Build failed in Jenkins: trafficcontrol-PR #4214

See Changes: [rob] Add TO Go ATS CDN configs [rob] Change atscfg ds name trimming to use funcs [rob] Delete broken TO API test (#3864) [rob] Fix Origins TO API tests [rob] Add consistent audit log messages

[GitHub] [trafficcontrol] asf-ci commented on issue #3911: To cache side configs plus cdns

asf-ci commented on issue #3911: To cache side configs plus cdns URL: https://github.com/apache/trafficcontrol/pull/3911#issuecomment-529046782 Refer to this link for build results (access rights to CI server needed): https://builds.apache.org/job/trafficcontrol-PR/4214/ Test

[GitHub] [trafficcontrol] rob05c opened a new pull request #3911: To cache side configs plus cdns

rob05c opened a new pull request #3911: To cache side configs plus cdns URL: https://github.com/apache/trafficcontrol/pull/3911 ## What does this PR (Pull Request) do? - [ ] This PR fixes #REPLACE_ME OR is not related to any Issue ## Which Traffic Control

[GitHub] [trafficcontrol] rob05c commented on issue #3733: CDN-in-a-Box now caches Carton dependencies by default

rob05c commented on issue #3733: CDN-in-a-Box now caches Carton dependencies by default URL: https://github.com/apache/trafficcontrol/pull/3733#issuecomment-529035679 I don't know how I missed this when it came in, but I just want to say, this is awesome. Should make builds drastically

[GitHub] [trafficcontrol] mitchell852 merged pull request #3733: CDN-in-a-Box now caches Carton dependencies by default

mitchell852 merged pull request #3733: CDN-in-a-Box now caches Carton dependencies by default URL: https://github.com/apache/trafficcontrol/pull/3733 This is an automated message from the Apache Git Service. To respond to

[GitHub] [trafficcontrol] dneuman64 opened a new issue #3910: Traffic Router does not allow RGB to be enabled on Client steering DSs

dneuman64 opened a new issue #3910: Traffic Router does not allow RGB to be enabled on Client steering DSs URL: https://github.com/apache/trafficcontrol/issues/3910 ## I'm submitting a ... - [ ] bug report - [ ] new feature / enhancement request - [ x]

[GitHub] [trafficcontrol] ocket8888 opened a new issue #3909: Network types should use inet

ocket opened a new issue #3909: Network types should use inet URL: https://github.com/apache/trafficcontrol/issues/3909 ## I'm submitting an improvement request (usability, performance, tech debt, etc.) ## Traffic Control components affected ... Traffic Ops ##

[GitHub] [trafficcontrol] ocket8888 edited a comment on issue #3908: Add deprecated message to cachegroup/:parameter_id/parameter resp

ocket edited a comment on issue #3908: Add deprecated message to cachegroup/:parameter_id/parameter resp URL: https://github.com/apache/trafficcontrol/pull/3908#issuecomment-529008786 RE: the docs deprecation stuff: I did that and I shouldn't have. When I was writing that endpoint's

[GitHub] [trafficcontrol] ocket8888 commented on issue #3908: Add deprecated message to cachegroup/:parameter_id/parameter resp

ocket commented on issue #3908: Add deprecated message to cachegroup/:parameter_id/parameter resp URL: https://github.com/apache/trafficcontrol/pull/3908#issuecomment-529008786 RE: the docs deprecation stuff: I did that and I shouldn't have. When I was writing that endpoint I'm sure I

[GitHub] [trafficcontrol] ocket8888 commented on issue #3799: Rewrite /hwinfo/dtdata to Go

ocket commented on issue #3799: Rewrite /hwinfo/dtdata to Go URL: https://github.com/apache/trafficcontrol/issues/3799#issuecomment-529008203 I think `hwinfo` in general isn't used, actually. And I'm fine with deprecating it, but "no re-write" is a separate discussion.

Build failed in Jenkins: trafficcontrol-3.1.x-rat #10

See -- Started by upstream project "trafficcontrol-3.1.x-build" build number 10 originally caused by: Started by an SCM change [EnvInject] - Loading node environment variables.

[GitHub] [trafficcontrol] rawlinp commented on issue #3908: Add deprecated message to cachegroup/:parameter_id/parameter resp

rawlinp commented on issue #3908: Add deprecated message to cachegroup/:parameter_id/parameter resp URL: https://github.com/apache/trafficcontrol/pull/3908#issuecomment-528999646 Cache Group Params in general probably can't be deprecated since I'm pretty sure we actually use and depend on

[GitHub] [trafficcontrol] rawlinp commented on issue #3799: Rewrite /hwinfo/dtdata to Go

rawlinp commented on issue #3799: Rewrite /hwinfo/dtdata to Go URL: https://github.com/apache/trafficcontrol/issues/3799#issuecomment-528983056 This one seems like a candidate for deprecation/removal (do not rewrite to Go). I think this endpoint was only used by the old Perl UI, but I

[GitHub] [trafficcontrol] asf-ci commented on issue #3908: Add deprecated message to cachegroup/:parameter_id/parameter resp

asf-ci commented on issue #3908: Add deprecated message to cachegroup/:parameter_id/parameter resp URL: https://github.com/apache/trafficcontrol/pull/3908#issuecomment-528980324 Refer to this link for build results (access rights to CI server needed):

[GitHub] [trafficcontrol] mhoppa commented on issue #3908: Add deprecated message to cachegroup/:parameter_id/parameter resp

mhoppa commented on issue #3908: Add deprecated message to cachegroup/:parameter_id/parameter resp URL: https://github.com/apache/trafficcontrol/pull/3908#issuecomment-528979753 @ocket I noticed it was already marked as such in the documentation

[GitHub] [trafficcontrol] ocket8888 commented on issue #3908: Add deprecated message to cachegroup/:parameter_id/parameter resp

ocket commented on issue #3908: Add deprecated message to cachegroup/:parameter_id/parameter resp URL: https://github.com/apache/trafficcontrol/pull/3908#issuecomment-528977438 I believe deprecations normally have to go through the mailing list. You probably wanna ask about Cache

[GitHub] [trafficcontrol] mhoppa opened a new pull request #3908: Add deprecated message to cachegroup/:parameter_id/parameter resp

mhoppa opened a new pull request #3908: Add deprecated message to cachegroup/:parameter_id/parameter resp URL: https://github.com/apache/trafficcontrol/pull/3908 ## What does this PR (Pull Request) do? - [x] This PR is not related to any Issue ## Which Traffic

[GitHub] [trafficcontrol] asf-ci commented on issue #3903: Rewrote /user/logout to Go

asf-ci commented on issue #3903: Rewrote /user/logout to Go URL: https://github.com/apache/trafficcontrol/pull/3903#issuecomment-528958785 Refer to this link for build results (access rights to CI server needed): https://builds.apache.org/job/trafficcontrol-PR/4212/ Test PASSed.

[GitHub] [trafficcontrol] asf-ci commented on issue #3894: Blueprint: new profile comparison/management view

asf-ci commented on issue #3894: Blueprint: new profile comparison/management view URL: https://github.com/apache/trafficcontrol/pull/3894#issuecomment-528957465 Refer to this link for build results (access rights to CI server needed):

[GitHub] [trafficcontrol] asf-ci commented on issue #3907: Add missing license headers to blueprints

asf-ci commented on issue #3907: Add missing license headers to blueprints URL: https://github.com/apache/trafficcontrol/pull/3907#issuecomment-528956134 Refer to this link for build results (access rights to CI server needed): https://builds.apache.org/job/trafficcontrol-PR/4210/

[GitHub] [trafficcontrol] asf-ci commented on issue #3688: Add TO Go remap.config

asf-ci commented on issue #3688: Add TO Go remap.config URL: https://github.com/apache/trafficcontrol/pull/3688#issuecomment-528954656 Refer to this link for build results (access rights to CI server needed): https://builds.apache.org/job/trafficcontrol-PR/4209/ Test PASSed.

[GitHub] [trafficcontrol] ocket8888 commented on a change in pull request #3894: Blueprint: new profile comparison/management view

ocket commented on a change in pull request #3894: Blueprint: new profile comparison/management view URL: https://github.com/apache/trafficcontrol/pull/3894#discussion_r321842042 ## File path: blueprints/profile-param-compare-manage.md ## @@ -0,0 +1,238 @@ + + +#

[GitHub] [trafficcontrol] rawlinp commented on issue #3762: Add Cache-Side Config Generator

rawlinp commented on issue #3762: Add Cache-Side Config Generator URL: https://github.com/apache/trafficcontrol/pull/3762#issuecomment-528939219 Where did we land on the idea to share code between the new atstccfg tool and the API and just replacing DB queries w/ API calls? Are we doing

[GitHub] [trafficcontrol] ocket8888 commented on a change in pull request #3762: Add Cache-Side Config Generator

ocket commented on a change in pull request #3762: Add Cache-Side Config Generator URL: https://github.com/apache/trafficcontrol/pull/3762#discussion_r321831927 ## File path: LICENSE ## @@ -440,3 +440,7 @@ For the lestrrat-go/jwx (commit e35178a) component: For the

[GitHub] [trafficcontrol] rawlinp commented on a change in pull request #3762: Add Cache-Side Config Generator

rawlinp commented on a change in pull request #3762: Add Cache-Side Config Generator URL: https://github.com/apache/trafficcontrol/pull/3762#discussion_r321831538 ## File path: LICENSE ## @@ -440,3 +440,7 @@ For the lestrrat-go/jwx (commit e35178a) component: For the

[GitHub] [trafficcontrol] mhoppa opened a new pull request #3907: Add missing license headers to blueprints

mhoppa opened a new pull request #3907: Add missing license headers to blueprints URL: https://github.com/apache/trafficcontrol/pull/3907 ## What does this PR (Pull Request) do? Adds missing license headers to blueprints - [x] This PR fixes #9001 OR is not related to any

[GitHub] [trafficcontrol] ocket8888 commented on issue #3762: Add Cache-Side Config Generator

ocket commented on issue #3762: Add Cache-Side Config Generator URL: https://github.com/apache/trafficcontrol/pull/3762#issuecomment-528937198 It also doesn't like the license of your `pkg` dependency: ``` ErrorBSD~!

[GitHub] [trafficcontrol] rob05c commented on a change in pull request #3688: Add TO Go remap.config

rob05c commented on a change in pull request #3688: Add TO Go remap.config URL: https://github.com/apache/trafficcontrol/pull/3688#discussion_r321830059 ## File path: lib/go-atscfg/remapdotconfig.go ## @@ -0,0 +1,369 @@ +package atscfg + +/* + * Licensed to the Apache

[GitHub] [trafficcontrol] rob05c commented on a change in pull request #3688: Add TO Go remap.config

rob05c commented on a change in pull request #3688: Add TO Go remap.config URL: https://github.com/apache/trafficcontrol/pull/3688#discussion_r321829883 ## File path: lib/go-atscfg/remapdotconfig.go ## @@ -0,0 +1,369 @@ +package atscfg + +/* + * Licensed to the Apache

[GitHub] [trafficcontrol] ocket8888 merged pull request #3906: Fix ordering in overview docs section

ocket merged pull request #3906: Fix ordering in overview docs section URL: https://github.com/apache/trafficcontrol/pull/3906 This is an automated message from the Apache Git Service. To respond to the message, please

[GitHub] [trafficcontrol] mitchell852 commented on issue #3904: Revalidate should be specific to the DS for which the invalidation request for submitted.

mitchell852 commented on issue #3904: Revalidate should be specific to the DS for which the invalidation request for submitted. URL: https://github.com/apache/trafficcontrol/issues/3904#issuecomment-528930690 regex_revalidate.config is a config file that is scoped at the cdn-level

[GitHub] [trafficcontrol] ocket8888 commented on issue #3762: Add Cache-Side Config Generator

ocket commented on issue #3762: Add Cache-Side Config Generator URL: https://github.com/apache/trafficcontrol/pull/3762#issuecomment-528928551 License header problems: ``` Error Unknown! traffic_ops/ort/atstccfg/urisigningconfig_test.go

[GitHub] [trafficcontrol] ocket8888 commented on a change in pull request #3906: Fix ordering in overview docs section

ocket commented on a change in pull request #3906: Fix ordering in overview docs section URL: https://github.com/apache/trafficcontrol/pull/3906#discussion_r321820271 ## File path: docs/source/overview/index.rst ## @@ -22,4 +22,12 @@ Introduces the Traffic Control

[GitHub] [trafficcontrol] ocket8888 commented on a change in pull request #3906: Fix ordering in overview docs section

ocket commented on a change in pull request #3906: Fix ordering in overview docs section URL: https://github.com/apache/trafficcontrol/pull/3906#discussion_r321819725 ## File path: docs/source/overview/index.rst ## @@ -22,4 +22,12 @@ Introduces the Traffic Control

[GitHub] [trafficcontrol] ocket8888 commented on a change in pull request #3906: Fix ordering in overview docs section

ocket commented on a change in pull request #3906: Fix ordering in overview docs section URL: https://github.com/apache/trafficcontrol/pull/3906#discussion_r321819842 ## File path: docs/source/overview/index.rst ## @@ -22,4 +22,12 @@ Introduces the Traffic Control

[GitHub] [trafficcontrol] asf-ci commented on issue #3906: Fix ordering in overview docs section

asf-ci commented on issue #3906: Fix ordering in overview docs section URL: https://github.com/apache/trafficcontrol/pull/3906#issuecomment-528912277 Refer to this link for build results (access rights to CI server needed): https://builds.apache.org/job/trafficcontrol-PR/4207/

[GitHub] [trafficcontrol] mhoppa opened a new pull request #3906: Fix ordering in overview docs section

mhoppa opened a new pull request #3906: Fix ordering in overview docs section URL: https://github.com/apache/trafficcontrol/pull/3906 ## What does this PR (Pull Request) do? Fix ordering in overview docs section Introduction was not first which makes it confusing to the end