[GitHub] [trafficcontrol] rimashah25 commented on pull request #7099: Delivery Service Active Flag Rework

rimashah25 commented on PR #7099: URL: https://github.com/apache/trafficcontrol/pull/7099#issuecomment-1270847030 Tested the API tests locally, all work (v3/v4/v5) fine. Yet to test DS DSRs creation with API v5 curl cmds. -- This is an automated message from the Apache Git Service. To

[GitHub] [trafficcontrol] shamrickus commented on a diff in pull request #7104: TP fix child DS tables not loading

shamrickus commented on code in PR #7104: URL: https://github.com/apache/trafficcontrol/pull/7104#discussion_r989386984 ## traffic_portal/app/src/common/modules/table/serviceCategoryDeliveryServices/table.serviceCategoryDeliveryServices.tpl.html: ## @@ -26,7 +26,6 @@

[GitHub] [trafficcontrol] zrhoffman commented on a diff in pull request #7109: Remove dnssec optimization flags from Traffic Router

zrhoffman commented on code in PR #7109: URL: https://github.com/apache/trafficcontrol/pull/7109#discussion_r989385185 ## traffic_router/core/src/main/java/org/apache/traffic_control/traffic_router/core/dns/ZoneManager.java: ## @@ -527,7 +527,7 @@ private static void

[GitHub] [trafficcontrol] shamrickus merged pull request #7102: Tpv2 server fix

shamrickus merged PR #7102: URL: https://github.com/apache/trafficcontrol/pull/7102 -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail:

[GitHub] [trafficcontrol] shamrickus commented on pull request #7102: Tpv2 server fix

shamrickus commented on PR #7102: URL: https://github.com/apache/trafficcontrol/pull/7102#issuecomment-1270546381 In that case we should make it do something other than `npm ci` (which also blows away node_modules on the host system I might add), but that's not relevant to this PR. --

[GitHub] [trafficcontrol] rimashah25 commented on a diff in pull request #7068: Renamed rascal to tm/traffic_monitor

rimashah25 commented on code in PR #7068: URL: https://github.com/apache/trafficcontrol/pull/7068#discussion_r989378882 ## traffic_ops/traffic_ops_golang/deliveryservice/capacity.go: ## @@ -249,7 +249,7 @@ JOIN server as s ON s.profile = pr.id JOIN cdn as c ON c.id = s.cdn_id

[GitHub] [trafficcontrol] rimashah25 commented on a diff in pull request #7068: Renamed rascal to tm/traffic_monitor

rimashah25 commented on code in PR #7068: URL: https://github.com/apache/trafficcontrol/pull/7068#discussion_r989371625 ## traffic_ops/traffic_ops_golang/server/servers.go: ## @@ -856,6 +856,12 @@ func getServers(h http.Header, params map[string]string, tx *sqlx.Tx, user *auth

[GitHub] [trafficcontrol] rimashah25 closed issue #5782: There is a vulnerability in log4j 1.2.17 ,upgrade recommended

rimashah25 closed issue #5782: There is a vulnerability in log4j 1.2.17 ,upgrade recommended URL: https://github.com/apache/trafficcontrol/issues/5782 -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go

[GitHub] [trafficcontrol] rimashah25 commented on issue #5782: There is a vulnerability in log4j 1.2.17 ,upgrade recommended

rimashah25 commented on issue #5782: URL: https://github.com/apache/trafficcontrol/issues/5782#issuecomment-1270503537 We have updated log4j to 2.17.1 (PR: #6390, #6438, #6445) -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub

[GitHub] [trafficcontrol] zrhoffman commented on a diff in pull request #7111: Delivery Service Regional field: Optionally make Max Origin Connections per Cache Group

zrhoffman commented on code in PR #7111: URL: https://github.com/apache/trafficcontrol/pull/7111#discussion_r989325834 ## CHANGELOG.md: ## @@ -12,6 +12,7 @@ The format is based on [Keep a Changelog](http://keepachangelog.com/en/1.0.0/). -

[GitHub] [trafficcontrol] zrhoffman commented on a diff in pull request #7111: Delivery Service Regional field: Optionally make Max Origin Connections per Cache Group

zrhoffman commented on code in PR #7111: URL: https://github.com/apache/trafficcontrol/pull/7111#discussion_r989324166 ## traffic_portal/app/src/common/modules/form/deliveryService/form.deliveryService.DNS.tpl.html: ## @@ -475,6 +475,26 @@ Previous Value

[GitHub] [trafficcontrol] zrhoffman commented on a diff in pull request #7111: Delivery Service Regional field: Optionally make Max Origin Connections per Cache Group

zrhoffman commented on code in PR #7111: URL: https://github.com/apache/trafficcontrol/pull/7111#discussion_r989319187 ## traffic_ops/app/db/migrations/2022100210472946_ds_regional.up.sql: ## @@ -0,0 +1,30 @@ +/* + * Licensed to the Apache Software Foundation (ASF) under one or

[GitHub] [trafficcontrol] ocket8888 commented on a diff in pull request #7111: Delivery Service Regional field: Optionally make Max Origin Connections per Cache Group

ocket commented on code in PR #7111: URL: https://github.com/apache/trafficcontrol/pull/7111#discussion_r989294749 ## CHANGELOG.md: ## @@ -12,6 +12,7 @@ The format is based on [Keep a Changelog](http://keepachangelog.com/en/1.0.0/). -

[GitHub] [trafficcontrol] ocket8888 commented on a diff in pull request #7111: Delivery Service Regional field: Optionally make Max Origin Connections per Cache Group

ocket commented on code in PR #7111: URL: https://github.com/apache/trafficcontrol/pull/7111#discussion_r989293452 ## traffic_ops/app/db/migrations/2022100210472946_ds_regional.up.sql: ## @@ -0,0 +1,30 @@ +/* + * Licensed to the Apache Software Foundation (ASF) under one or

[GitHub] [trafficcontrol] ocket8888 commented on a diff in pull request #7111: Delivery Service Regional field: Optionally make Max Origin Connections per Cache Group

ocket commented on code in PR #7111: URL: https://github.com/apache/trafficcontrol/pull/7111#discussion_r989293452 ## traffic_ops/app/db/migrations/2022100210472946_ds_regional.up.sql: ## @@ -0,0 +1,30 @@ +/* + * Licensed to the Apache Software Foundation (ASF) under one or

[GitHub] [trafficcontrol] zrhoffman commented on a diff in pull request #7111: Delivery Service Regional field: Optionally make Max Origin Connections per Cache Group

zrhoffman commented on code in PR #7111: URL: https://github.com/apache/trafficcontrol/pull/7111#discussion_r989277863 ## docs/source/overview/delivery_services.rst: ## @@ -505,6 +505,9 @@ Max Origin Connections -- The maximum number of TCP connections

[GitHub] [trafficcontrol] zrhoffman commented on a diff in pull request #7111: Delivery Service Regional field: Optionally make Max Origin Connections per Cache Group

zrhoffman commented on code in PR #7111: URL: https://github.com/apache/trafficcontrol/pull/7111#discussion_r989260025 ## traffic_ops/app/db/migrations/2022100210472946_ds_regional.up.sql: ## @@ -0,0 +1,30 @@ +/* + * Licensed to the Apache Software Foundation (ASF) under one or

[GitHub] [trafficcontrol] zrhoffman commented on a diff in pull request #7111: Delivery Service Regional field: Optionally make Max Origin Connections per Cache Group

zrhoffman commented on code in PR #7111: URL: https://github.com/apache/trafficcontrol/pull/7111#discussion_r989252029 ## CHANGELOG.md: ## @@ -12,6 +12,7 @@ The format is based on [Keep a Changelog](http://keepachangelog.com/en/1.0.0/). -

[GitHub] [trafficcontrol] ocket8888 commented on a diff in pull request #7111: Delivery Service Regional field: Optionally make Max Origin Connections per Cache Group

ocket commented on code in PR #7111: URL: https://github.com/apache/trafficcontrol/pull/7111#discussion_r989135302 ## CHANGELOG.md: ## @@ -12,6 +12,7 @@ The format is based on [Keep a Changelog](http://keepachangelog.com/en/1.0.0/). -

[GitHub] [trafficcontrol] zrhoffman commented on pull request #7111: Delivery Service Regional field: Optionally make Max Origin Connections per Cache Group

zrhoffman commented on PR #7111: URL: https://github.com/apache/trafficcontrol/pull/7111#issuecomment-1270196692 Added the Regional field to Traffic Portal v1 in 9b4c1f3f2e -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and

[GitHub] [trafficcontrol] ocket8888 commented on pull request #7102: Tpv2 server fix

ocket commented on PR #7102: URL: https://github.com/apache/trafficcontrol/pull/7102#issuecomment-1270168821 no, the developer environment is for development, so using the development angular server seems more appropriate to me. -- This is an automated message from the Apache Git