[GitHub] [trafficcontrol] ocket8888 merged pull request #7175: Dev CiaB: Prefix Traffic Monitor profile name with TM profile prefix

2022-11-07 Thread GitBox
ocket merged PR #7175: URL: https://github.com/apache/trafficcontrol/pull/7175 -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail:

[GitHub] [trafficcontrol] zrhoffman opened a new pull request, #7176: ATC build system: aarch64 support

2022-11-07 Thread GitBox
zrhoffman opened a new pull request, #7176: URL: https://github.com/apache/trafficcontrol/pull/7176 This PR - Replaces cases where the build architecture is hard-coded as `x86_64` with code that checks what the CPU architecture is - Replaces build code using `uname -a` with

[GitHub] [trafficcontrol] mitchell852 commented on issue #7094: Routing Name can be changed to default

2022-11-07 Thread GitBox
mitchell852 commented on issue #7094: URL: https://github.com/apache/trafficcontrol/issues/7094#issuecomment-1305848442 > This isn't real what's not real? :) The issue doesn't exist? -- This is an automated message from the Apache Git Service. To respond to the message,

[GitHub] [trafficcontrol] zrhoffman commented on pull request #4074: Set Content-Length header in Traffic Router

2022-11-07 Thread GitBox
zrhoffman commented on PR #4074: URL: https://github.com/apache/trafficcontrol/pull/4074#issuecomment-1305847642 The *TR Ultimate Test Harness* workflow fails on the master branch (and on #4074), fixed by #7175. -- This is an automated message from the Apache Git Service. To respond to

[GitHub] [trafficcontrol] zrhoffman opened a new pull request, #7175: Dev CiaB: Prefix Traffic Monitor profile name with TM profile prefix

2022-11-07 Thread GitBox
zrhoffman opened a new pull request, #7175: URL: https://github.com/apache/trafficcontrol/pull/7175 This PR fixes an issue in CDN in a Box for Developers where `monitoring.json` does not contain any parameters. This makes the *TR Ultimate Test Harness* GitHub Actions workflow

[GitHub] [trafficcontrol] bdgranger closed issue #4894: non-standard httpsPort not appended to domain name in remap.config line

2022-11-05 Thread GitBox
bdgranger closed issue #4894: non-standard httpsPort not appended to domain name in remap.config line URL: https://github.com/apache/trafficcontrol/issues/4894 -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL

[GitHub] [trafficcontrol] bdgranger commented on issue #4894: non-standard httpsPort not appended to domain name in remap.config line

2022-11-05 Thread GitBox
bdgranger commented on issue #4894: URL: https://github.com/apache/trafficcontrol/issues/4894#issuecomment-1304693283 @zrhoffman it appears this has been addressed in more recent releases. Closing this issue. Thanks! -- This is an automated message from the Apache Git Service. To

[GitHub] [trafficcontrol] zrhoffman commented on a diff in pull request #4074: Set Content-Length header in Traffic Router

2022-11-04 Thread GitBox
zrhoffman commented on code in PR #4074: URL: https://github.com/apache/trafficcontrol/pull/4074#discussion_r1014491685 ## traffic_router/core/src/main/java/org/apache/traffic_control/traffic_router/core/http/BufferedResponseFilter.java: ## @@ -0,0 +1,46 @@ +/* + * + * Licensed

[GitHub] [trafficcontrol] zrhoffman commented on pull request #4074: Set Content-Length header in Traffic Router

2022-11-04 Thread GitBox
zrhoffman commented on PR #4074: URL: https://github.com/apache/trafficcontrol/pull/4074#issuecomment-1304290033 Rebased to fix a changelog merge conflict -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above

[GitHub] [trafficcontrol] zrhoffman commented on a diff in pull request #4074: Set Content-Length header in Traffic Router

2022-11-04 Thread GitBox
zrhoffman commented on code in PR #4074: URL: https://github.com/apache/trafficcontrol/pull/4074#discussion_r1014488500 ## traffic_router/core/src/main/java/org/apache/traffic_control/traffic_router/core/http/BufferedResponseFilter.java: ## @@ -0,0 +1,46 @@ +/* + * + * Licensed

[GitHub] [trafficcontrol] rawlinp commented on a diff in pull request #4074: Set Content-Length header in Traffic Router

2022-11-04 Thread GitBox
rawlinp commented on code in PR #4074: URL: https://github.com/apache/trafficcontrol/pull/4074#discussion_r1014482794 ## traffic_router/core/src/main/java/org/apache/traffic_control/traffic_router/core/http/BufferedResponseFilter.java: ## @@ -0,0 +1,46 @@ +/* + * + * Licensed

[GitHub] [trafficcontrol] ocket8888 closed issue #7094: Routing Name can be changed to default

2022-11-04 Thread GitBox
ocket closed issue #7094: Routing Name can be changed to default URL: https://github.com/apache/trafficcontrol/issues/7094 -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment.

[GitHub] [trafficcontrol] ocket8888 commented on issue #7094: Routing Name can be changed to default

2022-11-04 Thread GitBox
ocket commented on issue #7094: URL: https://github.com/apache/trafficcontrol/issues/7094#issuecomment-1304267624 This isn't real -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the

[GitHub] [trafficcontrol] srijeet0406 merged pull request #7034: ASN test fixes

2022-11-04 Thread GitBox
srijeet0406 merged PR #7034: URL: https://github.com/apache/trafficcontrol/pull/7034 -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail:

[GitHub] [trafficcontrol] srijeet0406 closed issue #7033: `ASN` test fixtures seem to be broken

2022-11-04 Thread GitBox
srijeet0406 closed issue #7033: `ASN` test fixtures seem to be broken URL: https://github.com/apache/trafficcontrol/issues/7033 -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment.

[GitHub] [trafficcontrol] ocket8888 commented on a diff in pull request #4074: Set Content-Length header in Traffic Router

2022-11-04 Thread GitBox
ocket commented on code in PR #4074: URL: https://github.com/apache/trafficcontrol/pull/4074#discussion_r1014468019 ## traffic_router/core/src/main/java/org/apache/traffic_control/traffic_router/core/http/BufferedResponseFilter.java: ## @@ -0,0 +1,46 @@ +/* + * + * Licensed

[GitHub] [trafficcontrol] ocket8888 merged pull request #7173: Update TO tests README

2022-11-04 Thread GitBox
ocket merged PR #7173: URL: https://github.com/apache/trafficcontrol/pull/7173 -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail:

[GitHub] [trafficcontrol] zrhoffman commented on a diff in pull request #4074: Set Content-Length header in Traffic Router

2022-11-04 Thread GitBox
zrhoffman commented on code in PR #4074: URL: https://github.com/apache/trafficcontrol/pull/4074#discussion_r1014462885 ## traffic_router/core/src/test/java/org/apache/traffic_control/traffic_router/core/external/BufferedResponseTest.java: ## @@ -0,0 +1,183 @@ +/* + * + *

[GitHub] [trafficcontrol] ocket8888 commented on a diff in pull request #4074: Set Content-Length header in Traffic Router

2022-11-04 Thread GitBox
ocket commented on code in PR #4074: URL: https://github.com/apache/trafficcontrol/pull/4074#discussion_r1014461623 ## traffic_router/core/src/test/java/org/apache/traffic_control/traffic_router/core/external/BufferedResponseTest.java: ## @@ -0,0 +1,183 @@ +/* + * + *

[GitHub] [trafficcontrol] zrhoffman commented on a diff in pull request #4074: Set Content-Length header in Traffic Router

2022-11-04 Thread GitBox
zrhoffman commented on code in PR #4074: URL: https://github.com/apache/trafficcontrol/pull/4074#discussion_r1014447675 ## traffic_router/core/src/test/java/org/apache/traffic_control/traffic_router/core/external/BufferedResponseTest.java: ## @@ -0,0 +1,183 @@ +/* + * + *

[GitHub] [trafficcontrol] zrhoffman commented on a diff in pull request #4074: Set Content-Length header in Traffic Router

2022-11-04 Thread GitBox
zrhoffman commented on code in PR #4074: URL: https://github.com/apache/trafficcontrol/pull/4074#discussion_r1014437701 ## traffic_router/core/src/test/java/org/apache/traffic_control/traffic_router/core/external/LocationsTest.java: ## @@ -139,4 +144,38 @@ public void

[GitHub] [trafficcontrol] zrhoffman commented on a diff in pull request #4074: Set Content-Length header in Traffic Router

2022-11-04 Thread GitBox
zrhoffman commented on code in PR #4074: URL: https://github.com/apache/trafficcontrol/pull/4074#discussion_r1014435327 ## traffic_router/core/src/test/java/org/apache/traffic_control/traffic_router/core/external/BufferedResponseTest.java: ## @@ -0,0 +1,183 @@ +/* + * + *

[GitHub] [trafficcontrol] zrhoffman commented on a diff in pull request #4074: Set Content-Length header in Traffic Router

2022-11-04 Thread GitBox
zrhoffman commented on code in PR #4074: URL: https://github.com/apache/trafficcontrol/pull/4074#discussion_r1014435327 ## traffic_router/core/src/test/java/org/apache/traffic_control/traffic_router/core/external/BufferedResponseTest.java: ## @@ -0,0 +1,183 @@ +/* + * + *

[GitHub] [trafficcontrol] zrhoffman commented on a diff in pull request #4074: Set Content-Length header in Traffic Router

2022-11-04 Thread GitBox
zrhoffman commented on code in PR #4074: URL: https://github.com/apache/trafficcontrol/pull/4074#discussion_r1014434382 ## traffic_router/core/src/test/java/org/apache/traffic_control/traffic_router/core/external/BufferedResponseTest.java: ## @@ -0,0 +1,183 @@ +/* + * + *

[GitHub] [trafficcontrol] zrhoffman commented on a diff in pull request #4074: Set Content-Length header in Traffic Router

2022-11-04 Thread GitBox
zrhoffman commented on code in PR #4074: URL: https://github.com/apache/trafficcontrol/pull/4074#discussion_r1014433593 ## traffic_router/core/src/test/java/org/apache/traffic_control/traffic_router/core/external/BufferedResponseTest.java: ## @@ -0,0 +1,183 @@ +/* + * + *

[GitHub] [trafficcontrol] zrhoffman commented on a diff in pull request #4074: Set Content-Length header in Traffic Router

2022-11-04 Thread GitBox
zrhoffman commented on code in PR #4074: URL: https://github.com/apache/trafficcontrol/pull/4074#discussion_r1014432012 ## traffic_router/core/src/test/java/org/apache/traffic_control/traffic_router/core/external/BufferedResponseTest.java: ## @@ -0,0 +1,183 @@ +/* + * + *

[GitHub] [trafficcontrol] zrhoffman commented on a diff in pull request #4074: Set Content-Length header in Traffic Router

2022-11-04 Thread GitBox
zrhoffman commented on code in PR #4074: URL: https://github.com/apache/trafficcontrol/pull/4074#discussion_r1014431802 ## traffic_router/core/src/test/java/org/apache/traffic_control/traffic_router/core/external/BufferedResponseTest.java: ## @@ -0,0 +1,183 @@ +/* + * + *

[GitHub] [trafficcontrol] zrhoffman commented on a diff in pull request #4074: Set Content-Length header in Traffic Router

2022-11-04 Thread GitBox
zrhoffman commented on code in PR #4074: URL: https://github.com/apache/trafficcontrol/pull/4074#discussion_r1014431615 ## traffic_router/core/src/test/java/org/apache/traffic_control/traffic_router/core/external/BufferedResponseTest.java: ## @@ -0,0 +1,183 @@ +/* + * + *

[GitHub] [trafficcontrol] rimashah25 opened a new pull request, #7174: Fixed sort in topologies table, in a DS form for topologies and DSCP and tool tip (Max DNS) opens in a new page

2022-11-04 Thread GitBox
rimashah25 opened a new pull request, #7174: URL: https://github.com/apache/trafficcontrol/pull/7174 Closes: #5970 #5971 ## Which Traffic Control components are affected by this PR? - Traffic Portal ## What is the best way to verify this PR?

[GitHub] [trafficcontrol] zrhoffman commented on a diff in pull request #4074: Set Content-Length header in Traffic Router

2022-11-04 Thread GitBox
zrhoffman commented on code in PR #4074: URL: https://github.com/apache/trafficcontrol/pull/4074#discussion_r1014425725 ## traffic_router/core/src/main/java/org/apache/traffic_control/traffic_router/core/http/BufferedResponseFilter.java: ## @@ -0,0 +1,46 @@ +/* + * + * Licensed

[GitHub] [trafficcontrol] zrhoffman closed pull request #4096: TR: Send reason-phrase for HTTP API responses

2022-11-04 Thread GitBox
zrhoffman closed pull request #4096: TR: Send reason-phrase for HTTP API responses URL: https://github.com/apache/trafficcontrol/pull/4096 -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the

[GitHub] [trafficcontrol] zrhoffman commented on pull request #4096: TR: Send reason-phrase for HTTP API responses

2022-11-04 Thread GitBox
zrhoffman commented on PR #4096: URL: https://github.com/apache/trafficcontrol/pull/4096#issuecomment-1304107497 We're using Tomcat 9, which removes reason-phrases altogether, to #4096 is no longer needed. -- This is an automated message from the Apache Git Service. To respond to the

[GitHub] [trafficcontrol] ocket8888 commented on pull request #7099: Delivery Service Active Flag Rework

2022-11-04 Thread GitBox
ocket commented on PR #7099: URL: https://github.com/apache/trafficcontrol/pull/7099#issuecomment-1304011270 It looks like I accidentally removed `regional` from the docs when I rebased them after it was added, so I'll fix that and the migration timestamps. Other than that: >

[GitHub] [trafficcontrol] ericholguin commented on a diff in pull request #7173: Update TO tests README

2022-11-04 Thread GitBox
ericholguin commented on code in PR #7173: URL: https://github.com/apache/trafficcontrol/pull/7173#discussion_r1014366401 ## traffic_ops/testing/api/README.md: ## @@ -17,86 +17,101 @@ under the License. --> -# Traffic Ops API Tests +# Traffic Ops Client / API

[GitHub] [trafficcontrol] ericholguin commented on a diff in pull request #7173: Update TO tests README

2022-11-04 Thread GitBox
ericholguin commented on code in PR #7173: URL: https://github.com/apache/trafficcontrol/pull/7173#discussion_r1014362094 ## traffic_ops/testing/api/README.md: ## @@ -17,86 +17,101 @@ under the License. --> -# Traffic Ops API Tests +# Traffic Ops Client / API

[GitHub] [trafficcontrol] ocket8888 commented on a diff in pull request #7173: Update TO tests README

2022-11-04 Thread GitBox
ocket commented on code in PR #7173: URL: https://github.com/apache/trafficcontrol/pull/7173#discussion_r1014340359 ## traffic_ops/testing/api/README.md: ## @@ -17,86 +17,101 @@ under the License. --> -# Traffic Ops API Tests +# Traffic Ops Client / API Integration

[GitHub] [trafficcontrol] ericholguin opened a new pull request, #7173: Update TO tests README

2022-11-04 Thread GitBox
ericholguin opened a new pull request, #7173: URL: https://github.com/apache/trafficcontrol/pull/7173 Updates the TO test readme ## Which Traffic Control components are affected by this PR? - Documentation ## What is the best way to verify this PR?

[GitHub] [trafficcontrol] rimashah25 commented on a diff in pull request #7099: Delivery Service Active Flag Rework

2022-11-04 Thread GitBox
rimashah25 commented on code in PR #7099: URL: https://github.com/apache/trafficcontrol/pull/7099#discussion_r1013557339 ## docs/source/api/v5/deliveryservice_requests.rst: ## @@ -159,38 +175,111 @@ The response is an array of representations of :term:`Delivery Service

[GitHub] [trafficcontrol] ocket8888 merged pull request #7163: Fix t3c multiple profile generation

2022-11-04 Thread GitBox
ocket merged PR #7163: URL: https://github.com/apache/trafficcontrol/pull/7163 -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail:

[GitHub] [trafficcontrol] ocket8888 commented on a diff in pull request #7136: TO `deliveryservice/sslkeys/add` verify certificate chain

2022-11-04 Thread GitBox
ocket commented on code in PR #7136: URL: https://github.com/apache/trafficcontrol/pull/7136#discussion_r1014224466 ## traffic_ops/testing/api/v5/deliveryservices_keys_test.go: ## @@ -333,6 +334,38 @@ func DeliveryServiceSSLKeys(t *testing.T) { if

[GitHub] [trafficcontrol] rimashah25 commented on pull request #7099: Delivery Service Active Flag Rework

2022-11-03 Thread GitBox
rimashah25 commented on PR #7099: URL: https://github.com/apache/trafficcontrol/pull/7099#issuecomment-1302958291 Tested and reviewed the following: 1. Able to create DS with 3 states (Active, Primed, Inactive) using APIv5 2. Able to create DS with 2 states (as expected) (Active=true,

[GitHub] [trafficcontrol] rob05c commented on pull request #7167: Fix t3c test duplication and upgrade to v4

2022-11-03 Thread GitBox
rob05c commented on PR #7167: URL: https://github.com/apache/trafficcontrol/pull/7167#issuecomment-1302711780 It'd be really good to do this to v5 as well, so the t3c Integration Tests can easily share that too, when it comes time to upgrade them. But that can be done separately. --

[GitHub] [trafficcontrol] rimashah25 commented on a diff in pull request #7099: Delivery Service Active Flag Rework

2022-11-03 Thread GitBox
rimashah25 commented on code in PR #7099: URL: https://github.com/apache/trafficcontrol/pull/7099#discussion_r1009828166 ## traffic_ops/traffic_ops_golang/deliveryservice/deliveryservices.go: ## @@ -138,7 +162,7 @@ func CreateV30(w http.ResponseWriter, r *http.Request) {

[GitHub] [trafficcontrol] ocket8888 commented on pull request #7099: Delivery Service Active Flag Rework

2022-11-03 Thread GitBox
ocket commented on PR #7099: URL: https://github.com/apache/trafficcontrol/pull/7099#issuecomment-1302550947 I need to change the migration file names because new migrations have been added since this PR opened. I'm in a meeting atm, I'll do it this afternoon. -- This is an automated

[GitHub] [trafficcontrol] ocket8888 commented on a diff in pull request #7099: Delivery Service Active Flag Rework

2022-11-03 Thread GitBox
ocket commented on code in PR #7099: URL: https://github.com/apache/trafficcontrol/pull/7099#discussion_r1013301078 ## traffic_ops/traffic_ops_golang/deliveryservice/deliveryservices.go: ## @@ -138,7 +162,7 @@ func CreateV30(w http.ResponseWriter, r *http.Request) {

[GitHub] [trafficcontrol] ocket8888 merged pull request #7170: Use tonistiigi/binfmt to emulate arm64

2022-11-03 Thread GitBox
ocket merged PR #7170: URL: https://github.com/apache/trafficcontrol/pull/7170 -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail:

[GitHub] [trafficcontrol] ocket8888 commented on a diff in pull request #7169: Update TPv2 dependencies and node version

2022-11-03 Thread GitBox
ocket commented on code in PR #7169: URL: https://github.com/apache/trafficcontrol/pull/7169#discussion_r1013031890 ## experimental/traffic-portal/package.json: ## @@ -1,119 +1,119 @@ { - "name": "traffic-portal", - "version": "0.4.1", - "description": "The web UI for

[GitHub] [trafficcontrol] zrhoffman merged pull request #7172: Renamed rascal migration file to get latest time stamp

2022-11-02 Thread GitBox
zrhoffman merged PR #7172: URL: https://github.com/apache/trafficcontrol/pull/7172 -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail:

[GitHub] [trafficcontrol] rimashah25 opened a new pull request, #7172: Renamed rascal migration file to get latest time stamp

2022-11-02 Thread GitBox
rimashah25 opened a new pull request, #7172: URL: https://github.com/apache/trafficcontrol/pull/7172 Not related to any issue. ## Which Traffic Control components are affected by this PR? - Traffic Ops DB ## What is the best way to verify this PR? Run

[GitHub] [trafficcontrol] ocket8888 commented on a diff in pull request #4074: Set Content-Length header in Traffic Router

2022-11-02 Thread GitBox
ocket commented on code in PR #4074: URL: https://github.com/apache/trafficcontrol/pull/4074#discussion_r1012331738 ## traffic_router/core/src/main/java/org/apache/traffic_control/traffic_router/core/http/BufferedResponseFilter.java: ## @@ -0,0 +1,46 @@ +/* + * + * Licensed

[GitHub] [trafficcontrol] ocket8888 commented on a diff in pull request #4074: Set Content-Length header in Traffic Router

2022-11-02 Thread GitBox
ocket commented on code in PR #4074: URL: https://github.com/apache/trafficcontrol/pull/4074#discussion_r1012327712 ## traffic_router/core/src/test/java/org/apache/traffic_control/traffic_router/core/external/LocationsTest.java: ## @@ -139,4 +144,38 @@ public void

[GitHub] [trafficcontrol] zrhoffman merged pull request #7171: Changed Test Parameters password to not be hard coded, and instead re…

2022-11-02 Thread GitBox
zrhoffman merged PR #7171: URL: https://github.com/apache/trafficcontrol/pull/7171 -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail:

[GitHub] [trafficcontrol] ocket8888 commented on a diff in pull request #4074: Set Content-Length header in Traffic Router

2022-11-02 Thread GitBox
ocket commented on code in PR #4074: URL: https://github.com/apache/trafficcontrol/pull/4074#discussion_r1012310003 ## traffic_router/core/src/main/java/org/apache/traffic_control/traffic_router/core/http/BufferedResponseFilter.java: ## @@ -0,0 +1,46 @@ +/* + * + * Licensed

[GitHub] [trafficcontrol] ocket8888 commented on a diff in pull request #4074: Set Content-Length header in Traffic Router

2022-11-02 Thread GitBox
ocket commented on code in PR #4074: URL: https://github.com/apache/trafficcontrol/pull/4074#discussion_r1012310003 ## traffic_router/core/src/main/java/org/apache/traffic_control/traffic_router/core/http/BufferedResponseFilter.java: ## @@ -0,0 +1,46 @@ +/* + * + * Licensed

[GitHub] [trafficcontrol] kdamichie opened a new pull request, #7171: Changed Test Parameters password to not be hard coded, and instead re…

2022-11-02 Thread GitBox
kdamichie opened a new pull request, #7171: URL: https://github.com/apache/trafficcontrol/pull/7171 > This PR changes type parameters to replace hard coded password, and instead reference the user's > > ## Which Traffic Control components are affected by this PR? > * Traffic Ops -

[GitHub] [trafficcontrol] srijeet0406 merged pull request #7114: Refactor Snapshot Tests

2022-11-02 Thread GitBox
srijeet0406 merged PR #7114: URL: https://github.com/apache/trafficcontrol/pull/7114 -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail:

[GitHub] [trafficcontrol] rob05c merged pull request #7153: T3c bad cert check

2022-11-02 Thread GitBox
rob05c merged PR #7153: URL: https://github.com/apache/trafficcontrol/pull/7153 -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail:

[GitHub] [trafficcontrol] zrhoffman commented on a diff in pull request #4074: Set Content-Length header in Traffic Router

2022-11-02 Thread GitBox
zrhoffman commented on code in PR #4074: URL: https://github.com/apache/trafficcontrol/pull/4074#discussion_r1011972764 ## traffic_router/core/src/main/java/org/apache/traffic_control/traffic_router/core/http/BufferedResponseFilter.java: ## @@ -0,0 +1,46 @@ +/* + * + * Licensed

[GitHub] [trafficcontrol] zrhoffman opened a new pull request, #7170: Use tonistiigi/binfmt to emulate arm64

2022-11-02 Thread GitBox
zrhoffman opened a new pull request, #7170: URL: https://github.com/apache/trafficcontrol/pull/7170 This PR updates the `ghcr.io/apache/trafficcontrol/ci/trafficserver-alpine`-building workflow to use tonistiigi/binfmt to emulate aarch64, which saves an hour of build time.

[GitHub] [trafficcontrol] rob05c merged pull request #7137: T3C parent.config simulate topology for non topo delivery services

2022-11-02 Thread GitBox
rob05c merged PR #7137: URL: https://github.com/apache/trafficcontrol/pull/7137 -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail:

[GitHub] [trafficcontrol] ocket8888 merged pull request #7165: arm64 support for Dev CiaB's prebuilt trafficserver image

2022-11-01 Thread GitBox
ocket merged PR #7165: URL: https://github.com/apache/trafficcontrol/pull/7165 -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail:

[GitHub] [trafficcontrol] shamrickus opened a new pull request, #7169: Update TPv2 dependencies and node version

2022-11-01 Thread GitBox
shamrickus opened a new pull request, #7169: URL: https://github.com/apache/trafficcontrol/pull/7169 This PR updates TPv2 from early v14 to latest v14, in doing so allowing us to switch to an active support node version. It also updates the package.json to use tabs (which npm now

[GitHub] [trafficcontrol] zrhoffman commented on a diff in pull request #7165: arm64 support for Dev CiaB's prebuilt trafficserver image

2022-11-01 Thread GitBox
zrhoffman commented on code in PR #7165: URL: https://github.com/apache/trafficcontrol/pull/7165#discussion_r1010973449 ## .github/containers/trafficserver-alpine/docker-compose.yml: ## @@ -23,5 +23,22 @@ services: dockerfile: Dockerfile args:

[GitHub] [trafficcontrol] ocket8888 commented on pull request #7165: arm64 support for Dev CiaB's prebuilt trafficserver image

2022-11-01 Thread GitBox
ocket commented on PR #7165: URL: https://github.com/apache/trafficcontrol/pull/7165#issuecomment-1299321783 Assuming ericholguin has checked that this works on an arm processor (I don't have one that I wouldn't have to dig out of storage atm) then it's working fine. -- This is an

[GitHub] [trafficcontrol] ocket8888 commented on a diff in pull request #7165: arm64 support for Dev CiaB's prebuilt trafficserver image

2022-11-01 Thread GitBox
ocket commented on code in PR #7165: URL: https://github.com/apache/trafficcontrol/pull/7165#discussion_r1010955114 ## .github/containers/trafficserver-alpine/docker-compose.yml: ## @@ -23,5 +23,22 @@ services: dockerfile: Dockerfile args:

[GitHub] [trafficcontrol] ocket8888 merged pull request #7164: Pin node version in dev ciab TP/TPv2

2022-11-01 Thread GitBox
ocket merged PR #7164: URL: https://github.com/apache/trafficcontrol/pull/7164 -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail:

[GitHub] [trafficcontrol] ocket8888 commented on pull request #7164: Pin node version in dev ciab TP/TPv2

2022-11-01 Thread GitBox
ocket commented on PR #7164: URL: https://github.com/apache/trafficcontrol/pull/7164#issuecomment-1299300701 Well, I don't know what exactly the issue was, but after 7 hours there was still nothing in the logs. So I purged my docker cache, removed most directories from my local repo

[GitHub] [trafficcontrol] ocket8888 closed issue #2564: Legacy Naming Conventions (Rascal, RIAK, CCR et. al.)

2022-11-01 Thread GitBox
ocket closed issue #2564: Legacy Naming Conventions (Rascal, RIAK, CCR et. al.) URL: https://github.com/apache/trafficcontrol/issues/2564 -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the

[GitHub] [trafficcontrol] ocket8888 merged pull request #7068: Renamed rascal to tm/traffic_monitor

2022-11-01 Thread GitBox
ocket merged PR #7068: URL: https://github.com/apache/trafficcontrol/pull/7068 -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail:

[GitHub] [trafficcontrol] zrhoffman merged pull request #7168: Update Go version to 1.19.3

2022-11-01 Thread GitBox
zrhoffman merged PR #7168: URL: https://github.com/apache/trafficcontrol/pull/7168 -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail:

[GitHub] [trafficcontrol] zrhoffman commented on pull request #7164: Pin node version in dev ciab TP/TPv2

2022-11-01 Thread GitBox
zrhoffman commented on PR #7164: URL: https://github.com/apache/trafficcontrol/pull/7164#issuecomment-1299046154 > When I run the dev env on this branch, Traffic Router and tpv2 fail to start. Both TR and TPv2 start as expected for me on Linux on #7164's branch -- This is an

[GitHub] [trafficcontrol] shamrickus commented on pull request #7164: Pin node version in dev ciab TP/TPv2

2022-11-01 Thread GitBox
shamrickus commented on PR #7164: URL: https://github.com/apache/trafficcontrol/pull/7164#issuecomment-1299019963 > No it's not displaying anything, at all. Like I would show you the logs but they're literally empty. Assuming the container is still running, I stand by what I said. It

[GitHub] [trafficcontrol] ocket8888 commented on pull request #7164: Pin node version in dev ciab TP/TPv2

2022-11-01 Thread GitBox
ocket commented on PR #7164: URL: https://github.com/apache/trafficcontrol/pull/7164#issuecomment-1298972615 No it's not displaying anything, at all. Like I would show you the logs but they're literally empty. -- This is an automated message from the Apache Git Service. To respond to

[GitHub] [trafficcontrol] asf-ci opened a new pull request, #7168: Update Go version to 1.19.3

2022-11-01 Thread GitBox
asf-ci opened a new pull request, #7168: URL: https://github.com/apache/trafficcontrol/pull/7168 ## What does this PR (Pull Request) do? This PR makes the Go components of Traffic Control build using Go version 1.19.3 and updates the `golang.org/x/` dependencies. See the Go

[GitHub] [trafficcontrol] rob05c commented on pull request #7163: Fix t3c multiple profile generation

2022-11-01 Thread GitBox
rob05c commented on PR #7163: URL: https://github.com/apache/trafficcontrol/pull/7163#issuecomment-1298903906 I don't think this is really low-impact. It breaks config gen for all servers with multiple profiles assigned -- This is an automated message from the Apache Git Service. To

[GitHub] [trafficcontrol] github-code-scanning[bot] commented on a diff in pull request #7161: DTP open sourcing

2022-11-01 Thread GitBox
github-code-scanning[bot] commented on code in PR #7161: URL: https://github.com/apache/trafficcontrol/pull/7161#discussion_r1010694310 ## test/fakeOrigin/dtp/dtp.go: ## @@ -0,0 +1,127 @@ +package dtp + +/* + * Licensed to the Apache Software Foundation (ASF) under one + * or

[GitHub] [trafficcontrol] zrhoffman commented on a diff in pull request #7161: DTP open sourcing

2022-11-01 Thread GitBox
zrhoffman commented on code in PR #7161: URL: https://github.com/apache/trafficcontrol/pull/7161#discussion_r1010679145 ## test/fakeOrigin/dtp/bin.go: ## @@ -0,0 +1,86 @@ +package dtp + +/* + * Licensed to the Apache Software Foundation (ASF) under one + * or more contributor

[GitHub] [trafficcontrol] ezelkow1 commented on a diff in pull request #7161: DTP open sourcing

2022-11-01 Thread GitBox
ezelkow1 commented on code in PR #7161: URL: https://github.com/apache/trafficcontrol/pull/7161#discussion_r1010656437 ## test/fakeOrigin/dtp/dtp.go: ## @@ -0,0 +1,130 @@ +package dtp + +/* + * Licensed to the Apache Software Foundation (ASF) under one + * or more contributor

[GitHub] [trafficcontrol] ezelkow1 commented on a diff in pull request #7161: DTP open sourcing

2022-11-01 Thread GitBox
ezelkow1 commented on code in PR #7161: URL: https://github.com/apache/trafficcontrol/pull/7161#discussion_r1010640858 ## test/fakeOrigin/dtp/dtp.go: ## @@ -0,0 +1,130 @@ +package dtp + +/* + * Licensed to the Apache Software Foundation (ASF) under one + * or more contributor

[GitHub] [trafficcontrol] ocket8888 closed pull request #7166: ATC Collaborators for November 2022

2022-11-01 Thread GitBox
ocket closed pull request #7166: ATC Collaborators for November 2022 URL: https://github.com/apache/trafficcontrol/pull/7166 -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment.

[GitHub] [trafficcontrol] ezelkow1 commented on a diff in pull request #7161: DTP open sourcing

2022-11-01 Thread GitBox
ezelkow1 commented on code in PR #7161: URL: https://github.com/apache/trafficcontrol/pull/7161#discussion_r1010611787 ## test/fakeOrigin/dtp/bin.go: ## @@ -0,0 +1,86 @@ +package dtp + +/* + * Licensed to the Apache Software Foundation (ASF) under one + * or more contributor

[GitHub] [trafficcontrol] ezelkow1 commented on a diff in pull request #7161: DTP open sourcing

2022-11-01 Thread GitBox
ezelkow1 commented on code in PR #7161: URL: https://github.com/apache/trafficcontrol/pull/7161#discussion_r1010609907 ## test/fakeOrigin/dtp/handler.go: ## @@ -0,0 +1,360 @@ +package dtp + +/* + * Licensed to the Apache Software Foundation (ASF) under one + * or more

[GitHub] [trafficcontrol] zrhoffman commented on issue #2198: Add Generic Traffic Ops Config Endpoint

2022-11-01 Thread GitBox
zrhoffman commented on issue #2198: URL: https://github.com/apache/trafficcontrol/issues/2198#issuecomment-1298756527 Related: #4708 -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific

[GitHub] [trafficcontrol] ocket8888 commented on pull request #4996: Ds active flag

2022-11-01 Thread GitBox
ocket commented on PR #4996: URL: https://github.com/apache/trafficcontrol/pull/4996#issuecomment-1298737699 obsoleted by #7099 -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific

[GitHub] [trafficcontrol] ocket8888 closed pull request #4996: Ds active flag

2022-11-01 Thread GitBox
ocket closed pull request #4996: Ds active flag URL: https://github.com/apache/trafficcontrol/pull/4996 -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe,

[GitHub] [trafficcontrol] zrhoffman commented on issue #4894: non-standard httpsPort not appended to domain name in remap.config line

2022-11-01 Thread GitBox
zrhoffman commented on issue #4894: URL: https://github.com/apache/trafficcontrol/issues/4894#issuecomment-1298734903 @bdgranger Is this still an issue in ATC 7.0.1 or ATC 6.1.0? -- This is an automated message from the Apache Git Service. To respond to the message, please log on to

[GitHub] [trafficcontrol] shamrickus commented on pull request #7164: Pin node version in dev ciab TP/TPv2

2022-11-01 Thread GitBox
shamrickus commented on PR #7164: URL: https://github.com/apache/trafficcontrol/pull/7164#issuecomment-1298691974 > TPv2 logs are just... empty. The container is running, but it never does anything. If it's not displaying anything then `npm ci/install` is probably still doing it's

[GitHub] [trafficcontrol] ocket8888 commented on pull request #7164: Pin node version in dev ciab TP/TPv2

2022-11-01 Thread GitBox
ocket commented on PR #7164: URL: https://github.com/apache/trafficcontrol/pull/7164#issuecomment-1298672040 When I run the dev env on this branch, Traffic Router and tpv2 fail to start. Traffic Router Logs ``` trafficrouter_1 | [INFO] Scanning for projects...

[GitHub] [trafficcontrol] rob05c opened a new pull request, #7167: Fix t3c test duplication and upgrade to v4

2022-11-01 Thread GitBox
rob05c opened a new pull request, #7167: URL: https://github.com/apache/trafficcontrol/pull/7167 Moves the TO test setup to a shared library to remove duplication in the ORT/t3c integration tests, because that was easier than upgrading t3c tests to API v4, which was necessary to test

[GitHub] [trafficcontrol] asf-ci opened a new pull request, #7166: ATC Collaborators for November 2022

2022-11-01 Thread GitBox
asf-ci opened a new pull request, #7166: URL: https://github.com/apache/trafficcontrol/pull/7166 This PR uses [`.asf.yaml`](https://s.apache.org/asfyamltriage) to assign the GitHub [Triage

[GitHub] [trafficcontrol] zrhoffman commented on a diff in pull request #7161: DTP open sourcing

2022-11-01 Thread GitBox
zrhoffman commented on code in PR #7161: URL: https://github.com/apache/trafficcontrol/pull/7161#discussion_r1009733005 ## test/fakeOrigin/dtp/text.go: ## @@ -0,0 +1,86 @@ +package dtp + +/* + * Licensed to the Apache Software Foundation (ASF) under one + * or more contributor

[GitHub] [trafficcontrol] zrhoffman commented on a diff in pull request #7161: DTP open sourcing

2022-11-01 Thread GitBox
zrhoffman commented on code in PR #7161: URL: https://github.com/apache/trafficcontrol/pull/7161#discussion_r1010109462 ## test/fakeOrigin/dtp/dtp.go: ## @@ -0,0 +1,130 @@ +package dtp + +/* + * Licensed to the Apache Software Foundation (ASF) under one + * or more contributor

[GitHub] [trafficcontrol] zrhoffman opened a new pull request, #7165: arm64 support for Dev CiaB's prebuilt trafficserver image

2022-10-31 Thread GitBox
zrhoffman opened a new pull request, #7165: URL: https://github.com/apache/trafficcontrol/pull/7165 This PR adds `linux/arm64` support to the `ghcr.io/apache/trafficcontrol/ci/trafficserver-alpine` image which makes the CDN in a Box for Developers `t3c` image work for users on

[GitHub] [trafficcontrol] shamrickus opened a new pull request, #7164: Pin node version in dev ciab TP/TPv2

2022-10-31 Thread GitBox
shamrickus opened a new pull request, #7164: URL: https://github.com/apache/trafficcontrol/pull/7164 Currently the TP/TPv2 dev containers have issues starting due to node/npm versioning. `node:alpine` uses the latest node which currently is v19, many of our dependencies don't

[GitHub] [trafficcontrol] ezelkow1 commented on a diff in pull request #7161: DTP open sourcing

2022-10-31 Thread GitBox
ezelkow1 commented on code in PR #7161: URL: https://github.com/apache/trafficcontrol/pull/7161#discussion_r1009843462 ## test/fakeOrigin/dtp/dtp.go: ## @@ -0,0 +1,144 @@ +package dtp + +/* + * Licensed to the Apache Software Foundation (ASF) under one + * or more contributor

[GitHub] [trafficcontrol] ezelkow1 commented on a diff in pull request #7161: DTP open sourcing

2022-10-31 Thread GitBox
ezelkow1 commented on code in PR #7161: URL: https://github.com/apache/trafficcontrol/pull/7161#discussion_r1009842717 ## test/fakeOrigin/dtp/dtp.go: ## @@ -0,0 +1,144 @@ +package dtp + +/* + * Licensed to the Apache Software Foundation (ASF) under one + * or more contributor

[GitHub] [trafficcontrol] ezelkow1 commented on a diff in pull request #7161: DTP open sourcing

2022-10-31 Thread GitBox
ezelkow1 commented on code in PR #7161: URL: https://github.com/apache/trafficcontrol/pull/7161#discussion_r1009841681 ## test/fakeOrigin/dtp/config.go: ## @@ -0,0 +1,120 @@ +package dtp + +/* + * Licensed to the Apache Software Foundation (ASF) under one + * or more

[GitHub] [trafficcontrol] ezelkow1 commented on a diff in pull request #7161: DTP open sourcing

2022-10-31 Thread GitBox
ezelkow1 commented on code in PR #7161: URL: https://github.com/apache/trafficcontrol/pull/7161#discussion_r1009840899 ## test/fakeOrigin/dtp/dtp.go: ## @@ -0,0 +1,130 @@ +package dtp + +/* + * Licensed to the Apache Software Foundation (ASF) under one + * or more contributor

[GitHub] [trafficcontrol] ezelkow1 commented on a diff in pull request #7161: DTP open sourcing

2022-10-31 Thread GitBox
ezelkow1 commented on code in PR #7161: URL: https://github.com/apache/trafficcontrol/pull/7161#discussion_r1009840703 ## test/fakeOrigin/dtp/dtp.go: ## @@ -0,0 +1,130 @@ +package dtp + +/* + * Licensed to the Apache Software Foundation (ASF) under one + * or more contributor

[GitHub] [trafficcontrol] ezelkow1 commented on a diff in pull request #7161: DTP open sourcing

2022-10-31 Thread GitBox
ezelkow1 commented on code in PR #7161: URL: https://github.com/apache/trafficcontrol/pull/7161#discussion_r1009840556 ## test/fakeOrigin/dtp/config.go: ## @@ -0,0 +1,120 @@ +package dtp + +/* + * Licensed to the Apache Software Foundation (ASF) under one + * or more

<    2   3   4   5   6   7   8   9   10   11   >