[GitHub] dangogh opened a new issue #2710: TO Go -- db access error if profile.cdn is null

dangogh opened a new issue #2710: TO Go -- db access error if profile.cdn is null URL: https://github.com/apache/trafficcontrol/issues/2710 hitting the `POST /api/1.3/servers` endpoint. If the profile indicated has a null cdn, I get a db access error: ``` ERROR: servers.go:128:

[GitHub] dangogh commented on issue #2710: TO Go -- db access error if profile.cdn is null

dangogh commented on issue #2710: TO Go -- db access error if profile.cdn is null URL: https://github.com/apache/trafficcontrol/issues/2710#issuecomment-413890963 my thought as well. global profiles are cross-CDN, but should use the ALL cdn, which is created in `seeds.sql`

[GitHub] rob05c commented on issue #2710: TO Go -- db access error if profile.cdn is null

rob05c commented on issue #2710: TO Go -- db access error if profile.cdn is null URL: https://github.com/apache/trafficcontrol/issues/2710#issuecomment-413889775 +1 on `not null`. Profiles apply to Servers and DSes, which should always be on one CDN, and using them for anything on

[GitHub] dangogh commented on issue #2710: TO Go -- db access error if profile.cdn is null

dangogh commented on issue #2710: TO Go -- db access error if profile.cdn is null URL: https://github.com/apache/trafficcontrol/issues/2710#issuecomment-413894023 on the plus side, it does detect if server cdn and profile cdn don't match

[GitHub] mitchell852 commented on issue #2481: TP: adds the ability to crud api endpoints for roles/capabilities management

mitchell852 commented on issue #2481: TP: adds the ability to crud api endpoints for roles/capabilities management URL: https://github.com/apache/trafficcontrol/pull/2481#issuecomment-413929250 retest this please This is an

[GitHub] dangogh closed pull request #2709: TP: server.js - removes commented out code

dangogh closed pull request #2709: TP: server.js - removes commented out code URL: https://github.com/apache/trafficcontrol/pull/2709 This is a PR merged from a forked repository. As GitHub hides the original diff on merge, it is displayed below for the sake of provenance: As this is a

[GitHub] DylanVolz closed pull request #2691: Fix TO Go db nested query breaking dss post

DylanVolz closed pull request #2691: Fix TO Go db nested query breaking dss post URL: https://github.com/apache/trafficcontrol/pull/2691 This is a PR merged from a forked repository. As GitHub hides the original diff on merge, it is displayed below for the sake of provenance: As this is

[GitHub] DylanVolz closed pull request #2701: Fix TO Go dss endpoint limit param

DylanVolz closed pull request #2701: Fix TO Go dss endpoint limit param URL: https://github.com/apache/trafficcontrol/pull/2701 This is a PR merged from a forked repository. As GitHub hides the original diff on merge, it is displayed below for the sake of provenance: As this is a foreign

[GitHub] mitchell852 commented on issue #2017: TP, TO API should allow for 'delete' of users

mitchell852 commented on issue #2017: TP, TO API should allow for 'delete' of users URL: https://github.com/apache/trafficcontrol/issues/2017#issuecomment-413925703 @moltzaum is going to look at this This is an automated

[GitHub] mitchell852 commented on issue #2017: TP, TO API should allow for 'delete' of users

mitchell852 commented on issue #2017: TP, TO API should allow for 'delete' of users URL: https://github.com/apache/trafficcontrol/issues/2017#issuecomment-413917558 I like the user.active column but for now i think having DELETE /users/:id which just sets the role to disallowed would

[GitHub] mitchell852 commented on issue #2711: add profile constraint cdn not null

mitchell852 commented on issue #2711: add profile constraint cdn not null URL: https://github.com/apache/trafficcontrol/pull/2711#issuecomment-413928265 @dangogh - how about some kind of test. i.e. try to make a profile thru the api with a null cdn and ensure that it fails

Build failed in Jenkins: trafficcontrol-PR #2287

See Changes: [mitchell852] adds the ability to crud api endpoints [mitchell852] turn caps on/off based upon setting in tp_properties.json -- [...truncated 15.62 MB...]

[GitHub] dangogh commented on issue #2711: add profile constraint cdn not null

dangogh commented on issue #2711: add profile constraint cdn not null URL: https://github.com/apache/trafficcontrol/pull/2711#issuecomment-413916808 above failure was due to download issue on jenkins. retest this please

[GitHub] asfgit commented on issue #2711: add profile constraint cdn not null

asfgit commented on issue #2711: add profile constraint cdn not null URL: https://github.com/apache/trafficcontrol/pull/2711#issuecomment-413918276 Refer to this link for build results (access rights to CI server needed): https://builds.apache.org/job/trafficcontrol-PR/2286/ Test

Jenkins build is back to normal : trafficcontrol-PR #2286

See

[GitHub] asfgit commented on issue #2481: TP: adds the ability to crud api endpoints for roles/capabilities management

asfgit commented on issue #2481: TP: adds the ability to crud api endpoints for roles/capabilities management URL: https://github.com/apache/trafficcontrol/pull/2481#issuecomment-413938086 Refer to this link for build results (access rights to CI server needed):

[GitHub] dangogh opened a new pull request #2711: add profile constraint cdn not null

dangogh opened a new pull request #2711: add profile constraint cdn not null URL: https://github.com/apache/trafficcontrol/pull/2711 What does this PR do? Adds constraint to profile table to disallow null cdn. Only does this after ensuring that any null cdn currently in the db is

Build failed in Jenkins: trafficcontrol-PR #2285

See Changes: [mitchell852] add operations role to seeds.sql so there when used for extension user [dangogh] add profile constraint cdn not null -- [...truncated 12.15

[GitHub] asfgit commented on issue #2711: add profile constraint cdn not null

asfgit commented on issue #2711: add profile constraint cdn not null URL: https://github.com/apache/trafficcontrol/pull/2711#issuecomment-413915072 Refer to this link for build results (access rights to CI server needed): https://builds.apache.org/job/trafficcontrol-PR/2285/ Test

[GitHub] asfgit commented on issue #2513: Add TO Go plugin system

asfgit commented on issue #2513: Add TO Go plugin system URL: https://github.com/apache/trafficcontrol/pull/2513#issuecomment-413969569 Refer to this link for build results (access rights to CI server needed): https://builds.apache.org/job/trafficcontrol-PR/2288/ Test PASSed.

[GitHub] asfgit commented on issue #2481: TP: adds the ability to crud api endpoints for roles/capabilities management

asfgit commented on issue #2481: TP: adds the ability to crud api endpoints for roles/capabilities management URL: https://github.com/apache/trafficcontrol/pull/2481#issuecomment-413971220 Refer to this link for build results (access rights to CI server needed):

[GitHub] moltzaum commented on a change in pull request #2704: TO DB - Mapping roles to capabilities for read-only, operations, portal, federations, steering

moltzaum commented on a change in pull request #2704: TO DB - Mapping roles to capabilities for read-only, operations, portal, federations, steering URL: https://github.com/apache/trafficcontrol/pull/2704#discussion_r211025059 ## File path:

[GitHub] rob05c commented on issue #2711: add profile constraint cdn not null

rob05c commented on issue #2711: add profile constraint cdn not null URL: https://github.com/apache/trafficcontrol/pull/2711#issuecomment-413989902 Ah, you're right, I was mistaken This is an automated message from the Apache

[GitHub] rob05c closed pull request #2711: add profile constraint cdn not null

rob05c closed pull request #2711: add profile constraint cdn not null URL: https://github.com/apache/trafficcontrol/pull/2711 This is a PR merged from a forked repository. As GitHub hides the original diff on merge, it is displayed below for the sake of provenance: As this is a foreign

[GitHub] rob05c commented on issue #2711: add profile constraint cdn not null

rob05c commented on issue #2711: add profile constraint cdn not null URL: https://github.com/apache/trafficcontrol/pull/2711#issuecomment-413985870 For the record, I don't approve of testing Postgres itself. It's certainly valuable to test the API, for example, verifying that an attempt to

[GitHub] dangogh commented on issue #2711: add profile constraint cdn not null

dangogh commented on issue #2711: add profile constraint cdn not null URL: https://github.com/apache/trafficcontrol/pull/2711#issuecomment-413978075 @rob05c interested in merging? This is an automated message from the Apache

[GitHub] mitchell852 commented on a change in pull request #2704: TO DB - Mapping roles to capabilities for read-only, operations, portal, federations, steering

mitchell852 commented on a change in pull request #2704: TO DB - Mapping roles to capabilities for read-only, operations, portal, federations, steering URL: https://github.com/apache/trafficcontrol/pull/2704#discussion_r211024880 ## File path:

[GitHub] mitchell852 commented on issue #2481: TP: adds the ability to crud api endpoints for roles/capabilities management

mitchell852 commented on issue #2481: TP: adds the ability to crud api endpoints for roles/capabilities management URL: https://github.com/apache/trafficcontrol/pull/2481#issuecomment-413966634 retest this please This is

[GitHub] dangogh commented on issue #2711: add profile constraint cdn not null

dangogh commented on issue #2711: add profile constraint cdn not null URL: https://github.com/apache/trafficcontrol/pull/2711#issuecomment-413975538 @mitchell852 - api test added to attempt to create a bad profile -- one each for all the required fields. ``` cd

[GitHub] DylanVolz closed issue #2240: TP - provide the ability to manage api endpoints

DylanVolz closed issue #2240: TP - provide the ability to manage api endpoints URL: https://github.com/apache/trafficcontrol/issues/2240 This is an automated message from the Apache Git Service. To respond to the message,

[GitHub] DylanVolz closed pull request #2481: TP: adds the ability to crud api endpoints for roles/capabilities management

DylanVolz closed pull request #2481: TP: adds the ability to crud api endpoints for roles/capabilities management URL: https://github.com/apache/trafficcontrol/pull/2481 This is a PR merged from a forked repository. As GitHub hides the original diff on merge, it is displayed below for

[GitHub] MattMills opened a new issue #1470: Remove JS libraries loaded from cloudflare CDNJS

MattMills opened a new issue #1470: Remove JS libraries loaded from cloudflare CDNJS URL: https://github.com/apache/trafficcontrol/issues/1470 There are a few libraries in traffic portal that are being loaded from cdnjs.cloudflare.com, asked Jeremy why and he asked me to open this issue,