[GitHub] [trafficcontrol] mitchell852 commented on issue #3977: TP: Adds Server Capabilities UI

[GitBox]

mitchell852 commented on issue #3977: TP: Adds Server Capabilities UI
URL: https://github.com/apache/trafficcontrol/pull/3977#issuecomment-541109856
 
 
   > I'd like to remove allowing dot, if no one objects.
   
   I'm good with that. Is this a good UI error message?
   
   `Must be alphanumeric with no spaces. Dash and underscore are  also allowed.`
   
   based on that. This is fine:
   
   `---`
   `-_-_-_`
   `22`


This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
 
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org


With regards,
Apache Git Services

[GitHub] [trafficcontrol] asf-ci commented on issue #3954: Added deprecation notices for /user/current/update

[GitBox]

asf-ci commented on issue #3954: Added deprecation notices for 
/user/current/update
URL: https://github.com/apache/trafficcontrol/pull/3954#issuecomment-541127422
 
 
   
   Refer to this link for build results (access rights to CI server needed): 
   https://builds.apache.org/job/trafficcontrol-PR/4454/
   


This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
 
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org


With regards,
Apache Git Services

[GitHub] [trafficcontrol] lbathina opened a new issue #3986: Unable to add new user - shows passwords don't match even when they match

[GitBox]

lbathina opened a new issue #3986: Unable to add new user - shows passwords 
don't match even when they match
URL: https://github.com/apache/trafficcontrol/issues/3986
 
 
   
   
   
   
   ## I'm submitting a ...
   
   
   - [X] bug report
   - [ ] new feature / enhancement request
   - [ ] improvement request (usability, performance, tech debt, etc.)
   - [ ] other 
   
   ## Traffic Control components affected ...
   
   - [ ] CDN in a Box
   - [ ] Documentation
   - [ ] Grove
   - [ ] Traffic Control Client
   - [ ] Traffic Monitor
   - [ ] Traffic Ops
   - [ ] Traffic Ops ORT
   - [X] Traffic Portal
   - [ ] Traffic Router
   - [ ] Traffic Stats
   - [ ] Traffic Vault
   - [ ] unknown
   
   ## Current behavior:
   
   When password less than 8 characters are provided, even when the password 
and confirm password field matches, the application shows `Doesn't Match`
   ## Expected / new behavior:
   
   They should not throw `Doesn't Match` error. may be can show the password 
requirement not met or too short.
   ## Minimal reproduction of the problem with instructions:
   
   User Admin-> users -> click + -> enter required information -> in the 
password and confirm password try giving the following passwords. enter same 
password in both fields.
   test
   test123
   
   
   ## Anything else:
   
   
   


This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
 
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org


With regards,
Apache Git Services

[GitHub] [trafficcontrol] ocket8888 commented on a change in pull request #3870: Rewrite /capabilities to Go

[GitBox]

ocket commented on a change in pull request #3870: Rewrite /capabilities to 
Go
URL: https://github.com/apache/trafficcontrol/pull/3870#discussion_r334095773
 
 

 ##
 File path: traffic_ops/traffic_ops_golang/capabilities/capabilities.go
 ##
 @@ -0,0 +1,305 @@
+package capabilities
+
+/*
+ * Licensed to the Apache Software Foundation (ASF) under one
+ * or more contributor license agreements.  See the NOTICE file
+ * distributed with this work for additional information
+ * regarding copyright ownership.  The ASF licenses this file
+ * to you under the Apache License, Version 2.0 (the
+ * "License"); you may not use this file except in compliance
+ * with the License.  You may obtain a copy of the License at
+ *
+ *   http://www.apache.org/licenses/LICENSE-2.0
+ *
+ * Unless required by applicable law or agreed to in writing,
+ * software distributed under the License is distributed on an
+ * "AS IS" BASIS, WITHOUT WARRANTIES OR CONDITIONS OF ANY
+ * KIND, either express or implied.  See the License for the
+ * specific language governing permissions and limitations
+ * under the License.
+ */
+
+import "database/sql"
+import "encoding/json"
+import "errors"
+import "fmt"
+import "net/http"
+
+import "github.com/apache/trafficcontrol/lib/go-tc"
+import "github.com/apache/trafficcontrol/traffic_ops/traffic_ops_golang/api"
+
+const readQuery = `
+SELECT description,
+   last_updated,
+   name
+FROM capability
+`
+
+const createQuery = `
+INSERT INTO capability (name, description)
+VALUES ($1, $2)
+RETURNING description, last_updated, name
+`
+
+const replaceQuery = `
+UPDATE capability
+SET name=$1, description=$2
+WHERE name=$3
+RETURNING description, last_updated, name
+`
+
+const deleteQuery = `
+DELETE FROM capability
+WHERE name=$1
+RETURNING description, last_updated, name
+`
+
+func Read(w http.ResponseWriter, r *http.Request) {
+   inf, sysErr, userErr, errCode := api.NewInfo(r, nil, nil)
+   tx := inf.Tx.Tx
+   if userErr != nil || sysErr != nil {
+   api.HandleErr(w, r, tx, errCode, userErr, sysErr)
+   return
+   }
+   defer inf.Close()
+
+
+   var rows *sql.Rows
+   var err error
+   if name, ok := inf.Params["name"]; ok {
+   rows, err = tx.Query(readQuery + "WHERE name=$1", name)
+   } else {
+   rows, err = tx.Query(readQuery)
+   }
+   if err != nil && err != sql.ErrNoRows {
+   errCode = http.StatusInternalServerError
+   sysErr = fmt.Errorf("querying capabilities: %v", err)
+   api.HandleErr(w, r, tx, errCode, nil, sysErr)
+   return
+   }
+   defer rows.Close()
+
+   caps := []tc.Capability{}
+   for rows.Next() {
+   cap := tc.Capability{}
+   if err := rows.Scan(, , 
); err != nil {
+   errCode = http.StatusInternalServerError
+   sysErr = fmt.Errorf("Parsing database response: %v", 
err)
+   api.HandleErr(w, r, tx, errCode, nil, sysErr)
+   return
+   }
+
+   caps = append(caps, cap)
+   }
+
+   respBts, err := json.Marshal(struct{R []tc.Capability 
`json:"response"`}{caps})
 
 Review comment:
   oh yeah. I don't like using that because it doesn't add trailing newlines. 
But I can fix that...


This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
 
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org


With regards,
Apache Git Services

[GitHub] [trafficcontrol] asf-ci commented on issue #3977: TP: Adds Server Capabilities UI

[GitBox]

asf-ci commented on issue #3977: TP: Adds Server Capabilities UI
URL: https://github.com/apache/trafficcontrol/pull/3977#issuecomment-541167072
 
 
   
   Refer to this link for build results (access rights to CI server needed): 
   https://builds.apache.org/job/trafficcontrol-PR/4461/
   


This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
 
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org


With regards,
Apache Git Services

[GitHub] [trafficcontrol] mitchell852 commented on a change in pull request #3972: Add Server Capabilities blueprint

[GitBox]

mitchell852 commented on a change in pull request #3972: Add Server 
Capabilities blueprint
URL: https://github.com/apache/trafficcontrol/pull/3972#discussion_r334118568
 
 

 ##
 File path: blueprints/server-capabilitites.md
 ##
 @@ -0,0 +1,164 @@
+
+# Server Capabilities
+
+## Problem Description
+
+Suppose a Traffic Control operator has servers of a particular type. For 
example, servers with only Memory and no Disk cache. It's possible today to 
only route to those Edges, via manual Delivery Service Server assignments. But 
suppose you have a Mid server with only Memory and no Disk. Then suppose you 
have a certain class of traffic you need to route to this Mid, but not other 
traffic. For example, Delivery Services with small images; but not DSes with 
large binary files, which would destroy the cache. Right now, this isn't 
possible in Traffic Control.
+
+We propose a feature, called "Server Capabilitites" to solve this problem. 
Servers will have "capabilitites" and Delivery Services will have "Required 
Capabilitites," and if a server does not have a required capability, then it 
should not be manually assignable as an Edge, and a Mid must not be added as a 
parent for that DS in the Edge ATS config.
+
+Initially, this is completely backwards-compatible on upgrade, because 
initially no Delivery Service will have any Required Capabilities.
+
+This feature will be completely optional. TC operators who don't need Server 
Capabilities will simply not create them.
+
+Server Capabilities will be arbitrary strings. The ATS project will not "seed" 
any, and impose as little direction as possible. For example, Server 
Capabilitites could be Cache types, Server types, Hardware types, ATS versions, 
Lua support, other ATS plugin support, or any other features an operator needs 
to route (or not route) on.
+
+
+## Proposed Change
+
+- Servers have Capabilities (i.e.: CACHE_MEMORY, CACHE_DISK )
+
+- Delivery Services have Required Capabilities (i.e.: CACHE_MEMORY, CACHE_DISK)
+
+- When generating Configuration (e.g. ATS parent.config):
+  - If a Mid Server which is otherwise parented to an Edge does not have all 
Required Capabilities of a Delivery Service, that Mid will not be inserted as a 
parent for that Delivery Service’s remap and parent rules.
+  - Backward Compatibility is automatic:
+- Initially, no Delivery Services have Required Capabilities. Hence, 
everything behaves like it does today.
+- If an EDGE server does not have all capabilities required by a DS, that 
server SHOULD NOT be assignable to that DS. 
+- If an EDGE server is assigned to a DS which requires capabilities that 
server has, it SHOULD NOT be possible to remove those capabilities from that 
server.
+
+- Initially, Server Capability names are limited to `[a-Z]`, `[0-9]`, `_`, and 
`-`. This allows them to be put in most parts of a URI, as well as being the 
characters of Base64 URL Encoding. We may decide to allow high unicode later. 
But for now, since we're not sure yet what usage will look like, it's much 
easier to add characters later without breaking people, than it is to remove 
them.
+
+### Traffic Portal Impact
+
+- Server Page
+  - New dropdown to add to a text list: Capabilities
+  - List elements have a button to remove the capability
+  - Dropdown/List is just one option - other GUI components may be used
+  - Component should consider that there could be many Capabilities
+
+- Delivery Service Page
+  - New dropdown to add to a text list: Required Capabilities
 
 Review comment:
   I would go this route IF the server capabilities were part of the delivery 
service object but since they are not I will probably create a UI experience 
similar to how you assign servers to a delivery service. For example, when 
viewing a delivery service, you click "More > Manage Required Server 
Capabilities" which takes you to:
   
   tp.domain.com/#!/delivery-services/4/required-capabilities
   
   (I'll also add a context menu item to the delivery services table along the 
lines of "Manage Required Server Capabilities") 
   
   where you can add and remove required server capabilities as needed. Sound 
ok?


This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
 
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org


With regards,
Apache Git Services

[GitHub] [trafficcontrol] mhoppa commented on a change in pull request #3967: Rewrite DELETE federation delivery service to golang

[GitBox]

mhoppa commented on a change in pull request #3967: Rewrite DELETE federation 
delivery service to golang
URL: https://github.com/apache/trafficcontrol/pull/3967#discussion_r334133185
 
 

 ##
 File path: traffic_ops/traffic_ops_golang/routing/routes.go
 ##
 @@ -445,7 +445,7 @@ func Routes(d ServerData) ([]Route, []RawRoute, 
http.Handler, error) {
{1.1, http.MethodGet, `federations/?(\.json)?$`, 
federations.Get, auth.PrivLevelFederation, Authenticated, nil},
{1.1, http.MethodPost, 
`federations/{id}/deliveryservices?(\.json)?$`, federations.PostDSes, 
auth.PrivLevelAdmin, Authenticated, nil},
{1.1, http.MethodGet, 
`federations/{id}/deliveryservices?(\.json)?$`, 
api.ReadHandler({}), auth.PrivLevelReadOnly, 
Authenticated, nil},
-   {1.1, http.MethodDelete, 
`federations/{id}/deliveryservices?(\.json)?$`, 
api.DeleteHandler({}), auth.PrivLevelAdmin, 
Authenticated, nil},
+   {1.1, http.MethodDelete, 
`federations/{id}/deliveryservices/{dsID}/?(\.json)?$`, 
api.DeleteHandler({}), auth.PrivLevelAdmin, 
Authenticated, nil},
 
 Review comment:
   ?


This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
 
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org


With regards,
Apache Git Services

[GitHub] [trafficcontrol] ocket8888 commented on issue #3870: Rewrite /capabilities to Go

[GitBox]

ocket commented on issue #3870: Rewrite /capabilities to Go
URL: https://github.com/apache/trafficcontrol/pull/3870#issuecomment-541228488
 
 
   retest this please
   


This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
 
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org


With regards,
Apache Git Services

[GitHub] [trafficcontrol] ocket8888 commented on a change in pull request #3967: Rewrite DELETE federation delivery service to golang

[GitBox]

ocket commented on a change in pull request #3967: Rewrite DELETE 
federation delivery service to golang
URL: https://github.com/apache/trafficcontrol/pull/3967#discussion_r334138885
 
 

 ##
 File path: traffic_ops/traffic_ops_golang/routing/routes.go
 ##
 @@ -445,7 +445,7 @@ func Routes(d ServerData) ([]Route, []RawRoute, 
http.Handler, error) {
{1.1, http.MethodGet, `federations/?(\.json)?$`, 
federations.Get, auth.PrivLevelFederation, Authenticated, nil},
{1.1, http.MethodPost, 
`federations/{id}/deliveryservices?(\.json)?$`, federations.PostDSes, 
auth.PrivLevelAdmin, Authenticated, nil},
{1.1, http.MethodGet, 
`federations/{id}/deliveryservices?(\.json)?$`, 
api.ReadHandler({}), auth.PrivLevelReadOnly, 
Authenticated, nil},
-   {1.1, http.MethodDelete, 
`federations/{id}/deliveryservices?(\.json)?$`, 
api.DeleteHandler({}), auth.PrivLevelAdmin, 
Authenticated, nil},
+   {1.1, http.MethodDelete, 
`federations/{id}/deliveryservices/{dsID}/?(\.json)?$`, 
api.DeleteHandler({}), auth.PrivLevelAdmin, 
Authenticated, nil},
 
 Review comment:
   This removes the handler for `DELETE 
/api/1.x/federations/(ID}/deliveryservices`


This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
 
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org


With regards,
Apache Git Services

[GitHub] [trafficcontrol] asf-ci commented on issue #3977: TP: Adds Server Capabilities UI

[GitBox]

asf-ci commented on issue #3977: TP: Adds Server Capabilities UI
URL: https://github.com/apache/trafficcontrol/pull/3977#issuecomment-541192541
 
 
   
   Refer to this link for build results (access rights to CI server needed): 
   https://builds.apache.org/job/trafficcontrol-PR/4463/
   


This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
 
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org


With regards,
Apache Git Services

Build failed in Jenkins: trafficcontrol-PR #4463

[Apache Jenkins Server]

See 


Changes:

[mitchell852] prevents dots in server capability name


--
GitHub pull request #3977 of commit 97e7c817e010ed739959fc341b55619a27ed3675, 
no merge conflicts.
Running as SYSTEM
!!! PR mergeability status has changed !!!  
PR now has merge conflicts!
Setting status of 97e7c817e010ed739959fc341b55619a27ed3675 to PENDING with url 
https://builds.apache.org/job/trafficcontrol-PR/4463/ and message: 'Build 
started for merge commit.'
Using context: default
[EnvInject] - Loading node environment variables.
Building remotely on H37 (ubuntu xenial) in workspace 

[WS-CLEANUP] Deleting project workspace...
[WS-CLEANUP] Deferred wipeout is used...
using credential b205a645-1ea7-4dfd-973d-c14ac43cab07
Cloning the remote Git repository
Cloning repository git://github.com/apache/trafficcontrol.git
 > git init  # timeout=10
Fetching upstream changes from git://github.com/apache/trafficcontrol.git
 > git --version # timeout=10
using GIT_SSH to set credentials 
 > git fetch --tags --progress git://github.com/apache/trafficcontrol.git 
 > +refs/heads/*:refs/remotes/origin/*
 > git config remote.origin.url git://github.com/apache/trafficcontrol.git # 
 > timeout=10
 > git config --add remote.origin.fetch +refs/heads/*:refs/remotes/origin/* # 
 > timeout=10
 > git config remote.origin.url git://github.com/apache/trafficcontrol.git # 
 > timeout=10
Fetching upstream changes from git://github.com/apache/trafficcontrol.git
using GIT_SSH to set credentials 
 > git fetch --tags --progress git://github.com/apache/trafficcontrol.git 
 > +refs/pull/*:refs/remotes/origin/pr/*
 > git rev-parse 97e7c817e010ed739959fc341b55619a27ed3675^{commit} # timeout=10
Checking out Revision 97e7c817e010ed739959fc341b55619a27ed3675 (detached)
 > git config core.sparsecheckout # timeout=10
 > git checkout -f 97e7c817e010ed739959fc341b55619a27ed3675
Commit message: "prevents dots in server capability name"
 > git rev-list --no-walk 67ac5025941c112c533ae420f35068d0b82251be # timeout=10
[trafficcontrol-PR] $ /bin/bash /tmp/jenkins3795718723063827412.sh
++ echo jenkins-trafficcontrol-PR-4463
++ sed s/jenkins//
++ sed s/-//g
+ proj=trafficcontrolPR4463
+ yml=infrastructure/docker/build/docker-compose.yml
++ mktemp /tmp/docker-compose-
+ dc=/tmp/docker-compose-EpAC
++ mktemp /tmp/tc-status-
+ st=/tmp/tc-status-i1wd
+ trap finish EXIT
++ uname -s
++ uname -m
+ curl -o /tmp/docker-compose-EpAC -L 
https://github.com/docker/compose/releases/download/1.13.0/docker-compose-Linux-x86_64
  % Total% Received % Xferd  Average Speed   TimeTime Time  Current
 Dload  Upload   Total   SpentLeft  Speed
  0 00 00 0  0  0 --:--:-- --:--:-- --:--:-- 0  
0 00 00 0  0  0 --:--:-- --:--:-- --:--:-- 0100 
  6170   6170 0   1011  0 --:--:-- --:--:-- --:--:--  1011
  0 8079k0 507300 0  40783  0  0:03:22  0:00:01  0:03:21 
40783100 8079k  100 8079k0 0  4532k  0  0:00:01  0:00:01 --:--:-- 
14.5M
+ chmod +x /tmp/docker-compose-EpAC
+ rm -rf dist
+ /tmp/docker-compose-EpAC -f infrastructure/docker/build/docker-compose.yml -p 
trafficcontrolPR4463 up
Creating network "trafficcontrolpr4463_default" with the default driver
Pulling weasel (licenseweasel/weasel:0.2)...
0.2: Pulling from licenseweasel/weasel
Digest: sha256:b0e6dcd71152636af6e3a6e7e2bae275f77ce6aa719314e47981424a3fa86d70
Status: Downloaded newer image for licenseweasel/weasel:0.2
Creating trafficcontrolpr4463_traffic_router_build_1 ... 
Creating trafficcontrolpr4463_grovetccfg_build_1 ... 
Creating trafficcontrolpr4463_source_1 ... 
Creating trafficcontrolpr4463_grove_build_1 ... 
Creating trafficcontrolpr4463_docs_1 ... 
Creating trafficcontrolpr4463_traffic_router_build_1
Creating trafficcontrolpr4463_traffic_portal_build_1 ... 
Creating trafficcontrolpr4463_traffic_ops_build_1 ... 
Creating trafficcontrolpr4463_docs_1
Creating trafficcontrolpr4463_grovetccfg_build_1
Creating trafficcontrolpr4463_traffic_stats_build_1 ... 
Creating trafficcontrolpr4463_traffic_monitor_build_1 ... 
Creating trafficcontrolpr4463_source_1
Creating trafficcontrolpr4463_weasel_1 ... 
Creating trafficcontrolpr4463_grove_build_1
Creating trafficcontrolpr4463_traffic_stats_build_1
Creating trafficcontrolpr4463_traffic_ops_build_1
Creating trafficcontrolpr4463_traffic_monitor_build_1
Creating trafficcontrolpr4463_traffic_portal_build_1
Creating trafficcontrolpr4463_weasel_1
Creating trafficcontrolpr4463_traffic_router_build_1 ... 
error
ERROR: for trafficcontrolpr4463_traffic_router_build_1  Cannot start service 
traffic_router_build: no status provided on response: unknown
Creating trafficcontrolpr4463_weasel_1 ... 

[GitHub] [trafficcontrol] ocket8888 commented on a change in pull request #3967: Rewrite DELETE federation delivery service to golang

[GitBox]

ocket commented on a change in pull request #3967: Rewrite DELETE 
federation delivery service to golang
URL: https://github.com/apache/trafficcontrol/pull/3967#discussion_r334145362
 
 

 ##
 File path: traffic_ops/traffic_ops_golang/routing/routes.go
 ##
 @@ -445,7 +445,7 @@ func Routes(d ServerData) ([]Route, []RawRoute, 
http.Handler, error) {
{1.1, http.MethodGet, `federations/?(\.json)?$`, 
federations.Get, auth.PrivLevelFederation, Authenticated, nil},
{1.1, http.MethodPost, 
`federations/{id}/deliveryservices?(\.json)?$`, federations.PostDSes, 
auth.PrivLevelAdmin, Authenticated, nil},
{1.1, http.MethodGet, 
`federations/{id}/deliveryservices?(\.json)?$`, 
api.ReadHandler({}), auth.PrivLevelReadOnly, 
Authenticated, nil},
-   {1.1, http.MethodDelete, 
`federations/{id}/deliveryservices?(\.json)?$`, 
api.DeleteHandler({}), auth.PrivLevelAdmin, 
Authenticated, nil},
+   {1.1, http.MethodDelete, 
`federations/{id}/deliveryservices/{dsID}/?(\.json)?$`, 
api.DeleteHandler({}), auth.PrivLevelAdmin, 
Authenticated, nil},
 
 Review comment:
   oh... How did I even comment on that?


This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
 
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org


With regards,
Apache Git Services

[GitHub] [trafficcontrol] ocket8888 commented on a change in pull request #3870: Rewrite /capabilities to Go

[GitBox]

ocket commented on a change in pull request #3870: Rewrite /capabilities to 
Go
URL: https://github.com/apache/trafficcontrol/pull/3870#discussion_r334149509
 
 

 ##
 File path: traffic_ops/traffic_ops_golang/capabilities/capabilities.go
 ##
 @@ -0,0 +1,305 @@
+package capabilities
+
+/*
+ * Licensed to the Apache Software Foundation (ASF) under one
+ * or more contributor license agreements.  See the NOTICE file
+ * distributed with this work for additional information
+ * regarding copyright ownership.  The ASF licenses this file
+ * to you under the Apache License, Version 2.0 (the
+ * "License"); you may not use this file except in compliance
+ * with the License.  You may obtain a copy of the License at
+ *
+ *   http://www.apache.org/licenses/LICENSE-2.0
+ *
+ * Unless required by applicable law or agreed to in writing,
+ * software distributed under the License is distributed on an
+ * "AS IS" BASIS, WITHOUT WARRANTIES OR CONDITIONS OF ANY
+ * KIND, either express or implied.  See the License for the
+ * specific language governing permissions and limitations
+ * under the License.
+ */
+
+import "database/sql"
+import "encoding/json"
+import "errors"
+import "fmt"
+import "net/http"
+
+import "github.com/apache/trafficcontrol/lib/go-tc"
+import "github.com/apache/trafficcontrol/traffic_ops/traffic_ops_golang/api"
+
+const readQuery = `
+SELECT description,
+   last_updated,
+   name
+FROM capability
+`
+
+const createQuery = `
+INSERT INTO capability (name, description)
+VALUES ($1, $2)
+RETURNING description, last_updated, name
+`
+
+const replaceQuery = `
+UPDATE capability
+SET name=$1, description=$2
+WHERE name=$3
+RETURNING description, last_updated, name
+`
+
+const deleteQuery = `
+DELETE FROM capability
+WHERE name=$1
+RETURNING description, last_updated, name
+`
+
+func Read(w http.ResponseWriter, r *http.Request) {
+   inf, sysErr, userErr, errCode := api.NewInfo(r, nil, nil)
+   tx := inf.Tx.Tx
+   if userErr != nil || sysErr != nil {
+   api.HandleErr(w, r, tx, errCode, userErr, sysErr)
+   return
+   }
+   defer inf.Close()
+
+
+   var rows *sql.Rows
+   var err error
+   if name, ok := inf.Params["name"]; ok {
+   rows, err = tx.Query(readQuery + "WHERE name=$1", name)
+   } else {
+   rows, err = tx.Query(readQuery)
+   }
+   if err != nil && err != sql.ErrNoRows {
+   errCode = http.StatusInternalServerError
+   sysErr = fmt.Errorf("querying capabilities: %v", err)
+   api.HandleErr(w, r, tx, errCode, nil, sysErr)
+   return
+   }
+   defer rows.Close()
+
+   caps := []tc.Capability{}
+   for rows.Next() {
+   cap := tc.Capability{}
+   if err := rows.Scan(, , 
); err != nil {
+   errCode = http.StatusInternalServerError
+   sysErr = fmt.Errorf("Parsing database response: %v", 
err)
+   api.HandleErr(w, r, tx, errCode, nil, sysErr)
+   return
+   }
+
+   caps = append(caps, cap)
+   }
+
+   respBts, err := json.Marshal(struct{R []tc.Capability 
`json:"response"`}{caps})
+   if err != nil {
+   errCode = http.StatusInternalServerError
+   sysErr = fmt.Errorf("Marshaling response: %v", err)
+   api.HandleErr(w, r, tx, errCode, nil, sysErr)
+   return
+   }
+
+   w.Header().Set(tc.ContentType, tc.ApplicationJson)
+   w.Write(append(respBts, '\n'))
+}
+
+func Create(w http.ResponseWriter, r *http.Request) {
+   inf, sysErr, userErr, errCode := api.NewInfo(r, nil, nil)
+   tx := inf.Tx.Tx
+   if userErr != nil || sysErr != nil {
+   api.HandleErr(w, r, tx, errCode, userErr, sysErr)
+   return
+   }
+   defer inf.Close()
+
+   decoder := json.NewDecoder(r.Body)
+   var cap tc.Capability
+   if err := decoder.Decode(); err != nil {
+   sysErr = fmt.Errorf("Decoding request body: %v")
+   errCode = http.StatusInternalServerError
+   api.HandleErr(w, r, tx, errCode, nil, sysErr)
+   return
+   }
+
+   if cap.Name == "" {
+   userErr = errors.New("'name' must be defined! (and not empty)")
+   errCode = http.StatusBadRequest
+   api.HandleErr(w, r, tx, errCode, userErr, nil)
+   return
+   }
+
+   if cap.Description == "" {
+   userErr = errors.New("'description' must be defined! (and not 
empty)")
+   errCode = http.StatusBadRequest
+   api.HandleErr(w, r, tx, errCode, userErr, nil)
+   return
+   }
+
+   if ok, err := capabilityNameExists(cap.Name, tx); err != nil {
+   sysErr = fmt.Errorf("Checking for capability %s's existence: 
%v", cap.Name, err)
+   errCode = 

[GitHub] [trafficcontrol] mitchell852 commented on a change in pull request #3972: Add Server Capabilities blueprint

[GitBox]

mitchell852 commented on a change in pull request #3972: Add Server 
Capabilities blueprint
URL: https://github.com/apache/trafficcontrol/pull/3972#discussion_r334119233
 
 

 ##
 File path: blueprints/server-capabilitites.md
 ##
 @@ -0,0 +1,164 @@
+
+# Server Capabilities
+
+## Problem Description
+
+Suppose a Traffic Control operator has servers of a particular type. For 
example, servers with only Memory and no Disk cache. It's possible today to 
only route to those Edges, via manual Delivery Service Server assignments. But 
suppose you have a Mid server with only Memory and no Disk. Then suppose you 
have a certain class of traffic you need to route to this Mid, but not other 
traffic. For example, Delivery Services with small images; but not DSes with 
large binary files, which would destroy the cache. Right now, this isn't 
possible in Traffic Control.
+
+We propose a feature, called "Server Capabilitites" to solve this problem. 
Servers will have "capabilitites" and Delivery Services will have "Required 
Capabilitites," and if a server does not have a required capability, then it 
should not be manually assignable as an Edge, and a Mid must not be added as a 
parent for that DS in the Edge ATS config.
+
+Initially, this is completely backwards-compatible on upgrade, because 
initially no Delivery Service will have any Required Capabilities.
+
+This feature will be completely optional. TC operators who don't need Server 
Capabilities will simply not create them.
+
+Server Capabilities will be arbitrary strings. The ATS project will not "seed" 
any, and impose as little direction as possible. For example, Server 
Capabilitites could be Cache types, Server types, Hardware types, ATS versions, 
Lua support, other ATS plugin support, or any other features an operator needs 
to route (or not route) on.
+
+
+## Proposed Change
+
+- Servers have Capabilities (i.e.: CACHE_MEMORY, CACHE_DISK )
+
+- Delivery Services have Required Capabilities (i.e.: CACHE_MEMORY, CACHE_DISK)
+
+- When generating Configuration (e.g. ATS parent.config):
+  - If a Mid Server which is otherwise parented to an Edge does not have all 
Required Capabilities of a Delivery Service, that Mid will not be inserted as a 
parent for that Delivery Service’s remap and parent rules.
+  - Backward Compatibility is automatic:
+- Initially, no Delivery Services have Required Capabilities. Hence, 
everything behaves like it does today.
+- If an EDGE server does not have all capabilities required by a DS, that 
server SHOULD NOT be assignable to that DS. 
+- If an EDGE server is assigned to a DS which requires capabilities that 
server has, it SHOULD NOT be possible to remove those capabilities from that 
server.
+
+- Initially, Server Capability names are limited to `[a-Z]`, `[0-9]`, `_`, and 
`-`. This allows them to be put in most parts of a URI, as well as being the 
characters of Base64 URL Encoding. We may decide to allow high unicode later. 
But for now, since we're not sure yet what usage will look like, it's much 
easier to add characters later without breaking people, than it is to remove 
them.
+
+### Traffic Portal Impact
+
+- Server Page
+  - New dropdown to add to a text list: Capabilities
+  - List elements have a button to remove the capability
+  - Dropdown/List is just one option - other GUI components may be used
+  - Component should consider that there could be many Capabilities
+
+- Delivery Service Page
+  - New dropdown to add to a text list: Required Capabilities
+  - List elements have a button to remove a capability
+  - Dropdown/List is one option - other GUI components may be used
+  - Component should consider that there could be many Capabilities
+
+- New page for Server Capability Types
+  - Ability to add, delete Server Capability Types
+  - May be a text input, which adds to a list, with list element buttons to 
remove from the list
 
 Review comment:
   I try to keep the UI consistent. I.e. you see a table of things, you click 
the `+` button to create a thing, you are directed to a form, fill out the 
form, submit and you are sent back to the table that now includes your thing. 
Sound good?


This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
 
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org


With regards,
Apache Git Services

Build failed in Jenkins: trafficcontrol-PR #4462

[Apache Jenkins Server]

See 

Changes:


--
GitHub pull request #3870 of commit 4a5be16e2f96379a3d97ce52329da67e142a56b5, 
no merge conflicts.
Running as SYSTEM
Setting status of 4a5be16e2f96379a3d97ce52329da67e142a56b5 to PENDING with url 
https://builds.apache.org/job/trafficcontrol-PR/4462/ and message: 'Build 
started for merge commit.'
Using context: default
[EnvInject] - Loading node environment variables.
Building remotely on H30 (ubuntu) in workspace 

[WS-CLEANUP] Deleting project workspace...
[WS-CLEANUP] Deferred wipeout is used...
using credential b205a645-1ea7-4dfd-973d-c14ac43cab07
Cloning the remote Git repository
Cloning repository git://github.com/apache/trafficcontrol.git
 > git init  # timeout=10
Fetching upstream changes from git://github.com/apache/trafficcontrol.git
 > git --version # timeout=10
using GIT_SSH to set credentials 
 > git fetch --tags --progress -- git://github.com/apache/trafficcontrol.git 
 > +refs/heads/*:refs/remotes/origin/*
 > git config remote.origin.url git://github.com/apache/trafficcontrol.git # 
 > timeout=10
 > git config --add remote.origin.fetch +refs/heads/*:refs/remotes/origin/* # 
 > timeout=10
 > git config remote.origin.url git://github.com/apache/trafficcontrol.git # 
 > timeout=10
Fetching upstream changes from git://github.com/apache/trafficcontrol.git
using GIT_SSH to set credentials 
 > git fetch --tags --progress -- git://github.com/apache/trafficcontrol.git 
 > +refs/pull/*:refs/remotes/origin/pr/*
 > git rev-parse 4a5be16e2f96379a3d97ce52329da67e142a56b5^{commit} # timeout=10
 > git rev-parse origin/4a5be16e2f96379a3d97ce52329da67e142a56b5^{commit} # 
 > timeout=10
 > git rev-parse 4a5be16e2f96379a3d97ce52329da67e142a56b5^{commit} # timeout=10
ERROR: Couldn't find any revision to build. Verify the repository and branch 
configuration for this job.
Retrying after 10 seconds
using credential b205a645-1ea7-4dfd-973d-c14ac43cab07
 > git rev-parse --is-inside-work-tree # timeout=10
Fetching changes from the remote Git repository
 > git config remote.origin.url git://github.com/apache/trafficcontrol.git # 
 > timeout=10
Fetching upstream changes from git://github.com/apache/trafficcontrol.git
 > git --version # timeout=10
using GIT_SSH to set credentials 
 > git fetch --tags --progress -- git://github.com/apache/trafficcontrol.git 
 > +refs/pull/*:refs/remotes/origin/pr/*
 > git rev-parse 4a5be16e2f96379a3d97ce52329da67e142a56b5^{commit} # timeout=10
 > git rev-parse origin/4a5be16e2f96379a3d97ce52329da67e142a56b5^{commit} # 
 > timeout=10
 > git rev-parse 4a5be16e2f96379a3d97ce52329da67e142a56b5^{commit} # timeout=10
ERROR: Couldn't find any revision to build. Verify the repository and branch 
configuration for this job.
Retrying after 10 seconds
using credential b205a645-1ea7-4dfd-973d-c14ac43cab07
 > git rev-parse --is-inside-work-tree # timeout=10
Fetching changes from the remote Git repository
 > git config remote.origin.url git://github.com/apache/trafficcontrol.git # 
 > timeout=10
Fetching upstream changes from git://github.com/apache/trafficcontrol.git
 > git --version # timeout=10
using GIT_SSH to set credentials 
 > git fetch --tags --progress -- git://github.com/apache/trafficcontrol.git 
 > +refs/pull/*:refs/remotes/origin/pr/*
 > git rev-parse 4a5be16e2f96379a3d97ce52329da67e142a56b5^{commit} # timeout=10
 > git rev-parse origin/4a5be16e2f96379a3d97ce52329da67e142a56b5^{commit} # 
 > timeout=10
 > git rev-parse 4a5be16e2f96379a3d97ce52329da67e142a56b5^{commit} # timeout=10
ERROR: Couldn't find any revision to build. Verify the repository and branch 
configuration for this job.
Skipped archiving because build is not successful

[GitHub] [trafficcontrol] asf-ci commented on issue #3870: Rewrite /capabilities to Go

[GitBox]

asf-ci commented on issue #3870: Rewrite /capabilities to Go
URL: https://github.com/apache/trafficcontrol/pull/3870#issuecomment-541179969
 
 
   
   Refer to this link for build results (access rights to CI server needed): 
   https://builds.apache.org/job/trafficcontrol-PR/4462/
   


This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
 
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org


With regards,
Apache Git Services

[GitHub] [trafficcontrol] mhoppa commented on a change in pull request #3967: Rewrite DELETE federation delivery service to golang

[GitBox]

mhoppa commented on a change in pull request #3967: Rewrite DELETE federation 
delivery service to golang
URL: https://github.com/apache/trafficcontrol/pull/3967#discussion_r334139892
 
 

 ##
 File path: traffic_ops/traffic_ops_golang/routing/routes.go
 ##
 @@ -445,7 +445,7 @@ func Routes(d ServerData) ([]Route, []RawRoute, 
http.Handler, error) {
{1.1, http.MethodGet, `federations/?(\.json)?$`, 
federations.Get, auth.PrivLevelFederation, Authenticated, nil},
{1.1, http.MethodPost, 
`federations/{id}/deliveryservices?(\.json)?$`, federations.PostDSes, 
auth.PrivLevelAdmin, Authenticated, nil},
{1.1, http.MethodGet, 
`federations/{id}/deliveryservices?(\.json)?$`, 
api.ReadHandler({}), auth.PrivLevelReadOnly, 
Authenticated, nil},
-   {1.1, http.MethodDelete, 
`federations/{id}/deliveryservices?(\.json)?$`, 
api.DeleteHandler({}), auth.PrivLevelAdmin, 
Authenticated, nil},
+   {1.1, http.MethodDelete, 
`federations/{id}/deliveryservices/{dsID}/?(\.json)?$`, 
api.DeleteHandler({}), auth.PrivLevelAdmin, 
Authenticated, nil},
 
 Review comment:
   yeah it does from my initial commit but not master. my initial commit I was 
replacing the perl path of _federations/{id}/deliveryservices/{dsID}_  with 
_/api/1.x/federations/(ID}/deliveryservices_ but that was going to break the 
API so i backed it out and went back to the correct path 


This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
 
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org


With regards,
Apache Git Services

[GitHub] [trafficcontrol] mhoppa commented on a change in pull request #3967: Rewrite DELETE federation delivery service to golang

[GitBox]

mhoppa commented on a change in pull request #3967: Rewrite DELETE federation 
delivery service to golang
URL: https://github.com/apache/trafficcontrol/pull/3967#discussion_r334139892
 
 

 ##
 File path: traffic_ops/traffic_ops_golang/routing/routes.go
 ##
 @@ -445,7 +445,7 @@ func Routes(d ServerData) ([]Route, []RawRoute, 
http.Handler, error) {
{1.1, http.MethodGet, `federations/?(\.json)?$`, 
federations.Get, auth.PrivLevelFederation, Authenticated, nil},
{1.1, http.MethodPost, 
`federations/{id}/deliveryservices?(\.json)?$`, federations.PostDSes, 
auth.PrivLevelAdmin, Authenticated, nil},
{1.1, http.MethodGet, 
`federations/{id}/deliveryservices?(\.json)?$`, 
api.ReadHandler({}), auth.PrivLevelReadOnly, 
Authenticated, nil},
-   {1.1, http.MethodDelete, 
`federations/{id}/deliveryservices?(\.json)?$`, 
api.DeleteHandler({}), auth.PrivLevelAdmin, 
Authenticated, nil},
+   {1.1, http.MethodDelete, 
`federations/{id}/deliveryservices/{dsID}/?(\.json)?$`, 
api.DeleteHandler({}), auth.PrivLevelAdmin, 
Authenticated, nil},
 
 Review comment:
   yeah it does from my initial commit but not master. my initial commit I was 
replacing the perl path of _federations/{id}/deliveryservices/{dsID}_  with 
_/federations/(ID}/deliveryservices_ but that was going to break the API so i 
backed it out and went back to the correct path 


This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
 
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org


With regards,
Apache Git Services

[GitHub] [trafficcontrol] zrhoffman opened a new pull request #3988: WIP Remove Traffic Ops Golang legacy tc.ApiErrorType

[GitBox]

zrhoffman opened a new pull request #3988: WIP Remove Traffic Ops Golang legacy 
tc.ApiErrorType
URL: https://github.com/apache/trafficcontrol/pull/3988
 
 
   
   ## What does this PR (Pull Request) do?
   
   
   - [x] This PR fixes #3349 
   
   
   ## Which Traffic Control components are affected by this PR?
   
   
   - Traffic Ops
   
   ApiErrorType is not mentioned in the documentation, so its removal does not 
need to affect documentation.
   
   ## What is the best way to verify this PR?
   
   
   ## If this is a bug fix, what versions of Traffic Control are affected?
   
   Not a bug fix.
   
   ## The following criteria are ALL met by this PR
   
   
   - [ ] This PR includes tests OR I have explained why tests are unnecessary
   - [x] This PR includes documentation OR I have explained why documentation 
is unnecessary
   - [x] This PR includes an update to CHANGELOG.md OR such an update is not 
necessary
   - [x] This PR includes any and all required license headers
   - [x] This PR ensures that database migration sequence is correct OR this PR 
does not include a database migration
   - [x] This PR **DOES NOT FIX A SERIOUS SECURITY VULNERABILITY** (see [the 
Apache Software Foundation's security 
guidelines](https://www.apache.org/security/) for details)
   
   
   


This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
 
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org


With regards,
Apache Git Services

[GitHub] [trafficcontrol] mitchell852 commented on a change in pull request #3972: Add Server Capabilities blueprint

[GitBox]

mitchell852 commented on a change in pull request #3972: Add Server 
Capabilities blueprint
URL: https://github.com/apache/trafficcontrol/pull/3972#discussion_r334118568
 
 

 ##
 File path: blueprints/server-capabilitites.md
 ##
 @@ -0,0 +1,164 @@
+
+# Server Capabilities
+
+## Problem Description
+
+Suppose a Traffic Control operator has servers of a particular type. For 
example, servers with only Memory and no Disk cache. It's possible today to 
only route to those Edges, via manual Delivery Service Server assignments. But 
suppose you have a Mid server with only Memory and no Disk. Then suppose you 
have a certain class of traffic you need to route to this Mid, but not other 
traffic. For example, Delivery Services with small images; but not DSes with 
large binary files, which would destroy the cache. Right now, this isn't 
possible in Traffic Control.
+
+We propose a feature, called "Server Capabilitites" to solve this problem. 
Servers will have "capabilitites" and Delivery Services will have "Required 
Capabilitites," and if a server does not have a required capability, then it 
should not be manually assignable as an Edge, and a Mid must not be added as a 
parent for that DS in the Edge ATS config.
+
+Initially, this is completely backwards-compatible on upgrade, because 
initially no Delivery Service will have any Required Capabilities.
+
+This feature will be completely optional. TC operators who don't need Server 
Capabilities will simply not create them.
+
+Server Capabilities will be arbitrary strings. The ATS project will not "seed" 
any, and impose as little direction as possible. For example, Server 
Capabilitites could be Cache types, Server types, Hardware types, ATS versions, 
Lua support, other ATS plugin support, or any other features an operator needs 
to route (or not route) on.
+
+
+## Proposed Change
+
+- Servers have Capabilities (i.e.: CACHE_MEMORY, CACHE_DISK )
+
+- Delivery Services have Required Capabilities (i.e.: CACHE_MEMORY, CACHE_DISK)
+
+- When generating Configuration (e.g. ATS parent.config):
+  - If a Mid Server which is otherwise parented to an Edge does not have all 
Required Capabilities of a Delivery Service, that Mid will not be inserted as a 
parent for that Delivery Service’s remap and parent rules.
+  - Backward Compatibility is automatic:
+- Initially, no Delivery Services have Required Capabilities. Hence, 
everything behaves like it does today.
+- If an EDGE server does not have all capabilities required by a DS, that 
server SHOULD NOT be assignable to that DS. 
+- If an EDGE server is assigned to a DS which requires capabilities that 
server has, it SHOULD NOT be possible to remove those capabilities from that 
server.
+
+- Initially, Server Capability names are limited to `[a-Z]`, `[0-9]`, `_`, and 
`-`. This allows them to be put in most parts of a URI, as well as being the 
characters of Base64 URL Encoding. We may decide to allow high unicode later. 
But for now, since we're not sure yet what usage will look like, it's much 
easier to add characters later without breaking people, than it is to remove 
them.
+
+### Traffic Portal Impact
+
+- Server Page
+  - New dropdown to add to a text list: Capabilities
+  - List elements have a button to remove the capability
+  - Dropdown/List is just one option - other GUI components may be used
+  - Component should consider that there could be many Capabilities
+
+- Delivery Service Page
+  - New dropdown to add to a text list: Required Capabilities
 
 Review comment:
   I would go this route IF the server capabilities were part of the delivery 
service object but since they are not I will probably create a UI experience 
similar to how you assign servers to a delivery service. For example, when 
viewing a delivery service, you click "More > Manage Required Capabilities" 
which takes you to:
   
   tp.domain.com/#!/delivery-services/4/required-capabilities
   
   where you can add and remove required server capabilities as needed. Sound 
ok?


This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
 
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org


With regards,
Apache Git Services

[GitHub] [trafficcontrol] mitchell852 edited a comment on issue #3966: Add server capabilities API

[GitBox]

mitchell852 edited a comment on issue #3966: Add server capabilities API
URL: https://github.com/apache/trafficcontrol/pull/3966#issuecomment-541195588
 
 
   > 5. When a post with no body is made. the following error is provided.
   > 
   > ```
   > "alerts": [
   > {
   > "text": "EOF",
   > "level": "error"
   > }
   > ]
   > }```
   >  instead of a meaningful message indicating the missing info.
   > ```
   
   what to create a separate issue for that @lbathina as it sounds like this is 
a problem with all our POSTs


This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
 
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org


With regards,
Apache Git Services

[GitHub] [trafficcontrol] mhoppa commented on a change in pull request #3967: Rewrite DELETE federation delivery service to golang

[GitBox]

mhoppa commented on a change in pull request #3967: Rewrite DELETE federation 
delivery service to golang
URL: https://github.com/apache/trafficcontrol/pull/3967#discussion_r334155561
 
 

 ##
 File path: traffic_ops/traffic_ops_golang/federations/ds.go
 ##
 @@ -123,11 +131,93 @@ func (v *TOFedDSes) ParamColumns() 
map[string]dbhelpers.WhereColumnInfo {
}
 }
 func (v *TOFedDSes) GetType() string {
-   return "federation_deliveryservice"
+   return "federation deliveryservice"
+}
+
+func (v *TOFedDSes) SetKeys(keys map[string]interface{}) {
+   i, _ := keys["id"].(int)
+   v.fedID = 
+}
+
+func (v *TOFedDSes) GetKeys() (map[string]interface{}, bool) {
+   if v.fedID == nil {
+   return map[string]interface{}{"id": 0}, false
+   }
+   return map[string]interface{}{"id": *v.fedID}, true
+}
+
+func (v *TOFedDSes) GetAuditName() string {
+   if v.XMLID != nil {
+   return *v.XMLID
+   }
+   return strconv.Itoa(*v.ID)
+}
+
+func (v *TOFedDSes) GetKeyFieldsInfo() []api.KeyFieldInfo {
+   return []api.KeyFieldInfo{
+   {"id", api.GetIntKey},
+   }
 }
 
 func (v *TOFedDSes) Read() ([]interface{}, error, error, int) { return 
api.GenericRead(v) }
 
+func (v *TOFedDSes) Delete() (error, error, int) {
+   dsIDStr, ok := v.APIInfo().Params["dsID"]
+   if !ok {
+   return errors.New("dsID must be specified for deletion"), nil, 
http.StatusBadRequest
+   }
+   dsID, err := strconv.Atoi(dsIDStr)
+   if err != nil {
+   return errors.New("dsID must be an integer"), nil, 
http.StatusBadRequest
+   }
+   v.ID = 
+
+   // Check that we can delete it
+   if respCode, usrErr, sysErr := checkFedDSDeletion(v.APIInfo().Tx.Tx, 
*v.fedID, dsID); usrErr != nil || sysErr != nil {
+   if usrErr != nil {
+   return usrErr, sysErr, respCode
+   }
+   return usrErr, sysErr, respCode
+   }
+
+   // Actually delete the DS from the Federation
+   if err := deleteFedDS(v.APIInfo().Tx.Tx, *v.fedID, dsID); err != nil {
 
 Review comment:
   given that I did not add it on the GET rewrite (and the POST that was 
rewritten and merged before that)  I say that we do not add it here as we 
should add it to all three at the same time instead of partial support.
   
   Going forward we should come to an agreeance if rewrites should include 
tenancy checks or not. 


This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
 
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org


With regards,
Apache Git Services

[GitHub] [trafficcontrol] lbathina commented on issue #3977: TP: Adds Server Capabilities UI

[GitBox]

lbathina commented on issue #3977: TP: Adds Server Capabilities UI
URL: https://github.com/apache/trafficcontrol/pull/3977#issuecomment-541208904
 
 
   > > Also there should be a check on only special characters - system should 
not accept only special characters.
   > 
   > define special
   
   following doesn't make sense. 
   ---
   -_-_-_


This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
 
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org


With regards,
Apache Git Services

[GitHub] [trafficcontrol] lbathina edited a comment on issue #3977: TP: Adds Server Capabilities UI

[GitBox]

lbathina edited a comment on issue #3977: TP: Adds Server Capabilities UI
URL: https://github.com/apache/trafficcontrol/pull/3977#issuecomment-541208904
 
 
   > > Also there should be a check on only special characters - system should 
not accept only special characters.
   > 
   > define special
   
   for example following names for server capabilities doesn't make sense. 
   `---`
   `-_-_-_`


This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
 
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org


With regards,
Apache Git Services

[GitHub] [trafficcontrol] lbathina edited a comment on issue #3977: TP: Adds Server Capabilities UI

[GitBox]

lbathina edited a comment on issue #3977: TP: Adds Server Capabilities UI
URL: https://github.com/apache/trafficcontrol/pull/3977#issuecomment-541208904
 
 
   > > Also there should be a check on only special characters - system should 
not accept only special characters.
   > 
   > define special
   
   following names for server capabilities doesn't make sense. 
   `---`
   `-_-_-_`


This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
 
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org


With regards,
Apache Git Services

[GitHub] [trafficcontrol] asf-ci commented on issue #3870: Rewrite /capabilities to Go

[GitBox]

asf-ci commented on issue #3870: Rewrite /capabilities to Go
URL: https://github.com/apache/trafficcontrol/pull/3870#issuecomment-541210512
 
 
   
   Refer to this link for build results (access rights to CI server needed): 
   https://builds.apache.org/job/trafficcontrol-PR/4464/
   


This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
 
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org


With regards,
Apache Git Services

Build failed in Jenkins: trafficcontrol-PR #4464

[Apache Jenkins Server]

See 


Changes:

[ocket] Rewrite profile import to Go (#3930)

[ocket] On cachestats get if all TMs fail to return data return failure 
(#3926)

[ocket] Remove atstccfg unused code (#3960)

[ocket] Gives admins the ability to mark delivery service requests as 
complete

[ocket] Rewrite get federation deliveryservices to Go (#3947)

[mitchell852] Added SMTP configuration and APIInfo Email method (#3925)

[mitchell852] Removed an unused/broken module from Traffic Portal (#3636)

[ocket] Fixes #3550 (#3558)

[ocket] Add TO Go server cache configs (#3899)

[mitchell852] Fixed double-build of TR RPMs in CiaB makefile (#3883)

[mitchell852] Rewrote jobs endpoints to go (#3744)

[jeffrey_elsloo] check outcome of enforce command

[jeffrey_elsloo] second attempt, remove return completely

[jeffrey_elsloo] added new isSteeringDS field to RGB json, first attempt at 
enforcing RGB

[jeffrey_elsloo] RGB NPE fix

[jeffrey_elsloo] added a new field to the rgb config to identify steering DSs.  
Do not

[jeffrey_elsloo] cleaned up formatting

[jeffrey_elsloo] fixed formatting issues

[jeffrey_elsloo] more formatting

[mitchell852] Fix broken unit tests and run go fmt (#3979)

[ocket] Fix broken api tests (#3983)

[ocket] Rewrote capabilities endpoints to GO

[ocket] Fixed incorrect parameter contraint

[ocket] Added godoc

[ocket] Added support in the Go Client for capabilities

[ocket] Added API/client tests

[ocket] Added Python client support

[ocket] Updated docs

[ocket] Added changelog updates

[ocket] Traffic Portal changes to reflect deprecation

[ocket] Fix API route definition for consistency

[ocket] Remove unnecessary debug line

[ocket] Use Fatalf when warranted

[ocket] Use API functions to write responses

[ocket] Add trailing newlines to API responses


--
[...truncated 3.14 MB...]
traffic_portal_build_1   | +-- extend@3.0.2 
traffic_portal_build_1   | +-- forever-agent@0.6.1 
traffic_portal_build_1   | +-- form-data@2.3.3 
traffic_portal_build_1   | | `-- asynckit@0.4.0 
traffic_portal_build_1   | +-- har-validator@5.1.3 
traffic_portal_build_1   | | +-- ajv@6.10.2 
traffic_portal_build_1   | | | +-- fast-deep-equal@2.0.1 
traffic_portal_build_1   | | | +-- 
fast-json-stable-stringify@2.0.0 
traffic_portal_build_1   | | | +-- json-schema-traverse@0.4.1 
traffic_portal_build_1   | | | `-- uri-js@4.2.2 
traffic_portal_build_1   | | |   `-- punycode@2.1.1 
traffic_portal_build_1   | | `-- har-schema@2.0.0 
traffic_portal_build_1   | +-- http-signature@1.2.0 
traffic_portal_build_1   | | +-- assert-plus@1.0.0 
traffic_portal_build_1   | | +-- jsprim@1.4.1 
traffic_portal_build_1   | | | +-- extsprintf@1.3.0 
traffic_portal_build_1   | | | +-- json-schema@0.2.3 
traffic_portal_build_1   | | | `-- verror@1.10.0 
traffic_portal_build_1   | | `-- sshpk@1.16.1 
traffic_portal_build_1   | |   +-- asn1@0.2.4 
traffic_portal_build_1   | |   +-- bcrypt-pbkdf@1.0.2 
traffic_portal_build_1   | |   +-- dashdash@1.14.1 
traffic_portal_build_1   | |   +-- ecc-jsbn@0.1.2 
traffic_portal_build_1   | |   +-- getpass@0.1.7 
traffic_portal_build_1   | |   +-- jsbn@0.1.1 
traffic_portal_build_1   | |   `-- tweetnacl@0.14.5 
traffic_portal_build_1   | +-- is-typedarray@1.0.0 
traffic_portal_build_1   | +-- json-stringify-safe@5.0.1 
traffic_portal_build_1   | +-- oauth-sign@0.9.0 
traffic_portal_build_1   | +-- performance-now@2.1.0 
traffic_portal_build_1   | +-- qs@6.5.2 
traffic_portal_build_1   | +-- tough-cookie@2.4.3 
traffic_portal_build_1   | | +-- psl@1.4.0 
traffic_portal_build_1   | | `-- punycode@1.4.1 
traffic_portal_build_1   | +-- tunnel-agent@0.6.0 
traffic_portal_build_1   | `-- uuid@3.3.3 
traffic_portal_build_1   | 
traffic_portal_build_1   | npm WARN optional SKIPPING OPTIONAL 
DEPENDENCY: fsevents@^1.0.0 (node_modules/chokidar/node_modules/fsevents):
traffic_portal_build_1   | npm WARN notsup SKIPPING OPTIONAL 
DEPENDENCY: Unsupported platform for fsevents@1.2.9: wanted 
{"os":"darwin","arch":"any"} (current: {"os":"linux","arch":"x64"})
traffic_portal_build_1   | npm WARN traffic_portal@ No description
traffic_portal_build_1   | npm WARN traffic_portal@ No repository 
field.
traffic_portal_build_1   | npm 

[GitHub] [trafficcontrol] mitchell852 commented on a change in pull request #3972: Add Server Capabilities blueprint

[GitBox]

mitchell852 commented on a change in pull request #3972: Add Server 
Capabilities blueprint
URL: https://github.com/apache/trafficcontrol/pull/3972#discussion_r334117890
 
 

 ##
 File path: blueprints/server-capabilitites.md
 ##
 @@ -0,0 +1,164 @@
+
+# Server Capabilities
+
+## Problem Description
+
+Suppose a Traffic Control operator has servers of a particular type. For 
example, servers with only Memory and no Disk cache. It's possible today to 
only route to those Edges, via manual Delivery Service Server assignments. But 
suppose you have a Mid server with only Memory and no Disk. Then suppose you 
have a certain class of traffic you need to route to this Mid, but not other 
traffic. For example, Delivery Services with small images; but not DSes with 
large binary files, which would destroy the cache. Right now, this isn't 
possible in Traffic Control.
+
+We propose a feature, called "Server Capabilitites" to solve this problem. 
Servers will have "capabilitites" and Delivery Services will have "Required 
Capabilitites," and if a server does not have a required capability, then it 
should not be manually assignable as an Edge, and a Mid must not be added as a 
parent for that DS in the Edge ATS config.
+
+Initially, this is completely backwards-compatible on upgrade, because 
initially no Delivery Service will have any Required Capabilities.
+
+This feature will be completely optional. TC operators who don't need Server 
Capabilities will simply not create them.
+
+Server Capabilities will be arbitrary strings. The ATS project will not "seed" 
any, and impose as little direction as possible. For example, Server 
Capabilitites could be Cache types, Server types, Hardware types, ATS versions, 
Lua support, other ATS plugin support, or any other features an operator needs 
to route (or not route) on.
+
+
+## Proposed Change
+
+- Servers have Capabilities (i.e.: CACHE_MEMORY, CACHE_DISK )
+
+- Delivery Services have Required Capabilities (i.e.: CACHE_MEMORY, CACHE_DISK)
+
+- When generating Configuration (e.g. ATS parent.config):
+  - If a Mid Server which is otherwise parented to an Edge does not have all 
Required Capabilities of a Delivery Service, that Mid will not be inserted as a 
parent for that Delivery Service’s remap and parent rules.
+  - Backward Compatibility is automatic:
+- Initially, no Delivery Services have Required Capabilities. Hence, 
everything behaves like it does today.
+- If an EDGE server does not have all capabilities required by a DS, that 
server SHOULD NOT be assignable to that DS. 
+- If an EDGE server is assigned to a DS which requires capabilities that 
server has, it SHOULD NOT be possible to remove those capabilities from that 
server.
+
+- Initially, Server Capability names are limited to `[a-Z]`, `[0-9]`, `_`, and 
`-`. This allows them to be put in most parts of a URI, as well as being the 
characters of Base64 URL Encoding. We may decide to allow high unicode later. 
But for now, since we're not sure yet what usage will look like, it's much 
easier to add characters later without breaking people, than it is to remove 
them.
+
+### Traffic Portal Impact
+
+- Server Page
+  - New dropdown to add to a text list: Capabilities
 
 Review comment:
   I would go this route IF the server capabilities were part of the server 
object but since they are not I will probably create a UI experience similar to 
how you assign servers to a delivery service. For example, when viewing a 
server, you click "More > Manage Server Capabilities" which takes you to:
   
   `tp.domain.com/#!/servers/4/capabilities`
   
   where you can add and remove server capabilities as needed. Sound ok?


This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
 
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org


With regards,
Apache Git Services

[GitHub] [trafficcontrol] ocket8888 merged pull request #3985: Remove commented out PATCH /jobs code, api_capability, and docs

[GitBox]

ocket merged pull request #3985: Remove commented out PATCH /jobs code, 
api_capability, and docs
URL: https://github.com/apache/trafficcontrol/pull/3985
 
 
   


This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
 
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org


With regards,
Apache Git Services

Build failed in Jenkins: trafficcontrol-traffic_ops-test #1570

[Apache Jenkins Server]

See 


Changes:

[ocket] Remove commented out PATCH /jobs code, api_capability, and docs 
(#3985)


--
Started by an SCM change
Started by an SCM change
Started by an SCM change
Started by an SCM change
Started by an SCM change
Started by an SCM change
Running as SYSTEM
[EnvInject] - Loading node environment variables.
Building remotely on H40 (ubuntu xenial) in workspace 

using credential b205a645-1ea7-4dfd-973d-c14ac43cab07
 > git rev-parse --is-inside-work-tree # timeout=10
Fetching changes from the remote Git repository
 > git config remote.origin.url git://github.com/apache/trafficcontrol.git # 
 > timeout=10
Fetching upstream changes from git://github.com/apache/trafficcontrol.git
 > git --version # timeout=10
using GIT_SSH to set credentials 
 > git fetch --tags --progress git://github.com/apache/trafficcontrol.git 
 > +refs/heads/*:refs/remotes/origin/*
 > git rev-parse refs/remotes/origin/master^{commit} # timeout=10
 > git rev-parse refs/remotes/origin/origin/master^{commit} # timeout=10
Checking out Revision d9fa791cde878152a4421276425bb586da4fef03 
(refs/remotes/origin/master)
 > git config core.sparsecheckout # timeout=10
 > git checkout -f d9fa791cde878152a4421276425bb586da4fef03
Commit message: "Remove commented out PATCH /jobs code, api_capability, and 
docs (#3985)"
 > git rev-list --no-walk 9037f2ffa0d5141612fe79138066e790b9d8802d # timeout=10
[trafficcontrol-traffic_ops-test] $ /bin/bash /tmp/jenkins4984145590601021552.sh
docker-compose version 1.24.1, build 4667896
docker-py version: 3.7.2
CPython version: 2.7.12
OpenSSL version: OpenSSL 1.0.2g  1 Mar 2016
+ trap finish EXIT
+ proj=jenkins-trafficcontrol-traffic_ops-test-1570
++ pwd
+ 
compose=
+ cfile=traffic_ops/app/bin/tests/docker-compose.yml
+ [[ -z 

 ]]
+ [[ ! -x 

 ]]
+ 

 -p jenkins-trafficcontrol-traffic_ops-test-1570 -f 
traffic_ops/app/bin/tests/docker-compose.yml up --build --exit-code-from 
unit_golang unit_golang
using --exit-code-from implies --abort-on-container-exit
Creating network "jenkinstrafficcontroltrafficopstest1570_default" with the 
default driver
Creating volume "jenkinstrafficcontroltrafficopstest1570_traffic_ops" with 
default driver
Creating volume "jenkinstrafficcontroltrafficopstest1570_traffic_ops_golang" 
with default driver
Building unit_golang
Step 1/7 : FROM golang:1.11
 ---> 43a154fee764
Step 2/7 : MAINTAINER d...@trafficcontrol.apache.org
 ---> Using cache
 ---> 836182d7b678
Step 3/7 : ARG DIR=github.com/apache/trafficcontrol
 ---> Using cache
 ---> 9a0ff96e1463
Step 4/7 : ADD traffic_ops /go/src/$DIR/traffic_ops
 ---> 3ecf41fae578
Step 5/7 : ADD lib /go/src/$DIR/lib
 ---> a5e5f602227a
Step 6/7 : WORKDIR /go/src/$DIR/traffic_ops/traffic_ops_golang
 ---> Running in f3b67989b436
Removing intermediate container f3b67989b436
 ---> b3301af73858
Step 7/7 : CMD bash -c 'go get -v && go test -cover -v ./... 
../../lib/go-tc/...'
 ---> Running in 50dbdf000c38
Removing intermediate container 50dbdf000c38
 ---> 96ea5ad2c5a6
Successfully built 96ea5ad2c5a6
Successfully tagged jenkinstrafficcontroltrafficopstest1570_unit_golang:latest
Creating jenkinstrafficcontroltrafficopstest1570_unit_golang_1 ... 
Creating jenkinstrafficcontroltrafficopstest1570_unit_golang_1
Creating jenkinstrafficcontroltrafficopstest1570_unit_golang_1 ... 
error
ERROR: for jenkinstrafficcontroltrafficopstest1570_unit_golang_1  Cannot start 
service unit_golang: no status provided on response: unknown

ERROR: for unit_golang  Cannot start service unit_golang: no status provided on 
response: unknown
Encountered errors while bringing up the project.
+ exit 1
+ finish
+ local st=1
+ [[ 1 -ne 0 ]]
+ echo 'Exiting with status 1'
Exiting with status 1
+ 

 -p jenkins-trafficcontrol-traffic_ops-test-1570 -f 
traffic_ops/app/bin/tests/docker-compose.yml down -v
Removing jenkinstrafficcontroltrafficopstest1570_unit_golang_1 ... 
Removing jenkinstrafficcontroltrafficopstest1570_unit_golang_1 ... 
doneRemoving network 
jenkinstrafficcontroltrafficopstest1570_default
Removing volume jenkinstrafficcontroltrafficopstest1570_traffic_ops
Removing volume jenkinstrafficcontroltrafficopstest1570_traffic_ops_golang
Build step 'Execute shell' marked build as failure

[GitHub] [trafficcontrol] ocket8888 commented on a change in pull request #3967: Rewrite DELETE federation delivery service to golang

[GitBox]

ocket commented on a change in pull request #3967: Rewrite DELETE 
federation delivery service to golang
URL: https://github.com/apache/trafficcontrol/pull/3967#discussion_r334146811
 
 

 ##
 File path: traffic_ops/traffic_ops_golang/federations/ds.go
 ##
 @@ -123,11 +131,93 @@ func (v *TOFedDSes) ParamColumns() 
map[string]dbhelpers.WhereColumnInfo {
}
 }
 func (v *TOFedDSes) GetType() string {
-   return "federation_deliveryservice"
+   return "federation deliveryservice"
+}
+
+func (v *TOFedDSes) SetKeys(keys map[string]interface{}) {
+   i, _ := keys["id"].(int)
+   v.fedID = 
+}
+
+func (v *TOFedDSes) GetKeys() (map[string]interface{}, bool) {
+   if v.fedID == nil {
+   return map[string]interface{}{"id": 0}, false
+   }
+   return map[string]interface{}{"id": *v.fedID}, true
+}
+
+func (v *TOFedDSes) GetAuditName() string {
+   if v.XMLID != nil {
+   return *v.XMLID
+   }
+   return strconv.Itoa(*v.ID)
+}
+
+func (v *TOFedDSes) GetKeyFieldsInfo() []api.KeyFieldInfo {
+   return []api.KeyFieldInfo{
+   {"id", api.GetIntKey},
+   }
 }
 
 func (v *TOFedDSes) Read() ([]interface{}, error, error, int) { return 
api.GenericRead(v) }
 
+func (v *TOFedDSes) Delete() (error, error, int) {
+   dsIDStr, ok := v.APIInfo().Params["dsID"]
+   if !ok {
+   return errors.New("dsID must be specified for deletion"), nil, 
http.StatusBadRequest
+   }
+   dsID, err := strconv.Atoi(dsIDStr)
+   if err != nil {
+   return errors.New("dsID must be an integer"), nil, 
http.StatusBadRequest
+   }
+   v.ID = 
+
+   // Check that we can delete it
+   if respCode, usrErr, sysErr := checkFedDSDeletion(v.APIInfo().Tx.Tx, 
*v.fedID, dsID); usrErr != nil || sysErr != nil {
+   if usrErr != nil {
+   return usrErr, sysErr, respCode
+   }
+   return usrErr, sysErr, respCode
+   }
+
+   // Actually delete the DS from the Federation
+   if err := deleteFedDS(v.APIInfo().Tx.Tx, *v.fedID, dsID); err != nil {
 
 Review comment:
   Should this check tenancy? I'm sure Perl didn't, so it's probably not 
strictly necessary for a rewrite, but something to consider.


This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
 
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org


With regards,
Apache Git Services

[GitHub] [trafficcontrol] ocket8888 commented on a change in pull request #3967: Rewrite DELETE federation delivery service to golang

[GitBox]

ocket commented on a change in pull request #3967: Rewrite DELETE 
federation delivery service to golang
URL: https://github.com/apache/trafficcontrol/pull/3967#discussion_r334146455
 
 

 ##
 File path: traffic_ops/traffic_ops_golang/federations/ds.go
 ##
 @@ -123,11 +131,93 @@ func (v *TOFedDSes) ParamColumns() 
map[string]dbhelpers.WhereColumnInfo {
}
 }
 func (v *TOFedDSes) GetType() string {
-   return "federation_deliveryservice"
+   return "federation deliveryservice"
+}
+
+func (v *TOFedDSes) SetKeys(keys map[string]interface{}) {
+   i, _ := keys["id"].(int)
+   v.fedID = 
+}
+
+func (v *TOFedDSes) GetKeys() (map[string]interface{}, bool) {
+   if v.fedID == nil {
+   return map[string]interface{}{"id": 0}, false
+   }
+   return map[string]interface{}{"id": *v.fedID}, true
+}
+
+func (v *TOFedDSes) GetAuditName() string {
+   if v.XMLID != nil {
+   return *v.XMLID
+   }
+   return strconv.Itoa(*v.ID)
+}
+
+func (v *TOFedDSes) GetKeyFieldsInfo() []api.KeyFieldInfo {
+   return []api.KeyFieldInfo{
+   {"id", api.GetIntKey},
+   }
 }
 
 func (v *TOFedDSes) Read() ([]interface{}, error, error, int) { return 
api.GenericRead(v) }
 
+func (v *TOFedDSes) Delete() (error, error, int) {
+   dsIDStr, ok := v.APIInfo().Params["dsID"]
+   if !ok {
+   return errors.New("dsID must be specified for deletion"), nil, 
http.StatusBadRequest
+   }
+   dsID, err := strconv.Atoi(dsIDStr)
+   if err != nil {
+   return errors.New("dsID must be an integer"), nil, 
http.StatusBadRequest
+   }
+   v.ID = 
+
+   // Check that we can delete it
+   if respCode, usrErr, sysErr := checkFedDSDeletion(v.APIInfo().Tx.Tx, 
*v.fedID, dsID); usrErr != nil || sysErr != nil {
+   if usrErr != nil {
+   return usrErr, sysErr, respCode
+   }
+   return usrErr, sysErr, respCode
+   }
+
+   // Actually delete the DS from the Federation
+   if err := deleteFedDS(v.APIInfo().Tx.Tx, *v.fedID, dsID); err != nil {
+   return api.ParseDBError(err)
+   }
+
+   return nil, nil, http.StatusOK
+}
+
+func checkFedDSDeletion(tx *sql.Tx, fedID, dsID int) (int, error, error) {
+
+   q := `SELECT ARRAY(SELECT deliveryservice FROM 
federation_deliveryservice WHERE federation=$1)`
+   dsIDs := []int64{} // pg.Array does not support int slice needs to be 
int64
 
 Review comment:
   nit: `pq.Array`, not `pg.Array`


This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
 
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org


With regards,
Apache Git Services

[GitHub] [trafficcontrol] rawlinp opened a new pull request #3987: Add extension user config to CIAB TO API tests

[GitBox]

rawlinp opened a new pull request #3987: Add extension user config to CIAB TO 
API tests
URL: https://github.com/apache/trafficcontrol/pull/3987
 
 
   
   
   ## What does this PR (Pull Request) do?
   
   The extension user config was recently added to the TO API tests and
   needs to be added to the CIAB-ized TO API tests as well.
   
   - [x] This PR is not related to any Issue 
   
   
   ## Which Traffic Control components are affected by this PR?
   
   
   - CDN in a Box
   - tests
   
   ## What is the best way to verify this PR?
   
   Run the TO API tests via CIAB, verify they pass:
   ```
   cd infrastructure/cdn-in-a-box
   docker-compose -f docker-compose.yml --no-ansi up --no-deps --build dns db 
trafficops trafficops-perl
   docker-compose -f docker-compose.traffic-ops-test.yml -f docker-compose.yml 
--no-ansi  up --build integration
   ```
   
   
   ## The following criteria are ALL met by this PR
   
   - [x] This PR fixes tests
   - [x] Fixes tests, documentation is unnecessary
   - [x] This PR includes an update to CHANGELOG.md OR such an update is not 
necessary
   - [x] This PR includes any and all required license headers
   - [x] This PR ensures that database migration sequence is correct OR this PR 
does not include a database migration
   - [x] This PR **DOES NOT FIX A SERIOUS SECURITY VULNERABILITY** (see [the 
Apache Software Foundation's security 
guidelines](https://www.apache.org/security/) for details)
   
   
   


This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
 
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org


With regards,
Apache Git Services

[GitHub] [trafficcontrol] ocket8888 commented on issue #3901: Fixed runtime panic when creating roles, added docs

[GitBox]

ocket commented on issue #3901: Fixed runtime panic when creating roles, 
added docs
URL: https://github.com/apache/trafficcontrol/pull/3901#issuecomment-541205261
 
 
   retest this please


This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
 
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org


With regards,
Apache Git Services

[GitHub] [trafficcontrol] lbathina commented on issue #3977: TP: Adds Server Capabilities UI

[GitBox]

lbathina commented on issue #3977: TP: Adds Server Capabilities UI
URL: https://github.com/apache/trafficcontrol/pull/3977#issuecomment-541209743
 
 
   > > I'd like to remove allowing dot, if no one objects.
   > 
   > I'm good with that. Is this a good UI error message?
   > 
   > `Must be alphanumeric with no spaces. Dash and underscore are also 
allowed.`
   Name may contain alphabets, numbers, special character Dash and underscore.
   I guess Alphanumberic is different than saying can contain numbers, 
alphabets. 
   > 
   > based on that. This is fine:
   > 
   > `---`
   > `-_-_-_`
   > `22`
   > 
   > not really sure anyone would do thatbut they could...
   
   


This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
 
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org


With regards,
Apache Git Services

[GitHub] [trafficcontrol] asf-ci commented on issue #3870: Rewrite /capabilities to Go

[GitBox]

asf-ci commented on issue #3870: Rewrite /capabilities to Go
URL: https://github.com/apache/trafficcontrol/pull/3870#issuecomment-541227233
 
 
   
   Refer to this link for build results (access rights to CI server needed): 
   https://builds.apache.org/job/trafficcontrol-PR/4465/
   


This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
 
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org


With regards,
Apache Git Services

Build failed in Jenkins: trafficcontrol-PR #4465

[Apache Jenkins Server]

See 


Changes:

[ocket] fix compilation error

[ocket] Switch URL building to use proper net/url encoding


--
GitHub pull request #3870 of commit d572e3335456fc95a17c02b443f9b5ad2ff0ff7e, 
no merge conflicts.
Running as SYSTEM
Setting status of d572e3335456fc95a17c02b443f9b5ad2ff0ff7e to PENDING with url 
https://builds.apache.org/job/trafficcontrol-PR/4465/ and message: 'Build 
started for merge commit.'
Using context: default
[EnvInject] - Loading node environment variables.
Building remotely on H43 (ubuntu xenial) in workspace 

[WS-CLEANUP] Deleting project workspace...
[WS-CLEANUP] Deferred wipeout is used...
using credential b205a645-1ea7-4dfd-973d-c14ac43cab07
Cloning the remote Git repository
Cloning repository git://github.com/apache/trafficcontrol.git
 > git init  # timeout=10
Fetching upstream changes from git://github.com/apache/trafficcontrol.git
 > git --version # timeout=10
using GIT_SSH to set credentials 
 > git fetch --tags --progress git://github.com/apache/trafficcontrol.git 
 > +refs/heads/*:refs/remotes/origin/*
 > git config remote.origin.url git://github.com/apache/trafficcontrol.git # 
 > timeout=10
 > git config --add remote.origin.fetch +refs/heads/*:refs/remotes/origin/* # 
 > timeout=10
 > git config remote.origin.url git://github.com/apache/trafficcontrol.git # 
 > timeout=10
Fetching upstream changes from git://github.com/apache/trafficcontrol.git
using GIT_SSH to set credentials 
 > git fetch --tags --progress git://github.com/apache/trafficcontrol.git 
 > +refs/pull/*:refs/remotes/origin/pr/*
 > git rev-parse d572e3335456fc95a17c02b443f9b5ad2ff0ff7e^{commit} # timeout=10
Checking out Revision d572e3335456fc95a17c02b443f9b5ad2ff0ff7e (detached)
 > git config core.sparsecheckout # timeout=10
 > git checkout -f d572e3335456fc95a17c02b443f9b5ad2ff0ff7e
Commit message: "Switch URL building to use proper net/url encoding"
 > git rev-list --no-walk 6a491b8ac1c916e695148c2daffd9d13bdc2cbd7 # timeout=10
[trafficcontrol-PR] $ /bin/bash /tmp/jenkins6990633229526149503.sh
++ echo jenkins-trafficcontrol-PR-4465
++ sed s/jenkins//
++ sed s/-//g
+ proj=trafficcontrolPR4465
+ yml=infrastructure/docker/build/docker-compose.yml
++ mktemp /tmp/docker-compose-
+ dc=/tmp/docker-compose-oDNI
++ mktemp /tmp/tc-status-
+ st=/tmp/tc-status-18WL
+ trap finish EXIT
++ uname -s
++ uname -m
+ curl -o /tmp/docker-compose-oDNI -L 
https://github.com/docker/compose/releases/download/1.13.0/docker-compose-Linux-x86_64
  % Total% Received % Xferd  Average Speed   TimeTime Time  Current
 Dload  Upload   Total   SpentLeft  Speed
  0 00 00 0  0  0 --:--:-- --:--:-- --:--:-- 0  
0 00 00 0  0  0 --:--:-- --:--:-- --:--:-- 0100 
  6170   6170 0956  0 --:--:-- --:--:-- --:--:--   955
  3 8079k3  304k0 0   207k  0  0:00:38  0:00:01  0:00:37  
207k100 8079k  100 8079k0 0  4452k  0  0:00:01  0:00:01 --:--:-- 
22.0M
+ chmod +x /tmp/docker-compose-oDNI
+ rm -rf dist
+ /tmp/docker-compose-oDNI -f infrastructure/docker/build/docker-compose.yml -p 
trafficcontrolPR4465 up
Creating network "trafficcontrolpr4465_default" with the default driver
Building traffic_stats_build
Step 1/7 : FROM centos:7
7: Pulling from library/centos
Digest: sha256:307835c385f656ec2e2fec602cf093224173c51119bbebd602c53c3653a3d6eb
Status: Downloaded newer image for centos:7
 ---> 67fa590cfc1c
Step 2/7 : MAINTAINER d...@trafficcontrol.apache.org
 ---> Running in 54d71d61a2f0
Removing intermediate container 54d71d61a2f0
 ---> de6409f16807
Step 3/7 : VOLUME /trafficcontrol
 ---> Running in a71a8b02b31f
Removing intermediate container a71a8b02b31f
 ---> 392f4aa919b8
Step 4/7 : RUN  rpm --import /etc/pki/rpm-gpg/RPM-GPG-KEY-CentOS-7 &&   rpm 
--import https://dl.fedoraproject.org/pub/epel/RPM-GPG-KEY-EPEL-7 &&yum 
-y update ca-certificates &&yum -y install  epel-release && 
yum -y clean all
 ---> Running in 9ec9bb46c0c3
Service 'traffic_stats_build' failed to build: no status provided on response: 
unknown
+ exit 1
+ finish
+ /tmp/docker-compose-oDNI -f infrastructure/docker/build/docker-compose.yml -p 
trafficcontrolPR4465 down -v
Removing network trafficcontrolpr4465_default
+ /tmp/docker-compose-oDNI -f infrastructure/docker/build/docker-compose.yml -p 
trafficcontrolPR4465 rm -v -f
No stopped containers
+ rm -f /tmp/docker-compose-oDNI
Build step 'Execute shell' marked build as failure
Skipped archiving because build is not successful

[GitHub] [trafficcontrol] asf-ci commented on issue #3988: WIP Remove Traffic Ops Golang legacy tc.ApiErrorType

[GitBox]

asf-ci commented on issue #3988: WIP Remove Traffic Ops Golang legacy 
tc.ApiErrorType
URL: https://github.com/apache/trafficcontrol/pull/3988#issuecomment-541237431
 
 
   Can one of the admins verify this patch?


This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
 
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org


With regards,
Apache Git Services

Build failed in Jenkins: trafficcontrol-PR #4466

[Apache Jenkins Server]

See 

Changes:


--
GitHub pull request #3977 of commit 576dc0b61a243a93270a977f942ea95f951c78df, 
has merge conflicts.
Running as SYSTEM
Setting status of 576dc0b61a243a93270a977f942ea95f951c78df to PENDING with url 
https://builds.apache.org/job/trafficcontrol-PR/4466/ and message: 'Build 
started for original commit.'
Using context: default
[EnvInject] - Loading node environment variables.
Building remotely on H26 (ubuntu) in workspace 

[WS-CLEANUP] Deleting project workspace...
[WS-CLEANUP] Deferred wipeout is used...
using credential b205a645-1ea7-4dfd-973d-c14ac43cab07
Cloning the remote Git repository
Cloning repository git://github.com/apache/trafficcontrol.git
 > git init  # timeout=10
Fetching upstream changes from git://github.com/apache/trafficcontrol.git
 > git --version # timeout=10
using GIT_SSH to set credentials 
 > git fetch --tags --progress -- git://github.com/apache/trafficcontrol.git 
 > +refs/heads/*:refs/remotes/origin/*
 > git config remote.origin.url git://github.com/apache/trafficcontrol.git # 
 > timeout=10
 > git config --add remote.origin.fetch +refs/heads/*:refs/remotes/origin/* # 
 > timeout=10
 > git config remote.origin.url git://github.com/apache/trafficcontrol.git # 
 > timeout=10
Fetching upstream changes from git://github.com/apache/trafficcontrol.git
using GIT_SSH to set credentials 
 > git fetch --tags --progress -- git://github.com/apache/trafficcontrol.git 
 > +refs/pull/*:refs/remotes/origin/pr/*
 > git rev-parse 576dc0b61a243a93270a977f942ea95f951c78df^{commit} # timeout=10
 > git rev-parse origin/576dc0b61a243a93270a977f942ea95f951c78df^{commit} # 
 > timeout=10
 > git rev-parse 576dc0b61a243a93270a977f942ea95f951c78df^{commit} # timeout=10
ERROR: Couldn't find any revision to build. Verify the repository and branch 
configuration for this job.
Retrying after 10 seconds
using credential b205a645-1ea7-4dfd-973d-c14ac43cab07
 > git rev-parse --is-inside-work-tree # timeout=10
Fetching changes from the remote Git repository
 > git config remote.origin.url git://github.com/apache/trafficcontrol.git # 
 > timeout=10
Fetching upstream changes from git://github.com/apache/trafficcontrol.git
 > git --version # timeout=10
using GIT_SSH to set credentials 
 > git fetch --tags --progress -- git://github.com/apache/trafficcontrol.git 
 > +refs/pull/*:refs/remotes/origin/pr/*
 > git rev-parse 576dc0b61a243a93270a977f942ea95f951c78df^{commit} # timeout=10
 > git rev-parse origin/576dc0b61a243a93270a977f942ea95f951c78df^{commit} # 
 > timeout=10
 > git rev-parse 576dc0b61a243a93270a977f942ea95f951c78df^{commit} # timeout=10
ERROR: Couldn't find any revision to build. Verify the repository and branch 
configuration for this job.
Retrying after 10 seconds
using credential b205a645-1ea7-4dfd-973d-c14ac43cab07
 > git rev-parse --is-inside-work-tree # timeout=10
Fetching changes from the remote Git repository
 > git config remote.origin.url git://github.com/apache/trafficcontrol.git # 
 > timeout=10
Fetching upstream changes from git://github.com/apache/trafficcontrol.git
 > git --version # timeout=10
using GIT_SSH to set credentials 
 > git fetch --tags --progress -- git://github.com/apache/trafficcontrol.git 
 > +refs/pull/*:refs/remotes/origin/pr/*
 > git rev-parse 576dc0b61a243a93270a977f942ea95f951c78df^{commit} # timeout=10
 > git rev-parse origin/576dc0b61a243a93270a977f942ea95f951c78df^{commit} # 
 > timeout=10
 > git rev-parse 576dc0b61a243a93270a977f942ea95f951c78df^{commit} # timeout=10
ERROR: Couldn't find any revision to build. Verify the repository and branch 
configuration for this job.
Skipped archiving because build is not successful

[GitHub] [trafficcontrol] mitchell852 commented on issue #3966: Add server capabilities API

[GitBox]

mitchell852 commented on issue #3966: Add server capabilities API
URL: https://github.com/apache/trafficcontrol/pull/3966#issuecomment-541107333
 
 
   > Trimming whitespace should be fine. It should be documented, but the extra 
safety seems like a good thing to me.
   
   agree


This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
 
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org


With regards,
Apache Git Services

[GitHub] [trafficcontrol] mitchell852 edited a comment on issue #3966: Add server capabilities API

[GitBox]

mitchell852 edited a comment on issue #3966: Add server capabilities API
URL: https://github.com/apache/trafficcontrol/pull/3966#issuecomment-541107445
 
 
   > Unknown parameters should be ignored.
   
   unknown query params that is. agree.


This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
 
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org


With regards,
Apache Git Services

[GitHub] [trafficcontrol] mitchell852 commented on issue #3966: Add server capabilities API

[GitBox]

mitchell852 commented on issue #3966: Add server capabilities API
URL: https://github.com/apache/trafficcontrol/pull/3966#issuecomment-541107445
 
 
   > Unknown parameters should be ignored.
   
   agree


This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
 
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org


With regards,
Apache Git Services

[GitHub] [trafficcontrol] mitchell852 commented on issue #3977: TP: Adds Server Capabilities UI

[GitBox]

mitchell852 commented on issue #3977: TP: Adds Server Capabilities UI
URL: https://github.com/apache/trafficcontrol/pull/3977#issuecomment-541110531
 
 
   > Also there should be a check on only special characters - system should 
not accept only special characters.
   
   define special


This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
 
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org


With regards,
Apache Git Services

Build failed in Jenkins: trafficcontrol-PR #4455

[Apache Jenkins Server]

See 


Changes:

[rawlin_peters] Add server_capability goose migration

[rawlin_peters] Add server_capabilities API endpoints

[rawlin_peters] Add server capabilities methods to TO-Go client

[rawlin_peters] Add TO API tests for server capabilities

[rawlin_peters] Add CHANGELOG entry for server_capabilities

[rawlin_peters] Fix godoc comments on server_capabilities structs

[rawlin_peters] Addressed review comments

[rawlin_peters] Address PR review comments

[rawlin_peters] Address more PR feedback


--
GitHub pull request #3966 of commit efcaab23ae9b92c6db57ba2d4ba09c506589928f, 
no merge conflicts.
Running as SYSTEM
Setting status of efcaab23ae9b92c6db57ba2d4ba09c506589928f to PENDING with url 
https://builds.apache.org/job/trafficcontrol-PR/4455/ and message: 'Build 
started for merge commit.'
Using context: default
[EnvInject] - Loading node environment variables.
Building remotely on H41 (ubuntu xenial) in workspace 

[WS-CLEANUP] Deleting project workspace...
[WS-CLEANUP] Deferred wipeout is used...
using credential b205a645-1ea7-4dfd-973d-c14ac43cab07
Cloning the remote Git repository
Cloning repository git://github.com/apache/trafficcontrol.git
 > git init  # timeout=10
Fetching upstream changes from git://github.com/apache/trafficcontrol.git
 > git --version # timeout=10
using GIT_SSH to set credentials 
 > git fetch --tags --progress git://github.com/apache/trafficcontrol.git 
 > +refs/heads/*:refs/remotes/origin/*
 > git config remote.origin.url git://github.com/apache/trafficcontrol.git # 
 > timeout=10
 > git config --add remote.origin.fetch +refs/heads/*:refs/remotes/origin/* # 
 > timeout=10
 > git config remote.origin.url git://github.com/apache/trafficcontrol.git # 
 > timeout=10
Fetching upstream changes from git://github.com/apache/trafficcontrol.git
using GIT_SSH to set credentials 
 > git fetch --tags --progress git://github.com/apache/trafficcontrol.git 
 > +refs/pull/*:refs/remotes/origin/pr/*
 > git rev-parse efcaab23ae9b92c6db57ba2d4ba09c506589928f^{commit} # timeout=10
Checking out Revision efcaab23ae9b92c6db57ba2d4ba09c506589928f (detached)
 > git config core.sparsecheckout # timeout=10
 > git checkout -f efcaab23ae9b92c6db57ba2d4ba09c506589928f
Commit message: "Address more PR feedback"
 > git rev-list --no-walk 75821e8fc1e25a5426ca1fda58dc2b31b0f3c9c1 # timeout=10
[trafficcontrol-PR] $ /bin/bash /tmp/jenkins6423511491061958673.sh
++ echo jenkins-trafficcontrol-PR-4455
++ sed s/-//g
++ sed s/jenkins//
+ proj=trafficcontrolPR4455
+ yml=infrastructure/docker/build/docker-compose.yml
++ mktemp /tmp/docker-compose-
+ dc=/tmp/docker-compose-hB3q
++ mktemp /tmp/tc-status-
+ st=/tmp/tc-status-LQhO
+ trap finish EXIT
++ uname -s
++ uname -m
+ curl -o /tmp/docker-compose-hB3q -L 
https://github.com/docker/compose/releases/download/1.13.0/docker-compose-Linux-x86_64
  % Total% Received % Xferd  Average Speed   TimeTime Time  Current
 Dload  Upload   Total   SpentLeft  Speed
  0 00 00 0  0  0 --:--:-- --:--:-- --:--:-- 0  
0 00 00 0  0  0 --:--:-- --:--:-- --:--:-- 0100 
  6170   6170 0   1056  0 --:--:-- --:--:-- --:--:--  1054
  0 8079k0 00 0  0  0 --:--:--  0:00:01 --:--:-- 
0100 8079k  100 8079k0 0  4356k  0  0:00:01  0:00:01 --:--:-- 11.5M
+ chmod +x /tmp/docker-compose-hB3q
+ rm -rf dist
+ /tmp/docker-compose-hB3q -f infrastructure/docker/build/docker-compose.yml -p 
trafficcontrolPR4455 up
Creating network "trafficcontrolpr4455_default" with the default driver
Pulling weasel (licenseweasel/weasel:0.2)...
0.2: Pulling from licenseweasel/weasel
Digest: sha256:b0e6dcd71152636af6e3a6e7e2bae275f77ce6aa719314e47981424a3fa86d70
Status: Downloaded newer image for licenseweasel/weasel:0.2
Creating trafficcontrolpr4455_traffic_monitor_build_1 ... 
Creating trafficcontrolpr4455_weasel_1 ... 
Creating trafficcontrolpr4455_traffic_router_build_1 ... 
Creating trafficcontrolpr4455_source_1 ... 
Creating trafficcontrolpr4455_traffic_portal_build_1 ... 
Creating trafficcontrolpr4455_traffic_monitor_build_1
Creating trafficcontrolpr4455_traffic_stats_build_1 ... 
Creating trafficcontrolpr4455_docs_1 ... 
Creating trafficcontrolpr4455_grovetccfg_build_1 ... 
Creating trafficcontrolpr4455_grove_build_1 ... 
Creating trafficcontrolpr4455_weasel_1
Creating trafficcontrolpr4455_source_1
Creating trafficcontrolpr4455_traffic_ops_build_1 ... 
Creating trafficcontrolpr4455_traffic_router_build_1
Creating trafficcontrolpr4455_traffic_portal_build_1
Creating trafficcontrolpr4455_traffic_stats_build_1
Creating trafficcontrolpr4455_docs_1
Creating trafficcontrolpr4455_grovetccfg_build_1
Creating 

[GitHub] [trafficcontrol] asf-ci commented on issue #3966: Add server capabilities API

[GitBox]

asf-ci commented on issue #3966: Add server capabilities API
URL: https://github.com/apache/trafficcontrol/pull/3966#issuecomment-541134208
 
 
   
   Refer to this link for build results (access rights to CI server needed): 
   https://builds.apache.org/job/trafficcontrol-PR/4455/
   


This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
 
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org


With regards,
Apache Git Services

[GitHub] [trafficcontrol] rob05c edited a comment on issue #3982: Add Traffic Monitor gbps calculated stat.

[GitBox]

rob05c edited a comment on issue #3982: Add Traffic Monitor gbps calculated 
stat.
URL: https://github.com/apache/trafficcontrol/pull/3982#issuecomment-541090806
 
 
   Thanks! This is great, this small change is a big help to CDN operators!
   
   Would you mind adding a `CHANGELOG.md` entry? Since this is a new feature, 
it should have an entry for the next Release (`## [Unreleased]` header in the 
file). The `CHANGELOG.md` file is at the root of the project.
   
   I think this is ok without docs, we don't currently document the calculated 
stats in the Monitor.
   
   But, we've been trying to add tests for every new feature. Would you mind 
adding a small unit test for this?
   The ComputedStat funcs take a lot of data, but your func doesn't need most 
of the variables, so for the test, you can pass empty objects for everything 
but `info.Vitals.KbpsOut`, and then just verify that various Kbps inputs turn 
into the expected Gbps.
   
   Have you tested already, or run ATC before? If not, there are several ways 
you can do it. The easiest is probably to run a CDN-in-a-Box, instructions are 
here: 
https://traffic-control-cdn.readthedocs.io/en/latest/admin/quick_howto/ciab.html.
 A CDN is a complex thing though, if you hit issues, we're more than happy to 
help. We're on Slack, and also have an email list: 
https://traffic-control-cdn.readthedocs.io/en/latest/faq.html#how-do-i-get-help-with-traffic-control


This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
 
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org


With regards,
Apache Git Services

Build failed in Jenkins: trafficcontrol-traffic_ops-test #1569

[Apache Jenkins Server]

See 


Changes:

[ocket] Fix broken api tests (#3983)


--
Started by an SCM change
Running as SYSTEM
[EnvInject] - Loading node environment variables.
Building remotely on H40 (ubuntu xenial) in workspace 

using credential b205a645-1ea7-4dfd-973d-c14ac43cab07
 > git rev-parse --is-inside-work-tree # timeout=10
Fetching changes from the remote Git repository
 > git config remote.origin.url git://github.com/apache/trafficcontrol.git # 
 > timeout=10
Fetching upstream changes from git://github.com/apache/trafficcontrol.git
 > git --version # timeout=10
using GIT_SSH to set credentials 
 > git fetch --tags --progress git://github.com/apache/trafficcontrol.git 
 > +refs/heads/*:refs/remotes/origin/*
 > git rev-parse refs/remotes/origin/master^{commit} # timeout=10
 > git rev-parse refs/remotes/origin/origin/master^{commit} # timeout=10
Checking out Revision 9037f2ffa0d5141612fe79138066e790b9d8802d 
(refs/remotes/origin/master)
 > git config core.sparsecheckout # timeout=10
 > git checkout -f 9037f2ffa0d5141612fe79138066e790b9d8802d
Commit message: "Fix broken api tests (#3983)"
 > git rev-list --no-walk 9003567785f2608c31faa6c52fea74f704cc59c3 # timeout=10
[trafficcontrol-traffic_ops-test] $ /bin/bash /tmp/jenkins6626489485813833343.sh
docker-compose version 1.24.1, build 4667896
docker-py version: 3.7.2
CPython version: 2.7.12
OpenSSL version: OpenSSL 1.0.2g  1 Mar 2016
+ trap finish EXIT
+ proj=jenkins-trafficcontrol-traffic_ops-test-1569
++ pwd
+ 
compose=
+ cfile=traffic_ops/app/bin/tests/docker-compose.yml
+ [[ -z 

 ]]
+ [[ ! -x 

 ]]
+ 

 -p jenkins-trafficcontrol-traffic_ops-test-1569 -f 
traffic_ops/app/bin/tests/docker-compose.yml up --build --exit-code-from 
unit_golang unit_golang
using --exit-code-from implies --abort-on-container-exit
Creating network "jenkinstrafficcontroltrafficopstest1569_default" with the 
default driver
Creating volume "jenkinstrafficcontroltrafficopstest1569_traffic_ops" with 
default driver
Creating volume "jenkinstrafficcontroltrafficopstest1569_traffic_ops_golang" 
with default driver
Building unit_golang
Step 1/7 : FROM golang:1.11
1.11: Pulling from library/golang
Digest: sha256:e972c78795b22d5cfab02ac410aa2305fcc036319a7af51065d1af583cd3ec04
Status: Downloaded newer image for golang:1.11
 ---> 43a154fee764
Step 2/7 : MAINTAINER d...@trafficcontrol.apache.org
 ---> Running in b1809aa7e45d
Removing intermediate container b1809aa7e45d
 ---> 836182d7b678
Step 3/7 : ARG DIR=github.com/apache/trafficcontrol
 ---> Running in 9221b5b6f60a
Removing intermediate container 9221b5b6f60a
 ---> 9a0ff96e1463
Step 4/7 : ADD traffic_ops /go/src/$DIR/traffic_ops
 ---> f9aec8729c06
Step 5/7 : ADD lib /go/src/$DIR/lib
 ---> c9cdb33c23b4
Step 6/7 : WORKDIR /go/src/$DIR/traffic_ops/traffic_ops_golang
 ---> Running in e8d4a0afae03
Removing intermediate container e8d4a0afae03
 ---> 4e05d3ddcd3a
Step 7/7 : CMD bash -c 'go get -v && go test -cover -v ./... 
../../lib/go-tc/...'
 ---> Running in 7382eca0348b
Removing intermediate container 7382eca0348b
 ---> cbcafe2efa32
Successfully built cbcafe2efa32
Successfully tagged jenkinstrafficcontroltrafficopstest1569_unit_golang:latest
Creating jenkinstrafficcontroltrafficopstest1569_unit_golang_1 ... 
Creating jenkinstrafficcontroltrafficopstest1569_unit_golang_1
Creating jenkinstrafficcontroltrafficopstest1569_unit_golang_1 ... 
error
ERROR: for jenkinstrafficcontroltrafficopstest1569_unit_golang_1  Cannot start 
service unit_golang: no status provided on response: unknown

ERROR: for unit_golang  Cannot start service unit_golang: no status provided on 
response: unknown
Encountered errors while bringing up the project.
+ exit 1
+ finish
+ local st=1
+ [[ 1 -ne 0 ]]
+ echo 'Exiting with status 1'
Exiting with status 1
+ 

 -p jenkins-trafficcontrol-traffic_ops-test-1569 -f 
traffic_ops/app/bin/tests/docker-compose.yml down -v
Removing jenkinstrafficcontroltrafficopstest1569_unit_golang_1 ... 
Removing jenkinstrafficcontroltrafficopstest1569_unit_golang_1 ... 
doneRemoving network 
jenkinstrafficcontroltrafficopstest1569_default
Removing volume jenkinstrafficcontroltrafficopstest1569_traffic_ops
Removing volume jenkinstrafficcontroltrafficopstest1569_traffic_ops_golang
Build step 'Execute shell' marked build as failure

[GitHub] [trafficcontrol] mitchell852 edited a comment on issue #3966: Add server capabilities API

[GitBox]

mitchell852 edited a comment on issue #3966: Add server capabilities API
URL: https://github.com/apache/trafficcontrol/pull/3966#issuecomment-541107445
 
 
   > Unknown parameters should be ignored.
   
   unknown query params that is. agree. plus this is how our api has always 
behaved.


This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
 
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org


With regards,
Apache Git Services

[GitHub] [trafficcontrol] mitchell852 edited a comment on issue #3977: TP: Adds Server Capabilities UI

[GitBox]

mitchell852 edited a comment on issue #3977: TP: Adds Server Capabilities UI
URL: https://github.com/apache/trafficcontrol/pull/3977#issuecomment-541109856
 
 
   > I'd like to remove allowing dot, if no one objects.
   
   I'm good with that. Is this a good UI error message?
   
   `Must be alphanumeric with no spaces. Dash and underscore are  also allowed.`
   
   based on that. This is fine:
   
   `---`
   `-_-_-_`
   `22`
   
   not really sure anyone would do thatbut they could...


This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
 
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org


With regards,
Apache Git Services

[GitHub] [trafficcontrol] ocket8888 commented on issue #3982: Add Traffic Monitor gbps calculated stat.

[GitBox]

ocket commented on issue #3982: Add Traffic Monitor gbps calculated stat.
URL: https://github.com/apache/trafficcontrol/pull/3982#issuecomment-541127065
 
 
   With this change, what happens if there are conflicting maxKBPS and maxGBPS 
Parameters?


This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
 
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org


With regards,
Apache Git Services

[GitHub] [trafficcontrol] asf-ci commented on issue #3966: Add server capabilities API

[GitBox]

asf-ci commented on issue #3966: Add server capabilities API
URL: https://github.com/apache/trafficcontrol/pull/3966#issuecomment-541137404
 
 
   
   Refer to this link for build results (access rights to CI server needed): 
   https://builds.apache.org/job/trafficcontrol-PR/4458/
   


This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
 
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org


With regards,
Apache Git Services

Build failed in Jenkins: trafficcontrol-PR #4458

[Apache Jenkins Server]

See 


Changes:

[rawlin_peters] Add server_capability goose migration

[rawlin_peters] Add server_capabilities API endpoints

[rawlin_peters] Add server capabilities methods to TO-Go client

[rawlin_peters] Add TO API tests for server capabilities

[rawlin_peters] Add CHANGELOG entry for server_capabilities

[rawlin_peters] Fix godoc comments on server_capabilities structs

[rawlin_peters] Addressed review comments

[rawlin_peters] Address PR review comments

[rawlin_peters] Address more PR feedback

[rawlin_peters] Fix godoc comment before someone yells at me


--
GitHub pull request #3966 of commit 13625ca44eb9d856caa24bae44dc641a610c4488, 
no merge conflicts.
Running as SYSTEM
Setting status of 13625ca44eb9d856caa24bae44dc641a610c4488 to PENDING with url 
https://builds.apache.org/job/trafficcontrol-PR/4458/ and message: 'Build 
started for merge commit.'
Using context: default
[EnvInject] - Loading node environment variables.
Building remotely on H40 (ubuntu xenial) in workspace 

[WS-CLEANUP] Deleting project workspace...
[WS-CLEANUP] Deferred wipeout is used...
using credential b205a645-1ea7-4dfd-973d-c14ac43cab07
Cloning the remote Git repository
Cloning repository git://github.com/apache/trafficcontrol.git
 > git init  # timeout=10
Fetching upstream changes from git://github.com/apache/trafficcontrol.git
 > git --version # timeout=10
using GIT_SSH to set credentials 
 > git fetch --tags --progress git://github.com/apache/trafficcontrol.git 
 > +refs/heads/*:refs/remotes/origin/*
 > git config remote.origin.url git://github.com/apache/trafficcontrol.git # 
 > timeout=10
 > git config --add remote.origin.fetch +refs/heads/*:refs/remotes/origin/* # 
 > timeout=10
 > git config remote.origin.url git://github.com/apache/trafficcontrol.git # 
 > timeout=10
Fetching upstream changes from git://github.com/apache/trafficcontrol.git
using GIT_SSH to set credentials 
 > git fetch --tags --progress git://github.com/apache/trafficcontrol.git 
 > +refs/pull/*:refs/remotes/origin/pr/*
 > git rev-parse 13625ca44eb9d856caa24bae44dc641a610c4488^{commit} # timeout=10
Checking out Revision 13625ca44eb9d856caa24bae44dc641a610c4488 (detached)
 > git config core.sparsecheckout # timeout=10
 > git checkout -f 13625ca44eb9d856caa24bae44dc641a610c4488
Commit message: "Fix godoc comment before someone yells at me"
 > git rev-list --no-walk 230609efbf239cc8bf7e38521d773b9888d3bd41 # timeout=10
[trafficcontrol-PR] $ /bin/bash /tmp/jenkins1123966697421585766.sh
++ echo jenkins-trafficcontrol-PR-4458
++ sed s/-//g
++ sed s/jenkins//
+ proj=trafficcontrolPR4458
+ yml=infrastructure/docker/build/docker-compose.yml
++ mktemp /tmp/docker-compose-
+ dc=/tmp/docker-compose-iAzQ
++ mktemp /tmp/tc-status-
+ st=/tmp/tc-status-SWGp
+ trap finish EXIT
++ uname -s
++ uname -m
+ curl -o /tmp/docker-compose-iAzQ -L 
https://github.com/docker/compose/releases/download/1.13.0/docker-compose-Linux-x86_64
  % Total% Received % Xferd  Average Speed   TimeTime Time  Current
 Dload  Upload   Total   SpentLeft  Speed
  0 00 00 0  0  0 --:--:-- --:--:-- --:--:-- 0  
0 00 00 0  0  0 --:--:-- --:--:-- --:--:-- 0100 
  6170   6170 0   1010  0 --:--:-- --:--:-- --:--:--  1009
  6 8079k6  492k0 0   355k  0  0:00:22  0:00:01  0:00:21  
355k100 8079k  100 8079k0 0  4762k  0  0:00:01  0:00:01 --:--:-- 
23.7M
+ chmod +x /tmp/docker-compose-iAzQ
+ rm -rf dist
+ /tmp/docker-compose-iAzQ -f infrastructure/docker/build/docker-compose.yml -p 
trafficcontrolPR4458 up
Creating network "trafficcontrolpr4458_default" with the default driver
Building traffic_stats_build
Step 1/7 : FROM centos:7
 ---> 67fa590cfc1c
Step 2/7 : MAINTAINER d...@trafficcontrol.apache.org
 ---> Using cache
 ---> 48d4918b1747
Step 3/7 : VOLUME /trafficcontrol
 ---> Using cache
 ---> 26fe402f7071
Step 4/7 : RUN  rpm --import /etc/pki/rpm-gpg/RPM-GPG-KEY-CentOS-7 &&   rpm 
--import https://dl.fedoraproject.org/pub/epel/RPM-GPG-KEY-EPEL-7 &&yum 
-y update ca-certificates &&yum -y install  epel-release && 
yum -y clean all
 ---> Running in ec18cd936b88
Service 'traffic_stats_build' failed to build: no status provided on response: 
unknown
+ exit 1
+ finish
+ /tmp/docker-compose-iAzQ -f infrastructure/docker/build/docker-compose.yml -p 
trafficcontrolPR4458 down -v
Removing network trafficcontrolpr4458_default
+ /tmp/docker-compose-iAzQ -f infrastructure/docker/build/docker-compose.yml -p 
trafficcontrolPR4458 rm -v -f
No stopped containers
+ rm -f /tmp/docker-compose-iAzQ
Build step 'Execute shell' marked build as failure
Skipped archiving because build is not successful

[GitHub] [trafficcontrol] asf-ci commented on issue #3983: Fix broken api tests

[GitBox]

asf-ci commented on issue #3983: Fix broken api tests
URL: https://github.com/apache/trafficcontrol/pull/3983#issuecomment-541137126
 
 
   
   Refer to this link for build results (access rights to CI server needed): 
   https://builds.apache.org/job/trafficcontrol-PR/4457/
   


This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
 
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org


With regards,
Apache Git Services

Build failed in Jenkins: trafficcontrol-PR #4457

[Apache Jenkins Server]

See 


Changes:

[Michael_Hoppal] Fix broken api tests


--
GitHub pull request #3983 of commit 230609efbf239cc8bf7e38521d773b9888d3bd41, 
no merge conflicts.
Running as SYSTEM
Setting status of 230609efbf239cc8bf7e38521d773b9888d3bd41 to PENDING with url 
https://builds.apache.org/job/trafficcontrol-PR/4457/ and message: 'Build 
started for merge commit.'
Using context: default
[EnvInject] - Loading node environment variables.
Building remotely on H40 (ubuntu xenial) in workspace 

[WS-CLEANUP] Deleting project workspace...
[WS-CLEANUP] Deferred wipeout is used...
using credential b205a645-1ea7-4dfd-973d-c14ac43cab07
Cloning the remote Git repository
Cloning repository git://github.com/apache/trafficcontrol.git
 > git init  # timeout=10
Fetching upstream changes from git://github.com/apache/trafficcontrol.git
 > git --version # timeout=10
using GIT_SSH to set credentials 
 > git fetch --tags --progress git://github.com/apache/trafficcontrol.git 
 > +refs/heads/*:refs/remotes/origin/*
 > git config remote.origin.url git://github.com/apache/trafficcontrol.git # 
 > timeout=10
 > git config --add remote.origin.fetch +refs/heads/*:refs/remotes/origin/* # 
 > timeout=10
 > git config remote.origin.url git://github.com/apache/trafficcontrol.git # 
 > timeout=10
Fetching upstream changes from git://github.com/apache/trafficcontrol.git
using GIT_SSH to set credentials 
 > git fetch --tags --progress git://github.com/apache/trafficcontrol.git 
 > +refs/pull/*:refs/remotes/origin/pr/*
 > git rev-parse 230609efbf239cc8bf7e38521d773b9888d3bd41^{commit} # timeout=10
Checking out Revision 230609efbf239cc8bf7e38521d773b9888d3bd41 (detached)
 > git config core.sparsecheckout # timeout=10
 > git checkout -f 230609efbf239cc8bf7e38521d773b9888d3bd41
Commit message: "Fix broken api tests"
 > git rev-list --no-walk e1495e7bf0e3c3a8d97ca6793b55392a517a98f5 # timeout=10
[trafficcontrol-PR] $ /bin/bash /tmp/jenkins943940165693278825.sh
++ echo jenkins-trafficcontrol-PR-4457
++ sed s/-//g
++ sed s/jenkins//
+ proj=trafficcontrolPR4457
+ yml=infrastructure/docker/build/docker-compose.yml
++ mktemp /tmp/docker-compose-
+ dc=/tmp/docker-compose-OpHj
++ mktemp /tmp/tc-status-
+ st=/tmp/tc-status-5vQh
+ trap finish EXIT
++ uname -s
++ uname -m
+ curl -o /tmp/docker-compose-OpHj -L 
https://github.com/docker/compose/releases/download/1.13.0/docker-compose-Linux-x86_64
  % Total% Received % Xferd  Average Speed   TimeTime Time  Current
 Dload  Upload   Total   SpentLeft  Speed
  0 00 00 0  0  0 --:--:-- --:--:-- --:--:-- 
0100   6170   6170 0   1062  0 --:--:-- --:--:-- --:--:--  1063
  0 00 00 0  0  0 --:--:-- --:--:-- --:--:-- 
0100 8079k  100 8079k0 0  4781k  0  0:00:01  0:00:01 --:--:-- 8849k
+ chmod +x /tmp/docker-compose-OpHj
+ rm -rf dist
+ /tmp/docker-compose-OpHj -f infrastructure/docker/build/docker-compose.yml -p 
trafficcontrolPR4457 up
Creating network "trafficcontrolpr4457_default" with the default driver
Building traffic_stats_build
Step 1/7 : FROM centos:7
7: Pulling from library/centos
Digest: sha256:307835c385f656ec2e2fec602cf093224173c51119bbebd602c53c3653a3d6eb
Status: Downloaded newer image for centos:7
 ---> 67fa590cfc1c
Step 2/7 : MAINTAINER d...@trafficcontrol.apache.org
 ---> Running in e868a182a3e6
Removing intermediate container e868a182a3e6
 ---> 48d4918b1747
Step 3/7 : VOLUME /trafficcontrol
 ---> Running in 9ec15af65f0f
Removing intermediate container 9ec15af65f0f
 ---> 26fe402f7071
Step 4/7 : RUN  rpm --import /etc/pki/rpm-gpg/RPM-GPG-KEY-CentOS-7 &&   rpm 
--import https://dl.fedoraproject.org/pub/epel/RPM-GPG-KEY-EPEL-7 &&yum 
-y update ca-certificates &&yum -y install  epel-release && 
yum -y clean all
 ---> Running in 232c6fd1dff4
Service 'traffic_stats_build' failed to build: no status provided on response: 
unknown
+ exit 1
+ finish
+ /tmp/docker-compose-OpHj -f infrastructure/docker/build/docker-compose.yml -p 
trafficcontrolPR4457 down -v
Removing network trafficcontrolpr4457_default
+ /tmp/docker-compose-OpHj -f infrastructure/docker/build/docker-compose.yml -p 
trafficcontrolPR4457 rm -v -f
No stopped containers
+ rm -f /tmp/docker-compose-OpHj
Build step 'Execute shell' marked build as failure
Skipped archiving because build is not successful

Build failed in Jenkins: trafficcontrol-PR #4459

[Apache Jenkins Server]

See 


Changes:

[ocket] Rewrite profile import to Go (#3930)

[ocket] On cachestats get if all TMs fail to return data return failure 
(#3926)

[ocket] Remove atstccfg unused code (#3960)

[ocket] Gives admins the ability to mark delivery service requests as 
complete

[ocket] Rewrite get federation deliveryservices to Go (#3947)

[mitchell852] Added SMTP configuration and APIInfo Email method (#3925)

[mitchell852] Removed an unused/broken module from Traffic Portal (#3636)

[ocket] Fixes #3550 (#3558)

[ocket] Add TO Go server cache configs (#3899)

[mitchell852] Fixed double-build of TR RPMs in CiaB makefile (#3883)

[mitchell852] Rewrote jobs endpoints to go (#3744)

[jeffrey_elsloo] check outcome of enforce command

[jeffrey_elsloo] second attempt, remove return completely

[jeffrey_elsloo] added new isSteeringDS field to RGB json, first attempt at 
enforcing RGB

[jeffrey_elsloo] RGB NPE fix

[jeffrey_elsloo] added a new field to the rgb config to identify steering DSs.  
Do not

[jeffrey_elsloo] cleaned up formatting

[jeffrey_elsloo] fixed formatting issues

[jeffrey_elsloo] more formatting

[mitchell852] Fix broken unit tests and run go fmt (#3979)

[Michael_Hoppal] Fix broken api tests

[Michael_Hoppal] Change job response to 200 instead of 201 to follow conventions


--
GitHub pull request #3983 of commit d78e0c9e960286e11c389478a76d45bfb712babc, 
no merge conflicts.
Running as SYSTEM
Setting status of d78e0c9e960286e11c389478a76d45bfb712babc to PENDING with url 
https://builds.apache.org/job/trafficcontrol-PR/4459/ and message: 'Build 
started for merge commit.'
Using context: default
[EnvInject] - Loading node environment variables.
Building remotely on H37 (ubuntu xenial) in workspace 

[WS-CLEANUP] Deleting project workspace...
[WS-CLEANUP] Deferred wipeout is used...
using credential b205a645-1ea7-4dfd-973d-c14ac43cab07
Cloning the remote Git repository
Cloning repository git://github.com/apache/trafficcontrol.git
 > git init  # timeout=10
Fetching upstream changes from git://github.com/apache/trafficcontrol.git
 > git --version # timeout=10
using GIT_SSH to set credentials 
 > git fetch --tags --progress git://github.com/apache/trafficcontrol.git 
 > +refs/heads/*:refs/remotes/origin/*
 > git config remote.origin.url git://github.com/apache/trafficcontrol.git # 
 > timeout=10
 > git config --add remote.origin.fetch +refs/heads/*:refs/remotes/origin/* # 
 > timeout=10
 > git config remote.origin.url git://github.com/apache/trafficcontrol.git # 
 > timeout=10
Fetching upstream changes from git://github.com/apache/trafficcontrol.git
using GIT_SSH to set credentials 
 > git fetch --tags --progress git://github.com/apache/trafficcontrol.git 
 > +refs/pull/*:refs/remotes/origin/pr/*
 > git rev-parse d78e0c9e960286e11c389478a76d45bfb712babc^{commit} # timeout=10
Checking out Revision d78e0c9e960286e11c389478a76d45bfb712babc (detached)
 > git config core.sparsecheckout # timeout=10
 > git checkout -f d78e0c9e960286e11c389478a76d45bfb712babc
Commit message: "Change job response to 200 instead of 201 to follow 
conventions"
 > git rev-list --no-walk 13625ca44eb9d856caa24bae44dc641a610c4488 # timeout=10
[trafficcontrol-PR] $ /bin/bash /tmp/jenkins8247943988456302314.sh
++ echo jenkins-trafficcontrol-PR-4459
++ sed s/-//g
++ sed s/jenkins//
+ proj=trafficcontrolPR4459
+ yml=infrastructure/docker/build/docker-compose.yml
++ mktemp /tmp/docker-compose-
+ dc=/tmp/docker-compose-59fr
++ mktemp /tmp/tc-status-
+ st=/tmp/tc-status-z86r
+ trap finish EXIT
++ uname -s
++ uname -m
+ curl -o /tmp/docker-compose-59fr -L 
https://github.com/docker/compose/releases/download/1.13.0/docker-compose-Linux-x86_64
  % Total% Received % Xferd  Average Speed   TimeTime Time  Current
 Dload  Upload   Total   SpentLeft  Speed
  0 00 00 0  0  0 --:--:-- --:--:-- --:--:-- 0  
0 00 00 0  0  0 --:--:-- --:--:-- --:--:-- 0100 
  6170   6170 0   1058  0 --:--:-- --:--:-- --:--:--  1058
  0 8079k0 00 0  0  0 --:--:--  0:00:01 --:--:-- 
0100 8079k  100 8079k0 0  4729k  0  0:00:01  0:00:01 --:--:-- 12.7M
+ chmod +x /tmp/docker-compose-59fr
+ rm -rf dist
+ /tmp/docker-compose-59fr -f infrastructure/docker/build/docker-compose.yml -p 
trafficcontrolPR4459 up
Creating network "trafficcontrolpr4459_default" with the default driver
Pulling weasel (licenseweasel/weasel:0.2)...
0.2: Pulling from licenseweasel/weasel
Digest: sha256:b0e6dcd71152636af6e3a6e7e2bae275f77ce6aa719314e47981424a3fa86d70
Status: Downloaded newer image for licenseweasel/weasel:0.2
Creating trafficcontrolpr4459_traffic_ops_build_1 ... 

[GitHub] [trafficcontrol] asf-ci commented on issue #3983: Fix broken api tests

[GitBox]

asf-ci commented on issue #3983: Fix broken api tests
URL: https://github.com/apache/trafficcontrol/pull/3983#issuecomment-541141465
 
 
   
   Refer to this link for build results (access rights to CI server needed): 
   https://builds.apache.org/job/trafficcontrol-PR/4459/
   


This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
 
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org


With regards,
Apache Git Services

[GitHub] [trafficcontrol] rawlinp opened a new pull request #3985: Remove commented out PATCH /jobs code, api_capability, and docs

[GitBox]

rawlinp opened a new pull request #3985: Remove commented out PATCH /jobs code, 
api_capability, and docs
URL: https://github.com/apache/trafficcontrol/pull/3985
 
 
   
   
   
   ## What does this PR (Pull Request) do?
   
   
   The PATCH method was not included and should not be referenced by
   documentation or exist as an api_capability. In addition, commented-out
   code in the codebase is unnecessary cruft that makes the codebase harder
   to search and understand. If a PATCH method needs to be supported in the
   future, the commented-out code can be retrieved from the git history
   instead.
   
   - [x] This PR fixes is not related to any Issue 
   
   
   ## Which Traffic Control components are affected by this PR?
   
   
   - Documentation
   - Traffic Ops
   
   ## What is the best way to verify this PR?
   
   1. Verify traffic_ops_golang still builds and the unit tests pass
   2. Make sure the documentation still builds
   3. Run `db/admin seed` to re-run the `seeds.sql` file on TODB, make sure it 
succeeds
   
   ## The following criteria are ALL met by this PR
   
   
   - [x] This PR includes tests OR I have explained why tests are unnecessary
   - [x] This PR includes documentation OR I have explained why documentation 
is unnecessary
   - [x] This PR includes an update to CHANGELOG.md OR such an update is not 
necessary
   - [x] This PR includes any and all required license headers
   - [x] This PR ensures that database migration sequence is correct OR this PR 
does not include a database migration
   - [x] This PR **DOES NOT FIX A SERIOUS SECURITY VULNERABILITY** (see [the 
Apache Software Foundation's security 
guidelines](https://www.apache.org/security/) for details)
   
   
   


This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
 
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org


With regards,
Apache Git Services

[GitHub] [trafficcontrol] ocket8888 commented on a change in pull request #3870: Rewrite /capabilities to Go

[GitBox]

ocket commented on a change in pull request #3870: Rewrite /capabilities to 
Go
URL: https://github.com/apache/trafficcontrol/pull/3870#discussion_r334100766
 
 

 ##
 File path: lib/go-tc/capabilities.go
 ##
 @@ -0,0 +1,38 @@
+package tc
+
+/*
+ * Licensed to the Apache Software Foundation (ASF) under one
+ * or more contributor license agreements.  See the NOTICE file
+ * distributed with this work for additional information
+ * regarding copyright ownership.  The ASF licenses this file
+ * to you under the Apache License, Version 2.0 (the
+ * "License"); you may not use this file except in compliance
+ * with the License.  You may obtain a copy of the License at
+ *
+ *   http://www.apache.org/licenses/LICENSE-2.0
+ *
+ * Unless required by applicable law or agreed to in writing,
+ * software distributed under the License is distributed on an
+ * "AS IS" BASIS, WITHOUT WARRANTIES OR CONDITIONS OF ANY
+ * KIND, either express or implied.  See the License for the
+ * specific language governing permissions and limitations
+ * under the License.
+ */
+
+// Capability reflects the ability of a user in ATC to perform some operation.
+//
+// In practice, they are assigned to relevant Traffic Ops API endpoints - to 
describe the
+// capabilites of said endpoint - and to user permission Roles - to describe 
the capabilities
+// afforded by said Role. Note that enforcement of Capability-based permisions 
is not currently
+// implemented.
+type Capability struct {
+   Description string `json:"description"`
 
 Review comment:
   I don't think I need them, do I?


This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
 
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org


With regards,
Apache Git Services

[GitHub] [trafficcontrol] mitchell852 commented on issue #3977: TP: Adds Server Capabilities UI

[GitBox]

mitchell852 commented on issue #3977: TP: Adds Server Capabilities UI
URL: https://github.com/apache/trafficcontrol/pull/3977#issuecomment-541108652
 
 
   > leading and trailing spaces are ignore and doesn't throw errors.
   
   i think that's fine. the api strips them out.


This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
 
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org


With regards,
Apache Git Services

[GitHub] [trafficcontrol] rob05c commented on issue #3982: Add Traffic Monitor gbps calculated stat.

[GitBox]

rob05c commented on issue #3982: Add Traffic Monitor gbps calculated stat.
URL: https://github.com/apache/trafficcontrol/pull/3982#issuecomment-541128257
 
 
   You mean as threshold? You can apply any number of thresholds to the 
Monitor. Whatever is lowest will make it Unavailable first.


This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
 
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org


With regards,
Apache Git Services

[GitHub] [trafficcontrol] mhoppa opened a new pull request #3983: Fix broken api tests

[GitBox]

mhoppa opened a new pull request #3983: Fix broken api tests
URL: https://github.com/apache/trafficcontrol/pull/3983
 
 
   
   ## What does this PR (Pull Request) do?
   
   
   - [x] This PR fixes is not related to any Issue 
   
   
   ## Which Traffic Control components are affected by this PR?
   
   
   ## What is the best way to verify this PR?
   
   
   ## If this is a bug fix, what versions of Traffic Control are affected?
   
   
   
   ## The following criteria are ALL met by this PR
   
   
   - [x] I have explained why tests are unnecessary
   - [x]  I have explained why documentation is unnecessary
   - [x] This PR does not include an update to CHANGELOG.md
   - [x] This PR includes any and all required license headers
   - [x] This PR ensures that database migration sequence is correct OR this PR 
does not include a database migration
   - [x] This PR **DOES NOT FIX A SERIOUS SECURITY VULNERABILITY** (see [the 
Apache Software Foundation's security 
guidelines](https://www.apache.org/security/) for details)
   
   
   


This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
 
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org


With regards,
Apache Git Services

[GitHub] [trafficcontrol] ocket8888 merged pull request #3983: Fix broken api tests

[GitBox]

ocket merged pull request #3983: Fix broken api tests
URL: https://github.com/apache/trafficcontrol/pull/3983
 
 
   


This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
 
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org


With regards,
Apache Git Services

[GitHub] [trafficcontrol] asf-ci commented on issue #3985: Remove commented out PATCH /jobs code, api_capability, and docs

[GitBox]

asf-ci commented on issue #3985: Remove commented out PATCH /jobs code, 
api_capability, and docs
URL: https://github.com/apache/trafficcontrol/pull/3985#issuecomment-541152432
 
 
   
   Refer to this link for build results (access rights to CI server needed): 
   https://builds.apache.org/job/trafficcontrol-PR/4460/
   


This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
 
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org


With regards,
Apache Git Services

[GitHub] [trafficcontrol] rawlinp commented on issue #3966: Add server capabilities API

[GitBox]

rawlinp commented on issue #3966: Add server capabilities API
URL: https://github.com/apache/trafficcontrol/pull/3966#issuecomment-541113266
 
 
   > 1. ```
   > "alerts": [
   > {
   > "text": "no server capability with that id found",
   > "level": "error"
   > }
   > ]
   >```
   > 
   > }``` message here needs to be corrected. we are deleting 
server_capabilities only by name.
   
   Yeah, I noticed that as well and just kind of figured "name" is really the 
"id" of the resource, so I just left it as it was. I'll change the 
`GenericDelete` function to use "key" instead of "id".
   
   > 2. when spaces are at the start and end of name, they are trimmed and 
accepted instead of throwing error.
   
   I'm not intentionally trimming the name, but about to submit a fix that 
validates the name is alphanumeric/dash/underscore.
   
   > 3. api parameters are not validated. for instance, requesting 
service_capabilities endpoint with param id doesn't throw any error.
   
   I also agree unknown API parameters should be ignored.
   
   > 4. on PUT which is not defined - may be we should do method not allowed?
   
   This seems like a problem with our entire API rather than just this PR. We 
should fix that holistically and separately IMO.
   
   > 5. When a post with no body is made. the following error is provided.
   > 
   > ```
   > "alerts": [
   > {
   > "text": "EOF",
   > "level": "error"
   > }
   > ]
   > }```
   >  instead of a meaningful message indicating the missing info.
   > ```
   
   I suspect that is also a larger problem with the majority of our API, since 
we share the common code for unmarshalling JSON and returning errors across 
multiple endpoints. We should fix that separately.


This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
 
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org


With regards,
Apache Git Services

[GitHub] [trafficcontrol] vincentalfred commented on a change in pull request #3982: Add Traffic Monitor gbps calculated stat.

[GitBox]

vincentalfred commented on a change in pull request #3982: Add Traffic Monitor 
gbps calculated stat.
URL: https://github.com/apache/trafficcontrol/pull/3982#discussion_r334056340
 
 

 ##
 File path: traffic_monitor/cache/cache.go
 ##
 @@ -154,6 +154,9 @@ func ComputedStats() map[string]StatComputeFunc {
"kbps": func(info ResultInfo, serverInfo tc.TrafficServer, 
serverProfile tc.TMProfile, combinedState tc.IsAvailable) interface{} {
return info.Vitals.KbpsOut
},
+   "gbps": func(info ResultInfo, serverInfo tc.TrafficServer, 
serverProfile tc.TMProfile, combinedState tc.IsAvailable) interface{} {
+   return info.Vitals.KbpsOut / 100
 
 Review comment:
   I'm gonna cast it as float64 just to be safe.


This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
 
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org


With regards,
Apache Git Services

[GitHub] [trafficcontrol] ocket8888 commented on issue #2456: Add TO Go delete deliveryservice_user

[GitBox]

ocket commented on issue #2456: Add TO Go delete deliveryservice_user
URL: https://github.com/apache/trafficcontrol/pull/2456#issuecomment-541123572
 
 
   we shouldn't rewrite this using query instead of path parameters - that 
breaks the API contract.


This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
 
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org


With regards,
Apache Git Services

[GitHub] [trafficcontrol] ocket8888 commented on a change in pull request #3901: Fixed runtime panic when creating roles, added docs

[GitBox]

ocket commented on a change in pull request #3901: Fixed runtime panic when 
creating roles, added docs
URL: https://github.com/apache/trafficcontrol/pull/3901#discussion_r334072039
 
 

 ##
 File path: traffic_ops/traffic_ops_golang/role/roles.go
 ##
 @@ -177,12 +179,16 @@ func (role *TORole) Update() (error, error, int) {
if userErr != nil || sysErr != nil {
return userErr, sysErr, errCode
}
+
// TODO cascade delete, to automatically do this in SQL?
-   userErr, sysErr, errCode = 
role.deleteRoleCapabilityAssociations(role.ReqInfo.Tx)
-   if userErr != nil || sysErr != nil {
-   return userErr, sysErr, errCode
+   if role.Capabilities != nil && *role.Capabilities != nil {
 
 Review comment:
   Oh, no actually, you still need to do that. If the Role had associated 
capabilities and the user updated it to have none, you still need to delete 
those associations.


This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
 
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org


With regards,
Apache Git Services

[GitHub] [trafficcontrol] vincentalfred commented on issue #3982: Add Traffic Monitor gbps calculated stat.

[GitBox]

vincentalfred commented on issue #3982: Add Traffic Monitor gbps calculated 
stat.
URL: https://github.com/apache/trafficcontrol/pull/3982#issuecomment-541118094
 
 
   I'm relatively new to Go and open source. I'll update the changelog and try 
to create a unit test for it. Thanks for the guidance!


This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
 
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org


With regards,
Apache Git Services

[GitHub] [trafficcontrol] asf-ci commented on issue #3972: Add Server Capabilities blueprint

[GitBox]

asf-ci commented on issue #3972: Add Server Capabilities blueprint
URL: https://github.com/apache/trafficcontrol/pull/3972#issuecomment-541118026
 
 
   
   Refer to this link for build results (access rights to CI server needed): 
   https://builds.apache.org/job/trafficcontrol-PR/4453/
   


This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
 
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org


With regards,
Apache Git Services

Build failed in Jenkins: trafficcontrol-PR #4456

[Apache Jenkins Server]

See 


Changes:

[ocket] Rewrite profile import to Go (#3930)

[ocket] On cachestats get if all TMs fail to return data return failure 
(#3926)

[ocket] Remove atstccfg unused code (#3960)

[ocket] Gives admins the ability to mark delivery service requests as 
complete

[ocket] Rewrite get federation deliveryservices to Go (#3947)

[mitchell852] Added SMTP configuration and APIInfo Email method (#3925)

[mitchell852] Removed an unused/broken module from Traffic Portal (#3636)

[ocket] Fixes #3550 (#3558)

[ocket] Add TO Go server cache configs (#3899)

[mitchell852] Fixed double-build of TR RPMs in CiaB makefile (#3883)

[mitchell852] Rewrote jobs endpoints to go (#3744)

[jeffrey_elsloo] check outcome of enforce command

[jeffrey_elsloo] second attempt, remove return completely

[jeffrey_elsloo] added new isSteeringDS field to RGB json, first attempt at 
enforcing RGB

[jeffrey_elsloo] RGB NPE fix

[jeffrey_elsloo] added a new field to the rgb config to identify steering DSs.  
Do not

[jeffrey_elsloo] cleaned up formatting

[jeffrey_elsloo] fixed formatting issues

[jeffrey_elsloo] more formatting

[mitchell852] Fix broken unit tests and run go fmt (#3979)

[ocket] Fixed runtime panic when creating roles, added docs

[ocket] remove unnecessary nil check


--
GitHub pull request #3901 of commit e1495e7bf0e3c3a8d97ca6793b55392a517a98f5, 
no merge conflicts.
Running as SYSTEM
Setting status of e1495e7bf0e3c3a8d97ca6793b55392a517a98f5 to PENDING with url 
https://builds.apache.org/job/trafficcontrol-PR/4456/ and message: 'Build 
started for merge commit.'
Using context: default
[EnvInject] - Loading node environment variables.
Building remotely on H25 (ubuntu) in workspace 

[WS-CLEANUP] Deleting project workspace...
[WS-CLEANUP] Deferred wipeout is used...
using credential b205a645-1ea7-4dfd-973d-c14ac43cab07
Cloning the remote Git repository
Cloning repository git://github.com/apache/trafficcontrol.git
 > git init  # timeout=10
Fetching upstream changes from git://github.com/apache/trafficcontrol.git
 > git --version # timeout=10
using GIT_SSH to set credentials 
 > git fetch --tags --progress -- git://github.com/apache/trafficcontrol.git 
 > +refs/heads/*:refs/remotes/origin/*
 > git config remote.origin.url git://github.com/apache/trafficcontrol.git # 
 > timeout=10
 > git config --add remote.origin.fetch +refs/heads/*:refs/remotes/origin/* # 
 > timeout=10
 > git config remote.origin.url git://github.com/apache/trafficcontrol.git # 
 > timeout=10
Fetching upstream changes from git://github.com/apache/trafficcontrol.git
using GIT_SSH to set credentials 
 > git fetch --tags --progress -- git://github.com/apache/trafficcontrol.git 
 > +refs/pull/*:refs/remotes/origin/pr/*
 > git rev-parse e1495e7bf0e3c3a8d97ca6793b55392a517a98f5^{commit} # timeout=10
Checking out Revision e1495e7bf0e3c3a8d97ca6793b55392a517a98f5 (detached)
 > git config core.sparsecheckout # timeout=10
 > git checkout -f e1495e7bf0e3c3a8d97ca6793b55392a517a98f5
Commit message: "remove unnecessary nil check"
 > git rev-list --no-walk efcaab23ae9b92c6db57ba2d4ba09c506589928f # timeout=10
[trafficcontrol-PR] $ /bin/bash /tmp/jenkins4498985298980897166.sh
++ sed s/-//g
++ echo jenkins-trafficcontrol-PR-4456
++ sed s/jenkins//
+ proj=trafficcontrolPR4456
+ yml=infrastructure/docker/build/docker-compose.yml
++ mktemp /tmp/docker-compose-
+ dc=/tmp/docker-compose-S6L7
++ mktemp /tmp/tc-status-
+ st=/tmp/tc-status-wXVA
+ trap finish EXIT
++ uname -s
++ uname -m
+ curl -o /tmp/docker-compose-S6L7 -L 
https://github.com/docker/compose/releases/download/1.13.0/docker-compose-Linux-x86_64
  % Total% Received % Xferd  Average Speed   TimeTime Time  Current
 Dload  Upload   Total   SpentLeft  Speed
  0 00 00 0  0  0 --:--:-- --:--:-- --:--:-- 
0100   6170   6170 0   1858  0 --:--:-- --:--:-- --:--:--  1864
  0 8079k0 00 0  0  0 --:--:-- --:--:-- --:--:-- 
0100 8079k  100 8079k0 0  6024k  0  0:00:01  0:00:01 --:--:-- 12.2M
+ chmod +x /tmp/docker-compose-S6L7
+ rm -rf dist
+ /tmp/docker-compose-S6L7 -f infrastructure/docker/build/docker-compose.yml -p 
trafficcontrolPR4456 up
Creating network "trafficcontrolpr4456_default" with the default driver
Pulling weasel (licenseweasel/weasel:0.2)...
0.2: Pulling from licenseweasel/weasel
Digest: sha256:b0e6dcd71152636af6e3a6e7e2bae275f77ce6aa719314e47981424a3fa86d70
Status: Downloaded newer image for licenseweasel/weasel:0.2
Creating trafficcontrolpr4456_traffic_router_build_1 ... 
Creating trafficcontrolpr4456_grovetccfg_build_1 ... 
Creating trafficcontrolpr4456_traffic_portal_build_1 ... 
Creating 

[GitHub] [trafficcontrol] asf-ci commented on issue #3901: Fixed runtime panic when creating roles, added docs

[GitBox]

asf-ci commented on issue #3901: Fixed runtime panic when creating roles, added 
docs
URL: https://github.com/apache/trafficcontrol/pull/3901#issuecomment-541136621
 
 
   
   Refer to this link for build results (access rights to CI server needed): 
   https://builds.apache.org/job/trafficcontrol-PR/4456/
   


This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
 
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org


With regards,
Apache Git Services

[GitHub] [trafficcontrol] mhoppa commented on a change in pull request #3901: Fixed runtime panic when creating roles, added docs

[GitBox]

mhoppa commented on a change in pull request #3901: Fixed runtime panic when 
creating roles, added docs
URL: https://github.com/apache/trafficcontrol/pull/3901#discussion_r334076999
 
 

 ##
 File path: traffic_ops/traffic_ops_golang/role/roles.go
 ##
 @@ -177,12 +179,16 @@ func (role *TORole) Update() (error, error, int) {
if userErr != nil || sysErr != nil {
return userErr, sysErr, errCode
}
+
// TODO cascade delete, to automatically do this in SQL?
-   userErr, sysErr, errCode = 
role.deleteRoleCapabilityAssociations(role.ReqInfo.Tx)
-   if userErr != nil || sysErr != nil {
-   return userErr, sysErr, errCode
+   if role.Capabilities != nil && *role.Capabilities != nil {
 
 Review comment:
   ahh - makes sense  


This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
 
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org


With regards,
Apache Git Services

Build failed in Jenkins: trafficcontrol-master-build #1527

[Apache Jenkins Server]

See 


Changes:

[ocket] Fix broken api tests (#3983)


--
Started by an SCM change
Running as SYSTEM
[EnvInject] - Loading node environment variables.
Building remotely on H38 (ubuntu xenial) in workspace 

[WS-CLEANUP] Deleting project workspace...
[WS-CLEANUP] Deferred wipeout is used...
[WS-CLEANUP] Done
using credential b205a645-1ea7-4dfd-973d-c14ac43cab07
Cloning the remote Git repository
Cloning repository git://github.com/apache/trafficcontrol.git
 > git init  # 
 > timeout=10
Fetching upstream changes from git://github.com/apache/trafficcontrol.git
 > git --version # timeout=10
using GIT_SSH to set credentials 
 > git fetch --tags --progress git://github.com/apache/trafficcontrol.git 
 > +refs/heads/*:refs/remotes/origin/*
 > git config remote.origin.url git://github.com/apache/trafficcontrol.git # 
 > timeout=10
 > git config --add remote.origin.fetch +refs/heads/*:refs/remotes/origin/* # 
 > timeout=10
 > git config remote.origin.url git://github.com/apache/trafficcontrol.git # 
 > timeout=10
Fetching upstream changes from git://github.com/apache/trafficcontrol.git
using GIT_SSH to set credentials 
 > git fetch --tags --progress git://github.com/apache/trafficcontrol.git 
 > +refs/heads/*:refs/remotes/origin/*
 > git rev-parse refs/remotes/origin/master^{commit} # timeout=10
 > git rev-parse refs/remotes/origin/origin/master^{commit} # timeout=10
Checking out Revision 9037f2ffa0d5141612fe79138066e790b9d8802d 
(refs/remotes/origin/master)
 > git config core.sparsecheckout # timeout=10
 > git checkout -f 9037f2ffa0d5141612fe79138066e790b9d8802d
Commit message: "Fix broken api tests (#3983)"
 > git rev-list --no-walk 9003567785f2608c31faa6c52fea74f704cc59c3 # timeout=10
[trafficcontrol-master-build] $ /bin/bash /tmp/jenkins4368548726514536490.sh
++ echo jenkins-trafficcontrol-master-build-1527
++ sed s/-//g
++ sed s/jenkins//
+ proj=trafficcontrolmasterbuild1527
+ yml=infrastructure/docker/build/docker-compose.yml
++ mktemp /tmp/docker-compose-
+ dc=/tmp/docker-compose-cTqv
++ mktemp /tmp/tc-status-
+ st=/tmp/tc-status-8ecT
++ uname -s
++ uname -m
+ curl -o /tmp/docker-compose-cTqv -L 
https://github.com/docker/compose/releases/download/1.13.0/docker-compose-Linux-x86_64
  % Total% Received % Xferd  Average Speed   TimeTime Time  Current
 Dload  Upload   Total   SpentLeft  Speed
  0 00 00 0  0  0 --:--:-- --:--:-- --:--:-- 
0100   6170   6170 0   1036  0 --:--:-- --:--:-- --:--:--  1036
  0 00 00 0  0  0 --:--:-- --:--:-- --:--:-- 0 
55 8079k   55 4508k0 0  2662k  0  0:00:03  0:00:01  0:00:02 
4490k100 8079k  100 8079k0 0  4538k  0  0:00:01  0:00:01 --:--:-- 
7405k
+ chmod +x /tmp/docker-compose-cTqv
+ rm -rf dist
+ /tmp/docker-compose-cTqv -f infrastructure/docker/build/docker-compose.yml -p 
trafficcontrolmasterbuild1527 up
Creating network "trafficcontrolmasterbuild1527_default" with the default driver
Pulling weasel (licenseweasel/weasel:0.2)...
0.2: Pulling from licenseweasel/weasel
Digest: sha256:b0e6dcd71152636af6e3a6e7e2bae275f77ce6aa719314e47981424a3fa86d70
Status: Downloaded newer image for licenseweasel/weasel:0.2
Creating trafficcontrolmasterbuild1527_traffic_stats_build_1 ... 
Creating trafficcontrolmasterbuild1527_traffic_ops_build_1 ... 
Creating trafficcontrolmasterbuild1527_traffic_monitor_build_1 ... 
Creating trafficcontrolmasterbuild1527_grove_build_1 ... 
Creating trafficcontrolmasterbuild1527_source_1 ... 
Creating trafficcontrolmasterbuild1527_traffic_router_build_1 ... 
Creating trafficcontrolmasterbuild1527_weasel_1 ... 
Creating trafficcontrolmasterbuild1527_grovetccfg_build_1 ... 
Creating trafficcontrolmasterbuild1527_traffic_stats_build_1
Creating trafficcontrolmasterbuild1527_traffic_ops_build_1
Creating trafficcontrolmasterbuild1527_docs_1 ... 
Creating trafficcontrolmasterbuild1527_source_1
Creating trafficcontrolmasterbuild1527_traffic_portal_build_1 ... 
Creating trafficcontrolmasterbuild1527_traffic_router_build_1
Creating trafficcontrolmasterbuild1527_traffic_monitor_build_1
Creating trafficcontrolmasterbuild1527_weasel_1
Creating trafficcontrolmasterbuild1527_grovetccfg_build_1
Creating trafficcontrolmasterbuild1527_docs_1
Creating trafficcontrolmasterbuild1527_grove_build_1
Creating trafficcontrolmasterbuild1527_traffic_portal_build_1
Creating trafficcontrolmasterbuild1527_traffic_stats_build_1 ... 
error
ERROR: for trafficcontrolmasterbuild1527_traffic_stats_build_1  Cannot start 
service traffic_stats_build: no status provided on response: unknown
Creating trafficcontrolmasterbuild1527_traffic_router_build_1 ... 

[GitHub] [trafficcontrol] ocket8888 commented on issue #3870: Rewrite /capabilities to Go

[GitBox]

ocket commented on issue #3870: Rewrite /capabilities to Go
URL: https://github.com/apache/trafficcontrol/pull/3870#issuecomment-541257724
 
 
   retest this please


This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
 
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org


With regards,
Apache Git Services

[GitHub] [trafficcontrol] asf-ci commented on issue #3977: TP: Adds Server Capabilities UI

[GitBox]

asf-ci commented on issue #3977: TP: Adds Server Capabilities UI
URL: https://github.com/apache/trafficcontrol/pull/3977#issuecomment-541263780
 
 
   
   Refer to this link for build results (access rights to CI server needed): 
   https://builds.apache.org/job/trafficcontrol-PR/4472/
   


This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
 
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org


With regards,
Apache Git Services

Build failed in Jenkins: trafficcontrol-PR #4472

[Apache Jenkins Server]

See 


Changes:

[rawlin_peters] Add server_capability goose migration

[rawlin_peters] Add server_capabilities API endpoints

[rawlin_peters] Add server capabilities methods to TO-Go client

[rawlin_peters] Add TO API tests for server capabilities

[rawlin_peters] Add CHANGELOG entry for server_capabilities

[rawlin_peters] Fix godoc comments on server_capabilities structs

[rawlin_peters] Addressed review comments

[rawlin_peters] Address PR review comments

[rawlin_peters] Address more PR feedback

[rawlin_peters] Fix godoc comment before someone yells at me

[mitchell852] adds view for managing server capabilities

[mitchell852] fixes case differences with ui test directories

[mitchell852] adds ui tests for create/view/delete server capabilities

[mitchell852] prevents dots in server capability name

[mitchell852] adds changelog entry

[mitchell852] adds documentation for create, view and delete server capabilities


--
GitHub pull request #3977 of commit e8bbac326b219288c8c4cd39f87db2bebdf2db0e, 
has merge conflicts.
Running as SYSTEM
Setting status of e8bbac326b219288c8c4cd39f87db2bebdf2db0e to PENDING with url 
https://builds.apache.org/job/trafficcontrol-PR/4472/ and message: 'Build 
started for original commit.'
Using context: default
[EnvInject] - Loading node environment variables.
Building remotely on H40 (ubuntu xenial) in workspace 

[WS-CLEANUP] Deleting project workspace...
[WS-CLEANUP] Deferred wipeout is used...
using credential b205a645-1ea7-4dfd-973d-c14ac43cab07
Cloning the remote Git repository
Cloning repository git://github.com/apache/trafficcontrol.git
 > git init  # timeout=10
Fetching upstream changes from git://github.com/apache/trafficcontrol.git
 > git --version # timeout=10
using GIT_SSH to set credentials 
 > git fetch --tags --progress git://github.com/apache/trafficcontrol.git 
 > +refs/heads/*:refs/remotes/origin/*
 > git config remote.origin.url git://github.com/apache/trafficcontrol.git # 
 > timeout=10
 > git config --add remote.origin.fetch +refs/heads/*:refs/remotes/origin/* # 
 > timeout=10
 > git config remote.origin.url git://github.com/apache/trafficcontrol.git # 
 > timeout=10
Fetching upstream changes from git://github.com/apache/trafficcontrol.git
using GIT_SSH to set credentials 
 > git fetch --tags --progress git://github.com/apache/trafficcontrol.git 
 > +refs/pull/*:refs/remotes/origin/pr/*
 > git rev-parse e8bbac326b219288c8c4cd39f87db2bebdf2db0e^{commit} # timeout=10
Checking out Revision e8bbac326b219288c8c4cd39f87db2bebdf2db0e (detached)
 > git config core.sparsecheckout # timeout=10
 > git checkout -f e8bbac326b219288c8c4cd39f87db2bebdf2db0e
Commit message: "adds documentation for create, view and delete server 
capabilities"
 > git rev-list --no-walk d698f21593d9b79a4b65aae8a03105fc28a15cb5 # timeout=10
[trafficcontrol-PR] $ /bin/bash /tmp/jenkins6851506548567027844.sh
++ echo jenkins-trafficcontrol-PR-4472
++ sed s/-//g
++ sed s/jenkins//
+ proj=trafficcontrolPR4472
+ yml=infrastructure/docker/build/docker-compose.yml
++ mktemp /tmp/docker-compose-
+ dc=/tmp/docker-compose-fsNR
++ mktemp /tmp/tc-status-
+ st=/tmp/tc-status-l6VU
+ trap finish EXIT
++ uname -s
++ uname -m
+ curl -o /tmp/docker-compose-fsNR -L 
https://github.com/docker/compose/releases/download/1.13.0/docker-compose-Linux-x86_64
  % Total% Received % Xferd  Average Speed   TimeTime Time  Current
 Dload  Upload   Total   SpentLeft  Speed
  0 00 00 0  0  0 --:--:-- --:--:-- --:--:-- 0  
0 00 00 0  0  0 --:--:-- --:--:-- --:--:-- 0100 
  6170   6170 0   1046  0 --:--:-- --:--:-- --:--:--  1045
  0 8079k0 00 0  0  0 --:--:--  0:00:01 --:--:-- 
0100 8079k  100 8079k0 0  4509k  0  0:00:01  0:00:01 --:--:-- 13.0M
+ chmod +x /tmp/docker-compose-fsNR
+ rm -rf dist
+ /tmp/docker-compose-fsNR -f infrastructure/docker/build/docker-compose.yml -p 
trafficcontrolPR4472 up
Creating network "trafficcontrolpr4472_default" with the default driver
Building traffic_stats_build
Step 1/7 : FROM centos:7
7: Pulling from library/centos
Digest: sha256:307835c385f656ec2e2fec602cf093224173c51119bbebd602c53c3653a3d6eb
Status: Downloaded newer image for centos:7
 ---> 67fa590cfc1c
Step 2/7 : MAINTAINER d...@trafficcontrol.apache.org
 ---> Using cache
 ---> 48d4918b1747
Step 3/7 : VOLUME /trafficcontrol
 ---> Using cache
 ---> 26fe402f7071
Step 4/7 : RUN  rpm --import /etc/pki/rpm-gpg/RPM-GPG-KEY-CentOS-7 &&   rpm 
--import https://dl.fedoraproject.org/pub/epel/RPM-GPG-KEY-EPEL-7 &&yum 
-y update ca-certificates &&yum -y install  epel-release && 
yum -y clean all
 ---> Running in 

[GitHub] [trafficcontrol] asf-ci commented on issue #3758: Rewrote deliveryservice_stats to Go

[GitBox]

asf-ci commented on issue #3758: Rewrote deliveryservice_stats to Go
URL: https://github.com/apache/trafficcontrol/pull/3758#issuecomment-541278486
 
 
   
   Refer to this link for build results (access rights to CI server needed): 
   https://builds.apache.org/job/trafficcontrol-PR/4479/
   


This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
 
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org


With regards,
Apache Git Services

Build failed in Jenkins: trafficcontrol-PR #4479

[Apache Jenkins Server]

See 


Changes:

[ocket] Remove commented out PATCH /jobs code, api_capability, and docs 
(#3985)

[ocket] Rewrote deliveryservice_stats to Go

[ocket] Fixed api.CreateInfluxClient always attempting to use SSL

[ocket] Added descriptions of the totalBytes and totalTransactions fields

[ocket] fixed influx client builder considering servers that are not ONLINE

[ocket] increased traffic_stats log verbosity

[ocket] Better error reporting

[ocket] added appropriate deprecation notices

[ocket] Fixed config key to conform to standard behavior

[ocket] fixed GoDoc comments

[ocket] Added sane default for 'Secure' flag to influx configs

[ocket] Moved MimeType into a dedicated RFC package/library

[ocket] returns now explicit

[ocket] fixed rfc test compilation

[ocket] fixed more implicit returns, match return type of db helper funcs

[ocket] s/Equal/Satisfy/g

[ocket] match snake_case for configuration variables

[ocket] consistent casing for initialisms

[ocket] use Ptr util funcs

[ocket] var/const blocks

[ocket] Move config object into lib/go-tc

[ocket] lowercase local variables

[ocket] fixed compilation errors introduced by earlier changes

[ocket] Split some functionality out into utilities

[ocket] Collapse conditionals

[ocket] Made checking for excludes more similar to checking for orderables

[ocket] All internal errors now straight-up 500s, details to client omitted

[ocket] Add test for config parsing

[ocket] Switched back to a regular expression for intervals

[ocket] Column name value->sum_count

[ocket] Added missing struct tag

[ocket] Fix erroneous warning log message


--
GitHub pull request #3758 of commit 1527b19b301ff36b13b46d0dde042de25d1a20a2, 
no merge conflicts.
Running as SYSTEM
Setting status of 1527b19b301ff36b13b46d0dde042de25d1a20a2 to PENDING with url 
https://builds.apache.org/job/trafficcontrol-PR/4479/ and message: 'Build 
started for merge commit.'
Using context: default
[EnvInject] - Loading node environment variables.
Building remotely on H41 (ubuntu xenial) in workspace 

[WS-CLEANUP] Deleting project workspace...
[WS-CLEANUP] Deferred wipeout is used...
using credential b205a645-1ea7-4dfd-973d-c14ac43cab07
Cloning the remote Git repository
Cloning repository git://github.com/apache/trafficcontrol.git
 > git init  # timeout=10
Fetching upstream changes from git://github.com/apache/trafficcontrol.git
 > git --version # timeout=10
using GIT_SSH to set credentials 
 > git fetch --tags --progress git://github.com/apache/trafficcontrol.git 
 > +refs/heads/*:refs/remotes/origin/*
 > git config remote.origin.url git://github.com/apache/trafficcontrol.git # 
 > timeout=10
 > git config --add remote.origin.fetch +refs/heads/*:refs/remotes/origin/* # 
 > timeout=10
 > git config remote.origin.url git://github.com/apache/trafficcontrol.git # 
 > timeout=10
Fetching upstream changes from git://github.com/apache/trafficcontrol.git
using GIT_SSH to set credentials 
 > git fetch --tags --progress git://github.com/apache/trafficcontrol.git 
 > +refs/pull/*:refs/remotes/origin/pr/*
 > git rev-parse 1527b19b301ff36b13b46d0dde042de25d1a20a2^{commit} # timeout=10
Checking out Revision 1527b19b301ff36b13b46d0dde042de25d1a20a2 (detached)
 > git config core.sparsecheckout # timeout=10
 > git checkout -f 1527b19b301ff36b13b46d0dde042de25d1a20a2
Commit message: "Fix erroneous warning log message"
 > git rev-list --no-walk 994bef618c2d0293508d178d532ab8f42106e461 # timeout=10
[trafficcontrol-PR] $ /bin/bash /tmp/jenkins2275223636192873065.sh
++ echo jenkins-trafficcontrol-PR-4479
++ sed s/-//g
++ sed s/jenkins//
+ proj=trafficcontrolPR4479
+ yml=infrastructure/docker/build/docker-compose.yml
++ mktemp /tmp/docker-compose-
+ dc=/tmp/docker-compose-K4TW
++ mktemp /tmp/tc-status-
+ st=/tmp/tc-status-LopL
+ trap finish EXIT
++ uname -s
++ uname -m
+ curl -o /tmp/docker-compose-K4TW -L 
https://github.com/docker/compose/releases/download/1.13.0/docker-compose-Linux-x86_64
  % Total% Received % Xferd  Average Speed   TimeTime Time  Current
 Dload  Upload   Total   SpentLeft  Speed
  0 00 00 0  0  0 --:--:-- --:--:-- --:--:-- 
0100   6170   6170 0   1020  0 --:--:-- --:--:-- --:--:--  1021
  0 00 00 0  0  0 --:--:-- --:--:-- --:--:-- 
0100 8079k  100 8079k0 0  4644k  0  0:00:01  0:00:01 --:--:-- 10.5M
+ chmod +x /tmp/docker-compose-K4TW
+ rm -rf dist
+ /tmp/docker-compose-K4TW -f infrastructure/docker/build/docker-compose.yml -p 
trafficcontrolPR4479 up
Creating network "trafficcontrolpr4479_default" 

[GitHub] [trafficcontrol] asf-ci commented on issue #3977: TP: Adds Server Capabilities UI

[GitBox]

asf-ci commented on issue #3977: TP: Adds Server Capabilities UI
URL: https://github.com/apache/trafficcontrol/pull/3977#issuecomment-541262383
 
 
   
   Refer to this link for build results (access rights to CI server needed): 
   https://builds.apache.org/job/trafficcontrol-PR/4471/
   


This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
 
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org


With regards,
Apache Git Services

Build failed in Jenkins: trafficcontrol-PR #4471

[Apache Jenkins Server]

See 

Changes:


--
GitHub pull request #3977 of commit 6468a23a75ade33ca2c1da967f5be943c49dca95, 
has merge conflicts.
Running as SYSTEM
Setting status of 6468a23a75ade33ca2c1da967f5be943c49dca95 to PENDING with url 
https://builds.apache.org/job/trafficcontrol-PR/4471/ and message: 'Build 
started for original commit.'
Using context: default
[EnvInject] - Loading node environment variables.
Building remotely on H40 (ubuntu xenial) in workspace 

[WS-CLEANUP] Deleting project workspace...
[WS-CLEANUP] Deferred wipeout is used...
using credential b205a645-1ea7-4dfd-973d-c14ac43cab07
Cloning the remote Git repository
Cloning repository git://github.com/apache/trafficcontrol.git
 > git init  # timeout=10
Fetching upstream changes from git://github.com/apache/trafficcontrol.git
 > git --version # timeout=10
using GIT_SSH to set credentials 
 > git fetch --tags --progress git://github.com/apache/trafficcontrol.git 
 > +refs/heads/*:refs/remotes/origin/*
 > git config remote.origin.url git://github.com/apache/trafficcontrol.git # 
 > timeout=10
 > git config --add remote.origin.fetch +refs/heads/*:refs/remotes/origin/* # 
 > timeout=10
 > git config remote.origin.url git://github.com/apache/trafficcontrol.git # 
 > timeout=10
Fetching upstream changes from git://github.com/apache/trafficcontrol.git
using GIT_SSH to set credentials 
 > git fetch --tags --progress git://github.com/apache/trafficcontrol.git 
 > +refs/pull/*:refs/remotes/origin/pr/*
 > git rev-parse 6468a23a75ade33ca2c1da967f5be943c49dca95^{commit} # timeout=10
 > git rev-parse origin/6468a23a75ade33ca2c1da967f5be943c49dca95^{commit} # 
 > timeout=10
 > git rev-parse 6468a23a75ade33ca2c1da967f5be943c49dca95^{commit} # timeout=10
ERROR: Couldn't find any revision to build. Verify the repository and branch 
configuration for this job.
Retrying after 10 seconds
using credential b205a645-1ea7-4dfd-973d-c14ac43cab07
 > git rev-parse --is-inside-work-tree # timeout=10
Fetching changes from the remote Git repository
 > git config remote.origin.url git://github.com/apache/trafficcontrol.git # 
 > timeout=10
Fetching upstream changes from git://github.com/apache/trafficcontrol.git
 > git --version # timeout=10
using GIT_SSH to set credentials 
 > git fetch --tags --progress git://github.com/apache/trafficcontrol.git 
 > +refs/pull/*:refs/remotes/origin/pr/*
 > git rev-parse 6468a23a75ade33ca2c1da967f5be943c49dca95^{commit} # timeout=10
 > git rev-parse origin/6468a23a75ade33ca2c1da967f5be943c49dca95^{commit} # 
 > timeout=10
 > git rev-parse 6468a23a75ade33ca2c1da967f5be943c49dca95^{commit} # timeout=10
ERROR: Couldn't find any revision to build. Verify the repository and branch 
configuration for this job.
Retrying after 10 seconds
using credential b205a645-1ea7-4dfd-973d-c14ac43cab07
 > git rev-parse --is-inside-work-tree # timeout=10
Fetching changes from the remote Git repository
 > git config remote.origin.url git://github.com/apache/trafficcontrol.git # 
 > timeout=10
Fetching upstream changes from git://github.com/apache/trafficcontrol.git
 > git --version # timeout=10
using GIT_SSH to set credentials 
 > git fetch --tags --progress git://github.com/apache/trafficcontrol.git 
 > +refs/pull/*:refs/remotes/origin/pr/*
 > git rev-parse 6468a23a75ade33ca2c1da967f5be943c49dca95^{commit} # timeout=10
 > git rev-parse origin/6468a23a75ade33ca2c1da967f5be943c49dca95^{commit} # 
 > timeout=10
 > git rev-parse 6468a23a75ade33ca2c1da967f5be943c49dca95^{commit} # timeout=10
ERROR: Couldn't find any revision to build. Verify the repository and branch 
configuration for this job.
Skipped archiving because build is not successful

[GitHub] [trafficcontrol] asf-ci commented on issue #3766: Cachegroup fallbacks deprecation

[GitBox]

asf-ci commented on issue #3766: Cachegroup fallbacks deprecation
URL: https://github.com/apache/trafficcontrol/pull/3766#issuecomment-541278384
 
 
   
   Refer to this link for build results (access rights to CI server needed): 
   https://builds.apache.org/job/trafficcontrol-PR/4477/
   


This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
 
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org


With regards,
Apache Git Services

Build failed in Jenkins: trafficcontrol-PR #4477

[Apache Jenkins Server]

See 


Changes:

[ocket] Remove commented out PATCH /jobs code, api_capability, and docs 
(#3985)

[ocket] Added deprecation notice for cachegroup_fallbacks

[ocket] fixed missing documentation for 'fallbacks' array

[ocket] added deprecation section to CHANGELOG

[ocket] add deprecation warning alerts to API responses


--
GitHub pull request #3766 of commit 55d137559bdba10246b57a5d0ce9a933d1f39fd7, 
no merge conflicts.
Running as SYSTEM
Setting status of 55d137559bdba10246b57a5d0ce9a933d1f39fd7 to PENDING with url 
https://builds.apache.org/job/trafficcontrol-PR/4477/ and message: 'Build 
started for merge commit.'
Using context: default
[EnvInject] - Loading node environment variables.
Building remotely on H41 (ubuntu xenial) in workspace 

[WS-CLEANUP] Deleting project workspace...
[WS-CLEANUP] Deferred wipeout is used...
using credential b205a645-1ea7-4dfd-973d-c14ac43cab07
Cloning the remote Git repository
Cloning repository git://github.com/apache/trafficcontrol.git
 > git init  # timeout=10
Fetching upstream changes from git://github.com/apache/trafficcontrol.git
 > git --version # timeout=10
using GIT_SSH to set credentials 
 > git fetch --tags --progress git://github.com/apache/trafficcontrol.git 
 > +refs/heads/*:refs/remotes/origin/*
 > git config remote.origin.url git://github.com/apache/trafficcontrol.git # 
 > timeout=10
 > git config --add remote.origin.fetch +refs/heads/*:refs/remotes/origin/* # 
 > timeout=10
 > git config remote.origin.url git://github.com/apache/trafficcontrol.git # 
 > timeout=10
Fetching upstream changes from git://github.com/apache/trafficcontrol.git
using GIT_SSH to set credentials 
 > git fetch --tags --progress git://github.com/apache/trafficcontrol.git 
 > +refs/pull/*:refs/remotes/origin/pr/*
 > git rev-parse 55d137559bdba10246b57a5d0ce9a933d1f39fd7^{commit} # timeout=10
Checking out Revision 55d137559bdba10246b57a5d0ce9a933d1f39fd7 (detached)
 > git config core.sparsecheckout # timeout=10
 > git checkout -f 55d137559bdba10246b57a5d0ce9a933d1f39fd7
Commit message: "add deprecation warning alerts to API responses"
 > git rev-list --no-walk 994bef618c2d0293508d178d532ab8f42106e461 # timeout=10
[trafficcontrol-PR] $ /bin/bash /tmp/jenkins7142582120790161359.sh
++ echo jenkins-trafficcontrol-PR-4477
++ sed s/-//g
++ sed s/jenkins//
+ proj=trafficcontrolPR4477
+ yml=infrastructure/docker/build/docker-compose.yml
++ mktemp /tmp/docker-compose-
+ dc=/tmp/docker-compose-Nhwb
++ mktemp /tmp/tc-status-
+ st=/tmp/tc-status-UGfi
+ trap finish EXIT
++ uname -s
++ uname -m
+ curl -o /tmp/docker-compose-Nhwb -L 
https://github.com/docker/compose/releases/download/1.13.0/docker-compose-Linux-x86_64
  % Total% Received % Xferd  Average Speed   TimeTime Time  Current
 Dload  Upload   Total   SpentLeft  Speed
  0 00 00 0  0  0 --:--:-- --:--:-- --:--:-- 
0100   6170   6170 0   1083  0 --:--:-- --:--:-- --:--:--  1084
  0 00 00 0  0  0 --:--:-- --:--:-- --:--:-- 
0100 8079k  100 8079k0 0  4777k  0  0:00:01  0:00:01 --:--:-- 10.9M
+ chmod +x /tmp/docker-compose-Nhwb
+ rm -rf dist
+ /tmp/docker-compose-Nhwb -f infrastructure/docker/build/docker-compose.yml -p 
trafficcontrolPR4477 up
Creating network "trafficcontrolpr4477_default" with the default driver
Building traffic_stats_build
Step 1/7 : FROM centos:7
7: Pulling from library/centos
Digest: sha256:307835c385f656ec2e2fec602cf093224173c51119bbebd602c53c3653a3d6eb
Status: Downloaded newer image for centos:7
 ---> 67fa590cfc1c
Step 2/7 : MAINTAINER d...@trafficcontrol.apache.org
 ---> Running in 088fa6d7977e
Removing intermediate container 088fa6d7977e
 ---> 7f5a9392693b
Step 3/7 : VOLUME /trafficcontrol
 ---> Running in 2eb82b6e2576
Removing intermediate container 2eb82b6e2576
 ---> c61310063ae3
Step 4/7 : RUN  rpm --import /etc/pki/rpm-gpg/RPM-GPG-KEY-CentOS-7 &&   rpm 
--import https://dl.fedoraproject.org/pub/epel/RPM-GPG-KEY-EPEL-7 &&yum 
-y update ca-certificates &&yum -y install  epel-release && 
yum -y clean all
 ---> Running in e1b7c0c3cd8d
Service 'traffic_stats_build' failed to build: no status provided on response: 
unknown
+ exit 1
+ finish
+ /tmp/docker-compose-Nhwb -f infrastructure/docker/build/docker-compose.yml -p 
trafficcontrolPR4477 down -v
Removing network trafficcontrolpr4477_default
+ /tmp/docker-compose-Nhwb -f infrastructure/docker/build/docker-compose.yml -p 
trafficcontrolPR4477 rm -v -f
No stopped containers
+ rm -f /tmp/docker-compose-Nhwb
Build step 'Execute shell' marked build as failure
Skipped archiving because build is not successful

Build failed in Jenkins: trafficcontrol-PR #4478

[Apache Jenkins Server]

See 


Changes:

[ocket] Rewrote capabilities endpoints to GO

[ocket] Fixed incorrect parameter contraint

[ocket] Added godoc

[ocket] Added support in the Go Client for capabilities

[ocket] Added API/client tests

[ocket] Added Python client support

[ocket] Updated docs

[ocket] Added changelog updates

[ocket] Traffic Portal changes to reflect deprecation

[ocket] Fix API route definition for consistency

[ocket] Remove unnecessary debug line

[ocket] Use Fatalf when warranted

[ocket] Use API functions to write responses

[ocket] Add trailing newlines to API responses

[ocket] fix compilation error

[ocket] Switch URL building to use proper net/url encoding

[ocket] add db struct tags

[ocket] Add page/where/orderby/limit support

[ocket] fix some docs compilation error/warning


--
GitHub pull request #3870 of commit 994bef618c2d0293508d178d532ab8f42106e461, 
no merge conflicts.
Running as SYSTEM
Setting status of 994bef618c2d0293508d178d532ab8f42106e461 to PENDING with url 
https://builds.apache.org/job/trafficcontrol-PR/4478/ and message: 'Build 
started for merge commit.'
Using context: default
[EnvInject] - Loading node environment variables.
Building remotely on H41 (ubuntu xenial) in workspace 

[WS-CLEANUP] Deleting project workspace...
[WS-CLEANUP] Deferred wipeout is used...
using credential b205a645-1ea7-4dfd-973d-c14ac43cab07
Cloning the remote Git repository
Cloning repository git://github.com/apache/trafficcontrol.git
 > git init  # timeout=10
Fetching upstream changes from git://github.com/apache/trafficcontrol.git
 > git --version # timeout=10
using GIT_SSH to set credentials 
 > git fetch --tags --progress git://github.com/apache/trafficcontrol.git 
 > +refs/heads/*:refs/remotes/origin/*
 > git config remote.origin.url git://github.com/apache/trafficcontrol.git # 
 > timeout=10
 > git config --add remote.origin.fetch +refs/heads/*:refs/remotes/origin/* # 
 > timeout=10
 > git config remote.origin.url git://github.com/apache/trafficcontrol.git # 
 > timeout=10
Fetching upstream changes from git://github.com/apache/trafficcontrol.git
using GIT_SSH to set credentials 
 > git fetch --tags --progress git://github.com/apache/trafficcontrol.git 
 > +refs/pull/*:refs/remotes/origin/pr/*
 > git rev-parse 994bef618c2d0293508d178d532ab8f42106e461^{commit} # timeout=10
Checking out Revision 994bef618c2d0293508d178d532ab8f42106e461 (detached)
 > git config core.sparsecheckout # timeout=10
 > git checkout -f 994bef618c2d0293508d178d532ab8f42106e461
Commit message: "fix some docs compilation error/warning"
 > git rev-list --no-walk 55d137559bdba10246b57a5d0ce9a933d1f39fd7 # timeout=10
[trafficcontrol-PR] $ /bin/bash /tmp/jenkins1463466095206043447.sh
++ echo jenkins-trafficcontrol-PR-4478
++ sed s/-//g
++ sed s/jenkins//
+ proj=trafficcontrolPR4478
+ yml=infrastructure/docker/build/docker-compose.yml
++ mktemp /tmp/docker-compose-
+ dc=/tmp/docker-compose-fQkt
++ mktemp /tmp/tc-status-
+ st=/tmp/tc-status-BGc9
+ trap finish EXIT
++ uname -s
++ uname -m
+ curl -o /tmp/docker-compose-fQkt -L 
https://github.com/docker/compose/releases/download/1.13.0/docker-compose-Linux-x86_64
  % Total% Received % Xferd  Average Speed   TimeTime Time  Current
 Dload  Upload   Total   SpentLeft  Speed
  0 00 00 0  0  0 --:--:-- --:--:-- --:--:-- 0  
0 00 00 0  0  0 --:--:-- --:--:-- --:--:-- 0100 
  6170   6170 0   1044  0 --:--:-- --:--:-- --:--:--  1043
  0 8079k0 00 0  0  0 --:--:--  0:00:01 --:--:-- 
0100 8079k  100 8079k0 0  4723k  0  0:00:01  0:00:01 --:--:-- 11.6M
+ chmod +x /tmp/docker-compose-fQkt
+ rm -rf dist
+ /tmp/docker-compose-fQkt -f infrastructure/docker/build/docker-compose.yml -p 
trafficcontrolPR4478 up
Creating network "trafficcontrolpr4478_default" with the default driver
Building traffic_stats_build
Step 1/7 : FROM centos:7
 ---> 67fa590cfc1c
Step 2/7 : MAINTAINER d...@trafficcontrol.apache.org
 ---> Using cache
 ---> 7f5a9392693b
Step 3/7 : VOLUME /trafficcontrol
 ---> Using cache
 ---> c61310063ae3
Step 4/7 : RUN  rpm --import /etc/pki/rpm-gpg/RPM-GPG-KEY-CentOS-7 &&   rpm 
--import https://dl.fedoraproject.org/pub/epel/RPM-GPG-KEY-EPEL-7 &&yum 
-y update ca-certificates &&yum -y install  epel-release && 
yum -y clean all
 ---> Running in dc0de988a385
Service 'traffic_stats_build' failed to build: no status provided on response: 
unknown
+ exit 1
+ finish
+ /tmp/docker-compose-fQkt -f infrastructure/docker/build/docker-compose.yml -p 
trafficcontrolPR4478 down -v
Removing network 

[GitHub] [trafficcontrol] asf-ci commented on issue #3870: Rewrite /capabilities to Go

[GitBox]

asf-ci commented on issue #3870: Rewrite /capabilities to Go
URL: https://github.com/apache/trafficcontrol/pull/3870#issuecomment-541278437
 
 
   
   Refer to this link for build results (access rights to CI server needed): 
   https://builds.apache.org/job/trafficcontrol-PR/4478/
   


This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
 
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org


With regards,
Apache Git Services

[GitHub] [trafficcontrol] asf-ci commented on issue #3870: Rewrite /capabilities to Go

[GitBox]

asf-ci commented on issue #3870: Rewrite /capabilities to Go
URL: https://github.com/apache/trafficcontrol/pull/3870#issuecomment-541250927
 
 
   
   Refer to this link for build results (access rights to CI server needed): 
   https://builds.apache.org/job/trafficcontrol-PR/4467/
   


This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
 
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org


With regards,
Apache Git Services

Jenkins build is back to normal : trafficcontrol-PR #4467

[Apache Jenkins Server]

See 

Build failed in Jenkins: trafficcontrol-PR #4469

[Apache Jenkins Server]

See 


Changes:

[ocket] Rewrote capabilities endpoints to GO

[ocket] Fixed incorrect parameter contraint

[ocket] Added godoc

[ocket] Added support in the Go Client for capabilities

[ocket] Added API/client tests

[ocket] Added Python client support

[ocket] Updated docs

[ocket] Added changelog updates

[ocket] Traffic Portal changes to reflect deprecation

[ocket] Fix API route definition for consistency

[ocket] Remove unnecessary debug line

[ocket] Use Fatalf when warranted

[ocket] Use API functions to write responses

[ocket] Add trailing newlines to API responses

[ocket] fix compilation error

[ocket] Switch URL building to use proper net/url encoding

[ocket] add db struct tags

[ocket] Add page/where/orderby/limit support

[ocket] fix some docs compilation error/warning


--
[...truncated 3.06 MB...]
traffic_portal_build_1   | +-- forever-agent@0.6.1 
traffic_portal_build_1   | +-- form-data@2.3.3 
traffic_portal_build_1   | | `-- asynckit@0.4.0 
traffic_portal_build_1   | +-- har-validator@5.1.3 
traffic_portal_build_1   | | +-- ajv@6.10.2 
traffic_portal_build_1   | | | +-- fast-deep-equal@2.0.1 
traffic_portal_build_1   | | | +-- 
fast-json-stable-stringify@2.0.0 
traffic_portal_build_1   | | | +-- json-schema-traverse@0.4.1 
traffic_portal_build_1   | | | `-- uri-js@4.2.2 
traffic_portal_build_1   | | |   `-- punycode@2.1.1 
traffic_portal_build_1   | | `-- har-schema@2.0.0 
traffic_portal_build_1   | +-- http-signature@1.2.0 
traffic_portal_build_1   | | +-- assert-plus@1.0.0 
traffic_portal_build_1   | | +-- jsprim@1.4.1 
traffic_portal_build_1   | | | +-- extsprintf@1.3.0 
traffic_portal_build_1   | | | +-- json-schema@0.2.3 
traffic_portal_build_1   | | | `-- verror@1.10.0 
traffic_portal_build_1   | | `-- sshpk@1.16.1 
traffic_portal_build_1   | |   +-- asn1@0.2.4 
traffic_portal_build_1   | |   +-- bcrypt-pbkdf@1.0.2 
traffic_portal_build_1   | |   +-- dashdash@1.14.1 
traffic_portal_build_1   | |   +-- ecc-jsbn@0.1.2 
traffic_portal_build_1   | |   +-- getpass@0.1.7 
traffic_portal_build_1   | |   +-- jsbn@0.1.1 
traffic_portal_build_1   | |   `-- tweetnacl@0.14.5 
traffic_portal_build_1   | +-- is-typedarray@1.0.0 
traffic_portal_build_1   | +-- json-stringify-safe@5.0.1 
traffic_portal_build_1   | +-- oauth-sign@0.9.0 
traffic_portal_build_1   | +-- performance-now@2.1.0 
traffic_portal_build_1   | +-- qs@6.5.2 
traffic_portal_build_1   | +-- tough-cookie@2.4.3 
traffic_portal_build_1   | | +-- psl@1.4.0 
traffic_portal_build_1   | | `-- punycode@1.4.1 
traffic_portal_build_1   | +-- tunnel-agent@0.6.0 
traffic_portal_build_1   | `-- uuid@3.3.3 
traffic_portal_build_1   | 
traffic_portal_build_1   | npm WARN optional SKIPPING OPTIONAL 
DEPENDENCY: fsevents@^1.0.0 (node_modules/chokidar/node_modules/fsevents):
traffic_portal_build_1   | npm WARN notsup SKIPPING OPTIONAL 
DEPENDENCY: Unsupported platform for fsevents@1.2.9: wanted 
{"os":"darwin","arch":"any"} (current: {"os":"linux","arch":"x64"})
traffic_portal_build_1   | npm WARN traffic_portal@ No description
traffic_portal_build_1   | npm WARN traffic_portal@ No repository 
field.
traffic_portal_build_1   | npm WARN traffic_portal@ No license field.
traffic_portal_build_1   | 
traffic_portal_build_1   | Done.
traffic_portal_build_1   | 
traffic_portal_build_1   | 
traffic_portal_build_1   | Execution Time (2019-10-11 23:39:31 UTC)
traffic_portal_build_1   | loading tasks  1.9s  ▇ 3%
traffic_portal_build_1   | compass:prod  17.2s  
▇▇▇▇▇▇▇▇▇ 27%
traffic_portal_build_1   | browserify2:app-prod   3.5s  ▇▇ 
5%
traffic_portal_build_1   | browserify2:shared-libs-prod   5.5s  
▇▇▇ 9%
traffic_portal_build_1   | install-dependencies  34.7s  
▇▇▇▇▇▇▇▇▇▇▇▇▇▇▇▇▇▇ 55%
traffic_portal_build_1   | Total 1m 3.3s
traffic_portal_build_1   | 
traffic_portal_build_1   | + exit 0
traffic_portal_build_1   | Executing(%install): /bin/sh -e 
/var/tmp/rpm-tmp.oZuSip
traffic_portal_build_1   | + umask 022
traffic_portal_build_1   | + cd /tmp/trafficcontrol/rpmbuild/BUILD
traffic_portal_build_1   

[GitHub] [trafficcontrol] ocket8888 commented on issue #3766: Cachegroup fallbacks deprecation

[GitBox]

ocket commented on issue #3766: Cachegroup fallbacks deprecation
URL: https://github.com/apache/trafficcontrol/pull/3766#issuecomment-541257332
 
 
   > _The cachegroup_fallbacks endpoints should have a deprecation message 
added to its response_
   
   done.


This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
 
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org


With regards,
Apache Git Services

[GitHub] [trafficcontrol] asf-ci commented on issue #3870: Rewrite /capabilities to Go

[GitBox]

asf-ci commented on issue #3870: Rewrite /capabilities to Go
URL: https://github.com/apache/trafficcontrol/pull/3870#issuecomment-541257304
 
 
   
   Refer to this link for build results (access rights to CI server needed): 
   https://builds.apache.org/job/trafficcontrol-PR/4469/
   


This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
 
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org


With regards,
Apache Git Services

[GitHub] [trafficcontrol] asf-ci commented on issue #3967: Rewrite DELETE federation delivery service to golang

[GitBox]

asf-ci commented on issue #3967: Rewrite DELETE federation delivery service to 
golang
URL: https://github.com/apache/trafficcontrol/pull/3967#issuecomment-541266091
 
 
   
   Refer to this link for build results (access rights to CI server needed): 
   https://builds.apache.org/job/trafficcontrol-PR/4473/
   


This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
 
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org


With regards,
Apache Git Services

Jenkins build is back to normal : trafficcontrol-PR #4473

[Apache Jenkins Server]

See 

[GitHub] [trafficcontrol] asf-ci commented on issue #3901: Fixed runtime panic when creating roles, added docs

[GitBox]

asf-ci commented on issue #3901: Fixed runtime panic when creating roles, added 
docs
URL: https://github.com/apache/trafficcontrol/pull/3901#issuecomment-541268568
 
 
   
   Refer to this link for build results (access rights to CI server needed): 
   https://builds.apache.org/job/trafficcontrol-PR/4474/
   


This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
 
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org


With regards,
Apache Git Services

[GitHub] [trafficcontrol] ocket8888 merged pull request #3967: Rewrite DELETE federation delivery service to golang

[GitBox]

ocket merged pull request #3967: Rewrite DELETE federation delivery service 
to golang
URL: https://github.com/apache/trafficcontrol/pull/3967
 
 
   


This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
 
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org


With regards,
Apache Git Services

[GitHub] [trafficcontrol] ocket8888 closed issue #3794: Rewrite /federations/{{id}}/deliveryservices/{{DSID}} to Go

[GitBox]

ocket closed issue #3794: Rewrite 
/federations/{{id}}/deliveryservices/{{DSID}} to Go
URL: https://github.com/apache/trafficcontrol/issues/3794
 
 
   


This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
 
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org


With regards,
Apache Git Services

Build failed in Jenkins: trafficcontrol-PR #4470

[Apache Jenkins Server]

See 


Changes:

[Michael_Hoppal] Rewrite DELETE federation delivery service to golang

[Michael_Hoppal] Fix test case

[Michael_Hoppal] Dont change path as part of rewrite

[Michael_Hoppal] Minor fix


--
GitHub pull request #3967 of commit d698f21593d9b79a4b65aae8a03105fc28a15cb5, 
no merge conflicts.
Running as SYSTEM
Setting status of d698f21593d9b79a4b65aae8a03105fc28a15cb5 to PENDING with url 
https://builds.apache.org/job/trafficcontrol-PR/4470/ and message: 'Build 
started for merge commit.'
Using context: default
[EnvInject] - Loading node environment variables.
Building remotely on H37 (ubuntu xenial) in workspace 

[WS-CLEANUP] Deleting project workspace...
[WS-CLEANUP] Deferred wipeout is used...
using credential b205a645-1ea7-4dfd-973d-c14ac43cab07
Cloning the remote Git repository
Cloning repository git://github.com/apache/trafficcontrol.git
 > git init  # timeout=10
Fetching upstream changes from git://github.com/apache/trafficcontrol.git
 > git --version # timeout=10
using GIT_SSH to set credentials 
 > git fetch --tags --progress git://github.com/apache/trafficcontrol.git 
 > +refs/heads/*:refs/remotes/origin/*
 > git config remote.origin.url git://github.com/apache/trafficcontrol.git # 
 > timeout=10
 > git config --add remote.origin.fetch +refs/heads/*:refs/remotes/origin/* # 
 > timeout=10
 > git config remote.origin.url git://github.com/apache/trafficcontrol.git # 
 > timeout=10
Fetching upstream changes from git://github.com/apache/trafficcontrol.git
using GIT_SSH to set credentials 
 > git fetch --tags --progress git://github.com/apache/trafficcontrol.git 
 > +refs/pull/*:refs/remotes/origin/pr/*
 > git rev-parse d698f21593d9b79a4b65aae8a03105fc28a15cb5^{commit} # timeout=10
Checking out Revision d698f21593d9b79a4b65aae8a03105fc28a15cb5 (detached)
 > git config core.sparsecheckout # timeout=10
 > git checkout -f d698f21593d9b79a4b65aae8a03105fc28a15cb5
Commit message: "Minor fix"
 > git rev-list --no-walk 994bef618c2d0293508d178d532ab8f42106e461 # timeout=10
[trafficcontrol-PR] $ /bin/bash /tmp/jenkins2911347440655643885.sh
++ echo jenkins-trafficcontrol-PR-4470
++ sed s/-//g
++ sed s/jenkins//
+ proj=trafficcontrolPR4470
+ yml=infrastructure/docker/build/docker-compose.yml
++ mktemp /tmp/docker-compose-
+ dc=/tmp/docker-compose-enqU
++ mktemp /tmp/tc-status-
+ st=/tmp/tc-status-CzSM
+ trap finish EXIT
++ uname -s
++ uname -m
+ curl -o /tmp/docker-compose-enqU -L 
https://github.com/docker/compose/releases/download/1.13.0/docker-compose-Linux-x86_64
  % Total% Received % Xferd  Average Speed   TimeTime Time  Current
 Dload  Upload   Total   SpentLeft  Speed
  0 00 00 0  0  0 --:--:-- --:--:-- --:--:-- 
0100   6170   6170 0996  0 --:--:-- --:--:-- --:--:--   996
  0 00 00 0  0  0 --:--:-- --:--:-- --:--:-- 0 
89 8079k   89 7217k0 0  4048k  0  0:00:01  0:00:01 --:--:-- 
7372k100 8079k  100 8079k0 0  4512k  0  0:00:01  0:00:01 --:--:-- 
8194k
+ chmod +x /tmp/docker-compose-enqU
+ rm -rf dist
+ /tmp/docker-compose-enqU -f infrastructure/docker/build/docker-compose.yml -p 
trafficcontrolPR4470 up
Creating network "trafficcontrolpr4470_default" with the default driver
Building traffic_stats_build
Step 1/7 : FROM centos:7
7: Pulling from library/centos
Digest: sha256:307835c385f656ec2e2fec602cf093224173c51119bbebd602c53c3653a3d6eb
Status: Downloaded newer image for centos:7
 ---> 67fa590cfc1c
Step 2/7 : MAINTAINER d...@trafficcontrol.apache.org
 ---> Running in b842425bbb76
Removing intermediate container b842425bbb76
 ---> 9f85b454fef4
Step 3/7 : VOLUME /trafficcontrol
 ---> Running in 24170f591094
Removing intermediate container 24170f591094
 ---> 986d1576fa2d
Step 4/7 : RUN  rpm --import /etc/pki/rpm-gpg/RPM-GPG-KEY-CentOS-7 &&   rpm 
--import https://dl.fedoraproject.org/pub/epel/RPM-GPG-KEY-EPEL-7 &&yum 
-y update ca-certificates &&yum -y install  epel-release && 
yum -y clean all
 ---> Running in 8f7bb521addd
Service 'traffic_stats_build' failed to build: no status provided on response: 
unknown
+ exit 1
+ finish
+ /tmp/docker-compose-enqU -f infrastructure/docker/build/docker-compose.yml -p 
trafficcontrolPR4470 down -v
Removing network trafficcontrolpr4470_default
+ /tmp/docker-compose-enqU -f infrastructure/docker/build/docker-compose.yml -p 
trafficcontrolPR4470 rm -v -f
No stopped containers
+ rm -f /tmp/docker-compose-enqU
Build step 'Execute shell' marked build as failure
Skipped archiving because build is not successful

Jenkins build is back to normal : trafficcontrol-master-build #1529

[Apache Jenkins Server]

See 

[GitHub] [trafficcontrol] asf-ci commented on issue #3870: Rewrite /capabilities to Go

[GitBox]

asf-ci commented on issue #3870: Rewrite /capabilities to Go
URL: https://github.com/apache/trafficcontrol/pull/3870#issuecomment-541278280
 
 
   
   Refer to this link for build results (access rights to CI server needed): 
   https://builds.apache.org/job/trafficcontrol-PR/4476/
   


This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
 
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org


With regards,
Apache Git Services

Build failed in Jenkins: trafficcontrol-PR #4476

[Apache Jenkins Server]

See 


Changes:

[ocket] Fix broken api tests (#3983)

[ocket] Rewrote capabilities endpoints to GO

[ocket] Fixed incorrect parameter contraint

[ocket] Added godoc

[ocket] Added support in the Go Client for capabilities

[ocket] Added API/client tests

[ocket] Added Python client support

[ocket] Updated docs

[ocket] Added changelog updates

[ocket] Traffic Portal changes to reflect deprecation

[ocket] Fix API route definition for consistency

[ocket] Remove unnecessary debug line

[ocket] Use Fatalf when warranted

[ocket] Use API functions to write responses

[ocket] Add trailing newlines to API responses

[ocket] fix compilation error

[ocket] Switch URL building to use proper net/url encoding

[ocket] add db struct tags

[ocket] Add page/where/orderby/limit support

[ocket] fix some docs compilation error/warning


--
[...truncated 3.80 MB...]
traffic_portal_build_1   | | `-- delayed-stream@1.0.0 
traffic_portal_build_1   | +-- extend@3.0.2 
traffic_portal_build_1   | +-- forever-agent@0.6.1 
traffic_portal_build_1   | +-- form-data@2.3.3 
traffic_portal_build_1   | | `-- asynckit@0.4.0 
traffic_portal_build_1   | +-- har-validator@5.1.3 
traffic_portal_build_1   | | +-- ajv@6.10.2 
traffic_portal_build_1   | | | +-- fast-deep-equal@2.0.1 
traffic_portal_build_1   | | | +-- 
fast-json-stable-stringify@2.0.0 
traffic_portal_build_1   | | | +-- json-schema-traverse@0.4.1 
traffic_portal_build_1   | | | `-- uri-js@4.2.2 
traffic_portal_build_1   | | |   `-- punycode@2.1.1 
traffic_portal_build_1   | | `-- har-schema@2.0.0 
traffic_portal_build_1   | +-- http-signature@1.2.0 
traffic_portal_build_1   | | +-- assert-plus@1.0.0 
traffic_portal_build_1   | | +-- jsprim@1.4.1 
traffic_portal_build_1   | | | +-- extsprintf@1.3.0 
traffic_portal_build_1   | | | +-- json-schema@0.2.3 
traffic_portal_build_1   | | | `-- verror@1.10.0 
traffic_portal_build_1   | | `-- sshpk@1.16.1 
traffic_portal_build_1   | |   +-- asn1@0.2.4 
traffic_portal_build_1   | |   +-- bcrypt-pbkdf@1.0.2 
traffic_portal_build_1   | |   +-- dashdash@1.14.1 
traffic_portal_build_1   | |   +-- ecc-jsbn@0.1.2 
traffic_portal_build_1   | |   +-- getpass@0.1.7 
traffic_portal_build_1   | |   +-- jsbn@0.1.1 
traffic_portal_build_1   | |   `-- tweetnacl@0.14.5 
traffic_portal_build_1   | +-- is-typedarray@1.0.0 
traffic_portal_build_1   | +-- json-stringify-safe@5.0.1 
traffic_portal_build_1   | +-- oauth-sign@0.9.0 
traffic_portal_build_1   | +-- performance-now@2.1.0 
traffic_portal_build_1   | +-- qs@6.5.2 
traffic_portal_build_1   | +-- tough-cookie@2.4.3 
traffic_portal_build_1   | | +-- psl@1.4.0 
traffic_portal_build_1   | | `-- punycode@1.4.1 
traffic_portal_build_1   | +-- tunnel-agent@0.6.0 
traffic_portal_build_1   | `-- uuid@3.3.3 
traffic_portal_build_1   | 
traffic_portal_build_1   | npm WARN optional SKIPPING OPTIONAL 
DEPENDENCY: fsevents@^1.0.0 (node_modules/chokidar/node_modules/fsevents):
traffic_portal_build_1   | npm WARN notsup SKIPPING OPTIONAL 
DEPENDENCY: Unsupported platform for fsevents@1.2.9: wanted 
{"os":"darwin","arch":"any"} (current: {"os":"linux","arch":"x64"})
traffic_portal_build_1   | npm WARN traffic_portal@ No description
traffic_portal_build_1   | npm WARN traffic_portal@ No repository 
field.
traffic_portal_build_1   | npm WARN traffic_portal@ No license field.
traffic_portal_build_1   | 
traffic_portal_build_1   | Done.
traffic_portal_build_1   | 
traffic_portal_build_1   | 
traffic_portal_build_1   | Execution Time (2019-10-12 03:10:14 UTC)
traffic_portal_build_1   | loading tasks 994ms  ▇ 
3%
traffic_portal_build_1   | compass:prod   8.6s  
▇▇▇▇▇▇▇▇ 24%
traffic_portal_build_1   | browserify2:app-prod   2.2s  
▇▇ 6%
traffic_portal_build_1   | browserify2:shared-libs-prod   3.1s  
▇▇▇ 9%
traffic_portal_build_1   | install-dependencies21s  
▇▇▇▇▇▇▇▇▇▇▇▇▇▇▇▇▇▇▇ 58%
traffic_portal_build_1   | Total 36.2s
traffic_portal_build_1   | 

Build failed in Jenkins: trafficcontrol-PR #4468

[Apache Jenkins Server]

See 


Changes:

[Michael_Hoppal] Rewrite DELETE federation delivery service to golang

[Michael_Hoppal] Fix test case

[Michael_Hoppal] Dont change path as part of rewrite


--
GitHub pull request #3967 of commit f0e35c3387186f87955f7f030eca7676e17ffe15, 
no merge conflicts.
Running as SYSTEM
Setting status of f0e35c3387186f87955f7f030eca7676e17ffe15 to PENDING with url 
https://builds.apache.org/job/trafficcontrol-PR/4468/ and message: 'Build 
started for merge commit.'
Using context: default
[EnvInject] - Loading node environment variables.
Building remotely on H38 (ubuntu xenial) in workspace 

[WS-CLEANUP] Deleting project workspace...
[WS-CLEANUP] Deferred wipeout is used...
using credential b205a645-1ea7-4dfd-973d-c14ac43cab07
Cloning the remote Git repository
Cloning repository git://github.com/apache/trafficcontrol.git
 > git init  # timeout=10
Fetching upstream changes from git://github.com/apache/trafficcontrol.git
 > git --version # timeout=10
using GIT_SSH to set credentials 
 > git fetch --tags --progress git://github.com/apache/trafficcontrol.git 
 > +refs/heads/*:refs/remotes/origin/*
 > git config remote.origin.url git://github.com/apache/trafficcontrol.git # 
 > timeout=10
 > git config --add remote.origin.fetch +refs/heads/*:refs/remotes/origin/* # 
 > timeout=10
 > git config remote.origin.url git://github.com/apache/trafficcontrol.git # 
 > timeout=10
Fetching upstream changes from git://github.com/apache/trafficcontrol.git
using GIT_SSH to set credentials 
 > git fetch --tags --progress git://github.com/apache/trafficcontrol.git 
 > +refs/pull/*:refs/remotes/origin/pr/*
 > git rev-parse f0e35c3387186f87955f7f030eca7676e17ffe15^{commit} # timeout=10
Checking out Revision f0e35c3387186f87955f7f030eca7676e17ffe15 (detached)
 > git config core.sparsecheckout # timeout=10
 > git checkout -f f0e35c3387186f87955f7f030eca7676e17ffe15
Commit message: "Dont change path as part of rewrite"
 > git rev-list --no-walk 54de6971b793905c5dbeee75319d0109c43c1869 # timeout=10
[trafficcontrol-PR] $ /bin/bash /tmp/jenkins8015931376586364533.sh
++ echo jenkins-trafficcontrol-PR-4468
++ sed s/-//g
++ sed s/jenkins//
+ proj=trafficcontrolPR4468
+ yml=infrastructure/docker/build/docker-compose.yml
++ mktemp /tmp/docker-compose-
+ dc=/tmp/docker-compose-YAA5
++ mktemp /tmp/tc-status-
+ st=/tmp/tc-status-enAl
+ trap finish EXIT
++ uname -s
++ uname -m
+ curl -o /tmp/docker-compose-YAA5 -L 
https://github.com/docker/compose/releases/download/1.13.0/docker-compose-Linux-x86_64
  % Total% Received % Xferd  Average Speed   TimeTime Time  Current
 Dload  Upload   Total   SpentLeft  Speed
  0 00 00 0  0  0 --:--:-- --:--:-- --:--:-- 
0100   6170   6170 0975  0 --:--:-- --:--:-- --:--:--   976
  0 00 00 0  0  0 --:--:-- --:--:-- --:--:-- 0 
86 8079k   86 7023k0 0  3961k  0  0:00:02  0:00:01  0:00:01 
7315k100 8079k  100 8079k0 0  4421k  0  0:00:01  0:00:01 --:--:-- 
7975k
+ chmod +x /tmp/docker-compose-YAA5
+ rm -rf dist
+ /tmp/docker-compose-YAA5 -f infrastructure/docker/build/docker-compose.yml -p 
trafficcontrolPR4468 up
Creating network "trafficcontrolpr4468_default" with the default driver
Creating trafficcontrolpr4468_source_1 ... 
Creating trafficcontrolpr4468_grovetccfg_build_1 ... 
Creating trafficcontrolpr4468_grove_build_1 ... 
Creating trafficcontrolpr4468_docs_1 ... 
Creating trafficcontrolpr4468_traffic_monitor_build_1 ... 
Creating trafficcontrolpr4468_traffic_stats_build_1 ... 
Creating trafficcontrolpr4468_traffic_ops_build_1 ... 
Creating trafficcontrolpr4468_weasel_1 ... 
Creating trafficcontrolpr4468_source_1
Creating trafficcontrolpr4468_grovetccfg_build_1
Creating trafficcontrolpr4468_grove_build_1
Creating trafficcontrolpr4468_docs_1
Creating trafficcontrolpr4468_traffic_router_build_1 ... 
Creating trafficcontrolpr4468_traffic_portal_build_1 ... 
Creating trafficcontrolpr4468_traffic_monitor_build_1
Creating trafficcontrolpr4468_traffic_ops_build_1
Creating trafficcontrolpr4468_traffic_stats_build_1
Creating trafficcontrolpr4468_weasel_1
Creating trafficcontrolpr4468_traffic_router_build_1
Creating trafficcontrolpr4468_traffic_portal_build_1
Creating trafficcontrolpr4468_traffic_monitor_build_1 ... 
error
ERROR: for trafficcontrolpr4468_traffic_monitor_build_1  Cannot start service 
traffic_monitor_build: no status provided on response: unknown
Creating trafficcontrolpr4468_traffic_portal_build_1 ... 
error
ERROR: for trafficcontrolpr4468_traffic_portal_build_1  Cannot start service 
traffic_portal_build: no status provided on response: unknown
Creating 

Jenkins build is back to normal : trafficcontrol-traffic_ops-test #1571

[Apache Jenkins Server]

See