[GitHub] [trafficcontrol] mitchell852 commented on a change in pull request #4044: Ensure server_capability can only be assigned to edges or mids

mitchell852 commented on a change in pull request #4044: Ensure server_capability can only be assigned to edges or mids URL: https://github.com/apache/trafficcontrol/pull/4044#discussion_r341199299 ## File path: traffic_ops/traffic_ops_golang/server/servers_server_capability.go

[GitHub] [trafficcontrol] mitchell852 commented on a change in pull request #4035: TP: adds the ability to add/remove required server capabilities from DS

mitchell852 commented on a change in pull request #4035: TP: adds the ability to add/remove required server capabilities from DS URL: https://github.com/apache/trafficcontrol/pull/4035#discussion_r341160185 ## File path: CHANGELOG.md ## @@ -59,9 +59,9 @@ The format is

Jenkins build is back to normal : trafficcontrol-PR #4681

See

[GitHub] [trafficcontrol] asf-ci commented on issue #3996: Rewrote /user/current to Go

asf-ci commented on issue #3996: Rewrote /user/current to Go URL: https://github.com/apache/trafficcontrol/pull/3996#issuecomment-548443125 Refer to this link for build results (access rights to CI server needed): https://builds.apache.org/job/trafficcontrol-PR/4681/

[GitHub] [trafficcontrol] mitchell852 commented on a change in pull request #4044: Ensure server_capability can only be assigned to edges or mids

mitchell852 commented on a change in pull request #4044: Ensure server_capability can only be assigned to edges or mids URL: https://github.com/apache/trafficcontrol/pull/4044#discussion_r341177948 ## File path: traffic_ops/traffic_ops_golang/server/servers_server_capability.go

[GitHub] [trafficcontrol] mitchell852 commented on issue #4038: TP, TO: server capabilities are allowed to be assigned to any servers which are not mid or edge

mitchell852 commented on issue #4038: TP, TO: server capabilities are allowed to be assigned to any servers which are not mid or edge URL: https://github.com/apache/trafficcontrol/issues/4038#issuecomment-548427524 > sure! also, while you're at it. you could probably fix the isCache

[GitHub] [trafficcontrol] dandypham opened a new issue #4052: Can create Federation without CDN

dandypham opened a new issue #4052: Can create Federation without CDN URL: https://github.com/apache/trafficcontrol/issues/4052 ## I'm submitting a ... - [x] bug report - [ ] new feature / enhancement request - [ ] improvement request (usability,

[GitHub] [trafficcontrol] mitchell852 commented on a change in pull request #4044: Ensure server_capability can only be assigned to edges or mids

mitchell852 commented on a change in pull request #4044: Ensure server_capability can only be assigned to edges or mids URL: https://github.com/apache/trafficcontrol/pull/4044#discussion_r341252434 ## File path:

[GitHub] [trafficcontrol] mitchell852 commented on a change in pull request #4044: Ensure server_capability can only be assigned to edges or mids

mitchell852 commented on a change in pull request #4044: Ensure server_capability can only be assigned to edges or mids URL: https://github.com/apache/trafficcontrol/pull/4044#discussion_r341252016 ## File path:

[GitHub] [trafficcontrol] ChrisHines commented on a change in pull request #4046: Improve docs

ChrisHines commented on a change in pull request #4046: Improve docs URL: https://github.com/apache/trafficcontrol/pull/4046#discussion_r341141549 ## File path: docs/source/admin/traffic_router.rst ## @@ -577,11 +577,11 @@ What You Need .. seealso:: See

[GitHub] [trafficcontrol] rob05c commented on a change in pull request #4044: Ensure server_capability can only be assigned to edges or mids

rob05c commented on a change in pull request #4044: Ensure server_capability can only be assigned to edges or mids URL: https://github.com/apache/trafficcontrol/pull/4044#discussion_r341202275 ## File path: traffic_ops/traffic_ops_golang/server/servers_server_capability.go

[GitHub] [trafficcontrol] rob05c commented on a change in pull request #4044: Ensure server_capability can only be assigned to edges or mids

rob05c commented on a change in pull request #4044: Ensure server_capability can only be assigned to edges or mids URL: https://github.com/apache/trafficcontrol/pull/4044#discussion_r341211653 ## File path: traffic_ops/traffic_ops_golang/server/servers_server_capability.go

[GitHub] [trafficcontrol] mhoppa commented on issue #4044: Ensure server_capability can only be assigned to edges or mids

mhoppa commented on issue #4044: Ensure server_capability can only be assigned to edges or mids URL: https://github.com/apache/trafficcontrol/pull/4044#issuecomment-548459991 @ocket TP is done, @mitchell852 let me know if you were thinking something different then what I implemented

[GitHub] [trafficcontrol] mitchell852 commented on a change in pull request #4044: Ensure server_capability can only be assigned to edges or mids

mitchell852 commented on a change in pull request #4044: Ensure server_capability can only be assigned to edges or mids URL: https://github.com/apache/trafficcontrol/pull/4044#discussion_r341252016 ## File path:

Build failed in Jenkins: trafficcontrol-PR #4682

See Changes: [Michael_Hoppal] Ensure server_capability can only be assigned to edges or mids [Michael_Hoppal] Add TP logic to block attempting to assign sc to non edge/mid

[GitHub] [trafficcontrol] asf-ci commented on issue #4044: Ensure server_capability can only be assigned to edges or mids

asf-ci commented on issue #4044: Ensure server_capability can only be assigned to edges or mids URL: https://github.com/apache/trafficcontrol/pull/4044#issuecomment-548467495 Refer to this link for build results (access rights to CI server needed):

[GitHub] [trafficcontrol] ChrisHines commented on a change in pull request #4046: Improve docs

ChrisHines commented on a change in pull request #4046: Improve docs URL: https://github.com/apache/trafficcontrol/pull/4046#discussion_r341138573 ## File path: docs/source/admin/quick_howto/ciab.rst ## @@ -237,7 +237,7 @@ Multiple optional containers may be combined by

[GitHub] [trafficcontrol] mitchell852 edited a comment on issue #4000: Put server_capability status code is incorrect

mitchell852 edited a comment on issue #4000: Put server_capability status code is incorrect URL: https://github.com/apache/trafficcontrol/issues/4000#issuecomment-548422212 @ZugNZwang - can you retitle this / rewrite the description a bit to be more generic as this is a global api issue?

[GitHub] [trafficcontrol] ocket8888 commented on a change in pull request #4035: TP: adds the ability to add/remove required server capabilities from DS

ocket commented on a change in pull request #4035: TP: adds the ability to add/remove required server capabilities from DS URL: https://github.com/apache/trafficcontrol/pull/4035#discussion_r341217546 ## File path:

[GitHub] [trafficcontrol] asf-ci commented on issue #4035: TP: adds the ability to add/remove required server capabilities from DS

asf-ci commented on issue #4035: TP: adds the ability to add/remove required server capabilities from DS URL: https://github.com/apache/trafficcontrol/pull/4035#issuecomment-548411085 Refer to this link for build results (access rights to CI server needed):

Build failed in Jenkins: trafficcontrol-PR #4680

See Changes: [mitchell852] adds the ability to add or remove required server capabilities from a [mitchell852] adds context menu items for viewing a server capability's servers and [mitchell852] adds UI

[GitHub] [trafficcontrol] ocket8888 merged pull request #4046: Improve docs

ocket merged pull request #4046: Improve docs URL: https://github.com/apache/trafficcontrol/pull/4046 This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use

[GitHub] [trafficcontrol] mitchell852 commented on a change in pull request #4035: TP: adds the ability to add/remove required server capabilities from DS

mitchell852 commented on a change in pull request #4035: TP: adds the ability to add/remove required server capabilities from DS URL: https://github.com/apache/trafficcontrol/pull/4035#discussion_r341159475 ## File path:

[GitHub] [trafficcontrol] mitchell852 commented on issue #4000: Put server_capability status code is incorrect

mitchell852 commented on issue #4000: Put server_capability status code is incorrect URL: https://github.com/apache/trafficcontrol/issues/4000#issuecomment-548422212 @ZugNZwang - can you retitle this / rewrite the description a bit to be more generic?

[GitHub] [trafficcontrol] ZugNZwang opened a new issue #4053: cache_stats metricType documentation should be maxkbps

ZugNZwang opened a new issue #4053: cache_stats metricType documentation should be maxkbps URL: https://github.com/apache/trafficcontrol/issues/4053 ## I'm submitting a ... - [ ] bug report - [ ] new feature / enhancement request - [X] improvement request

[GitHub] [trafficcontrol] mhoppa commented on a change in pull request #3996: Rewrote /user/current to Go

mhoppa commented on a change in pull request #3996: Rewrote /user/current to Go URL: https://github.com/apache/trafficcontrol/pull/3996#discussion_r341168333 ## File path: lib/go-tc/users.go ## @@ -99,6 +109,179 @@ type UserCurrent struct { commonUserFields }

[GitHub] [trafficcontrol] mattjackson220 commented on issue #4012: Added IPv6 checking to Traffic Monitor

mattjackson220 commented on issue #4012: Added IPv6 checking to Traffic Monitor URL: https://github.com/apache/trafficcontrol/pull/4012#issuecomment-548452178 Updated with the PeerPollingProtocol I'm digging through to see why there are so many "Peer is reachable" lines. I would expect

[GitHub] [trafficcontrol] mitchell852 commented on a change in pull request #4044: Ensure server_capability can only be assigned to edges or mids

mitchell852 commented on a change in pull request #4044: Ensure server_capability can only be assigned to edges or mids URL: https://github.com/apache/trafficcontrol/pull/4044#discussion_r341254261 ## File path:

Jenkins build is back to normal : trafficcontrol-traffic_ops-test #1620

See

[GitHub] [trafficcontrol] lbathina opened a new issue #4058: Inactive tenant - should not be allowed to login with an appropriate message

lbathina opened a new issue #4058: Inactive tenant - should not be allowed to login with an appropriate message URL: https://github.com/apache/trafficcontrol/issues/4058 ## I'm submitting a ... - [X] bug report - [ ] new feature / enhancement request - [X]

[GitHub] [trafficcontrol] ocket8888 merged pull request #4035: TP: adds the ability to add/remove required server capabilities from DS

ocket merged pull request #4035: TP: adds the ability to add/remove required server capabilities from DS URL: https://github.com/apache/trafficcontrol/pull/4035 This is an automated message from the Apache Git Service.

[GitHub] [trafficcontrol] ocket8888 commented on issue #4055: TP/T0: Tenant should not be allowed to be a parent to itself & also not allow a child of a parent to be a parent of the its parent

ocket commented on issue #4055: TP/T0: Tenant should not be allowed to be a parent to itself & also not allow a child of a parent to be a parent of the its parent URL: https://github.com/apache/trafficcontrol/issues/4055#issuecomment-548527804 Did the assignment succeed? I doubt it,

[GitHub] [trafficcontrol] ocket8888 edited a comment on issue #4055: TP/T0: Tenant should not be allowed to be a parent to itself & also not allow a child of a parent to be a parent of the its parent

ocket edited a comment on issue #4055: TP/T0: Tenant should not be allowed to be a parent to itself & also not allow a child of a parent to be a parent of the its parent URL: https://github.com/apache/trafficcontrol/issues/4055#issuecomment-548527804 Did the assignment succeed? I

[GitHub] [trafficcontrol] asf-ci commented on issue #4044: Ensure server_capability can only be assigned to edges or mids

asf-ci commented on issue #4044: Ensure server_capability can only be assigned to edges or mids URL: https://github.com/apache/trafficcontrol/pull/4044#issuecomment-548545249 Refer to this link for build results (access rights to CI server needed):

Build failed in Jenkins: trafficcontrol-master-build #1575

See Changes: [ocket] Rewrite PUT /api/1.1/servers/:id/status to Go (#4030) -- Started by an SCM change Running as SYSTEM [EnvInject] - Loading node

[GitHub] [trafficcontrol] dandypham commented on issue #4052: Can create Federation without CDN

dandypham commented on issue #4052: Can create Federation without CDN URL: https://github.com/apache/trafficcontrol/issues/4052#issuecomment-548532027 Yes, I just checked again. So you can create a Federations without the CDN. Then the Federation is not display as first but if you give it

[GitHub] [trafficcontrol] ocket8888 commented on issue #4058: Inactive tenant - should not be allowed to login with an appropriate message

ocket commented on issue #4058: Inactive tenant - should not be allowed to login with an appropriate message URL: https://github.com/apache/trafficcontrol/issues/4058#issuecomment-548547001 > _"Currently an user of an inactive tenant is able to login and POST , GET and DELETE"_ >

[GitHub] [trafficcontrol] ocket8888 commented on issue #4052: Can create Federation without CDN

ocket commented on issue #4052: Can create Federation without CDN URL: https://github.com/apache/trafficcontrol/issues/4052#issuecomment-548507294 That URI ought to result in a 404 if the CDN ID doesn't exist. But also, a 200 status code doesn't technically mean that it was a

[GitHub] [trafficcontrol] ZugNZwang opened a new issue #4054: cache_stats endpoint orderby=value returns Internal Server Error

ZugNZwang opened a new issue #4054: cache_stats endpoint orderby=value returns Internal Server Error URL: https://github.com/apache/trafficcontrol/issues/4054 ## I'm submitting a ... - [X] bug report - [ ] new feature / enhancement request - [ ] improvement

[GitHub] [trafficcontrol] ocket8888 merged pull request #4041: Block server servercapability delete if associated ds requires it

ocket merged pull request #4041: Block server servercapability delete if associated ds requires it URL: https://github.com/apache/trafficcontrol/pull/4041 This is an automated message from the Apache Git Service. To

Build failed in Jenkins: trafficcontrol-PR #4684

See Changes: [ocket] Improve docs (#4046) [ocket] TP: adds the ability to add/remove required server capabilities from DS [ocket] Rewrite PUT /api/1.1/servers/:id/status to Go (#4030)

[GitHub] [trafficcontrol] asf-ci commented on issue #4044: Ensure server_capability can only be assigned to edges or mids

asf-ci commented on issue #4044: Ensure server_capability can only be assigned to edges or mids URL: https://github.com/apache/trafficcontrol/pull/4044#issuecomment-548516679 Refer to this link for build results (access rights to CI server needed):

[GitHub] [trafficcontrol] ocket8888 merged pull request #4030: Rewrite PUT /api/1.1/servers/:id/status to Go

ocket merged pull request #4030: Rewrite PUT /api/1.1/servers/:id/status to Go URL: https://github.com/apache/trafficcontrol/pull/4030 This is an automated message from the Apache Git Service. To respond to the message,

Jenkins build is back to normal : trafficcontrol-PR #4683

See

[GitHub] [trafficcontrol] ocket8888 closed issue #3829: Rewrite /servers/{{id}}/status to Go

ocket closed issue #3829: Rewrite /servers/{{id}}/status to Go URL: https://github.com/apache/trafficcontrol/issues/3829 This is an automated message from the Apache Git Service. To respond to the message, please log on

Build failed in Jenkins: trafficcontrol-3.1.x-rat #11

See Changes: -- Started by upstream project "trafficcontrol-3.1.x-build" build number 11 originally caused by: Started by an SCM change Started by an SCM change Started by an

[GitHub] [trafficcontrol] lbathina opened a new issue #4055: TP/T0: Tenant should not be allowed to be a parent to itself.

lbathina opened a new issue #4055: TP/T0: Tenant should not be allowed to be a parent to itself. URL: https://github.com/apache/trafficcontrol/issues/4055 ## I'm submitting a ... - [X] bug report - [ ] new feature / enhancement request - [ ] improvement

[GitHub] [trafficcontrol] lbathina commented on issue #4055: TP/T0: Tenant should not be allowed to be a parent to itself & also not allow a child of a parent to be a parent of the its parent

lbathina commented on issue #4055: TP/T0: Tenant should not be allowed to be a parent to itself & also not allow a child of a parent to be a parent of the its parent URL: https://github.com/apache/trafficcontrol/issues/4055#issuecomment-548528853 TP is just passing in the info got from

[GitHub] [trafficcontrol] lbathina opened a new issue #4057: TP: root tenant should not be editable in TP

lbathina opened a new issue #4057: TP: root tenant should not be editable in TP URL: https://github.com/apache/trafficcontrol/issues/4057 ## I'm submitting a ... - [X] bug report - [ ] new feature / enhancement request - [X] improvement request (usability,

[GitHub] [trafficcontrol] dandypham commented on issue #4052: Can create Federation without CDN

dandypham commented on issue #4052: Can create Federation without CDN URL: https://github.com/apache/trafficcontrol/issues/4052#issuecomment-548535945 Yes, so if the user decide to change the Delivery Service it will change the CDN also.

[GitHub] [trafficcontrol] lbathina opened a new issue #4056: TO: tenant users returned is not filtered list of users belong to the tenant

lbathina opened a new issue #4056: TO: tenant users returned is not filtered list of users belong to the tenant URL: https://github.com/apache/trafficcontrol/issues/4056 ## I'm submitting a ... - [X] bug report - [ ] new feature / enhancement request - [ ]

[GitHub] [trafficcontrol] mitchell852 commented on issue #4044: Ensure server_capability can only be assigned to edges or mids

mitchell852 commented on issue #4044: Ensure server_capability can only be assigned to edges or mids URL: https://github.com/apache/trafficcontrol/pull/4044#issuecomment-548542539 by the way, nice video in your PR description!

[GitHub] [trafficcontrol] mhoppa commented on a change in pull request #4044: Ensure server_capability can only be assigned to edges or mids

mhoppa commented on a change in pull request #4044: Ensure server_capability can only be assigned to edges or mids URL: https://github.com/apache/trafficcontrol/pull/4044#discussion_r341200033 ## File path: traffic_ops/traffic_ops_golang/server/servers_server_capability.go

Jenkins build is back to normal : trafficcontrol-traffic_ops-test #1617

See

[GitHub] [trafficcontrol] mitchell852 commented on issue #4041: Block server servercapability delete if associated ds requires it

mitchell852 commented on issue #4041: Block server servercapability delete if associated ds requires it URL: https://github.com/apache/trafficcontrol/pull/4041#issuecomment-548444964 what about the opposite scenario? blocking ds required capability addition IF assigned servers don't have

[GitHub] [trafficcontrol] asf-ci commented on issue #4059: deliveryservices_required_capability return 403

asf-ci commented on issue #4059: deliveryservices_required_capability return 403 URL: https://github.com/apache/trafficcontrol/pull/4059#issuecomment-548570327 Can one of the admins verify this patch? This is an automated

[GitHub] [trafficcontrol] asf-ci commented on issue #4060: Block allowing requiring caps on ds that their servers dont have

asf-ci commented on issue #4060: Block allowing requiring caps on ds that their servers dont have URL: https://github.com/apache/trafficcontrol/pull/4060#issuecomment-548579047 Refer to this link for build results (access rights to CI server needed):

[GitHub] [trafficcontrol] mhoppa opened a new pull request #4060: Block allowing requiring caps on ds that their servers dont have

mhoppa opened a new pull request #4060: Block allowing requiring caps on ds that their servers dont have URL: https://github.com/apache/trafficcontrol/pull/4060 ## What does this PR (Pull Request) do? - [x] This PR fixes is not related to any Issue This PR adds the

[GitHub] [trafficcontrol] mitchell852 opened a new pull request #4061: TP: fetches tenant users with the proper query param and removes tenantId…

mitchell852 opened a new pull request #4061: TP: fetches tenant users with the proper query param and removes tenantId… URL: https://github.com/apache/trafficcontrol/pull/4061 … from the list of supported query params in the docs ## What does this PR (Pull Request) do? When TP

Build failed in Jenkins: trafficcontrol-PR #4686

See Changes: [mitchell852] fetches tenant users with the proper query param and removes tenantId -- GitHub pull request #4061 of commit

[GitHub] [trafficcontrol] asf-ci commented on issue #4061: TP: fetches tenant users with the proper query param and removes tenantId…

asf-ci commented on issue #4061: TP: fetches tenant users with the proper query param and removes tenantId… URL: https://github.com/apache/trafficcontrol/pull/4061#issuecomment-548582294 Refer to this link for build results (access rights to CI server needed):

Build failed in Jenkins: trafficcontrol-PR #4687

See Changes: [Michael_Hoppal] Block allowing requiring caps on ds that their servers dont have [Michael_Hoppal] Fix API tests -- GitHub pull request #4060 of commit

[GitHub] [trafficcontrol] asf-ci commented on issue #4060: Block allowing requiring caps on ds that their servers dont have

asf-ci commented on issue #4060: Block allowing requiring caps on ds that their servers dont have URL: https://github.com/apache/trafficcontrol/pull/4060#issuecomment-548582506 Refer to this link for build results (access rights to CI server needed):

[GitHub] [trafficcontrol] jheitz200 opened a new pull request #4059: deliveryservices_required_capability return 403

jheitz200 opened a new pull request #4059: deliveryservices_required_capability return 403 URL: https://github.com/apache/trafficcontrol/pull/4059 - Traffic Ops - Documentation - the documentation for this api is still correct ## What is the best way to verify this PR?

Build failed in Jenkins: trafficcontrol-PR #4685

See Changes: [Michael_Hoppal] Block allowing requiring caps on ds that their servers dont have -- GitHub pull request #4060 of commit