[GitHub] [trafficcontrol] mitchell852 commented on a change in pull request #3595: Removing restangular

mitchell852 commented on a change in pull request #3595: Removing restangular URL: https://github.com/apache/trafficcontrol/pull/3595#discussion_r358883941 ## File path: traffic_portal/app/src/common/api/ProfileParameterService.js ## @@ -35,6 +35,7 @@ var

[GitHub] [trafficcontrol] mitchell852 closed issue #3571: TP: remove Restangular dependency

mitchell852 closed issue #3571: TP: remove Restangular dependency URL: https://github.com/apache/trafficcontrol/issues/3571 This is an automated message from the Apache Git Service. To respond to the message, please log on

[GitHub] [trafficcontrol] mitchell852 closed issue #4194: TP: Generate ISO view won't resolve

mitchell852 closed issue #4194: TP: Generate ISO view won't resolve URL: https://github.com/apache/trafficcontrol/issues/4194 This is an automated message from the Apache Git Service. To respond to the message, please log on

[GitHub] [trafficcontrol] mitchell852 merged pull request #3595: Removing restangular

mitchell852 merged pull request #3595: Removing restangular URL: https://github.com/apache/trafficcontrol/pull/3595 This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub

[GitHub] [trafficcontrol] ocket8888 commented on a change in pull request #3996: Rewrote /user/current to Go

ocket commented on a change in pull request #3996: Rewrote /user/current to Go URL: https://github.com/apache/trafficcontrol/pull/3996#discussion_r358940493 ## File path: traffic_ops/traffic_ops_golang/user/current.go ## @@ -80,3 +144,184 @@ WHERE u.id=$1

[GitHub] [trafficcontrol] ZugNZwang opened a new issue #4219: TO API allows creation of a profile with spaces

ZugNZwang opened a new issue #4219: TO API allows creation of a profile with spaces URL: https://github.com/apache/trafficcontrol/issues/4219 ## I'm submitting a ... - [X] bug report - [ ] new feature / enhancement request - [ ] improvement request

[GitHub] [trafficcontrol] rawlinp commented on a change in pull request #3996: Rewrote /user/current to Go

rawlinp commented on a change in pull request #3996: Rewrote /user/current to Go URL: https://github.com/apache/trafficcontrol/pull/3996#discussion_r358946693 ## File path: lib/go-tc/users.go ## @@ -86,10 +94,11 @@ type commonUserFields struct { // User fields in v14

[GitHub] [trafficcontrol] mitchell852 commented on issue #4199: TP: bug fixes on the any map form

mitchell852 commented on issue #4199: TP: bug fixes on the any map form URL: https://github.com/apache/trafficcontrol/pull/4199#issuecomment-566653475 > UI tests are broken. I don't know if this is the full scope of the problem, but the `should populate and submit the delivery service

[GitHub] [trafficcontrol] ocket8888 commented on a change in pull request #3996: Rewrote /user/current to Go

ocket commented on a change in pull request #3996: Rewrote /user/current to Go URL: https://github.com/apache/trafficcontrol/pull/3996#discussion_r358942272 ## File path: lib/go-tc/users.go ## @@ -86,10 +94,11 @@ type commonUserFields struct { // User fields in v14

[GitHub] [trafficcontrol] asf-ci commented on issue #3595: Removing restangular

asf-ci commented on issue #3595: Removing restangular URL: https://github.com/apache/trafficcontrol/pull/3595#issuecomment-566677695 Refer to this link for build results (access rights to CI server needed): https://builds.apache.org/job/trafficcontrol-PR/4946/

[GitHub] [trafficcontrol] asf-ci commented on issue #2459: Add TO Go deliveryservices/id/capacity

asf-ci commented on issue #2459: Add TO Go deliveryservices/id/capacity URL: https://github.com/apache/trafficcontrol/pull/2459#issuecomment-566704326 Refer to this link for build results (access rights to CI server needed): https://builds.apache.org/job/trafficcontrol-PR/4947/

Build failed in Jenkins: trafficcontrol-PR #4948

See Changes: -- GitHub pull request #3996 of commit dee0e0b521fdce24ad6c37ca44d47cf6c4d585dd, no merge conflicts. Running as SYSTEM Setting status of

[GitHub] [trafficcontrol] asf-ci commented on issue #3996: Rewrote /user/current to Go

asf-ci commented on issue #3996: Rewrote /user/current to Go URL: https://github.com/apache/trafficcontrol/pull/3996#issuecomment-566712832 Refer to this link for build results (access rights to CI server needed): https://builds.apache.org/job/trafficcontrol-PR/4948/

[GitHub] [trafficcontrol] mitchell852 commented on issue #4219: TO API allows creation of a profile with spaces

mitchell852 commented on issue #4219: TO API allows creation of a profile with spaces URL: https://github.com/apache/trafficcontrol/issues/4219#issuecomment-566751754 well apparently TP does not allow spaces but the TO API does.

[GitHub] [trafficcontrol] ocket8888 commented on issue #4105: Rewrite /federation_resolvers/{{ID}} to Go

ocket commented on issue #4105: Rewrite /federation_resolvers/{{ID}} to Go URL: https://github.com/apache/trafficcontrol/pull/4105#issuecomment-566754313 There already is a test in the client integration test suite. It was added in an earlier PR because the testing fixtures needed to

[GitHub] [trafficcontrol] ocket8888 commented on a change in pull request #4105: Rewrite /federation_resolvers/{{ID}} to Go

ocket commented on a change in pull request #4105: Rewrite /federation_resolvers/{{ID}} to Go URL: https://github.com/apache/trafficcontrol/pull/4105#discussion_r359042280 ## File path: traffic_ops/traffic_ops_golang/federation_resolvers/federation_resolvers.go ## @@

[GitHub] [trafficcontrol] ocket8888 commented on a change in pull request #4105: Rewrite /federation_resolvers/{{ID}} to Go

ocket commented on a change in pull request #4105: Rewrite /federation_resolvers/{{ID}} to Go URL: https://github.com/apache/trafficcontrol/pull/4105#discussion_r359042837 ## File path: traffic_ops/traffic_ops_golang/federation_resolvers/federation_resolvers.go ## @@

[GitHub] [trafficcontrol] asf-ci commented on issue #4105: Rewrite /federation_resolvers/{{ID}} to Go

asf-ci commented on issue #4105: Rewrite /federation_resolvers/{{ID}} to Go URL: https://github.com/apache/trafficcontrol/pull/4105#issuecomment-566762653 Refer to this link for build results (access rights to CI server needed): https://builds.apache.org/job/trafficcontrol-PR/4951/

Build failed in Jenkins: trafficcontrol-PR #4951

See Changes: [ocket] Fix struct tags -- [...truncated 2.86 MB...] traffic_portal_build_1 | +-- extend@3.0.2 traffic_portal_build_1 |

[GitHub] [trafficcontrol] mitchell852 closed issue #3788: Rewrite /deliveryservices/{{id}}/capacity to Go

mitchell852 closed issue #3788: Rewrite /deliveryservices/{{id}}/capacity to Go URL: https://github.com/apache/trafficcontrol/issues/3788 This is an automated message from the Apache Git Service. To respond to the message,

[GitHub] [trafficcontrol] asf-ci commented on issue #3996: Rewrote /user/current to Go

asf-ci commented on issue #3996: Rewrote /user/current to Go URL: https://github.com/apache/trafficcontrol/pull/3996#issuecomment-566727795 Refer to this link for build results (access rights to CI server needed): https://builds.apache.org/job/trafficcontrol-PR/4949/

[GitHub] [trafficcontrol] mitchell852 commented on issue #4219: TO API allows creation of a profile with spaces

mitchell852 commented on issue #4219: TO API allows creation of a profile with spaces URL: https://github.com/apache/trafficcontrol/issues/4219#issuecomment-566753998 in practice, i've never seen profile names with spaces.but not really sure if it would hurt or not.

Build failed in Jenkins: trafficcontrol-PR #4950

See Changes: [ocket] Rewrote /federation_resolvers - POST [ocket] Rewrote /federation_resolvers - GET [ocket] fix queries [ocket] Fixed query again [ocket] Added Go client methods

[GitHub] [trafficcontrol] asf-ci commented on issue #4105: Rewrite /federation_resolvers/{{ID}} to Go

asf-ci commented on issue #4105: Rewrite /federation_resolvers/{{ID}} to Go URL: https://github.com/apache/trafficcontrol/pull/4105#issuecomment-566759848 Refer to this link for build results (access rights to CI server needed): https://builds.apache.org/job/trafficcontrol-PR/4950/

[GitHub] [trafficcontrol] asf-ci commented on issue #4105: Rewrite /federation_resolvers/{{ID}} to Go

asf-ci commented on issue #4105: Rewrite /federation_resolvers/{{ID}} to Go URL: https://github.com/apache/trafficcontrol/pull/4105#issuecomment-566767641 Refer to this link for build results (access rights to CI server needed): https://builds.apache.org/job/trafficcontrol-PR/4953/

Build failed in Jenkins: trafficcontrol-traffic_ops-test #1712

See Changes: [mitchell852] Add TO Go deliveryservices/id/capacity (#2459) -- Started by an SCM change Running as SYSTEM [EnvInject] - Loading node

Build failed in Jenkins: trafficcontrol-PR #4953

See Changes: [mitchell852] Add Go implementation of POST servers/{id}/queue_update (#4181) [mitchell852] Add TO Go cdns/health, cdns/name/health (#2305) [rawlin_peters] Fix TO to remove proxy route for Go

Jenkins build is back to normal : trafficcontrol-PR #4949

See

[GitHub] [trafficcontrol] ocket8888 commented on issue #4219: TO API allows creation of a profile with spaces

ocket commented on issue #4219: TO API allows creation of a profile with spaces URL: https://github.com/apache/trafficcontrol/issues/4219#issuecomment-566748671 Why do you expect that a profile name cannot contain spaces?

[GitHub] [trafficcontrol] ocket8888 commented on issue #4219: TO API allows creation of a profile with spaces

ocket commented on issue #4219: TO API allows creation of a profile with spaces URL: https://github.com/apache/trafficcontrol/issues/4219#issuecomment-566752517 Oh, well then is the bug in TO or TP? Are Profile names supposed to contain spaces? Is there a production environment that

[GitHub] [trafficcontrol] ocket8888 commented on a change in pull request #4105: Rewrite /federation_resolvers/{{ID}} to Go

ocket commented on a change in pull request #4105: Rewrite /federation_resolvers/{{ID}} to Go URL: https://github.com/apache/trafficcontrol/pull/4105#discussion_r359044439 ## File path: traffic_ops/traffic_ops_golang/federation_resolvers/federation_resolvers.go ## @@

Jenkins build is back to normal : trafficcontrol-PR #4952

See

[GitHub] [trafficcontrol] ocket8888 commented on a change in pull request #4105: Rewrite /federation_resolvers/{{ID}} to Go

ocket commented on a change in pull request #4105: Rewrite /federation_resolvers/{{ID}} to Go URL: https://github.com/apache/trafficcontrol/pull/4105#discussion_r359049576 ## File path: traffic_ops/traffic_ops_golang/federation_resolvers/federation_resolvers.go ## @@

[GitHub] [trafficcontrol] asf-ci commented on issue #4199: TP: bug fixes on the any map form

asf-ci commented on issue #4199: TP: bug fixes on the any map form URL: https://github.com/apache/trafficcontrol/pull/4199#issuecomment-566766413 Refer to this link for build results (access rights to CI server needed): https://builds.apache.org/job/trafficcontrol-PR/4952/

Build failed in Jenkins: trafficcontrol-PR #4954

See Changes: [ocket] Added GoDocs -- [...truncated 2.65 MB...] traffic_portal_build_1 | | | `-- uri-js@4.2.2 traffic_portal_build_1 |

[GitHub] [trafficcontrol] asf-ci commented on issue #4105: Rewrite /federation_resolvers/{{ID}} to Go

asf-ci commented on issue #4105: Rewrite /federation_resolvers/{{ID}} to Go URL: https://github.com/apache/trafficcontrol/pull/4105#issuecomment-566772110 Refer to this link for build results (access rights to CI server needed): https://builds.apache.org/job/trafficcontrol-PR/4954/

Build failed in Jenkins: trafficcontrol-PR #4955

See Changes: [ocket] More appropriate API version checks -- [...truncated 2.84 MB...] traffic_portal_build_1 | | | +-- json-schema-traverse@0.4.1

[GitHub] [trafficcontrol] asf-ci commented on issue #4105: Rewrite /federation_resolvers/{{ID}} to Go

asf-ci commented on issue #4105: Rewrite /federation_resolvers/{{ID}} to Go URL: https://github.com/apache/trafficcontrol/pull/4105#issuecomment-566773282 Refer to this link for build results (access rights to CI server needed): https://builds.apache.org/job/trafficcontrol-PR/4955/

[GitHub] [trafficcontrol] ocket8888 closed issue #4102: TP: Delivery Service URLs section shouldn't be displayed for ANY_MAP DS type

ocket closed issue #4102: TP: Delivery Service URLs section shouldn't be displayed for ANY_MAP DS type URL: https://github.com/apache/trafficcontrol/issues/4102 This is an automated message from the Apache Git Service.

[GitHub] [trafficcontrol] ocket8888 closed issue #2426: Revalidate builds invalid regexes on ANY_MAP Delivery Services

ocket closed issue #2426: Revalidate builds invalid regexes on ANY_MAP Delivery Services URL: https://github.com/apache/trafficcontrol/issues/2426 This is an automated message from the Apache Git Service. To respond to

[GitHub] [trafficcontrol] ocket8888 closed issue #4201: TP: Remove "Manage Regexes" and "Manage Static DNS Entries" from ANY_MAP DS form

ocket closed issue #4201: TP: Remove "Manage Regexes" and "Manage Static DNS Entries" from ANY_MAP DS form URL: https://github.com/apache/trafficcontrol/issues/4201 This is an automated message from the Apache Git

[GitHub] [trafficcontrol] ocket8888 merged pull request #4199: TP: bug fixes on the any map form

ocket merged pull request #4199: TP: bug fixes on the any map form URL: https://github.com/apache/trafficcontrol/pull/4199 This is an automated message from the Apache Git Service. To respond to the message, please log

[GitHub] [trafficcontrol] ocket8888 closed issue #1943: Traffic Portal ANY_MAP Delivery Service form contains Traffic Router configurations

ocket closed issue #1943: Traffic Portal ANY_MAP Delivery Service form contains Traffic Router configurations URL: https://github.com/apache/trafficcontrol/issues/1943 This is an automated message from the Apache Git

Build failed in Jenkins: trafficcontrol-traffic_ops-test #1713

See Changes: [ocket] TP: bug fixes on the any map form (#4199) -- Started by an SCM change Running as SYSTEM [EnvInject] - Loading node environment

Build failed in Jenkins: trafficcontrol-PR #4956

See Changes: [ocket] go fmt -- [...truncated 2.84 MB...] traffic_portal_build_1 | +-- form-data@2.3.3 traffic_portal_build_1 | | `--

[GitHub] [trafficcontrol] asf-ci commented on issue #4105: Rewrite /federation_resolvers/{{ID}} to Go

asf-ci commented on issue #4105: Rewrite /federation_resolvers/{{ID}} to Go URL: https://github.com/apache/trafficcontrol/pull/4105#issuecomment-566778207 Refer to this link for build results (access rights to CI server needed): https://builds.apache.org/job/trafficcontrol-PR/4956/

Build failed in Jenkins: trafficcontrol-PR #4957

See Changes: [mitchell852] Add TO Go deliveryservices/id/capacity (#2459) [ocket] TP: bug fixes on the any map form (#4199) [ocket] Rewrote capabilities endpoints to GO [ocket] Fixed incorrect

[GitHub] [trafficcontrol] asf-ci commented on issue #3870: Rewrite /capabilities to Go

asf-ci commented on issue #3870: Rewrite /capabilities to Go URL: https://github.com/apache/trafficcontrol/pull/3870#issuecomment-566786324 Refer to this link for build results (access rights to CI server needed): https://builds.apache.org/job/trafficcontrol-PR/4957/

[GitHub] [trafficcontrol] ocket8888 commented on issue #4211: Incorrect error response for /users/register when tenantId doesn't exist

ocket commented on issue #4211: Incorrect error response for /users/register when tenantId doesn't exist URL: https://github.com/apache/trafficcontrol/issues/4211#issuecomment-566872054 I wrestled a lot with how to label this. Since there's no authoritative source on what behavior