Jenkins build is back to normal : trafficcontrol-PR #5296

2020-02-12 Thread Apache Jenkins Server
See

[GitHub] [trafficcontrol] mattjackson220 commented on a change in pull request #4356: Update generic API Create to allow arrays in POST if set on object

2020-02-12 Thread GitBox
mattjackson220 commented on a change in pull request #4356: Update generic API Create to allow arrays in POST if set on object URL: https://github.com/apache/trafficcontrol/pull/4356#discussion_r378307498 ## File path: traffic_ops/traffic_ops_golang/api/shared_handlers.go

[GitHub] [trafficcontrol] mhoppa commented on a change in pull request #4378: updated API to version 2.x

2020-02-12 Thread GitBox
mhoppa commented on a change in pull request #4378: updated API to version 2.x URL: https://github.com/apache/trafficcontrol/pull/4378#discussion_r378314059 ## File path: traffic_ops/traffic_ops_golang/routing/routes.go ## @@ -722,6 +1118,13 @@ func notImplementedHandler(w

[GitHub] [trafficcontrol] mhoppa commented on a change in pull request #4378: updated API to version 2.x

2020-02-12 Thread GitBox
mhoppa commented on a change in pull request #4378: updated API to version 2.x URL: https://github.com/apache/trafficcontrol/pull/4378#discussion_r378306800 ## File path: traffic_ops/traffic_ops_golang/routing/routes.go ## @@ -133,477 +134,872 @@ func Routes(d ServerData)

[GitHub] [trafficcontrol] mhoppa commented on a change in pull request #4378: updated API to version 2.x

2020-02-12 Thread GitBox
mhoppa commented on a change in pull request #4378: updated API to version 2.x URL: https://github.com/apache/trafficcontrol/pull/4378#discussion_r378310322 ## File path: traffic_ops/traffic_ops_golang/routing/routes.go ## @@ -133,477 +134,872 @@ func Routes(d ServerData)

[GitHub] [trafficcontrol] mattjackson220 commented on a change in pull request #4356: Update generic API Create to allow arrays in POST if set on object

2020-02-12 Thread GitBox
mattjackson220 commented on a change in pull request #4356: Update generic API Create to allow arrays in POST if set on object URL: https://github.com/apache/trafficcontrol/pull/4356#discussion_r378310259 ## File path:

Build failed in Jenkins: trafficcontrol-PR #5298

2020-02-12 Thread Apache Jenkins Server
See Changes: -- [...truncated 3.01 MB...] unit_1 | === RUN TestInterfaces unit_1 | --- PASS: TestInterfaces (0.00s) unit_1 | === RUN TestValidate

[GitHub] [trafficcontrol] mattjackson220 commented on a change in pull request #4356: Update generic API Create to allow arrays in POST if set on object

2020-02-12 Thread GitBox
mattjackson220 commented on a change in pull request #4356: Update generic API Create to allow arrays in POST if set on object URL: https://github.com/apache/trafficcontrol/pull/4356#discussion_r378308425 ## File path: traffic_ops/traffic_ops_golang/api/shared_interfaces.go

[GitHub] [trafficcontrol] mitchell852 opened a new pull request #4394: TP: adds configurability (show/hide columns) to the parameters and users tables

2020-02-12 Thread GitBox
mitchell852 opened a new pull request #4394: TP: adds configurability (show/hide columns) to the parameters and users tables URL: https://github.com/apache/trafficcontrol/pull/4394 ## What does this PR (Pull Request) do? - [x] This PR is not related to any Issue ## Which

[GitHub] [trafficcontrol] mattjackson220 commented on a change in pull request #4378: updated API to version 2.x

2020-02-12 Thread GitBox
mattjackson220 commented on a change in pull request #4378: updated API to version 2.x URL: https://github.com/apache/trafficcontrol/pull/4378#discussion_r378358422 ## File path: traffic_ops/traffic_ops_golang/routing/routes.go ## @@ -133,477 +134,872 @@ func Routes(d

Jenkins build is back to normal : trafficcontrol-PR #5299

2020-02-12 Thread Apache Jenkins Server
See

[GitHub] [trafficcontrol] mhoppa commented on a change in pull request #4378: updated API to version 2.x

2020-02-12 Thread GitBox
mhoppa commented on a change in pull request #4378: updated API to version 2.x URL: https://github.com/apache/trafficcontrol/pull/4378#discussion_r378314059 ## File path: traffic_ops/traffic_ops_golang/routing/routes.go ## @@ -722,6 +1118,13 @@ func notImplementedHandler(w

[GitHub] [trafficcontrol] mattjackson220 commented on a change in pull request #4378: updated API to version 2.x

2020-02-12 Thread GitBox
mattjackson220 commented on a change in pull request #4378: updated API to version 2.x URL: https://github.com/apache/trafficcontrol/pull/4378#discussion_r378358160 ## File path: traffic_ops/traffic_ops_golang/routing/routes.go ## @@ -133,477 +134,872 @@ func Routes(d

[GitHub] [trafficcontrol] mhoppa commented on a change in pull request #4378: updated API to version 2.x

2020-02-12 Thread GitBox
mhoppa commented on a change in pull request #4378: updated API to version 2.x URL: https://github.com/apache/trafficcontrol/pull/4378#discussion_r378306889 ## File path: traffic_ops/traffic_ops_golang/routing/routes.go ## @@ -133,477 +134,872 @@ func Routes(d ServerData)

[GitHub] [trafficcontrol] ocket8888 commented on a change in pull request #3534: TP Delivery Service Generate SSL update, new letsencrypt generate and renew API endpoints

2020-02-12 Thread GitBox
ocket commented on a change in pull request #3534: TP Delivery Service Generate SSL update, new letsencrypt generate and renew API endpoints URL: https://github.com/apache/trafficcontrol/pull/3534#discussion_r378334362 ## File path:

[GitHub] [trafficcontrol] ocket8888 commented on a change in pull request #3534: TP Delivery Service Generate SSL update, new letsencrypt generate and renew API endpoints

2020-02-12 Thread GitBox
ocket commented on a change in pull request #3534: TP Delivery Service Generate SSL update, new letsencrypt generate and renew API endpoints URL: https://github.com/apache/trafficcontrol/pull/3534#discussion_r378311847 ## File path:

[GitHub] [trafficcontrol] ocket8888 commented on a change in pull request #3534: TP Delivery Service Generate SSL update, new letsencrypt generate and renew API endpoints

2020-02-12 Thread GitBox
ocket commented on a change in pull request #3534: TP Delivery Service Generate SSL update, new letsencrypt generate and renew API endpoints URL: https://github.com/apache/trafficcontrol/pull/3534#discussion_r378299333 ## File path: docs/source/admin/traffic_ops.rst ##

[GitHub] [trafficcontrol] ocket8888 commented on a change in pull request #3534: TP Delivery Service Generate SSL update, new letsencrypt generate and renew API endpoints

2020-02-12 Thread GitBox
ocket commented on a change in pull request #3534: TP Delivery Service Generate SSL update, new letsencrypt generate and renew API endpoints URL: https://github.com/apache/trafficcontrol/pull/3534#discussion_r378330704 ## File path:

[GitHub] [trafficcontrol] ocket8888 commented on a change in pull request #3534: TP Delivery Service Generate SSL update, new letsencrypt generate and renew API endpoints

2020-02-12 Thread GitBox
ocket commented on a change in pull request #3534: TP Delivery Service Generate SSL update, new letsencrypt generate and renew API endpoints URL: https://github.com/apache/trafficcontrol/pull/3534#discussion_r378311239 ## File path:

[GitHub] [trafficcontrol] ocket8888 commented on a change in pull request #3534: TP Delivery Service Generate SSL update, new letsencrypt generate and renew API endpoints

2020-02-12 Thread GitBox
ocket commented on a change in pull request #3534: TP Delivery Service Generate SSL update, new letsencrypt generate and renew API endpoints URL: https://github.com/apache/trafficcontrol/pull/3534#discussion_r378328568 ## File path: docs/source/api/letsencrypt_autorenew.rst

[GitHub] [trafficcontrol] ocket8888 commented on a change in pull request #3534: TP Delivery Service Generate SSL update, new letsencrypt generate and renew API endpoints

2020-02-12 Thread GitBox
ocket commented on a change in pull request #3534: TP Delivery Service Generate SSL update, new letsencrypt generate and renew API endpoints URL: https://github.com/apache/trafficcontrol/pull/3534#discussion_r37826 ## File path:

[GitHub] [trafficcontrol] ocket8888 commented on a change in pull request #3534: TP Delivery Service Generate SSL update, new letsencrypt generate and renew API endpoints

2020-02-12 Thread GitBox
ocket commented on a change in pull request #3534: TP Delivery Service Generate SSL update, new letsencrypt generate and renew API endpoints URL: https://github.com/apache/trafficcontrol/pull/3534#discussion_r378331013 ## File path:

[GitHub] [trafficcontrol] ocket8888 opened a new issue #4393: DS SSL keys routes return empty 'response' objects on error

2020-02-12 Thread GitBox
ocket opened a new issue #4393: DS SSL keys routes return empty 'response' objects on error URL: https://github.com/apache/trafficcontrol/issues/4393 ## I'm submitting a ... - bug report - improvement request (usability, performance, tech debt, etc.) (not sure which this

[GitHub] [trafficcontrol] mattjackson220 commented on a change in pull request #4378: updated API to version 2.x

2020-02-12 Thread GitBox
mattjackson220 commented on a change in pull request #4378: updated API to version 2.x URL: https://github.com/apache/trafficcontrol/pull/4378#discussion_r378358763 ## File path: traffic_ops/traffic_ops_golang/routing/routes.go ## @@ -133,477 +134,872 @@ func Routes(d

[GitHub] [trafficcontrol] zrhoffman commented on a change in pull request #4356: Update generic API Create to allow arrays in POST if set on object

2020-02-12 Thread GitBox
zrhoffman commented on a change in pull request #4356: Update generic API Create to allow arrays in POST if set on object URL: https://github.com/apache/trafficcontrol/pull/4356#discussion_r378389643 ## File path: traffic_ops/testing/api/v1/parameters_test.go ## @@ -45,6

[GitHub] [trafficcontrol] mattjackson220 commented on a change in pull request #3534: TP Delivery Service Generate SSL update, new letsencrypt generate and renew API endpoints

2020-02-12 Thread GitBox
mattjackson220 commented on a change in pull request #3534: TP Delivery Service Generate SSL update, new letsencrypt generate and renew API endpoints URL: https://github.com/apache/trafficcontrol/pull/3534#discussion_r378395975 ## File path:

Build failed in Jenkins: trafficcontrol-traffic_ops-test #1831

2020-02-12 Thread Apache Jenkins Server
See Changes: [github] updated API to version 2.x (#4378) -- [...truncated 61.33 KB...] unit_golang_1 | PASS unit_golang_1 | coverage:

[GitHub] [trafficcontrol] mhoppa commented on issue #4371: API 2.0 documentation

2020-02-12 Thread GitBox
mhoppa commented on issue #4371: API 2.0 documentation URL: https://github.com/apache/trafficcontrol/pull/4371#issuecomment-585368172 Nothing blocking this merge since 2.0 is now cut. So once reviewed  This is an automated

Build failed in Jenkins: trafficcontrol-PR #5301

2020-02-12 Thread Apache Jenkins Server
See Changes: [matthew_jackson] TP Delivery Service Generate SSL update, new letsencrypt generate and [matthew_jackson] Added API for dns challenges and setup DNS Challenge calls to LE [matthew_jackson] DNS

Jenkins build is back to normal : trafficcontrol-PR #5302

2020-02-12 Thread Apache Jenkins Server
See

[GitHub] [trafficcontrol] ZugNZwang opened a new issue #4395: deliveryservice_requests Internal Server Error when status and changeType are wrong

2020-02-12 Thread GitBox
ZugNZwang opened a new issue #4395: deliveryservice_requests Internal Server Error when status and changeType are wrong URL: https://github.com/apache/trafficcontrol/issues/4395 ## I'm submitting a ... - [X] bug report - [ ] new feature / enhancement request

[GitHub] [trafficcontrol] zrhoffman commented on issue #4356: Update generic API Create to allow arrays in POST if set on object

2020-02-12 Thread GitBox
zrhoffman commented on issue #4356: Update generic API Create to allow arrays in POST if set on object URL: https://github.com/apache/trafficcontrol/pull/4356#issuecomment-585367898 - docs build without warnings - `go fmt` comes up clean - unit tests pass - API tests pass

[GitHub] [trafficcontrol] mattjackson220 commented on a change in pull request #3534: TP Delivery Service Generate SSL update, new letsencrypt generate and renew API endpoints

2020-02-12 Thread GitBox
mattjackson220 commented on a change in pull request #3534: TP Delivery Service Generate SSL update, new letsencrypt generate and renew API endpoints URL: https://github.com/apache/trafficcontrol/pull/3534#discussion_r378389118 ## File path:

[GitHub] [trafficcontrol] mattjackson220 commented on a change in pull request #3534: TP Delivery Service Generate SSL update, new letsencrypt generate and renew API endpoints

2020-02-12 Thread GitBox
mattjackson220 commented on a change in pull request #3534: TP Delivery Service Generate SSL update, new letsencrypt generate and renew API endpoints URL: https://github.com/apache/trafficcontrol/pull/3534#discussion_r378389186 ## File path:

[GitHub] [trafficcontrol] ocket8888 merged pull request #4378: updated API to version 2.x

2020-02-12 Thread GitBox
ocket merged pull request #4378: updated API to version 2.x URL: https://github.com/apache/trafficcontrol/pull/4378 This is an automated message from the Apache Git Service. To respond to the message, please log on to

[GitHub] [trafficcontrol] zrhoffman edited a comment on issue #4391: Make pkg.ps1 compatible with PowerShell Core (OSS version)

2020-02-12 Thread GitBox
zrhoffman edited a comment on issue #4391: Make pkg.ps1 compatible with PowerShell Core (OSS version) URL: https://github.com/apache/trafficcontrol/pull/4391#issuecomment-585372885 Looking into it, Brennan found that the `.git` directory isn't copied to the temp build directory when the

[GitHub] [trafficcontrol] zrhoffman commented on issue #4391: Make pkg.ps1 compatible with PowerShell Core (OSS version)

2020-02-12 Thread GitBox
zrhoffman commented on issue #4391: Make pkg.ps1 compatible with PowerShell Core (OSS version) URL: https://github.com/apache/trafficcontrol/pull/4391#issuecomment-585372885 Looking into it, Brennan found that the `.git` directory isn't copied to the temp build directory when the rest of

[GitHub] [trafficcontrol] mattjackson220 commented on a change in pull request #3534: TP Delivery Service Generate SSL update, new letsencrypt generate and renew API endpoints

2020-02-12 Thread GitBox
mattjackson220 commented on a change in pull request #3534: TP Delivery Service Generate SSL update, new letsencrypt generate and renew API endpoints URL: https://github.com/apache/trafficcontrol/pull/3534#discussion_r378387988 ## File path: docs/source/admin/traffic_ops.rst

[GitHub] [trafficcontrol] mattjackson220 commented on a change in pull request #3534: TP Delivery Service Generate SSL update, new letsencrypt generate and renew API endpoints

2020-02-12 Thread GitBox
mattjackson220 commented on a change in pull request #3534: TP Delivery Service Generate SSL update, new letsencrypt generate and renew API endpoints URL: https://github.com/apache/trafficcontrol/pull/3534#discussion_r378388140 ## File path:

[GitHub] [trafficcontrol] mattjackson220 commented on a change in pull request #3534: TP Delivery Service Generate SSL update, new letsencrypt generate and renew API endpoints

2020-02-12 Thread GitBox
mattjackson220 commented on a change in pull request #3534: TP Delivery Service Generate SSL update, new letsencrypt generate and renew API endpoints URL: https://github.com/apache/trafficcontrol/pull/3534#discussion_r378388210 ## File path:

[GitHub] [trafficcontrol] mattjackson220 commented on a change in pull request #3534: TP Delivery Service Generate SSL update, new letsencrypt generate and renew API endpoints

2020-02-12 Thread GitBox
mattjackson220 commented on a change in pull request #3534: TP Delivery Service Generate SSL update, new letsencrypt generate and renew API endpoints URL: https://github.com/apache/trafficcontrol/pull/3534#discussion_r378388254 ## File path:

[GitHub] [trafficcontrol] mattjackson220 commented on a change in pull request #3534: TP Delivery Service Generate SSL update, new letsencrypt generate and renew API endpoints

2020-02-12 Thread GitBox
mattjackson220 commented on a change in pull request #3534: TP Delivery Service Generate SSL update, new letsencrypt generate and renew API endpoints URL: https://github.com/apache/trafficcontrol/pull/3534#discussion_r378395423 ## File path:

[GitHub] [trafficcontrol] mattjackson220 commented on a change in pull request #4378: updated API to version 2.x

2020-02-12 Thread GitBox
mattjackson220 commented on a change in pull request #4378: updated API to version 2.x URL: https://github.com/apache/trafficcontrol/pull/4378#discussion_r378369086 ## File path: traffic_ops/traffic_ops_golang/routing/routes.go ## @@ -722,6 +1118,13 @@ func

[GitHub] [trafficcontrol] zrhoffman commented on a change in pull request #4356: Update generic API Create to allow arrays in POST if set on object

2020-02-12 Thread GitBox
zrhoffman commented on a change in pull request #4356: Update generic API Create to allow arrays in POST if set on object URL: https://github.com/apache/trafficcontrol/pull/4356#discussion_r378389643 ## File path: traffic_ops/testing/api/v1/parameters_test.go ## @@ -45,6

[GitHub] [trafficcontrol] mattjackson220 commented on a change in pull request #4356: Update generic API Create to allow arrays in POST if set on object

2020-02-12 Thread GitBox
mattjackson220 commented on a change in pull request #4356: Update generic API Create to allow arrays in POST if set on object URL: https://github.com/apache/trafficcontrol/pull/4356#discussion_r378412642 ## File path: traffic_ops/testing/api/v1/parameters_test.go ## @@

Build failed in Jenkins: trafficcontrol-PR #5306

2020-02-12 Thread Apache Jenkins Server
See Changes: -- GitHub pull request #4391 of commit 6d2b6fc18eb227f28ac0d781eea93828f6c22f51, no merge conflicts. Running as SYSTEM Setting status of

Jenkins build is back to normal : trafficcontrol-PR #5307

2020-02-12 Thread Apache Jenkins Server
See

[GitHub] [trafficcontrol] ocket8888 commented on issue #4396: WIP - Client upgrade

2020-02-12 Thread GitBox
ocket commented on issue #4396: WIP - Client upgrade URL: https://github.com/apache/trafficcontrol/pull/4396#issuecomment-585389090 This was supposed to be a draft... This is an automated message from the Apache Git

[GitHub] [trafficcontrol] ocket8888 opened a new pull request #4396: Client upgrade

2020-02-12 Thread GitBox
ocket opened a new pull request #4396: Client upgrade URL: https://github.com/apache/trafficcontrol/pull/4396 ## What does this PR (Pull Request) do? Updates clients of the Traffic Ops API to use version 2.0 - [x] This PR is not related to any Issue ## Which Traffic

Build failed in Jenkins: trafficcontrol-traffic_ops-test #1832

2020-02-12 Thread Apache Jenkins Server
See Changes: [github] Make pkg.ps1 compatible with PowerShell Core (OSS version) (#4391) -- [...truncated 61.52 KB...] unit_golang_1 | PASS

[GitHub] [trafficcontrol] ocket8888 merged pull request #4391: Make pkg.ps1 compatible with PowerShell Core (OSS version)

2020-02-12 Thread GitBox
ocket merged pull request #4391: Make pkg.ps1 compatible with PowerShell Core (OSS version) URL: https://github.com/apache/trafficcontrol/pull/4391 This is an automated message from the Apache Git Service. To respond to