[GitHub] asfgit commented on issue #2314: Remove deliveryservice.org_server_fqdn column/compute it from Origin table

2018-06-13 Thread GitBox
asfgit commented on issue #2314: Remove deliveryservice.org_server_fqdn column/compute it from Origin table URL: https://github.com/apache/trafficcontrol/pull/2314#issuecomment-397127532 Refer to this link for build results (access rights to CI server needed):

[GitHub] asfgit commented on issue #2411: Add Go DS API query parameter alias for xml_id -> xmlId

2018-06-13 Thread GitBox
asfgit commented on issue #2411: Add Go DS API query parameter alias for xml_id -> xmlId URL: https://github.com/apache/trafficcontrol/pull/2411#issuecomment-397118601 Refer to this link for build results (access rights to CI server needed):

[GitHub] dangogh closed pull request #2408: Refactored the API Tests to run in a Docker container

2018-06-13 Thread GitBox
dangogh closed pull request #2408: Refactored the API Tests to run in a Docker container URL: https://github.com/apache/trafficcontrol/pull/2408 This is a PR merged from a forked repository. As GitHub hides the original diff on merge, it is displayed below for the sake of provenance: As

[GitHub] rawlinp opened a new pull request #2411: Add Go DS API query parameter alias for xml_id -> xmlId

2018-06-13 Thread GitBox
rawlinp opened a new pull request #2411: Add Go DS API query parameter alias for xml_id -> xmlId URL: https://github.com/apache/trafficcontrol/pull/2411 The Perl version did not support this query parameter, but it probably should have because it's more intuitive to have it match the

[GitHub] rob05c closed pull request #2410: Fix go DS API query params for filtering/ordering

2018-06-13 Thread GitBox
rob05c closed pull request #2410: Fix go DS API query params for filtering/ordering URL: https://github.com/apache/trafficcontrol/pull/2410 This is a PR merged from a forked repository. As GitHub hides the original diff on merge, it is displayed below for the sake of provenance: As this

[GitHub] rawlinp opened a new pull request #2410: Fix go DS API query params for filtering/ordering

2018-06-13 Thread GitBox
rawlinp opened a new pull request #2410: Fix go DS API query params for filtering/ordering URL: https://github.com/apache/trafficcontrol/pull/2410 Add ability to filter by the same columns the Perl version allows filtering on. By default, order GET deliveryservices by xml_id if

[GitHub] rivasj commented on a change in pull request #2406: Re-added anonymous_blocking_enabled field to deliveryservice queries

2018-06-13 Thread GitBox
rivasj commented on a change in pull request #2406: Re-added anonymous_blocking_enabled field to deliveryservice queries URL: https://github.com/apache/trafficcontrol/pull/2406#discussion_r195246642 ## File path: lib/go-tc/deliveryservices.go ## @@ -58,59 +58,60 @@ type

[GitHub] mitchell852 commented on a change in pull request #2406: Re-added anonymous_blocking_enabled field to deliveryservice queries

2018-06-13 Thread GitBox
mitchell852 commented on a change in pull request #2406: Re-added anonymous_blocking_enabled field to deliveryservice queries URL: https://github.com/apache/trafficcontrol/pull/2406#discussion_r195243156 ## File path: lib/go-tc/deliveryservices.go ## @@ -58,59 +58,60 @@

[GitHub] dewrich commented on a change in pull request #2406: Re-added anonymous_blocking_enabled field to deliveryservice queries

2018-06-13 Thread GitBox
dewrich commented on a change in pull request #2406: Re-added anonymous_blocking_enabled field to deliveryservice queries URL: https://github.com/apache/trafficcontrol/pull/2406#discussion_r195241031 ## File path: traffic_ops/experimental/server/api/deliveryservices.go ##

[GitHub] asfgit commented on issue #2408: Refactored the API Tests to run in a Docker container

2018-06-13 Thread GitBox
asfgit commented on issue #2408: Refactored the API Tests to run in a Docker container URL: https://github.com/apache/trafficcontrol/pull/2408#issuecomment-397089096 Refer to this link for build results (access rights to CI server needed):

[GitHub] asfgit commented on issue #2314: Remove deliveryservice.org_server_fqdn column/compute it from Origin table

2018-06-13 Thread GitBox
asfgit commented on issue #2314: Remove deliveryservice.org_server_fqdn column/compute it from Origin table URL: https://github.com/apache/trafficcontrol/pull/2314#issuecomment-397087695 Refer to this link for build results (access rights to CI server needed):

[GitHub] dewrich opened a new pull request #2408: Refactored the API Tests to run in a container

2018-06-13 Thread GitBox
dewrich opened a new pull request #2408: Refactored the API Tests to run in a container URL: https://github.com/apache/trafficcontrol/pull/2408 These are now compatible with the cdn-in-a-box docker containers This is an

[GitHub] rob05c commented on a change in pull request #2406: Re-added anonymous_blocking_enabled field to deliveryservice queries

2018-06-13 Thread GitBox
rob05c commented on a change in pull request #2406: Re-added anonymous_blocking_enabled field to deliveryservice queries URL: https://github.com/apache/trafficcontrol/pull/2406#discussion_r195232902 ## File path: lib/go-tc/deliveryservices.go ## @@ -58,59 +58,60 @@ type

[GitHub] rob05c commented on a change in pull request #2406: Re-added anonymous_blocking_enabled field to deliveryservice queries

2018-06-13 Thread GitBox
rob05c commented on a change in pull request #2406: Re-added anonymous_blocking_enabled field to deliveryservice queries URL: https://github.com/apache/trafficcontrol/pull/2406#discussion_r195232902 ## File path: lib/go-tc/deliveryservices.go ## @@ -58,59 +58,60 @@ type

[GitHub] limited commented on a change in pull request #2406: Re-added anonymous_blocking_enabled field to deliveryservice queries

2018-06-13 Thread GitBox
limited commented on a change in pull request #2406: Re-added anonymous_blocking_enabled field to deliveryservice queries URL: https://github.com/apache/trafficcontrol/pull/2406#discussion_r195228980 ## File path: lib/go-tc/deliveryservices.go ## @@ -58,59 +58,60 @@ type

[GitHub] rob05c commented on a change in pull request #2406: Re-added anonymous_blocking_enabled field to deliveryservice queries

2018-06-13 Thread GitBox
rob05c commented on a change in pull request #2406: Re-added anonymous_blocking_enabled field to deliveryservice queries URL: https://github.com/apache/trafficcontrol/pull/2406#discussion_r195226665 ## File path: traffic_ops/experimental/server/api/deliveryservices.go ##

[GitHub] rawlinp commented on a change in pull request #2314: Remove deliveryservice.org_server_fqdn column/compute it from Origin table

2018-06-13 Thread GitBox
rawlinp commented on a change in pull request #2314: Remove deliveryservice.org_server_fqdn column/compute it from Origin table URL: https://github.com/apache/trafficcontrol/pull/2314#discussion_r195215795 ## File path:

[GitHub] rob05c commented on a change in pull request #2314: Remove deliveryservice.org_server_fqdn column/compute it from Origin table

2018-06-13 Thread GitBox
rob05c commented on a change in pull request #2314: Remove deliveryservice.org_server_fqdn column/compute it from Origin table URL: https://github.com/apache/trafficcontrol/pull/2314#discussion_r195205994 ## File path:

[GitHub] rob05c commented on a change in pull request #2314: Remove deliveryservice.org_server_fqdn column/compute it from Origin table

2018-06-13 Thread GitBox
rob05c commented on a change in pull request #2314: Remove deliveryservice.org_server_fqdn column/compute it from Origin table URL: https://github.com/apache/trafficcontrol/pull/2314#discussion_r195205994 ## File path:

[GitHub] Vijay-1 commented on issue #2407: Edge retrieval from origin - Configuring go_direct from traffic ops.

2018-06-13 Thread GitBox
Vijay-1 commented on issue #2407: Edge retrieval from origin - Configuring go_direct from traffic ops. URL: https://github.com/apache/trafficcontrol/pull/2407#issuecomment-397054098 **Rawlin's comment on DS-es sharing same origin** If there is a scenario where we need two different

[GitHub] asfgit commented on issue #2407: Edge retrieval from origin - Configuring go_direct from traffic ops.

2018-06-13 Thread GitBox
asfgit commented on issue #2407: Edge retrieval from origin - Configuring go_direct from traffic ops. URL: https://github.com/apache/trafficcontrol/pull/2407#issuecomment-397053454 Can one of the admins verify this patch?

[GitHub] dineshkumar82 opened a new pull request #2407: Edge retrieval from origin - Configuring go_direct from traffic ops.

2018-06-13 Thread GitBox
dineshkumar82 opened a new pull request #2407: Edge retrieval from origin - Configuring go_direct from traffic ops. URL: https://github.com/apache/trafficcontrol/pull/2407 All DS-es sharing an origin server should have same value for go_direct (or) No two Delivery service shares same

[GitHub] asfgit commented on issue #2401: Implement Origin UI in Traffic Portal

2018-06-13 Thread GitBox
asfgit commented on issue #2401: Implement Origin UI in Traffic Portal URL: https://github.com/apache/trafficcontrol/pull/2401#issuecomment-397051464 Refer to this link for build results (access rights to CI server needed):

[GitHub] rawlinp commented on a change in pull request #2314: Remove deliveryservice.org_server_fqdn column/compute it from Origin table

2018-06-13 Thread GitBox
rawlinp commented on a change in pull request #2314: Remove deliveryservice.org_server_fqdn column/compute it from Origin table URL: https://github.com/apache/trafficcontrol/pull/2314#discussion_r195185045 ## File path:

[GitHub] rob05c commented on a change in pull request #2314: Remove deliveryservice.org_server_fqdn column/compute it from Origin table

2018-06-13 Thread GitBox
rob05c commented on a change in pull request #2314: Remove deliveryservice.org_server_fqdn column/compute it from Origin table URL: https://github.com/apache/trafficcontrol/pull/2314#discussion_r195180097 ## File path:

[GitHub] mitchell852 commented on issue #2397: TP - empty value field for parameter not accepted

2018-06-13 Thread GitBox
mitchell852 commented on issue #2397: TP - empty value field for parameter not accepted URL: https://github.com/apache/trafficcontrol/issues/2397#issuecomment-397016213 To achieve this in TP: 1. remove the API validation on "Value:

[GitHub] asfgit commented on issue #2406: Re-added anonymous_blocking_enabled field to deliveryservice queries

2018-06-13 Thread GitBox
asfgit commented on issue #2406: Re-added anonymous_blocking_enabled field to deliveryservice queries URL: https://github.com/apache/trafficcontrol/pull/2406#issuecomment-397014647 Can one of the admins verify this patch?

[GitHub] rivasj opened a new pull request #2406: Re-added anonymous_blocking_enabled field to deliveryservice queries

2018-06-13 Thread GitBox
rivasj opened a new pull request #2406: Re-added anonymous_blocking_enabled field to deliveryservice queries URL: https://github.com/apache/trafficcontrol/pull/2406 Re-added anonymous_blocking_enabled field to deliveryservice queries after deliveryservice endpoints implemented in go

[GitHub] Vijay-1 commented on issue #2029: [Issue 1907] TO API for backup edge cachegroup

2018-06-13 Thread GitBox
Vijay-1 commented on issue #2029: [Issue 1907] TO API for backup edge cachegroup URL: https://github.com/apache/trafficcontrol/pull/2029#issuecomment-397005255 Yes. The changes requested for edgeLocations.go for CRConfig were addressed.

[GitHub] asfgit commented on issue #2386: Fix TO Go DS POST to 400 on duplicate, not 5xx

2018-06-13 Thread GitBox
asfgit commented on issue #2386: Fix TO Go DS POST to 400 on duplicate, not 5xx URL: https://github.com/apache/incubator-trafficcontrol/pull/2386#issuecomment-396986742 Refer to this link for build results (access rights to CI server needed):

[GitHub] asfgit commented on issue #2392: Fix Traffic Ops Delivery Service endpoints for anymap

2018-06-13 Thread GitBox
asfgit commented on issue #2392: Fix Traffic Ops Delivery Service endpoints for anymap URL: https://github.com/apache/incubator-trafficcontrol/pull/2392#issuecomment-396984910 Refer to this link for build results (access rights to CI server needed):

[GitHub] asfgit commented on issue #2395: To go ds sslkeys generate

2018-06-13 Thread GitBox
asfgit commented on issue #2395: To go ds sslkeys generate URL: https://github.com/apache/incubator-trafficcontrol/pull/2395#issuecomment-396983071 Refer to this link for build results (access rights to CI server needed):

[GitHub] asfgit commented on issue #2400: To go cdns sslkeys

2018-06-13 Thread GitBox
asfgit commented on issue #2400: To go cdns sslkeys URL: https://github.com/apache/incubator-trafficcontrol/pull/2400#issuecomment-396981356 Refer to this link for build results (access rights to CI server needed): https://builds.apache.org/job/incubator-trafficcontrol-PR/1808/

[GitHub] asfgit commented on issue #2402: To go riak ping

2018-06-13 Thread GitBox
asfgit commented on issue #2402: To go riak ping URL: https://github.com/apache/incubator-trafficcontrol/pull/2402#issuecomment-396979699 Refer to this link for build results (access rights to CI server needed): https://builds.apache.org/job/incubator-trafficcontrol-PR/1807/

[GitHub] asfgit commented on issue #2405: Add Traffic Ops Golang user/current

2018-06-13 Thread GitBox
asfgit commented on issue #2405: Add Traffic Ops Golang user/current URL: https://github.com/apache/incubator-trafficcontrol/pull/2405#issuecomment-396975459 Refer to this link for build results (access rights to CI server needed):

[GitHub] asfgit commented on issue #2338: Add TO Go users

2018-06-13 Thread GitBox
asfgit commented on issue #2338: Add TO Go users URL: https://github.com/apache/incubator-trafficcontrol/pull/2338#issuecomment-396972562 Refer to this link for build results (access rights to CI server needed): https://builds.apache.org/job/incubator-trafficcontrol-PR/1805/

[GitHub] asfgit commented on issue #2339: Add TO Go users/id/deliveryservices

2018-06-13 Thread GitBox
asfgit commented on issue #2339: Add TO Go users/id/deliveryservices URL: https://github.com/apache/incubator-trafficcontrol/pull/2339#issuecomment-396970817 Refer to this link for build results (access rights to CI server needed):

[GitHub] asfgit commented on issue #2353: Add TO Go regions/name

2018-06-13 Thread GitBox
asfgit commented on issue #2353: Add TO Go regions/name URL: https://github.com/apache/incubator-trafficcontrol/pull/2353#issuecomment-396968862 Refer to this link for build results (access rights to CI server needed): https://builds.apache.org/job/incubator-trafficcontrol-PR/1803/

[GitHub] asfgit commented on issue #2356: Add TO Go Logs

2018-06-13 Thread GitBox
asfgit commented on issue #2356: Add TO Go Logs URL: https://github.com/apache/incubator-trafficcontrol/pull/2356#issuecomment-396961681 Refer to this link for build results (access rights to CI server needed): https://builds.apache.org/job/incubator-trafficcontrol-PR/1802/ Test

[GitHub] asfgit commented on issue #2369: To go deletednsseckeys

2018-06-13 Thread GitBox
asfgit commented on issue #2369: To go deletednsseckeys URL: https://github.com/apache/incubator-trafficcontrol/pull/2369#issuecomment-396960296 Refer to this link for build results (access rights to CI server needed): https://builds.apache.org/job/incubator-trafficcontrol-PR/1801/

[GitHub] asfgit commented on issue #2382: To go dnsseckeys generate

2018-06-13 Thread GitBox
asfgit commented on issue #2382: To go dnsseckeys generate URL: https://github.com/apache/incubator-trafficcontrol/pull/2382#issuecomment-396958436 Refer to this link for build results (access rights to CI server needed):

[GitHub] dewrich closed pull request #2404: TO Go DS API: initialDispersion not required for DNS DSes

2018-06-13 Thread GitBox
dewrich closed pull request #2404: TO Go DS API: initialDispersion not required for DNS DSes URL: https://github.com/apache/incubator-trafficcontrol/pull/2404 This is a PR merged from a forked repository. As GitHub hides the original diff on merge, it is displayed below for the sake of