[GitHub] Shihta commented on issue #3126: Removed unnecessary http-parser dependency

[GitBox]

Shihta commented on issue #3126: Removed unnecessary http-parser dependency
URL: https://github.com/apache/trafficcontrol/pull/3126#issuecomment-447700596
 
 
   The commit seems caused CIAB error.
   Maybe CIAB needs more dependencies settings if you remove this package.
   I suggest to revert this patch.


This is an automated message from the Apache Git Service.
To respond to the message, please log on GitHub and use the
URL above to go to the specific comment.
 
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org


With regards,
Apache Git Services

[GitHub] ocket8888 commented on issue #3126: Removed unnecessary http-parser dependency

[GitBox]

ocket commented on issue #3126: Removed unnecessary http-parser dependency
URL: https://github.com/apache/trafficcontrol/pull/3126#issuecomment-447852819
 
 
   I tested this by running Traffic Portal in CDN-in-a-Box - can you explain 
why you think it broke?


This is an automated message from the Apache Git Service.
To respond to the message, please log on GitHub and use the
URL above to go to the specific comment.
 
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org


With regards,
Apache Git Services

[GitHub] ocket8888 closed pull request #2789: Added missing 'cronie' dependency

[GitBox]

ocket closed pull request #2789: Added missing 'cronie' dependency
URL: https://github.com/apache/trafficcontrol/pull/2789
 
 
   

This is a PR merged from a forked repository.
As GitHub hides the original diff on merge, it is displayed below for
the sake of provenance:

As this is a foreign pull request (from a fork), the diff is supplied
below (as it won't show otherwise due to GitHub magic):

diff --git a/traffic_ops/build/traffic_ops.spec 
b/traffic_ops/build/traffic_ops.spec
index b47251e89..6b974d4f2 100644
--- a/traffic_ops/build/traffic_ops.spec
+++ b/traffic_ops/build/traffic_ops.spec
@@ -33,7 +33,7 @@ URL:  https://github.com/apache/trafficcontrol/
 Vendor:   Apache Software Foundation
 Packager: daniel_kirkwood at Cable dot Comcast dot com
 AutoReqProv:  no
-Requires: cpanminus, expat-devel, gcc-c++, golang = 1.9.4, libcurl, 
libpcap-devel, mkisofs, tar
+Requires: cpanminus, expat-devel, gcc-c++, golang = 1.9.4, libcurl, 
libpcap-devel, mkisofs, tar, cronie
 Requires: openssl-devel, perl, perl-core, perl-DBD-Pg, perl-DBI, 
perl-Digest-SHA1
 Requires: libidn-devel, libcurl-devel, libcap
 Requires: postgresql96 >= 9.6.2 , postgresql96-devel >= 9.6.2
@@ -62,7 +62,7 @@ Built: %(date) by %{getenv: USER}
 echo "GOPATH: $GOPATH"
 go version
 go env
-
+
 # Create build area with proper gopath structure
 mkdir -p src pkg bin || { echo "Could not create directories in $(pwd): 
$!"; exit 1; }
 
@@ -91,11 +91,11 @@ Built: %(date) by %{getenv: USER}
 }
 oldpwd=$(pwd)
 #copy in traffic_ops/vendor
-vendordir=src/github.com/apache/trafficcontrol/traffic_ops/vendor 
+vendordir=src/github.com/apache/trafficcontrol/traffic_ops/vendor
 ( mkdir -p "$vendordir" && \
   cd "$vendordir" && \
   cp -r "$TC_DIR"/traffic_ops/vendor/* . \
-) || { echo "could not copy traffic_ops/vendor directory"; exit 1; } 
+) || { echo "could not copy traffic_ops/vendor directory"; exit 1; }
 
 # build traffic_ops_golang binary
 godir=src/github.com/apache/trafficcontrol/traffic_ops/traffic_ops_golang
@@ -190,7 +190,7 @@ Built: %(date) by %{getenv: USER}
 %__chmod +x /etc/init.d/traffic_ops
 %__chmod +x %{PACKAGEDIR}/install/bin/*
 /sbin/chkconfig --add traffic_ops
-   
+
 %__mkdir -p %{TRAFFIC_OPS_LOG_DIR}
 
 if [ -f /var/tmp/traffic_ops-backup.tar ]; then
@@ -230,7 +230,7 @@ if [ "$1" = "0" ]; then
# this is an uninstall
%__rm -rf %{PACKAGEDIR}
%__rm /etc/init.d/traffic_ops
-/usr/bin/getent passwd %{TRAFFIC_OPS_USER} || /usr/sbin/userdel 
%{TRAFFIC_OPS_USER} 
+/usr/bin/getent passwd %{TRAFFIC_OPS_USER} || /usr/sbin/userdel 
%{TRAFFIC_OPS_USER}
 /usr/bin/getent group %{TRAFFIC_OPS_GROUP} || /usr/sbin/groupdel 
%{TRAFFIC_OPS_GROUP}
 fi
 


 


This is an automated message from the Apache Git Service.
To respond to the message, please log on GitHub and use the
URL above to go to the specific comment.
 
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org


With regards,
Apache Git Services

[GitHub] dangogh commented on issue #3126: Removed unnecessary http-parser dependency

[GitBox]

dangogh commented on issue #3126: Removed unnecessary http-parser dependency
URL: https://github.com/apache/trafficcontrol/pull/3126#issuecomment-447905480
 
 
   @Shihta Please provide more detail -- what error did you see?


This is an automated message from the Apache Git Service.
To respond to the message, please log on GitHub and use the
URL above to go to the specific comment.
 
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org


With regards,
Apache Git Services

[GitHub] villajo commented on a change in pull request #3122: Pushing changes to Traffic Vault documentation to have instructions f…

[GitBox]

villajo commented on a change in pull request #3122: Pushing changes to Traffic 
Vault documentation to have instructions f…
URL: https://github.com/apache/trafficcontrol/pull/3122#discussion_r242221902
 
 

 ##
 File path: docs/source/admin/traffic_vault.rst
 ##
 @@ -29,6 +29,28 @@ Configuring Traffic Vault
 =
 The following steps were taken to configure Riak in our environments.
 
+
+Self Signed Certificate configuration
+-
+Below shows how to create self signed certs for Trafficvault.
+
+Note: Self Signed Certificates are not recommended for production use. 
Intended for dev or learning purposes only. Modify subject as necessary.   
+
+   ``cd ~``
+   ``mkdir certs``
+   ``cd certs``
+   ``openssl genrsa -out ca-bundle.key 2048``
+   ``openssl req -new -key ca-bundle.key -out ca-bundle.csr -subj 
"/C=US/ST=CO/L=DEN/O=somecompany/OU=CDN/CN=somecompany.net/emailAddress=someu...@somecompany.net"``
+   ``openssl x509 -req -days 365 -in ca-bundle.csr -signkey ca-bundle.key 
-out ca-bundle.crt``
+   ``openssl genrsa -out server.key 2048``
+   ``openssl req -new -key server.key -out server.csr -subj 
"/C=US/ST=CO/L=DEN/O=somecompany/OU=CDN/CN=somecompany.net/emailAddress=someu...@somecompany.net"``
+   ``openssl x509 -req -days 365 -in server.csr -CA ca-bundle.crt -CAkey 
ca-bundle.key -CAcreateserial -out server.crt``
+   ``mkdir /etc/riak/certs``
+   ``mv -f server.crt /etc/riak/certs/.``
+   ``mv -f server.key /etc/riak/certs/.``
+   ``mv -f ca-bundle.crt /etc/pki/tls/certs/.``
+
 
 Review comment:
   Certainly! I can do that.. 
   
   Would this be more of what we're looking for? 
   
   Self Signed Certificate configuration
   -
   
   note:: Self Signed Certificates are not recommended for production use. 
Intended for dev or learning purposes only. Modify subject as necessary.
   
   `Self Signed Certificate configuration
   -
   
   note:: Self Signed Certificates are not recommended for production use. 
Intended for dev or learning purposes only. Modify subject as necessary.
   
   code-block:: shell
   :caption: Self-Signed Certificate Configuration
   
   cd ~
   mkdir certs
   cd certs
   openssl genrsa -out ca-bundle.key 2048
   openssl req -new -key ca-bundle.key -out ca-bundle.csr -subj 
"/C=US/ST=CO/L=DEN/O=somecompany/OU=CDN/CN=somecompany.net/emailAddress=someu...@somecompany.net"
   openssl x509 -req -days 365 -in ca-bundle.csr -signkey ca-bundle.key 
-out ca-bundle.crt
   openssl genrsa -out server.key 2048
   openssl req -new -key server.key -out server.csr -subj 
"/C=US/ST=CO/L=DEN/O=somecompany/OU=CDN/CN=somecompany.net/emailAddress=someu...@somecompany.net"
   openssl x509 -req -days 365 -in server.csr -CA ca-bundle.crt -CAkey 
ca-bundle.key -CAcreateserial -out server.crt
   mkdir /etc/riak/certs
   mv -f server.crt /etc/riak/certs/.
   mv -f server.key /etc/riak/certs/.
   mv -f ca-bundle.crt /etc/pki/tls/certs/.
   `


This is an automated message from the Apache Git Service.
To respond to the message, please log on GitHub and use the
URL above to go to the specific comment.
 
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org


With regards,
Apache Git Services

[GitHub] villajo commented on a change in pull request #3122: Pushing changes to Traffic Vault documentation to have instructions f…

[GitBox]

villajo commented on a change in pull request #3122: Pushing changes to Traffic 
Vault documentation to have instructions f…
URL: https://github.com/apache/trafficcontrol/pull/3122#discussion_r242221902
 
 

 ##
 File path: docs/source/admin/traffic_vault.rst
 ##
 @@ -29,6 +29,28 @@ Configuring Traffic Vault
 =
 The following steps were taken to configure Riak in our environments.
 
+
+Self Signed Certificate configuration
+-
+Below shows how to create self signed certs for Trafficvault.
+
+Note: Self Signed Certificates are not recommended for production use. 
Intended for dev or learning purposes only. Modify subject as necessary.   
+
+   ``cd ~``
+   ``mkdir certs``
+   ``cd certs``
+   ``openssl genrsa -out ca-bundle.key 2048``
+   ``openssl req -new -key ca-bundle.key -out ca-bundle.csr -subj 
"/C=US/ST=CO/L=DEN/O=somecompany/OU=CDN/CN=somecompany.net/emailAddress=someu...@somecompany.net"``
+   ``openssl x509 -req -days 365 -in ca-bundle.csr -signkey ca-bundle.key 
-out ca-bundle.crt``
+   ``openssl genrsa -out server.key 2048``
+   ``openssl req -new -key server.key -out server.csr -subj 
"/C=US/ST=CO/L=DEN/O=somecompany/OU=CDN/CN=somecompany.net/emailAddress=someu...@somecompany.net"``
+   ``openssl x509 -req -days 365 -in server.csr -CA ca-bundle.crt -CAkey 
ca-bundle.key -CAcreateserial -out server.crt``
+   ``mkdir /etc/riak/certs``
+   ``mv -f server.crt /etc/riak/certs/.``
+   ``mv -f server.key /etc/riak/certs/.``
+   ``mv -f ca-bundle.crt /etc/pki/tls/certs/.``
+
 
 Review comment:
   Certainly! I can do that.. 
   
   Would this be more of what we're looking for? 
   
   `Self Signed Certificate configuration
   -
   
   note:: Self Signed Certificates are not recommended for production use. 
Intended for dev or learning purposes only. Modify subject as necessary.
   
   code-block:: shell
   :caption: Self-Signed Certificate Configuration
   
   cd ~
   mkdir certs
   cd certs
   openssl genrsa -out ca-bundle.key 2048
   openssl req -new -key ca-bundle.key -out ca-bundle.csr -subj 
"/C=US/ST=CO/L=DEN/O=somecompany/OU=CDN/CN=somecompany.net/emailAddress=someu...@somecompany.net"
   openssl x509 -req -days 365 -in ca-bundle.csr -signkey ca-bundle.key 
-out ca-bundle.crt
   openssl genrsa -out server.key 2048
   openssl req -new -key server.key -out server.csr -subj 
"/C=US/ST=CO/L=DEN/O=somecompany/OU=CDN/CN=somecompany.net/emailAddress=someu...@somecompany.net"
   openssl x509 -req -days 365 -in server.csr -CA ca-bundle.crt -CAkey 
ca-bundle.key -CAcreateserial -out server.crt
   mkdir /etc/riak/certs
   mv -f server.crt /etc/riak/certs/.
   mv -f server.key /etc/riak/certs/.
   mv -f ca-bundle.crt /etc/pki/tls/certs/.
   `


This is an automated message from the Apache Git Service.
To respond to the message, please log on GitHub and use the
URL above to go to the specific comment.
 
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org


With regards,
Apache Git Services

[GitHub] villajo commented on a change in pull request #3122: Pushing changes to Traffic Vault documentation to have instructions f…

[GitBox]

villajo commented on a change in pull request #3122: Pushing changes to Traffic 
Vault documentation to have instructions f…
URL: https://github.com/apache/trafficcontrol/pull/3122#discussion_r242223067
 
 

 ##
 File path: docs/source/admin/traffic_vault.rst
 ##
 @@ -29,6 +29,28 @@ Configuring Traffic Vault
 =
 The following steps were taken to configure Riak in our environments.
 
+
+Self Signed Certificate configuration
+-
+Below shows how to create self signed certs for Trafficvault.
+
+Note: Self Signed Certificates are not recommended for production use. 
Intended for dev or learning purposes only. Modify subject as necessary.   
 
 Review comment:
   Will do on both fronts! Thank you!


This is an automated message from the Apache Git Service.
To respond to the message, please log on GitHub and use the
URL above to go to the specific comment.
 
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org


With regards,
Apache Git Services

[GitHub] asfgit commented on issue #3122: Add Traffic Vault steps for Self Signed SSL

[GitBox]

asfgit commented on issue #3122: Add Traffic Vault steps for Self Signed SSL
URL: https://github.com/apache/trafficcontrol/pull/3122#issuecomment-447914805
 
 
   
   Refer to this link for build results (access rights to CI server needed): 
   https://builds.apache.org/job/trafficcontrol-PR/2958/
   Test FAILed.
   


This is an automated message from the Apache Git Service.
To respond to the message, please log on GitHub and use the
URL above to go to the specific comment.
 
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org


With regards,
Apache Git Services

[GitHub] ocket8888 commented on a change in pull request #3122: Add Traffic Vault steps for Self Signed SSL

[GitBox]

ocket commented on a change in pull request #3122: Add Traffic Vault steps 
for Self Signed SSL
URL: https://github.com/apache/trafficcontrol/pull/3122#discussion_r242228970
 
 

 ##
 File path: docs/source/admin/traffic_vault.rst
 ##
 @@ -29,6 +29,28 @@ Configuring Traffic Vault
 =
 The following steps were taken to configure Riak in our environments.
 
+
+Self Signed Certificate configuration
+-
+Below shows how to create self signed certs for Trafficvault.
+
+Note: Self Signed Certificates are not recommended for production use. 
Intended for dev or learning purposes only. Modify subject as necessary.   
+
+   ``cd ~``
+   ``mkdir certs``
+   ``cd certs``
+   ``openssl genrsa -out ca-bundle.key 2048``
+   ``openssl req -new -key ca-bundle.key -out ca-bundle.csr -subj 
"/C=US/ST=CO/L=DEN/O=somecompany/OU=CDN/CN=somecompany.net/emailAddress=someu...@somecompany.net"``
+   ``openssl x509 -req -days 365 -in ca-bundle.csr -signkey ca-bundle.key 
-out ca-bundle.crt``
+   ``openssl genrsa -out server.key 2048``
+   ``openssl req -new -key server.key -out server.csr -subj 
"/C=US/ST=CO/L=DEN/O=somecompany/OU=CDN/CN=somecompany.net/emailAddress=someu...@somecompany.net"``
+   ``openssl x509 -req -days 365 -in server.csr -CA ca-bundle.crt -CAkey 
ca-bundle.key -CAcreateserial -out server.crt``
+   ``mkdir /etc/riak/certs``
+   ``mv -f server.crt /etc/riak/certs/.``
+   ``mv -f server.key /etc/riak/certs/.``
+   ``mv -f ca-bundle.crt /etc/pki/tls/certs/.``
+
 
 Review comment:
   I believe so. It's a little hard to tell, because GitHub is trying to format 
it as markdown, but it looks roughly right. 


This is an automated message from the Apache Git Service.
To respond to the message, please log on GitHub and use the
URL above to go to the specific comment.
 
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org


With regards,
Apache Git Services

[GitHub] villajo commented on a change in pull request #3122: Add Traffic Vault steps for Self Signed SSL

[GitBox]

villajo commented on a change in pull request #3122: Add Traffic Vault steps 
for Self Signed SSL
URL: https://github.com/apache/trafficcontrol/pull/3122#discussion_r242221902
 
 

 ##
 File path: docs/source/admin/traffic_vault.rst
 ##
 @@ -29,6 +29,28 @@ Configuring Traffic Vault
 =
 The following steps were taken to configure Riak in our environments.
 
+
+Self Signed Certificate configuration
+-
+Below shows how to create self signed certs for Trafficvault.
+
+Note: Self Signed Certificates are not recommended for production use. 
Intended for dev or learning purposes only. Modify subject as necessary.   
+
+   ``cd ~``
+   ``mkdir certs``
+   ``cd certs``
+   ``openssl genrsa -out ca-bundle.key 2048``
+   ``openssl req -new -key ca-bundle.key -out ca-bundle.csr -subj 
"/C=US/ST=CO/L=DEN/O=somecompany/OU=CDN/CN=somecompany.net/emailAddress=someu...@somecompany.net"``
+   ``openssl x509 -req -days 365 -in ca-bundle.csr -signkey ca-bundle.key 
-out ca-bundle.crt``
+   ``openssl genrsa -out server.key 2048``
+   ``openssl req -new -key server.key -out server.csr -subj 
"/C=US/ST=CO/L=DEN/O=somecompany/OU=CDN/CN=somecompany.net/emailAddress=someu...@somecompany.net"``
+   ``openssl x509 -req -days 365 -in server.csr -CA ca-bundle.crt -CAkey 
ca-bundle.key -CAcreateserial -out server.crt``
+   ``mkdir /etc/riak/certs``
+   ``mv -f server.crt /etc/riak/certs/.``
+   ``mv -f server.key /etc/riak/certs/.``
+   ``mv -f ca-bundle.crt /etc/pki/tls/certs/.``
+
 
 Review comment:
   Certainly! I can do that.. 
   
   Would this be more of what we're looking for? 
   
   ```Self Signed Certificate configuration
   -
   
   note:: Self Signed Certificates are not recommended for production use. 
Intended for dev or learning purposes only. Modify subject as necessary.
   
   code-block:: shell
   :caption: Self-Signed Certificate Configuration
   
   cd ~
   mkdir certs
   cd certs
   openssl genrsa -out ca-bundle.key 2048
   openssl req -new -key ca-bundle.key -out ca-bundle.csr -subj 
"/C=US/ST=CO/L=DEN/O=somecompany/OU=CDN/CN=somecompany.net/emailAddress=someu...@somecompany.net"
   openssl x509 -req -days 365 -in ca-bundle.csr -signkey ca-bundle.key 
-out ca-bundle.crt
   openssl genrsa -out server.key 2048
   openssl req -new -key server.key -out server.csr -subj 
"/C=US/ST=CO/L=DEN/O=somecompany/OU=CDN/CN=somecompany.net/emailAddress=someu...@somecompany.net"
   openssl x509 -req -days 365 -in server.csr -CA ca-bundle.crt -CAkey 
ca-bundle.key -CAcreateserial -out server.crt
   mkdir /etc/riak/certs
   mv -f server.crt /etc/riak/certs/.
   mv -f server.key /etc/riak/certs/.
   mv -f ca-bundle.crt /etc/pki/tls/certs/.
   ```


This is an automated message from the Apache Git Service.
To respond to the message, please log on GitHub and use the
URL above to go to the specific comment.
 
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org


With regards,
Apache Git Services

[GitHub] villajo commented on a change in pull request #3122: Add Traffic Vault steps for Self Signed SSL

[GitBox]

villajo commented on a change in pull request #3122: Add Traffic Vault steps 
for Self Signed SSL
URL: https://github.com/apache/trafficcontrol/pull/3122#discussion_r242221902
 
 

 ##
 File path: docs/source/admin/traffic_vault.rst
 ##
 @@ -29,6 +29,28 @@ Configuring Traffic Vault
 =
 The following steps were taken to configure Riak in our environments.
 
+
+Self Signed Certificate configuration
+-
+Below shows how to create self signed certs for Trafficvault.
+
+Note: Self Signed Certificates are not recommended for production use. 
Intended for dev or learning purposes only. Modify subject as necessary.   
+
+   ``cd ~``
+   ``mkdir certs``
+   ``cd certs``
+   ``openssl genrsa -out ca-bundle.key 2048``
+   ``openssl req -new -key ca-bundle.key -out ca-bundle.csr -subj 
"/C=US/ST=CO/L=DEN/O=somecompany/OU=CDN/CN=somecompany.net/emailAddress=someu...@somecompany.net"``
+   ``openssl x509 -req -days 365 -in ca-bundle.csr -signkey ca-bundle.key 
-out ca-bundle.crt``
+   ``openssl genrsa -out server.key 2048``
+   ``openssl req -new -key server.key -out server.csr -subj 
"/C=US/ST=CO/L=DEN/O=somecompany/OU=CDN/CN=somecompany.net/emailAddress=someu...@somecompany.net"``
+   ``openssl x509 -req -days 365 -in server.csr -CA ca-bundle.crt -CAkey 
ca-bundle.key -CAcreateserial -out server.crt``
+   ``mkdir /etc/riak/certs``
+   ``mv -f server.crt /etc/riak/certs/.``
+   ``mv -f server.key /etc/riak/certs/.``
+   ``mv -f ca-bundle.crt /etc/pki/tls/certs/.``
+
 
 Review comment:
   Certainly! I can do that.. 
   
   Would this be more of what we're looking for? 
   
   ```Self Signed Certificate configuration
   -
   
   .. note:: Self Signed Certificates are not recommended for production use. 
Intended for dev or learning purposes only. Modify subject as necessary.
   
   code-block:: shell
   :caption: Self-Signed Certificate Configuration
   
   cd ~
   mkdir certs
   cd certs
   openssl genrsa -out ca-bundle.key 2048
   openssl req -new -key ca-bundle.key -out ca-bundle.csr -subj 
"/C=US/ST=CO/L=DEN/O=somecompany/OU=CDN/CN=somecompany.net/emailAddress=someu...@somecompany.net"
   openssl x509 -req -days 365 -in ca-bundle.csr -signkey ca-bundle.key 
-out ca-bundle.crt
   openssl genrsa -out server.key 2048
   openssl req -new -key server.key -out server.csr -subj 
"/C=US/ST=CO/L=DEN/O=somecompany/OU=CDN/CN=somecompany.net/emailAddress=someu...@somecompany.net"
   openssl x509 -req -days 365 -in server.csr -CA ca-bundle.crt -CAkey 
ca-bundle.key -CAcreateserial -out server.crt
   mkdir /etc/riak/certs
   mv -f server.crt /etc/riak/certs/.
   mv -f server.key /etc/riak/certs/.
   mv -f ca-bundle.crt /etc/pki/tls/certs/.
   ```


This is an automated message from the Apache Git Service.
To respond to the message, please log on GitHub and use the
URL above to go to the specific comment.
 
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org


With regards,
Apache Git Services

[GitHub] villajo commented on a change in pull request #3122: Add Traffic Vault steps for Self Signed SSL

[GitBox]

villajo commented on a change in pull request #3122: Add Traffic Vault steps 
for Self Signed SSL
URL: https://github.com/apache/trafficcontrol/pull/3122#discussion_r242221902
 
 

 ##
 File path: docs/source/admin/traffic_vault.rst
 ##
 @@ -29,6 +29,28 @@ Configuring Traffic Vault
 =
 The following steps were taken to configure Riak in our environments.
 
+
+Self Signed Certificate configuration
+-
+Below shows how to create self signed certs for Trafficvault.
+
+Note: Self Signed Certificates are not recommended for production use. 
Intended for dev or learning purposes only. Modify subject as necessary.   
+
+   ``cd ~``
+   ``mkdir certs``
+   ``cd certs``
+   ``openssl genrsa -out ca-bundle.key 2048``
+   ``openssl req -new -key ca-bundle.key -out ca-bundle.csr -subj 
"/C=US/ST=CO/L=DEN/O=somecompany/OU=CDN/CN=somecompany.net/emailAddress=someu...@somecompany.net"``
+   ``openssl x509 -req -days 365 -in ca-bundle.csr -signkey ca-bundle.key 
-out ca-bundle.crt``
+   ``openssl genrsa -out server.key 2048``
+   ``openssl req -new -key server.key -out server.csr -subj 
"/C=US/ST=CO/L=DEN/O=somecompany/OU=CDN/CN=somecompany.net/emailAddress=someu...@somecompany.net"``
+   ``openssl x509 -req -days 365 -in server.csr -CA ca-bundle.crt -CAkey 
ca-bundle.key -CAcreateserial -out server.crt``
+   ``mkdir /etc/riak/certs``
+   ``mv -f server.crt /etc/riak/certs/.``
+   ``mv -f server.key /etc/riak/certs/.``
+   ``mv -f ca-bundle.crt /etc/pki/tls/certs/.``
+
 
 Review comment:
   Certainly! I can do that.. 
   
   Would this be more of what we're looking for? 
   
   ```Self Signed Certificate configuration
   -
   
   .. note:: Self Signed Certificates are not recommended for production use. 
Intended for dev or learning purposes only. Modify subject as necessary.
   
   .. code-block:: shell
   :caption: Self-Signed Certificate Configuration
   
   cd ~
   mkdir certs
   cd certs
   openssl genrsa -out ca-bundle.key 2048
   openssl req -new -key ca-bundle.key -out ca-bundle.csr -subj 
"/C=US/ST=CO/L=DEN/O=somecompany/OU=CDN/CN=somecompany.net/emailAddress=someu...@somecompany.net"
   openssl x509 -req -days 365 -in ca-bundle.csr -signkey ca-bundle.key 
-out ca-bundle.crt
   openssl genrsa -out server.key 2048
   openssl req -new -key server.key -out server.csr -subj 
"/C=US/ST=CO/L=DEN/O=somecompany/OU=CDN/CN=somecompany.net/emailAddress=someu...@somecompany.net"
   openssl x509 -req -days 365 -in server.csr -CA ca-bundle.crt -CAkey 
ca-bundle.key -CAcreateserial -out server.crt
   mkdir /etc/riak/certs
   mv -f server.crt /etc/riak/certs/.
   mv -f server.key /etc/riak/certs/.
   mv -f ca-bundle.crt /etc/pki/tls/certs/.
   ```


This is an automated message from the Apache Git Service.
To respond to the message, please log on GitHub and use the
URL above to go to the specific comment.
 
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org


With regards,
Apache Git Services

[GitHub] ocket8888 commented on a change in pull request #3122: Add Traffic Vault steps for Self Signed SSL

[GitBox]

ocket commented on a change in pull request #3122: Add Traffic Vault steps 
for Self Signed SSL
URL: https://github.com/apache/trafficcontrol/pull/3122#discussion_r242228970
 
 

 ##
 File path: docs/source/admin/traffic_vault.rst
 ##
 @@ -29,6 +29,28 @@ Configuring Traffic Vault
 =
 The following steps were taken to configure Riak in our environments.
 
+
+Self Signed Certificate configuration
+-
+Below shows how to create self signed certs for Trafficvault.
+
+Note: Self Signed Certificates are not recommended for production use. 
Intended for dev or learning purposes only. Modify subject as necessary.   
+
+   ``cd ~``
+   ``mkdir certs``
+   ``cd certs``
+   ``openssl genrsa -out ca-bundle.key 2048``
+   ``openssl req -new -key ca-bundle.key -out ca-bundle.csr -subj 
"/C=US/ST=CO/L=DEN/O=somecompany/OU=CDN/CN=somecompany.net/emailAddress=someu...@somecompany.net"``
+   ``openssl x509 -req -days 365 -in ca-bundle.csr -signkey ca-bundle.key 
-out ca-bundle.crt``
+   ``openssl genrsa -out server.key 2048``
+   ``openssl req -new -key server.key -out server.csr -subj 
"/C=US/ST=CO/L=DEN/O=somecompany/OU=CDN/CN=somecompany.net/emailAddress=someu...@somecompany.net"``
+   ``openssl x509 -req -days 365 -in server.csr -CA ca-bundle.crt -CAkey 
ca-bundle.key -CAcreateserial -out server.crt``
+   ``mkdir /etc/riak/certs``
+   ``mv -f server.crt /etc/riak/certs/.``
+   ``mv -f server.key /etc/riak/certs/.``
+   ``mv -f ca-bundle.crt /etc/pki/tls/certs/.``
+
 
 Review comment:
   Actually, it looks like you're missing the double-periods before directives 
like e.g. `.. note::` and `.. code-block:: shell`.


This is an automated message from the Apache Git Service.
To respond to the message, please log on GitHub and use the
URL above to go to the specific comment.
 
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org


With regards,
Apache Git Services

[GitHub] villajo commented on a change in pull request #3122: Add Traffic Vault steps for Self Signed SSL

[GitBox]

villajo commented on a change in pull request #3122: Add Traffic Vault steps 
for Self Signed SSL
URL: https://github.com/apache/trafficcontrol/pull/3122#discussion_r242233225
 
 

 ##
 File path: docs/source/admin/traffic_vault.rst
 ##
 @@ -29,6 +29,28 @@ Configuring Traffic Vault
 =
 The following steps were taken to configure Riak in our environments.
 
+
+Self Signed Certificate configuration
+-
+Below shows how to create self signed certs for Trafficvault.
+
+Note: Self Signed Certificates are not recommended for production use. 
Intended for dev or learning purposes only. Modify subject as necessary.   
+
+   ``cd ~``
+   ``mkdir certs``
+   ``cd certs``
+   ``openssl genrsa -out ca-bundle.key 2048``
+   ``openssl req -new -key ca-bundle.key -out ca-bundle.csr -subj 
"/C=US/ST=CO/L=DEN/O=somecompany/OU=CDN/CN=somecompany.net/emailAddress=someu...@somecompany.net"``
+   ``openssl x509 -req -days 365 -in ca-bundle.csr -signkey ca-bundle.key 
-out ca-bundle.crt``
+   ``openssl genrsa -out server.key 2048``
+   ``openssl req -new -key server.key -out server.csr -subj 
"/C=US/ST=CO/L=DEN/O=somecompany/OU=CDN/CN=somecompany.net/emailAddress=someu...@somecompany.net"``
+   ``openssl x509 -req -days 365 -in server.csr -CA ca-bundle.crt -CAkey 
ca-bundle.key -CAcreateserial -out server.crt``
+   ``mkdir /etc/riak/certs``
+   ``mv -f server.crt /etc/riak/certs/.``
+   ``mv -f server.key /etc/riak/certs/.``
+   ``mv -f ca-bundle.crt /etc/pki/tls/certs/.``
+
 
 Review comment:
   changing that in github.. one moment. 


This is an automated message from the Apache Git Service.
To respond to the message, please log on GitHub and use the
URL above to go to the specific comment.
 
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org


With regards,
Apache Git Services

[GitHub] dangogh opened a new issue #3131: error building traffic_portal

[GitBox]

dangogh opened a new issue #3131: error building traffic_portal
URL: https://github.com/apache/trafficcontrol/issues/3131
 
 
   Running traffic_portal build in docker on mac,  I got this error:
   
   ```
   Step 7/11 : RUN  gem install compass
   ...
   ERROR:  Error installing compass:
The last version of rb-inotify (>= 0.9) to support your Ruby & RubyGems 
was 0.9.10. Try installing it with `gem install rb-inotify -v 0.9.10` and then 
running the current command again
rb-inotify requires Ruby version >= 2.2. The current ruby version is .
   ```
   


This is an automated message from the Apache Git Service.
To respond to the message, please log on GitHub and use the
URL above to go to the specific comment.
 
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org


With regards,
Apache Git Services

[GitHub] ocket8888 commented on a change in pull request #3122: Add Traffic Vault steps for Self Signed SSL

[GitBox]

ocket commented on a change in pull request #3122: Add Traffic Vault steps 
for Self Signed SSL
URL: https://github.com/apache/trafficcontrol/pull/3122#discussion_r242235152
 
 

 ##
 File path: docs/source/admin/traffic_vault.rst
 ##
 @@ -29,6 +29,28 @@ Configuring Traffic Vault
 =
 The following steps were taken to configure Riak in our environments.
 
+
+Self Signed Certificate configuration
+-
+Below shows how to create self signed certs for Trafficvault.
+
+Note: Self Signed Certificates are not recommended for production use. 
Intended for dev or learning purposes only. Modify subject as necessary.   
+
+   ``cd ~``
+   ``mkdir certs``
+   ``cd certs``
+   ``openssl genrsa -out ca-bundle.key 2048``
+   ``openssl req -new -key ca-bundle.key -out ca-bundle.csr -subj 
"/C=US/ST=CO/L=DEN/O=somecompany/OU=CDN/CN=somecompany.net/emailAddress=someu...@somecompany.net"``
+   ``openssl x509 -req -days 365 -in ca-bundle.csr -signkey ca-bundle.key 
-out ca-bundle.crt``
+   ``openssl genrsa -out server.key 2048``
+   ``openssl req -new -key server.key -out server.csr -subj 
"/C=US/ST=CO/L=DEN/O=somecompany/OU=CDN/CN=somecompany.net/emailAddress=someu...@somecompany.net"``
+   ``openssl x509 -req -days 365 -in server.csr -CA ca-bundle.crt -CAkey 
ca-bundle.key -CAcreateserial -out server.crt``
+   ``mkdir /etc/riak/certs``
+   ``mv -f server.crt /etc/riak/certs/.``
+   ``mv -f server.key /etc/riak/certs/.``
+   ``mv -f ca-bundle.crt /etc/pki/tls/certs/.``
+
 
 Review comment:
   Okay, that looks good.


This is an automated message from the Apache Git Service.
To respond to the message, please log on GitHub and use the
URL above to go to the specific comment.
 
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org


With regards,
Apache Git Services

[GitHub] asfgit commented on issue #3122: Add Traffic Vault steps for Self Signed SSL

[GitBox]

asfgit commented on issue #3122: Add Traffic Vault steps for Self Signed SSL
URL: https://github.com/apache/trafficcontrol/pull/3122#issuecomment-447922815
 
 
   
   Refer to this link for build results (access rights to CI server needed): 
   https://builds.apache.org/job/trafficcontrol-PR/2959/
   Test FAILed.
   


This is an automated message from the Apache Git Service.
To respond to the message, please log on GitHub and use the
URL above to go to the specific comment.
 
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org


With regards,
Apache Git Services

[GitHub] dangogh opened a new pull request #3132: lock TP dependency

[GitBox]

dangogh opened a new pull request #3132: lock TP dependency
URL: https://github.com/apache/trafficcontrol/pull/3132
 
 
    What does this PR do?
   
   Locks rb-inotify version to be compatible with Ruby version on centos 7.
   
   Fixes #3131 
   
    Which TC components are affected by this PR?
   
   - [ ] Documentation
   - [ ] Grove
   - [ ] Traffic Analytics
   - [ ] Traffic Monitor
   - [ ] Traffic Ops
   - [ ] Traffic Ops ORT
   - [x] Traffic Portal
   - [ ] Traffic Router
   - [ ] Traffic Stats
   - [ ] Traffic Vault
   - [ ] Other _
   
    What is the best way to verify this PR?
   
   ```
   ./pkg -v traffic_portal_build
   ```
   
    Check all that apply
   
   - [ ] This PR includes tests
   - [ ] This PR includes documentation updates
   - [ ] This PR includes an update to CHANGELOG.md
   - [ ] This PR includes all required license headers
   - [ ] This PR includes a database migration (ensure that migration sequence 
is correct)
   - [ ] This PR fixes a serious security flaw. Read more: 
[www.apache.org/security](http://www.apache.org/security/)
   
   
   
   
   
   


This is an automated message from the Apache Git Service.
To respond to the message, please log on GitHub and use the
URL above to go to the specific comment.
 
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org


With regards,
Apache Git Services

[GitHub] dangogh closed pull request #3122: Add Traffic Vault steps for Self Signed SSL

[GitBox]

dangogh closed pull request #3122: Add Traffic Vault steps for Self Signed SSL
URL: https://github.com/apache/trafficcontrol/pull/3122
 
 
   

This is a PR merged from a forked repository.
As GitHub hides the original diff on merge, it is displayed below for
the sake of provenance:

As this is a foreign pull request (from a fork), the diff is supplied
below (as it won't show otherwise due to GitHub magic):

diff --git a/docs/source/admin/traffic_vault.rst 
b/docs/source/admin/traffic_vault.rst
index 55fdc95a1..4651cf27a 100644
--- a/docs/source/admin/traffic_vault.rst
+++ b/docs/source/admin/traffic_vault.rst
@@ -29,6 +29,30 @@ Configuring Traffic Vault
 =
 The following steps were taken to configure Riak in our environments.
 
+
+Self Signed Certificate configuration
+-
+
+.. note:: Self Signed Certificates are not recommended for production use. 
Intended for dev or learning purposes only. Modify subject as necessary.   
+
+.. code-block:: shell
+:caption: Self-Signed Certificate Configuration
+
+   cd ~
+   mkdir certs
+   cd certs
+   openssl genrsa -out ca-bundle.key 2048
+   openssl req -new -key ca-bundle.key -out ca-bundle.csr -subj 
"/C=US/ST=CO/L=DEN/O=somecompany/OU=CDN/CN=somecompany.net/emailAddress=someu...@somecompany.net"
+   openssl x509 -req -days 365 -in ca-bundle.csr -signkey ca-bundle.key 
-out ca-bundle.crt
+   openssl genrsa -out server.key 2048
+   openssl req -new -key server.key -out server.csr -subj 
"/C=US/ST=CO/L=DEN/O=somecompany/OU=CDN/CN=somecompany.net/emailAddress=someu...@somecompany.net"
+   openssl x509 -req -days 365 -in server.csr -CA ca-bundle.crt -CAkey 
ca-bundle.key -CAcreateserial -out server.crt
+   mkdir /etc/riak/certs
+   mv -f server.crt /etc/riak/certs/.
+   mv -f server.key /etc/riak/certs/.
+   mv -f ca-bundle.crt /etc/pki/tls/certs/.
+
+
 Riak configuration file configuration
 -
 


 


This is an automated message from the Apache Git Service.
To respond to the message, please log on GitHub and use the
URL above to go to the specific comment.
 
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org


With regards,
Apache Git Services

[GitHub] mitchell852 closed pull request #3132: lock TP dependency

[GitBox]

mitchell852 closed pull request #3132: lock TP dependency
URL: https://github.com/apache/trafficcontrol/pull/3132
 
 
   

This is a PR merged from a forked repository.
As GitHub hides the original diff on merge, it is displayed below for
the sake of provenance:

As this is a foreign pull request (from a fork), the diff is supplied
below (as it won't show otherwise due to GitHub magic):

diff --git a/infrastructure/docker/build/Dockerfile-traffic_portal 
b/infrastructure/docker/build/Dockerfile-traffic_portal
index b6380dcae..e37c61982 100644
--- a/infrastructure/docker/build/Dockerfile-traffic_portal
+++ b/infrastructure/docker/build/Dockerfile-traffic_portal
@@ -39,9 +39,10 @@ RUN  yum -y install \
ruby-devel \
rubygems
 
-RUNgem update --system
-RUNgem install compass
-RUNnpm -g install bower grunt-cli
+RUNgem update --system && \
+   gem install rb-inotify -v 0.9.10 && \
+   gem install compass && \
+   npm -g install bower grunt-cli
 
 # bower will not run as root by default
 RUNecho '{ "allow_root": true }' > /root/.bowerrc


 


This is an automated message from the Apache Git Service.
To respond to the message, please log on GitHub and use the
URL above to go to the specific comment.
 
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org


With regards,
Apache Git Services

[GitHub] mitchell852 closed issue #3131: error building traffic_portal

[GitBox]

mitchell852 closed issue #3131: error building traffic_portal
URL: https://github.com/apache/trafficcontrol/issues/3131
 
 
   


This is an automated message from the Apache Git Service.
To respond to the message, please log on GitHub and use the
URL above to go to the specific comment.
 
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org


With regards,
Apache Git Services

[GitHub] ocket8888 opened a new pull request #3133: Added documentation guidelines

[GitBox]

ocket opened a new pull request #3133: Added documentation guidelines
URL: https://github.com/apache/trafficcontrol/pull/3133
 
 
   ## What does this PR do?
   Adds documentation guidelines as per the mailing list discussion. Also fixed 
a label that was in conflict with said guidelines, provided cursor hints for 
abbreviations and removed a warning about building the docs with Python 3.7+ 
(related bug is now fixed).
   
   ## Which TC components are affected by this PR?
   - [x] Documentation
   - [ ] Grove
   - [ ] Traffic Analytics
   - [ ] Traffic Monitor
   - [ ] Traffic Ops
   - [ ] Traffic Ops ORT
   - [ ] Traffic Portal
   - [ ] Traffic Router
   - [ ] Traffic Stats
   - [ ] Traffic Vault
   - [ ] Other _
   
   ## What is the best way to verify this PR?
   Build the documentation and read the guidelines to be sure they make sense 
and provide tangible quality of life benefits.
   
   ## Check all that apply
   - [ ] This PR includes tests
   - [x] This PR includes documentation updates
   - [ ] This PR includes an update to CHANGELOG.md
   - [ ] This PR includes all required license headers
   - [ ] This PR includes a database migration (ensure that migration sequence 
is correct)
   - [ ] This PR fixes a serious security flaw. Read more: 
[www.apache.org/security](http://www.apache.org/security/)
   
   
   
   


This is an automated message from the Apache Git Service.
To respond to the message, please log on GitHub and use the
URL above to go to the specific comment.
 
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org


With regards,
Apache Git Services

[GitHub] asfgit commented on issue #3132: lock TP dependency

[GitBox]

asfgit commented on issue #3132: lock TP dependency
URL: https://github.com/apache/trafficcontrol/pull/3132#issuecomment-447934959
 
 
   
   Refer to this link for build results (access rights to CI server needed): 
   https://builds.apache.org/job/trafficcontrol-PR/2960/
   Test PASSed.
   


This is an automated message from the Apache Git Service.
To respond to the message, please log on GitHub and use the
URL above to go to the specific comment.
 
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org


With regards,
Apache Git Services

[GitHub] asfgit commented on issue #3133: Added documentation guidelines

[GitBox]

asfgit commented on issue #3133: Added documentation guidelines
URL: https://github.com/apache/trafficcontrol/pull/3133#issuecomment-447936888
 
 
   
   Refer to this link for build results (access rights to CI server needed): 
   https://builds.apache.org/job/trafficcontrol-PR/2961/
   Test PASSed.
   


This is an automated message from the Apache Git Service.
To respond to the message, please log on GitHub and use the
URL above to go to the specific comment.
 
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org


With regards,
Apache Git Services

[GitHub] ocket8888 opened a new pull request #3134: Added an explanation of the format and structure of API endpoint docs

[GitBox]

ocket opened a new pull request #3134: Added an explanation of the format 
and structure of API endpoint docs
URL: https://github.com/apache/trafficcontrol/pull/3134
 
 
   ## What does this PR do?
   Adds an explanation of the format and structure of API endpoint docs.
   
   ## Which TC components are affected by this PR?
   - [x] Documentation
   - [ ] Grove
   - [ ] Traffic Analytics
   - [ ] Traffic Monitor
   - [ ] Traffic Ops
   - [ ] Traffic Ops ORT
   - [ ] Traffic Portal
   - [ ] Traffic Router
   - [ ] Traffic Stats
   - [ ] Traffic Vault
   - [ ] Other _
   
   ## What is the best way to verify this PR?
   Ensure the docs build properly, then read the index page for the Traffic Ops 
API and make sure the format is explained in a thorough, sensible manner. 
   
   ## Check all that apply
   - [ ] This PR includes tests
   - [x] This PR includes documentation updates
   - [ ] This PR includes an update to CHANGELOG.md
   - [ ] This PR includes all required license headers
   - [ ] This PR includes a database migration (ensure that migration sequence 
is correct)
   - [ ] This PR fixes a serious security flaw. Read more: 
[www.apache.org/security](http://www.apache.org/security/)
   


This is an automated message from the Apache Git Service.
To respond to the message, please log on GitHub and use the
URL above to go to the specific comment.
 
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org


With regards,
Apache Git Services

[GitHub] asfgit commented on issue #3134: Added an explanation of the format and structure of API endpoint docs

[GitBox]

asfgit commented on issue #3134: Added an explanation of the format and 
structure of API endpoint docs
URL: https://github.com/apache/trafficcontrol/pull/3134#issuecomment-447960235
 
 
   
   Refer to this link for build results (access rights to CI server needed): 
   https://builds.apache.org/job/trafficcontrol-PR/2962/
   Test PASSed.
   


This is an automated message from the Apache Git Service.
To respond to the message, please log on GitHub and use the
URL above to go to the specific comment.
 
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org


With regards,
Apache Git Services

[GitHub] mitchell852 commented on a change in pull request #3133: Added documentation guidelines

[GitBox]

mitchell852 commented on a change in pull request #3133: Added documentation 
guidelines
URL: https://github.com/apache/trafficcontrol/pull/3133#discussion_r242284380
 
 

 ##
 File path: docs/source/development/documentation_guidelines.rst
 ##
 @@ -0,0 +1,172 @@
+..
+..
+.. Licensed under the Apache License, Version 2.0 (the "License");
+.. you may not use this file except in compliance with the License.
+.. You may obtain a copy of the License at
+..
+.. http://www.apache.org/licenses/LICENSE-2.0
+..
+.. Unless required by applicable law or agreed to in writing, software
+.. distributed under the License is distributed on an "AS IS" BASIS,
+.. WITHOUT WARRANTIES OR CONDITIONS OF ANY KIND, either express or implied.
+.. See the License for the specific language governing permissions and
+.. limitations under the License.
+..
+
+.. _docs-guide:
+
+
+Documentation Guidelines
+
+The Apache Traffic Control documentation is written in :abbr:`RST 
(reStructuredText)` and uses the `Sphinx documentation build system 
`_ to convert these into the desired 
output document format. This collection of guidelines does **not** aim to be a 
primer in :abbr:`RST (reStructuredText)`, but merely a style guide regarding 
how the components of the document ought to be formatted and structured. It may 
also point out some features of the markup language of which a writer may not 
be aware.
+
+.. seealso:: `The docutils RST reference 
`_.
+
+Building
+
+To build the documentation, see :ref:`docs-build`.
+
+Writing
+===
+When writing documentation, the most important things to remember are:
+
+- Spell Check. Most text editors have this built in (e.g. "F6" in Sublime 
Text) or have plugins that will do this for you.
+- Proof-Read. Spell-checkers won't catch grammatical errors or poor wording, 
so it's very important to actually proof-read all documentation *before* 
submitting it in a Pull Request.
+- Make Sure the Documentation Actually Builds. Please actually verify the 
documentation not only builds, but builds *correctly*. That means there 
probably shouldn't be any warnings, no malformed tables etc. and it also means 
that new documentation is actually accessible once built. It's not enough to 
create a new ``.rst`` file, that file must actually be linked to from some 
other, already included document. Some warnings may be considered acceptable, 
but do be prepared to defend them.
+- Traffic Ops UI is Dead. Do not ever create documentation that references or 
includes images of the Traffic Ops UI. That is officially dead now, and if the 
documentation being created is best made with references to a user-friendly UI, 
such references, examples and/or images should all be to/of Traffic Portal.
+
+Formatting
+--
+Whenever possible, avoid specifying manual line breaks, except as required by 
:abbr:`RST (reStructuredText)` syntax. Extremely long lines will be wrapped by 
the user-agent, compiler, or output format as necessary. A single blank line 
may be used to separate paragraphs. This means that the 'flow break' character 
should never need to be used, i.e. no line in the documentation should ever 
match the regular expression ``^\|$``.
+
+Abbreviations
+"
+When using an abbreviation, acronym or initialism for the first time on a 
page, it **must** be named fully and followed by the abbreviation in 
parentheses e.g. "Fully Qualified Domain Name (FQDN)". Strictly speaking, the 
*best* way to create an abbreviation is to always fully name it in parentheses 
immediately following the abbreviation using the ``:abbr:`` :abbr:`RST 
(reStructuredText)` text role e.g. ``:abbr:`FQDN (Fully Qualified Domain 
Name)```, but it's not reasonable to expect that of everyone. Some 
abbreviations can be assumed to be understood by the documentation's target 
audience, and do not need full naming; they are:
+
+- DNS
+- HTTP
+- HTTPS
+- IP/IPv4/IPv6
+- TCP
+- UDP
+- URL
+- URI
+
+Please do **not** abbreviate Traffic Control terms e.g. Cache Group, Delivery 
Service. See `Terms`_ for the proper way to use these terms.
+
+Floating Objects
+
+"Floating objects" are images, tables, source code listings, and equations. 
These may not be placed relative to other content exactly as shown in the 
source :abbr:`RST (reStructuredText)` document, as it may be necessary to move 
them for e.g. page breaks in PDF documents so they are not split across pages.
+
+Figures
+'''
+Images should *always* be included inside of a ``.. figure`` directive. 
**Always** caption figures to make their purpose clear, as well as to make them 
directly link-able inside of the document and include them in figure listings. 
Figures should, in general be sized *explicitly* but not *absolutely* i.e. use 
``70%`` not ``540px``. Figures should, in general, be centered on the page. 
When 

[GitHub] ocket8888 commented on a change in pull request #3133: Added documentation guidelines

[GitBox]

ocket commented on a change in pull request #3133: Added documentation 
guidelines
URL: https://github.com/apache/trafficcontrol/pull/3133#discussion_r242291250
 
 

 ##
 File path: docs/source/development/documentation_guidelines.rst
 ##
 @@ -0,0 +1,172 @@
+..
+..
+.. Licensed under the Apache License, Version 2.0 (the "License");
+.. you may not use this file except in compliance with the License.
+.. You may obtain a copy of the License at
+..
+.. http://www.apache.org/licenses/LICENSE-2.0
+..
+.. Unless required by applicable law or agreed to in writing, software
+.. distributed under the License is distributed on an "AS IS" BASIS,
+.. WITHOUT WARRANTIES OR CONDITIONS OF ANY KIND, either express or implied.
+.. See the License for the specific language governing permissions and
+.. limitations under the License.
+..
+
+.. _docs-guide:
+
+
+Documentation Guidelines
+
+The Apache Traffic Control documentation is written in :abbr:`RST 
(reStructuredText)` and uses the `Sphinx documentation build system 
`_ to convert these into the desired 
output document format. This collection of guidelines does **not** aim to be a 
primer in :abbr:`RST (reStructuredText)`, but merely a style guide regarding 
how the components of the document ought to be formatted and structured. It may 
also point out some features of the markup language of which a writer may not 
be aware.
+
+.. seealso:: `The docutils RST reference 
`_.
+
+Building
+
+To build the documentation, see :ref:`docs-build`.
+
+Writing
+===
+When writing documentation, the most important things to remember are:
+
+- Spell Check. Most text editors have this built in (e.g. "F6" in Sublime 
Text) or have plugins that will do this for you.
+- Proof-Read. Spell-checkers won't catch grammatical errors or poor wording, 
so it's very important to actually proof-read all documentation *before* 
submitting it in a Pull Request.
+- Make Sure the Documentation Actually Builds. Please actually verify the 
documentation not only builds, but builds *correctly*. That means there 
probably shouldn't be any warnings, no malformed tables etc. and it also means 
that new documentation is actually accessible once built. It's not enough to 
create a new ``.rst`` file, that file must actually be linked to from some 
other, already included document. Some warnings may be considered acceptable, 
but do be prepared to defend them.
+- Traffic Ops UI is Dead. Do not ever create documentation that references or 
includes images of the Traffic Ops UI. That is officially dead now, and if the 
documentation being created is best made with references to a user-friendly UI, 
such references, examples and/or images should all be to/of Traffic Portal.
+
+Formatting
+--
+Whenever possible, avoid specifying manual line breaks, except as required by 
:abbr:`RST (reStructuredText)` syntax. Extremely long lines will be wrapped by 
the user-agent, compiler, or output format as necessary. A single blank line 
may be used to separate paragraphs. This means that the 'flow break' character 
should never need to be used, i.e. no line in the documentation should ever 
match the regular expression ``^\|$``.
+
+Abbreviations
+"
+When using an abbreviation, acronym or initialism for the first time on a 
page, it **must** be named fully and followed by the abbreviation in 
parentheses e.g. "Fully Qualified Domain Name (FQDN)". Strictly speaking, the 
*best* way to create an abbreviation is to always fully name it in parentheses 
immediately following the abbreviation using the ``:abbr:`` :abbr:`RST 
(reStructuredText)` text role e.g. ``:abbr:`FQDN (Fully Qualified Domain 
Name)```, but it's not reasonable to expect that of everyone. Some 
abbreviations can be assumed to be understood by the documentation's target 
audience, and do not need full naming; they are:
+
+- DNS
+- HTTP
+- HTTPS
+- IP/IPv4/IPv6
+- TCP
+- UDP
+- URL
+- URI
+
+Please do **not** abbreviate Traffic Control terms e.g. Cache Group, Delivery 
Service. See `Terms`_ for the proper way to use these terms.
+
+Floating Objects
+
+"Floating objects" are images, tables, source code listings, and equations. 
These may not be placed relative to other content exactly as shown in the 
source :abbr:`RST (reStructuredText)` document, as it may be necessary to move 
them for e.g. page breaks in PDF documents so they are not split across pages.
+
+Figures
+'''
+Images should *always* be included inside of a ``.. figure`` directive. 
**Always** caption figures to make their purpose clear, as well as to make them 
directly link-able inside of the document and include them in figure listings. 
Figures should, in general be sized *explicitly* but not *absolutely* i.e. use 
``70%`` not ``540px``. Figures should, in general, be centered on the page. 
When dr

[GitHub] ocket8888 opened a new issue #3135: /api/1.1/cachegroups 'shortname' cannot be filtered

[GitBox]

ocket opened a new issue #3135: /api/1.1/cachegroups 'shortname' cannot be 
filtered
URL: https://github.com/apache/trafficcontrol/issues/3135
 
 
   When trying to get a Cache Group with the short name "foo", for example, one 
might request `GET /api/1.1/cachegroups?shortName=foo HTTP/1.1`. The existence 
of this parameter seems intentional, but the underlying SQL query is poorly 
crafted to support it, as it fails with this error in the logs:
   ```
   ERROR: api.go:98: 2018-12-17T19:45:02.834992539Z: 172.16.239.1:48950 cg 
read: querying: pq: column reference "short_name" is ambiguous
   ```


This is an automated message from the Apache Git Service.
To respond to the message, please log on GitHub and use the
URL above to go to the specific comment.
 
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org


With regards,
Apache Git Services

[GitHub] rawlinp commented on a change in pull request #3128: Updated documentation for the new Go db/admin binary

[GitBox]

rawlinp commented on a change in pull request #3128: Updated documentation for 
the new Go db/admin binary
URL: https://github.com/apache/trafficcontrol/pull/3128#discussion_r242304062
 
 

 ##
 File path: docs/source/development/traffic_ops.rst
 ##
 @@ -229,30 +229,11 @@ To install the Traffic Ops Developer environment:
.. seealso:: `PostgreSQL instructions on setting up a database 
`_.
 
 
-#. Use the ``setup`` command of the ``admin.pl`` script (see `Database 
Management`_ for usage) to set up the traffic_ops database(s).
-
-Example Output::
-
-   $ db/admin.pl --env=development setup
-   Using database.conf: conf/development/database.conf
-   Using database.conf: conf/development/database.conf
-   Using database.conf: conf/development/database.conf
-   Using database.conf: conf/development/database.conf
-   Using database.conf: conf/development/database.conf
-   Using database.conf: conf/development/database.conf
-   Executing 'drop database to_development'
-   Executing 'create database to_development'
-   Creating database tables...
-   Warning: Using a password on the command line interface can be 
insecure.
-   Migrating database...
-   goose: migrating db environment 'development', current version: 
0, target: 2015021010
-   OK20141222103718_extension.sql
-   OK2015010810_add_job_deliveryservice.sql
-   OK2015020510_cg_location.sql
-   OK2015020910_cran_to_asn.sql
-   OK2015021010_ds_keyinfo.sql
-   Seeding database...
-   Warning: Using a password on the command line interface can be 
insecure.
+#. Use the ``reset`` and ``upgrade`` commands of the ``admin`` binary (see 
`Database Management`_ for usage) to set up the traffic_ops database(s).
+
+Example Usage::
 
 Review comment:
   So, I made this change, but if you check the built html, everything on this 
page that is contained in the `.. code-block` syntax doesn't even show up in 
the doc at all. For example, there is a long list of Perltidy options that are 
in the rst but don't show up in the built html (it's using `.. 
code-block::perl` syntax): 
https://traffic-control-cdn.readthedocs.io/en/latest/development/traffic_ops.html#perl-formatting-conventions
   Any idea what's going on here? I suspect there are probably numerous other 
things not showing up in the docs currently because of this. 


This is an automated message from the Apache Git Service.
To respond to the message, please log on GitHub and use the
URL above to go to the specific comment.
 
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org


With regards,
Apache Git Services

[GitHub] rawlinp commented on issue #3128: Updated documentation for the new Go db/admin binary

[GitBox]

rawlinp commented on issue #3128: Updated documentation for the new Go db/admin 
binary
URL: https://github.com/apache/trafficcontrol/pull/3128#issuecomment-447987502
 
 
   > It'd also be great if you could put in an option list
   
   The supported options and commands are already documented in the 
`docs/source/development/traffic_ops.rst` file.


This is an automated message from the Apache Git Service.
To respond to the message, please log on GitHub and use the
URL above to go to the specific comment.
 
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org


With regards,
Apache Git Services

[GitHub] ocket8888 commented on issue #3128: Updated documentation for the new Go db/admin binary

[GitBox]

ocket commented on issue #3128: Updated documentation for the new Go 
db/admin binary
URL: https://github.com/apache/trafficcontrol/pull/3128#issuecomment-447988929
 
 
   Ah, I see that now. That's good with me provided the new script fully 
implements all of those and only those.


This is an automated message from the Apache Git Service.
To respond to the message, please log on GitHub and use the
URL above to go to the specific comment.
 
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org


With regards,
Apache Git Services

[GitHub] ocket8888 commented on a change in pull request #3128: Updated documentation for the new Go db/admin binary

[GitBox]

ocket commented on a change in pull request #3128: Updated documentation 
for the new Go db/admin binary
URL: https://github.com/apache/trafficcontrol/pull/3128#discussion_r242306846
 
 

 ##
 File path: docs/source/development/traffic_ops.rst
 ##
 @@ -229,30 +229,11 @@ To install the Traffic Ops Developer environment:
.. seealso:: `PostgreSQL instructions on setting up a database 
`_.
 
 
-#. Use the ``setup`` command of the ``admin.pl`` script (see `Database 
Management`_ for usage) to set up the traffic_ops database(s).
-
-Example Output::
-
-   $ db/admin.pl --env=development setup
-   Using database.conf: conf/development/database.conf
-   Using database.conf: conf/development/database.conf
-   Using database.conf: conf/development/database.conf
-   Using database.conf: conf/development/database.conf
-   Using database.conf: conf/development/database.conf
-   Using database.conf: conf/development/database.conf
-   Executing 'drop database to_development'
-   Executing 'create database to_development'
-   Creating database tables...
-   Warning: Using a password on the command line interface can be 
insecure.
-   Migrating database...
-   goose: migrating db environment 'development', current version: 
0, target: 2015021010
-   OK20141222103718_extension.sql
-   OK2015010810_add_job_deliveryservice.sql
-   OK2015020510_cg_location.sql
-   OK2015020910_cran_to_asn.sql
-   OK2015021010_ds_keyinfo.sql
-   Seeding database...
-   Warning: Using a password on the command line interface can be 
insecure.
+#. Use the ``reset`` and ``upgrade`` commands of the ``admin`` binary (see 
`Database Management`_ for usage) to set up the traffic_ops database(s).
+
+Example Usage::
 
 Review comment:
   Not sure, I'll check it out.


This is an automated message from the Apache Git Service.
To respond to the message, please log on GitHub and use the
URL above to go to the specific comment.
 
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org


With regards,
Apache Git Services

[GitHub] ocket8888 commented on a change in pull request #3128: Updated documentation for the new Go db/admin binary

[GitBox]

ocket commented on a change in pull request #3128: Updated documentation 
for the new Go db/admin binary
URL: https://github.com/apache/trafficcontrol/pull/3128#discussion_r242308464
 
 

 ##
 File path: docs/source/development/traffic_ops.rst
 ##
 @@ -229,30 +229,12 @@ To install the Traffic Ops Developer environment:
.. seealso:: `PostgreSQL instructions on setting up a database 
`_.
 
 
-#. Use the ``setup`` command of the ``admin.pl`` script (see `Database 
Management`_ for usage) to set up the traffic_ops database(s).
-
-Example Output::
-
-   $ db/admin.pl --env=development setup
-   Using database.conf: conf/development/database.conf
-   Using database.conf: conf/development/database.conf
-   Using database.conf: conf/development/database.conf
-   Using database.conf: conf/development/database.conf
-   Using database.conf: conf/development/database.conf
-   Using database.conf: conf/development/database.conf
-   Executing 'drop database to_development'
-   Executing 'create database to_development'
-   Creating database tables...
-   Warning: Using a password on the command line interface can be 
insecure.
-   Migrating database...
-   goose: migrating db environment 'development', current version: 
0, target: 2015021010
-   OK20141222103718_extension.sql
-   OK2015010810_add_job_deliveryservice.sql
-   OK2015020510_cg_location.sql
-   OK2015020910_cran_to_asn.sql
-   OK2015021010_ds_keyinfo.sql
-   Seeding database...
-   Warning: Using a password on the command line interface can be 
insecure.
+#. Use the ``reset`` and ``upgrade`` commands of the ``admin`` binary (see 
`Database Management`_ for usage) to set up the traffic_ops database(s).
+
+   .. code-block::shell
 
 Review comment:
   This is why you're not seeing this in the output. It's also why that Perl 
snippet isn't being rendered. `..` in RST starts a comment - as you probably 
know. Without the space between the `::` and the syntax name, the lexer detects 
that as just a plain word, not a directive. It needs to match `^\s*\.\. 
[\w\-]+:: .*$` to be considered a directive.
   
   tl;dr: you're missing a space after `::` and before `shell`.


This is an automated message from the Apache Git Service.
To respond to the message, please log on GitHub and use the
URL above to go to the specific comment.
 
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org


With regards,
Apache Git Services

[GitHub] ocket8888 commented on a change in pull request #3128: Updated documentation for the new Go db/admin binary

[GitBox]

ocket commented on a change in pull request #3128: Updated documentation 
for the new Go db/admin binary
URL: https://github.com/apache/trafficcontrol/pull/3128#discussion_r242308464
 
 

 ##
 File path: docs/source/development/traffic_ops.rst
 ##
 @@ -229,30 +229,12 @@ To install the Traffic Ops Developer environment:
.. seealso:: `PostgreSQL instructions on setting up a database 
`_.
 
 
-#. Use the ``setup`` command of the ``admin.pl`` script (see `Database 
Management`_ for usage) to set up the traffic_ops database(s).
-
-Example Output::
-
-   $ db/admin.pl --env=development setup
-   Using database.conf: conf/development/database.conf
-   Using database.conf: conf/development/database.conf
-   Using database.conf: conf/development/database.conf
-   Using database.conf: conf/development/database.conf
-   Using database.conf: conf/development/database.conf
-   Using database.conf: conf/development/database.conf
-   Executing 'drop database to_development'
-   Executing 'create database to_development'
-   Creating database tables...
-   Warning: Using a password on the command line interface can be 
insecure.
-   Migrating database...
-   goose: migrating db environment 'development', current version: 
0, target: 2015021010
-   OK20141222103718_extension.sql
-   OK2015010810_add_job_deliveryservice.sql
-   OK2015020510_cg_location.sql
-   OK2015020910_cran_to_asn.sql
-   OK2015021010_ds_keyinfo.sql
-   Seeding database...
-   Warning: Using a password on the command line interface can be 
insecure.
+#. Use the ``reset`` and ``upgrade`` commands of the ``admin`` binary (see 
`Database Management`_ for usage) to set up the traffic_ops database(s).
+
+   .. code-block::shell
 
 Review comment:
   This is why you're not seeing this in the output. It's also why that Perl 
snippet isn't being rendered. `..` in RST starts a comment - as you probably 
know. Without the space between the `::` and the syntax name, the lexer detects 
that as just a plain word, not a directive. It needs to match `^\s*.. [\w\-]+:: 
.*$` to be considered a directive.
   
   tl;dr: you're missing a space after `::` and before `shell`.


This is an automated message from the Apache Git Service.
To respond to the message, please log on GitHub and use the
URL above to go to the specific comment.
 
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org


With regards,
Apache Git Services

[GitHub] ocket8888 commented on a change in pull request #3128: Updated documentation for the new Go db/admin binary

[GitBox]

ocket commented on a change in pull request #3128: Updated documentation 
for the new Go db/admin binary
URL: https://github.com/apache/trafficcontrol/pull/3128#discussion_r242308464
 
 

 ##
 File path: docs/source/development/traffic_ops.rst
 ##
 @@ -229,30 +229,12 @@ To install the Traffic Ops Developer environment:
.. seealso:: `PostgreSQL instructions on setting up a database 
`_.
 
 
-#. Use the ``setup`` command of the ``admin.pl`` script (see `Database 
Management`_ for usage) to set up the traffic_ops database(s).
-
-Example Output::
-
-   $ db/admin.pl --env=development setup
-   Using database.conf: conf/development/database.conf
-   Using database.conf: conf/development/database.conf
-   Using database.conf: conf/development/database.conf
-   Using database.conf: conf/development/database.conf
-   Using database.conf: conf/development/database.conf
-   Using database.conf: conf/development/database.conf
-   Executing 'drop database to_development'
-   Executing 'create database to_development'
-   Creating database tables...
-   Warning: Using a password on the command line interface can be 
insecure.
-   Migrating database...
-   goose: migrating db environment 'development', current version: 
0, target: 2015021010
-   OK20141222103718_extension.sql
-   OK2015010810_add_job_deliveryservice.sql
-   OK2015020510_cg_location.sql
-   OK2015020910_cran_to_asn.sql
-   OK2015021010_ds_keyinfo.sql
-   Seeding database...
-   Warning: Using a password on the command line interface can be 
insecure.
+#. Use the ``reset`` and ``upgrade`` commands of the ``admin`` binary (see 
`Database Management`_ for usage) to set up the traffic_ops database(s).
+
+   .. code-block::shell
 
 Review comment:
   This is why you're not seeing this in the output. It's also why that Perl 
snippet isn't being rendered. `..` in RST starts a comment - as you probably 
know. Without the space between the `::` and the syntax name, the lexer detects 
that as just a plain word, not a directive. It needs to match `^\s*\.\. 
[\w\-]+:: .*$` to be considered a directive.
   
   tl;dr: you're missing a space after `::` and before `shell`.


This is an automated message from the Apache Git Service.
To respond to the message, please log on GitHub and use the
URL above to go to the specific comment.
 
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org


With regards,
Apache Git Services

[GitHub] ocket8888 commented on a change in pull request #3128: Updated documentation for the new Go db/admin binary

[GitBox]

ocket commented on a change in pull request #3128: Updated documentation 
for the new Go db/admin binary
URL: https://github.com/apache/trafficcontrol/pull/3128#discussion_r242308464
 
 

 ##
 File path: docs/source/development/traffic_ops.rst
 ##
 @@ -229,30 +229,12 @@ To install the Traffic Ops Developer environment:
.. seealso:: `PostgreSQL instructions on setting up a database 
`_.
 
 
-#. Use the ``setup`` command of the ``admin.pl`` script (see `Database 
Management`_ for usage) to set up the traffic_ops database(s).
-
-Example Output::
-
-   $ db/admin.pl --env=development setup
-   Using database.conf: conf/development/database.conf
-   Using database.conf: conf/development/database.conf
-   Using database.conf: conf/development/database.conf
-   Using database.conf: conf/development/database.conf
-   Using database.conf: conf/development/database.conf
-   Using database.conf: conf/development/database.conf
-   Executing 'drop database to_development'
-   Executing 'create database to_development'
-   Creating database tables...
-   Warning: Using a password on the command line interface can be 
insecure.
-   Migrating database...
-   goose: migrating db environment 'development', current version: 
0, target: 2015021010
-   OK20141222103718_extension.sql
-   OK2015010810_add_job_deliveryservice.sql
-   OK2015020510_cg_location.sql
-   OK2015020910_cran_to_asn.sql
-   OK2015021010_ds_keyinfo.sql
-   Seeding database...
-   Warning: Using a password on the command line interface can be 
insecure.
+#. Use the ``reset`` and ``upgrade`` commands of the ``admin`` binary (see 
`Database Management`_ for usage) to set up the traffic_ops database(s).
+
+   .. code-block::shell
 
 Review comment:
   This is why you're not seeing this in the output. It's also why that Perl 
snippet isn't being rendered. `..` in RST starts a comment - as you probably 
know. Without the space between the `::` and the syntax name, the lexer detects 
that as just a plain word, not a directive. It needs to match `^\s*\.\. 
[\w\-]+:: \s*.*$` to be considered a directive.
   
   tl;dr: you're missing a space after `::` and before `shell`.


This is an automated message from the Apache Git Service.
To respond to the message, please log on GitHub and use the
URL above to go to the specific comment.
 
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org


With regards,
Apache Git Services

[GitHub] asfgit commented on issue #3128: Updated documentation for the new Go db/admin binary

[GitBox]

asfgit commented on issue #3128: Updated documentation for the new Go db/admin 
binary
URL: https://github.com/apache/trafficcontrol/pull/3128#issuecomment-447996948
 
 
   
   Refer to this link for build results (access rights to CI server needed): 
   https://builds.apache.org/job/trafficcontrol-PR/2963/
   Test FAILed.
   


This is an automated message from the Apache Git Service.
To respond to the message, please log on GitHub and use the
URL above to go to the specific comment.
 
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org


With regards,
Apache Git Services

[GitHub] ocket8888 opened a new issue #3136: /api/1.4/cdns/name/{{name}}/dnsseckeys doesn't work

[GitBox]

ocket opened a new issue #3136: /api/1.4/cdns/name/{{name}}/dnsseckeys 
doesn't work
URL: https://github.com/apache/trafficcontrol/issues/3136
 
 
   This fails with an internal server error when requested with `GET` - the 
error message 
   ```
   ERROR: api.go:98: 2018-12-17T21:15:47.244252383Z: 172.16.239.1:60312 getting 
DS Record TTL: getting cdn 'CDN-in-a-Box' DS Record TTL from CRConfig: pq: 
column "content" does not exist
   ```
   is printed to the logs. Note this is after generating DNSSEC keys, if that 
matters.


This is an automated message from the Apache Git Service.
To respond to the message, please log on GitHub and use the
URL above to go to the specific comment.
 
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org


With regards,
Apache Git Services

[GitHub] rob05c opened a new pull request #3137: Fix TO query for crconfig column rename

[GitBox]

rob05c opened a new pull request #3137: Fix TO query for crconfig column rename
URL: https://github.com/apache/trafficcontrol/pull/3137
 
 
   Fixes #3136
   
    What does this PR do?
   
   Fixes #3136
   
    Which TC components are affected by this PR?
   
   - [ ] Documentation
   - [ ] Grove
   - [ ] Traffic Analytics
   - [ ] Traffic Monitor
   - [x] Traffic Ops
   - [ ] Traffic Ops ORT
   - [ ] Traffic Portal
   - [ ] Traffic Router
   - [ ] Traffic Stats
   - [ ] Traffic Vault
   - [ ] Other _
   
    What is the best way to verify this PR?
   
   Verify https://github.com/apache/trafficcontrol/issues/3136
   
    Check all that apply
   
   - [ ] This PR includes tests
   - [ ] This PR includes documentation updates
   - [ ] This PR includes an update to CHANGELOG.md
   - [ ] This PR includes all required license headers
   - [ ] This PR includes a database migration (ensure that migration sequence 
is correct)
   - [ ] This PR fixes a serious security flaw. Read more: 
[www.apache.org/security](http://www.apache.org/security/)
   
   
   
   
   
   


This is an automated message from the Apache Git Service.
To respond to the message, please log on GitHub and use the
URL above to go to the specific comment.
 
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org


With regards,
Apache Git Services

[GitHub] asfgit commented on issue #3137: Fix TO query for crconfig column rename

[GitBox]

asfgit commented on issue #3137: Fix TO query for crconfig column rename
URL: https://github.com/apache/trafficcontrol/pull/3137#issuecomment-448018410
 
 
   
   Refer to this link for build results (access rights to CI server needed): 
   https://builds.apache.org/job/trafficcontrol-PR/2964/
   Test FAILed.
   


This is an automated message from the Apache Git Service.
To respond to the message, please log on GitHub and use the
URL above to go to the specific comment.
 
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org


With regards,
Apache Git Services

[GitHub] rawlinp commented on issue #3128: Updated documentation for the new Go db/admin binary

[GitBox]

rawlinp commented on issue #3128: Updated documentation for the new Go db/admin 
binary
URL: https://github.com/apache/trafficcontrol/pull/3128#issuecomment-448057406
 
 
   @ocket ok, I believe everything is addressed, and the other code-block 
syntax errors I found have been fixed.


This is an automated message from the Apache Git Service.
To respond to the message, please log on GitHub and use the
URL above to go to the specific comment.
 
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org


With regards,
Apache Git Services

[GitHub] asfgit commented on issue #3128: Updated documentation for the new Go db/admin binary

[GitBox]

asfgit commented on issue #3128: Updated documentation for the new Go db/admin 
binary
URL: https://github.com/apache/trafficcontrol/pull/3128#issuecomment-448060325
 
 
   
   Refer to this link for build results (access rights to CI server needed): 
   https://builds.apache.org/job/trafficcontrol-PR/2965/
   Test FAILed.
   


This is an automated message from the Apache Git Service.
To respond to the message, please log on GitHub and use the
URL above to go to the specific comment.
 
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org


With regards,
Apache Git Services

[GitHub] mitchell852 commented on a change in pull request #3133: Added documentation guidelines

[GitBox]

mitchell852 commented on a change in pull request #3133: Added documentation 
guidelines
URL: https://github.com/apache/trafficcontrol/pull/3133#discussion_r242386210
 
 

 ##
 File path: docs/source/development/documentation_guidelines.rst
 ##
 @@ -0,0 +1,172 @@
+..
+..
+.. Licensed under the Apache License, Version 2.0 (the "License");
+.. you may not use this file except in compliance with the License.
+.. You may obtain a copy of the License at
+..
+.. http://www.apache.org/licenses/LICENSE-2.0
+..
+.. Unless required by applicable law or agreed to in writing, software
+.. distributed under the License is distributed on an "AS IS" BASIS,
+.. WITHOUT WARRANTIES OR CONDITIONS OF ANY KIND, either express or implied.
+.. See the License for the specific language governing permissions and
+.. limitations under the License.
+..
+
+.. _docs-guide:
+
+
+Documentation Guidelines
+
+The Apache Traffic Control documentation is written in :abbr:`RST 
(reStructuredText)` and uses the `Sphinx documentation build system 
`_ to convert these into the desired 
output document format. This collection of guidelines does **not** aim to be a 
primer in :abbr:`RST (reStructuredText)`, but merely a style guide regarding 
how the components of the document ought to be formatted and structured. It may 
also point out some features of the markup language of which a writer may not 
be aware.
+
+.. seealso:: `The docutils RST reference 
`_.
+
+Building
+
+To build the documentation, see :ref:`docs-build`.
+
+Writing
+===
+When writing documentation, the most important things to remember are:
+
+- Spell Check. Most text editors have this built in (e.g. "F6" in Sublime 
Text) or have plugins that will do this for you.
+- Proof-Read. Spell-checkers won't catch grammatical errors or poor wording, 
so it's very important to actually proof-read all documentation *before* 
submitting it in a Pull Request.
+- Make Sure the Documentation Actually Builds. Please actually verify the 
documentation not only builds, but builds *correctly*. That means there 
probably shouldn't be any warnings, no malformed tables etc. and it also means 
that new documentation is actually accessible once built. It's not enough to 
create a new ``.rst`` file, that file must actually be linked to from some 
other, already included document. Some warnings may be considered acceptable, 
but do be prepared to defend them.
+- Traffic Ops UI is Dead. Do not ever create documentation that references or 
includes images of the Traffic Ops UI. That is officially dead now, and if the 
documentation being created is best made with references to a user-friendly UI, 
such references, examples and/or images should all be to/of Traffic Portal.
+
+Formatting
+--
+Whenever possible, avoid specifying manual line breaks, except as required by 
:abbr:`RST (reStructuredText)` syntax. Extremely long lines will be wrapped by 
the user-agent, compiler, or output format as necessary. A single blank line 
may be used to separate paragraphs. This means that the 'flow break' character 
should never need to be used, i.e. no line in the documentation should ever 
match the regular expression ``^\|$``.
+
+Abbreviations
+"
+When using an abbreviation, acronym or initialism for the first time on a 
page, it **must** be named fully and followed by the abbreviation in 
parentheses e.g. "Fully Qualified Domain Name (FQDN)". Strictly speaking, the 
*best* way to create an abbreviation is to always fully name it in parentheses 
immediately following the abbreviation using the ``:abbr:`` :abbr:`RST 
(reStructuredText)` text role e.g. ``:abbr:`FQDN (Fully Qualified Domain 
Name)```, but it's not reasonable to expect that of everyone. Some 
abbreviations can be assumed to be understood by the documentation's target 
audience, and do not need full naming; they are:
+
+- DNS
+- HTTP
+- HTTPS
+- IP/IPv4/IPv6
+- TCP
+- UDP
+- URL
+- URI
+
+Please do **not** abbreviate Traffic Control terms e.g. Cache Group, Delivery 
Service. See `Terms`_ for the proper way to use these terms.
+
+Floating Objects
+
+"Floating objects" are images, tables, source code listings, and equations. 
These may not be placed relative to other content exactly as shown in the 
source :abbr:`RST (reStructuredText)` document, as it may be necessary to move 
them for e.g. page breaks in PDF documents so they are not split across pages.
+
+Figures
+'''
+Images should *always* be included inside of a ``.. figure`` directive. 
**Always** caption figures to make their purpose clear, as well as to make them 
directly link-able inside of the document and include them in figure listings. 
Figures should, in general be sized *explicitly* but not *absolutely* i.e. use 
``70%`` not ``540px``. Figures should, in general, be centered on the page. 
When 

[GitHub] Shihta opened a new issue #3138: CIAB Trafficmonitor shows a lot of "Request Error: ... service still starting, some caches unpolled"

[GitBox]

Shihta opened a new issue #3138: CIAB Trafficmonitor shows a lot of "Request 
Error: ... service still starting, some caches unpolled"
URL: https://github.com/apache/trafficcontrol/issues/3138
 
 
   I use the latest master branch for building docker images of CDN in a Box.
   After start all CIAB services, I can open Trafficmonitor webpage by access 
http://trafficmonitor.infra.ciab.test/.
   The figure is shown as follows:
   ![2018-12-18 10 34 
23](https://user-images.githubusercontent.com/5186176/50129151-b4aa3a80-02b2-11e9-91b6-f8dd2be62db6.png)
   
   However, there are a lot of error messages in the docker log of 
Trafficmonitor.
   I use "docker logs -f CONTAINER_ID" to get Trafficmonitor logs and the 
figure is shown as follows:
   ![2018-12-18 10 34 
31](https://user-images.githubusercontent.com/5186176/50129158-bb38b200-02b2-11e9-8e81-89c0607f0707.png)
   
   That might be the root cause that Trafficroter not work.
   Any idea?


This is an automated message from the Apache Git Service.
To respond to the message, please log on GitHub and use the
URL above to go to the specific comment.
 
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org


With regards,
Apache Git Services

[GitHub] Shihta commented on issue #3126: Removed unnecessary http-parser dependency

[GitBox]

Shihta commented on issue #3126: Removed unnecessary http-parser dependency
URL: https://github.com/apache/trafficcontrol/pull/3126#issuecomment-448080689
 
 
   I think it's the same issue as #3131 and it has fixed.
   
   My screenshot is shown as follows:
   ![2018-12-18 10 59 
15](https://user-images.githubusercontent.com/5186176/50129636-defcf780-02b4-11e9-9ea7-847176ae98f1.png)
   
   Thanks!


This is an automated message from the Apache Git Service.
To respond to the message, please log on GitHub and use the
URL above to go to the specific comment.
 
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org


With regards,
Apache Git Services

[GitHub] dangogh commented on issue #3126: Removed unnecessary http-parser dependency

[GitBox]

dangogh commented on issue #3126: Removed unnecessary http-parser dependency
URL: https://github.com/apache/trafficcontrol/pull/3126#issuecomment-448082895
 
 
   ok -- not caused by this change, but by an upstream change..
   
   Duplicate of #3131


This is an automated message from the Apache Git Service.
To respond to the message, please log on GitHub and use the
URL above to go to the specific comment.
 
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org


With regards,
Apache Git Services

[GitHub] ocket8888 commented on issue #3136: /api/1.4/cdns/name/{{name}}/dnsseckeys doesn't work

[GitBox]

ocket commented on issue #3136: /api/1.4/cdns/name/{{name}}/dnsseckeys 
doesn't work
URL: https://github.com/apache/trafficcontrol/issues/3136#issuecomment-448248509
 
 
   This may be a CDN-in-a-Box-specific issue


This is an automated message from the Apache Git Service.
To respond to the message, please log on GitHub and use the
URL above to go to the specific comment.
 
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org


With regards,
Apache Git Services

[GitHub] ocket8888 removed a comment on issue #3136: /api/1.4/cdns/name/{{name}}/dnsseckeys doesn't work

[GitBox]

ocket removed a comment on issue #3136: 
/api/1.4/cdns/name/{{name}}/dnsseckeys doesn't work
URL: https://github.com/apache/trafficcontrol/issues/3136#issuecomment-448248509
 
 
   This may be a CDN-in-a-Box-specific issue


This is an automated message from the Apache Git Service.
To respond to the message, please log on GitHub and use the
URL above to go to the specific comment.
 
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org


With regards,
Apache Git Services

[GitHub] dneuman64 closed pull request #3128: Updated documentation for the new Go db/admin binary

[GitBox]

dneuman64 closed pull request #3128: Updated documentation for the new Go 
db/admin binary
URL: https://github.com/apache/trafficcontrol/pull/3128
 
 
   

This is a PR merged from a forked repository.
As GitHub hides the original diff on merge, it is displayed below for
the sake of provenance:

As this is a foreign pull request (from a fork), the diff is supplied
below (as it won't show otherwise due to GitHub magic):

diff --git a/CHANGELOG.md b/CHANGELOG.md
index 5b07ecba4..49863ea54 100644
--- a/CHANGELOG.md
+++ b/CHANGELOG.md
@@ -15,6 +15,7 @@ The format is based on [Keep a 
Changelog](http://keepachangelog.com/en/1.0.0/).
   - /api/1.1/cdns/name/:name/dnsseckeys `GET`
   - /api/1.4/cdns/name/:name/dnsseckeys `GET`
 - To support reusing a single riak cluster connection, an optional parameter 
is added to riak.conf: "HealthCheckInterval". This options takes a 'Duration' 
value (ie: 10s, 5m) which affects how often the riak cluster is health checked. 
 Default is currently set to: "HealthCheckInterval": "5s".
+- Added a new Go db/admin binary to replace the Perl db/admin.pl script which 
is now deprecated and will be removed in a future release. The new db/admin 
binary is essentially a drop-in replacement for db/admin.pl since it supports 
all of the same commands and options; therefore, it should be used in place of 
db/admin.pl for all the same tasks.
 - Added an API 1.4 endpoint, /api/1.4/cdns/dnsseckeys/refresh, to perform 
necessary behavior previously served outside the API under `/internal`.
 - Adds the DS Record text to the cdn dnsseckeys endpoint in 1.4.
 - Added monitoring.json snapshotting. This stores the monitoring json in the 
same table as the crconfig snapshot. Snapshotting is now required in order to 
push out monitoring changes.
diff --git a/docs/source/admin/traffic_ops/installation.rst 
b/docs/source/admin/traffic_ops/installation.rst
index 6e09bde0a..518dc3bf1 100644
--- a/docs/source/admin/traffic_ops/installation.rst
+++ b/docs/source/admin/traffic_ops/installation.rst
@@ -238,7 +238,7 @@ To upgrade from older Traffic Ops versions, run the 
following commands as the ro
systemctl stop traffic_ops
yum upgrade traffic_ops
pushd /opt/traffic_ops/app/
-   
PERL5LIB=/opt/traffic_ops/app/lib:/opt/traffic_ops/app/local/lib/perl5 
./db/admin.pl --env production upgrade
+   ./db/admin --env production upgrade
 
 After this completes, see :ref:`to-install` to run the ``postinstall`` script.
 Once the ``postinstall`` script, has finished, run the following command as 
the root user (or with ``sudo``):
diff --git a/docs/source/api/federations.rst b/docs/source/api/federations.rst
index aa771734a..1ce319ae6 100644
--- a/docs/source/api/federations.rst
+++ b/docs/source/api/federations.rst
@@ -97,7 +97,7 @@ Request Structure
:resolve4: An array of IPv4 addresses that can resolve the 
Delivery Service's federation
:resolve6: An array of IPv6 addresses that can resolve the 
Delivery Service's federation
 
-.. code-block::http
+.. code-block:: http
:caption: Request Example
 
POST /api/1.1/federations HTTP/1.1
diff --git a/docs/source/development/traffic_ops.rst 
b/docs/source/development/traffic_ops.rst
index de9484c92..ecbecd7a1 100644
--- a/docs/source/development/traffic_ops.rst
+++ b/docs/source/development/traffic_ops.rst
@@ -129,7 +129,7 @@ Perl Formatting Conventions
 ===
 `Perltidy `_ is for use in code formatting.
 
-.. code-block::perl
+.. code-block:: perl
:caption: Example Perltidy Configuration (usually in ``~/.perltidyrc``)
 
-l=156
@@ -155,11 +155,11 @@ Perl Formatting Conventions
 
 Database Management
 ===
-The ``app/db/admin.pl`` script is for use in managing the Traffic Ops database 
tables. This essentially serves as a front-end for `Goose 
`_ Below is an example of its usage.
+The ``app/db/admin`` binary is for use in managing the Traffic Ops database 
tables. This essentially serves as a front-end for `Goose 
`_ Below is an example of its usage.
 
-.. note:: For proper resolution of Perl library paths and SOL statement files, 
it's recommended that this script be run from the ``app`` directory
+.. note:: For proper resolution of configuration and SOL statement files, it's 
recommended that this binary be run from the ``app`` directory
 
-``db/admin.pl [options] command``
+``db/admin [options] command``
 
 Options:
 
@@ -202,12 +202,12 @@ status
 upgrade
Performs a migration on the database for the current environment, then 
seeds it and patches it using the SQL statements from the 
``app/db/patches.sql`` file
 
-.. code-block::bash
+.. code-block:: bash
:caption: Example Usage
 
-   db/admin.pl --env=test reset
+   db/admin --env=test reset
 
-The environments are de

[GitHub] asfgit commented on issue #3134: Added an explanation of the format and structure of API endpoint docs

[GitBox]

asfgit commented on issue #3134: Added an explanation of the format and 
structure of API endpoint docs
URL: https://github.com/apache/trafficcontrol/pull/3134#issuecomment-448279663
 
 
   
   Refer to this link for build results (access rights to CI server needed): 
   https://builds.apache.org/job/trafficcontrol-PR/2966/
   Test PASSed.
   


This is an automated message from the Apache Git Service.
To respond to the message, please log on GitHub and use the
URL above to go to the specific comment.
 
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org


With regards,
Apache Git Services

[GitHub] ocket8888 commented on a change in pull request #3133: Added documentation guidelines

[GitBox]

ocket commented on a change in pull request #3133: Added documentation 
guidelines
URL: https://github.com/apache/trafficcontrol/pull/3133#discussion_r242607238
 
 

 ##
 File path: docs/source/development/documentation_guidelines.rst
 ##
 @@ -0,0 +1,172 @@
+..
+..
+.. Licensed under the Apache License, Version 2.0 (the "License");
+.. you may not use this file except in compliance with the License.
+.. You may obtain a copy of the License at
+..
+.. http://www.apache.org/licenses/LICENSE-2.0
+..
+.. Unless required by applicable law or agreed to in writing, software
+.. distributed under the License is distributed on an "AS IS" BASIS,
+.. WITHOUT WARRANTIES OR CONDITIONS OF ANY KIND, either express or implied.
+.. See the License for the specific language governing permissions and
+.. limitations under the License.
+..
+
+.. _docs-guide:
+
+
+Documentation Guidelines
+
+The Apache Traffic Control documentation is written in :abbr:`RST 
(reStructuredText)` and uses the `Sphinx documentation build system 
`_ to convert these into the desired 
output document format. This collection of guidelines does **not** aim to be a 
primer in :abbr:`RST (reStructuredText)`, but merely a style guide regarding 
how the components of the document ought to be formatted and structured. It may 
also point out some features of the markup language of which a writer may not 
be aware.
+
+.. seealso:: `The docutils RST reference 
`_.
+
+Building
+
+To build the documentation, see :ref:`docs-build`.
+
+Writing
+===
+When writing documentation, the most important things to remember are:
+
+- Spell Check. Most text editors have this built in (e.g. "F6" in Sublime 
Text) or have plugins that will do this for you.
+- Proof-Read. Spell-checkers won't catch grammatical errors or poor wording, 
so it's very important to actually proof-read all documentation *before* 
submitting it in a Pull Request.
+- Make Sure the Documentation Actually Builds. Please actually verify the 
documentation not only builds, but builds *correctly*. That means there 
probably shouldn't be any warnings, no malformed tables etc. and it also means 
that new documentation is actually accessible once built. It's not enough to 
create a new ``.rst`` file, that file must actually be linked to from some 
other, already included document. Some warnings may be considered acceptable, 
but do be prepared to defend them.
+- Traffic Ops UI is Dead. Do not ever create documentation that references or 
includes images of the Traffic Ops UI. That is officially dead now, and if the 
documentation being created is best made with references to a user-friendly UI, 
such references, examples and/or images should all be to/of Traffic Portal.
+
+Formatting
+--
+Whenever possible, avoid specifying manual line breaks, except as required by 
:abbr:`RST (reStructuredText)` syntax. Extremely long lines will be wrapped by 
the user-agent, compiler, or output format as necessary. A single blank line 
may be used to separate paragraphs. This means that the 'flow break' character 
should never need to be used, i.e. no line in the documentation should ever 
match the regular expression ``^\|$``.
+
+Abbreviations
+"
+When using an abbreviation, acronym or initialism for the first time on a 
page, it **must** be named fully and followed by the abbreviation in 
parentheses e.g. "Fully Qualified Domain Name (FQDN)". Strictly speaking, the 
*best* way to create an abbreviation is to always fully name it in parentheses 
immediately following the abbreviation using the ``:abbr:`` :abbr:`RST 
(reStructuredText)` text role e.g. ``:abbr:`FQDN (Fully Qualified Domain 
Name)```, but it's not reasonable to expect that of everyone. Some 
abbreviations can be assumed to be understood by the documentation's target 
audience, and do not need full naming; they are:
+
+- DNS
+- HTTP
+- HTTPS
+- IP/IPv4/IPv6
+- TCP
+- UDP
+- URL
+- URI
+
+Please do **not** abbreviate Traffic Control terms e.g. Cache Group, Delivery 
Service. See `Terms`_ for the proper way to use these terms.
+
+Floating Objects
+
+"Floating objects" are images, tables, source code listings, and equations. 
These may not be placed relative to other content exactly as shown in the 
source :abbr:`RST (reStructuredText)` document, as it may be necessary to move 
them for e.g. page breaks in PDF documents so they are not split across pages.
+
+Figures
+'''
+Images should *always* be included inside of a ``.. figure`` directive. 
**Always** caption figures to make their purpose clear, as well as to make them 
directly link-able inside of the document and include them in figure listings. 
Figures should, in general be sized *explicitly* but not *absolutely* i.e. use 
``70%`` not ``540px``. Figures should, in general, be centered on the page. 
When dr

[GitHub] jrushford opened a new issue #3139: grove: errors - "request method or response status code does not allow body"

[GitBox]

jrushford opened a new issue #3139: grove: errors - "request method or response 
status code does not allow body"
URL: https://github.com/apache/trafficcontrol/issues/3139
 
 
   Monitoring the Colorado Springs trial servers and am see messages like this 
in the error.log:
   
   "ERROR: handler.go:319:  responding: http: request method or response 
status code does not allow body"
   
   I do not believe they are causing any player issues as I've monitored the 
channels and see no issue with playback.  The requests are GET requests and  I 
believe that they may be conditional GET requests with an If-Modified-Since 
header and that the response may be a 304 with a body.  Not 100 % certain 
though as the requests are over SSL and the error message does not log the 
response code.  
   
   I will add some additional debugging so that it does log the response code 
and am trying to duplicate this in the lab for further analysis.


This is an automated message from the Apache Git Service.
To respond to the message, please log on GitHub and use the
URL above to go to the specific comment.
 
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org


With regards,
Apache Git Services

[GitHub] asfgit commented on issue #3133: Added documentation guidelines

[GitBox]

asfgit commented on issue #3133: Added documentation guidelines
URL: https://github.com/apache/trafficcontrol/pull/3133#issuecomment-448287194
 
 
   
   Refer to this link for build results (access rights to CI server needed): 
   https://builds.apache.org/job/trafficcontrol-PR/2967/
   Test PASSed.
   


This is an automated message from the Apache Git Service.
To respond to the message, please log on GitHub and use the
URL above to go to the specific comment.
 
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org


With regards,
Apache Git Services

[GitHub] asfgit commented on issue #3133: Added documentation guidelines

[GitBox]

asfgit commented on issue #3133: Added documentation guidelines
URL: https://github.com/apache/trafficcontrol/pull/3133#issuecomment-448294054
 
 
   
   Refer to this link for build results (access rights to CI server needed): 
   https://builds.apache.org/job/trafficcontrol-PR/2968/
   Test PASSed.
   


This is an automated message from the Apache Git Service.
To respond to the message, please log on GitHub and use the
URL above to go to the specific comment.
 
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org


With regards,
Apache Git Services

[GitHub] traeak opened a new pull request #3140: Add traffic_ops_ort.pl suuport for processing ##OVERRIDE## lines from…

[GitBox]

traeak opened a new pull request #3140: Add traffic_ops_ort.pl suuport for 
processing ##OVERRIDE## lines from…
URL: https://github.com/apache/trafficcontrol/pull/3140
 
 
   fix to require space after ##OVERRIDE## keyword
   
    What does this PR do?
   
   Fixes #(issue_number)
   
    Which TC components are affected by this PR?
   
   - [ ] Documentation
   - [ ] Grove
   - [ ] Traffic Analytics
   - [ ] Traffic Monitor
   - [ ] Traffic Ops
   - [x] Traffic Ops ORT
   - [ ] Traffic Portal
   - [ ] Traffic Router
   - [ ] Traffic Stats
   - [ ] Traffic Vault
   - [ ] Other _
   
    What is the best way to verify this PR?
   
   Select any existing base DS.  Create ANY_MAP delivery service to override.
   Create raw remap text with something like:
   
   Short example:
   
   ##OVERRIDE## map http://from.foo http://to.bar 
   
   Make sure both the base DS and ANY_MAP are assigned to a server.  run ORT in 
report mode to check that the ##OVERRIDE## rule is uncommented and that the 
base DS rule is commented out via ##OVERRIDDEN##.
   
   Select to queue that particular server.  Inspect the generated remap.config 
for the above conditions.
   Select to queue again.  Ensure that remap.config is not tagged as changed to 
avoid unnecessary config reloads.
   
    Check all that apply
   
   - [ ] This PR includes tests
   - [ ] This PR includes documentation updates
   - [x] This PR includes an update to CHANGELOG.md
   - [ ] This PR includes all required license headers
   - [ ] This PR includes a database migration (ensure that migration sequence 
is correct)
   - [ ] This PR fixes a serious security flaw. Read more: 
[www.apache.org/security](http://www.apache.org/security/)
   
   
   
   
   
   


This is an automated message from the Apache Git Service.
To respond to the message, please log on GitHub and use the
URL above to go to the specific comment.
 
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org


With regards,
Apache Git Services

[GitHub] asfgit commented on issue #3140: Add traffic_ops_ort.pl suuport for processing ##OVERRIDE## lines from…

[GitBox]

asfgit commented on issue #3140: Add traffic_ops_ort.pl suuport for processing 
##OVERRIDE## lines from…
URL: https://github.com/apache/trafficcontrol/pull/3140#issuecomment-448309675
 
 
   Can one of the admins verify this patch?


This is an automated message from the Apache Git Service.
To respond to the message, please log on GitHub and use the
URL above to go to the specific comment.
 
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org


With regards,
Apache Git Services

[GitHub] jrushford opened a new pull request #3141: Add additional response code information in responder.go.

[GitBox]

jrushford opened a new pull request #3141: Add additional response code 
information in responder.go.
URL: https://github.com/apache/trafficcontrol/pull/3141
 
 
   This would help with issue 3139.
   
    What does this PR do?
   Adds additional information in a log message to help in troubleshooting 
#3139 
   Fixes #(issue_number)
   helps in troubleshooting #3139 
    Which TC components are affected by this PR?
   
   - [ ] Documentation
   - [X] Grove
   - [ ] Traffic Analytics
   - [ ] Traffic Monitor
   - [ ] Traffic Ops
   - [ ] Traffic Ops ORT
   - [ ] Traffic Portal
   - [ ] Traffic Router
   - [ ] Traffic Stats
   - [ ] Traffic Vault
   - [ ] Other _
   
    What is the best way to verify this PR?
   
   
    Check all that apply
   
   - [ ] This PR includes tests
   - [ ] This PR includes documentation updates
   - [ ] This PR includes an update to CHANGELOG.md
   - [ ] This PR includes all required license headers
   - [ ] This PR includes a database migration (ensure that migration sequence 
is correct)
   - [ ] This PR fixes a serious security flaw. Read more: 
[www.apache.org/security](http://www.apache.org/security/)
   
   
   
   
   
   


This is an automated message from the Apache Git Service.
To respond to the message, please log on GitHub and use the
URL above to go to the specific comment.
 
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org


With regards,
Apache Git Services

[GitHub] asfgit commented on issue #3141: Add additional response code information in responder.go.

[GitBox]

asfgit commented on issue #3141: Add additional response code information in 
responder.go.
URL: https://github.com/apache/trafficcontrol/pull/3141#issuecomment-448313691
 
 
   
   Refer to this link for build results (access rights to CI server needed): 
   https://builds.apache.org/job/trafficcontrol-PR/2969/
   Test FAILed.
   


This is an automated message from the Apache Git Service.
To respond to the message, please log on GitHub and use the
URL above to go to the specific comment.
 
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org


With regards,
Apache Git Services

[GitHub] ocket8888 opened a new pull request #3142: Configuration file route generation script now works with restructured ATC client

[GitBox]

ocket opened a new pull request #3142: Configuration file route generation 
script now works with restructured ATC client
URL: https://github.com/apache/trafficcontrol/pull/3142
 
 
   ## What does this PR do?
   Recent changes to the ATC client broke the convoluted import mechanisms 
employed by the genRoutesConfig.py script. This fixes it.
   
   ## Which TC components are affected by this PR?
   
   - [ ] Documentation
   - [ ] Grove
   - [ ] Traffic Analytics
   - [ ] Traffic Monitor
   - [ ] Traffic Ops
   - [ ] Traffic Ops ORT
   - [ ] Traffic Portal
   - [ ] Traffic Router
   - [ ] Traffic Stats
   - [ ] Traffic Vault
   - [x] genRoutesConfig.py
   
   ## What is the best way to verify this PR?
   Use `genRoutesConfig.py` to generate config file routes for two running 
traffic ops instances pointed at the same database (or using the same data). 
See [the 
documentation](https://traffic-control-cdn.readthedocs.io/en/latest/tools/compare.html#genconfigroutes-py)
 for details.
   
    Check all that apply
   
   - [ ] This PR includes tests
   - [ ] This PR includes documentation updates
   - [ ] This PR includes an update to CHANGELOG.md
   - [ ] This PR includes all required license headers
   - [ ] This PR includes a database migration (ensure that migration sequence 
is correct)
   - [ ] This PR fixes a serious security flaw. Read more: 
[www.apache.org/security](http://www.apache.org/security/)
   
   
   
   
   
   


This is an automated message from the Apache Git Service.
To respond to the message, please log on GitHub and use the
URL above to go to the specific comment.
 
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org


With regards,
Apache Git Services

[GitHub] asfgit commented on issue #3142: Configuration file route generation script now works with restructured ATC client

[GitBox]

asfgit commented on issue #3142: Configuration file route generation script now 
works with restructured ATC client
URL: https://github.com/apache/trafficcontrol/pull/3142#issuecomment-448353999
 
 
   
   Refer to this link for build results (access rights to CI server needed): 
   https://builds.apache.org/job/trafficcontrol-PR/2970/
   Test PASSed.
   


This is an automated message from the Apache Git Service.
To respond to the message, please log on GitHub and use the
URL above to go to the specific comment.
 
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org


With regards,
Apache Git Services

[GitHub] mitchell852 closed pull request #3142: Configuration file route generation script now works with restructured ATC client

[GitBox]

mitchell852 closed pull request #3142: Configuration file route generation 
script now works with restructured ATC client
URL: https://github.com/apache/trafficcontrol/pull/3142
 
 
   

This is a PR merged from a forked repository.
As GitHub hides the original diff on merge, it is displayed below for
the sake of provenance:

As this is a foreign pull request (from a fork), the diff is supplied
below (as it won't show otherwise due to GitHub magic):

diff --git a/traffic_ops/testing/compare/genConfigRoutes.py 
b/traffic_ops/testing/compare/genConfigRoutes.py
index 35d414d3f..7317ba433 100755
--- a/traffic_ops/testing/compare/genConfigRoutes.py
+++ b/traffic_ops/testing/compare/genConfigRoutes.py
@@ -36,17 +36,16 @@
 
 #: An absolute path to the Traffic Ops python packages (This assumes that the 
script is run from
 #: within the repository's normal directory structure)
-TO_LIBS_PATH = os.path.join(ROOT, "traffic_control", "clients", "python", 
"trafficops")
+TO_LIBS_PATH = os.path.join(ROOT, "traffic_control", "clients", "python") 
 
 sys.path.insert(0, TO_LIBS_PATH)
-sys.path.insert(0, os.path.join(TO_LIBS_PATH, "trafficops"))
 from trafficops.tosession import TOSession
-from common.restapi import LoginError, OperationError, InvalidJSONError
+from trafficops.restapi import LoginError, OperationError, InvalidJSONError
 
 #: A format specifier for logging output. Propagates to all imported modules.
 LOG_FMT = "%(levelname)s: %(asctime)s line %(lineno)d in 
%(module)s.%(funcName)s: %(message)s"
 
-__version__ = "2.0.0"
+__version__ = "2.0.0-1"
 
 def getConfigRoutesForServers(servers:typing.List[dict], inst:TOSession) \
-> 
typing.Generator[str, None, None]:
@@ -62,7 +61,7 @@ def getConfigRoutesForServers(servers:typing.List[dict], 
inst:TOSession) \
for server in servers:
try:
yield "/api/1.3/servers/%s/configfiles/ats" % 
server.hostName
-   for file in 
inst.getServerConfigFiles(servername=server.hostName)[0].configFiles:
+   for file in 
inst.get_server_config_files(host_name=server.hostName)[0].configFiles:
if "apiUri" in file:
yield file.apiUri
else:


 


This is an automated message from the Apache Git Service.
To respond to the message, please log on GitHub and use the
URL above to go to the specific comment.
 
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org


With regards,
Apache Git Services

[GitHub] jrushford commented on issue #3141: Add additional response code information in responder.go.

[GitBox]

jrushford commented on issue #3141: Add additional response code information in 
responder.go.
URL: https://github.com/apache/trafficcontrol/pull/3141#issuecomment-448377939
 
 
   retest this please


This is an automated message from the Apache Git Service.
To respond to the message, please log on GitHub and use the
URL above to go to the specific comment.
 
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org


With regards,
Apache Git Services

[GitHub] asfgit commented on issue #3141: Add additional response code information in responder.go.

[GitBox]

asfgit commented on issue #3141: Add additional response code information in 
responder.go.
URL: https://github.com/apache/trafficcontrol/pull/3141#issuecomment-448379647
 
 
   
   Refer to this link for build results (access rights to CI server needed): 
   https://builds.apache.org/job/trafficcontrol-PR/2971/
   Test PASSed.
   


This is an automated message from the Apache Git Service.
To respond to the message, please log on GitHub and use the
URL above to go to the specific comment.
 
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org


With regards,
Apache Git Services

[GitHub] rawlinp opened a new pull request #3143: Fix improper file slurping in Perl

[GitBox]

rawlinp opened a new pull request #3143: Fix improper file slurping in Perl
URL: https://github.com/apache/trafficcontrol/pull/3143
 
 
    What does this PR do?
   
   The proper way to enable slurp mode is by doing `local $/;`. When you do
   `undef $/` it is undefining the global `$/` input record separator which
   is bad and can cause a multitude of problems. Using the `local` version
   only nullifies the input record separator locally in order to enable
   slurp mode in that particular function rather than changing it globally.
   
    Which TC components are affected by this PR?
   
   - [ ] Documentation
   - [ ] Grove
   - [ ] Traffic Analytics
   - [ ] Traffic Monitor
   - [x] Traffic Ops
   - [ ] Traffic Ops ORT
   - [ ] Traffic Portal
   - [ ] Traffic Router
   - [ ] Traffic Stats
   - [ ] Traffic Vault
   - [ ] Other _
   
    What is the best way to verify this PR?
   Hit the `POST /api/$version/isos?stream=yes` endpoint. This can be done in 
Traffic Portal, just make sure to set stream=yes in order to hit the changed 
code. I'm not sure how to really verify `parse_retention_period_in_seconds` 
since I can't find anywhere in the code that actually uses that function. The 
GenDbDump change isn't really verifiable anymore since it's a UI endpoint, but 
this should cover our bases in case it is being used in some obscure way by a 
non-UI endpoint.
   
    Check all that apply
   
   - [ ] This PR includes tests
   - [ ] This PR includes documentation updates
   - [ ] This PR includes an update to CHANGELOG.md
   - [ ] This PR includes all required license headers
   - [ ] This PR includes a database migration (ensure that migration sequence 
is correct)
   - [ ] This PR fixes a serious security flaw. Read more: 
[www.apache.org/security](http://www.apache.org/security/)
   
   
   
   
   
   


This is an automated message from the Apache Git Service.
To respond to the message, please log on GitHub and use the
URL above to go to the specific comment.
 
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org


With regards,
Apache Git Services

[GitHub] rob05c opened a new pull request #3144: Fix Traffic Ops POST cachegroups/{id}/deliveryservices to return tenancy error instead of 500

[GitBox]

rob05c opened a new pull request #3144: Fix Traffic Ops POST 
cachegroups/{id}/deliveryservices to return tenancy error instead of 500
URL: https://github.com/apache/trafficcontrol/pull/3144
 
 
    What does this PR do?
   
   Fix Traffic Ops POST cachegroups/{id}/deliveryservices to return tenancy 
error instead of 500
   
    Which TC components are affected by this PR?
   
   - [ ] Documentation
   - [ ] Grove
   - [ ] Traffic Analytics
   - [ ] Traffic Monitor
   - [x] Traffic Ops
   - [ ] Traffic Ops ORT
   - [ ] Traffic Portal
   - [ ] Traffic Router
   - [ ] Traffic Stats
   - [ ] Traffic Vault
   - [ ] Other _
   
    What is the best way to verify this PR?
   
   `POST cachegroups/{id}/deliveryservices` to a delivery service your user's 
tenant doesn't isn't authorized for. Verify a `403 Forbidden` with message `not 
authorized for delivery service tenant x` is returned, not a 5xx with no 
message.
   
    Check all that apply
   
   - [ ] This PR includes tests
   - [ ] This PR includes documentation updates
   - [ ] This PR includes an update to CHANGELOG.md
   - [ ] This PR includes all required license headers
   - [ ] This PR includes a database migration (ensure that migration sequence 
is correct)
   - [ ] This PR fixes a serious security flaw. Read more: 
[www.apache.org/security](http://www.apache.org/security/)
   
   
   
   
   
   


This is an automated message from the Apache Git Service.
To respond to the message, please log on GitHub and use the
URL above to go to the specific comment.
 
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org


With regards,
Apache Git Services

[GitHub] asfgit commented on issue #3144: Fix Traffic Ops POST cachegroups/{id}/deliveryservices to return tenancy error instead of 500

[GitBox]

asfgit commented on issue #3144: Fix Traffic Ops POST 
cachegroups/{id}/deliveryservices to return tenancy error instead of 500
URL: https://github.com/apache/trafficcontrol/pull/3144#issuecomment-448405792
 
 
   
   Refer to this link for build results (access rights to CI server needed): 
   https://builds.apache.org/job/trafficcontrol-PR/2972/
   Test PASSed.
   


This is an automated message from the Apache Git Service.
To respond to the message, please log on GitHub and use the
URL above to go to the specific comment.
 
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org


With regards,
Apache Git Services

[GitHub] asfgit commented on issue #3143: Fix improper file slurping in Perl

[GitBox]

asfgit commented on issue #3143: Fix improper file slurping in Perl
URL: https://github.com/apache/trafficcontrol/pull/3143#issuecomment-448406772
 
 
   
   Refer to this link for build results (access rights to CI server needed): 
   https://builds.apache.org/job/trafficcontrol-PR/2973/
   Test FAILed.
   


This is an automated message from the Apache Git Service.
To respond to the message, please log on GitHub and use the
URL above to go to the specific comment.
 
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org


With regards,
Apache Git Services

[GitHub] dangogh closed pull request #3143: Fix improper file slurping in Perl

[GitBox]

dangogh closed pull request #3143: Fix improper file slurping in Perl
URL: https://github.com/apache/trafficcontrol/pull/3143
 
 
   

This is a PR merged from a forked repository.
As GitHub hides the original diff on merge, it is displayed below for
the sake of provenance:

As this is a foreign pull request (from a fork), the diff is supplied
below (as it won't show otherwise due to GitHub magic):

diff --git a/traffic_ops/app/lib/API/Iso.pm b/traffic_ops/app/lib/API/Iso.pm
index 4fe98d853..97d8f109c 100644
--- a/traffic_ops/app/lib/API/Iso.pm
+++ b/traffic_ops/app/lib/API/Iso.pm
@@ -270,7 +270,7 @@ sub generate_iso {
}
 
# slurp it in..
-   undef $/;
+   local $/;
$data = <$fh>;
 
close $fh;
diff --git 
a/traffic_ops/app/lib/Extensions/TrafficStats/Helper/InfluxResponse.pm 
b/traffic_ops/app/lib/Extensions/TrafficStats/Helper/InfluxResponse.pm
index f4aaf5cca..2b5a4dab5 100644
--- a/traffic_ops/app/lib/Extensions/TrafficStats/Helper/InfluxResponse.pm
+++ b/traffic_ops/app/lib/Extensions/TrafficStats/Helper/InfluxResponse.pm
@@ -36,7 +36,7 @@ sub parse_retention_period_in_seconds {
my $self = shift;
my $retention_period = shift;
 
-   undef $/;
+   local $/;
 
my ( $hour, $minutes, $seconds ) = $retention_period =~ 
/(\d*)h(\d*)m(\d*)s/ms;
 
diff --git a/traffic_ops/app/lib/UI/GenDbDump.pm 
b/traffic_ops/app/lib/UI/GenDbDump.pm
index 6d2b14a73..3e832416d 100644
--- a/traffic_ops/app/lib/UI/GenDbDump.pm
+++ b/traffic_ops/app/lib/UI/GenDbDump.pm
@@ -40,7 +40,7 @@ sub dbdump {
}
 
# slurp it in..
-   undef $/;
+   local $/;
my $data = <$fh>;
 
 


 


This is an automated message from the Apache Git Service.
To respond to the message, please log on GitHub and use the
URL above to go to the specific comment.
 
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org


With regards,
Apache Git Services

[GitHub] rawlinp closed issue #3136: /api/1.4/cdns/name/{{name}}/dnsseckeys doesn't work

[GitBox]

rawlinp closed issue #3136: /api/1.4/cdns/name/{{name}}/dnsseckeys doesn't work
URL: https://github.com/apache/trafficcontrol/issues/3136
 
 
   


This is an automated message from the Apache Git Service.
To respond to the message, please log on GitHub and use the
URL above to go to the specific comment.
 
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org


With regards,
Apache Git Services

[GitHub] rawlinp closed pull request #3137: Fix TO query for crconfig column rename

[GitBox]

rawlinp closed pull request #3137: Fix TO query for crconfig column rename
URL: https://github.com/apache/trafficcontrol/pull/3137
 
 
   

This is a PR merged from a forked repository.
As GitHub hides the original diff on merge, it is displayed below for
the sake of provenance:

As this is a foreign pull request (from a fork), the diff is supplied
below (as it won't show otherwise due to GitHub magic):

diff --git a/traffic_ops/traffic_ops_golang/cdn/dnssec.go 
b/traffic_ops/traffic_ops_golang/cdn/dnssec.go
index bfd019597..446ef5a7c 100644
--- a/traffic_ops/traffic_ops_golang/cdn/dnssec.go
+++ b/traffic_ops/traffic_ops_golang/cdn/dnssec.go
@@ -121,7 +121,7 @@ func GetDNSSECKeysV11(w http.ResponseWriter, r 
*http.Request) {
 
 func GetDSRecordTTL(tx *sql.Tx, cdn string) (time.Duration, error) {
ttlSeconds := 0
-   if err := tx.QueryRow(`SELECT JSON_EXTRACT_PATH_TEXT(content, 'config', 
'ttls', 'DS') FROM snapshot WHERE cdn = $1`, cdn).Scan(&ttlSeconds); err != nil 
{
+   if err := tx.QueryRow(`SELECT JSON_EXTRACT_PATH_TEXT(crconfig, 
'config', 'ttls', 'DS') FROM snapshot WHERE cdn = $1`, cdn).Scan(&ttlSeconds); 
err != nil {
return 0, errors.New("getting cdn '" + cdn + "' DS Record TTL 
from CRConfig: " + err.Error())
}
return time.Duration(ttlSeconds) * time.Second, nil


 


This is an automated message from the Apache Git Service.
To respond to the message, please log on GitHub and use the
URL above to go to the specific comment.
 
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org


With regards,
Apache Git Services

[GitHub] rawlinp closed pull request #3141: Add additional response code information in responder.go.

[GitBox]

rawlinp closed pull request #3141: Add additional response code information in 
responder.go.
URL: https://github.com/apache/trafficcontrol/pull/3141
 
 
   

This is a PR merged from a forked repository.
As GitHub hides the original diff on merge, it is displayed below for
the sake of provenance:

As this is a foreign pull request (from a fork), the diff is supplied
below (as it won't show otherwise due to GitHub magic):

diff --git a/grove/cache/responder.go b/grove/cache/responder.go
index 60b9b39a9..929f5190d 100644
--- a/grove/cache/responder.go
+++ b/grove/cache/responder.go
@@ -16,7 +16,6 @@ package cache
 
 import (
"net/http"
-   "time"
 
"github.com/apache/trafficcontrol/grove/cachedata"
"github.com/apache/trafficcontrol/grove/plugin"
@@ -96,7 +95,7 @@ func (r *Responder) Do() {
// TODO move plugins.BeforeRespond here? How do we distinguish between 
success, and know to set headers? r.OriginReqSuccess?
bytesSent, err := r.F()
if err != nil {
-   log.Errorln(time.Now().Format(time.RFC3339Nano) + " " + 
r.Req.RemoteAddr + " " + r.Req.Method + " " + r.Req.RequestURI + ": responding: 
" + err.Error())
+   log.Errorf("%s %s %s %v : responding: %v", r.Req.RemoteAddr, 
r.Req.Method, r.Req.RequestURI, r.ResponseCode, err.Error())
}
web.TryFlush(r.W) // TODO remove? Let plugins do it, if they need to?
 


 


This is an automated message from the Apache Git Service.
To respond to the message, please log on GitHub and use the
URL above to go to the specific comment.
 
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org


With regards,
Apache Git Services

[GitHub] ezelkow1 commented on issue #3138: CIAB Trafficmonitor shows a lot of "Request Error: ... service still starting, some caches unpolled"

[GitBox]

ezelkow1 commented on issue #3138: CIAB Trafficmonitor shows a lot of "Request 
Error: ... service still starting, some caches unpolled"
URL: https://github.com/apache/trafficcontrol/issues/3138#issuecomment-448656192
 
 
   Have you done a snapshot first after bringing up the CIAB? You may not see a 
warning about it anymore but you still have to do a snapshot of the CDN in CIAB 
for the monitor to have a valid config to pull


This is an automated message from the Apache Git Service.
To respond to the message, please log on GitHub and use the
URL above to go to the specific comment.
 
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org


With regards,
Apache Git Services

[GitHub] jhowell-comcast opened a new issue #3145: TP: DNSSEC interface is broken if keys not already present

[GitBox]

jhowell-comcast opened a new issue #3145: TP: DNSSEC interface is broken if 
keys not already present
URL: https://github.com/apache/trafficcontrol/issues/3145
 
 
   
![tp_dnssec_broken](https://user-images.githubusercontent.com/40806931/50234701-7fb1ec80-0373-11e9-9d46-8fb2be626404.png)
   When going into DNSSEC interface on a CDN that doesn't already have keys, 
the interface is displayed as attached. The buttons are non-functional. It is 
not possible to generate new keys in the interface. 


This is an automated message from the Apache Git Service.
To respond to the message, please log on GitHub and use the
URL above to go to the specific comment.
 
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org


With regards,
Apache Git Services

[GitHub] rawlinp closed pull request #294: [TC-157] router fail to restart due to failed to get SSL keys

[GitBox]

rawlinp closed pull request #294: [TC-157] router fail to restart due to failed 
to get SSL keys
URL: https://github.com/apache/trafficcontrol/pull/294
 
 
   

This is a PR merged from a forked repository.
As GitHub hides the original diff on merge, it is displayed below for
the sake of provenance:

As this is a foreign pull request (from a fork), the diff is supplied
below (as it won't show otherwise due to GitHub magic):

diff --git 
a/traffic_router/core/src/main/java/com/comcast/cdn/traffic_control/traffic_router/core/secure/CertificatesClient.java
 
b/traffic_router/core/src/main/java/com/comcast/cdn/traffic_control/traffic_router/core/secure/CertificatesClient.java
index ae4525d94..f2585dade 100644
--- 
a/traffic_router/core/src/main/java/com/comcast/cdn/traffic_control/traffic_router/core/secure/CertificatesClient.java
+++ 
b/traffic_router/core/src/main/java/com/comcast/cdn/traffic_control/traffic_router/core/secure/CertificatesClient.java
@@ -43,6 +43,9 @@
 
while (status != HttpURLConnection.HTTP_NOT_MODIFIED && status 
!= HttpURLConnection.HTTP_OK) {

trafficRouterManager.trackEvent("lastHttpsCertificatesFetchFail");
+   if (shutdown){
+   return null;
+   }
try {

Thread.sleep(trafficOpsUtils.getConfigLongValue("certificates.retry.interval", 
30 * 1000L));
} catch (InterruptedException e) {
@@ -69,6 +72,9 @@
public int fetchRawData(final StringBuilder stringBuilder) {
while (trafficOpsUtils == null || trafficOpsUtils.getHostname() 
== null || trafficOpsUtils.getHostname().isEmpty()) {
LOGGER.error("No traffic ops hostname yet!");
+   if (shutdown) {
+   return -1;
+   }
try {
Thread.sleep(5000L);
} catch (Exception e) {


 


This is an automated message from the Apache Git Service.
To respond to the message, please log on GitHub and use the
URL above to go to the specific comment.
 
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org


With regards,
Apache Git Services

[GitHub] rawlinp commented on issue #914: [TC-157] Failed to restart tomcat in Traffic Router when failed to get SSL keys

[GitBox]

rawlinp commented on issue #914: [TC-157] Failed to restart tomcat in Traffic 
Router when failed to get SSL keys
URL: https://github.com/apache/trafficcontrol/issues/914#issuecomment-448668953
 
 
   Closing this because this doesn't appear to be an issue anymore (was unable 
to reproduce).


This is an automated message from the Apache Git Service.
To respond to the message, please log on GitHub and use the
URL above to go to the specific comment.
 
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org


With regards,
Apache Git Services

[GitHub] rawlinp closed issue #914: [TC-157] Failed to restart tomcat in Traffic Router when failed to get SSL keys

[GitBox]

rawlinp closed issue #914: [TC-157] Failed to restart tomcat in Traffic Router 
when failed to get SSL keys
URL: https://github.com/apache/trafficcontrol/issues/914
 
 
   


This is an automated message from the Apache Git Service.
To respond to the message, please log on GitHub and use the
URL above to go to the specific comment.
 
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org


With regards,
Apache Git Services

[GitHub] rawlinp commented on issue #294: [TC-157] router fail to restart due to failed to get SSL keys

[GitBox]

rawlinp commented on issue #294: [TC-157] router fail to restart due to failed 
to get SSL keys
URL: https://github.com/apache/trafficcontrol/pull/294#issuecomment-448668853
 
 
   Closing this because this doesn't appear to be an issue anymore (was unable 
to reproduce).


This is an automated message from the Apache Git Service.
To respond to the message, please log on GitHub and use the
URL above to go to the specific comment.
 
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org


With regards,
Apache Git Services

[GitHub] mitchell852 commented on a change in pull request #3133: Added documentation guidelines

[GitBox]

mitchell852 commented on a change in pull request #3133: Added documentation 
guidelines
URL: https://github.com/apache/trafficcontrol/pull/3133#discussion_r243000326
 
 

 ##
 File path: docs/source/development/documentation_guidelines.rst
 ##
 @@ -0,0 +1,172 @@
+..
+..
+.. Licensed under the Apache License, Version 2.0 (the "License");
+.. you may not use this file except in compliance with the License.
+.. You may obtain a copy of the License at
+..
+.. http://www.apache.org/licenses/LICENSE-2.0
+..
+.. Unless required by applicable law or agreed to in writing, software
+.. distributed under the License is distributed on an "AS IS" BASIS,
+.. WITHOUT WARRANTIES OR CONDITIONS OF ANY KIND, either express or implied.
+.. See the License for the specific language governing permissions and
+.. limitations under the License.
+..
+
+.. _docs-guide:
+
+
+Documentation Guidelines
+
+The Apache Traffic Control documentation is written in :abbr:`RST 
(reStructuredText)` and uses the `Sphinx documentation build system 
`_ to convert these into the desired 
output document format. This collection of guidelines does **not** aim to be a 
primer in :abbr:`RST (reStructuredText)`, but merely a style guide regarding 
how the components of the document ought to be formatted and structured. It may 
also point out some features of the markup language of which a writer may not 
be aware.
+
+.. seealso:: `The docutils RST reference 
`_.
+
+Building
+
+To build the documentation, see :ref:`docs-build`.
+
+Writing
+===
+When writing documentation, the most important things to remember are:
+
+- Spell Check. Most text editors have this built in (e.g. "F6" in Sublime 
Text) or have plugins that will do this for you.
+- Proof-Read. Spell-checkers won't catch grammatical errors or poor wording, 
so it's very important to actually proof-read all documentation *before* 
submitting it in a Pull Request.
+- Make Sure the Documentation Actually Builds. Please actually verify the 
documentation not only builds, but builds *correctly*. That means there 
probably shouldn't be any warnings, no malformed tables etc. and it also means 
that new documentation is actually accessible once built. It's not enough to 
create a new ``.rst`` file, that file must actually be linked to from some 
other, already included document. Some warnings may be considered acceptable, 
but do be prepared to defend them.
+- Traffic Ops UI is Dead. Do not ever create documentation that references or 
includes images of the Traffic Ops UI. That is officially dead now, and if the 
documentation being created is best made with references to a user-friendly UI, 
such references, examples and/or images should all be to/of Traffic Portal.
+
+Formatting
+--
+Whenever possible, avoid specifying manual line breaks, except as required by 
:abbr:`RST (reStructuredText)` syntax. Extremely long lines will be wrapped by 
the user-agent, compiler, or output format as necessary. A single blank line 
may be used to separate paragraphs. This means that the 'flow break' character 
should never need to be used, i.e. no line in the documentation should ever 
match the regular expression ``^\|$``.
+
+Abbreviations
+"
+When using an abbreviation, acronym or initialism for the first time on a 
page, it **must** be named fully and followed by the abbreviation in 
parentheses e.g. "Fully Qualified Domain Name (FQDN)". Strictly speaking, the 
*best* way to create an abbreviation is to always fully name it in parentheses 
immediately following the abbreviation using the ``:abbr:`` :abbr:`RST 
(reStructuredText)` text role e.g. ``:abbr:`FQDN (Fully Qualified Domain 
Name)```, but it's not reasonable to expect that of everyone. Some 
abbreviations can be assumed to be understood by the documentation's target 
audience, and do not need full naming; they are:
+
+- DNS
 
 Review comment:
   you can probably add ORT to this list?


This is an automated message from the Apache Git Service.
To respond to the message, please log on GitHub and use the
URL above to go to the specific comment.
 
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org


With regards,
Apache Git Services

[GitHub] asfgit commented on issue #3134: Added an explanation of the format and structure of API endpoint docs

[GitBox]

asfgit commented on issue #3134: Added an explanation of the format and 
structure of API endpoint docs
URL: https://github.com/apache/trafficcontrol/pull/3134#issuecomment-448676741
 
 
   
   Refer to this link for build results (access rights to CI server needed): 
   https://builds.apache.org/job/trafficcontrol-PR/2974/
   Test FAILed.
   


This is an automated message from the Apache Git Service.
To respond to the message, please log on GitHub and use the
URL above to go to the specific comment.
 
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org


With regards,
Apache Git Services

[GitHub] ocket8888 opened a new issue #3146: Creating a status without a description is allowed, but breaks the endpoint

[GitBox]

ocket opened a new issue #3146: Creating a status without a description is 
allowed, but breaks the endpoint
URL: https://github.com/apache/trafficcontrol/issues/3146
 
 
   A status can be created or updated such that it has a `null` description, 
but doing so will cause any further `GET` requests to `/api/1.x/statuses` or 
`/api/1.x/statuses/{{ID}}` to return a generic Internal Server Error response. 
The Traffic Ops logs show this error:
   ```
   ERROR: api.go:98: 2018-12-19T16:46:01.92506172Z: 172.16.239.1:47562 scanning 
status: sql: Scan error on column index 0: unsupported Scan, storing 
driver.Value type  into type *string
   ```


This is an automated message from the Apache Git Service.
To respond to the message, please log on GitHub and use the
URL above to go to the specific comment.
 
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org


With regards,
Apache Git Services

[GitHub] rob05c commented on issue #2732: Unable to Edit or Delete a Tenant where Active is false

[GitBox]

rob05c commented on issue #2732: Unable to Edit or Delete a Tenant where Active 
is false
URL: https://github.com/apache/trafficcontrol/issues/2732#issuecomment-448679801
 
 
   I'm hitting this issue, trying to fix the TO API Tests for tenancy.
   
   >I've dug a bit into this issue, and I believe the issue is in 
IsResourceAuthorizedToUserTx, >specifically line 197 in tenancy.go. The 
expected behavior is that an active tenant that is the parent >of any inactive 
tenant should still be able to modify that tenant.
   >I'd suggest that the active in this case refer to the activity of the 
requesting user's tenant, not the >activity of the tenant being modified.
   
   I think I agree. I think the solution is to fix the query in 
`IsResourceAuthorizedToUserTx` to return true if the user's tenant is active, 
and is a parent of the resource's tenant, irrespective whether the resource's 
direct tenant is active.
   
   I also agree with the discussion on the mailing list, that there are bigger 
issues with how tenancy and activity is treated. But I think it's worth fixing 
the immediate bug, if it isn't too difficult, even before we figure out the 
larger solution.


This is an automated message from the Apache Git Service.
To respond to the message, please log on GitHub and use the
URL above to go to the specific comment.
 
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org


With regards,
Apache Git Services

[GitHub] ocket8888 opened a new issue #3147: POST to /api/1.x/types gives bad error message

[GitBox]

ocket opened a new issue #3147: POST to /api/1.x/types gives bad error 
message
URL: https://github.com/apache/trafficcontrol/issues/3147
 
 
   If a payload without a `useInTable` field is submitted in a `POST` request 
to the `/api/1.x/types` endpoint, it will return a `400 Bad Request` response 
with an `alerts` object that has the following `text`:
   ```
   'use_in_table' cannot be blank
   ```
   This is confusing to users, because the actual field that cannot be blank is 
`useInTable`. It seems that the API "Cruder" is using the "db" name from the 
`TypeNullable` struct's ([lines 42 to 48 in 
`lib/go-tc/types.go`](https://github.com/apache/trafficcontrol/blob/master/lib/go-tc/types.go#L42-L48))
 field decorators instead of the "json" name.


This is an automated message from the Apache Git Service.
To respond to the message, please log on GitHub and use the
URL above to go to the specific comment.
 
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org


With regards,
Apache Git Services

[GitHub] ocket8888 commented on a change in pull request #3140: Add traffic_ops_ort.pl suuport for processing ##OVERRIDE## lines from…

[GitBox]

ocket commented on a change in pull request #3140: Add traffic_ops_ort.pl 
suuport for processing ##OVERRIDE## lines from…
URL: https://github.com/apache/trafficcontrol/pull/3140#discussion_r243031462
 
 

 ##
 File path: traffic_ops/bin/traffic_ops_ort.pl
 ##
 @@ -303,12 +303,12 @@ sub revalidate_while_sleeping {
 }
 
 sub os_version {
-  my $release = "UNKNOWN";
-  if (`uname -r` =~ m/.+(el\d)(?:\.\w+)*\.x86_64/)  {
-$release = uc $1;
-  }
-  exists $supported_el_release{$release} ? return $release
-  : die("unsupported el_version: $release");
+   my $release = "UNKNOWN";
+   if (`uname -r` =~ m/.+(el\d)(?:\.\w+)*\.x86_64/)  {
+   $release = uc $1;
+   }
+   exists $supported_el_release{$release} ? return $release
+   : die("unsupported el_version: $release");
 
 Review comment:
   First let me say I'm a huge fan of turning space-based indentation into 
tab-based indentation. Just be careful that when you're doing that you aren't 
turning _alignment_ into _indentation_. This should be indented one level with 
a tab character then aligned using spaces so that it displays consistently 
regardless of where your editor places its tabstops.


This is an automated message from the Apache Git Service.
To respond to the message, please log on GitHub and use the
URL above to go to the specific comment.
 
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org


With regards,
Apache Git Services

[GitHub] ocket8888 commented on a change in pull request #3133: Added documentation guidelines

[GitBox]

ocket commented on a change in pull request #3133: Added documentation 
guidelines
URL: https://github.com/apache/trafficcontrol/pull/3133#discussion_r243034076
 
 

 ##
 File path: docs/source/development/documentation_guidelines.rst
 ##
 @@ -0,0 +1,172 @@
+..
+..
+.. Licensed under the Apache License, Version 2.0 (the "License");
+.. you may not use this file except in compliance with the License.
+.. You may obtain a copy of the License at
+..
+.. http://www.apache.org/licenses/LICENSE-2.0
+..
+.. Unless required by applicable law or agreed to in writing, software
+.. distributed under the License is distributed on an "AS IS" BASIS,
+.. WITHOUT WARRANTIES OR CONDITIONS OF ANY KIND, either express or implied.
+.. See the License for the specific language governing permissions and
+.. limitations under the License.
+..
+
+.. _docs-guide:
+
+
+Documentation Guidelines
+
+The Apache Traffic Control documentation is written in :abbr:`RST 
(reStructuredText)` and uses the `Sphinx documentation build system 
`_ to convert these into the desired 
output document format. This collection of guidelines does **not** aim to be a 
primer in :abbr:`RST (reStructuredText)`, but merely a style guide regarding 
how the components of the document ought to be formatted and structured. It may 
also point out some features of the markup language of which a writer may not 
be aware.
+
+.. seealso:: `The docutils RST reference 
`_.
+
+Building
+
+To build the documentation, see :ref:`docs-build`.
+
+Writing
+===
+When writing documentation, the most important things to remember are:
+
+- Spell Check. Most text editors have this built in (e.g. "F6" in Sublime 
Text) or have plugins that will do this for you.
+- Proof-Read. Spell-checkers won't catch grammatical errors or poor wording, 
so it's very important to actually proof-read all documentation *before* 
submitting it in a Pull Request.
+- Make Sure the Documentation Actually Builds. Please actually verify the 
documentation not only builds, but builds *correctly*. That means there 
probably shouldn't be any warnings, no malformed tables etc. and it also means 
that new documentation is actually accessible once built. It's not enough to 
create a new ``.rst`` file, that file must actually be linked to from some 
other, already included document. Some warnings may be considered acceptable, 
but do be prepared to defend them.
+- Traffic Ops UI is Dead. Do not ever create documentation that references or 
includes images of the Traffic Ops UI. That is officially dead now, and if the 
documentation being created is best made with references to a user-friendly UI, 
such references, examples and/or images should all be to/of Traffic Portal.
+
+Formatting
+--
+Whenever possible, avoid specifying manual line breaks, except as required by 
:abbr:`RST (reStructuredText)` syntax. Extremely long lines will be wrapped by 
the user-agent, compiler, or output format as necessary. A single blank line 
may be used to separate paragraphs. This means that the 'flow break' character 
should never need to be used, i.e. no line in the documentation should ever 
match the regular expression ``^\|$``.
+
+Abbreviations
+"
+When using an abbreviation, acronym or initialism for the first time on a 
page, it **must** be named fully and followed by the abbreviation in 
parentheses e.g. "Fully Qualified Domain Name (FQDN)". Strictly speaking, the 
*best* way to create an abbreviation is to always fully name it in parentheses 
immediately following the abbreviation using the ``:abbr:`` :abbr:`RST 
(reStructuredText)` text role e.g. ``:abbr:`FQDN (Fully Qualified Domain 
Name)```, but it's not reasonable to expect that of everyone. Some 
abbreviations can be assumed to be understood by the documentation's target 
audience, and do not need full naming; they are:
+
+- DNS
 
 Review comment:
   I disagree. "ORT" is a Traffic Control-specific abbreviation, so someone 
reading the documentation for the first time cannot be assumed to know that 
that means. I also wouldn't put things like TO, TP, TR, etc. on that list.


This is an automated message from the Apache Git Service.
To respond to the message, please log on GitHub and use the
URL above to go to the specific comment.
 
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org


With regards,
Apache Git Services

[GitHub] rob05c opened a new pull request #3148: Fix Traffic Ops GET statuses to allow null descriptions

[GitBox]

rob05c opened a new pull request #3148: Fix Traffic Ops GET statuses to allow 
null descriptions
URL: https://github.com/apache/trafficcontrol/pull/3148
 
 
    What does this PR do?
   
   Fix Traffic Ops GET statuses to allow null descriptions
   
   Includes API Tests.
   
    Which TC components are affected by this PR?
   
   - [ ] Documentation
   - [ ] Grove
   - [ ] Traffic Analytics
   - [ ] Traffic Monitor
   - [x] Traffic Ops
   - [ ] Traffic Ops ORT
   - [ ] Traffic Portal
   - [ ] Traffic Router
   - [ ] Traffic Stats
   - [ ] Traffic Vault
   - [ ] Other _
   
    What is the best way to verify this PR?
   
   Run API tests. Create a status with a null description, and call `GET 
/statuses`.
   
    Check all that apply
   
   - [x] This PR includes tests
   - [ ] This PR includes documentation updates
   - [ ] This PR includes an update to CHANGELOG.md
   - [ ] This PR includes all required license headers
   - [ ] This PR includes a database migration (ensure that migration sequence 
is correct)
   - [ ] This PR fixes a serious security flaw. Read more: 
[www.apache.org/security](http://www.apache.org/security/)
   
   
   
   
   
   


This is an automated message from the Apache Git Service.
To respond to the message, please log on GitHub and use the
URL above to go to the specific comment.
 
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org


With regards,
Apache Git Services

[GitHub] asfgit commented on issue #3148: Fix Traffic Ops GET statuses to allow null descriptions

[GitBox]

asfgit commented on issue #3148: Fix Traffic Ops GET statuses to allow null 
descriptions
URL: https://github.com/apache/trafficcontrol/pull/3148#issuecomment-448713149
 
 
   
   Refer to this link for build results (access rights to CI server needed): 
   https://builds.apache.org/job/trafficcontrol-PR/2975/
   Test PASSed.
   


This is an automated message from the Apache Git Service.
To respond to the message, please log on GitHub and use the
URL above to go to the specific comment.
 
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org


With regards,
Apache Git Services

[GitHub] jrushford opened a new pull request #3149: Added a configuration setting, 'DisableHTTP2'. The setting

[GitBox]

jrushford opened a new pull request #3149: Added a configuration setting, 
'DisableHTTP2'.  The setting
URL: https://github.com/apache/trafficcontrol/pull/3149
 
 
   is false by default but when set to 'true', the grove server
   will not negotiate and serve HTTP2.
   
    What does this PR do?
   Adds a new config setting that lets the operator disable HTTP2 in grove.
   Fixes #(issue_number)
   
    Which TC components are affected by this PR?
   
   - [ ] Documentation
   - [X] Grove
   - [ ] Traffic Analytics
   - [ ] Traffic Monitor
   - [ ] Traffic Ops
   - [ ] Traffic Ops ORT
   - [ ] Traffic Portal
   - [ ] Traffic Router
   - [ ] Traffic Stats
   - [ ] Traffic Vault
   - [ ] Other _
   
    What is the best way to verify this PR?
   By default, grove will negotiate and service HTTP2 with capable clients.  If 
the operator adds the config setting "disable_http2: true" to the grove config 
file, grove will not negotiate and service an HTTP2 connection.
   
    Check all that apply
   
   - [ ] This PR includes tests
   - [ ] This PR includes documentation updates
   - [ ] This PR includes an update to CHANGELOG.md
   - [ ] This PR includes all required license headers
   - [ ] This PR includes a database migration (ensure that migration sequence 
is correct)
   - [ ] This PR fixes a serious security flaw. Read more: 
[www.apache.org/security](http://www.apache.org/security/)
   
   
   
   
   
   


This is an automated message from the Apache Git Service.
To respond to the message, please log on GitHub and use the
URL above to go to the specific comment.
 
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org


With regards,
Apache Git Services

[GitHub] asfgit commented on issue #3149: Added an optional configuration setting, 'DisableHTTP2' to the grove config.

[GitBox]

asfgit commented on issue #3149: Added an optional configuration setting, 
'DisableHTTP2' to the grove config.
URL: https://github.com/apache/trafficcontrol/pull/3149#issuecomment-448726621
 
 
   
   Refer to this link for build results (access rights to CI server needed): 
   https://builds.apache.org/job/trafficcontrol-PR/2976/
   Test PASSed.
   


This is an automated message from the Apache Git Service.
To respond to the message, please log on GitHub and use the
URL above to go to the specific comment.
 
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org


With regards,
Apache Git Services

[GitHub] asfgit commented on issue #3134: Added an explanation of the format and structure of API endpoint docs

[GitBox]

asfgit commented on issue #3134: Added an explanation of the format and 
structure of API endpoint docs
URL: https://github.com/apache/trafficcontrol/pull/3134#issuecomment-448734921
 
 
   
   Refer to this link for build results (access rights to CI server needed): 
   https://builds.apache.org/job/trafficcontrol-PR/2977/
   Test PASSed.
   


This is an automated message from the Apache Git Service.
To respond to the message, please log on GitHub and use the
URL above to go to the specific comment.
 
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org


With regards,
Apache Git Services

[GitHub] dangogh opened a new issue #3150: TP build errors

[GitBox]

dangogh opened a new issue #3150: TP build errors
URL: https://github.com/apache/trafficcontrol/issues/3150
 
 
   Traffic Portal fails to build in 
https://builds.apache.org/view/S-Z/view/TrafficControl/job/trafficcontrol-master-build
 apparently due to an upstream change:
   
   ```
   Step 6/9 : RUNgem update --system && gem install rb-inotify -v 
0.9.10 && gem install compass && npm -g install bower grunt-cli
---> Running in 466b8eb0e5a5
   ERROR:  Error installing rubygems-update:
   rubygems-update requires Ruby version >= 2.3.0.
   ERROR:  While executing gem ... (NoMethodError)
   undefined method `version' for nil:NilClass
   Updating rubygems-update
   ERROR: Service 'traffic_portal_build' failed to build: The command '/bin/sh 
-c gem update --system && gem install rb-inotify -v 0.9.10 && gem 
install compass && npm -g install bower grunt-cli' returned a non-zero 
code: 1
   ```
   


This is an automated message from the Apache Git Service.
To respond to the message, please log on GitHub and use the
URL above to go to the specific comment.
 
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org


With regards,
Apache Git Services

[GitHub] dangogh opened a new issue #3151: TO build errors

[GitBox]

dangogh opened a new issue #3151: TO build errors
URL: https://github.com/apache/trafficcontrol/issues/3151
 
 
   Traffic Ops fails to build in 
https://builds.apache.org/view/S-Z/view/TrafficControl/job/trafficcontrol-master-build
 apparently due to an upstream repository change:
   ```
   Cannot retrieve metalink for repository: epel/x86_64. Please verify its path 
and try again
   Service 'traffic_ops_build' failed to build: The command '/bin/sh -c yum -y 
install  expat-devel gcc libcurl-devel  
 makeopenssl-devel   perl-ExtUtils-MakeMaker
 tar && yum-config-manager --add-repo 
'http://vault.centos.org/7.5.1804/os/x86_64/' && yum -y install 
--enablerepo=vault* golang-1.9.4 &&yum -y clean all' returned a 
non-zero code: 1
   + exit 1
   Build step 'Execute shell' marked build as failure
   ```


This is an automated message from the Apache Git Service.
To respond to the message, please log on GitHub and use the
URL above to go to the specific comment.
 
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org


With regards,
Apache Git Services

[GitHub] dangogh opened a new pull request #3152: fix builder Dockerfiles

[GitBox]

dangogh opened a new pull request #3152: fix builder Dockerfiles
URL: https://github.com/apache/trafficcontrol/pull/3152
 
 
    What does this PR do?
   Fixes build errors in traffic_portal and traffic_ops both due to upstream 
repo changes.  Change is to use newer version of ruby for traffic_portal build 
and update ca-certificates for all builds.
   
   Fixes #3150 
   Fixes #3151
   
    Which TC components are affected by this PR?
   
   - [ ] Documentation
   - [ ] Grove
   - [ ] Traffic Analytics
   - [x] Traffic Monitor
   - [x] Traffic Ops
   - [ ] Traffic Ops ORT
   - [x] Traffic Portal
   - [x] Traffic Router
   - [x] Traffic Stats
   - [ ] Traffic Vault
   - [ ] Other _
   
    What is the best way to verify this PR?
   
   See the Apache build passes.
   
    Check all that apply
   
   - [ ] This PR includes tests
   - [ ] This PR includes documentation updates
   - [ ] This PR includes an update to CHANGELOG.md
   - [ ] This PR includes all required license headers
   - [ ] This PR includes a database migration (ensure that migration sequence 
is correct)
   - [ ] This PR fixes a serious security flaw. Read more: 
[www.apache.org/security](http://www.apache.org/security/)
   
   
   
   
   
   


This is an automated message from the Apache Git Service.
To respond to the message, please log on GitHub and use the
URL above to go to the specific comment.
 
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org


With regards,
Apache Git Services

[GitHub] asfgit commented on issue #3152: fix builder Dockerfiles

[GitBox]

asfgit commented on issue #3152: fix builder Dockerfiles
URL: https://github.com/apache/trafficcontrol/pull/3152#issuecomment-448794710
 
 
   
   Refer to this link for build results (access rights to CI server needed): 
   https://builds.apache.org/job/trafficcontrol-PR/2978/
   Test PASSed.
   


This is an automated message from the Apache Git Service.
To respond to the message, please log on GitHub and use the
URL above to go to the specific comment.
 
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org


With regards,
Apache Git Services

[GitHub] mitchell852 commented on a change in pull request #3133: Added documentation guidelines

[GitBox]

mitchell852 commented on a change in pull request #3133: Added documentation 
guidelines
URL: https://github.com/apache/trafficcontrol/pull/3133#discussion_r243319441
 
 

 ##
 File path: docs/source/development/documentation_guidelines.rst
 ##
 @@ -0,0 +1,172 @@
+..
+..
+.. Licensed under the Apache License, Version 2.0 (the "License");
+.. you may not use this file except in compliance with the License.
+.. You may obtain a copy of the License at
+..
+.. http://www.apache.org/licenses/LICENSE-2.0
+..
+.. Unless required by applicable law or agreed to in writing, software
+.. distributed under the License is distributed on an "AS IS" BASIS,
+.. WITHOUT WARRANTIES OR CONDITIONS OF ANY KIND, either express or implied.
+.. See the License for the specific language governing permissions and
+.. limitations under the License.
+..
+
+.. _docs-guide:
+
+
+Documentation Guidelines
+
+The Apache Traffic Control documentation is written in :abbr:`RST 
(reStructuredText)` and uses the `Sphinx documentation build system 
`_ to convert these into the desired 
output document format. This collection of guidelines does **not** aim to be a 
primer in :abbr:`RST (reStructuredText)`, but merely a style guide regarding 
how the components of the document ought to be formatted and structured. It may 
also point out some features of the markup language of which a writer may not 
be aware.
+
+.. seealso:: `The docutils RST reference 
`_.
+
+Building
+
+To build the documentation, see :ref:`docs-build`.
+
+Writing
+===
+When writing documentation, the most important things to remember are:
+
+- Spell Check. Most text editors have this built in (e.g. "F6" in Sublime 
Text) or have plugins that will do this for you.
+- Proof-Read. Spell-checkers won't catch grammatical errors or poor wording, 
so it's very important to actually proof-read all documentation *before* 
submitting it in a Pull Request.
+- Make Sure the Documentation Actually Builds. Please actually verify the 
documentation not only builds, but builds *correctly*. That means there 
probably shouldn't be any warnings, no malformed tables etc. and it also means 
that new documentation is actually accessible once built. It's not enough to 
create a new ``.rst`` file, that file must actually be linked to from some 
other, already included document. Some warnings may be considered acceptable, 
but do be prepared to defend them.
+- Traffic Ops UI is Dead. Do not ever create documentation that references or 
includes images of the Traffic Ops UI. That is officially dead now, and if the 
documentation being created is best made with references to a user-friendly UI, 
such references, examples and/or images should all be to/of Traffic Portal.
+
+Formatting
+--
+Whenever possible, avoid specifying manual line breaks, except as required by 
:abbr:`RST (reStructuredText)` syntax. Extremely long lines will be wrapped by 
the user-agent, compiler, or output format as necessary. A single blank line 
may be used to separate paragraphs. This means that the 'flow break' character 
should never need to be used, i.e. no line in the documentation should ever 
match the regular expression ``^\|$``.
+
+Abbreviations
+"
+When using an abbreviation, acronym or initialism for the first time on a 
page, it **must** be named fully and followed by the abbreviation in 
parentheses e.g. "Fully Qualified Domain Name (FQDN)". Strictly speaking, the 
*best* way to create an abbreviation is to always fully name it in parentheses 
immediately following the abbreviation using the ``:abbr:`` :abbr:`RST 
(reStructuredText)` text role e.g. ``:abbr:`FQDN (Fully Qualified Domain 
Name)```, but it's not reasonable to expect that of everyone. Some 
abbreviations can be assumed to be understood by the documentation's target 
audience, and do not need full naming; they are:
+
+- DNS
 
 Review comment:
   fair enough. not a big deal. i agree about the TP, TP, TR because Traffic 
Portal means more than TP. But does Operational Readiness Test have more 
meaning than ORT? not so sure...


This is an automated message from the Apache Git Service.
To respond to the message, please log on GitHub and use the
URL above to go to the specific comment.
 
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org


With regards,
Apache Git Services

[GitHub] ocket8888 commented on a change in pull request #3133: Added documentation guidelines

[GitBox]

ocket commented on a change in pull request #3133: Added documentation 
guidelines
URL: https://github.com/apache/trafficcontrol/pull/3133#discussion_r243324496
 
 

 ##
 File path: docs/source/development/documentation_guidelines.rst
 ##
 @@ -0,0 +1,172 @@
+..
+..
+.. Licensed under the Apache License, Version 2.0 (the "License");
+.. you may not use this file except in compliance with the License.
+.. You may obtain a copy of the License at
+..
+.. http://www.apache.org/licenses/LICENSE-2.0
+..
+.. Unless required by applicable law or agreed to in writing, software
+.. distributed under the License is distributed on an "AS IS" BASIS,
+.. WITHOUT WARRANTIES OR CONDITIONS OF ANY KIND, either express or implied.
+.. See the License for the specific language governing permissions and
+.. limitations under the License.
+..
+
+.. _docs-guide:
+
+
+Documentation Guidelines
+
+The Apache Traffic Control documentation is written in :abbr:`RST 
(reStructuredText)` and uses the `Sphinx documentation build system 
`_ to convert these into the desired 
output document format. This collection of guidelines does **not** aim to be a 
primer in :abbr:`RST (reStructuredText)`, but merely a style guide regarding 
how the components of the document ought to be formatted and structured. It may 
also point out some features of the markup language of which a writer may not 
be aware.
+
+.. seealso:: `The docutils RST reference 
`_.
+
+Building
+
+To build the documentation, see :ref:`docs-build`.
+
+Writing
+===
+When writing documentation, the most important things to remember are:
+
+- Spell Check. Most text editors have this built in (e.g. "F6" in Sublime 
Text) or have plugins that will do this for you.
+- Proof-Read. Spell-checkers won't catch grammatical errors or poor wording, 
so it's very important to actually proof-read all documentation *before* 
submitting it in a Pull Request.
+- Make Sure the Documentation Actually Builds. Please actually verify the 
documentation not only builds, but builds *correctly*. That means there 
probably shouldn't be any warnings, no malformed tables etc. and it also means 
that new documentation is actually accessible once built. It's not enough to 
create a new ``.rst`` file, that file must actually be linked to from some 
other, already included document. Some warnings may be considered acceptable, 
but do be prepared to defend them.
+- Traffic Ops UI is Dead. Do not ever create documentation that references or 
includes images of the Traffic Ops UI. That is officially dead now, and if the 
documentation being created is best made with references to a user-friendly UI, 
such references, examples and/or images should all be to/of Traffic Portal.
+
+Formatting
+--
+Whenever possible, avoid specifying manual line breaks, except as required by 
:abbr:`RST (reStructuredText)` syntax. Extremely long lines will be wrapped by 
the user-agent, compiler, or output format as necessary. A single blank line 
may be used to separate paragraphs. This means that the 'flow break' character 
should never need to be used, i.e. no line in the documentation should ever 
match the regular expression ``^\|$``.
+
+Abbreviations
+"
+When using an abbreviation, acronym or initialism for the first time on a 
page, it **must** be named fully and followed by the abbreviation in 
parentheses e.g. "Fully Qualified Domain Name (FQDN)". Strictly speaking, the 
*best* way to create an abbreviation is to always fully name it in parentheses 
immediately following the abbreviation using the ``:abbr:`` :abbr:`RST 
(reStructuredText)` text role e.g. ``:abbr:`FQDN (Fully Qualified Domain 
Name)```, but it's not reasonable to expect that of everyone. Some 
abbreviations can be assumed to be understood by the documentation's target 
audience, and do not need full naming; they are:
+
+- DNS
 
 Review comment:
   It's not about collision, it's about obscurity. You might not have a 
conflicting definition of ORT, but that doesn't mean you know what it means. 
The target audience of Traffic Control is people who want to set up a CDN. That 
means they know what a CDN is (roughly), and they're familiar with how a simple 
webserver serves HTTP(S) requests - that covers that list. For example I was 
hired and trying to set up a CDN-in-a-Box I didn't know what "ORT" meant until 
I found the definition in the docs. I did know (roughly) what a CDN is, and I 
understood what basic web technologies like HTTP and DNS are. "ORT" doesn't 
exist outside of Traffic Control, so we could never expect anyone to come into 
the documentation knowing what that is.
   
   To be clear, I'm not saying that "ORT" can't be used in the docs, I'm just 
saying the first time you use it on a page you should make it clear what it is. 
I don't actually think the best way to do t

[GitHub] ocket8888 commented on a change in pull request #3133: Added documentation guidelines

[GitBox]

ocket commented on a change in pull request #3133: Added documentation 
guidelines
URL: https://github.com/apache/trafficcontrol/pull/3133#discussion_r243324496
 
 

 ##
 File path: docs/source/development/documentation_guidelines.rst
 ##
 @@ -0,0 +1,172 @@
+..
+..
+.. Licensed under the Apache License, Version 2.0 (the "License");
+.. you may not use this file except in compliance with the License.
+.. You may obtain a copy of the License at
+..
+.. http://www.apache.org/licenses/LICENSE-2.0
+..
+.. Unless required by applicable law or agreed to in writing, software
+.. distributed under the License is distributed on an "AS IS" BASIS,
+.. WITHOUT WARRANTIES OR CONDITIONS OF ANY KIND, either express or implied.
+.. See the License for the specific language governing permissions and
+.. limitations under the License.
+..
+
+.. _docs-guide:
+
+
+Documentation Guidelines
+
+The Apache Traffic Control documentation is written in :abbr:`RST 
(reStructuredText)` and uses the `Sphinx documentation build system 
`_ to convert these into the desired 
output document format. This collection of guidelines does **not** aim to be a 
primer in :abbr:`RST (reStructuredText)`, but merely a style guide regarding 
how the components of the document ought to be formatted and structured. It may 
also point out some features of the markup language of which a writer may not 
be aware.
+
+.. seealso:: `The docutils RST reference 
`_.
+
+Building
+
+To build the documentation, see :ref:`docs-build`.
+
+Writing
+===
+When writing documentation, the most important things to remember are:
+
+- Spell Check. Most text editors have this built in (e.g. "F6" in Sublime 
Text) or have plugins that will do this for you.
+- Proof-Read. Spell-checkers won't catch grammatical errors or poor wording, 
so it's very important to actually proof-read all documentation *before* 
submitting it in a Pull Request.
+- Make Sure the Documentation Actually Builds. Please actually verify the 
documentation not only builds, but builds *correctly*. That means there 
probably shouldn't be any warnings, no malformed tables etc. and it also means 
that new documentation is actually accessible once built. It's not enough to 
create a new ``.rst`` file, that file must actually be linked to from some 
other, already included document. Some warnings may be considered acceptable, 
but do be prepared to defend them.
+- Traffic Ops UI is Dead. Do not ever create documentation that references or 
includes images of the Traffic Ops UI. That is officially dead now, and if the 
documentation being created is best made with references to a user-friendly UI, 
such references, examples and/or images should all be to/of Traffic Portal.
+
+Formatting
+--
+Whenever possible, avoid specifying manual line breaks, except as required by 
:abbr:`RST (reStructuredText)` syntax. Extremely long lines will be wrapped by 
the user-agent, compiler, or output format as necessary. A single blank line 
may be used to separate paragraphs. This means that the 'flow break' character 
should never need to be used, i.e. no line in the documentation should ever 
match the regular expression ``^\|$``.
+
+Abbreviations
+"
+When using an abbreviation, acronym or initialism for the first time on a 
page, it **must** be named fully and followed by the abbreviation in 
parentheses e.g. "Fully Qualified Domain Name (FQDN)". Strictly speaking, the 
*best* way to create an abbreviation is to always fully name it in parentheses 
immediately following the abbreviation using the ``:abbr:`` :abbr:`RST 
(reStructuredText)` text role e.g. ``:abbr:`FQDN (Fully Qualified Domain 
Name)```, but it's not reasonable to expect that of everyone. Some 
abbreviations can be assumed to be understood by the documentation's target 
audience, and do not need full naming; they are:
+
+- DNS
 
 Review comment:
   It's not about collision, it's about obscurity. You might not have a 
conflicting definition of ORT, but that doesn't mean you know what it means. 
The target audience of Traffic Control is people who want to set up a CDN. That 
means they know what a CDN is (roughly), and they're familiar with how a simple 
webserver serves HTTP(S) requests - that covers that list. For example I was 
hired and trying to set up a CDN-in-a-Box I didn't know what "ORT" meant until 
I found the definition in the docs. I did know (roughly) what a CDN is, and I 
understood what basic web technologies like HTTP and DNS are. "ORT" doesn't 
exist outside of Traffic Control, so we could never expect anyone to come into 
the documentation knowing what that is.
   
   To be clear, I'm not saying that "ORT" can't be used in the docs, I'm just 
saying the first time you use it on a page you should make it clear what it is. 
I don't actually think the best way to do t

[GitHub] asfgit commented on issue #3149: Added an optional configuration setting, 'DisableHTTP2' to the grove config.

[GitBox]

asfgit commented on issue #3149: Added an optional configuration setting, 
'DisableHTTP2' to the grove config.
URL: https://github.com/apache/trafficcontrol/pull/3149#issuecomment-449047093
 
 
   
   Refer to this link for build results (access rights to CI server needed): 
   https://builds.apache.org/job/trafficcontrol-PR/2979/
   Test FAILed.
   


This is an automated message from the Apache Git Service.
To respond to the message, please log on GitHub and use the
URL above to go to the specific comment.
 
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org


With regards,
Apache Git Services

[GitHub] mitchell852 closed issue #3151: TO build errors

[GitBox]

mitchell852 closed issue #3151: TO build errors
URL: https://github.com/apache/trafficcontrol/issues/3151
 
 
   


This is an automated message from the Apache Git Service.
To respond to the message, please log on GitHub and use the
URL above to go to the specific comment.
 
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org


With regards,
Apache Git Services

[GitHub] mitchell852 closed issue #3150: TP build errors

[GitBox]

mitchell852 closed issue #3150: TP build errors
URL: https://github.com/apache/trafficcontrol/issues/3150
 
 
   


This is an automated message from the Apache Git Service.
To respond to the message, please log on GitHub and use the
URL above to go to the specific comment.
 
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org


With regards,
Apache Git Services