[GitHub] [trafficcontrol] srijeet0406 commented on a diff in pull request #7224: Add required capabilities to delivery service structure

2022-12-07 Thread GitBox
srijeet0406 commented on code in PR #7224: URL: https://github.com/apache/trafficcontrol/pull/7224#discussion_r1042596304 ## lib/go-tc/deliveryservices.go: ## @@ -1632,7 +1632,11 @@ func (ds DeliveryServiceV5) Downgrade() DeliveryServiceV4 { copy(*downgraded.Mat

[GitHub] [trafficcontrol] srijeet0406 merged pull request #7239: Update traffic_router.logrotate as well as Ansible block to copy file.

2022-12-07 Thread GitBox
srijeet0406 merged PR #7239: URL: https://github.com/apache/trafficcontrol/pull/7239 -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: issues-unsubscr...@

[GitHub] [trafficcontrol] ragen14 commented on pull request #7239: Update traffic_router.logrotate as well as Ansible block to copy file.

2022-12-07 Thread GitBox
ragen14 commented on PR #7239: URL: https://github.com/apache/trafficcontrol/pull/7239#issuecomment-1341464936 > Added suggested change from Ash to copy file instead of creating file. looks good -- This is an automated message from the Apache Git Service. To respond to the message,

[GitHub] [trafficcontrol] codecov[bot] commented on pull request #7239: Update traffic_router.logrotate as well as Ansible block to copy file.

2022-12-07 Thread GitBox
codecov[bot] commented on PR #7239: URL: https://github.com/apache/trafficcontrol/pull/7239#issuecomment-1341428385 # [Codecov](https://codecov.io/gh/apache/trafficcontrol/pull/7239?src=pr&el=h1&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+A

[GitHub] [trafficcontrol] villajo commented on a diff in pull request #7239: Update traffic_router.logrotate as well as Ansible block to copy file.

2022-12-07 Thread GitBox
villajo commented on code in PR #7239: URL: https://github.com/apache/trafficcontrol/pull/7239#discussion_r1042561992 ## .github/workflows/codeql.java.yml: ## @@ -37,6 +37,8 @@ jobs: RHEL_VERSION: rhel_version STARTUP_SCRIPT_DIR: /startup-dir STARTUP_SCRIPT_

[GitHub] [trafficcontrol] srijeet0406 commented on a diff in pull request #7239: Update traffic_router.logrotate as well as Ansible block to copy file.

2022-12-07 Thread GitBox
srijeet0406 commented on code in PR #7239: URL: https://github.com/apache/trafficcontrol/pull/7239#discussion_r1042561557 ## .github/workflows/codeql.java.yml: ## @@ -37,6 +37,8 @@ jobs: RHEL_VERSION: rhel_version STARTUP_SCRIPT_DIR: /startup-dir STARTUP_SCR

[GitHub] [trafficcontrol] ocket8888 commented on a diff in pull request #7224: Add required capabilities to delivery service structure

2022-12-07 Thread GitBox
ocket commented on code in PR #7224: URL: https://github.com/apache/trafficcontrol/pull/7224#discussion_r1042523146 ## lib/go-tc/deliveryservices.go: ## @@ -1632,7 +1632,11 @@ func (ds DeliveryServiceV5) Downgrade() DeliveryServiceV4 { copy(*downgraded.Match

[GitHub] [trafficcontrol] villajo commented on pull request #7239: Update traffic_router.logrotate as well as Ansible block to copy file.

2022-12-07 Thread GitBox
villajo commented on PR #7239: URL: https://github.com/apache/trafficcontrol/pull/7239#issuecomment-1341284114 Added suggested change from Ash to copy file instead of creating file. -- This is an automated message from the Apache Git Service. To respond to the message, please log on to Gi

[GitHub] [trafficcontrol] villajo opened a new pull request, #7239: Update traffic_router.logrotate

2022-12-07 Thread GitBox
villajo opened a new pull request, #7239: URL: https://github.com/apache/trafficcontrol/pull/7239 Related: #6533 This PR Is related to 6533, logrotate file for traffic router did not have an Apache license attached. ## Which Traffic Control components are affected by this PR?

[GitHub] [trafficcontrol] codecov[bot] commented on pull request #7204: t3c: strategies.yaml hash_key only for consistent_hash

2022-12-07 Thread GitBox
codecov[bot] commented on PR #7204: URL: https://github.com/apache/trafficcontrol/pull/7204#issuecomment-1341005636 # [Codecov](https://codecov.io/gh/apache/trafficcontrol/pull/7204?src=pr&el=h1&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+A

[GitHub] [trafficcontrol] shamrickus merged pull request #7236: Bump qs from 6.5.2 to 6.5.3 in /traffic_portal/test/integration

2022-12-06 Thread GitBox
shamrickus merged PR #7236: URL: https://github.com/apache/trafficcontrol/pull/7236 -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: issues-unsubscr...@t

[GitHub] [trafficcontrol] ocket8888 commented on a diff in pull request #7224: Add required capabilities to delivery service structure

2022-12-06 Thread GitBox
ocket commented on code in PR #7224: URL: https://github.com/apache/trafficcontrol/pull/7224#discussion_r1036398114 ## docs/source/api/v3/deliveryservices_required_capabilities.rst: ## @@ -19,6 +19,8 @@ ``deliveryservices_required_capabilities`` ***

[GitHub] [trafficcontrol] fabikd opened a new issue, #7238: can-in-a-box build fails with "No such file or directory" on M1 Pro Mac

2022-12-06 Thread GitBox
fabikd opened a new issue, #7238: URL: https://github.com/apache/trafficcontrol/issues/7238 ## This Bug Report affects these Traffic Control components: - Traffic Control Cache Config (`t3c`, formerly ORT) - Traffic Control Health Client (t3c-health-client) - Traffic

[GitHub] [trafficcontrol] zrhoffman closed issue #6533: TR should not rename/recreate log files on rollover

2022-12-06 Thread GitBox
zrhoffman closed issue #6533: TR should not rename/recreate log files on rollover URL: https://github.com/apache/trafficcontrol/issues/6533 -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specif

[GitHub] [trafficcontrol] zrhoffman merged pull request #7234: Fix issue 6533

2022-12-06 Thread GitBox
zrhoffman merged PR #7234: URL: https://github.com/apache/trafficcontrol/pull/7234 -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: issues-unsubscr...@tr

[GitHub] [trafficcontrol] tcfdev closed issue #5025: Fix TO API Update/Reval Pending Race

2022-12-06 Thread GitBox
tcfdev closed issue #5025: Fix TO API Update/Reval Pending Race URL: https://github.com/apache/trafficcontrol/issues/5025 -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To uns

[GitHub] [trafficcontrol] tcfdev commented on issue #5025: Fix TO API Update/Reval Pending Race

2022-12-06 Thread GitBox
tcfdev commented on issue #5025: URL: https://github.com/apache/trafficcontrol/issues/5025#issuecomment-1340073780 This issue was addressed with: #6569 -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to

[GitHub] [trafficcontrol] srijeet0406 commented on a diff in pull request #7224: Add required capabilities to delivery service structure

2022-12-06 Thread GitBox
srijeet0406 commented on code in PR #7224: URL: https://github.com/apache/trafficcontrol/pull/7224#discussion_r1041501933 ## traffic_ops/traffic_ops_golang/dbhelpers/db_helpers.go: ## @@ -850,13 +850,11 @@ func GetRequiredCapabilitiesOfDeliveryServices(ids []int, tx *sql.Tx) (m

[GitHub] [trafficcontrol] tcfdev opened a new issue, #7237: Improve the response time for v3/server endpoint

2022-12-06 Thread GitBox
tcfdev opened a new issue, #7237: URL: https://github.com/apache/trafficcontrol/issues/7237 ## This Improvement request (usability, performance, tech debt, etc.) affects these Traffic Control components: - Traffic Ops ## Current behavior: The response tim

[GitHub] [trafficcontrol] codecov[bot] commented on pull request #7236: Bump qs from 6.5.2 to 6.5.3 in /traffic_portal/test/integration

2022-12-06 Thread GitBox
codecov[bot] commented on PR #7236: URL: https://github.com/apache/trafficcontrol/pull/7236#issuecomment-1339994796 # [Codecov](https://codecov.io/gh/apache/trafficcontrol/pull/7236?src=pr&el=h1&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+A

[GitHub] [trafficcontrol] dependabot[bot] opened a new pull request, #7236: Bump qs from 6.5.2 to 6.5.3 in /traffic_portal/test/integration

2022-12-06 Thread GitBox
dependabot[bot] opened a new pull request, #7236: URL: https://github.com/apache/trafficcontrol/pull/7236 Bumps [qs](https://github.com/ljharb/qs) from 6.5.2 to 6.5.3. Changelog Sourced from https://github.com/ljharb/qs/blob/main/CHANGELOG.md";>qs's changelog. 6.5.3 [

[GitHub] [trafficcontrol] shamrickus merged pull request #7210: APIv5 Delivery Service updates for Traffic Portal

2022-12-06 Thread GitBox
shamrickus merged PR #7210: URL: https://github.com/apache/trafficcontrol/pull/7210 -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: issues-unsubscr...@t

[GitHub] [trafficcontrol] codecov[bot] commented on pull request #7235: Fix APIv4 and under DSRs not having Original set on Update DSRs

2022-12-06 Thread GitBox
codecov[bot] commented on PR #7235: URL: https://github.com/apache/trafficcontrol/pull/7235#issuecomment-1339922932 # [Codecov](https://codecov.io/gh/apache/trafficcontrol/pull/7235?src=pr&el=h1&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+A

[GitHub] [trafficcontrol] ocket8888 opened a new pull request, #7235: Fix APIv4 and under DSRs not having Original set on Update DSRs

2022-12-06 Thread GitBox
ocket opened a new pull request, #7235: URL: https://github.com/apache/trafficcontrol/pull/7235 DSRs in versions earlier than 5.0 should have their requested _and_ original DS's set, but because of a bug in the downgrade process, the original was being discarded. This PR fixes that bug.

[GitHub] [trafficcontrol] villajo opened a new pull request, #7234: Fix issue 6533

2022-12-06 Thread GitBox
villajo opened a new pull request, #7234: URL: https://github.com/apache/trafficcontrol/pull/7234 Closes: 6533 Related: 6533 This ticket fixes an issue with logrotation in Traffic Router where the file handle wouldn't stay with the file being written to upon rotation. This would c

[GitHub] [trafficcontrol] codecov[bot] commented on pull request #7233: use a comma separated list of IPs for purge_allow_ip

2022-12-06 Thread GitBox
codecov[bot] commented on PR #7233: URL: https://github.com/apache/trafficcontrol/pull/7233#issuecomment-1339799884 # [Codecov](https://codecov.io/gh/apache/trafficcontrol/pull/7233?src=pr&el=h1&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+A

[GitHub] [trafficcontrol] jpappa200 opened a new pull request, #7233: use a comma separated list of IPs for purge_allow_ip

2022-12-06 Thread GitBox
jpappa200 opened a new pull request, #7233: URL: https://github.com/apache/trafficcontrol/pull/7233 Closes: #7232 If a profile has multiple parameters with the same name and config file, the layered profile approach will only use one parameter. this has become an issue with ip_allow

[GitHub] [trafficcontrol] jpappa200 opened a new issue, #7232: t3c doesn't add multiple purge_allow_ip parameters to ip_allow.yaml

2022-12-06 Thread GitBox
jpappa200 opened a new issue, #7232: URL: https://github.com/apache/trafficcontrol/issues/7232 ## This Bug Report affects these Traffic Control components: - Traffic Control Cache Config (`t3c`, formerly ORT) ## Current behavior: Because of layered profiles a

[GitHub] [trafficcontrol] shamrickus commented on a diff in pull request #7210: APIv5 Delivery Service updates for Traffic Portal

2022-12-06 Thread GitBox
shamrickus commented on code in PR #7210: URL: https://github.com/apache/trafficcontrol/pull/7210#discussion_r1041226589 ## traffic_portal/app/src/common/modules/form/deliveryService/form.deliveryService.HTTP.tpl.html: ## @@ -50,20 +50,20 @@

[GitHub] [trafficcontrol] srijeet0406 merged pull request #7216: Fix sort in server's capabilities table.

2022-12-05 Thread GitBox
srijeet0406 merged PR #7216: URL: https://github.com/apache/trafficcontrol/pull/7216 -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: issues-unsubscr...@

[GitHub] [trafficcontrol] shamrickus commented on pull request #7210: APIv5 Delivery Service updates for Traffic Portal

2022-12-05 Thread GitBox
shamrickus commented on PR #7210: URL: https://github.com/apache/trafficcontrol/pull/7210#issuecomment-1338126616 Getting a 400 when attempting to update a DS with DSRs enabled. Looks like it's not sending the `delivery_service_id` with the request. -- This is an automated message from th

[GitHub] [trafficcontrol] rimashah25 commented on a diff in pull request #7213: Added description field to server capabilities

2022-12-05 Thread GitBox
rimashah25 commented on code in PR #7213: URL: https://github.com/apache/trafficcontrol/pull/7213#discussion_r1039992971 ## traffic_ops/testing/api/v3/tc-fixtures.json: ## @@ -4822,22 +4822,28 @@ ], "serverCapabilities": [ { -"name": "foo" +

[GitHub] [trafficcontrol] shamrickus commented on pull request #7210: APIv5 Delivery Service updates for Traffic Portal

2022-12-05 Thread GitBox
shamrickus commented on PR #7210: URL: https://github.com/apache/trafficcontrol/pull/7210#issuecomment-1337904210 Looks like something is wrong with the tooltip HTML: ![image](https://user-images.githubusercontent.com/5377636/205713668-ab2bfa92-4b6e-450c-b898-d3109adcf654.png) -

[GitHub] [trafficcontrol] rimashah25 commented on a diff in pull request #7213: Added description field to server capabilities

2022-12-05 Thread GitBox
rimashah25 commented on code in PR #7213: URL: https://github.com/apache/trafficcontrol/pull/7213#discussion_r1039910430 ## traffic_portal/app/src/common/modules/form/serverCapability/form.serverCapability.tpl.html: ## @@ -41,6 +41,13 @@

[GitHub] [trafficcontrol] srijeet0406 commented on a diff in pull request #7216: Fix sort in server's capabilities table.

2022-12-05 Thread GitBox
srijeet0406 commented on code in PR #7216: URL: https://github.com/apache/trafficcontrol/pull/7216#discussion_r1039844609 ## CHANGELOG.md: ## @@ -31,6 +31,7 @@ The format is based on [Keep a Changelog](http://keepachangelog.com/en/1.0.0/). - Switched Delivery Service active st

[GitHub] [trafficcontrol] rimashah25 commented on a diff in pull request #7216: Fix sort in server's capabilities table.

2022-12-05 Thread GitBox
rimashah25 commented on code in PR #7216: URL: https://github.com/apache/trafficcontrol/pull/7216#discussion_r1039785274 ## CHANGELOG.md: ## @@ -31,6 +31,7 @@ The format is based on [Keep a Changelog](http://keepachangelog.com/en/1.0.0/). - Switched Delivery Service active sta

[GitHub] [trafficcontrol] codecov[bot] commented on pull request #7231: Fix shared usernames display while retrieving CDN locks

2022-12-04 Thread GitBox
codecov[bot] commented on PR #7231: URL: https://github.com/apache/trafficcontrol/pull/7231#issuecomment-1336886240 # [Codecov](https://codecov.io/gh/apache/trafficcontrol/pull/7231?src=pr&el=h1&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+A

[GitHub] [trafficcontrol] srijeet0406 opened a new pull request, #7231: Fix shared usernames display while retrieving CDN locks

2022-12-04 Thread GitBox
srijeet0406 opened a new pull request, #7231: URL: https://github.com/apache/trafficcontrol/pull/7231 This PR is not related to any issue. ## Which Traffic Control components are affected by this PR? - Traffic Ops - Traffic Portal ## What is the best wa

[GitHub] [trafficcontrol] srijeet0406 commented on a diff in pull request #7216: Fix sort in server's capabilities table.

2022-12-04 Thread GitBox
srijeet0406 commented on code in PR #7216: URL: https://github.com/apache/trafficcontrol/pull/7216#discussion_r1039140056 ## CHANGELOG.md: ## @@ -31,6 +31,7 @@ The format is based on [Keep a Changelog](http://keepachangelog.com/en/1.0.0/). - Switched Delivery Service active st

[GitHub] [trafficcontrol] zrhoffman merged pull request #7230: Add Traffic Router unit tests to Codecov

2022-12-02 Thread GitBox
zrhoffman merged PR #7230: URL: https://github.com/apache/trafficcontrol/pull/7230 -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: issues-unsubscr...@tr

[GitHub] [trafficcontrol] codecov[bot] commented on pull request #7230: Add Traffic Router unit tests to Codecov

2022-12-02 Thread GitBox
codecov[bot] commented on PR #7230: URL: https://github.com/apache/trafficcontrol/pull/7230#issuecomment-1335958006 # [Codecov](https://codecov.io/gh/apache/trafficcontrol/pull/7230?src=pr&el=h1&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+A

[GitHub] [trafficcontrol] zrhoffman commented on a diff in pull request #7230: Add Traffic Router unit tests to Codecov

2022-12-02 Thread GitBox
zrhoffman commented on code in PR #7230: URL: https://github.com/apache/trafficcontrol/pull/7230#discussion_r1038622457 ## traffic_router/pom.xml: ## @@ -71,6 +71,19 @@ true +

[GitHub] [trafficcontrol] ericholguin opened a new pull request, #7230: Add Traffic Router unit tests too Codecov

2022-12-02 Thread GitBox
ericholguin opened a new pull request, #7230: URL: https://github.com/apache/trafficcontrol/pull/7230 Adds the jacoco plugin in order to enable code coverage reports Codecov can leverage these report results to determine test coverage ## Which Traffic Control compone

[GitHub] [trafficcontrol] zrhoffman merged pull request #7226: Add Unit Tests to Codecov

2022-12-02 Thread GitBox
zrhoffman merged PR #7226: URL: https://github.com/apache/trafficcontrol/pull/7226 -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: issues-unsubscr...@tr

[GitHub] [trafficcontrol] ocket8888 commented on issue #6563: The example Ansible dynamic inventory script exits with a KeyError exception.

2022-12-02 Thread GitBox
ocket commented on issue #6563: URL: https://github.com/apache/trafficcontrol/issues/6563#issuecomment-1335529389 In 6.x the Ansible scripts need a version of the TO client that defaults to using APIv2 - specifically because of that network interface change. What version is your `traff

[GitHub] [trafficcontrol] smalenfant commented on issue #6563: The example Ansible dynamic inventory script exits with a KeyError exception.

2022-12-02 Thread GitBox
smalenfant commented on issue #6563: URL: https://github.com/apache/trafficcontrol/issues/6563#issuecomment-1335517430 I have been having similar issues with API 3.0 because it won't return ipAddress and ipAddress6 anymore. This is now change with interfaces. This is quite a breaking

[GitHub] [trafficcontrol] ocket8888 merged pull request #7229: ATC Collaborators for December 2022

2022-12-01 Thread GitBox
ocket merged PR #7229: URL: https://github.com/apache/trafficcontrol/pull/7229 -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: issues-unsubscr...@tr

[GitHub] [trafficcontrol] asf-ci opened a new pull request, #7229: ATC Collaborators for December 2022

2022-12-01 Thread GitBox
asf-ci opened a new pull request, #7229: URL: https://github.com/apache/trafficcontrol/pull/7229 This PR uses [`.asf.yaml`](https://s.apache.org/asfyamltriage) to assign the GitHub [Triage role](https://docs.github.com/en/organizations/managing-access-to-your-organizations-repositories/repo

[GitHub] [trafficcontrol] zrhoffman commented on a diff in pull request #7226: Add Unit Tests to Codecov

2022-11-30 Thread GitBox
zrhoffman commented on code in PR #7226: URL: https://github.com/apache/trafficcontrol/pull/7226#discussion_r1036557410 ## .github/actions/go-test/entrypoint.sh: ## @@ -34,9 +34,7 @@ if [ -z "$INPUT_DIR" ]; then fi # Need to fetch golang.org/x/* dependencies -if ! [ -d "${GI

[GitHub] [trafficcontrol] zrhoffman commented on a diff in pull request #7226: Add Unit Tests to Codecov

2022-11-30 Thread GitBox
zrhoffman commented on code in PR #7226: URL: https://github.com/apache/trafficcontrol/pull/7226#discussion_r1036551896 ## .codecov.yml: ## @@ -38,8 +56,4 @@ flags: v5: paths: - ".*" -carryforward: true - - - - +carryforward: true Review Comment: Need

[GitHub] [trafficcontrol] zrhoffman commented on a diff in pull request #7226: Add Unit Tests to Codecov

2022-11-30 Thread GitBox
zrhoffman commented on code in PR #7226: URL: https://github.com/apache/trafficcontrol/pull/7226#discussion_r1036522283 ## .codecov.yml: ## @@ -0,0 +1,45 @@ +flags: Review Comment: `.codecov.yml` needs an Apache License header -- This is an automated message from the Apa

[GitHub] [trafficcontrol] zrhoffman commented on a diff in pull request #7226: Add Unit Tests to Codecov

2022-11-30 Thread GitBox
zrhoffman commented on code in PR #7226: URL: https://github.com/apache/trafficcontrol/pull/7226#discussion_r1036520185 ## .github/workflows/go.unit.tests.yaml: ## @@ -73,11 +73,177 @@ jobs: key: docker-images/alpine@${{ env.ALPINE_VERSION }}.tar.gz - name: Import

[GitHub] [trafficcontrol] ocket8888 commented on a diff in pull request #7224: Add required capabilities to delivery service structure

2022-11-30 Thread GitBox
ocket commented on code in PR #7224: URL: https://github.com/apache/trafficcontrol/pull/7224#discussion_r1035362614 ## CHANGELOG.md: ## @@ -24,6 +24,7 @@ The format is based on [Keep a Changelog](http://keepachangelog.com/en/1.0.0/). - [#7113](https://github.com/apache/tra

[GitHub] [trafficcontrol] smalenfant opened a new issue, #7228: Max origin connection: dynamically update based on operation status (not admin status)

2022-11-30 Thread GitBox
smalenfant opened a new issue, #7228: URL: https://github.com/apache/trafficcontrol/issues/7228 ## This Improvement request (usability, performance, tech debt, etc.) affects these Traffic Control components: - Traffic Control Cache Config (`t3c`, formerly ORT) - Traffic Ops - Tr

[GitHub] [trafficcontrol] ocket8888 opened a new pull request, #7227: Traffic Portal library typings

2022-11-29 Thread GitBox
ocket opened a new pull request, #7227: URL: https://github.com/apache/trafficcontrol/pull/7227 I'm trying to add some typings to Traffic Portal things, but every PR that does that will need to add typings for JS libraries we use. So, this adds them in its own PR, to help keep the other

[GitHub] [trafficcontrol] codecov[bot] commented on pull request #7226: Add Unit Tests to Codecov

2022-11-29 Thread GitBox
codecov[bot] commented on PR #7226: URL: https://github.com/apache/trafficcontrol/pull/7226#issuecomment-1331474941 # [Codecov](https://codecov.io/gh/apache/trafficcontrol/pull/7226?src=pr&el=h1&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+A

[GitHub] [trafficcontrol] ericholguin opened a new pull request, #7226: Add Unit Tests to Codecov

2022-11-29 Thread GitBox
ericholguin opened a new pull request, #7226: URL: https://github.com/apache/trafficcontrol/pull/7226 With this PR we are adding the Go Unit Tests to Codecov ## Which Traffic Control components are affected by this PR? - GitHub Actions ## What is t

[GitHub] [trafficcontrol] ocket8888 opened a new issue, #7225: APIv4 and v5 docs still list `id` as a property of Roles, despite being removed in v4.

2022-11-29 Thread GitBox
ocket opened a new issue, #7225: URL: https://github.com/apache/trafficcontrol/issues/7225 ## This Bug Report affects these Traffic Control components: - Documentation ## Current behavior: The docs for the `/roles` endpoint of API versions 4 and 5 still list in their respons

[GitHub] [trafficcontrol] srijeet0406 closed issue #7222: TO DB migrations: cannot cast jsonb string to type boolean

2022-11-28 Thread GitBox
srijeet0406 closed issue #7222: TO DB migrations: cannot cast jsonb string to type boolean URL: https://github.com/apache/trafficcontrol/issues/7222 -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to t

[GitHub] [trafficcontrol] srijeet0406 merged pull request #7223: Use strings for JSONB string comparisons

2022-11-28 Thread GitBox
srijeet0406 merged PR #7223: URL: https://github.com/apache/trafficcontrol/pull/7223 -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: issues-unsubscr...@

[GitHub] [trafficcontrol] codecov[bot] commented on pull request #7224: Add required capabilities to delivery service structure

2022-11-28 Thread GitBox
codecov[bot] commented on PR #7224: URL: https://github.com/apache/trafficcontrol/pull/7224#issuecomment-1329705215 # [Codecov](https://codecov.io/gh/apache/trafficcontrol/pull/7224?src=pr&el=h1&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+A

[GitHub] [trafficcontrol] srijeet0406 closed pull request #7186: Add required capabilities to delivery service structure

2022-11-28 Thread GitBox
srijeet0406 closed pull request #7186: Add required capabilities to delivery service structure URL: https://github.com/apache/trafficcontrol/pull/7186 -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to

[GitHub] [trafficcontrol] srijeet0406 commented on pull request #7186: Add required capabilities to delivery service structure

2022-11-28 Thread GitBox
srijeet0406 commented on PR #7186: URL: https://github.com/apache/trafficcontrol/pull/7186#issuecomment-1329693104 Closed in favor of https://github.com/apache/trafficcontrol/pull/7224/ -- This is an automated message from the Apache Git Service. To respond to the message, please log on to

[GitHub] [trafficcontrol] srijeet0406 opened a new pull request, #7224: Add required capabilities to delivery service structure

2022-11-28 Thread GitBox
srijeet0406 opened a new pull request, #7224: URL: https://github.com/apache/trafficcontrol/pull/7224 This PR adds the `required capabilities` into the `deliveryservice` structure. ## Which Traffic Control components are affected by this PR? - Documentation - Tra

[GitHub] [trafficcontrol] zrhoffman opened a new pull request, #7223: Use strings for JSONB string comparisons

2022-11-28 Thread GitBox
zrhoffman opened a new pull request, #7223: URL: https://github.com/apache/trafficcontrol/pull/7223 This PR fixes #7222 by using string comparisons in the migrations ## Which Traffic Control components are affected by this PR? - Traffic Ops - database migrations

[GitHub] [trafficcontrol] zrhoffman opened a new issue, #7222: TO DB migrations: cannot cast jsonb string to type boolean

2022-11-28 Thread GitBox
zrhoffman opened a new issue, #7222: URL: https://github.com/apache/trafficcontrol/issues/7222 ## This Bug Report affects these Traffic Control components: - Traffic Ops ## Current behavior: If the `delivery_service_requests` table is non-empty, running the `

[GitHub] [trafficcontrol] zrhoffman merged pull request #7218: Add a link to the blueprint to the DS active flag changelog entry

2022-11-28 Thread GitBox
zrhoffman merged PR #7218: URL: https://github.com/apache/trafficcontrol/pull/7218 -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: issues-unsubscr...@tr

[GitHub] [trafficcontrol] zrhoffman merged pull request #7217: Fix unable to create DSRs for updating existing DSs

2022-11-28 Thread GitBox
zrhoffman merged PR #7217: URL: https://github.com/apache/trafficcontrol/pull/7217 -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: issues-unsubscr...@tr

[GitHub] [trafficcontrol] zrhoffman closed issue #7212: Creating a DSR: cannot update non-existent Delivery Service ''

2022-11-28 Thread GitBox
zrhoffman closed issue #7212: Creating a DSR: cannot update non-existent Delivery Service '' URL: https://github.com/apache/trafficcontrol/issues/7212 -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to

[GitHub] [trafficcontrol] ocket8888 opened a new issue, #7221: Broken request structure spec in cdn locks description

2022-11-23 Thread GitBox
ocket opened a new issue, #7221: URL: https://github.com/apache/trafficcontrol/issues/7221 ## This Bug Report affects these Traffic Control components: - Documentation ## Current behavior: [The current docs for the `cdn_locks` TO API endpoint](https://traffic-control-cdn.rea

[GitHub] [trafficcontrol] ocket8888 opened a new pull request, #7220: Tpv2 snapshot diff page

2022-11-23 Thread GitBox
ocket opened a new pull request, #7220: URL: https://github.com/apache/trafficcontrol/pull/7220 Adds a page for showing snapshot diffs to TPv2. It's not complete, only shows diffs for the `contentServers`, `contentRouters`, and `config` sections so far. Getting the rest done will be a b

[GitHub] [trafficcontrol] ocket8888 opened a new pull request, #7219: TP Utility types

2022-11-22 Thread GitBox
ocket opened a new pull request, #7219: URL: https://github.com/apache/trafficcontrol/pull/7219 This PR adds types to the "Service Utilities". Those being: - CollectionUtils - DateUtils - DeliveryServiceUtils - FileUtils - FormUtils - LocationUtils - NumberUtils

[GitHub] [trafficcontrol] codecov[bot] commented on pull request #7217: Fix unable to create DSRs for updating existing DSs

2022-11-22 Thread GitBox
codecov[bot] commented on PR #7217: URL: https://github.com/apache/trafficcontrol/pull/7217#issuecomment-1324427851 # [Codecov](https://codecov.io/gh/apache/trafficcontrol/pull/7217?src=pr&el=h1&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+A

[GitHub] [trafficcontrol] ocket8888 opened a new pull request, #7218: Add a link to the blueprint to the DS active flag changelog entry

2022-11-22 Thread GitBox
ocket opened a new pull request, #7218: URL: https://github.com/apache/trafficcontrol/pull/7218 Title ## Which Traffic Control components are affected by this PR? None ## What is the best way to verify this PR? Read the changed line, maybe click the link to mak

[GitHub] [trafficcontrol] ocket8888 opened a new pull request, #7217: Fix unable to create DSRs for updating existing DSRs

2022-11-22 Thread GitBox
ocket opened a new pull request, #7217: URL: https://github.com/apache/trafficcontrol/pull/7217 Fixes #7212 ## Which Traffic Control components are affected by this PR? - Traffic Ops ## What is the best way to verify this PR? Make sure the tests pass. To test m

[GitHub] [trafficcontrol] ocket8888 commented on a diff in pull request #7213: Added description field to server capabilities

2022-11-22 Thread GitBox
ocket commented on code in PR #7213: URL: https://github.com/apache/trafficcontrol/pull/7213#discussion_r1029909191 ## docs/source/api/v3/server_capabilities.rst: ## @@ -70,6 +71,7 @@ Response Structure "response": [ {

[GitHub] [trafficcontrol] ocket8888 merged pull request #7194: Added catch for missing POST body when posted to profileparameters

2022-11-22 Thread GitBox
ocket merged PR #7194: URL: https://github.com/apache/trafficcontrol/pull/7194 -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: issues-unsubscr...@tr

[GitHub] [trafficcontrol] ocket8888 closed issue #4428: profileparameters POST request with no request body returns Internal Server Error

2022-11-22 Thread GitBox
ocket closed issue #4428: profileparameters POST request with no request body returns Internal Server Error URL: https://github.com/apache/trafficcontrol/issues/4428 -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the

[GitHub] [trafficcontrol] rimashah25 opened a new pull request, #7216: Fix sort in server's capabilities table.

2022-11-22 Thread GitBox
rimashah25 opened a new pull request, #7216: URL: https://github.com/apache/trafficcontrol/pull/7216 ## Which Traffic Control components are affected by this PR? - Traffic Portal ## What is the best way to verify this PR? Fixed sorting in Configure > S

[GitHub] [trafficcontrol] dependabot[bot] commented on pull request #7201: Bump minimatch and nightwatch in /experimental/traffic-portal

2022-11-22 Thread GitBox
dependabot[bot] commented on PR #7201: URL: https://github.com/apache/trafficcontrol/pull/7201#issuecomment-1324051851 Looks like these dependencies are up-to-date now, so this is no longer needed. -- This is an automated message from the Apache Git Service. To respond to the message, ple

[GitHub] [trafficcontrol] dependabot[bot] closed pull request #7201: Bump minimatch and nightwatch in /experimental/traffic-portal

2022-11-22 Thread GitBox
dependabot[bot] closed pull request #7201: Bump minimatch and nightwatch in /experimental/traffic-portal URL: https://github.com/apache/trafficcontrol/pull/7201 -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL abov

[GitHub] [trafficcontrol] ocket8888 merged pull request #7203: TPv2: Add Divisions Pages

2022-11-22 Thread GitBox
ocket merged PR #7203: URL: https://github.com/apache/trafficcontrol/pull/7203 -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: issues-unsubscr...@tr

[GitHub] [trafficcontrol] shamrickus merged pull request #7214: Bump engine.io from 6.2.0 to 6.2.1 in /experimental/traffic-portal

2022-11-22 Thread GitBox
shamrickus merged PR #7214: URL: https://github.com/apache/trafficcontrol/pull/7214 -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: issues-unsubscr...@t

[GitHub] [trafficcontrol] shamrickus merged pull request #7215: Bump engine.io from 6.2.0 to 6.2.1 in /traffic_portal

2022-11-22 Thread GitBox
shamrickus merged PR #7215: URL: https://github.com/apache/trafficcontrol/pull/7215 -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: issues-unsubscr...@t

[GitHub] [trafficcontrol] codecov[bot] commented on pull request #7215: Bump engine.io from 6.2.0 to 6.2.1 in /traffic_portal

2022-11-21 Thread GitBox
codecov[bot] commented on PR #7215: URL: https://github.com/apache/trafficcontrol/pull/7215#issuecomment-1323234791 # [Codecov](https://codecov.io/gh/apache/trafficcontrol/pull/7215?src=pr&el=h1&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+A

[GitHub] [trafficcontrol] dependabot[bot] opened a new pull request, #7215: Bump engine.io from 6.2.0 to 6.2.1 in /traffic_portal

2022-11-21 Thread GitBox
dependabot[bot] opened a new pull request, #7215: URL: https://github.com/apache/trafficcontrol/pull/7215 Bumps [engine.io](https://github.com/socketio/engine.io) from 6.2.0 to 6.2.1. Release notes Sourced from https://github.com/socketio/engine.io/releases";>engine.io's releases.

[GitHub] [trafficcontrol] codecov[bot] commented on pull request #7214: Bump engine.io from 6.2.0 to 6.2.1 in /experimental/traffic-portal

2022-11-21 Thread GitBox
codecov[bot] commented on PR #7214: URL: https://github.com/apache/trafficcontrol/pull/7214#issuecomment-1323104866 # [Codecov](https://codecov.io/gh/apache/trafficcontrol/pull/7214?src=pr&el=h1&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+A

[GitHub] [trafficcontrol] dependabot[bot] opened a new pull request, #7214: Bump engine.io from 6.2.0 to 6.2.1 in /experimental/traffic-portal

2022-11-21 Thread GitBox
dependabot[bot] opened a new pull request, #7214: URL: https://github.com/apache/trafficcontrol/pull/7214 Bumps [engine.io](https://github.com/socketio/engine.io) from 6.2.0 to 6.2.1. Release notes Sourced from https://github.com/socketio/engine.io/releases";>engine.io's releases.

[GitHub] [trafficcontrol] codecov[bot] commented on pull request #7213: Added description field to server capabilities

2022-11-21 Thread GitBox
codecov[bot] commented on PR #7213: URL: https://github.com/apache/trafficcontrol/pull/7213#issuecomment-1322885454 # [Codecov](https://codecov.io/gh/apache/trafficcontrol/pull/7213?src=pr&el=h1&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+A

[GitHub] [trafficcontrol] rimashah25 opened a new pull request, #7213: Added description field to server capabilities

2022-11-21 Thread GitBox
rimashah25 opened a new pull request, #7213: URL: https://github.com/apache/trafficcontrol/pull/7213 Closed: #https://github.com/apache/trafficcontrol/issues/6234 ## Which Traffic Control components are affected by this PR? - Documentation - Traffic Ops - Traff

[GitHub] [trafficcontrol] zrhoffman opened a new issue, #7212: Creating a DSR: cannot update non-existent Delivery Service ''

2022-11-21 Thread GitBox
zrhoffman opened a new issue, #7212: URL: https://github.com/apache/trafficcontrol/issues/7212 ## This Bug Report affects these Traffic Control components: - Traffic Ops - Traffic Portal ## Steps to reproduce: 1. Enable Delivery Service Requests by setting

[GitHub] [trafficcontrol] zrhoffman merged pull request #7211: Upload TO Integration test coverage to Codecov

2022-11-21 Thread GitBox
zrhoffman merged PR #7211: URL: https://github.com/apache/trafficcontrol/pull/7211 -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: issues-unsubscr...@tr

[GitHub] [trafficcontrol] ocket8888 commented on a diff in pull request #7203: TPv2: Add Divisions Pages

2022-11-21 Thread GitBox
ocket commented on code in PR #7203: URL: https://github.com/apache/trafficcontrol/pull/7203#discussion_r1028533974 ## experimental/traffic-portal/src/app/core/cache-groups/divisions/detail/division-detail.component.ts: ## @@ -0,0 +1,102 @@ +/* +* Licensed under the Apache L

[GitHub] [trafficcontrol] ocket8888 commented on a diff in pull request #7203: TPv2: Add Divisions Pages

2022-11-21 Thread GitBox
ocket commented on code in PR #7203: URL: https://github.com/apache/trafficcontrol/pull/7203#discussion_r1028530633 ## experimental/traffic-portal/src/app/core/cache-groups/divisions/detail/division-detail.component.ts: ## @@ -0,0 +1,102 @@ +/* +* Licensed under the Apache L

[GitHub] [trafficcontrol] ocket8888 commented on a diff in pull request #7203: TPv2: Add Divisions Pages

2022-11-21 Thread GitBox
ocket commented on code in PR #7203: URL: https://github.com/apache/trafficcontrol/pull/7203#discussion_r1025500951 ## experimental/traffic-portal/src/app/api/cache-group.service.ts: ## @@ -13,6 +13,7 @@ */ import { HttpClient } from "@angular/common/http"; import { Injec

[GitHub] [trafficcontrol] codecov[bot] commented on pull request #7211: Upload TO Integration test coverage to Codecov

2022-11-21 Thread GitBox
codecov[bot] commented on PR #7211: URL: https://github.com/apache/trafficcontrol/pull/7211#issuecomment-1322519964 # [Codecov](https://codecov.io/gh/apache/trafficcontrol/pull/7211?src=pr&el=h1&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+A

[GitHub] [trafficcontrol] ericholguin opened a new pull request, #7211: Upload TO Integration test coverage to Codecov

2022-11-21 Thread GitBox
ericholguin opened a new pull request, #7211: URL: https://github.com/apache/trafficcontrol/pull/7211 Adds the Codecov GHA to the TO Integration Test workflow and modifies the shell script to use golang's test coverage and output to the file used by Codecov ## Which

[GitHub] [trafficcontrol] kdamichie commented on a diff in pull request #7194: Added catch for missing POST body when posted to profileparameters

2022-11-21 Thread GitBox
kdamichie commented on code in PR #7194: URL: https://github.com/apache/trafficcontrol/pull/7194#discussion_r1028275283 ## traffic_ops/testing/api/v3/profile_parameters_test.go: ## @@ -163,6 +165,16 @@ func TestProfileParameters(t *testing.T) { }) } +func TestPostWith

[GitHub] [trafficcontrol] srijeet0406 commented on a diff in pull request #7194: Added catch for missing POST body when posted to profileparameters

2022-11-21 Thread GitBox
srijeet0406 commented on code in PR #7194: URL: https://github.com/apache/trafficcontrol/pull/7194#discussion_r1028263034 ## traffic_ops/testing/api/v3/profile_parameters_test.go: ## @@ -163,6 +165,16 @@ func TestProfileParameters(t *testing.T) { }) } +func TestPostWi

[GitHub] [trafficcontrol] zrhoffman merged pull request #7184: Add a button to toggle the visibility of all sensitive fields to DS forms

2022-11-21 Thread GitBox
zrhoffman merged PR #7184: URL: https://github.com/apache/trafficcontrol/pull/7184 -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: issues-unsubscr...@tr

<    1   2   3   4   5   6   7   8   9   10   >