[GitHub] [trafficcontrol] ocket8888 commented on a diff in pull request #7073: Adding the `asn` field to all `GET` endpoints that return a `server` object

2022-09-23 Thread GitBox
ocket commented on code in PR #7073: URL: https://github.com/apache/trafficcontrol/pull/7073#discussion_r978711512 ## lib/go-tc/deliveryservice_servers.go: ## @@ -206,7 +206,8 @@ type DSServerResponseV40 struct { Alerts } -// for servers assigned to a Delivery

[GitHub] [trafficcontrol] ocket8888 commented on a diff in pull request #7073: Adding the `asn` field to all `GET` endpoints that return a `server` object

2022-09-21 Thread GitBox
ocket commented on code in PR #7073: URL: https://github.com/apache/trafficcontrol/pull/7073#discussion_r976670398 ## lib/go-tc/deliveryservice_servers.go: ## @@ -189,21 +189,33 @@ type DSServerResponseV30 struct { // DSServerV4 contains information for a V4.x Delivery

[GitHub] [trafficcontrol] ocket8888 commented on a diff in pull request #7073: Adding the `asn` field to all `GET` endpoints that return a `server` object

2022-09-19 Thread GitBox
ocket commented on code in PR #7073: URL: https://github.com/apache/trafficcontrol/pull/7073#discussion_r974713602 ## traffic_ops/traffic_ops_golang/deliveryservice/eligible.go: ## @@ -96,6 +96,15 @@ func GetServersEligible(w http.ResponseWriter, r *http.Request) {

[GitHub] [trafficcontrol] ocket8888 commented on a diff in pull request #7073: Adding the `asn` field to all `GET` endpoints that return a `server` object

2022-09-19 Thread GitBox
ocket commented on code in PR #7073: URL: https://github.com/apache/trafficcontrol/pull/7073#discussion_r974569641 ## traffic_ops/traffic_ops_golang/deliveryservice/eligible.go: ## @@ -96,6 +96,15 @@ func GetServersEligible(w http.ResponseWriter, r *http.Request) {