[GitHub] [trafficcontrol] rob05c commented on a diff in pull request #7096: Add health client parent health

2022-10-24 Thread GitBox
rob05c commented on code in PR #7096: URL: https://github.com/apache/trafficcontrol/pull/7096#discussion_r1003764988 ## tc-health-client/config/config_test.go: ## @@ -37,7 +37,7 @@ func TestLoadConfig(t *testing.T) { } cfg := Cfg{ -

[GitHub] [trafficcontrol] rob05c commented on a diff in pull request #7096: Add health client parent health

2022-10-24 Thread GitBox
rob05c commented on code in PR #7096: URL: https://github.com/apache/trafficcontrol/pull/7096#discussion_r1003764401 ## tc-health-client/tmagent/markdownservice.go: ## @@ -0,0 +1,484 @@ +package tmagent + +/* + * Licensed to the Apache Software Foundation (ASF) under one + * or

[GitHub] [trafficcontrol] rob05c commented on a diff in pull request #7096: Add health client parent health

2022-10-24 Thread GitBox
rob05c commented on code in PR #7096: URL: https://github.com/apache/trafficcontrol/pull/7096#discussion_r1003762350 ## tc-health-client/sar/ephemeralportholder.go: ## @@ -0,0 +1,77 @@ +package sar + +/* + * Licensed to the Apache Software Foundation (ASF) under one + * or more

[GitHub] [trafficcontrol] rob05c commented on a diff in pull request #7096: Add health client parent health

2022-09-29 Thread GitBox
rob05c commented on code in PR #7096: URL: https://github.com/apache/trafficcontrol/pull/7096#discussion_r983631749 ## tc-health-client/sar/multisar.go: ## @@ -0,0 +1,388 @@ +// package sar implements a syn-ack-rst health ping. +// It sends a TCP SYN, waits for an ACK, then

[GitHub] [trafficcontrol] rob05c commented on a diff in pull request #7096: Add health client parent health

2022-09-28 Thread GitBox
rob05c commented on code in PR #7096: URL: https://github.com/apache/trafficcontrol/pull/7096#discussion_r982915522 ## tc-health-client/sar/sar.go: ## @@ -0,0 +1,348 @@ +// package sar implements a syn-ack-rst health ping. +// It sends a TCP SYN, waits for an ACK, then