[GitHub] [trafficcontrol] zrhoffman commented on a diff in pull request #7099: Delivery Service Active Flag Rework

zrhoffman commented on code in PR #7099: URL: https://github.com/apache/trafficcontrol/pull/7099#discussion_r1025629258 ## traffic_ops/testing/api/utils/utils.go: ## @@ -119,7 +130,7 @@ type V3TestData struct { // V3TestDataT represents the data needed for testing the v3 api

[GitHub] [trafficcontrol] zrhoffman commented on a diff in pull request #7099: Delivery Service Active Flag Rework

zrhoffman commented on code in PR #7099: URL: https://github.com/apache/trafficcontrol/pull/7099#discussion_r1025615043 ## traffic_ops/testing/api/utils/utils.go: ## @@ -119,7 +130,7 @@ type V3TestData struct { // V3TestDataT represents the data needed for testing the v3 api

[GitHub] [trafficcontrol] zrhoffman commented on a diff in pull request #7099: Delivery Service Active Flag Rework

zrhoffman commented on code in PR #7099: URL: https://github.com/apache/trafficcontrol/pull/7099#discussion_r1025600442 ## traffic_ops/testing/api/utils/utils.go: ## @@ -119,7 +130,7 @@ type V3TestData struct { // V3TestDataT represents the data needed for testing the v3 api

[GitHub] [trafficcontrol] zrhoffman commented on a diff in pull request #7099: Delivery Service Active Flag Rework

zrhoffman commented on code in PR #7099: URL: https://github.com/apache/trafficcontrol/pull/7099#discussion_r1025600442 ## traffic_ops/testing/api/utils/utils.go: ## @@ -119,7 +130,7 @@ type V3TestData struct { // V3TestDataT represents the data needed for testing the v3 api

[GitHub] [trafficcontrol] zrhoffman commented on a diff in pull request #7099: Delivery Service Active Flag Rework

zrhoffman commented on code in PR #7099: URL: https://github.com/apache/trafficcontrol/pull/7099#discussion_r1025592447 ## traffic_ops/traffic_ops_golang/crconfig/deliveryservice.go: ## @@ -145,7 +145,7 @@ FROM deliveryservice AS d INNER JOIN type AS t ON t.id = d.type LEFT

[GitHub] [trafficcontrol] zrhoffman commented on a diff in pull request #7099: Delivery Service Active Flag Rework

zrhoffman commented on code in PR #7099: URL: https://github.com/apache/trafficcontrol/pull/7099#discussion_r1025573120 ## traffic_ops/testing/api/utils/utils.go: ## @@ -119,7 +130,7 @@ type V3TestData struct { // V3TestDataT represents the data needed for testing the v3 api

[GitHub] [trafficcontrol] zrhoffman commented on a diff in pull request #7099: Delivery Service Active Flag Rework

zrhoffman commented on code in PR #7099: URL: https://github.com/apache/trafficcontrol/pull/7099#discussion_r1025419058 ## lib/go-tc/copy.go: ## @@ -0,0 +1,112 @@ +package tc Review Comment: `copy.go` belongs in the `go-util` package -- This is an automated message from

[GitHub] [trafficcontrol] zrhoffman commented on a diff in pull request #7099: Delivery Service Active Flag Rework

zrhoffman commented on code in PR #7099: URL: https://github.com/apache/trafficcontrol/pull/7099#discussion_r1025557008 ## lib/go-tc/copy.go: ## @@ -0,0 +1,112 @@ +package tc Review Comment: That's true. What you did is definitely an improvement already, so maybe someone

[GitHub] [trafficcontrol] zrhoffman commented on a diff in pull request #7099: Delivery Service Active Flag Rework

zrhoffman commented on code in PR #7099: URL: https://github.com/apache/trafficcontrol/pull/7099#discussion_r1025548842 ## traffic_ops/testing/api/utils/utils.go: ## @@ -119,7 +130,7 @@ type V3TestData struct { // V3TestDataT represents the data needed for testing the v3 api

[GitHub] [trafficcontrol] zrhoffman commented on a diff in pull request #7099: Delivery Service Active Flag Rework

zrhoffman commented on code in PR #7099: URL: https://github.com/apache/trafficcontrol/pull/7099#discussion_r1025539566 ## traffic_ops/testing/api/utils/utils.go: ## @@ -119,7 +130,7 @@ type V3TestData struct { // V3TestDataT represents the data needed for testing the v3 api

[GitHub] [trafficcontrol] zrhoffman commented on a diff in pull request #7099: Delivery Service Active Flag Rework

zrhoffman commented on code in PR #7099: URL: https://github.com/apache/trafficcontrol/pull/7099#discussion_r1025539566 ## traffic_ops/testing/api/utils/utils.go: ## @@ -119,7 +130,7 @@ type V3TestData struct { // V3TestDataT represents the data needed for testing the v3 api

[GitHub] [trafficcontrol] zrhoffman commented on a diff in pull request #7099: Delivery Service Active Flag Rework

zrhoffman commented on code in PR #7099: URL: https://github.com/apache/trafficcontrol/pull/7099#discussion_r1025536834 ## traffic_ops/testing/api/utils/utils.go: ## @@ -119,7 +130,7 @@ type V3TestData struct { // V3TestDataT represents the data needed for testing the v3 api

[GitHub] [trafficcontrol] zrhoffman commented on a diff in pull request #7099: Delivery Service Active Flag Rework

zrhoffman commented on code in PR #7099: URL: https://github.com/apache/trafficcontrol/pull/7099#discussion_r1025419058 ## lib/go-tc/copy.go: ## @@ -0,0 +1,112 @@ +package tc Review Comment: `copy.go` belongs in the `go-utils` package ##