[GitHub] incubator-trafficcontrol pull request #214: [TC-94] - adds deliveryservice_r...

2017-01-23 Thread mitchell852
GitHub user mitchell852 opened a pull request: https://github.com/apache/incubator-trafficcontrol/pull/214 [TC-94] - adds deliveryservice_regex crud capabilities You can merge this pull request into a Git repository by running: $ git pull

[GitHub] incubator-trafficcontrol pull request #212: Add support for delivery service...

2017-01-23 Thread dneuman64
Github user dneuman64 commented on a diff in the pull request: https://github.com/apache/incubator-trafficcontrol/pull/212#discussion_r97409224 --- Diff: traffic_monitor/experimental/traffic_monitor/deliveryservice/stat.go --- @@ -72,7 +74,7 @@ func setStaticData(dsStats Stats,

[GitHub] incubator-trafficcontrol issue #212: Add support for delivery service thresh...

2017-01-23 Thread rob05c
Github user rob05c commented on the issue: https://github.com/apache/incubator-trafficcontrol/pull/212 Other than those 2 little things, looks great. Not enough to -1, if they take more than 5mins. --- If your project is set up for it, you can reply to this email and have your reply

[GitHub] incubator-trafficcontrol pull request #212: Add support for delivery service...

2017-01-23 Thread rob05c
Github user rob05c commented on a diff in the pull request: https://github.com/apache/incubator-trafficcontrol/pull/212#discussion_r97406714 --- Diff: traffic_monitor/experimental/traffic_monitor/static/index.html --- @@ -382,7 +386,7 @@

[GitHub] incubator-trafficcontrol pull request #212: Add support for delivery service...

2017-01-23 Thread rob05c
Github user rob05c commented on a diff in the pull request: https://github.com/apache/incubator-trafficcontrol/pull/212#discussion_r97405960 --- Diff: traffic_monitor/experimental/traffic_monitor/deliveryservice/stat.go --- @@ -72,7 +74,7 @@ func setStaticData(dsStats Stats,

[GitHub] incubator-trafficcontrol issue #209: Fix a couple of license issues for 1.8....

2017-01-23 Thread dangogh
Github user dangogh commented on the issue: https://github.com/apache/incubator-trafficcontrol/pull/209 Cleaned up LICENSE file and removed several 3rd party files that were not used. --- If your project is set up for it, you can reply to this email and have your reply appear on

[GitHub] incubator-trafficcontrol pull request #213: [TC-117] - creates a default del...

2017-01-23 Thread mitchell852
GitHub user mitchell852 opened a pull request: https://github.com/apache/incubator-trafficcontrol/pull/213 [TC-117] - creates a default deliveryservice_regex when a new ds is created at set_number=0 in the format .\*\.xml-id\..\* You can merge this pull request into a Git

[GitHub] incubator-trafficcontrol pull request #190: fix the issue failed to delete s...

2017-01-23 Thread asfgit
Github user asfgit closed the pull request at: https://github.com/apache/incubator-trafficcontrol/pull/190 --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project does not have this feature enabled and wishes so, or if

[GitHub] incubator-trafficcontrol pull request #195: Add Traffic Monitor 2.0 Cache Ca...

2017-01-23 Thread asfgit
Github user asfgit closed the pull request at: https://github.com/apache/incubator-trafficcontrol/pull/195 --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project does not have this feature enabled and wishes so, or if

[GitHub] incubator-trafficcontrol pull request #200: [TC-68] - to support an HA TO, r...

2017-01-23 Thread asfgit
Github user asfgit closed the pull request at: https://github.com/apache/incubator-trafficcontrol/pull/200 --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project does not have this feature enabled and wishes so, or if

[GitHub] incubator-trafficcontrol pull request #199: [TC-32] Addition of ATS Config A...

2017-01-23 Thread mitchell852
Github user mitchell852 commented on a diff in the pull request: https://github.com/apache/incubator-trafficcontrol/pull/199#discussion_r97381236 --- Diff: traffic_ops/app/lib/API/Configs/ApacheTrafficServer.pm --- @@ -0,0 +1,1941 @@ +package API::Configs::ApacheTrafficServer;

[GitHub] incubator-trafficcontrol pull request #199: [TC-32] Addition of ATS Config A...

2017-01-23 Thread dg4prez
Github user dg4prez commented on a diff in the pull request: https://github.com/apache/incubator-trafficcontrol/pull/199#discussion_r97381748 --- Diff: traffic_ops/app/lib/API/Configs/ApacheTrafficServer.pm --- @@ -0,0 +1,1941 @@ +package API::Configs::ApacheTrafficServer;

[GitHub] incubator-trafficcontrol pull request #208: Fix TC-110 - parameterize ip_all...

2017-01-23 Thread asfgit
Github user asfgit closed the pull request at: https://github.com/apache/incubator-trafficcontrol/pull/208 --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project does not have this feature enabled and wishes so, or if

[GitHub] incubator-trafficcontrol issue #200: [TC-68] - to support an HA TO, regex_re...

2017-01-23 Thread knutsel
Github user knutsel commented on the issue: https://github.com/apache/incubator-trafficcontrol/pull/200 I'll take a look --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project does not have this feature enabled

[GitHub] incubator-trafficcontrol pull request #208: Fix TC-110 - parameterize ip_all...

2017-01-23 Thread knutsel
Github user knutsel commented on a diff in the pull request: https://github.com/apache/incubator-trafficcontrol/pull/208#discussion_r97372213 --- Diff: traffic_ops/app/lib/UI/ConfigFiles.pm --- @@ -475,9 +475,14 @@ sub ip_allow_data { $ipallow->[$i]->{action} = 'ip_allow';

[GitHub] incubator-trafficcontrol pull request #207: [TC-109] Enhance event logging t...

2017-01-23 Thread asfgit
Github user asfgit closed the pull request at: https://github.com/apache/incubator-trafficcontrol/pull/207 --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project does not have this feature enabled and wishes so, or if

[GitHub] incubator-trafficcontrol issue #207: [TC-109] Enhance event logging to bring...

2017-01-23 Thread dneuman64
Github user dneuman64 commented on the issue: https://github.com/apache/incubator-trafficcontrol/pull/207 Taking a look at this now --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project does not have this

[GitHub] incubator-trafficcontrol pull request #206: TO - remove duplicate license an...

2017-01-23 Thread asfgit
Github user asfgit closed the pull request at: https://github.com/apache/incubator-trafficcontrol/pull/206 --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project does not have this feature enabled and wishes so, or if

[GitHub] incubator-trafficcontrol pull request #212: Add support for delivery service...

2017-01-23 Thread dneuman64
GitHub user dneuman64 opened a pull request: https://github.com/apache/incubator-trafficcontrol/pull/212 Add support for delivery service thresholds in goTM goTM now checks the Total TPS Threshold and Total Kbps Threshold defined on a delivery service and sets a delivery service to

[GitHub] incubator-trafficcontrol pull request #141: Old - do not merge, will delete

2017-01-23 Thread dg4prez
Github user dg4prez closed the pull request at: https://github.com/apache/incubator-trafficcontrol/pull/141 --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project does not have this feature enabled and wishes so, or if

[GitHub] incubator-trafficcontrol pull request #199: [TC-32] Addition of ATS Config A...

2017-01-23 Thread dg4prez
GitHub user dg4prez reopened a pull request: https://github.com/apache/incubator-trafficcontrol/pull/199 [TC-32] Addition of ATS Config API Working API for ATS config file generation, divided by three "scopes" - CDN, profile, and server. This is intended to be used for a

[GitHub] incubator-trafficcontrol issue #200: [TC-68] - to support an HA TO, regex_re...

2017-01-23 Thread mitchell852
Github user mitchell852 commented on the issue: https://github.com/apache/incubator-trafficcontrol/pull/200 @dewrich or @dangogh - can either of you review / merge? this needs to get into 2.0 so the path to HA TO is clear. thanks! --- If your project is set up for it, you can reply

[GitHub] incubator-trafficcontrol issue #141: Old - do not merge, will delete

2017-01-23 Thread mitchell852
Github user mitchell852 commented on the issue: https://github.com/apache/incubator-trafficcontrol/pull/141 @dg4prez - you want to just close this since you have opened this? https://github.com/apache/incubator-trafficcontrol/pull/199 --- If your project is set up for it,

[jira] [Commented] (TC-110) Coalesce settings for ip_allow.config should be in parameters.

2017-01-23 Thread ASF GitHub Bot (JIRA)
[ https://issues.apache.org/jira/browse/TC-110?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=15834703#comment-15834703 ] ASF GitHub Bot commented on TC-110: --- Github user mitchell852 commented on a diff in the pull request:

[jira] [Commented] (TC-110) Coalesce settings for ip_allow.config should be in parameters.

2017-01-23 Thread ASF GitHub Bot (JIRA)
[ https://issues.apache.org/jira/browse/TC-110?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=15834691#comment-15834691 ] ASF GitHub Bot commented on TC-110: --- Github user mitchell852 commented on a diff in the pull request:

[GitHub] incubator-trafficcontrol pull request #208: Fix TC-110 - parameterize ip_all...

2017-01-23 Thread mitchell852
Github user mitchell852 commented on a diff in the pull request: https://github.com/apache/incubator-trafficcontrol/pull/208#discussion_r97332624 --- Diff: traffic_ops/app/lib/UI/ConfigFiles.pm --- @@ -533,9 +550,8 @@ sub ip_allow_data { } #