[GitHub] asfgit commented on issue #2080: Add cachegroup generic crud to traffic_ops_golang

asfgit commented on issue #2080: Add cachegroup generic crud to traffic_ops_golang URL: https://github.com/apache/incubator-trafficcontrol/pull/2080#issuecomment-378443139 Refer to this link for build results (access rights to CI server needed):

[GitHub] asfgit commented on issue #2080: Add cachegroup generic crud to traffic_ops_golang

asfgit commented on issue #2080: Add cachegroup generic crud to traffic_ops_golang URL: https://github.com/apache/incubator-trafficcontrol/pull/2080#issuecomment-378439378 Refer to this link for build results (access rights to CI server needed):

[GitHub] asfgit commented on issue #2080: Add cachegroup generic crud to traffic_ops_golang

asfgit commented on issue #2080: Add cachegroup generic crud to traffic_ops_golang URL: https://github.com/apache/incubator-trafficcontrol/pull/2080#issuecomment-378416864 Refer to this link for build results (access rights to CI server needed):

[GitHub] mitchell852 commented on issue #2029: [Issue 1907] TO API for backup edge cachegroup

mitchell852 commented on issue #2029: [Issue 1907] TO API for backup edge cachegroup URL: https://github.com/apache/incubator-trafficcontrol/pull/2029#issuecomment-378402232 @hongfeiweb - we're trying to move away from "route" or "path" parameters to remove some of the ambiguity that

[GitHub] asfgit commented on issue #1889: Add TO Golang CRConfig generation

asfgit commented on issue #1889: Add TO Golang CRConfig generation URL: https://github.com/apache/incubator-trafficcontrol/pull/1889#issuecomment-378399379 Refer to this link for build results (access rights to CI server needed):

[GitHub] rob05c commented on issue #1889: Add TO Golang CRConfig generation

rob05c commented on issue #1889: Add TO Golang CRConfig generation URL: https://github.com/apache/incubator-trafficcontrol/pull/1889#issuecomment-378396610 This should be ready to be merged. It diffs identical with the Perl CRConfig generation. It has tests, via sqlmock. I

[GitHub] rob05c commented on issue #1889: Add TO Golang CRConfig generation

rob05c commented on issue #1889: Add TO Golang CRConfig generation URL: https://github.com/apache/incubator-trafficcontrol/pull/1889#issuecomment-378396610 This should be ready to be merged. It diffs identical with the Perl CRConfig generation. It has tests, via sqlmock. I

[GitHub] asfgit commented on issue #2010: Go login

asfgit commented on issue #2010: Go login URL: https://github.com/apache/incubator-trafficcontrol/pull/2010#issuecomment-378374551 Refer to this link for build results (access rights to CI server needed): https://builds.apache.org/job/incubator-trafficcontrol-PR/1321/ Test

Build failed in Jenkins: incubator-trafficcontrol-traffic_ops-test #520

See Changes: [jeffrey_elsloo] Remove broken, unused, internal steering API POST endpoint -- Started by an SCM change [EnvInject] - Loading node

[GitHub] elsloo commented on issue #2076: Remove broken, unused, internal steering API POST endpoint

elsloo commented on issue #2076: Remove broken, unused, internal steering API POST endpoint URL: https://github.com/apache/incubator-trafficcontrol/pull/2076#issuecomment-378350264 I'm good with merging this because 1) we're planning to move away from /internal routes, and 2) it's broken

Build failed in Jenkins: incubator-trafficcontrol-traffic_ops-test #519

See Changes: [jeffrey_elsloo] Remove vendored golang.org/x [jeffrey_elsloo] Add TO build go get for golang x libs -- Started by an SCM change

[GitHub] hongfeiweb commented on issue #2029: Implements https://github.com/apache/incubator-trafficcontrol/issues/…

hongfeiweb commented on issue #2029: Implements https://github.com/apache/incubator-trafficcontrol/issues/… URL: https://github.com/apache/incubator-trafficcontrol/pull/2029#issuecomment-378308231 @DylanVolz - i am not convinced that moving the URL to top level (as cachegroup_fallbacks)

[GitHub] asfgit commented on issue #2078: Remove vendored golang x

asfgit commented on issue #2078: Remove vendored golang x URL: https://github.com/apache/incubator-trafficcontrol/pull/2078#issuecomment-378308213 Refer to this link for build results (access rights to CI server needed):

[GitHub] rob05c opened a new pull request #2078: Remove vendored golang x

rob05c opened a new pull request #2078: Remove vendored golang x URL: https://github.com/apache/incubator-trafficcontrol/pull/2078 Marking bug, because vendored x can break new compilers, and we specifically need to remove x/crypto for the Release.

[GitHub] rob05c commented on issue #2078: Remove vendored golang x

rob05c commented on issue #2078: Remove vendored golang x URL: https://github.com/apache/incubator-trafficcontrol/pull/2078#issuecomment-378301197 Tested the Docker build, it succeeds. This is an automated message from the

[GitHub] dewrich closed pull request #2075: TO: allow ssl connection to db to be required

dewrich closed pull request #2075: TO: allow ssl connection to db to be required URL: https://github.com/apache/incubator-trafficcontrol/pull/2075 This is a PR merged from a forked repository. As GitHub hides the original diff on merge, it is displayed below for the sake of provenance:

[GitHub] Vijay-1 commented on issue #2029: Implements https://github.com/apache/incubator-trafficcontrol/issues/…

Vijay-1 commented on issue #2029: Implements https://github.com/apache/incubator-trafficcontrol/issues/… URL: https://github.com/apache/incubator-trafficcontrol/pull/2029#issuecomment-378280795 In perl/ Mojo, i can see this query params only for indexes, where we are fetching an entire

[GitHub] rob05c opened a new issue #2077: Write Go Coding Style Doc

rob05c opened a new issue #2077: Write Go Coding Style Doc URL: https://github.com/apache/incubator-trafficcontrol/issues/2077 Most of the Go Coding Style is covered in https://golang.org/doc/effective_go.html and https://github.com/golang/go/wiki/CodeReviewComments but not everything.