Github user sbogacz commented on the issue:
https://github.com/apache/incubator-trafficcontrol/pull/167
@PSUdaemon @dneuman64 @rob05c @dewrich Hey guys, in case you haven't seen
it yet, [they just released the pre-alpha version of the native dependency tool
for
Go](
Github user sbogacz commented on the issue:
https://github.com/apache/incubator-trafficcontrol/pull/167
ð¤¦ââï¸ Pulled in upstream but didn't update vendor, so here we go
again...
---
If your project is set up for it, you can reply to this email and have your
reply appe
Github user sbogacz commented on the issue:
https://github.com/apache/incubator-trafficcontrol/pull/167
@dneuman64 Crossing fingers
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this
Github user sbogacz commented on a diff in the pull request:
https://github.com/apache/incubator-trafficcontrol/pull/167#discussion_r96073860
--- Diff: traffic_stats/build/traffic_stats.spec ---
@@ -75,8 +75,8 @@
godir=src/github.com/apache/incubator-trafficcontrol/traffic_stats
Github user sbogacz commented on the issue:
https://github.com/apache/incubator-trafficcontrol/pull/167
@dneuman64 I had to bring in several more dependencies into vendor to cover
those dependencies' dependencies (not to beat a dead horse, but tooling can
really help here). I
Github user sbogacz commented on the issue:
https://github.com/apache/incubator-trafficcontrol/pull/167
That's the difficulty in vendoring without tooling, totally missed those.
I'll add to the vendor folder and push
---
If your project is set up for it, you can reply to
Github user sbogacz commented on a diff in the pull request:
https://github.com/apache/incubator-trafficcontrol/pull/167#discussion_r95876943
--- Diff: traffic_stats/assert/testhelpers.go ---
@@ -0,0 +1,109 @@
+/*
+Licensed to the Apache Software Foundation (ASF) under one
Github user sbogacz commented on a diff in the pull request:
https://github.com/apache/incubator-trafficcontrol/pull/167#discussion_r95876801
--- Diff: traffic_stats/assert/testhelpers.go ---
@@ -0,0 +1,109 @@
+/*
+Licensed to the Apache Software Foundation (ASF) under one
Github user sbogacz commented on the issue:
https://github.com/apache/incubator-trafficcontrol/pull/167
@dneuman64 These last changes should encapsulate what we talked about:
* Remove `urfave/cli` dependency by having a config object that can be
"autopopulated&qu
Github user sbogacz commented on a diff in the pull request:
https://github.com/apache/incubator-trafficcontrol/pull/167#discussion_r95610649
--- Diff: traffic_stats/influxdb_tools/sync/sync_test.go ---
@@ -0,0 +1,230 @@
+/*
+Licensed to the Apache Software Foundation (ASF
Github user sbogacz commented on the issue:
https://github.com/apache/incubator-trafficcontrol/pull/167
Added some more commits to show the direction I was thinking of going with
some of the refactoring, what the move back to `flag` from `urfave/cli` looks
like, and added the `vendor
Github user sbogacz commented on a diff in the pull request:
https://github.com/apache/incubator-trafficcontrol/pull/167#discussion_r95499191
--- Diff: traffic_stats/influxdb_tools/sync/sync_test.go ---
@@ -0,0 +1,230 @@
+/*
+Licensed to the Apache Software Foundation (ASF
Github user sbogacz commented on a diff in the pull request:
https://github.com/apache/incubator-trafficcontrol/pull/167#discussion_r95489426
--- Diff: traffic_stats/influxdb_tools/sync/sync_test.go ---
@@ -0,0 +1,230 @@
+/*
+Licensed to the Apache Software Foundation (ASF
Github user sbogacz commented on the issue:
https://github.com/apache/incubator-trafficcontrol/pull/167
@rob05c Yeah, that's what I'm talking about. That functionality (and since
greater versions of go1.6, the tooling as well) supports the _existence_ of a
vendor folder, an
Github user sbogacz commented on the issue:
https://github.com/apache/incubator-trafficcontrol/pull/167
@rob05c Sadly, there's not actually a native vendoring tool solution yet,
and I haven't heard any news about when it could be expected. While we can
certainly move de
Github user sbogacz commented on the issue:
https://github.com/apache/incubator-trafficcontrol/pull/167
I've had good experiences with `godep` for the most part, and I'd be happy
to bring it in (I can maybe throw in a Makefile to make some of the local
commands easier). Tha
Github user sbogacz commented on a diff in the pull request:
https://github.com/apache/incubator-trafficcontrol/pull/167#discussion_r95290454
--- Diff: traffic_stats/influxdb_tools/sync/sync_test.go ---
@@ -0,0 +1,230 @@
+/*
+Licensed to the Apache Software Foundation (ASF
Github user sbogacz commented on the issue:
https://github.com/apache/incubator-trafficcontrol/pull/167
I did look at the licenses beforehand, but I'll admit I don't know the most
about the technicalities of Open Source licenses. I'll go back and get the
tests to use
Github user sbogacz commented on a diff in the pull request:
https://github.com/apache/incubator-trafficcontrol/pull/167#discussion_r95100933
--- Diff: traffic_stats/influxdb_tools/create/create_ts_databases.go ---
@@ -20,45 +20,81 @@ under the License.
package main
Github user sbogacz commented on a diff in the pull request:
https://github.com/apache/incubator-trafficcontrol/pull/167#discussion_r95100626
--- Diff: traffic_stats/influxdb_tools/sync/sync_test.go ---
@@ -0,0 +1,230 @@
+/*
+Licensed to the Apache Software Foundation (ASF
Github user sbogacz commented on a diff in the pull request:
https://github.com/apache/incubator-trafficcontrol/pull/167#discussion_r95100395
--- Diff: traffic_stats/influxdb_tools/create/create_ts_databases.go ---
@@ -20,45 +20,81 @@ under the License.
package main
Github user sbogacz commented on the issue:
https://github.com/apache/incubator-trafficcontrol/pull/167
Hey @PSUdaemon, thanks for the review. I'm more than happy to make changes
to the PR to conform to project standards. I think the question of dependencies
is a good one, bo
Github user sbogacz commented on a diff in the pull request:
https://github.com/apache/incubator-trafficcontrol/pull/167#discussion_r95096773
--- Diff: traffic_stats/influxdb_tools/sync/sync_test.go ---
@@ -0,0 +1,230 @@
+/*
+Licensed to the Apache Software Foundation (ASF
Github user sbogacz commented on a diff in the pull request:
https://github.com/apache/incubator-trafficcontrol/pull/167#discussion_r95096692
--- Diff: traffic_stats/influxdb_tools/create/create_ts_databases.go ---
@@ -20,45 +20,81 @@ under the License.
package main
Github user sbogacz commented on a diff in the pull request:
https://github.com/apache/incubator-trafficcontrol/pull/167#discussion_r95096542
--- Diff: traffic_stats/influxdb_tools/create/create_ts_databases.go ---
@@ -20,45 +20,81 @@ under the License.
package main
Github user sbogacz commented on a diff in the pull request:
https://github.com/apache/incubator-trafficcontrol/pull/167#discussion_r95096071
--- Diff: traffic_stats/influxdb_tools/create/create_ts_databases.go ---
@@ -20,45 +20,81 @@ under the License.
package main
GitHub user sbogacz opened a pull request:
https://github.com/apache/incubator-trafficcontrol/pull/167
Refactor and cleanup the influxdb_tools in traffic_stats
1) Cleanup lint warnings in the traffic_stats/influxdb_tools go files
(mostly due to repeated constant strings), and fix
27 matches
Mail list logo
