[GitHub] incubator-trafficcontrol pull request #751: [TC-462] Ds tenancy validation r...

2017-07-27 Thread mitchell852
Github user mitchell852 commented on a diff in the pull request: https://github.com/apache/incubator-trafficcontrol/pull/751#discussion_r129904376 --- Diff: traffic_ops/app/lib/API/DeliveryServiceMatches.pm --- @@ -28,11 +29,19 @@ sub index { my $format = $self->pa

[GitHub] incubator-trafficcontrol pull request #751: [TC-462] Ds tenancy validation r...

2017-07-27 Thread mitchell852
Github user mitchell852 commented on a diff in the pull request: https://github.com/apache/incubator-trafficcontrol/pull/751#discussion_r129904886 --- Diff: traffic_ops/app/lib/API/DeliveryServiceRegexes.pm --- @@ -27,12 +28,18 @@ use Validate::Tiny ':all'; sub all

[GitHub] incubator-trafficcontrol pull request #751: [TC-462] Ds tenancy validation r...

2017-07-27 Thread mitchell852
Github user mitchell852 commented on a diff in the pull request: https://github.com/apache/incubator-trafficcontrol/pull/751#discussion_r129906932 --- Diff: traffic_ops/app/lib/API/DeliveryServiceRegexes.pm --- @@ -222,6 +262,18 @@ sub delete { return $self

[GitHub] incubator-trafficcontrol pull request #751: [TC-462] Ds tenancy validation r...

2017-07-27 Thread mitchell852
Github user mitchell852 commented on a diff in the pull request: https://github.com/apache/incubator-trafficcontrol/pull/751#discussion_r129905512 --- Diff: traffic_ops/app/lib/API/DeliveryServiceRegexes.pm --- @@ -66,6 +73,12 @@ sub index { return $self->not_fo

[GitHub] incubator-trafficcontrol pull request #751: [TC-462] Ds tenancy validation r...

2017-07-27 Thread mitchell852
Github user mitchell852 commented on a diff in the pull request: https://github.com/apache/incubator-trafficcontrol/pull/751#discussion_r129906584 --- Diff: traffic_ops/app/lib/API/DeliveryServiceRegexes.pm --- @@ -66,6 +73,12 @@ sub index { return $self->not_fo

[GitHub] incubator-trafficcontrol pull request #761: Add TO client DS ByServer, Regex...

2017-07-27 Thread mitchell852
Github user mitchell852 commented on a diff in the pull request: https://github.com/apache/incubator-trafficcontrol/pull/761#discussion_r129881754 --- Diff: traffic_ops/client/delivery_service_endpoints.go --- @@ -22,6 +22,10 @@ func deliveryServicesEp() string { return

[GitHub] incubator-trafficcontrol pull request #760: [TC-477] - disables select all c...

2017-07-27 Thread mitchell852
GitHub user mitchell852 opened a pull request: https://github.com/apache/incubator-trafficcontrol/pull/760 [TC-477] - disables select all checkbox when results are filtered You can merge this pull request into a Git repository by running: $ git pull https://github.com

[GitHub] incubator-trafficcontrol pull request #757: TPv2 - changes form input identi...

2017-07-26 Thread mitchell852
GitHub user mitchell852 opened a pull request: https://github.com/apache/incubator-trafficcontrol/pull/757 TPv2 - changes form input identifiers on login page to avoid browser saved v… …alues from showing in other form inputs of same name You can merge this pull request

[GitHub] incubator-trafficcontrol pull request #755: [TC-476] - TPv2 - improper datab...

2017-07-26 Thread mitchell852
GitHub user mitchell852 opened a pull request: https://github.com/apache/incubator-trafficcontrol/pull/755 [TC-476] - TPv2 - improper databinding to maxDNSAnswers instead of maxDnsAnswers You can merge this pull request into a Git repository by running: $ git pull https

[GitHub] incubator-trafficcontrol issue #742: [TC-428] Ds tenancy validation

2017-07-25 Thread mitchell852
Github user mitchell852 commented on the issue: https://github.com/apache/incubator-trafficcontrol/pull/742 just so i'm clear. to fully implement tenancy you should set the parameters like this? ignore-tenancy=0 ignore_ds_tmuser_assignment=1 --- If your

[GitHub] incubator-trafficcontrol pull request #740: add safe (limited field) update ...

2017-07-24 Thread mitchell852
Github user mitchell852 commented on a diff in the pull request: https://github.com/apache/incubator-trafficcontrol/pull/740#discussion_r129148171 --- Diff: docs/source/development/traffic_ops_api/v12/deliveryservice.rst --- @@ -2648,7 +2648,266 @@ SSL Keys

[GitHub] incubator-trafficcontrol pull request #748: [TC-419] - implements configurab...

2017-07-24 Thread mitchell852
GitHub user mitchell852 opened a pull request: https://github.com/apache/incubator-trafficcontrol/pull/748 [TC-419] - implements configurable autorefresh of TPv2 dashboard components You can merge this pull request into a Git repository by running: $ git pull https

[GitHub] incubator-trafficcontrol issue #742: [TC-428] Ds tenancy validation

2017-07-24 Thread mitchell852
Github user mitchell852 commented on the issue: https://github.com/apache/incubator-trafficcontrol/pull/742 I'm a little worried that I don't see an entry in the seeds.sql file for the ignore-tenancy parameter. I feel like if somebody want's to disable tenancy they will not know

[GitHub] incubator-trafficcontrol pull request #742: [TC-428] Ds tenancy validation

2017-07-24 Thread mitchell852
Github user mitchell852 commented on a diff in the pull request: https://github.com/apache/incubator-trafficcontrol/pull/742#discussion_r129085204 --- Diff: traffic_ops/app/lib/API/Deliveryservice.pm --- @@ -950,8 +996,13 @@ sub state { my $id = $self->param(

[GitHub] incubator-trafficcontrol issue #740: add safe (limited field) update endpoin...

2017-07-24 Thread mitchell852
Github user mitchell852 commented on the issue: https://github.com/apache/incubator-trafficcontrol/pull/740 Can you add some documentation for this new api endpoint? you'll want to update this file: https://github.com/apache/incubator-trafficcontrol/blob/master/docs/source

[GitHub] incubator-trafficcontrol pull request #740: add safe (limited field) update ...

2017-07-20 Thread mitchell852
Github user mitchell852 commented on a diff in the pull request: https://github.com/apache/incubator-trafficcontrol/pull/740#discussion_r128634422 --- Diff: traffic_ops/app/lib/API/Deliveryservice.pm --- @@ -442,6 +442,139 @@ sub update { } } +sub

[GitHub] incubator-trafficcontrol pull request #740: add safe (limited field) update ...

2017-07-20 Thread mitchell852
Github user mitchell852 commented on a diff in the pull request: https://github.com/apache/incubator-trafficcontrol/pull/740#discussion_r128633810 --- Diff: traffic_ops/app/lib/API/Deliveryservice.pm --- @@ -442,6 +442,139 @@ sub update { } } +sub

[GitHub] incubator-trafficcontrol pull request #740: add safe (limited field) update ...

2017-07-20 Thread mitchell852
Github user mitchell852 commented on a diff in the pull request: https://github.com/apache/incubator-trafficcontrol/pull/740#discussion_r128633945 --- Diff: traffic_ops/app/lib/API/Deliveryservice.pm --- @@ -442,6 +442,139 @@ sub update { } } +sub

[GitHub] incubator-trafficcontrol pull request #745: [TC-444] - removes references to...

2017-07-20 Thread mitchell852
GitHub user mitchell852 opened a pull request: https://github.com/apache/incubator-trafficcontrol/pull/745 [TC-444] - removes references to migrations user and role as it is no longer use… …d for database migrations You can merge this pull request into a Git repository

[GitHub] incubator-trafficcontrol issue #740: add safe (limited field) update endpoin...

2017-07-20 Thread mitchell852
Github user mitchell852 commented on the issue: https://github.com/apache/incubator-trafficcontrol/pull/740 actually, you know what? can you just add your api to the ds-write capability in seeds.sql? i think rather than creating a new capability, we stick to the standard ones and let

[GitHub] incubator-trafficcontrol issue #740: add safe (limited field) update endpoin...

2017-07-20 Thread mitchell852
Github user mitchell852 commented on the issue: https://github.com/apache/incubator-trafficcontrol/pull/740 when adding api endpoints, be sure to add your endpoint to the seeds.sql file. my guess is you'll want to create a new capability called ds-write-safe or something

[GitHub] incubator-trafficcontrol pull request #744: [TC-430] - accounts for scenario...

2017-07-20 Thread mitchell852
GitHub user mitchell852 opened a pull request: https://github.com/apache/incubator-trafficcontrol/pull/744 [TC-430] - accounts for scenario where no servers exist You can merge this pull request into a Git repository by running: $ git pull https://github.com/mitchell852

[GitHub] incubator-trafficcontrol pull request #741: updates TP readme files

2017-07-19 Thread mitchell852
GitHub user mitchell852 opened a pull request: https://github.com/apache/incubator-trafficcontrol/pull/741 updates TP readme files You can merge this pull request into a Git repository by running: $ git pull https://github.com/mitchell852/incubator-trafficcontrol fixes-tp

[GitHub] incubator-trafficcontrol pull request #735: [TC-427] User tenancy validation

2017-07-19 Thread mitchell852
Github user mitchell852 commented on a diff in the pull request: https://github.com/apache/incubator-trafficcontrol/pull/735#discussion_r128346564 --- Diff: traffic_ops/app/lib/API/User.pm --- @@ -477,6 +506,13 @@ sub update_current { return $self->alert( "

[GitHub] incubator-trafficcontrol pull request #730: [TC-64] - updating current user ...

2017-07-13 Thread mitchell852
GitHub user mitchell852 opened a pull request: https://github.com/apache/incubator-trafficcontrol/pull/730 [TC-64] - updating current user uses a different api than updating any user You can merge this pull request into a Git repository by running: $ git pull https

[GitHub] incubator-trafficcontrol pull request #727: [TC-417] - clears tm_user.token ...

2017-07-12 Thread mitchell852
GitHub user mitchell852 opened a pull request: https://github.com/apache/incubator-trafficcontrol/pull/727 [TC-417] - clears tm_user.token that was generated during portal user registration process as u… …pdating your current user signifies that your registration is complete

[GitHub] incubator-trafficcontrol pull request #722: [TC-64] - fixes tp release info ...

2017-07-11 Thread mitchell852
GitHub user mitchell852 opened a pull request: https://github.com/apache/incubator-trafficcontrol/pull/722 [TC-64] - fixes tp release info dialog You can merge this pull request into a Git repository by running: $ git pull https://github.com/mitchell852/incubator

[GitHub] incubator-trafficcontrol pull request #719: [TC-64] - hooks steering targets...

2017-07-10 Thread mitchell852
GitHub user mitchell852 opened a pull request: https://github.com/apache/incubator-trafficcontrol/pull/719 [TC-64] - hooks steering targets into TP …c portal You can merge this pull request into a Git repository by running: $ git pull https://github.com/mitchell852

[GitHub] incubator-trafficcontrol pull request #711: [TC-64] - adds ccr dns ttl to ht...

2017-07-03 Thread mitchell852
GitHub user mitchell852 opened a pull request: https://github.com/apache/incubator-trafficcontrol/pull/711 [TC-64] - adds ccr dns ttl to http* and dns* deliveryservices with an appropria… …te default value You can merge this pull request into a Git repository by running

[GitHub] incubator-trafficcontrol issue #708: promotes TO experimental UI to the new ...

2017-06-30 Thread mitchell852
Github user mitchell852 commented on the issue: https://github.com/apache/incubator-trafficcontrol/pull/708 Per this email it has been decided that the new TO UI (that consumes the TO API) will take the place of the Traffic Portal https://lists.apache.org/thread.html

[GitHub] incubator-trafficcontrol pull request #644: Tenant utils

2017-06-29 Thread mitchell852
Github user mitchell852 commented on a diff in the pull request: https://github.com/apache/incubator-trafficcontrol/pull/644#discussion_r124806475 --- Diff: traffic_ops/app/lib/API/Tenant.pm --- @@ -131,21 +130,74 @@ sub update { my $is_active = $params->{act

[GitHub] incubator-trafficcontrol pull request #644: Tenant utils

2017-06-28 Thread mitchell852
Github user mitchell852 commented on a diff in the pull request: https://github.com/apache/incubator-trafficcontrol/pull/644#discussion_r124660517 --- Diff: traffic_ops/app/lib/API/Tenant.pm --- @@ -248,7 +326,17 @@ sub delete { if ( !defined($tenant

[GitHub] incubator-trafficcontrol pull request #644: Tenant utils

2017-06-28 Thread mitchell852
Github user mitchell852 commented on a diff in the pull request: https://github.com/apache/incubator-trafficcontrol/pull/644#discussion_r124660063 --- Diff: traffic_ops/app/lib/API/Tenant.pm --- @@ -131,21 +130,74 @@ sub update { my $is_active = $params->{act

[GitHub] incubator-trafficcontrol pull request #644: Tenant utils

2017-06-28 Thread mitchell852
Github user mitchell852 commented on a diff in the pull request: https://github.com/apache/incubator-trafficcontrol/pull/644#discussion_r124659823 --- Diff: traffic_ops/app/lib/API/Tenant.pm --- @@ -121,7 +115,12 @@ sub update

[GitHub] incubator-trafficcontrol pull request #644: Tenant utils

2017-06-28 Thread mitchell852
Github user mitchell852 commented on a diff in the pull request: https://github.com/apache/incubator-trafficcontrol/pull/644#discussion_r124628818 --- Diff: traffic_ops/app/lib/API/User.pm --- @@ -404,7 +406,7 @@ sub current { my $self = shift; my @data; my

[GitHub] incubator-trafficcontrol pull request #644: Tenant utils

2017-06-28 Thread mitchell852
Github user mitchell852 commented on a diff in the pull request: https://github.com/apache/incubator-trafficcontrol/pull/644#discussion_r124592678 --- Diff: traffic_ops/app/lib/API/Tenant.pm --- @@ -31,34 +32,28 @@ sub getTenantName { return defined($tenant_id) ? $self->

[GitHub] incubator-trafficcontrol pull request #644: Tenant utils

2017-06-28 Thread mitchell852
Github user mitchell852 commented on a diff in the pull request: https://github.com/apache/incubator-trafficcontrol/pull/644#discussion_r124624257 --- Diff: traffic_ops/app/lib/API/Tenant.pm --- @@ -131,21 +130,74 @@ sub update { my $is_active = $params->{act

[GitHub] incubator-trafficcontrol pull request #644: Tenant utils

2017-06-28 Thread mitchell852
Github user mitchell852 commented on a diff in the pull request: https://github.com/apache/incubator-trafficcontrol/pull/644#discussion_r124621754 --- Diff: traffic_ops/app/lib/API/Tenant.pm --- @@ -131,21 +130,74 @@ sub update { my $is_active = $params->{act

[GitHub] incubator-trafficcontrol pull request #644: Tenant utils

2017-06-28 Thread mitchell852
Github user mitchell852 commented on a diff in the pull request: https://github.com/apache/incubator-trafficcontrol/pull/644#discussion_r124597615 --- Diff: traffic_ops/app/lib/API/Tenant.pm --- @@ -121,7 +115,12 @@ sub update

[GitHub] incubator-trafficcontrol pull request #644: Tenant utils

2017-06-28 Thread mitchell852
Github user mitchell852 commented on a diff in the pull request: https://github.com/apache/incubator-trafficcontrol/pull/644#discussion_r124625194 --- Diff: traffic_ops/app/lib/API/Tenant.pm --- @@ -185,11 +237,36 @@ sub create { return $self->alert("Ten

[GitHub] incubator-trafficcontrol pull request #644: Tenant utils

2017-06-28 Thread mitchell852
Github user mitchell852 commented on a diff in the pull request: https://github.com/apache/incubator-trafficcontrol/pull/644#discussion_r124625956 --- Diff: traffic_ops/app/lib/API/Tenant.pm --- @@ -248,7 +326,17 @@ sub delete { if ( !defined($tenant

[GitHub] incubator-trafficcontrol pull request #644: Tenant utils

2017-06-28 Thread mitchell852
Github user mitchell852 commented on a diff in the pull request: https://github.com/apache/incubator-trafficcontrol/pull/644#discussion_r124589621 --- Diff: traffic_ops/app/lib/API/Tenant.pm --- @@ -31,34 +32,28 @@ sub getTenantName { return defined($tenant_id) ? $self->

[GitHub] incubator-trafficcontrol pull request #644: Tenant utils

2017-06-28 Thread mitchell852
Github user mitchell852 commented on a diff in the pull request: https://github.com/apache/incubator-trafficcontrol/pull/644#discussion_r124623700 --- Diff: traffic_ops/app/lib/API/Tenant.pm --- @@ -131,21 +130,74 @@ sub update { my $is_active = $params->{act

[GitHub] incubator-trafficcontrol issue #703: [TC-64] - new TO UI is to be named traf...

2017-06-27 Thread mitchell852
Github user mitchell852 commented on the issue: https://github.com/apache/incubator-trafficcontrol/pull/703 Per this email thread - https://lists.apache.org/thread.html/b24a6a6807a50c52d6c9e82e4a3e00f78a56179e57cfadf21fc1711a@%3Cusers.trafficcontrol.apache.org%3E --- If your project

[GitHub] incubator-trafficcontrol pull request #701: TPv2 - adds back missing css cha...

2017-06-26 Thread mitchell852
GitHub user mitchell852 opened a pull request: https://github.com/apache/incubator-trafficcontrol/pull/701 TPv2 - adds back missing css changes when file was deleted You can merge this pull request into a Git repository by running: $ git pull https://github.com/mitchell852

[GitHub] incubator-trafficcontrol pull request #700: fixes problematic character

2017-06-26 Thread mitchell852
GitHub user mitchell852 opened a pull request: https://github.com/apache/incubator-trafficcontrol/pull/700 fixes problematic character You can merge this pull request into a Git repository by running: $ git pull https://github.com/mitchell852/incubator-trafficcontrol fixes

[GitHub] incubator-trafficcontrol pull request #698: TPv2 - adds the ability to defin...

2017-06-26 Thread mitchell852
GitHub user mitchell852 opened a pull request: https://github.com/apache/incubator-trafficcontrol/pull/698 TPv2 - adds the ability to define a custom menu via a json file You can merge this pull request into a Git repository by running: $ git pull https://github.com

[GitHub] incubator-trafficcontrol pull request #664: [TC-64] - TP v2 - minor changes ...

2017-06-09 Thread mitchell852
GitHub user mitchell852 opened a pull request: https://github.com/apache/incubator-trafficcontrol/pull/664 [TC-64] - TP v2 - minor changes based on feedback You can merge this pull request into a Git repository by running: $ git pull https://github.com/mitchell852/incubator

[GitHub] incubator-trafficcontrol pull request #658: [TC-64] - failed to account for ...

2017-06-08 Thread mitchell852
GitHub user mitchell852 opened a pull request: https://github.com/apache/incubator-trafficcontrol/pull/658 [TC-64] - failed to account for traffic monitors in snapshot diff You can merge this pull request into a Git repository by running: $ git pull https://github.com

[GitHub] incubator-trafficcontrol pull request #657: [TC-372] - optimizes user/ds ass...

2017-06-08 Thread mitchell852
GitHub user mitchell852 opened a pull request: https://github.com/apache/incubator-trafficcontrol/pull/657 [TC-372] - optimizes user/ds assignment endpoint and allows for bulk assignment thru ui You can merge this pull request into a Git repository by running: $ git pull

[GitHub] incubator-trafficcontrol pull request #656: [TC-371] - TO API - optimizes se...

2017-06-08 Thread mitchell852
GitHub user mitchell852 opened a pull request: https://github.com/apache/incubator-trafficcontrol/pull/656 [TC-371] - TO API - optimizes server to ds assignment endpoint You can merge this pull request into a Git repository by running: $ git pull https://github.com

[GitHub] incubator-trafficcontrol issue #627: Change Traffic Ops to hide sensitive da...

2017-06-08 Thread mitchell852
Github user mitchell852 commented on the issue: https://github.com/apache/incubator-trafficcontrol/pull/627 This PR should be merged first - https://github.com/apache/incubator-trafficcontrol/pull/642 Once that PR is merged, username will be added to access logs and that data

[GitHub] incubator-trafficcontrol pull request #655: [TC-64] to exp - allows for bulk...

2017-06-07 Thread mitchell852
GitHub user mitchell852 opened a pull request: https://github.com/apache/incubator-trafficcontrol/pull/655 [TC-64] to exp - allows for bulk assignment of servers to a ds You can merge this pull request into a Git repository by running: $ git pull https://github.com

[GitHub] incubator-trafficcontrol pull request #653: stop tp before clean. also, reme...

2017-06-07 Thread mitchell852
GitHub user mitchell852 opened a pull request: https://github.com/apache/incubator-trafficcontrol/pull/653 stop tp before clean. also, remember to remove container first. You can merge this pull request into a Git repository by running: $ git pull https://github.com

[GitHub] incubator-trafficcontrol pull request #652: TO API - updates access_control_...

2017-06-07 Thread mitchell852
GitHub user mitchell852 opened a pull request: https://github.com/apache/incubator-trafficcontrol/pull/652 TO API - updates access_control_allow_origin to allow multiple api consumers You can merge this pull request into a Git repository by running: $ git pull https

[GitHub] incubator-trafficcontrol issue #602: Change Traffic Ops password hashing to ...

2017-06-07 Thread mitchell852
Github user mitchell852 commented on the issue: https://github.com/apache/incubator-trafficcontrol/pull/602 i'm seeing this when i try to login [2017-06-07 10:59:36,931] [DEBUG] POST "/api/1.2/user/login". [2017-06-07 10:59:37,072] [DEBUG] Routing to controller

[GitHub] incubator-trafficcontrol issue #567: API GW phase 0 (replaces #551, depends ...

2017-06-07 Thread mitchell852
Github user mitchell852 commented on the issue: https://github.com/apache/incubator-trafficcontrol/pull/567 @amiryesh - can you rebase this? --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project does not have

[GitHub] incubator-trafficcontrol issue #642: Add Traffic Ops username to access log

2017-06-06 Thread mitchell852
Github user mitchell852 commented on the issue: https://github.com/apache/incubator-trafficcontrol/pull/642 this is what the log line looks like now: 127.0.0.1 - - [05/Jun/2017:13:54:34 -0600] "GET /api/1.2/logs/newcount HTTP/1.1" 200 51 25823 "Mozilla/5.0 (M

[GitHub] incubator-trafficcontrol issue #645: Change Traffic Ops `/update` to `priv >...

2017-06-06 Thread mitchell852
Github user mitchell852 commented on the issue: https://github.com/apache/incubator-trafficcontrol/pull/645 do you want to create a role for this? maybe call it 'ort' with a priv level of 11? this role would be added to the seeds.sql file. i'm guessing everyone could benefit from

[GitHub] incubator-trafficcontrol pull request #646: [TC-364] - adds the ability to a...

2017-06-05 Thread mitchell852
GitHub user mitchell852 opened a pull request: https://github.com/apache/incubator-trafficcontrol/pull/646 [TC-364] - adds the ability to assign/unassign ds's to user thru the api You can merge this pull request into a Git repository by running: $ git pull https://github.com

[GitHub] incubator-trafficcontrol issue #642: Add Traffic Ops username to access log

2017-06-05 Thread mitchell852
Github user mitchell852 commented on the issue: https://github.com/apache/incubator-trafficcontrol/pull/642 Tested locally, here were my results: 127.0.0.1 - localUsername [05/Jun/2017:13:38:48 -0600] "GET /api/1.2/logs/newcount HTTP/1.1" 200 51 7370 "Mozilla

[GitHub] incubator-trafficcontrol issue #602: Change Traffic Ops password hashing to ...

2017-06-05 Thread mitchell852
Github user mitchell852 commented on the issue: https://github.com/apache/incubator-trafficcontrol/pull/602 sorry, i merged another PR that created a conflict for you... --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well

[GitHub] incubator-trafficcontrol issue #370: Adding a "create user" to the api

2017-06-05 Thread mitchell852
Github user mitchell852 commented on the issue: https://github.com/apache/incubator-trafficcontrol/pull/370 yes, there is a UT failure: t/user.t (Wstat: 256 Tests: 21 Failed: 1) Failed test: 5 Non-zero exit status: 1

[GitHub] incubator-trafficcontrol pull request #641: changelog fix - current_user() d...

2017-06-02 Thread mitchell852
GitHub user mitchell852 opened a pull request: https://github.com/apache/incubator-trafficcontrol/pull/641 changelog fix - current_user() does not have a userid. also making sure count is nume… …ric. You can merge this pull request into a Git repository by running: $ git

[GitHub] incubator-trafficcontrol pull request #640: fixes broken user test

2017-06-01 Thread mitchell852
GitHub user mitchell852 opened a pull request: https://github.com/apache/incubator-trafficcontrol/pull/640 fixes broken user test You can merge this pull request into a Git repository by running: $ git pull https://github.com/mitchell852/incubator-trafficcontrol fixes-broken

[GitHub] incubator-trafficcontrol pull request #639: [TC-362] - adds api for updating...

2017-06-01 Thread mitchell852
GitHub user mitchell852 opened a pull request: https://github.com/apache/incubator-trafficcontrol/pull/639 [TC-362] - adds api for updating server status and ties it into new UI You can merge this pull request into a Git repository by running: $ git pull https://github.com

[GitHub] incubator-trafficcontrol pull request #638: [TC-64] - to exp - ui tweaks

2017-06-01 Thread mitchell852
GitHub user mitchell852 opened a pull request: https://github.com/apache/incubator-trafficcontrol/pull/638 [TC-64] - to exp - ui tweaks You can merge this pull request into a Git repository by running: $ git pull https://github.com/mitchell852/incubator-trafficcontrol tc-64

[GitHub] incubator-trafficcontrol pull request #370: Adding a "create user" to the ap...

2017-05-31 Thread mitchell852
Github user mitchell852 commented on a diff in the pull request: https://github.com/apache/incubator-trafficcontrol/pull/370#discussion_r119400623 --- Diff: traffic_ops/app/lib/API/User.pm --- @@ -229,6 +229,112 @@ sub update { } +# Create +sub create

[GitHub] incubator-trafficcontrol pull request #370: Adding a "create user" to the ap...

2017-05-31 Thread mitchell852
Github user mitchell852 commented on a diff in the pull request: https://github.com/apache/incubator-trafficcontrol/pull/370#discussion_r119400399 --- Diff: traffic_ops/app/lib/API/User.pm --- @@ -226,6 +226,120 @@ sub update { } +# Create +sub create

[GitHub] incubator-trafficcontrol pull request #605: [TC-355] Add CDN match checks wh...

2017-05-31 Thread mitchell852
Github user mitchell852 commented on a diff in the pull request: https://github.com/apache/incubator-trafficcontrol/pull/605#discussion_r119394809 --- Diff: traffic_ops/app/lib/API/Server.pm --- @@ -911,6 +911,21 @@ sub is_server_valid { return ( 0, "Invalid s

[GitHub] incubator-trafficcontrol pull request #624: [TC-359] - fixes bug where updat...

2017-05-31 Thread mitchell852
Github user mitchell852 commented on a diff in the pull request: https://github.com/apache/incubator-trafficcontrol/pull/624#discussion_r119386426 --- Diff: traffic_ops/app/lib/API/User.pm --- @@ -579,7 +573,7 @@ sub is_good_password { return "Your password c

[GitHub] incubator-trafficcontrol issue #627: Change Traffic Ops to hide sensitive da...

2017-05-31 Thread mitchell852
Github user mitchell852 commented on the issue: https://github.com/apache/incubator-trafficcontrol/pull/627 I can't get TO to build/start Couldn't load application from file "bin/../local/../script/cdn": Not a CODE reference at /src/github.com/apache/incubator-traf

[GitHub] incubator-trafficcontrol issue #370: Adding a "create user" to the api

2017-05-30 Thread mitchell852
Github user mitchell852 commented on the issue: https://github.com/apache/incubator-trafficcontrol/pull/370 @nir-sopher - can you fix this PR? "This branch cannot be rebased safely" - i'd like to get it merged if possible --- If your project is set up for it, you

[GitHub] incubator-trafficcontrol issue #602: Change Traffic Ops password hashing to ...

2017-05-30 Thread mitchell852
Github user mitchell852 commented on the issue: https://github.com/apache/incubator-trafficcontrol/pull/602 I'll try to look at this tomorrow. thanks @rob05c --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your

[GitHub] incubator-trafficcontrol issue #627: Change Traffic Ops to hide sensitive da...

2017-05-30 Thread mitchell852
Github user mitchell852 commented on the issue: https://github.com/apache/incubator-trafficcontrol/pull/627 I'll try to check this out tomorrow. thanks @rob05c --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your

[GitHub] incubator-trafficcontrol pull request #624: [TC-359] - fixes bug where updat...

2017-05-30 Thread mitchell852
GitHub user mitchell852 opened a pull request: https://github.com/apache/incubator-trafficcontrol/pull/624 [TC-359] - fixes bug where updating a user always returned "email taken" or "use… …rname taken". well of course it's taken...it's taken by the u

[GitHub] incubator-trafficcontrol pull request #623: [TC-356] - adds missing license ...

2017-05-30 Thread mitchell852
GitHub user mitchell852 opened a pull request: https://github.com/apache/incubator-trafficcontrol/pull/623 [TC-356] - adds missing license header You can merge this pull request into a Git repository by running: $ git pull https://github.com/mitchell852/incubator

[GitHub] incubator-trafficcontrol pull request #622: [TC-358] - adds apis to fetch cu...

2017-05-30 Thread mitchell852
GitHub user mitchell852 opened a pull request: https://github.com/apache/incubator-trafficcontrol/pull/622 [TC-358] - adds apis to fetch current and pending cdn snapshots You can merge this pull request into a Git repository by running: $ git pull https://github.com

[GitHub] incubator-trafficcontrol pull request #615: [TC-64] - TO exp - hooks up cdn ...

2017-05-25 Thread mitchell852
GitHub user mitchell852 opened a pull request: https://github.com/apache/incubator-trafficcontrol/pull/615 [TC-64] - TO exp - hooks up cdn config diff / snapshot You can merge this pull request into a Git repository by running: $ git pull https://github.com/mitchell852

[GitHub] incubator-trafficcontrol pull request #606: [TC-354] - adds api, docs and te...

2017-05-23 Thread mitchell852
GitHub user mitchell852 opened a pull request: https://github.com/apache/incubator-trafficcontrol/pull/606 [TC-354] - adds api, docs and tests to assign servers to a ds as well as fetch unassigned server… …s for a ds You can merge this pull request into a Git repository

[GitHub] incubator-trafficcontrol issue #605: Add CDN match checks when assigning or ...

2017-05-23 Thread mitchell852
Github user mitchell852 commented on the issue: https://github.com/apache/incubator-trafficcontrol/pull/605 In the API, I see where you are checking this: - when updating/creating a server, check that server.profile.cdn == server.cdn but i don't see where you

[GitHub] incubator-trafficcontrol pull request #604: [TC-64] - TO exp - adds ability ...

2017-05-23 Thread mitchell852
GitHub user mitchell852 opened a pull request: https://github.com/apache/incubator-trafficcontrol/pull/604 [TC-64] - TO exp - adds ability to assign servers to ds You can merge this pull request into a Git repository by running: $ git pull https://github.com/mitchell852

[GitHub] incubator-trafficcontrol issue #544: Authorization model

2017-05-22 Thread mitchell852
Github user mitchell852 commented on the issue: https://github.com/apache/incubator-trafficcontrol/pull/544 I'm ready to merge this PR however it says "This branch cannot be rebased safely". To be honest I'm not really sure what that means but it doesn't sound great. So h

[GitHub] incubator-trafficcontrol pull request #550: adds timezone to last_seen_log b...

2017-05-19 Thread mitchell852
Github user mitchell852 closed the pull request at: https://github.com/apache/incubator-trafficcontrol/pull/550 --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project does not have this feature enabled and wishes so

[GitHub] incubator-trafficcontrol pull request #589: [TC-64] - To experimental - allo...

2017-05-19 Thread mitchell852
GitHub user mitchell852 opened a pull request: https://github.com/apache/incubator-trafficcontrol/pull/589 [TC-64] - To experimental - allows user to assign/unassign params from profile or cachegroup You can merge this pull request into a Git repository by running: $ git

[GitHub] incubator-trafficcontrol pull request #586: [TC-64] - TO experimental - adds...

2017-05-18 Thread mitchell852
GitHub user mitchell852 opened a pull request: https://github.com/apache/incubator-trafficcontrol/pull/586 [TC-64] - TO experimental - adds different views for each ds type You can merge this pull request into a Git repository by running: $ git pull https://github.com

[GitHub] incubator-trafficcontrol issue #561: Adds documentation for configfiles API ...

2017-05-17 Thread mitchell852
Github user mitchell852 commented on the issue: https://github.com/apache/incubator-trafficcontrol/pull/561 last i checked, these docs now build properly via sphinx...so i'm fine with the PR once the @dangogh comment is addressed. I'll kick this over to @dangogh --- If your

[GitHub] incubator-trafficcontrol pull request #572: contributing.md - adds details r...

2017-05-12 Thread mitchell852
GitHub user mitchell852 opened a pull request: https://github.com/apache/incubator-trafficcontrol/pull/572 contributing.md - adds details regarding writing documentation You can merge this pull request into a Git repository by running: $ git pull https://github.com

[GitHub] incubator-trafficcontrol pull request #570: [TC-280] - adds api/*/servers/st...

2017-05-11 Thread mitchell852
GitHub user mitchell852 opened a pull request: https://github.com/apache/incubator-trafficcontrol/pull/570 [TC-280] - adds api/*/servers/status api endpoint to show a count of servers in … …each status. also fixed broken asn tests. You can merge this pull request into a Git

[GitHub] incubator-trafficcontrol pull request #544: Authorization model

2017-05-10 Thread mitchell852
Github user mitchell852 commented on a diff in the pull request: https://github.com/apache/incubator-trafficcontrol/pull/544#discussion_r115898210 --- Diff: traffic_ops/app/db/seeds.sql --- @@ -81,10 +81,260 @@ insert into role (name, description, priv_level) values ('steering

[GitHub] incubator-trafficcontrol pull request #544: Authorization model

2017-05-10 Thread mitchell852
Github user mitchell852 commented on a diff in the pull request: https://github.com/apache/incubator-trafficcontrol/pull/544#discussion_r115896943 --- Diff: traffic_ops/app/db/seeds.sql --- @@ -81,10 +81,260 @@ insert into role (name, description, priv_level) values ('steering

[GitHub] incubator-trafficcontrol pull request #544: Authorization model

2017-05-10 Thread mitchell852
Github user mitchell852 commented on a diff in the pull request: https://github.com/apache/incubator-trafficcontrol/pull/544#discussion_r115896288 --- Diff: traffic_ops/app/db/seeds.sql --- @@ -81,10 +81,260 @@ insert into role (name, description, priv_level) values ('steering

[GitHub] incubator-trafficcontrol pull request #544: Authorization model

2017-05-10 Thread mitchell852
Github user mitchell852 commented on a diff in the pull request: https://github.com/apache/incubator-trafficcontrol/pull/544#discussion_r115896312 --- Diff: traffic_ops/app/db/seeds.sql --- @@ -81,10 +81,260 @@ insert into role (name, description, priv_level) values ('steering

[GitHub] incubator-trafficcontrol pull request #544: Authorization model

2017-05-10 Thread mitchell852
Github user mitchell852 commented on a diff in the pull request: https://github.com/apache/incubator-trafficcontrol/pull/544#discussion_r115861924 --- Diff: traffic_ops/app/lib/API/ApiCapability.pm --- @@ -0,0 +1,256 @@ +package API::ApiCapability

[GitHub] incubator-trafficcontrol pull request #544: Authorization model

2017-05-10 Thread mitchell852
Github user mitchell852 commented on a diff in the pull request: https://github.com/apache/incubator-trafficcontrol/pull/544#discussion_r115859517 --- Diff: traffic_ops/app/db/migrations/2017040601_create_capabilities_and_roles.sql --- @@ -0,0 +1,91

[GitHub] incubator-trafficcontrol pull request #544: Authorization model

2017-05-10 Thread mitchell852
Github user mitchell852 commented on a diff in the pull request: https://github.com/apache/incubator-trafficcontrol/pull/544#discussion_r115858507 --- Diff: traffic_ops/app/db/migrations/2017040601_create_capabilities_and_roles.sql --- @@ -0,0 +1,91

[GitHub] incubator-trafficcontrol pull request #544: Authorization model

2017-05-10 Thread mitchell852
Github user mitchell852 commented on a diff in the pull request: https://github.com/apache/incubator-trafficcontrol/pull/544#discussion_r115863296 --- Diff: traffic_ops/app/lib/API/Capability.pm --- @@ -0,0 +1,184 @@ +package API::Capability; +# +# +# Licensed

[GitHub] incubator-trafficcontrol pull request #544: Authorization model

2017-05-10 Thread mitchell852
Github user mitchell852 commented on a diff in the pull request: https://github.com/apache/incubator-trafficcontrol/pull/544#discussion_r115862965 --- Diff: traffic_ops/app/lib/API/Capability.pm --- @@ -0,0 +1,184 @@ +package API::Capability; +# +# +# Licensed

[GitHub] incubator-trafficcontrol pull request #544: Authorization model

2017-05-10 Thread mitchell852
Github user mitchell852 commented on a diff in the pull request: https://github.com/apache/incubator-trafficcontrol/pull/544#discussion_r115857172 --- Diff: traffic_ops/app/db/migrations/2017040601_create_capabilities_and_roles.sql --- @@ -0,0 +1,91

[GitHub] incubator-trafficcontrol pull request #544: Authorization model

2017-05-10 Thread mitchell852
Github user mitchell852 commented on a diff in the pull request: https://github.com/apache/incubator-trafficcontrol/pull/544#discussion_r115856064 --- Diff: docs/source/development/traffic_ops_api/v12/api_capability.rst --- @@ -0,0 +1,367 @@ +.. +.. +.. Licensed under

<    1   2   3   4   5   >