[GitHub] incubator-trafficcontrol pull request #753: [TC-463] User tenancy ds assignm...

2017-08-03 Thread mitchell852
Github user mitchell852 commented on a diff in the pull request: https://github.com/apache/incubator-trafficcontrol/pull/753#discussion_r129940738 --- Diff: traffic_ops/app/lib/Utils/Tenant.pm --- @@ -224,6 +224,15 @@ sub is_ds_resource_accessible { return $self

[GitHub] incubator-trafficcontrol pull request #753: [TC-463] User tenancy ds assignm...

2017-08-03 Thread mitchell852
Github user mitchell852 commented on a diff in the pull request: https://github.com/apache/incubator-trafficcontrol/pull/753#discussion_r129937967 --- Diff: traffic_ops/app/lib/API/DeliveryServiceUser.pm --- @@ -31,6 +32,18 @@ sub delete { return $self->forbid

[GitHub] incubator-trafficcontrol pull request #766: [TC-461] DS steering tenancy che...

2017-08-03 Thread mitchell852
Github user mitchell852 commented on a diff in the pull request: https://github.com/apache/incubator-trafficcontrol/pull/766#discussion_r131236009 --- Diff: traffic_ops/app/lib/API/DeliveryService/SteeringTarget.pm --- @@ -29,6 +30,20 @@ sub index { my $steering_id = $self

[GitHub] incubator-trafficcontrol pull request #815: [TC-521] - TPv2 - accounts for m...

2017-08-15 Thread mitchell852
GitHub user mitchell852 opened a pull request: https://github.com/apache/incubator-trafficcontrol/pull/815 [TC-521] - TPv2 - accounts for missing dependency that centos 7.3 doesn't provide. when… … centos 7.4 is available this dependency will be provided with the distro. You

[GitHub] incubator-trafficcontrol pull request #817: [TC-524] - hooks popout button t...

2017-08-15 Thread mitchell852
GitHub user mitchell852 opened a pull request: https://github.com/apache/incubator-trafficcontrol/pull/817 [TC-524] - hooks popout button to open new window/tab You can merge this pull request into a Git repository by running: $ git pull https://github.com/mitchell852

[GitHub] incubator-trafficcontrol pull request #818: [TC-515] - TPv2 - adds human rea...

2017-08-15 Thread mitchell852
GitHub user mitchell852 opened a pull request: https://github.com/apache/incubator-trafficcontrol/pull/818 [TC-515] - TPv2 - adds human readable ds protocols to ds table You can merge this pull request into a Git repository by running: $ git pull https://github.com

[GitHub] incubator-trafficcontrol pull request #814: [BACKPORT] [TC-519] - adds back ...

2017-08-15 Thread mitchell852
GitHub user mitchell852 opened a pull request: https://github.com/apache/incubator-trafficcontrol/pull/814 [BACKPORT] [TC-519] - adds back missing tenants menu item (cherry picked from commit a049589041ece51d6069cae09e2fdf23440d4a91) You can merge this pull request into a Git

[GitHub] incubator-trafficcontrol pull request #821: [BACKPORT] [TC-521] TPv2 - accou...

2017-08-15 Thread mitchell852
GitHub user mitchell852 opened a pull request: https://github.com/apache/incubator-trafficcontrol/pull/821 [BACKPORT] [TC-521] TPv2 - accounts for missing dependency that centos 7.3 doesn't provide … when centos 7.4 is available this dependency will be provided with the distro

[GitHub] incubator-trafficcontrol issue #754: Configure session tracking on TO side

2017-08-16 Thread mitchell852
Github user mitchell852 commented on the issue: https://github.com/apache/incubator-trafficcontrol/pull/754 and was this discussed on the ML because i'm a pretty hard -1 on more DS table columns (if possible). That table is way out of control imo (50+ columns already?). @knutsel did

[GitHub] incubator-trafficcontrol pull request #811: [TC-519] - adds back missing ten...

2017-08-14 Thread mitchell852
GitHub user mitchell852 opened a pull request: https://github.com/apache/incubator-trafficcontrol/pull/811 [TC-519] - adds back missing tenants menu item You can merge this pull request into a Git repository by running: $ git pull https://github.com/mitchell852/incubator

[GitHub] incubator-trafficcontrol pull request #812: [TC-517] TP - displays users fil...

2017-08-14 Thread mitchell852
GitHub user mitchell852 opened a pull request: https://github.com/apache/incubator-trafficcontrol/pull/812 [TC-517] TP - displays users filtered by tenant. API adds tenant filter to use… …rs api. You can merge this pull request into a Git repository by running: $ git pull

[GitHub] incubator-trafficcontrol issue #790: [TC-336] build ui for managing url sig ...

2017-08-10 Thread mitchell852
Github user mitchell852 commented on the issue: https://github.com/apache/incubator-trafficcontrol/pull/790 you might want to consider adding a confirm dialog to the generate button. i.e. "Are you sure you want to generate url sig keys?" - search for dialog.confirm to

[GitHub] incubator-trafficcontrol pull request #730: [TC-64] - updating current user ...

2017-07-13 Thread mitchell852
GitHub user mitchell852 opened a pull request: https://github.com/apache/incubator-trafficcontrol/pull/730 [TC-64] - updating current user uses a different api than updating any user You can merge this pull request into a Git repository by running: $ git pull https

[GitHub] incubator-trafficcontrol pull request #722: [TC-64] - fixes tp release info ...

2017-07-11 Thread mitchell852
GitHub user mitchell852 opened a pull request: https://github.com/apache/incubator-trafficcontrol/pull/722 [TC-64] - fixes tp release info dialog You can merge this pull request into a Git repository by running: $ git pull https://github.com/mitchell852/incubator

[GitHub] incubator-trafficcontrol pull request #719: [TC-64] - hooks steering targets...

2017-07-10 Thread mitchell852
GitHub user mitchell852 opened a pull request: https://github.com/apache/incubator-trafficcontrol/pull/719 [TC-64] - hooks steering targets into TP …c portal You can merge this pull request into a Git repository by running: $ git pull https://github.com/mitchell852

[GitHub] incubator-trafficcontrol issue #740: add safe (limited field) update endpoin...

2017-07-20 Thread mitchell852
Github user mitchell852 commented on the issue: https://github.com/apache/incubator-trafficcontrol/pull/740 when adding api endpoints, be sure to add your endpoint to the seeds.sql file. my guess is you'll want to create a new capability called ds-write-safe or something

[GitHub] incubator-trafficcontrol issue #740: add safe (limited field) update endpoin...

2017-07-20 Thread mitchell852
Github user mitchell852 commented on the issue: https://github.com/apache/incubator-trafficcontrol/pull/740 actually, you know what? can you just add your api to the ds-write capability in seeds.sql? i think rather than creating a new capability, we stick to the standard ones and let

[GitHub] incubator-trafficcontrol pull request #744: [TC-430] - accounts for scenario...

2017-07-20 Thread mitchell852
GitHub user mitchell852 opened a pull request: https://github.com/apache/incubator-trafficcontrol/pull/744 [TC-430] - accounts for scenario where no servers exist You can merge this pull request into a Git repository by running: $ git pull https://github.com/mitchell852

[GitHub] incubator-trafficcontrol issue #742: [TC-428] Ds tenancy validation

2017-07-25 Thread mitchell852
Github user mitchell852 commented on the issue: https://github.com/apache/incubator-trafficcontrol/pull/742 just so i'm clear. to fully implement tenancy you should set the parameters like this? ignore-tenancy=0 ignore_ds_tmuser_assignment=1 --- If your

[GitHub] incubator-trafficcontrol pull request #742: [TC-428] Ds tenancy validation

2017-07-24 Thread mitchell852
Github user mitchell852 commented on a diff in the pull request: https://github.com/apache/incubator-trafficcontrol/pull/742#discussion_r129085204 --- Diff: traffic_ops/app/lib/API/Deliveryservice.pm --- @@ -950,8 +996,13 @@ sub state { my $id = $self->param(

[GitHub] incubator-trafficcontrol issue #740: add safe (limited field) update endpoin...

2017-07-24 Thread mitchell852
Github user mitchell852 commented on the issue: https://github.com/apache/incubator-trafficcontrol/pull/740 Can you add some documentation for this new api endpoint? you'll want to update this file: https://github.com/apache/incubator-trafficcontrol/blob/master/docs/source

[GitHub] incubator-trafficcontrol pull request #748: [TC-419] - implements configurab...

2017-07-24 Thread mitchell852
GitHub user mitchell852 opened a pull request: https://github.com/apache/incubator-trafficcontrol/pull/748 [TC-419] - implements configurable autorefresh of TPv2 dashboard components You can merge this pull request into a Git repository by running: $ git pull https

[GitHub] incubator-trafficcontrol pull request #740: add safe (limited field) update ...

2017-07-24 Thread mitchell852
Github user mitchell852 commented on a diff in the pull request: https://github.com/apache/incubator-trafficcontrol/pull/740#discussion_r129148171 --- Diff: docs/source/development/traffic_ops_api/v12/deliveryservice.rst --- @@ -2648,7 +2648,266 @@ SSL Keys

[GitHub] incubator-trafficcontrol issue #742: [TC-428] Ds tenancy validation

2017-07-24 Thread mitchell852
Github user mitchell852 commented on the issue: https://github.com/apache/incubator-trafficcontrol/pull/742 I'm a little worried that I don't see an entry in the seeds.sql file for the ignore-tenancy parameter. I feel like if somebody want's to disable tenancy they will not know

[GitHub] incubator-trafficcontrol pull request #761: Add TO client DS ByServer, Regex...

2017-07-27 Thread mitchell852
Github user mitchell852 commented on a diff in the pull request: https://github.com/apache/incubator-trafficcontrol/pull/761#discussion_r129881754 --- Diff: traffic_ops/client/delivery_service_endpoints.go --- @@ -22,6 +22,10 @@ func deliveryServicesEp() string { return

[GitHub] incubator-trafficcontrol pull request #760: [TC-477] - disables select all c...

2017-07-27 Thread mitchell852
GitHub user mitchell852 opened a pull request: https://github.com/apache/incubator-trafficcontrol/pull/760 [TC-477] - disables select all checkbox when results are filtered You can merge this pull request into a Git repository by running: $ git pull https://github.com

[GitHub] incubator-trafficcontrol pull request #751: [TC-462] Ds tenancy validation r...

2017-07-27 Thread mitchell852
Github user mitchell852 commented on a diff in the pull request: https://github.com/apache/incubator-trafficcontrol/pull/751#discussion_r129905512 --- Diff: traffic_ops/app/lib/API/DeliveryServiceRegexes.pm --- @@ -66,6 +73,12 @@ sub index { return $self->not_fo

[GitHub] incubator-trafficcontrol pull request #751: [TC-462] Ds tenancy validation r...

2017-07-27 Thread mitchell852
Github user mitchell852 commented on a diff in the pull request: https://github.com/apache/incubator-trafficcontrol/pull/751#discussion_r129906584 --- Diff: traffic_ops/app/lib/API/DeliveryServiceRegexes.pm --- @@ -66,6 +73,12 @@ sub index { return $self->not_fo

[GitHub] incubator-trafficcontrol pull request #751: [TC-462] Ds tenancy validation r...

2017-07-27 Thread mitchell852
Github user mitchell852 commented on a diff in the pull request: https://github.com/apache/incubator-trafficcontrol/pull/751#discussion_r129904886 --- Diff: traffic_ops/app/lib/API/DeliveryServiceRegexes.pm --- @@ -27,12 +28,18 @@ use Validate::Tiny ':all'; sub all

[GitHub] incubator-trafficcontrol pull request #751: [TC-462] Ds tenancy validation r...

2017-07-27 Thread mitchell852
Github user mitchell852 commented on a diff in the pull request: https://github.com/apache/incubator-trafficcontrol/pull/751#discussion_r129906932 --- Diff: traffic_ops/app/lib/API/DeliveryServiceRegexes.pm --- @@ -222,6 +262,18 @@ sub delete { return $self

[GitHub] incubator-trafficcontrol pull request #751: [TC-462] Ds tenancy validation r...

2017-07-27 Thread mitchell852
Github user mitchell852 commented on a diff in the pull request: https://github.com/apache/incubator-trafficcontrol/pull/751#discussion_r129904376 --- Diff: traffic_ops/app/lib/API/DeliveryServiceMatches.pm --- @@ -28,11 +29,19 @@ sub index { my $format = $self->pa

[GitHub] incubator-trafficcontrol pull request #752: [TC-460] Ds tenancy validation s...

2017-07-27 Thread mitchell852
Github user mitchell852 commented on a diff in the pull request: https://github.com/apache/incubator-trafficcontrol/pull/752#discussion_r129933611 --- Diff: traffic_ops/app/lib/API/Server.pm --- @@ -569,10 +575,17 @@ sub get_unassigned_servers_by_dsid { $ds_server_criteria

[GitHub] incubator-trafficcontrol pull request #752: [TC-460] Ds tenancy validation s...

2017-07-27 Thread mitchell852
Github user mitchell852 commented on a diff in the pull request: https://github.com/apache/incubator-trafficcontrol/pull/752#discussion_r129931534 --- Diff: traffic_ops/app/lib/API/Server.pm --- @@ -445,18 +431,27 @@ sub get_servers_by_dsid { my $orderby_snakecase

[GitHub] incubator-trafficcontrol pull request #752: [TC-460] Ds tenancy validation s...

2017-07-27 Thread mitchell852
Github user mitchell852 commented on a diff in the pull request: https://github.com/apache/incubator-trafficcontrol/pull/752#discussion_r129931600 --- Diff: traffic_ops/app/lib/API/Server.pm --- @@ -489,11 +484,22 @@ sub get_edge_servers_by_dsid { my $self= shift

[GitHub] incubator-trafficcontrol pull request #752: [TC-460] Ds tenancy validation s...

2017-07-27 Thread mitchell852
Github user mitchell852 commented on a diff in the pull request: https://github.com/apache/incubator-trafficcontrol/pull/752#discussion_r129933912 --- Diff: traffic_ops/app/lib/API/Server.pm --- @@ -726,41 +746,26 @@ sub get_servers_by_type { my $orderby = $self

[GitHub] incubator-trafficcontrol pull request #752: [TC-460] Ds tenancy validation s...

2017-07-27 Thread mitchell852
Github user mitchell852 commented on a diff in the pull request: https://github.com/apache/incubator-trafficcontrol/pull/752#discussion_r129914745 --- Diff: traffic_ops/app/lib/API/DeliveryServiceServer.pm --- @@ -80,15 +86,21 @@ sub assign_servers_to_ds { return

[GitHub] incubator-trafficcontrol pull request #752: [TC-460] Ds tenancy validation s...

2017-07-27 Thread mitchell852
Github user mitchell852 commented on a diff in the pull request: https://github.com/apache/incubator-trafficcontrol/pull/752#discussion_r129913844 --- Diff: traffic_ops/app/lib/API/DeliveryServiceServer.pm --- @@ -27,6 +28,11 @@ sub index { my @data; my $orderby

[GitHub] incubator-trafficcontrol pull request #752: [TC-460] Ds tenancy validation s...

2017-07-27 Thread mitchell852
Github user mitchell852 commented on a diff in the pull request: https://github.com/apache/incubator-trafficcontrol/pull/752#discussion_r129913397 --- Diff: traffic_ops/app/lib/API/DeliveryServiceServer.pm --- @@ -27,6 +28,11 @@ sub index { my @data; my $orderby

[GitHub] incubator-trafficcontrol pull request #752: [TC-460] Ds tenancy validation s...

2017-07-27 Thread mitchell852
Github user mitchell852 commented on a diff in the pull request: https://github.com/apache/incubator-trafficcontrol/pull/752#discussion_r129930025 --- Diff: traffic_ops/app/lib/API/DeliveryServiceServer.pm --- @@ -223,8 +240,19 @@ sub remove_server_from_ds { my $ds_id

[GitHub] incubator-trafficcontrol pull request #752: [TC-460] Ds tenancy validation s...

2017-07-27 Thread mitchell852
Github user mitchell852 commented on a diff in the pull request: https://github.com/apache/incubator-trafficcontrol/pull/752#discussion_r129933537 --- Diff: traffic_ops/app/lib/API/Server.pm --- @@ -569,10 +575,17 @@ sub get_unassigned_servers_by_dsid { $ds_server_criteria

[GitHub] incubator-trafficcontrol pull request #752: [TC-460] Ds tenancy validation s...

2017-07-27 Thread mitchell852
Github user mitchell852 commented on a diff in the pull request: https://github.com/apache/incubator-trafficcontrol/pull/752#discussion_r129934238 --- Diff: traffic_ops/app/lib/API/Server.pm --- @@ -947,6 +952,10 @@ sub details_v11 { } my

[GitHub] incubator-trafficcontrol pull request #752: [TC-460] Ds tenancy validation s...

2017-07-27 Thread mitchell852
Github user mitchell852 commented on a diff in the pull request: https://github.com/apache/incubator-trafficcontrol/pull/752#discussion_r129934310 --- Diff: traffic_ops/app/lib/API/Server.pm --- @@ -1021,6 +1030,10 @@ sub details

[GitHub] incubator-trafficcontrol pull request #755: [TC-476] - TPv2 - improper datab...

2017-07-26 Thread mitchell852
GitHub user mitchell852 opened a pull request: https://github.com/apache/incubator-trafficcontrol/pull/755 [TC-476] - TPv2 - improper databinding to maxDNSAnswers instead of maxDnsAnswers You can merge this pull request into a Git repository by running: $ git pull https

[GitHub] incubator-trafficcontrol pull request #757: TPv2 - changes form input identi...

2017-07-26 Thread mitchell852
GitHub user mitchell852 opened a pull request: https://github.com/apache/incubator-trafficcontrol/pull/757 TPv2 - changes form input identifiers on login page to avoid browser saved v… …alues from showing in other form inputs of same name You can merge this pull request

[GitHub] incubator-trafficcontrol pull request #735: [TC-427] User tenancy validation

2017-07-19 Thread mitchell852
Github user mitchell852 commented on a diff in the pull request: https://github.com/apache/incubator-trafficcontrol/pull/735#discussion_r128346564 --- Diff: traffic_ops/app/lib/API/User.pm --- @@ -477,6 +506,13 @@ sub update_current { return $self->alert( "

[GitHub] incubator-trafficcontrol pull request #741: updates TP readme files

2017-07-19 Thread mitchell852
GitHub user mitchell852 opened a pull request: https://github.com/apache/incubator-trafficcontrol/pull/741 updates TP readme files You can merge this pull request into a Git repository by running: $ git pull https://github.com/mitchell852/incubator-trafficcontrol fixes-tp

[GitHub] incubator-trafficcontrol pull request #745: [TC-444] - removes references to...

2017-07-20 Thread mitchell852
GitHub user mitchell852 opened a pull request: https://github.com/apache/incubator-trafficcontrol/pull/745 [TC-444] - removes references to migrations user and role as it is no longer use… …d for database migrations You can merge this pull request into a Git repository

[GitHub] incubator-trafficcontrol pull request #740: add safe (limited field) update ...

2017-07-20 Thread mitchell852
Github user mitchell852 commented on a diff in the pull request: https://github.com/apache/incubator-trafficcontrol/pull/740#discussion_r128634422 --- Diff: traffic_ops/app/lib/API/Deliveryservice.pm --- @@ -442,6 +442,139 @@ sub update { } } +sub

[GitHub] incubator-trafficcontrol pull request #740: add safe (limited field) update ...

2017-07-20 Thread mitchell852
Github user mitchell852 commented on a diff in the pull request: https://github.com/apache/incubator-trafficcontrol/pull/740#discussion_r128633810 --- Diff: traffic_ops/app/lib/API/Deliveryservice.pm --- @@ -442,6 +442,139 @@ sub update { } } +sub

[GitHub] incubator-trafficcontrol pull request #740: add safe (limited field) update ...

2017-07-20 Thread mitchell852
Github user mitchell852 commented on a diff in the pull request: https://github.com/apache/incubator-trafficcontrol/pull/740#discussion_r128633945 --- Diff: traffic_ops/app/lib/API/Deliveryservice.pm --- @@ -442,6 +442,139 @@ sub update { } } +sub

[GitHub] incubator-trafficcontrol pull request #727: [TC-417] - clears tm_user.token ...

2017-07-12 Thread mitchell852
GitHub user mitchell852 opened a pull request: https://github.com/apache/incubator-trafficcontrol/pull/727 [TC-417] - clears tm_user.token that was generated during portal user registration process as u… …pdating your current user signifies that your registration is complete

[GitHub] incubator-trafficcontrol pull request #644: Tenant utils

2017-06-28 Thread mitchell852
Github user mitchell852 commented on a diff in the pull request: https://github.com/apache/incubator-trafficcontrol/pull/644#discussion_r124659823 --- Diff: traffic_ops/app/lib/API/Tenant.pm --- @@ -121,7 +115,12 @@ sub update

[GitHub] incubator-trafficcontrol pull request #644: Tenant utils

2017-06-28 Thread mitchell852
Github user mitchell852 commented on a diff in the pull request: https://github.com/apache/incubator-trafficcontrol/pull/644#discussion_r124589621 --- Diff: traffic_ops/app/lib/API/Tenant.pm --- @@ -31,34 +32,28 @@ sub getTenantName { return defined($tenant_id) ? $self->

[GitHub] incubator-trafficcontrol pull request #644: Tenant utils

2017-06-28 Thread mitchell852
Github user mitchell852 commented on a diff in the pull request: https://github.com/apache/incubator-trafficcontrol/pull/644#discussion_r124623700 --- Diff: traffic_ops/app/lib/API/Tenant.pm --- @@ -131,21 +130,74 @@ sub update { my $is_active = $params->{act

[GitHub] incubator-trafficcontrol pull request #644: Tenant utils

2017-06-28 Thread mitchell852
Github user mitchell852 commented on a diff in the pull request: https://github.com/apache/incubator-trafficcontrol/pull/644#discussion_r124625956 --- Diff: traffic_ops/app/lib/API/Tenant.pm --- @@ -248,7 +326,17 @@ sub delete { if ( !defined($tenant

[GitHub] incubator-trafficcontrol pull request #644: Tenant utils

2017-06-28 Thread mitchell852
Github user mitchell852 commented on a diff in the pull request: https://github.com/apache/incubator-trafficcontrol/pull/644#discussion_r124628818 --- Diff: traffic_ops/app/lib/API/User.pm --- @@ -404,7 +406,7 @@ sub current { my $self = shift; my @data; my

[GitHub] incubator-trafficcontrol pull request #644: Tenant utils

2017-06-28 Thread mitchell852
Github user mitchell852 commented on a diff in the pull request: https://github.com/apache/incubator-trafficcontrol/pull/644#discussion_r124592678 --- Diff: traffic_ops/app/lib/API/Tenant.pm --- @@ -31,34 +32,28 @@ sub getTenantName { return defined($tenant_id) ? $self->

[GitHub] incubator-trafficcontrol pull request #644: Tenant utils

2017-06-28 Thread mitchell852
Github user mitchell852 commented on a diff in the pull request: https://github.com/apache/incubator-trafficcontrol/pull/644#discussion_r124624257 --- Diff: traffic_ops/app/lib/API/Tenant.pm --- @@ -131,21 +130,74 @@ sub update { my $is_active = $params->{act

[GitHub] incubator-trafficcontrol pull request #644: Tenant utils

2017-06-28 Thread mitchell852
Github user mitchell852 commented on a diff in the pull request: https://github.com/apache/incubator-trafficcontrol/pull/644#discussion_r124621754 --- Diff: traffic_ops/app/lib/API/Tenant.pm --- @@ -131,21 +130,74 @@ sub update { my $is_active = $params->{act

[GitHub] incubator-trafficcontrol pull request #644: Tenant utils

2017-06-28 Thread mitchell852
Github user mitchell852 commented on a diff in the pull request: https://github.com/apache/incubator-trafficcontrol/pull/644#discussion_r124597615 --- Diff: traffic_ops/app/lib/API/Tenant.pm --- @@ -121,7 +115,12 @@ sub update

[GitHub] incubator-trafficcontrol pull request #644: Tenant utils

2017-06-28 Thread mitchell852
Github user mitchell852 commented on a diff in the pull request: https://github.com/apache/incubator-trafficcontrol/pull/644#discussion_r124625194 --- Diff: traffic_ops/app/lib/API/Tenant.pm --- @@ -185,11 +237,36 @@ sub create { return $self->alert("Ten

[GitHub] incubator-trafficcontrol pull request #644: Tenant utils

2017-06-28 Thread mitchell852
Github user mitchell852 commented on a diff in the pull request: https://github.com/apache/incubator-trafficcontrol/pull/644#discussion_r124660517 --- Diff: traffic_ops/app/lib/API/Tenant.pm --- @@ -248,7 +326,17 @@ sub delete { if ( !defined($tenant

[GitHub] incubator-trafficcontrol pull request #644: Tenant utils

2017-06-28 Thread mitchell852
Github user mitchell852 commented on a diff in the pull request: https://github.com/apache/incubator-trafficcontrol/pull/644#discussion_r124660063 --- Diff: traffic_ops/app/lib/API/Tenant.pm --- @@ -131,21 +130,74 @@ sub update { my $is_active = $params->{act

[GitHub] incubator-trafficcontrol issue #708: promotes TO experimental UI to the new ...

2017-06-30 Thread mitchell852
Github user mitchell852 commented on the issue: https://github.com/apache/incubator-trafficcontrol/pull/708 Per this email it has been decided that the new TO UI (that consumes the TO API) will take the place of the Traffic Portal https://lists.apache.org/thread.html

[GitHub] incubator-trafficcontrol pull request #711: [TC-64] - adds ccr dns ttl to ht...

2017-07-03 Thread mitchell852
GitHub user mitchell852 opened a pull request: https://github.com/apache/incubator-trafficcontrol/pull/711 [TC-64] - adds ccr dns ttl to http* and dns* deliveryservices with an appropria… …te default value You can merge this pull request into a Git repository by running

[GitHub] incubator-trafficcontrol pull request #644: Tenant utils

2017-06-29 Thread mitchell852
Github user mitchell852 commented on a diff in the pull request: https://github.com/apache/incubator-trafficcontrol/pull/644#discussion_r124806475 --- Diff: traffic_ops/app/lib/API/Tenant.pm --- @@ -131,21 +130,74 @@ sub update { my $is_active = $params->{act

[GitHub] incubator-trafficcontrol issue #703: [TC-64] - new TO UI is to be named traf...

2017-06-27 Thread mitchell852
Github user mitchell852 commented on the issue: https://github.com/apache/incubator-trafficcontrol/pull/703 Per this email thread - https://lists.apache.org/thread.html/b24a6a6807a50c52d6c9e82e4a3e00f78a56179e57cfadf21fc1711a@%3Cusers.trafficcontrol.apache.org%3E --- If your project

[GitHub] incubator-trafficcontrol pull request #524: [TC-64] TOUI experimental - adds...

2017-04-26 Thread mitchell852
GitHub user mitchell852 opened a pull request: https://github.com/apache/incubator-trafficcontrol/pull/524 [TC-64] TOUI experimental - adds update status dialog and also changes return object of generic d… …ialog component You can merge this pull request into a Git repository

[GitHub] incubator-trafficcontrol pull request #526: [TC-64] - TO exp - fixes respons...

2017-04-27 Thread mitchell852
GitHub user mitchell852 opened a pull request: https://github.com/apache/incubator-trafficcontrol/pull/526 [TC-64] - TO exp - fixes responsive layout You can merge this pull request into a Git repository by running: $ git pull https://github.com/mitchell852/incubator

[GitHub] incubator-trafficcontrol issue #497: Allow specification of the 'id' paramet...

2017-04-27 Thread mitchell852
Github user mitchell852 commented on the issue: https://github.com/apache/incubator-trafficcontrol/pull/497 @jschmerge - can you create a jira ticket for this? https://issues.apache.org/jira/browse/TC --- If your project is set up for it, you can reply to this email and have your

[GitHub] incubator-trafficcontrol pull request #435: Authorization model

2017-04-24 Thread mitchell852
Github user mitchell852 commented on a diff in the pull request: https://github.com/apache/incubator-trafficcontrol/pull/435#discussion_r113053856 --- Diff: traffic_ops/app/lib/API/ApiCapability.pm --- @@ -0,0 +1,258 @@ +package API::ApiCapability

[GitHub] incubator-trafficcontrol pull request #435: Authorization model

2017-04-24 Thread mitchell852
Github user mitchell852 commented on a diff in the pull request: https://github.com/apache/incubator-trafficcontrol/pull/435#discussion_r113053641 --- Diff: traffic_ops/app/lib/API/ApiCapability.pm --- @@ -0,0 +1,258 @@ +package API::ApiCapability

[GitHub] incubator-trafficcontrol pull request #435: Authorization model

2017-04-24 Thread mitchell852
Github user mitchell852 commented on a diff in the pull request: https://github.com/apache/incubator-trafficcontrol/pull/435#discussion_r113056848 --- Diff: traffic_ops/app/lib/API/ApiCapability.pm --- @@ -0,0 +1,258 @@ +package API::ApiCapability

[GitHub] incubator-trafficcontrol pull request #435: Authorization model

2017-04-24 Thread mitchell852
Github user mitchell852 commented on a diff in the pull request: https://github.com/apache/incubator-trafficcontrol/pull/435#discussion_r113049468 --- Diff: traffic_ops/app/db/migrations/2017040601_create_capabilities_and_roles.sql --- @@ -0,0 +1,89

[GitHub] incubator-trafficcontrol pull request #435: Authorization model

2017-04-24 Thread mitchell852
Github user mitchell852 commented on a diff in the pull request: https://github.com/apache/incubator-trafficcontrol/pull/435#discussion_r113049164 --- Diff: traffic_ops/app/db/migrations/2017040601_create_capabilities_and_roles.sql --- @@ -0,0 +1,89

[GitHub] incubator-trafficcontrol pull request #435: Authorization model

2017-04-24 Thread mitchell852
Github user mitchell852 commented on a diff in the pull request: https://github.com/apache/incubator-trafficcontrol/pull/435#discussion_r113056228 --- Diff: traffic_ops/app/lib/TrafficOpsRoutes.pm --- @@ -657,6 +657,23 @@ sub api_routes { # Supports ?orderby=key $r

[GitHub] incubator-trafficcontrol pull request #435: Authorization model

2017-04-24 Thread mitchell852
Github user mitchell852 commented on a diff in the pull request: https://github.com/apache/incubator-trafficcontrol/pull/435#discussion_r113052674 --- Diff: traffic_ops/app/db/seeds.sql --- @@ -22,6 +22,257 @@ insert into role (id, name, description, priv_level) values (5

[GitHub] incubator-trafficcontrol pull request #435: Authorization model

2017-04-24 Thread mitchell852
Github user mitchell852 commented on a diff in the pull request: https://github.com/apache/incubator-trafficcontrol/pull/435#discussion_r113050424 --- Diff: traffic_ops/app/db/seeds.sql --- @@ -22,6 +22,257 @@ insert into role (id, name, description, priv_level) values (5

[GitHub] incubator-trafficcontrol pull request #435: Authorization model

2017-04-24 Thread mitchell852
Github user mitchell852 commented on a diff in the pull request: https://github.com/apache/incubator-trafficcontrol/pull/435#discussion_r113049926 --- Diff: traffic_ops/app/db/seeds.sql --- @@ -22,6 +22,257 @@ insert into role (id, name, description, priv_level) values (5

[GitHub] incubator-trafficcontrol issue #435: Authorization model

2017-04-24 Thread mitchell852
Github user mitchell852 commented on the issue: https://github.com/apache/incubator-trafficcontrol/pull/435 Hi @naamashoresh - I'm sorry to make you do this but can you reconcile your seeds.sql file? You might have to do a rebase as seeds.sql has changes significantly since you

[GitHub] incubator-trafficcontrol pull request #513: [TC-235] - fixes max_dns_answers...

2017-04-25 Thread mitchell852
GitHub user mitchell852 opened a pull request: https://github.com/apache/incubator-trafficcontrol/pull/513 [TC-235] - fixes max_dns_answers for all DNS* types You can merge this pull request into a Git repository by running: $ git pull https://github.com/mitchell852/incubator

[GitHub] incubator-trafficcontrol pull request #529: [TC-64] - TO exp - fixes bug in ...

2017-04-28 Thread mitchell852
GitHub user mitchell852 opened a pull request: https://github.com/apache/incubator-trafficcontrol/pull/529 [TC-64] - TO exp - fixes bug in change log poller. had to move it into a persistent mode… …l so the $interval would not get crushed. it is needed to cancel the interval

[GitHub] incubator-trafficcontrol pull request #509: [TC-64] - adds the ability to un...

2017-04-24 Thread mitchell852
GitHub user mitchell852 opened a pull request: https://github.com/apache/incubator-trafficcontrol/pull/509 [TC-64] - adds the ability to unlink profiles from parameters You can merge this pull request into a Git repository by running: $ git pull https://github.com/mitchell852

[GitHub] incubator-trafficcontrol pull request #777: [TC-498] - case mismatch was cau...

2017-08-04 Thread mitchell852
GitHub user mitchell852 opened a pull request: https://github.com/apache/incubator-trafficcontrol/pull/777 [TC-498] - case mismatch was causing no validation on fullName when updating current user You can merge this pull request into a Git repository by running: $ git pull

[GitHub] incubator-trafficcontrol pull request #764: [TC-480] - adds exampleurls (aka...

2017-07-28 Thread mitchell852
GitHub user mitchell852 opened a pull request: https://github.com/apache/incubator-trafficcontrol/pull/764 [TC-480] - adds exampleurls (aka edge fqdns) to ds view/edit form You can merge this pull request into a Git repository by running: $ git pull https://github.com

[GitHub] incubator-trafficcontrol pull request #770: [TC-486] - adds steering role to...

2017-08-01 Thread mitchell852
GitHub user mitchell852 opened a pull request: https://github.com/apache/incubator-trafficcontrol/pull/770 [TC-486] - adds steering role to steering apis You can merge this pull request into a Git repository by running: $ git pull https://github.com/mitchell852/incubator

[GitHub] incubator-trafficcontrol pull request #787: TPv2 - adds unique query param v...

2017-08-08 Thread mitchell852
GitHub user mitchell852 opened a pull request: https://github.com/apache/incubator-trafficcontrol/pull/787 TPv2 - adds unique query param value on build to force invalidation of assets You can merge this pull request into a Git repository by running: $ git pull https

[GitHub] incubator-trafficcontrol pull request #792: [Backport] [TC-504] - fixes numb...

2017-08-09 Thread mitchell852
GitHub user mitchell852 opened a pull request: https://github.com/apache/incubator-trafficcontrol/pull/792 [Backport] [TC-504] - fixes number validation on global max settings (cherry picked from commit 8603bc83dfe9b667af54f9101028740940bac86f) You can merge this pull request

[GitHub] incubator-trafficcontrol pull request #784: [TC-423] - adds clone profile to...

2017-08-08 Thread mitchell852
GitHub user mitchell852 opened a pull request: https://github.com/apache/incubator-trafficcontrol/pull/784 [TC-423] - adds clone profile to TPv2 and adds a few missing change log statements You can merge this pull request into a Git repository by running: $ git pull https

[GitHub] incubator-trafficcontrol pull request #791: [TC-504] - fixes number validati...

2017-08-09 Thread mitchell852
GitHub user mitchell852 opened a pull request: https://github.com/apache/incubator-trafficcontrol/pull/791 [TC-504] - fixes number validation on global max settings You can merge this pull request into a Git repository by running: $ git pull https://github.com/mitchell852

[GitHub] incubator-trafficcontrol pull request #776: fixes tenant test

2017-08-04 Thread mitchell852
GitHub user mitchell852 opened a pull request: https://github.com/apache/incubator-trafficcontrol/pull/776 fixes tenant test You can merge this pull request into a Git repository by running: $ git pull https://github.com/mitchell852/incubator-trafficcontrol fixes-tenant-test

[GitHub] incubator-trafficcontrol pull request #782: updates tp dev install doc

2017-08-07 Thread mitchell852
GitHub user mitchell852 opened a pull request: https://github.com/apache/incubator-trafficcontrol/pull/782 updates tp dev install doc You can merge this pull request into a Git repository by running: $ git pull https://github.com/mitchell852/incubator-trafficcontrol updates

[GitHub] incubator-trafficcontrol pull request #783: [TC-437] - adds the ability to g...

2017-08-07 Thread mitchell852
GitHub user mitchell852 opened a pull request: https://github.com/apache/incubator-trafficcontrol/pull/783 [TC-437] - adds the ability to generate an ISO to the api / traffic portal v2 You can merge this pull request into a Git repository by running: $ git pull https

[GitHub] incubator-trafficcontrol pull request #834: [BACKPORT] [TC-533] - ssl_keys -...

2017-08-18 Thread mitchell852
Github user mitchell852 closed the pull request at: https://github.com/apache/incubator-trafficcontrol/pull/834 --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project does not have this feature enabled and wishes so

[GitHub] incubator-trafficcontrol pull request #831: [TC-535] url sig - tenancy check...

2017-08-18 Thread mitchell852
Github user mitchell852 commented on a diff in the pull request: https://github.com/apache/incubator-trafficcontrol/pull/831#discussion_r134007263 --- Diff: traffic_ops/app/lib/API/DeliveryService/KeysUrlSig.pm --- @@ -98,7 +118,7 @@ sub copy_url_sig_keys { if ( defined

[GitHub] incubator-trafficcontrol pull request #838: [BACKPORT] [TC-441] - hooks up p...

2017-08-18 Thread mitchell852
GitHub user mitchell852 opened a pull request: https://github.com/apache/incubator-trafficcontrol/pull/838 [BACKPORT] [TC-441] - hooks up password reset to TP (cherry picked from commit 421d390de80d5fa75a0d17488cf3a24bbe2fcc27) You can merge this pull request into a Git repository

[GitHub] incubator-trafficcontrol pull request #834: [BACKPORT] [TC-533] - ssl_keys -...

2017-08-18 Thread mitchell852
GitHub user mitchell852 opened a pull request: https://github.com/apache/incubator-trafficcontrol/pull/834 [BACKPORT] [TC-533] - ssl_keys - tenancy checks (cherry picked from commit 01452c99a0fc4d459742a67bad3bab9f20fcf4e6) You can merge this pull request into a Git repository

[GitHub] incubator-trafficcontrol pull request #831: [TC-535] url sig - tenancy check...

2017-08-18 Thread mitchell852
Github user mitchell852 commented on a diff in the pull request: https://github.com/apache/incubator-trafficcontrol/pull/831#discussion_r134007130 --- Diff: traffic_ops/app/lib/API/DeliveryService/KeysUrlSig.pm --- @@ -69,14 +86,17 @@ sub copy_url_sig_keys { else

[GitHub] incubator-trafficcontrol pull request #831: [TC-535] url sig - tenancy check...

2017-08-18 Thread mitchell852
Github user mitchell852 commented on a diff in the pull request: https://github.com/apache/incubator-trafficcontrol/pull/831#discussion_r134007307 --- Diff: traffic_ops/app/lib/API/DeliveryService/KeysUrlSig.pm --- @@ -134,17 +154,22 @@ sub generate { my $current_user

[GitHub] incubator-trafficcontrol pull request #831: [TC-535] url sig - tenancy check...

2017-08-18 Thread mitchell852
Github user mitchell852 commented on a diff in the pull request: https://github.com/apache/incubator-trafficcontrol/pull/831#discussion_r134007236 --- Diff: traffic_ops/app/lib/API/DeliveryService/KeysUrlSig.pm --- @@ -98,7 +118,7 @@ sub copy_url_sig_keys { if ( defined

<    1   2   3   4   5   >