Github user alficles commented on the issue:
https://github.com/apache/incubator-trafficcontrol/pull/327
+1. This is good to merge.
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this
Github user dangogh commented on the issue:
https://github.com/apache/incubator-trafficcontrol/pull/327
adding those 2 things to BUILD.md shortly..For last point, I think
deal with it separately. Created issue
https://issues.apache.org/jira/browse/TC-180 for that.
---
If
Github user alficles commented on the issue:
https://github.com/apache/incubator-trafficcontrol/pull/327
Ok. I've tested this. It correctly produces binaries in the `dist`
directory, without polluting your environment. For anyone else testing, make
sure your docker is on the absolute
Github user limited commented on the issue:
https://github.com/apache/incubator-trafficcontrol/pull/327
noted, will see how the merge looks. probably a go
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project
Github user dangogh commented on the issue:
https://github.com/apache/incubator-trafficcontrol/pull/327
@alficles -- latest should address those clean concerns..
@limited -- please consider pulling in to 2.0
---
If your project is set up for it, you can reply to this email
Github user alficles commented on the issue:
https://github.com/apache/incubator-trafficcontrol/pull/327
Here's what I do on the ats-rpmbuild side:
```
#!/usr/bin/env bash
if [ ! -d /src ]; then
echo "Source directory does not exist."
exit
Github user dangogh commented on the issue:
https://github.com/apache/incubator-trafficcontrol/pull/327
@alficles -- copying the repo wouldn't be easier: chicken vs egg.
docker-compose operates from that directory, so would need to switch to the
copy mid-stream. Cleaning up
Github user rob05c commented on the issue:
https://github.com/apache/incubator-trafficcontrol/pull/327
@dangogh @alficles Yes, traffic_monitor and traffic_monitor_golang should
never both be built. One is replacing the other. The plan is to rename the
`traffic_monitor_golang`
Github user alficles commented on the issue:
https://github.com/apache/incubator-trafficcontrol/pull/327
This is a marked improvement, but it introduces a new issue: `make clean`.
Since the build is happening directly in the local directories, all the
temporary files will be left
Github user alficles commented on the issue:
https://github.com/apache/incubator-trafficcontrol/pull/327
@dangogh @rob05c Yeah, `docker-compose up` should build all the things. As
it stands, you'll get either a build failure or, worse, an unlabeled and
arbitrary traffic_monitor
Github user dangogh commented on the issue:
https://github.com/apache/incubator-trafficcontrol/pull/327
@limited -- is this what you had in mind? Perhaps should be considered
for merge into 2.0? (for Apache compliance)
---
If your project is set up for it, you can reply to this
Github user dangogh commented on the issue:
https://github.com/apache/incubator-trafficcontrol/pull/327
@rob05c -- `traffic_monitor` and `traffic_monitor_golang` both produce the
same name rpm. Does the former need to be removed from the
`docker-compose.yml`?
---
If your project
12 matches
Mail list logo
