Github user bryancall commented on the issue:
https://github.com/apache/trafficserver/pull/1465
@zwoop Did you run the tests?
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
Github user zwoop commented on the issue:
https://github.com/apache/trafficserver/pull/1465
I'm going to land this. There will definitely be RAT report errors on this,
but we can address those either with adding licenses when needed, or add to the
RAT exclusions (e.g. exclude *.gold
Github user bryancall commented on the issue:
https://github.com/apache/trafficserver/pull/1465
Here is the full output from running the tests: https://da.gd/XOiCg
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your
Github user bryancall commented on the issue:
https://github.com/apache/trafficserver/pull/1465
I am seeing 4 failed tests.
```
[bcall@homer tests]$ ./autest.sh --ats-bin /usr/local/bin
Running Test basic:. Passed
Running Test basic-cop:. Passed
Running Test
Github user SolidWallOfCode commented on the issue:
https://github.com/apache/trafficserver/pull/1465
I think it should be a top level subdirectory because it's not just for ci.
We should expect developers to be running at least some of these tests locally,
it was part of the basic
Github user dragon512 commented on the issue:
https://github.com/apache/trafficserver/pull/1465
I am not sure why it should be under "ci" tree. That is stuff for the open
source CI system. Why would tests for ATS go under the ci data file? Tests are
for developer, not the ci system.
Github user zwoop commented on the issue:
https://github.com/apache/trafficserver/pull/1465
Should this be in the "ci" tree rather that its own top-level tree?
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your
Github user dragon512 commented on the issue:
https://github.com/apache/trafficserver/pull/1465
I just pushed a fix for CentOs and RHEL system to bootstrap better. I
believe this should take care of the issue @jpeach reported given was running
on one of those systems
---
If your
Github user dragon512 commented on the issue:
https://github.com/apache/trafficserver/pull/1465
@bryancall So from what I can see at the moment. master is broken. 7.1 is
working fine minus the custom logfile test. The remap_http and header-rewrite
fail with
- <
Github user bryancall commented on the issue:
https://github.com/apache/trafficserver/pull/1465
@dragon512
I am seeing some errors when running the tests:
```
Total of 15 test
Unknown: 0
Exception: 0
Failed: 10
Warning: 0
kipped: 2
Passed: 3
Github user atsci commented on the issue:
https://github.com/apache/trafficserver/pull/1465
Linux build *successful*! See
https://ci.trafficserver.apache.org/job/linux-github/1491/ for details.
---
If your project is set up for it, you can reply to this email and have your
Github user atsci commented on the issue:
https://github.com/apache/trafficserver/pull/1465
FreeBSD build *successful*! See
https://ci.trafficserver.apache.org/job/freebsd-github/1597/ for details.
---
If your project is set up for it, you can reply to this email and have
Github user dragon512 commented on the issue:
https://github.com/apache/trafficserver/pull/1465
This is just starter documentation.. We will move it to the official sphinx
doc later.
---
If your project is set up for it, you can reply to this email and have your
reply appear on
Github user persiaAziz commented on the issue:
https://github.com/apache/trafficserver/pull/1465
Shouldn't the documentation be a inside the doc folder of ATS? Will this
show up on the traffic server website?
---
If your project is set up for it, you can reply to this email and have
Github user dragon512 commented on the issue:
https://github.com/apache/trafficserver/pull/1465
I should have added:
- the copyright headers for the source files
- blurb to the notices file ( I hope this is correct @zwoop?)
- I have add some documentation @persiaAziz
Github user dragon512 commented on the issue:
https://github.com/apache/trafficserver/pull/1465
@jpeach So I agree with everything you suggest except for moving the test
under the ci directory. The source layout is confusing enough as is. hiding
this under some location no one will
Github user zwoop commented on the issue:
https://github.com/apache/trafficserver/pull/1465
MIT is fine. You should retain the MIT header in any imported source, and
also update the NOTICE file accordingly.
---
If your project is set up for it, you can reply to this email and have
Github user dragon512 commented on the issue:
https://github.com/apache/trafficserver/pull/1465
So copy paste header from the other source files in ATS.
There is no concern that the AuTest code ( ie the testing engine used) is
MIT.. just asking.
---
If your project is set
Github user atsci commented on the issue:
https://github.com/apache/trafficserver/pull/1465
clang-analyzer build *successful*! See
https://ci.trafficserver.apache.org/job/clang-analyzer-github/146/ for details.
---
If your project is set up for it, you can reply to this email
Github user atsci commented on the issue:
https://github.com/apache/trafficserver/pull/1465
Linux build *successful*! See
https://ci.trafficserver.apache.org/job/linux-github/1475/ for details.
---
If your project is set up for it, you can reply to this email and have your
Github user atsci commented on the issue:
https://github.com/apache/trafficserver/pull/1465
Intel CC build *successful*! See
https://ci.trafficserver.apache.org/job/icc-github/14/ for details.
---
If your project is set up for it, you can reply to this email and have your
Github user atsci commented on the issue:
https://github.com/apache/trafficserver/pull/1465
FreeBSD build *failed*! See
https://ci.trafficserver.apache.org/job/freebsd-github/1581/ for details.
---
If your project is set up for it, you can reply to this email and have your
Github user bryancall commented on the issue:
https://github.com/apache/trafficserver/pull/1465
[approve ci]
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes
23 matches
Mail list logo
