[GitHub] trafficserver issue #1559: Do not callback one SM EVENT_ERROR twice.

2017-03-08 Thread atsci
Github user atsci commented on the issue:

https://github.com/apache/trafficserver/pull/1559
  
clang-analyzer build *successful*! 
https://ci.trafficserver.apache.org/job/clang-analyzer-github/277/
 



---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastruct...@apache.org or file a JIRA ticket
with INFRA.
---


[GitHub] trafficserver issue #1559: Do not callback one SM EVENT_ERROR twice.

2017-03-08 Thread atsci
Github user atsci commented on the issue:

https://github.com/apache/trafficserver/pull/1559
  
clang-analyzer build *successful*! 
https://ci.trafficserver.apache.org/job/clang-analyzer-github/276/
 



---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastruct...@apache.org or file a JIRA ticket
with INFRA.
---


[GitHub] trafficserver issue #1559: Do not callback one SM EVENT_ERROR twice.

2017-03-08 Thread atsci
Github user atsci commented on the issue:

https://github.com/apache/trafficserver/pull/1559
  
Linux build *successful*! 
https://ci.trafficserver.apache.org/job/linux-github/1610/
 



---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastruct...@apache.org or file a JIRA ticket
with INFRA.
---


[GitHub] trafficserver issue #1559: Do not callback one SM EVENT_ERROR twice.

2017-03-08 Thread oknet
Github user oknet commented on the issue:

https://github.com/apache/trafficserver/pull/1559
  
This is a fix for #1531 to avoid enforce the handler to handle read error 
and write error.

@scw00 Can you have a try ?

@zwoop May I ignore the AU check failed ?


---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastruct...@apache.org or file a JIRA ticket
with INFRA.
---


[GitHub] trafficserver issue #1559: Do not callback one SM EVENT_ERROR twice.

2017-03-08 Thread atsci
Github user atsci commented on the issue:

https://github.com/apache/trafficserver/pull/1559
  
Intel CC build *successful*! 
https://ci.trafficserver.apache.org/job/icc-github/145/
 



---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastruct...@apache.org or file a JIRA ticket
with INFRA.
---


[GitHub] trafficserver issue #1559: Do not callback one SM EVENT_ERROR twice.

2017-03-08 Thread atsci
Github user atsci commented on the issue:

https://github.com/apache/trafficserver/pull/1559
  
AU check *failed*! https://ci.trafficserver.apache.org/job/autest-github/19/
 



---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastruct...@apache.org or file a JIRA ticket
with INFRA.
---


[GitHub] trafficserver issue #1559: Do not callback one SM EVENT_ERROR twice.

2017-03-08 Thread atsci
Github user atsci commented on the issue:

https://github.com/apache/trafficserver/pull/1559
  
FreeBSD11 build *successful*! 
https://ci.trafficserver.apache.org/job/freebsd-github/1715/
 



---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastruct...@apache.org or file a JIRA ticket
with INFRA.
---


[GitHub] trafficserver issue #1559: Do not callback one SM EVENT_ERROR twice.

2017-03-08 Thread atsci
Github user atsci commented on the issue:

https://github.com/apache/trafficserver/pull/1559
  
Linux build *successful*! 
https://ci.trafficserver.apache.org/job/linux-github/1609/
 



---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastruct...@apache.org or file a JIRA ticket
with INFRA.
---


[GitHub] trafficserver issue #1559: Do not callback one SM EVENT_ERROR twice.

2017-03-08 Thread atsci
Github user atsci commented on the issue:

https://github.com/apache/trafficserver/pull/1559
  
FreeBSD11 build *successful*! 
https://ci.trafficserver.apache.org/job/freebsd-github/1714/
 



---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastruct...@apache.org or file a JIRA ticket
with INFRA.
---


[GitHub] trafficserver issue #1559: Do not callback one SM EVENT_ERROR twice.

2017-03-08 Thread atsci
Github user atsci commented on the issue:

https://github.com/apache/trafficserver/pull/1559
  
Intel CC build *successful*! 
https://ci.trafficserver.apache.org/job/icc-github/144/
 



---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastruct...@apache.org or file a JIRA ticket
with INFRA.
---


[GitHub] trafficserver issue #1559: Do not callback one SM EVENT_ERROR twice.

2017-03-08 Thread atsci
Github user atsci commented on the issue:

https://github.com/apache/trafficserver/pull/1559
  
clang format *successful*! 
https://ci.trafficserver.apache.org/job/clang-format-github/20/
 



---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastruct...@apache.org or file a JIRA ticket
with INFRA.
---


[GitHub] trafficserver issue #1559: Do not callback one SM EVENT_ERROR twice.

2017-03-08 Thread atsci
Github user atsci commented on the issue:

https://github.com/apache/trafficserver/pull/1559
  
RAT check *successful*! 
https://ci.trafficserver.apache.org/job/RAT-github/33/
 



---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastruct...@apache.org or file a JIRA ticket
with INFRA.
---


[GitHub] trafficserver issue #1559: Do not callback one SM EVENT_ERROR twice.

2017-03-08 Thread atsci
Github user atsci commented on the issue:

https://github.com/apache/trafficserver/pull/1559
  
AU check *failed*! https://ci.trafficserver.apache.org/job/autest-github/18/
 



---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastruct...@apache.org or file a JIRA ticket
with INFRA.
---


[GitHub] trafficserver issue #1559: Do not callback one SM EVENT_ERROR twice.

2017-03-08 Thread atsci
Github user atsci commented on the issue:

https://github.com/apache/trafficserver/pull/1559
  
clang format *successful*! 
https://ci.trafficserver.apache.org/job/clang-format-github/19/
 



---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastruct...@apache.org or file a JIRA ticket
with INFRA.
---


[GitHub] trafficserver issue #1559: Do not callback one SM EVENT_ERROR twice.

2017-03-08 Thread atsci
Github user atsci commented on the issue:

https://github.com/apache/trafficserver/pull/1559
  
RAT check *successful*! 
https://ci.trafficserver.apache.org/job/RAT-github/32/
 



---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastruct...@apache.org or file a JIRA ticket
with INFRA.
---


[GitHub] trafficserver issue #1559: Do not callback one SM EVENT_ERROR twice.

2017-03-08 Thread atsci
Github user atsci commented on the issue:

https://github.com/apache/trafficserver/pull/1559
  
FreeBSD11 build *failed*! 
https://ci.trafficserver.apache.org/job/freebsd-github/1713/
 



---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastruct...@apache.org or file a JIRA ticket
with INFRA.
---


[GitHub] trafficserver issue #1559: Do not callback one SM EVENT_ERROR twice.

2017-03-08 Thread atsci
Github user atsci commented on the issue:

https://github.com/apache/trafficserver/pull/1559
  
clang format *successful*! 
https://ci.trafficserver.apache.org/job/clang-format-github/18/
 



---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastruct...@apache.org or file a JIRA ticket
with INFRA.
---


[GitHub] trafficserver issue #1559: Do not callback one SM EVENT_ERROR twice.

2017-03-08 Thread atsci
Github user atsci commented on the issue:

https://github.com/apache/trafficserver/pull/1559
  
RAT check *successful*! 
https://ci.trafficserver.apache.org/job/RAT-github/31/
 



---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastruct...@apache.org or file a JIRA ticket
with INFRA.
---


[GitHub] trafficserver issue #1559: Do not callback one SM EVENT_ERROR twice.

2017-03-08 Thread atsci
Github user atsci commented on the issue:

https://github.com/apache/trafficserver/pull/1559
  
Linux build *failed*! 
https://ci.trafficserver.apache.org/job/linux-github/1608/
 



---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastruct...@apache.org or file a JIRA ticket
with INFRA.
---


[GitHub] trafficserver issue #1559: Do not callback one SM EVENT_ERROR twice.

2017-03-08 Thread atsci
Github user atsci commented on the issue:

https://github.com/apache/trafficserver/pull/1559
  
AU check *failed*! https://ci.trafficserver.apache.org/job/autest-github/17/
 



---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastruct...@apache.org or file a JIRA ticket
with INFRA.
---


[GitHub] trafficserver issue #1559: Do not callback one SM EVENT_ERROR twice.

2017-03-08 Thread atsci
Github user atsci commented on the issue:

https://github.com/apache/trafficserver/pull/1559
  
clang-analyzer build *successful*! 
https://ci.trafficserver.apache.org/job/clang-analyzer-github/275/
 



---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastruct...@apache.org or file a JIRA ticket
with INFRA.
---


[GitHub] trafficserver issue #1559: Do not callback one SM EVENT_ERROR twice.

2017-03-08 Thread atsci
Github user atsci commented on the issue:

https://github.com/apache/trafficserver/pull/1559
  
FreeBSD11 build *failed*! 
https://ci.trafficserver.apache.org/job/freebsd-github/1712/
 



---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastruct...@apache.org or file a JIRA ticket
with INFRA.
---


[GitHub] trafficserver issue #1559: Do not callback one SM EVENT_ERROR twice.

2017-03-08 Thread atsci
Github user atsci commented on the issue:

https://github.com/apache/trafficserver/pull/1559
  
clang format *successful*! 
https://ci.trafficserver.apache.org/job/clang-format-github/17/
 



---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastruct...@apache.org or file a JIRA ticket
with INFRA.
---


[GitHub] trafficserver issue #1559: Do not callback one SM EVENT_ERROR twice.

2017-03-08 Thread atsci
Github user atsci commented on the issue:

https://github.com/apache/trafficserver/pull/1559
  
RAT check *successful*! 
https://ci.trafficserver.apache.org/job/RAT-github/30/
 



---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastruct...@apache.org or file a JIRA ticket
with INFRA.
---


[GitHub] trafficserver issue #1559: Do not callback one SM EVENT_ERROR twice.

2017-03-08 Thread atsci
Github user atsci commented on the issue:

https://github.com/apache/trafficserver/pull/1559
  
Linux build *failed*! 
https://ci.trafficserver.apache.org/job/linux-github/1607/
 



---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastruct...@apache.org or file a JIRA ticket
with INFRA.
---


[GitHub] trafficserver issue #1559: Do not callback one SM EVENT_ERROR twice.

2017-03-08 Thread atsci
Github user atsci commented on the issue:

https://github.com/apache/trafficserver/pull/1559
  
AU check *failed*! https://ci.trafficserver.apache.org/job/autest-github/16/
 



---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastruct...@apache.org or file a JIRA ticket
with INFRA.
---


[GitHub] trafficserver issue #1559: Do not callback one SM EVENT_ERROR twice.

2017-03-08 Thread atsci
Github user atsci commented on the issue:

https://github.com/apache/trafficserver/pull/1559
  
Intel CC build *failed*! 
https://ci.trafficserver.apache.org/job/icc-github/143/
 



---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastruct...@apache.org or file a JIRA ticket
with INFRA.
---


[GitHub] trafficserver issue #1534: Use StringView for protocol stack to avoid callin...

2017-03-08 Thread maskit
Github user maskit commented on the issue:

https://github.com/apache/trafficserver/pull/1534
  
I can see "h2" if I build it on Linux with gcc but not on Mac with clang.


---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastruct...@apache.org or file a JIRA ticket
with INFRA.
---


[GitHub] trafficserver issue #1557: brotli support in gzip plugin

2017-03-08 Thread zwoop
Github user zwoop commented on the issue:

https://github.com/apache/trafficserver/pull/1557
  
I need to read this some more, but it feels like we need a configuration 
option here as well.


---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastruct...@apache.org or file a JIRA ticket
with INFRA.
---


[GitHub] trafficserver issue #1558: redundant url encoding for logging field "cquuc"

2017-03-08 Thread esmq2092
GitHub user esmq2092 opened an issue:

https://github.com/apache/trafficserver/issues/1558

redundant url encoding for logging field "cquuc"

when client request with query string like %30,
use "cqu" logging filed, it will be recorded it as %30,
but when log with "cquuc", it  will be recorded as %2530,

redundant encoding happened...








---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastruct...@apache.org or file a JIRA ticket
with INFRA.
---


[GitHub] trafficserver pull request #1534: Use StringView for protocol stack to avoid...

2017-03-08 Thread SolidWallOfCode
Github user SolidWallOfCode commented on a diff in the pull request:

https://github.com/apache/trafficserver/pull/1534#discussion_r105075862
  
--- Diff: iocore/net/P_UnixNetVConnection.h ---
@@ -149,21 +149,21 @@ class UnixNetVConnection : public NetVConnection
   // called when handing an  event from this NetVConnection,//
   // or the NetVConnection creation callback.   //
   
-  virtual void set_active_timeout(ink_hrtime timeout_in);
-  virtual void set_inactivity_timeout(ink_hrtime timeout_in);
-  virtual void cancel_active_timeout();
-  virtual void cancel_inactivity_timeout();
-  virtual void set_action(Continuation *c);
-  virtual void add_to_keep_alive_queue();
-  virtual void remove_from_keep_alive_queue();
-  virtual bool add_to_active_queue();
+  void set_active_timeout(ink_hrtime timeout_in) override;
+  void set_inactivity_timeout(ink_hrtime timeout_in) override;
+  void cancel_active_timeout() override;
+  void cancel_inactivity_timeout() override;
+  void set_action(Continuation *c) override;
+  void add_to_keep_alive_queue() override;
+  void remove_from_keep_alive_queue() override;
+  bool add_to_active_queue() override;
   virtual void remove_from_active_queue();
--- End diff --

@bryancall Note `remove_from_active_queue` does not override anything, in 
contrast to the rest of this group of methods.


---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastruct...@apache.org or file a JIRA ticket
with INFRA.
---


[GitHub] trafficserver pull request #1534: Use StringView for protocol stack to avoid...

2017-03-08 Thread SolidWallOfCode
Github user SolidWallOfCode commented on a diff in the pull request:

https://github.com/apache/trafficserver/pull/1534#discussion_r105075732
  
--- Diff: proxy/http/HttpSM.cc ---
@@ -8057,14 +8059,13 @@ HttpSM::is_redirect_required()
 
 // Fill in the client protocols used.  Return the number of entries 
returned
 int
-HttpSM::populate_client_protocol(const char **result, int n) const
+HttpSM::populate_client_protocol(ts::StringView *result, int n) const
--- End diff --

This should be fixed.


---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastruct...@apache.org or file a JIRA ticket
with INFRA.
---


[GitHub] trafficserver issue #1534: Use StringView for protocol stack to avoid callin...

2017-03-08 Thread atsci
Github user atsci commented on the issue:

https://github.com/apache/trafficserver/pull/1534
  
clang-analyzer build *successful*! 
https://ci.trafficserver.apache.org/job/clang-analyzer-github/274/
 



---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastruct...@apache.org or file a JIRA ticket
with INFRA.
---


[GitHub] trafficserver issue #1534: Use StringView for protocol stack to avoid callin...

2017-03-08 Thread SolidWallOfCode
Github user SolidWallOfCode commented on the issue:

https://github.com/apache/trafficserver/pull/1534
  
@maskit I'll look at that, but zwoop's test output has the 'h2' in it.


---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastruct...@apache.org or file a JIRA ticket
with INFRA.
---


[GitHub] trafficserver issue #1534: Use StringView for protocol stack to avoid callin...

2017-03-08 Thread atsci
Github user atsci commented on the issue:

https://github.com/apache/trafficserver/pull/1534
  
FreeBSD11 build *successful*! 
https://ci.trafficserver.apache.org/job/freebsd-github/1711/
 



---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastruct...@apache.org or file a JIRA ticket
with INFRA.
---


[GitHub] trafficserver issue #1534: Use StringView for protocol stack to avoid callin...

2017-03-08 Thread atsci
Github user atsci commented on the issue:

https://github.com/apache/trafficserver/pull/1534
  
Linux build *successful*! 
https://ci.trafficserver.apache.org/job/linux-github/1606/
 



---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastruct...@apache.org or file a JIRA ticket
with INFRA.
---


[GitHub] trafficserver issue #1534: Use StringView for protocol stack to avoid callin...

2017-03-08 Thread atsci
Github user atsci commented on the issue:

https://github.com/apache/trafficserver/pull/1534
  
Intel CC build *successful*! 
https://ci.trafficserver.apache.org/job/icc-github/142/
 



---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastruct...@apache.org or file a JIRA ticket
with INFRA.
---


[GitHub] trafficserver issue #1534: Use StringView for protocol stack to avoid callin...

2017-03-08 Thread atsci
Github user atsci commented on the issue:

https://github.com/apache/trafficserver/pull/1534
  
AU check *failed*! https://ci.trafficserver.apache.org/job/autest-github/15/
 



---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastruct...@apache.org or file a JIRA ticket
with INFRA.
---


[GitHub] trafficserver issue #1557: brotli support in gzip plugin

2017-03-08 Thread shukitchan
Github user shukitchan commented on the issue:

https://github.com/apache/trafficserver/pull/1557
  
I will take a closer look in the coming days.
In the meanwhile, can you update the documentation for the gzip plugin as 
well for this change?


---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastruct...@apache.org or file a JIRA ticket
with INFRA.
---


[GitHub] trafficserver issue #1534: Use StringView for protocol stack to avoid callin...

2017-03-08 Thread atsci
Github user atsci commented on the issue:

https://github.com/apache/trafficserver/pull/1534
  
RAT check *successful*! 
https://ci.trafficserver.apache.org/job/RAT-github/29/
 



---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastruct...@apache.org or file a JIRA ticket
with INFRA.
---


[GitHub] trafficserver issue #1534: Use StringView for protocol stack to avoid callin...

2017-03-08 Thread atsci
Github user atsci commented on the issue:

https://github.com/apache/trafficserver/pull/1534
  
clang format *successful*! 
https://ci.trafficserver.apache.org/job/clang-format-github/16/
 



---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastruct...@apache.org or file a JIRA ticket
with INFRA.
---


Jenkins build is back to normal : clang-format-master #1376

2017-03-08 Thread jenkins
See 




[GitHub] trafficserver issue #1516: Implement Cache-Control: immutable handling

2017-03-08 Thread shukitchan
Github user shukitchan commented on the issue:

https://github.com/apache/trafficserver/pull/1516
  
I think we should keep the existing behavior since this is not an 
experimental plugin and we are not in the middle of releasing a major version. 


---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastruct...@apache.org or file a JIRA ticket
with INFRA.
---


Build failed in Jenkins: clang-format-master #1375

2017-03-08 Thread jenkins
See 


--
Started by user Leif Hedstrom
Running as Leif Hedstrom
Building remotely on ICC-Github1 (github_icc) in workspace 

 > /usr/bin/git rev-parse --is-inside-work-tree # timeout=10
Fetching changes from the remote Git repository
 > /usr/bin/git config remote.origin.url 
 > http://192.168.3.1/mirror/trafficserver.git # timeout=10
Cleaning workspace
 > /usr/bin/git rev-parse --verify HEAD # timeout=10
Resetting working tree
 > /usr/bin/git reset --hard # timeout=10
ERROR: Error fetching remote repo 'origin'
hudson.plugins.git.GitException: Failed to fetch from 
http://192.168.3.1/mirror/trafficserver.git
at hudson.plugins.git.GitSCM.fetchFrom(GitSCM.java:803)
at hudson.plugins.git.GitSCM.retrieveChanges(GitSCM.java:1063)
at hudson.plugins.git.GitSCM.checkout(GitSCM.java:1094)
at hudson.scm.SCM.checkout(SCM.java:496)
at hudson.model.AbstractProject.checkout(AbstractProject.java:1278)
at 
hudson.model.AbstractBuild$AbstractBuildExecution.defaultCheckout(AbstractBuild.java:604)
at jenkins.scm.SCMCheckoutStrategy.checkout(SCMCheckoutStrategy.java:86)
at 
hudson.model.AbstractBuild$AbstractBuildExecution.run(AbstractBuild.java:529)
at hudson.model.Run.execute(Run.java:1728)
at hudson.model.FreeStyleBuild.run(FreeStyleBuild.java:43)
at hudson.model.ResourceController.execute(ResourceController.java:98)
at hudson.model.Executor.run(Executor.java:405)
Caused by: hudson.plugins.git.GitException: Command "/usr/bin/git reset --hard" 
returned status code 128:
stdout: 
stderr: fatal: unable to read tree 1cda89c2d1b56c6c8dec1c7d1ed522d72e736ac9

at 
org.jenkinsci.plugins.gitclient.CliGitAPIImpl.launchCommandIn(CliGitAPIImpl.java:1793)
at 
org.jenkinsci.plugins.gitclient.CliGitAPIImpl.launchCommandIn(CliGitAPIImpl.java:1766)
at 
org.jenkinsci.plugins.gitclient.CliGitAPIImpl.launchCommandIn(CliGitAPIImpl.java:1762)
at 
org.jenkinsci.plugins.gitclient.CliGitAPIImpl.launchCommand(CliGitAPIImpl.java:1409)
at 
org.jenkinsci.plugins.gitclient.CliGitAPIImpl.reset(CliGitAPIImpl.java:373)
at 
org.jenkinsci.plugins.gitclient.CliGitAPIImpl.clean(CliGitAPIImpl.java:677)
at hudson.plugins.git.GitAPI.clean(GitAPI.java:311)
at sun.reflect.NativeMethodAccessorImpl.invoke0(Native Method)
at 
sun.reflect.NativeMethodAccessorImpl.invoke(NativeMethodAccessorImpl.java:62)
at 
sun.reflect.DelegatingMethodAccessorImpl.invoke(DelegatingMethodAccessorImpl.java:43)
at java.lang.reflect.Method.invoke(Method.java:498)
at 
hudson.remoting.RemoteInvocationHandler$RPCRequest.perform(RemoteInvocationHandler.java:895)
at 
hudson.remoting.RemoteInvocationHandler$RPCRequest.call(RemoteInvocationHandler.java:870)
at 
hudson.remoting.RemoteInvocationHandler$RPCRequest.call(RemoteInvocationHandler.java:829)
at hudson.remoting.UserRequest.perform(UserRequest.java:153)
at hudson.remoting.UserRequest.perform(UserRequest.java:50)
at hudson.remoting.Request$2.run(Request.java:336)
at 
hudson.remoting.InterceptingExecutorService$1.call(InterceptingExecutorService.java:68)
at java.util.concurrent.FutureTask.run(FutureTask.java:266)
at 
java.util.concurrent.ThreadPoolExecutor.runWorker(ThreadPoolExecutor.java:1142)
at 
java.util.concurrent.ThreadPoolExecutor$Worker.run(ThreadPoolExecutor.java:617)
at java.lang.Thread.run(Thread.java:745)
at ..remote call to ICC-Github1(Native Method)
at hudson.remoting.Channel.attachCallSiteStackTrace(Channel.java:1545)
at hudson.remoting.UserResponse.retrieve(UserRequest.java:253)
at hudson.remoting.Channel.call(Channel.java:830)
at 
hudson.remoting.RemoteInvocationHandler.invoke(RemoteInvocationHandler.java:257)
at com.sun.proxy.$Proxy71.clean(Unknown Source)
at 
org.jenkinsci.plugins.gitclient.RemoteGitImpl.clean(RemoteGitImpl.java:450)
at 
hudson.plugins.git.extensions.impl.CleanBeforeCheckout.decorateFetchCommand(CleanBeforeCheckout.java:32)
at hudson.plugins.git.GitSCM.fetchFrom(GitSCM.java:799)
... 11 more
ERROR: null



Build failed in Jenkins: clang-format-master #1374

2017-03-08 Thread jenkins
See 


--
Started by upstream project "in_tree-master" build number 2504
originally caused by:
 Started by remote host 2001:4800:7821:102:be76:4eff:fe05:ad8b
Started by upstream project "out_of_tree-master" build number 2274
originally caused by:
 Started by remote host 2001:4800:7821:102:be76:4eff:fe05:ad8b
Building remotely on ICC-Github1 (github_icc) in workspace 

 > /usr/bin/git rev-parse --is-inside-work-tree # timeout=10
Fetching changes from the remote Git repository
 > /usr/bin/git config remote.origin.url 
 > http://192.168.3.1/mirror/trafficserver.git # timeout=10
Cleaning workspace
 > /usr/bin/git rev-parse --verify HEAD # timeout=10
Resetting working tree
 > /usr/bin/git reset --hard # timeout=10
ERROR: Error fetching remote repo 'origin'
hudson.plugins.git.GitException: Failed to fetch from 
http://192.168.3.1/mirror/trafficserver.git
at hudson.plugins.git.GitSCM.fetchFrom(GitSCM.java:803)
at hudson.plugins.git.GitSCM.retrieveChanges(GitSCM.java:1063)
at hudson.plugins.git.GitSCM.checkout(GitSCM.java:1094)
at hudson.scm.SCM.checkout(SCM.java:496)
at hudson.model.AbstractProject.checkout(AbstractProject.java:1278)
at 
hudson.model.AbstractBuild$AbstractBuildExecution.defaultCheckout(AbstractBuild.java:604)
at jenkins.scm.SCMCheckoutStrategy.checkout(SCMCheckoutStrategy.java:86)
at 
hudson.model.AbstractBuild$AbstractBuildExecution.run(AbstractBuild.java:529)
at hudson.model.Run.execute(Run.java:1728)
at hudson.model.FreeStyleBuild.run(FreeStyleBuild.java:43)
at hudson.model.ResourceController.execute(ResourceController.java:98)
at hudson.model.Executor.run(Executor.java:405)
Caused by: hudson.plugins.git.GitException: Command "/usr/bin/git reset --hard" 
returned status code 128:
stdout: 
stderr: fatal: unable to read tree 1cda89c2d1b56c6c8dec1c7d1ed522d72e736ac9

at 
org.jenkinsci.plugins.gitclient.CliGitAPIImpl.launchCommandIn(CliGitAPIImpl.java:1793)
at 
org.jenkinsci.plugins.gitclient.CliGitAPIImpl.launchCommandIn(CliGitAPIImpl.java:1766)
at 
org.jenkinsci.plugins.gitclient.CliGitAPIImpl.launchCommandIn(CliGitAPIImpl.java:1762)
at 
org.jenkinsci.plugins.gitclient.CliGitAPIImpl.launchCommand(CliGitAPIImpl.java:1409)
at 
org.jenkinsci.plugins.gitclient.CliGitAPIImpl.reset(CliGitAPIImpl.java:373)
at 
org.jenkinsci.plugins.gitclient.CliGitAPIImpl.clean(CliGitAPIImpl.java:677)
at hudson.plugins.git.GitAPI.clean(GitAPI.java:311)
at sun.reflect.NativeMethodAccessorImpl.invoke0(Native Method)
at 
sun.reflect.NativeMethodAccessorImpl.invoke(NativeMethodAccessorImpl.java:62)
at 
sun.reflect.DelegatingMethodAccessorImpl.invoke(DelegatingMethodAccessorImpl.java:43)
at java.lang.reflect.Method.invoke(Method.java:498)
at 
hudson.remoting.RemoteInvocationHandler$RPCRequest.perform(RemoteInvocationHandler.java:895)
at 
hudson.remoting.RemoteInvocationHandler$RPCRequest.call(RemoteInvocationHandler.java:870)
at 
hudson.remoting.RemoteInvocationHandler$RPCRequest.call(RemoteInvocationHandler.java:829)
at hudson.remoting.UserRequest.perform(UserRequest.java:153)
at hudson.remoting.UserRequest.perform(UserRequest.java:50)
at hudson.remoting.Request$2.run(Request.java:336)
at 
hudson.remoting.InterceptingExecutorService$1.call(InterceptingExecutorService.java:68)
at java.util.concurrent.FutureTask.run(FutureTask.java:266)
at 
java.util.concurrent.ThreadPoolExecutor.runWorker(ThreadPoolExecutor.java:1142)
at 
java.util.concurrent.ThreadPoolExecutor$Worker.run(ThreadPoolExecutor.java:617)
at java.lang.Thread.run(Thread.java:745)
at ..remote call to ICC-Github1(Native Method)
at hudson.remoting.Channel.attachCallSiteStackTrace(Channel.java:1545)
at hudson.remoting.UserResponse.retrieve(UserRequest.java:253)
at hudson.remoting.Channel.call(Channel.java:830)
at 
hudson.remoting.RemoteInvocationHandler.invoke(RemoteInvocationHandler.java:257)
at com.sun.proxy.$Proxy71.clean(Unknown Source)
at 
org.jenkinsci.plugins.gitclient.RemoteGitImpl.clean(RemoteGitImpl.java:450)
at 
hudson.plugins.git.extensions.impl.CleanBeforeCheckout.decorateFetchCommand(CleanBeforeCheckout.java:32)
at hudson.plugins.git.GitSCM.fetchFrom(GitSCM.java:799)
... 11 more
ERROR: null



[GitHub] trafficserver pull request #1551: rectify a minor error in test_server_inter...

2017-03-08 Thread shukitchan
Github user shukitchan closed the pull request at:

https://github.com/apache/trafficserver/pull/1551


---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastruct...@apache.org or file a JIRA ticket
with INFRA.
---


[GitHub] trafficserver issue #1551: rectify a minor error in test_server_intercept.lu...

2017-03-08 Thread shukitchan
Github user shukitchan commented on the issue:

https://github.com/apache/trafficserver/pull/1551
  
thanks for spotting the mistake.

👍 


---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastruct...@apache.org or file a JIRA ticket
with INFRA.
---


[GitHub] trafficserver issue #1557: brotli support in gzip plugin

2017-03-08 Thread maskit
Github user maskit commented on the issue:

https://github.com/apache/trafficserver/pull/1557
  
Having one plugin for multiple compression algorithms is fine with me. 
However, I'm not a big fun of adding it with "else if" statements, though we 
already did that for deflate. It looks like ifdef things and it's not so easy 
to read.

I think it should have an abstract parent class for all the algorithms and 
each algorithms should be implemented as subclasses.


---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastruct...@apache.org or file a JIRA ticket
with INFRA.
---


[GitHub] trafficserver issue #1554: TS-4976: Regularize example plugins - blacklist

2017-03-08 Thread atsci
Github user atsci commented on the issue:

https://github.com/apache/trafficserver/pull/1554
  
clang-analyzer build *successful*! 
https://ci.trafficserver.apache.org/job/clang-analyzer-github/273/
 



---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastruct...@apache.org or file a JIRA ticket
with INFRA.
---


[GitHub] trafficserver issue #1534: Use StringView for protocol stack to avoid callin...

2017-03-08 Thread maskit
Github user maskit commented on the issue:

https://github.com/apache/trafficserver/pull/1534
  
It looks Http2ClientSession::PROTO_TAG is empty to me. I see two spaces 
between "http/1.1" and "tls/1.2".


---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastruct...@apache.org or file a JIRA ticket
with INFRA.
---


[GitHub] trafficserver issue #1554: TS-4976: Regularize example plugins - blacklist

2017-03-08 Thread atsci
Github user atsci commented on the issue:

https://github.com/apache/trafficserver/pull/1554
  
Intel CC build *successful*! 
https://ci.trafficserver.apache.org/job/icc-github/141/
 



---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastruct...@apache.org or file a JIRA ticket
with INFRA.
---


[GitHub] trafficserver issue #1554: TS-4976: Regularize example plugins - blacklist

2017-03-08 Thread atsci
Github user atsci commented on the issue:

https://github.com/apache/trafficserver/pull/1554
  
Linux build *successful*! 
https://ci.trafficserver.apache.org/job/linux-github/1605/
 



---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastruct...@apache.org or file a JIRA ticket
with INFRA.
---


[GitHub] trafficserver issue #1554: TS-4976: Regularize example plugins - blacklist

2017-03-08 Thread atsci
Github user atsci commented on the issue:

https://github.com/apache/trafficserver/pull/1554
  
FreeBSD11 build *successful*! 
https://ci.trafficserver.apache.org/job/freebsd-github/1710/
 



---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastruct...@apache.org or file a JIRA ticket
with INFRA.
---


[GitHub] trafficserver issue #1554: TS-4976: Regularize example plugins - blacklist

2017-03-08 Thread atsci
Github user atsci commented on the issue:

https://github.com/apache/trafficserver/pull/1554
  
AU check *failed*! https://ci.trafficserver.apache.org/job/autest-github/14/
 



---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastruct...@apache.org or file a JIRA ticket
with INFRA.
---


[GitHub] trafficserver issue #1554: TS-4976: Regularize example plugins - blacklist

2017-03-08 Thread atsci
Github user atsci commented on the issue:

https://github.com/apache/trafficserver/pull/1554
  
RAT check *successful*! 
https://ci.trafficserver.apache.org/job/RAT-github/28/
 



---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastruct...@apache.org or file a JIRA ticket
with INFRA.
---


[GitHub] trafficserver issue #1554: TS-4976: Regularize example plugins - blacklist

2017-03-08 Thread atsci
Github user atsci commented on the issue:

https://github.com/apache/trafficserver/pull/1554
  
clang format *successful*! 
https://ci.trafficserver.apache.org/job/clang-format-github/15/
 



---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastruct...@apache.org or file a JIRA ticket
with INFRA.
---


[GitHub] trafficserver issue #1554: TS-4976: Regularize example plugins - blacklist

2017-03-08 Thread atsci
Github user atsci commented on the issue:

https://github.com/apache/trafficserver/pull/1554
  
clang-analyzer build *successful*! 
https://ci.trafficserver.apache.org/job/clang-analyzer-github/272/
 



---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastruct...@apache.org or file a JIRA ticket
with INFRA.
---


[GitHub] trafficserver issue #1554: TS-4976: Regularize example plugins - blacklist

2017-03-08 Thread atsci
Github user atsci commented on the issue:

https://github.com/apache/trafficserver/pull/1554
  
Linux build *successful*! 
https://ci.trafficserver.apache.org/job/linux-github/1604/
 



---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastruct...@apache.org or file a JIRA ticket
with INFRA.
---


[GitHub] trafficserver issue #1554: TS-4976: Regularize example plugins - blacklist

2017-03-08 Thread atsci
Github user atsci commented on the issue:

https://github.com/apache/trafficserver/pull/1554
  
Intel CC build *successful*! 
https://ci.trafficserver.apache.org/job/icc-github/140/
 



---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastruct...@apache.org or file a JIRA ticket
with INFRA.
---


[GitHub] trafficserver issue #1554: TS-4976: Regularize example plugins - blacklist

2017-03-08 Thread atsci
Github user atsci commented on the issue:

https://github.com/apache/trafficserver/pull/1554
  
AU check *failed*! https://ci.trafficserver.apache.org/job/autest-github/13/
 



---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastruct...@apache.org or file a JIRA ticket
with INFRA.
---


[GitHub] trafficserver issue #1554: TS-4976: Regularize example plugins - blacklist

2017-03-08 Thread atsci
Github user atsci commented on the issue:

https://github.com/apache/trafficserver/pull/1554
  
FreeBSD11 build *successful*! 
https://ci.trafficserver.apache.org/job/freebsd-github/1709/
 



---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastruct...@apache.org or file a JIRA ticket
with INFRA.
---


[GitHub] trafficserver issue #1532: ATS 7.1 release running out of memory

2017-03-08 Thread bryancall
Github user bryancall commented on the issue:

https://github.com/apache/trafficserver/issues/1532
  
There is an issue with the number of real TCP connections, the stats that 
keeps track of the number of current client connections, and the number of 
http2 client sessions.  All of them disagree:

```
[bcall@e24 ~]$ ss -tn | awk '{print $4}' | grep -c :80 ; ss -tn | awk 
'{print $4}' | grep -c :443; traffic_ctl metric get 
proxy.process.net.accepts_currently_open; traffic_ctl metric match 
current_client_sessions
253
1364
proxy.process.net.accepts_currently_open 9
proxy.process.http2.current_client_sessions 41804
```


---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastruct...@apache.org or file a JIRA ticket
with INFRA.
---


[GitHub] trafficserver issue #1554: TS-4976: Regularize example plugins - blacklist

2017-03-08 Thread atsci
Github user atsci commented on the issue:

https://github.com/apache/trafficserver/pull/1554
  
RAT check *successful*! 
https://ci.trafficserver.apache.org/job/RAT-github/27/
 



---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastruct...@apache.org or file a JIRA ticket
with INFRA.
---


[GitHub] trafficserver issue #1554: TS-4976: Regularize example plugins - blacklist

2017-03-08 Thread atsci
Github user atsci commented on the issue:

https://github.com/apache/trafficserver/pull/1554
  
clang format *successful*! 
https://ci.trafficserver.apache.org/job/clang-format-github/14/
 



---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastruct...@apache.org or file a JIRA ticket
with INFRA.
---


[GitHub] trafficserver issue #1554: TS-4976: Regularize example plugins - blacklist

2017-03-08 Thread zwoop
Github user zwoop commented on the issue:

https://github.com/apache/trafficserver/pull/1554
  
[approve ci]


---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastruct...@apache.org or file a JIRA ticket
with INFRA.
---


[GitHub] trafficserver issue #1456: Add TCP accept metric which tracks the total numb...

2017-03-08 Thread bryancall
Github user bryancall commented on the issue:

https://github.com/apache/trafficserver/pull/1456
  
We should have a metric that tracks the total number of accepts at the TCP 
layer.  I recommend that the name be inline with the current metrics 
`proxy.process.net.total_accepts`


---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastruct...@apache.org or file a JIRA ticket
with INFRA.
---


[GitHub] trafficserver issue #1555: Support for brotli in gzip plugin.

2017-03-08 Thread myraid
Github user myraid commented on the issue:

https://github.com/apache/trafficserver/issues/1555
  
@bryancall realized it after creating the issue. 


---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastruct...@apache.org or file a JIRA ticket
with INFRA.
---


[GitHub] trafficserver issue #1557: brotli support in gzip plugin

2017-03-08 Thread bryancall
Github user bryancall commented on the issue:

https://github.com/apache/trafficserver/pull/1557
  
Added the requirements here:
```
Here are the requirements for supporting brotli encoding.

If the Accept-Encoding has brotli, then the normalize AE should pick up 
brotli. (Should we send both "br" and "gzip" in AE?
If the response is already encoded then do nothing. Should we have a 
configuration to force brotli encode the response?
If the response is unencoded and if Accept-Encoding has brotli then encode 
using brotli.
```


---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastruct...@apache.org or file a JIRA ticket
with INFRA.
---


[GitHub] trafficserver issue #1555: Support for brotli in gzip plugin.

2017-03-08 Thread bryancall
Github user bryancall closed the issue at:

https://github.com/apache/trafficserver/issues/1555


---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastruct...@apache.org or file a JIRA ticket
with INFRA.
---


[GitHub] trafficserver issue #1555: Support for brotli in gzip plugin.

2017-03-08 Thread bryancall
Github user bryancall commented on the issue:

https://github.com/apache/trafficserver/issues/1555
  
@myraid Issues don't need to be created if there is a PR for it.

The PR for it is: #1557


---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastruct...@apache.org or file a JIRA ticket
with INFRA.
---


[GitHub] trafficserver pull request #1556: Force use of python3 for microserver

2017-03-08 Thread bryancall
Github user bryancall closed the pull request at:

https://github.com/apache/trafficserver/pull/1556


---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastruct...@apache.org or file a JIRA ticket
with INFRA.
---


[GitHub] trafficserver pull request #1541: retry safe requests

2017-03-08 Thread PSUdaemon
Github user PSUdaemon closed the pull request at:

https://github.com/apache/trafficserver/pull/1541


---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastruct...@apache.org or file a JIRA ticket
with INFRA.
---


[GitHub] trafficserver pull request #1267: TS-5021: Separate parent_is_proxy from oth...

2017-03-08 Thread jrushford
Github user jrushford closed the pull request at:

https://github.com/apache/trafficserver/pull/1267


---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastruct...@apache.org or file a JIRA ticket
with INFRA.
---


[GitHub] trafficserver issue #1557: brotli support in gzip plugin

2017-03-08 Thread myraid
Github user myraid commented on the issue:

https://github.com/apache/trafficserver/pull/1557
  
For brotli to work the "proxy.config.http.normalize_ae_gzip" configuration 
should be set to '0'
Should we control this flag manually or throught the gzip plugin?


---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastruct...@apache.org or file a JIRA ticket
with INFRA.
---


[GitHub] trafficserver pull request #1557: brotli support in gzip plugin

2017-03-08 Thread myraid
GitHub user myraid opened a pull request:

https://github.com/apache/trafficserver/pull/1557

brotli support in gzip plugin

The requirements are outlined in
https://github.com/apache/trafficserver/issues/1555

@bryancall @shukitchan can you review.

You can merge this pull request into a Git repository by running:

$ git pull https://github.com/myraid/trafficserver gzip_br

Alternatively you can review and apply these changes as the patch at:

https://github.com/apache/trafficserver/pull/1557.patch

To close this pull request, make a commit to your master/trunk branch
with (at least) the following in the commit message:

This closes #1557


commit 5db9b36dc5b5c4a10125a63d8739355aea8dac44
Author: myraid 
Date:   2017-03-07T23:52:20Z

brotli support




---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastruct...@apache.org or file a JIRA ticket
with INFRA.
---


[GitHub] trafficserver pull request #1556: Force use of python3 for microserver

2017-03-08 Thread dragon512
GitHub user dragon512 opened a pull request:

https://github.com/apache/trafficserver/pull/1556

Force use of python3 for microserver

should fix the issue with Jenkins build issue

You can merge this pull request into a Git repository by running:

$ git pull https://github.com/dragon512/trafficserver autest-patch

Alternatively you can review and apply these changes as the patch at:

https://github.com/apache/trafficserver/pull/1556.patch

To close this pull request, make a commit to your master/trunk branch
with (at least) the following in the commit message:

This closes #1556






---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastruct...@apache.org or file a JIRA ticket
with INFRA.
---


[GitHub] trafficserver issue #1555: Support for brotli in gzip plugin.

2017-03-08 Thread myraid
GitHub user myraid opened an issue:

https://github.com/apache/trafficserver/issues/1555

Support for brotli in gzip plugin.


Here are the requirements for supporting brotli encoding.

- If the Accept-Encoding has brotli, then the normalize AE should pick up 
brotli. (Should we send both "br" and "gzip" in AE?
- If the response is already encoded then do nothing. Should we have a 
configuration to force brotli encode the response?
- If the response is unencoded and if Accept-Encoding has brotli then 
encode using brotli.






---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastruct...@apache.org or file a JIRA ticket
with INFRA.
---


[GitHub] trafficserver issue #1267: TS-5021: Separate parent_is_proxy from other pare...

2017-03-08 Thread jrushford
Github user jrushford commented on the issue:

https://github.com/apache/trafficserver/pull/1267
  
7.2.0 is fine


Thanks
--
John J. Rushford
IPCDN Engineering
1400 Wewatta Street, Denver Colorado 80202
john_rushf...@cable.comcast.com











From: Leif Hedstrom 
Reply-To: apache/trafficserver 
Date: Wednesday, March 8, 2017 at 11:56 AM
To: apache/trafficserver 
Cc: John Rushford , Mention 

Subject: Re: [apache/trafficserver] TS-5021: Separate parent_is_proxy from 
other parent configuration options. (#1267)


@jrushford Question: do we want this into 
7.1.x ?

—
You are receiving this because you were mentioned.
Reply to this email directly, view it on 
GitHub,
 or mute the 
thread.



---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastruct...@apache.org or file a JIRA ticket
with INFRA.
---


[GitHub] trafficserver issue #1267: TS-5021: Separate parent_is_proxy from other pare...

2017-03-08 Thread zwoop
Github user zwoop commented on the issue:

https://github.com/apache/trafficserver/pull/1267
  
@jrushford Question: do we want this into 7.1.x ?


---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastruct...@apache.org or file a JIRA ticket
with INFRA.
---


[GitHub] trafficserver issue #1267: TS-5021: Separate parent_is_proxy from other pare...

2017-03-08 Thread jrushford
Github user jrushford commented on the issue:

https://github.com/apache/trafficserver/pull/1267
  
@zwoop - forgot about this one but,  i rebased this and it's ready to go if 
you're +1.  


---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastruct...@apache.org or file a JIRA ticket
with INFRA.
---


[GitHub] trafficserver issue #1554: TS-4976: Regularize example plugins - blacklist

2017-03-08 Thread atsci
Github user atsci commented on the issue:

https://github.com/apache/trafficserver/pull/1554
  
clang-analyzer build *successful*! 
https://ci.trafficserver.apache.org/job/clang-analyzer-github/271/
 



---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastruct...@apache.org or file a JIRA ticket
with INFRA.
---


[GitHub] trafficserver issue #1554: TS-4976: Regularize example plugins - blacklist

2017-03-08 Thread atsci
Github user atsci commented on the issue:

https://github.com/apache/trafficserver/pull/1554
  
Intel CC build *successful*! 
https://ci.trafficserver.apache.org/job/icc-github/139/
 



---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastruct...@apache.org or file a JIRA ticket
with INFRA.
---


[GitHub] trafficserver issue #1554: TS-4976: Regularize example plugins - blacklist

2017-03-08 Thread atsci
Github user atsci commented on the issue:

https://github.com/apache/trafficserver/pull/1554
  
Linux build *successful*! 
https://ci.trafficserver.apache.org/job/linux-github/1603/
 



---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastruct...@apache.org or file a JIRA ticket
with INFRA.
---


[GitHub] trafficserver issue #1554: TS-4976: Regularize example plugins - blacklist

2017-03-08 Thread atsci
Github user atsci commented on the issue:

https://github.com/apache/trafficserver/pull/1554
  
AU check *failed*! https://ci.trafficserver.apache.org/job/autest-github/12/
 



---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastruct...@apache.org or file a JIRA ticket
with INFRA.
---


[GitHub] trafficserver issue #1554: TS-4976: Regularize example plugins - blacklist

2017-03-08 Thread atsci
Github user atsci commented on the issue:

https://github.com/apache/trafficserver/pull/1554
  
FreeBSD11 build *successful*! 
https://ci.trafficserver.apache.org/job/freebsd-github/1708/
 



---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastruct...@apache.org or file a JIRA ticket
with INFRA.
---


[GitHub] trafficserver issue #1554: TS-4976: Regularize example plugins - blacklist

2017-03-08 Thread zwoop
Github user zwoop commented on the issue:

https://github.com/apache/trafficserver/pull/1554
  
[approve ci]


---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastruct...@apache.org or file a JIRA ticket
with INFRA.
---


[GitHub] trafficserver issue #1554: TS-4976: Regularize example plugins - blacklist

2017-03-08 Thread atsci
Github user atsci commented on the issue:

https://github.com/apache/trafficserver/pull/1554
  
clang format *successful*! 
https://ci.trafficserver.apache.org/job/clang-format-github/13/
 



---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastruct...@apache.org or file a JIRA ticket
with INFRA.
---


[GitHub] trafficserver issue #1554: TS-4976: Regularize example plugins - blacklist

2017-03-08 Thread atsci
Github user atsci commented on the issue:

https://github.com/apache/trafficserver/pull/1554
  
RAT check *successful*! 
https://ci.trafficserver.apache.org/job/RAT-github/26/
 



---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastruct...@apache.org or file a JIRA ticket
with INFRA.
---


[GitHub] trafficserver issue #1267: TS-5021: Separate parent_is_proxy from other pare...

2017-03-08 Thread atsci
Github user atsci commented on the issue:

https://github.com/apache/trafficserver/pull/1267
  
clang-analyzer build *successful*! 
https://ci.trafficserver.apache.org/job/clang-analyzer-github/270/
 



---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastruct...@apache.org or file a JIRA ticket
with INFRA.
---


[GitHub] trafficserver issue #1267: TS-5021: Separate parent_is_proxy from other pare...

2017-03-08 Thread atsci
Github user atsci commented on the issue:

https://github.com/apache/trafficserver/pull/1267
  
Intel CC build *successful*! 
https://ci.trafficserver.apache.org/job/icc-github/138/
 



---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastruct...@apache.org or file a JIRA ticket
with INFRA.
---


[GitHub] trafficserver issue #1267: TS-5021: Separate parent_is_proxy from other pare...

2017-03-08 Thread atsci
Github user atsci commented on the issue:

https://github.com/apache/trafficserver/pull/1267
  
Linux build *successful*! 
https://ci.trafficserver.apache.org/job/linux-github/1602/
 



---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastruct...@apache.org or file a JIRA ticket
with INFRA.
---


[GitHub] trafficserver issue #1267: TS-5021: Separate parent_is_proxy from other pare...

2017-03-08 Thread atsci
Github user atsci commented on the issue:

https://github.com/apache/trafficserver/pull/1267
  
FreeBSD11 build *successful*! 
https://ci.trafficserver.apache.org/job/freebsd-github/1707/
 



---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastruct...@apache.org or file a JIRA ticket
with INFRA.
---


[GitHub] trafficserver issue #1267: TS-5021: Separate parent_is_proxy from other pare...

2017-03-08 Thread atsci
Github user atsci commented on the issue:

https://github.com/apache/trafficserver/pull/1267
  
AU check *failed*! https://ci.trafficserver.apache.org/job/autest-github/11/
 



---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastruct...@apache.org or file a JIRA ticket
with INFRA.
---


[GitHub] trafficserver issue #1267: TS-5021: Separate parent_is_proxy from other pare...

2017-03-08 Thread atsci
Github user atsci commented on the issue:

https://github.com/apache/trafficserver/pull/1267
  
clang format *successful*! 
https://ci.trafficserver.apache.org/job/clang-format-github/12/
 



---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastruct...@apache.org or file a JIRA ticket
with INFRA.
---


[GitHub] trafficserver issue #1267: TS-5021: Separate parent_is_proxy from other pare...

2017-03-08 Thread atsci
Github user atsci commented on the issue:

https://github.com/apache/trafficserver/pull/1267
  
RAT check *successful*! 
https://ci.trafficserver.apache.org/job/RAT-github/25/
 



---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastruct...@apache.org or file a JIRA ticket
with INFRA.
---


[GitHub] trafficserver issue #1544: AddressSanitizer failed to deallocate

2017-03-08 Thread shinrich
Github user shinrich commented on the issue:

https://github.com/apache/trafficserver/issues/1544
  
Also reported via issue #1498.  I think there is a problem with freeing 
memory if the free list is deallocated (-f).  When I accidentally left the -f 
flag on after I reinstalled a non-ASAN build, my system crashed due to out of 
memory within minutes.  Without the -f flag, my production box has been running 
for days without appreciable memory growth.


---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastruct...@apache.org or file a JIRA ticket
with INFRA.
---


[GitHub] trafficserver issue #1554: TS-4976: Regularize example plugins - blacklist

2017-03-08 Thread atsci
Github user atsci commented on the issue:

https://github.com/apache/trafficserver/pull/1554
  
Intel CC build *successful*! 
https://ci.trafficserver.apache.org/job/icc-github/137/
 



---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastruct...@apache.org or file a JIRA ticket
with INFRA.
---


[GitHub] trafficserver issue #1554: TS-4976: Regularize example plugins - blacklist

2017-03-08 Thread atsci
Github user atsci commented on the issue:

https://github.com/apache/trafficserver/pull/1554
  
Linux build *successful*! 
https://ci.trafficserver.apache.org/job/linux-github/1601/
 



---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastruct...@apache.org or file a JIRA ticket
with INFRA.
---


[GitHub] trafficserver issue #1554: TS-4976: Regularize example plugins - blacklist

2017-03-08 Thread atsci
Github user atsci commented on the issue:

https://github.com/apache/trafficserver/pull/1554
  
AU check *failed*! https://ci.trafficserver.apache.org/job/autest-github/10/
 



---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastruct...@apache.org or file a JIRA ticket
with INFRA.
---


[GitHub] trafficserver issue #1554: TS-4976: Regularize example plugins - blacklist

2017-03-08 Thread atsci
Github user atsci commented on the issue:

https://github.com/apache/trafficserver/pull/1554
  
FreeBSD11 build *successful*! 
https://ci.trafficserver.apache.org/job/freebsd-github/1706/
 



---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastruct...@apache.org or file a JIRA ticket
with INFRA.
---


  1   2   >