[GitHub] trafficserver issue #1528: Unable to build 6.2.x with --enable-static-proxy ...

2017-03-02 Thread Tchinmai7
GitHub user Tchinmai7 opened an issue: https://github.com/apache/trafficserver/issues/1528 Unable to build 6.2.x with --enable-static-proxy flag I tried building 6.2.x with --enable-static-proxy flag and it fails during make. System details : Ubuntu 14.04.5

[GitHub] trafficserver issue #1500: Create a keep alive session timeout and/or max # ...

2017-03-02 Thread maskit
Github user maskit commented on the issue: https://github.com/apache/trafficserver/issues/1500 previous discussion: https://issues.apache.org/jira/browse/TS-4277 --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your

[GitHub] trafficserver issue #1478: sscl is occasionally zero (formerly TS-2998)

2017-03-02 Thread maskit
Github user maskit commented on the issue: https://github.com/apache/trafficserver/issues/1478 It seems use of transform plugins (e.g. gzip plugin) cause this issue. I'm not sure why range requests matter here.

[GitHub] trafficserver pull request #1520: Report protocol in request via header

2017-03-02 Thread shukitchan
Github user shukitchan commented on a diff in the pull request: https://github.com/apache/trafficserver/pull/1520#discussion_r104076857 --- Diff: proxy/http/HttpTransactHeaders.cc --- @@ -741,26 +741,14 @@ HttpTransactHeaders::insert_via_header_in_request(HttpTransact::State *s,

[GitHub] trafficserver issue #1526: When SSL connect fails, we return 502 success

2017-03-02 Thread maskit
Github user maskit commented on the issue: https://github.com/apache/trafficserver/pull/1526 The fix seems reasonable, but why 7.1.1? It should be 7.2.0? --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project

[GitHub] trafficserver pull request #1520: Report protocol in request via header

2017-03-02 Thread maskit
Github user maskit commented on a diff in the pull request: https://github.com/apache/trafficserver/pull/1520#discussion_r104074965 --- Diff: proxy/http/HttpTransactHeaders.cc --- @@ -741,26 +741,14 @@ HttpTransactHeaders::insert_via_header_in_request(HttpTransact::State *s,

[GitHub] trafficserver issue #1457: fix TS-4195: crash when stop trafficserver

2017-03-02 Thread jpeach
Github user jpeach commented on the issue: https://github.com/apache/trafficserver/pull/1457 With some additional effort, we can fix this reliably. The traditional way to do this is for the signal handler to write a byte to a pipe, which will wake up an event handler to do an ordered

[GitHub] trafficserver issue #1465: Add new testing system to the test subdirectory

2017-03-02 Thread bryancall
Github user bryancall commented on the issue: https://github.com/apache/trafficserver/pull/1465 Here is the full output from running the tests: https://da.gd/XOiCg --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your

[GitHub] trafficserver issue #1457: fix TS-4195: crash when stop trafficserver

2017-03-02 Thread zizhong
Github user zizhong commented on the issue: https://github.com/apache/trafficserver/pull/1457 @zwoop , @bryancall, Hey, what is the next step about this? We can't let ATS crashes this way. We also want our leak detection tools to work fine. Why is `exit` mandatory in our signal

[GitHub] trafficserver issue #1465: Add new testing system to the test subdirectory

2017-03-02 Thread bryancall
Github user bryancall commented on the issue: https://github.com/apache/trafficserver/pull/1465 I am seeing 4 failed tests. ``` [bcall@homer tests]$ ./autest.sh --ats-bin /usr/local/bin Running Test basic:. Passed Running Test basic-cop:. Passed Running Test

[GitHub] trafficserver pull request #1516: Implement Cache-Control: immutable handlin...

2017-03-02 Thread danobi
Github user danobi commented on a diff in the pull request: https://github.com/apache/trafficserver/pull/1516#discussion_r103987142 --- Diff: plugins/esi/combo_handler.cc --- @@ -136,6 +138,24 @@ struct InterceptData { ~InterceptData(); }; +/* + * This

[GitHub] trafficserver issue #1527: More and slower active connections in 7.1.x

2017-03-02 Thread zwoop
GitHub user zwoop opened an issue: https://github.com/apache/trafficserver/issues/1527 More and slower active connections in 7.1.x I think, but still working on confirming, that the commit in 425b696240ea213. The net effect is that 1. I'm seeing roughly twice as many

[GitHub] trafficserver pull request #1516: Implement Cache-Control: immutable handlin...

2017-03-02 Thread danobi
Github user danobi commented on a diff in the pull request: https://github.com/apache/trafficserver/pull/1516#discussion_r103965565 --- Diff: plugins/esi/combo_handler.cc --- @@ -136,6 +138,24 @@ struct InterceptData { ~InterceptData(); }; +/* + * This

[GitHub] trafficserver pull request #1516: Implement Cache-Control: immutable handlin...

2017-03-02 Thread danobi
Github user danobi commented on a diff in the pull request: https://github.com/apache/trafficserver/pull/1516#discussion_r103965747 --- Diff: plugins/esi/combo_handler.cc --- @@ -136,6 +138,24 @@ struct InterceptData { ~InterceptData(); }; +/* + * This

[GitHub] trafficserver pull request #1465: Add new testing system to the test subdire...

2017-03-02 Thread dragon512
Github user dragon512 commented on a diff in the pull request: https://github.com/apache/trafficserver/pull/1465#discussion_r103950549 --- Diff: tests/getting_started.md --- @@ -0,0 +1,197 @@ + +# Getting Started + +This directory contains different tests for Apache

[GitHub] trafficserver issue #1522: Ingore read and write errors if vio has been clea...

2017-03-02 Thread zwoop
Github user zwoop commented on the issue: https://github.com/apache/trafficserver/pull/1522 Still looking good on Docs, but would like to give it at least another 24 hours before we declare victory. --- If your project is set up for it, you can reply to this email and have your

[GitHub] trafficserver pull request #1520: Report protocol in request via header

2017-03-02 Thread zwoop
Github user zwoop commented on a diff in the pull request: https://github.com/apache/trafficserver/pull/1520#discussion_r103943927 --- Diff: proxy/http/HttpTransactHeaders.cc --- @@ -741,26 +741,14 @@ HttpTransactHeaders::insert_via_header_in_request(HttpTransact::State *s, HTTPHd

[GitHub] trafficserver pull request #1520: Report protocol in request via header

2017-03-02 Thread SolidWallOfCode
Github user SolidWallOfCode commented on a diff in the pull request: https://github.com/apache/trafficserver/pull/1520#discussion_r103937152 --- Diff: proxy/http/HttpTransactHeaders.cc --- @@ -741,26 +741,14 @@ HttpTransactHeaders::insert_via_header_in_request(HttpTransact::State