[GitHub] trafficserver issue #1534: Use StringView for protocol stack to avoid callin...

2017-03-05 Thread shukitchan
Github user shukitchan commented on the issue: https://github.com/apache/trafficserver/pull/1534 👍 Looks good. Just one question. Should the internal "protocol_contains" functions return "StringView" as well? Obviously we should not be changing the return type of

[GitHub] trafficserver issue #1522: Ignore read and write errors if vio has been clea...

2017-03-05 Thread scw00
Github user scw00 commented on the issue: https://github.com/apache/trafficserver/pull/1522 I think, it #never calls handler with read.enabled = 0(or write.enabled). It means the handler don not want this type of event .It may never handle this event and just assert! #1531 ---

[GitHub] trafficserver issue #1531: Assertion in state_read_server_response_header (v...

2017-03-05 Thread scw00
Github user scw00 commented on the issue: https://github.com/apache/trafficserver/issues/1531 I think, it never call handler with read.enabled = 0(or write.enabled). It means the handler don not want this type of event .It may never handle this event and just assert!

[GitHub] trafficserver pull request #1539: Signals fix

2017-03-05 Thread PSUdaemon
Github user PSUdaemon closed the pull request at: https://github.com/apache/trafficserver/pull/1539 --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project does not have this feature enabled and wishes so, or if the

[GitHub] trafficserver pull request #1509: TS-5106: Create ParentRoundRobin object as...

2017-03-05 Thread PSUdaemon
Github user PSUdaemon closed the pull request at: https://github.com/apache/trafficserver/pull/1509 --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project does not have this feature enabled and wishes so, or if the

[GitHub] trafficserver pull request #1276: TS-5105: Do vc->con.setRemote(target) befo...

2017-03-05 Thread PSUdaemon
Github user PSUdaemon closed the pull request at: https://github.com/apache/trafficserver/pull/1276 --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project does not have this feature enabled and wishes so, or if the

[GitHub] trafficserver issue #1509: TS-5106: Create ParentRoundRobin object as Parent...

2017-03-05 Thread atsci
Github user atsci commented on the issue: https://github.com/apache/trafficserver/pull/1509 clang-analyzer build *successful*! See https://ci.trafficserver.apache.org/job/clang-analyzer-github/237/ for details. --- If your project is set up for it, you can reply to this email

[GitHub] trafficserver issue #1536: Create RAT builds for all Github PRs

2017-03-05 Thread zwoop
Github user zwoop commented on the issue: https://github.com/apache/trafficserver/issues/1536 This is fixed. --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project does not have this feature enabled and wishes

[GitHub] trafficserver issue #1536: Create RAT builds for all Github PRs

2017-03-05 Thread zwoop
Github user zwoop closed the issue at: https://github.com/apache/trafficserver/issues/1536 --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project does not have this feature enabled and wishes so, or if the feature is

[GitHub] trafficserver issue #1276: TS-5105: Do vc->con.setRemote(target) before sock...

2017-03-05 Thread atsci
Github user atsci commented on the issue: https://github.com/apache/trafficserver/pull/1276 clang-analyzer build *successful*! See https://ci.trafficserver.apache.org/job/clang-analyzer-github/236/ for details. --- If your project is set up for it, you can reply to this email

[GitHub] trafficserver issue #1276: TS-5105: Do vc->con.setRemote(target) before sock...

2017-03-05 Thread atsci
Github user atsci commented on the issue: https://github.com/apache/trafficserver/pull/1276 FreeBSD build *successful*! See https://ci.trafficserver.apache.org/job/freebsd-github/1673/ for details. --- If your project is set up for it, you can reply to this email and have

[GitHub] trafficserver issue #1509: TS-5106: Create ParentRoundRobin object as Parent...

2017-03-05 Thread atsci
Github user atsci commented on the issue: https://github.com/apache/trafficserver/pull/1509 Intel CC build *successful*! See https://ci.trafficserver.apache.org/job/icc-github/105/ for details. --- If your project is set up for it, you can reply to this email and have your

[GitHub] trafficserver issue #1276: TS-5105: Do vc->con.setRemote(target) before sock...

2017-03-05 Thread atsci
Github user atsci commented on the issue: https://github.com/apache/trafficserver/pull/1276 Linux build *successful*! See https://ci.trafficserver.apache.org/job/linux-github/1569/ for details. --- If your project is set up for it, you can reply to this email and have your

[GitHub] trafficserver issue #1509: TS-5106: Create ParentRoundRobin object as Parent...

2017-03-05 Thread atsci
Github user atsci commented on the issue: https://github.com/apache/trafficserver/pull/1509 Linux build *successful*! See https://ci.trafficserver.apache.org/job/linux-github/1568/ for details. --- If your project is set up for it, you can reply to this email and have your

[GitHub] trafficserver issue #1509: TS-5106: Create ParentRoundRobin object as Parent...

2017-03-05 Thread atsci
Github user atsci commented on the issue: https://github.com/apache/trafficserver/pull/1509 FreeBSD build *successful*! See https://ci.trafficserver.apache.org/job/freebsd-github/1672/ for details. --- If your project is set up for it, you can reply to this email and have

[GitHub] trafficserver issue #1276: TS-5105: Do vc->con.setRemote(target) before sock...

2017-03-05 Thread atsci
Github user atsci commented on the issue: https://github.com/apache/trafficserver/pull/1276 Intel CC build *successful*! See https://ci.trafficserver.apache.org/job/icc-github/104/ for details. --- If your project is set up for it, you can reply to this email and have your

[GitHub] trafficserver issue #1476: Crash in get_client_addr()

2017-03-05 Thread shinrich
Github user shinrich commented on the issue: https://github.com/apache/trafficserver/issues/1476 I had two more asserts once I added back in the accept thread. Upon deeper inspection, the last alloc time and the UA_BEGIN time were off by half a ms, so I am attributing that to clock

[GitHub] trafficserver pull request #1539: Signals fix

2017-03-05 Thread PSUdaemon
Github user PSUdaemon commented on a diff in the pull request: https://github.com/apache/trafficserver/pull/1539#discussion_r104324677 --- Diff: iocore/eventsystem/I_EThread.h --- @@ -56,7 +56,7 @@ enum ThreadType { DEDICATED, }; -extern volatile bool

[GitHub] trafficserver pull request #1539: Signals fix

2017-03-05 Thread SolidWallOfCode
Github user SolidWallOfCode commented on a diff in the pull request: https://github.com/apache/trafficserver/pull/1539#discussion_r104324657 --- Diff: iocore/eventsystem/I_EThread.h --- @@ -56,7 +56,7 @@ enum ThreadType { DEDICATED, }; -extern volatile bool

[GitHub] trafficserver issue #1539: Signals fix

2017-03-05 Thread atsci
Github user atsci commented on the issue: https://github.com/apache/trafficserver/pull/1539 clang-analyzer build *successful*! See https://ci.trafficserver.apache.org/job/clang-analyzer-github/235/ for details. --- If your project is set up for it, you can reply to this email

[GitHub] trafficserver issue #1539: Signals fix

2017-03-05 Thread atsci
Github user atsci commented on the issue: https://github.com/apache/trafficserver/pull/1539 Linux build *successful*! See https://ci.trafficserver.apache.org/job/linux-github/1567/ for details. --- If your project is set up for it, you can reply to this email and have your

[GitHub] trafficserver issue #1539: Signals fix

2017-03-05 Thread atsci
Github user atsci commented on the issue: https://github.com/apache/trafficserver/pull/1539 FreeBSD build *successful*! See https://ci.trafficserver.apache.org/job/freebsd-github/1671/ for details. --- If your project is set up for it, you can reply to this email and have

[GitHub] trafficserver issue #1539: Signals fix

2017-03-05 Thread atsci
Github user atsci commented on the issue: https://github.com/apache/trafficserver/pull/1539 Intel CC build *successful*! See https://ci.trafficserver.apache.org/job/icc-github/103/ for details. --- If your project is set up for it, you can reply to this email and have your

[GitHub] trafficserver pull request #1539: Signals fix

2017-03-05 Thread PSUdaemon
GitHub user PSUdaemon opened a pull request: https://github.com/apache/trafficserver/pull/1539 Signals fix This fixed Ubuntu builds but also reverts a commit I just backported because it was also reverted in master by @zwoop. You can merge this pull request into a Git repository

[GitHub] trafficserver issue #1538: Tests are failing on cache-generation-clear

2017-03-05 Thread dragon512
Github user dragon512 commented on the issue: https://github.com/apache/trafficserver/issues/1538 @bryancall Can you provide move info on this. as of Friday this was passing fine. Could you dump the report details for this test? --- If your project is set up for it, you can reply to

[GitHub] trafficserver issue #1443: Assert on null t_state.transact_return_point

2017-03-05 Thread bryancall
Github user bryancall closed the issue at: https://github.com/apache/trafficserver/issues/1443 --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project does not have this feature enabled and wishes so, or if the feature

[GitHub] trafficserver issue #1443: Assert on null t_state.transact_return_point

2017-03-05 Thread bryancall
Github user bryancall commented on the issue: https://github.com/apache/trafficserver/issues/1443 Looks like this should be closed since the PR for it was merged. Please reopen if need be. --- If your project is set up for it, you can reply to this email and have your reply appear

[GitHub] trafficserver issue #1538: Tests are failing on cache-generation-clear

2017-03-05 Thread bryancall
GitHub user bryancall opened an issue: https://github.com/apache/trafficserver/issues/1538 Tests are failing on cache-generation-clear ``` [bcall@homer tests]$ time ./autest.sh --ats-bin /usr/local/bin Running Test basic:. Passed Running Test basic-cop:. Passed

[GitHub] trafficserver issue #1537: TS-4976: Regularize example plugin basic_auth.

2017-03-05 Thread atsci
Github user atsci commented on the issue: https://github.com/apache/trafficserver/pull/1537 clang-analyzer build *successful*! See https://ci.trafficserver.apache.org/job/clang-analyzer-github/234/ for details. --- If your project is set up for it, you can reply to this email

[GitHub] trafficserver issue #1537: TS-4976: Regularize example plugin basic_auth.

2017-03-05 Thread atsci
Github user atsci commented on the issue: https://github.com/apache/trafficserver/pull/1537 Linux build *failed*! See https://ci.trafficserver.apache.org/job/linux-github/1566/ for details. --- If your project is set up for it, you can reply to this email and have your reply

[GitHub] trafficserver issue #1537: TS-4976: Regularize example plugin basic_auth.

2017-03-05 Thread atsci
Github user atsci commented on the issue: https://github.com/apache/trafficserver/pull/1537 Intel CC build *failed*! See https://ci.trafficserver.apache.org/job/icc-github/102/ for details. --- If your project is set up for it, you can reply to this email and have your reply

[GitHub] trafficserver issue #1537: TS-4976: Regularize example plugin basic_auth.

2017-03-05 Thread atsci
Github user atsci commented on the issue: https://github.com/apache/trafficserver/pull/1537 FreeBSD build *failed*! See https://ci.trafficserver.apache.org/job/freebsd-github/1670/ for details. --- If your project is set up for it, you can reply to this email and have your

[GitHub] trafficserver pull request #1537: TS-4976: Regularize example plugin basic_a...

2017-03-05 Thread SolidWallOfCode
GitHub user SolidWallOfCode opened a pull request: https://github.com/apache/trafficserver/pull/1537 TS-4976: Regularize example plugin basic_auth. You can merge this pull request into a Git repository by running: $ git pull https://github.com/SolidWallOfCode/trafficserver

[GitHub] trafficserver pull request #1533: TS-4976: Regularize example plugin append_...

2017-03-05 Thread SolidWallOfCode
Github user SolidWallOfCode closed the pull request at: https://github.com/apache/trafficserver/pull/1533 --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project does not have this feature enabled and wishes so, or if