[GitHub] trafficserver issue #1562: dns Negative cache

2017-03-09 Thread pubyun
Github user pubyun commented on the issue: https://github.com/apache/trafficserver/issues/1562 maybe another issue: ATS will try ipv6 dns resolve for non-exist host name every time also i config flowing config: CONFIG proxy.config.hostdb.ip_resolve STRING ipv4;none

[GitHub] trafficserver issue #1562: dns Negative cache

2017-03-09 Thread pubyun
GitHub user pubyun opened an issue: https://github.com/apache/trafficserver/issues/1562 dns Negative cache tcpdump shows that ATS will query DNS server for a non-exist host name every time. there is no dns Negative cache in ATS. i test ATS 6.2.1. ---

[GitHub] trafficserver issue #1399: Paft of tcp_congestion_control code was erased by...

2017-03-09 Thread maskit
Github user maskit closed the issue at: https://github.com/apache/trafficserver/issues/1399 --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project does not have this feature enabled and wishes so, or if the feature is

[GitHub] trafficserver issue #1399: Paft of tcp_congestion_control code was erased by...

2017-03-09 Thread maskit
Github user maskit commented on the issue: https://github.com/apache/trafficserver/issues/1399 Fixed on 6.2.x, 7.1.x and master. --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project does not have this feature

[GitHub] trafficserver issue #1535: Cleanup new tests/ tree with RAT exclusions / lic...

2017-03-09 Thread zwoop
Github user zwoop commented on the issue: https://github.com/apache/trafficserver/issues/1535 This is done. --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project does not have this feature enabled and wishes

[GitHub] trafficserver issue #1535: Cleanup new tests/ tree with RAT exclusions / lic...

2017-03-09 Thread zwoop
Github user zwoop closed the issue at: https://github.com/apache/trafficserver/issues/1535 --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project does not have this feature enabled and wishes so, or if the feature is

[GitHub] trafficserver issue #1426: issue #1399 add code of tcp_congestion_control er...

2017-03-09 Thread zwoop
Github user zwoop commented on the issue: https://github.com/apache/trafficserver/pull/1426 This is now back ported to 7.1.0. --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project does not have this feature

[GitHub] trafficserver issue #1561: A new 7.1 Crash with regex_revalidate config upda...

2017-03-09 Thread zwoop
Github user zwoop commented on the issue: https://github.com/apache/trafficserver/issues/1561 Yeh, I think you have to create the mutex. Before all these changes, the core would create one for you if it needed it, but that had a massive single mutex around that. So instead, we now

[GitHub] trafficserver issue #1557: brotli support in gzip plugin

2017-03-09 Thread myraid
Github user myraid commented on the issue: https://github.com/apache/trafficserver/pull/1557 @bryancall Yes the default behavior is br. Are you suggesting that the option should dictate normalizing the AE? What will be the behavior when both gzip and br are selected? --- If

[GitHub] trafficserver pull request #1557: brotli support in gzip plugin

2017-03-09 Thread myraid
Github user myraid commented on a diff in the pull request: https://github.com/apache/trafficserver/pull/1557#discussion_r105300325 --- Diff: plugins/gzip/gzip.cc --- @@ -95,18 +104,29 @@ gzip_data_alloc(int compression_type) } } + if(compression_type ==

[GitHub] trafficserver issue #1557: brotli support in gzip plugin

2017-03-09 Thread bryancall
Github user bryancall commented on the issue: https://github.com/apache/trafficserver/pull/1557 It looks like brotli is on by default? It would be nice to have an option on what types of compression algorithms that you want to enable. --- If your project is set up for it, you can

[GitHub] trafficserver pull request #1557: brotli support in gzip plugin

2017-03-09 Thread bryancall
Github user bryancall commented on a diff in the pull request: https://github.com/apache/trafficserver/pull/1557#discussion_r105279083 --- Diff: plugins/gzip/gzip.cc --- @@ -95,18 +104,29 @@ gzip_data_alloc(int compression_type) } } + if(compression_type

[GitHub] trafficserver issue #1516: Implement Cache-Control: immutable handling

2017-03-09 Thread shukitchan
Github user shukitchan commented on the issue: https://github.com/apache/trafficserver/pull/1516 feature flag or feature gate should be fine. i think it is a bug, too. but unfortunately i think we still need to support that till the next major release. --- If your project

[GitHub] trafficserver issue #1544: AddressSanitizer failed to deallocate

2017-03-09 Thread zwoop
Github user zwoop commented on the issue: https://github.com/apache/trafficserver/issues/1544 Duplicate of #1498. --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project does not have this feature enabled and

[GitHub] trafficserver issue #1544: AddressSanitizer failed to deallocate

2017-03-09 Thread zwoop
Github user zwoop closed the issue at: https://github.com/apache/trafficserver/issues/1544 --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project does not have this feature enabled and wishes so, or if the feature is

[GitHub] trafficserver issue #1558: redundant url encoding for logging field "cquuc"

2017-03-09 Thread zwoop
Github user zwoop commented on the issue: https://github.com/apache/trafficserver/issues/1558 What version is this? I could have sworn we fixed this. --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project does

[GitHub] trafficserver issue #1561: A new 7.1 Crash

2017-03-09 Thread shinrich
GitHub user shinrich opened an issue: https://github.com/apache/trafficserver/issues/1561 A new 7.1 Crash After running in production for 2.5 days without incident (with a couple fixes now merged back to 7.1.x), I got a core with the following stack trace ``` (gdb) bt

[GitHub] trafficserver issue #1560: Replace all usage (and implementation) of Vec<> w...

2017-03-09 Thread zwoop
GitHub user zwoop opened an issue: https://github.com/apache/trafficserver/issues/1560 Replace all usage (and implementation) of Vec<> with std::vector @SolidWallOfCode says that it's better, and I like consistency, so we should unify the code around using one vector

[GitHub] trafficserver issue #1557: brotli support in gzip plugin

2017-03-09 Thread myraid
Github user myraid commented on the issue: https://github.com/apache/trafficserver/pull/1557 @bryancall @zwoop I am working on a enhancement to force brotli compression even if content-encoding header is present. Do you think it will be a good idea to have a separate plugin for

[GitHub] trafficserver issue #1426: issue #1399 add code of tcp_congestion_control er...

2017-03-09 Thread maskit
Github user maskit commented on the issue: https://github.com/apache/trafficserver/pull/1426 @zwoop Yes, we should. I wrote the reason on #1399. --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project does not

[GitHub] trafficserver issue #1335: Deadlock in HostDB

2017-03-09 Thread zwoop
Github user zwoop commented on the issue: https://github.com/apache/trafficserver/issues/1335 @jacksontj @vmamidi is working on this, and has a fix (hopefully). --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your

[GitHub] trafficserver issue #1412: Assertion in HttpSM::tunnel_handler_post

2017-03-09 Thread zwoop
Github user zwoop commented on the issue: https://github.com/apache/trafficserver/issues/1412 @oknet Did any of your commits address this issue? --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project does not

[GitHub] trafficserver issue #1527: More and slower active connections in 7.1.x

2017-03-09 Thread zwoop
Github user zwoop commented on the issue: https://github.com/apache/trafficserver/issues/1527 On our boxes, it was very noticeable. I can try again, but the net result was roughly 2-3x the number of active connections, and each transaction was 1/2 - 1/3 the speed (throughput in

[GitHub] trafficserver issue #1446: Need dedicated TS_SSL_SERVERNAME_HOOK

2017-03-09 Thread zwoop
Github user zwoop commented on the issue: https://github.com/apache/trafficserver/pull/1446 @shinrich @oknet Is this still a 7.1.0 candidate? Or do we move out to 7.2.0? --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well.

[GitHub] trafficserver issue #1426: issue #1399 add code of tcp_congestion_control er...

2017-03-09 Thread zwoop
Github user zwoop commented on the issue: https://github.com/apache/trafficserver/pull/1426 @maskit should we backport this to 7.1.0 ? --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project does not have this

[GitHub] trafficserver issue #1526: When SSL connect fails, we return 502 success

2017-03-09 Thread zwoop
Github user zwoop commented on the issue: https://github.com/apache/trafficserver/pull/1526 I'd like to put this in for 7.1.0 I think. Any objections? --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project does

[GitHub] trafficserver issue #1531: Assertion in state_read_server_response_header (v...

2017-03-09 Thread zwoop
Github user zwoop closed the issue at: https://github.com/apache/trafficserver/issues/1531 --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project does not have this feature enabled and wishes so, or if the feature is

[GitHub] trafficserver pull request #1559: Do not callback one SM EVENT_ERROR twice.

2017-03-09 Thread zwoop
Github user zwoop closed the pull request at: https://github.com/apache/trafficserver/pull/1559 --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project does not have this feature enabled and wishes so, or if the feature

[GitHub] trafficserver issue #1516: Implement Cache-Control: immutable handling

2017-03-09 Thread danobi
Github user danobi commented on the issue: https://github.com/apache/trafficserver/pull/1516 Ok. Does a feature gate sound good? We can flip the flag on the next release. --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well.

[GitHub] trafficserver issue #1481: Log Field % always outputs "-"

2017-03-09 Thread zwoop
Github user zwoop commented on the issue: https://github.com/apache/trafficserver/issues/1481 Yeh, I suck. Patch coming. --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project does not have this feature enabled

[GitHub] trafficserver issue #1175: socks.config - dest_ip rule issue

2017-03-09 Thread 06chaynes
Github user 06chaynes commented on the issue: https://github.com/apache/trafficserver/issues/1175 I apologize for the lack of updates on this, i Just now got a chance to pull this back out and start testing. I verified that the setup works properly in Debian. I also agree that my

[GitHub] trafficserver pull request #1559: Do not callback one SM EVENT_ERROR twice.

2017-03-09 Thread zwoop
Github user zwoop commented on a diff in the pull request: https://github.com/apache/trafficserver/pull/1559#discussion_r105187896 --- Diff: iocore/net/UnixNetVConnection.cc --- @@ -271,9 +271,22 @@ read_from_net(NetHandler *nh, UnixNetVConnection *vc, EThread *thread)

[GitHub] trafficserver issue #1559: Do not callback one SM EVENT_ERROR twice.

2017-03-09 Thread zwoop
Github user zwoop commented on the issue: https://github.com/apache/trafficserver/pull/1559 Nice! Testing this PR on docs.trafficserver now. --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project does not have

[GitHub] trafficserver issue #1559: Do not callback one SM EVENT_ERROR twice.

2017-03-09 Thread zwoop
Github user zwoop commented on the issue: https://github.com/apache/trafficserver/pull/1559 @oknet Yes, ignore AU tests for now. --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project does not have this feature

[GitHub] trafficserver issue #1531: Assertion in state_read_server_response_header (v...

2017-03-09 Thread oknet
Github user oknet commented on the issue: https://github.com/apache/trafficserver/issues/1531 I created a PR #1559 to resolve this issue. --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project does not have this

[GitHub] trafficserver issue #1559: Do not callback one SM EVENT_ERROR twice.

2017-03-09 Thread scw00
Github user scw00 commented on the issue: https://github.com/apache/trafficserver/pull/1559 @oknet I it work well on my test env, and jtest can not re-product any more ! --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well.