[GitHub] trafficserver issue #1502: issue #1501: reconstruct to load the default valu...

2017-03-16 Thread atsci
Github user atsci commented on the issue: https://github.com/apache/trafficserver/pull/1502 clang-analyzer build *successful*! https://ci.trafficserver.apache.org/job/clang-analyzer-github/337/ --- If your project is set up for it, you can reply to this email and have your

[GitHub] trafficserver issue #1502: issue #1501: reconstruct to load the default valu...

2017-03-16 Thread atsci
Github user atsci commented on the issue: https://github.com/apache/trafficserver/pull/1502 Intel CC build *successful*! https://ci.trafficserver.apache.org/job/icc-github/205/ --- If your project is set up for it, you can reply to this email and have your reply appear on

[GitHub] trafficserver issue #1502: issue #1501: reconstruct to load the default valu...

2017-03-16 Thread atsci
Github user atsci commented on the issue: https://github.com/apache/trafficserver/pull/1502 Linux build *successful*! https://ci.trafficserver.apache.org/job/linux-github/1667/ --- If your project is set up for it, you can reply to this email and have your reply appear on

[GitHub] trafficserver issue #1502: issue #1501: reconstruct to load the default valu...

2017-03-16 Thread atsci
Github user atsci commented on the issue: https://github.com/apache/trafficserver/pull/1502 FreeBSD11 build *successful*! https://ci.trafficserver.apache.org/job/freebsd-github/1774/ --- If your project is set up for it, you can reply to this email and have your reply appear

[GitHub] trafficserver issue #1502: issue #1501: reconstruct to load the default valu...

2017-03-16 Thread atsci
Github user atsci commented on the issue: https://github.com/apache/trafficserver/pull/1502 AU check *successful*! https://ci.trafficserver.apache.org/job/autest-github/76/ --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub

[GitHub] trafficserver issue #1502: issue #1501: reconstruct to load the default valu...

2017-03-16 Thread atsci
Github user atsci commented on the issue: https://github.com/apache/trafficserver/pull/1502 clang format *successful*! https://ci.trafficserver.apache.org/job/clang-format-github/79/ --- If your project is set up for it, you can reply to this email and have your reply appear

[GitHub] trafficserver issue #1502: issue #1501: reconstruct to load the default valu...

2017-03-16 Thread atsci
Github user atsci commented on the issue: https://github.com/apache/trafficserver/pull/1502 RAT check *successful*! https://ci.trafficserver.apache.org/job/RAT-github/92/ --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as

[GitHub] trafficserver issue #1502: issue #1501: reconstruct to load the default valu...

2017-03-16 Thread maskit
Github user maskit commented on the issue: https://github.com/apache/trafficserver/pull/1502 [approve ci] --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project does not have this feature enabled and wishes so,

[GitHub] trafficserver pull request #1590: Fix a wrong option charactar for access_ke...

2017-03-16 Thread maskit
Github user maskit closed the pull request at: https://github.com/apache/trafficserver/pull/1590 --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project does not have this feature enabled and wishes so, or if the

[GitHub] trafficserver issue #1590: Fix a wrong option charactar for access_key

2017-03-16 Thread atsci
Github user atsci commented on the issue: https://github.com/apache/trafficserver/pull/1590 clang-analyzer build *successful*! https://ci.trafficserver.apache.org/job/clang-analyzer-github/336/ --- If your project is set up for it, you can reply to this email and have your

[GitHub] trafficserver issue #1589: glibc 2.25 will cause compile errors

2017-03-16 Thread zwoop
Github user zwoop commented on the issue: https://github.com/apache/trafficserver/issues/1589 @PSUdaemon You were mucking around in this mess a while back (even though I tried to keep you out of the rat hole ... ;). Can you take a look at this? It sounds similar to the issues you

[GitHub] trafficserver issue #1502: issue #1501: reconstruct to load the default valu...

2017-03-16 Thread zhilhuan
Github user zhilhuan commented on the issue: https://github.com/apache/trafficserver/pull/1502 @maskit Rebased and done a forced push. Would you please restart the CI? Thanks! --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as

[GitHub] trafficserver issue #1502: issue #1501: reconstruct to load the default valu...

2017-03-16 Thread maskit
Github user maskit commented on the issue: https://github.com/apache/trafficserver/pull/1502 @zhilhuan The build issue is already fixed on master but the commit (c251f2ba72d0520d25f8099af78a540f1586f55b) is not in your branch, I think. Could you rebase again? Then all builds should

[GitHub] trafficserver issue #1590: Fix a wrong option charactar for access_key

2017-03-16 Thread atsci
Github user atsci commented on the issue: https://github.com/apache/trafficserver/pull/1590 Intel CC build *successful*! https://ci.trafficserver.apache.org/job/icc-github/204/ --- If your project is set up for it, you can reply to this email and have your reply appear on

[GitHub] trafficserver issue #1590: Fix a wrong option charactar for access_key

2017-03-16 Thread atsci
Github user atsci commented on the issue: https://github.com/apache/trafficserver/pull/1590 Linux build *successful*! https://ci.trafficserver.apache.org/job/linux-github/1666/ --- If your project is set up for it, you can reply to this email and have your reply appear on

[GitHub] trafficserver issue #1590: Fix a wrong option charactar for access_key

2017-03-16 Thread atsci
Github user atsci commented on the issue: https://github.com/apache/trafficserver/pull/1590 FreeBSD11 build *successful*! https://ci.trafficserver.apache.org/job/freebsd-github/1773/ --- If your project is set up for it, you can reply to this email and have your reply appear

[GitHub] trafficserver issue #1590: Fix a wrong option charactar for access_key

2017-03-16 Thread atsci
Github user atsci commented on the issue: https://github.com/apache/trafficserver/pull/1590 AU check *successful*! https://ci.trafficserver.apache.org/job/autest-github/75/ --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub

[GitHub] trafficserver issue #1590: Fix a wrong option charactar for access_key

2017-03-16 Thread atsci
Github user atsci commented on the issue: https://github.com/apache/trafficserver/pull/1590 clang format *successful*! https://ci.trafficserver.apache.org/job/clang-format-github/78/ --- If your project is set up for it, you can reply to this email and have your reply appear

[GitHub] trafficserver issue #1590: Fix a wrong option charactar for access_key

2017-03-16 Thread atsci
Github user atsci commented on the issue: https://github.com/apache/trafficserver/pull/1590 RAT check *successful*! https://ci.trafficserver.apache.org/job/RAT-github/91/ --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as

[GitHub] trafficserver pull request #1590: Fix a wrong option charactar for access_ke...

2017-03-16 Thread maskit
GitHub user maskit opened a pull request: https://github.com/apache/trafficserver/pull/1590 Fix a wrong option charactar for access_key The character doesn't match with line 536 ``` {const_cast("access_key"), required_argument, nullptr, 'a'}, ``` You can merge this pull

[GitHub] trafficserver issue #1502: issue #1501: reconstruct to load the default valu...

2017-03-16 Thread zhilhuan
Github user zhilhuan commented on the issue: https://github.com/apache/trafficserver/pull/1502 Hi, sorry that I am not familiar with how this CI is running. But I've tried to "make" and "make test" in my local linux server (CentOS 7.2), there is no failure. So I guess the "Linux

[GitHub] trafficserver issue #1589: glibc 2.25 will cause compile errors

2017-03-16 Thread danobi
GitHub user danobi opened an issue: https://github.com/apache/trafficserver/issues/1589 glibc 2.25 will cause compile errors Heads up: according to the 2.25 release document: > * The types res_sendhookact, res_send_qhook, re_send_rhook, and the qhook and rhook members

[GitHub] trafficserver issue #1567: [RFC] Diags scrubbing mechanism

2017-03-16 Thread danobi
Github user danobi commented on the issue: https://github.com/apache/trafficserver/pull/1567 Personally, I don't think this feature has much use in open source. If nothing else, it probably encourages poor security practices. Even with this patch, someone could still do a

[GitHub] trafficserver issue #1567: [RFC] Diags scrubbing mechanism

2017-03-16 Thread atsci
Github user atsci commented on the issue: https://github.com/apache/trafficserver/pull/1567 clang-analyzer build *successful*! https://ci.trafficserver.apache.org/job/clang-analyzer-github/335/ --- If your project is set up for it, you can reply to this email and have your

[GitHub] trafficserver issue #1567: [RFC] Diags scrubbing mechanism

2017-03-16 Thread atsci
Github user atsci commented on the issue: https://github.com/apache/trafficserver/pull/1567 Linux build *successful*! https://ci.trafficserver.apache.org/job/linux-github/1665/ --- If your project is set up for it, you can reply to this email and have your reply appear on

[GitHub] trafficserver issue #1567: [RFC] Diags scrubbing mechanism

2017-03-16 Thread atsci
Github user atsci commented on the issue: https://github.com/apache/trafficserver/pull/1567 Intel CC build *successful*! https://ci.trafficserver.apache.org/job/icc-github/203/ --- If your project is set up for it, you can reply to this email and have your reply appear on

[GitHub] trafficserver issue #1567: [RFC] Diags scrubbing mechanism

2017-03-16 Thread atsci
Github user atsci commented on the issue: https://github.com/apache/trafficserver/pull/1567 FreeBSD11 build *successful*! https://ci.trafficserver.apache.org/job/freebsd-github/1772/ --- If your project is set up for it, you can reply to this email and have your reply appear

[GitHub] trafficserver issue #1567: [RFC] Diags scrubbing mechanism

2017-03-16 Thread atsci
Github user atsci commented on the issue: https://github.com/apache/trafficserver/pull/1567 AU check *failed*! https://ci.trafficserver.apache.org/job/autest-github/74/ --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as

[GitHub] trafficserver issue #1567: [RFC] Diags scrubbing mechanism

2017-03-16 Thread atsci
Github user atsci commented on the issue: https://github.com/apache/trafficserver/pull/1567 clang format *successful*! https://ci.trafficserver.apache.org/job/clang-format-github/77/ --- If your project is set up for it, you can reply to this email and have your reply appear

[GitHub] trafficserver issue #1567: [RFC] Diags scrubbing mechanism

2017-03-16 Thread atsci
Github user atsci commented on the issue: https://github.com/apache/trafficserver/pull/1567 RAT check *successful*! https://ci.trafficserver.apache.org/job/RAT-github/90/ --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as

[GitHub] trafficserver issue #1548: Insure that parent health stats are updated prope...

2017-03-16 Thread jrushford
Github user jrushford commented on the issue: https://github.com/apache/trafficserver/pull/1548 @zwoop you're right of course. I'm going to take a closer look at refactoring this into a base class. --- If your project is set up for it, you can reply to this email and have your

[GitHub] trafficserver issue #1582: Make regex_revalidate.c use ref-counted config da...

2017-03-16 Thread jrushford
Github user jrushford commented on the issue: https://github.com/apache/trafficserver/issues/1582 @zwoop I'll take a look. --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project does not have this feature

[GitHub] trafficserver issue #1548: Insure that parent health stats are updated prope...

2017-03-16 Thread zwoop
Github user zwoop commented on the issue: https://github.com/apache/trafficserver/pull/1548 @jrushford I assume we don't want this for 7.1.0 ? --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project does not have

[GitHub] trafficserver pull request #1567: [RFC] Diags scrubbing mechanism

2017-03-16 Thread SolidWallOfCode
Github user SolidWallOfCode commented on a diff in the pull request: https://github.com/apache/trafficserver/pull/1567#discussion_r106505497 --- Diff: lib/ts/Diags.h --- @@ -226,6 +242,10 @@ class Diags mutable ink_mutex tag_table_lock; // prevents reconfig/read races

[GitHub] trafficserver pull request #1567: [RFC] Diags scrubbing mechanism

2017-03-16 Thread SolidWallOfCode
Github user SolidWallOfCode commented on a diff in the pull request: https://github.com/apache/trafficserver/pull/1567#discussion_r106505205 --- Diff: proxy/logging/LogObject.h --- @@ -299,6 +299,10 @@ class LogObject : public RefCountObj unsigned m_buffer_manager_idx;

[GitHub] trafficserver pull request #1516: Implement Cache-Control: immutable handlin...

2017-03-16 Thread shukitchan
Github user shukitchan commented on a diff in the pull request: https://github.com/apache/trafficserver/pull/1516#discussion_r106500402 --- Diff: doc/admin-guide/plugins/combo_handler.en.rst --- @@ -83,3 +83,16 @@ results in these file paths being "reconstructed"::

[GitHub] trafficserver pull request #1567: [RFC] Diags scrubbing mechanism

2017-03-16 Thread danobi
Github user danobi commented on a diff in the pull request: https://github.com/apache/trafficserver/pull/1567#discussion_r106498117 --- Diff: proxy/logging/LogObject.h --- @@ -299,6 +299,10 @@ class LogObject : public RefCountObj unsigned m_buffer_manager_idx;

[GitHub] trafficserver pull request #1516: Implement Cache-Control: immutable handlin...

2017-03-16 Thread danobi
Github user danobi commented on a diff in the pull request: https://github.com/apache/trafficserver/pull/1516#discussion_r106499461 --- Diff: doc/admin-guide/plugins/combo_handler.en.rst --- @@ -83,3 +83,16 @@ results in these file paths being "reconstructed"::

[GitHub] trafficserver pull request #1567: [RFC] Diags scrubbing mechanism

2017-03-16 Thread danobi
Github user danobi commented on a diff in the pull request: https://github.com/apache/trafficserver/pull/1567#discussion_r106496765 --- Diff: lib/ts/Scrubber.h --- @@ -0,0 +1,89 @@ +/** @file + + The Scrubber class helps replace patterns of text inside a buffer with

[GitHub] trafficserver pull request #1516: Implement Cache-Control: immutable handlin...

2017-03-16 Thread shukitchan
Github user shukitchan commented on a diff in the pull request: https://github.com/apache/trafficserver/pull/1516#discussion_r106484837 --- Diff: doc/admin-guide/plugins/combo_handler.en.rst --- @@ -83,3 +83,16 @@ results in these file paths being "reconstructed"::

[GitHub] trafficserver pull request #1567: [RFC] Diags scrubbing mechanism

2017-03-16 Thread danobi
Github user danobi commented on a diff in the pull request: https://github.com/apache/trafficserver/pull/1567#discussion_r106495464 --- Diff: lib/ts/Diags.h --- @@ -226,6 +242,10 @@ class Diags mutable ink_mutex tag_table_lock; // prevents reconfig/read races DFA

[GitHub] trafficserver pull request #1567: [RFC] Diags scrubbing mechanism

2017-03-16 Thread danobi
Github user danobi commented on a diff in the pull request: https://github.com/apache/trafficserver/pull/1567#discussion_r106495318 --- Diff: lib/ts/Scrubber.cc --- @@ -0,0 +1,201 @@ +/** @file + + Implementation for Scrubber.h + + @section license License

[GitHub] trafficserver issue #1516: Implement Cache-Control: immutable handling

2017-03-16 Thread atsci
Github user atsci commented on the issue: https://github.com/apache/trafficserver/pull/1516 clang-analyzer build *successful*! https://ci.trafficserver.apache.org/job/clang-analyzer-github/334/ --- If your project is set up for it, you can reply to this email and have your

[GitHub] trafficserver issue #1516: Implement Cache-Control: immutable handling

2017-03-16 Thread atsci
Github user atsci commented on the issue: https://github.com/apache/trafficserver/pull/1516 Intel CC build *successful*! https://ci.trafficserver.apache.org/job/icc-github/202/ --- If your project is set up for it, you can reply to this email and have your reply appear on

[GitHub] trafficserver issue #1516: Implement Cache-Control: immutable handling

2017-03-16 Thread atsci
Github user atsci commented on the issue: https://github.com/apache/trafficserver/pull/1516 Linux build *successful*! https://ci.trafficserver.apache.org/job/linux-github/1664/ --- If your project is set up for it, you can reply to this email and have your reply appear on

[GitHub] trafficserver issue #1516: Implement Cache-Control: immutable handling

2017-03-16 Thread atsci
Github user atsci commented on the issue: https://github.com/apache/trafficserver/pull/1516 FreeBSD11 build *successful*! https://ci.trafficserver.apache.org/job/freebsd-github/1771/ --- If your project is set up for it, you can reply to this email and have your reply appear

[GitHub] trafficserver issue #1516: Implement Cache-Control: immutable handling

2017-03-16 Thread atsci
Github user atsci commented on the issue: https://github.com/apache/trafficserver/pull/1516 AU check *successful*! https://ci.trafficserver.apache.org/job/autest-github/73/ --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub

[GitHub] trafficserver issue #1567: [RFC] Diags scrubbing mechanism

2017-03-16 Thread SolidWallOfCode
Github user SolidWallOfCode commented on the issue: https://github.com/apache/trafficserver/pull/1567 Looking better. --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project does not have this feature enabled and

[GitHub] trafficserver pull request #1567: [RFC] Diags scrubbing mechanism

2017-03-16 Thread SolidWallOfCode
Github user SolidWallOfCode commented on a diff in the pull request: https://github.com/apache/trafficserver/pull/1567#discussion_r106482070 --- Diff: proxy/logging/LogObject.h --- @@ -299,6 +299,10 @@ class LogObject : public RefCountObj unsigned m_buffer_manager_idx;

[GitHub] trafficserver issue #1516: Implement Cache-Control: immutable handling

2017-03-16 Thread atsci
Github user atsci commented on the issue: https://github.com/apache/trafficserver/pull/1516 clang format *successful*! https://ci.trafficserver.apache.org/job/clang-format-github/76/ --- If your project is set up for it, you can reply to this email and have your reply appear

[GitHub] trafficserver issue #1516: Implement Cache-Control: immutable handling

2017-03-16 Thread atsci
Github user atsci commented on the issue: https://github.com/apache/trafficserver/pull/1516 RAT check *successful*! https://ci.trafficserver.apache.org/job/RAT-github/89/ --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as

[GitHub] trafficserver pull request #1567: [RFC] Diags scrubbing mechanism

2017-03-16 Thread SolidWallOfCode
Github user SolidWallOfCode commented on a diff in the pull request: https://github.com/apache/trafficserver/pull/1567#discussion_r106481662 --- Diff: lib/ts/Scrubber.h --- @@ -0,0 +1,89 @@ +/** @file + + The Scrubber class helps replace patterns of text inside a

[GitHub] trafficserver pull request #1567: [RFC] Diags scrubbing mechanism

2017-03-16 Thread SolidWallOfCode
Github user SolidWallOfCode commented on a diff in the pull request: https://github.com/apache/trafficserver/pull/1567#discussion_r106481402 --- Diff: lib/ts/Scrubber.h --- @@ -0,0 +1,89 @@ +/** @file + + The Scrubber class helps replace patterns of text inside a

[GitHub] trafficserver issue #1516: Implement Cache-Control: immutable handling

2017-03-16 Thread danobi
Github user danobi commented on the issue: https://github.com/apache/trafficserver/pull/1516 I just copied over the same text from the README to the admin config docs. --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If

[GitHub] trafficserver pull request #1567: [RFC] Diags scrubbing mechanism

2017-03-16 Thread SolidWallOfCode
Github user SolidWallOfCode commented on a diff in the pull request: https://github.com/apache/trafficserver/pull/1567#discussion_r106480902 --- Diff: lib/ts/Scrubber.cc --- @@ -0,0 +1,201 @@ +/** @file + + Implementation for Scrubber.h + + @section license

[GitHub] trafficserver issue #1548: Insure that parent health stats are updated prope...

2017-03-16 Thread zwoop
Github user zwoop commented on the issue: https://github.com/apache/trafficserver/pull/1548 I'm fine with this. However, seeing that the two policy implementations has virtually identical implementations here, it begs the question as to why this is not in a base class? It seems

[GitHub] trafficserver issue #1557: brotli support in gzip plugin

2017-03-16 Thread shukitchan
Github user shukitchan commented on the issue: https://github.com/apache/trafficserver/pull/1557 @myraid your description seems to be good. i will spend some times tomorrow to review the code. meanwhile, pls update this as well

[GitHub] trafficserver issue #1516: Implement Cache-Control: immutable handling

2017-03-16 Thread danobi
Github user danobi commented on the issue: https://github.com/apache/trafficserver/pull/1516 I didn't realize there was a doc page for that. Updating now. --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project

[GitHub] trafficserver issue #1516: Implement Cache-Control: immutable handling

2017-03-16 Thread shukitchan
Github user shukitchan commented on the issue: https://github.com/apache/trafficserver/pull/1516 looks good. thanks. can you update this as well? https://github.com/apache/trafficserver/blob/master/doc/admin-guide/plugins/combo_handler.en.rst @SolidWallOfCode , any

[GitHub] trafficserver pull request #1588: Make clear the implicit relationship betwe...

2017-03-16 Thread zwoop
Github user zwoop closed the pull request at: https://github.com/apache/trafficserver/pull/1588 --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project does not have this feature enabled and wishes so, or if the feature

[GitHub] trafficserver issue #1588: Make clear the implicit relationship between conf...

2017-03-16 Thread atsci
Github user atsci commented on the issue: https://github.com/apache/trafficserver/pull/1588 clang-analyzer build *successful*! https://ci.trafficserver.apache.org/job/clang-analyzer-github/333/ --- If your project is set up for it, you can reply to this email and have your

[GitHub] trafficserver pull request #1567: [RFC] Diags scrubbing mechanism

2017-03-16 Thread SolidWallOfCode
Github user SolidWallOfCode commented on a diff in the pull request: https://github.com/apache/trafficserver/pull/1567#discussion_r106456327 --- Diff: lib/ts/Scrubber.cc --- @@ -0,0 +1,201 @@ +/** @file + + Implementation for Scrubber.h + + @section license

[GitHub] trafficserver issue #1588: Make clear the implicit relationship between conf...

2017-03-16 Thread atsci
Github user atsci commented on the issue: https://github.com/apache/trafficserver/pull/1588 Intel CC build *successful*! https://ci.trafficserver.apache.org/job/icc-github/201/ --- If your project is set up for it, you can reply to this email and have your reply appear on

[GitHub] trafficserver issue #1588: Make clear the implicit relationship between conf...

2017-03-16 Thread atsci
Github user atsci commented on the issue: https://github.com/apache/trafficserver/pull/1588 Linux build *successful*! https://ci.trafficserver.apache.org/job/linux-github/1663/ --- If your project is set up for it, you can reply to this email and have your reply appear on

[GitHub] trafficserver issue #1588: Make clear the implicit relationship between conf...

2017-03-16 Thread atsci
Github user atsci commented on the issue: https://github.com/apache/trafficserver/pull/1588 AU check *successful*! https://ci.trafficserver.apache.org/job/autest-github/72/ --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub

[GitHub] trafficserver issue #1588: Make clear the implicit relationship between conf...

2017-03-16 Thread atsci
Github user atsci commented on the issue: https://github.com/apache/trafficserver/pull/1588 FreeBSD11 build *successful*! https://ci.trafficserver.apache.org/job/freebsd-github/1770/ --- If your project is set up for it, you can reply to this email and have your reply appear

[GitHub] trafficserver issue #1588: Make clear the implicit relationship between conf...

2017-03-16 Thread atsci
Github user atsci commented on the issue: https://github.com/apache/trafficserver/pull/1588 RAT check *successful*! https://ci.trafficserver.apache.org/job/RAT-github/88/ --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as

Jenkins build is back to normal : freebsd_10-master ยป clang,freebsd_10,release #1495

2017-03-16 Thread jenkins
See

[GitHub] trafficserver issue #1516: Implement Cache-Control: immutable handling

2017-03-16 Thread atsci
Github user atsci commented on the issue: https://github.com/apache/trafficserver/pull/1516 clang-analyzer build *successful*! https://ci.trafficserver.apache.org/job/clang-analyzer-github/332/ --- If your project is set up for it, you can reply to this email and have your

[GitHub] trafficserver issue #1588: Make clear the implicit relationship between conf...

2017-03-16 Thread atsci
Github user atsci commented on the issue: https://github.com/apache/trafficserver/pull/1588 clang format *successful*! https://ci.trafficserver.apache.org/job/clang-format-github/75/ --- If your project is set up for it, you can reply to this email and have your reply appear

[GitHub] trafficserver issue #1516: Implement Cache-Control: immutable handling

2017-03-16 Thread atsci
Github user atsci commented on the issue: https://github.com/apache/trafficserver/pull/1516 clang-analyzer build *successful*! https://ci.trafficserver.apache.org/job/clang-analyzer-github/331/ --- If your project is set up for it, you can reply to this email and have your

[GitHub] trafficserver pull request #1588: Make clear the implicit relationship betwe...

2017-03-16 Thread danobi
GitHub user danobi opened a pull request: https://github.com/apache/trafficserver/pull/1588 Make clear the implicit relationship between configs `periodic_tasks_interval` is the gatekeeper for all periodic tasks. Meaning, the implicit lower bound for all other log related

[GitHub] trafficserver issue #1516: Implement Cache-Control: immutable handling

2017-03-16 Thread atsci
Github user atsci commented on the issue: https://github.com/apache/trafficserver/pull/1516 Intel CC build *successful*! https://ci.trafficserver.apache.org/job/icc-github/200/ --- If your project is set up for it, you can reply to this email and have your reply appear on

[GitHub] trafficserver issue #1516: Implement Cache-Control: immutable handling

2017-03-16 Thread atsci
Github user atsci commented on the issue: https://github.com/apache/trafficserver/pull/1516 Linux build *successful*! https://ci.trafficserver.apache.org/job/linux-github/1662/ --- If your project is set up for it, you can reply to this email and have your reply appear on

[GitHub] trafficserver pull request #1567: [RFC] Diags scrubbing mechanism

2017-03-16 Thread SolidWallOfCode
Github user SolidWallOfCode commented on a diff in the pull request: https://github.com/apache/trafficserver/pull/1567#discussion_r106447714 --- Diff: lib/ts/Scrubber.cc --- @@ -0,0 +1,201 @@ +/** @file + + Implementation for Scrubber.h + + @section license

[GitHub] trafficserver issue #1516: Implement Cache-Control: immutable handling

2017-03-16 Thread atsci
Github user atsci commented on the issue: https://github.com/apache/trafficserver/pull/1516 FreeBSD11 build *successful*! https://ci.trafficserver.apache.org/job/freebsd-github/1769/ --- If your project is set up for it, you can reply to this email and have your reply appear

[GitHub] trafficserver issue #1516: Implement Cache-Control: immutable handling

2017-03-16 Thread atsci
Github user atsci commented on the issue: https://github.com/apache/trafficserver/pull/1516 Intel CC build *successful*! https://ci.trafficserver.apache.org/job/icc-github/199/ --- If your project is set up for it, you can reply to this email and have your reply appear on

[GitHub] trafficserver pull request #1567: [RFC] Diags scrubbing mechanism

2017-03-16 Thread SolidWallOfCode
Github user SolidWallOfCode commented on a diff in the pull request: https://github.com/apache/trafficserver/pull/1567#discussion_r106446324 --- Diff: lib/ts/Scrubber.cc --- @@ -0,0 +1,201 @@ +/** @file + + Implementation for Scrubber.h + + @section license

[GitHub] trafficserver pull request #1567: [RFC] Diags scrubbing mechanism

2017-03-16 Thread SolidWallOfCode
Github user SolidWallOfCode commented on a diff in the pull request: https://github.com/apache/trafficserver/pull/1567#discussion_r106445847 --- Diff: lib/ts/Scrubber.cc --- @@ -0,0 +1,201 @@ +/** @file + + Implementation for Scrubber.h + + @section license

[GitHub] trafficserver pull request #1567: [RFC] Diags scrubbing mechanism

2017-03-16 Thread SolidWallOfCode
Github user SolidWallOfCode commented on a diff in the pull request: https://github.com/apache/trafficserver/pull/1567#discussion_r106446114 --- Diff: lib/ts/Scrubber.cc --- @@ -0,0 +1,201 @@ +/** @file + + Implementation for Scrubber.h + + @section license

[GitHub] trafficserver issue #1516: Implement Cache-Control: immutable handling

2017-03-16 Thread atsci
Github user atsci commented on the issue: https://github.com/apache/trafficserver/pull/1516 FreeBSD11 build *successful*! https://ci.trafficserver.apache.org/job/freebsd-github/1768/ --- If your project is set up for it, you can reply to this email and have your reply appear

[GitHub] trafficserver pull request #1567: [RFC] Diags scrubbing mechanism

2017-03-16 Thread SolidWallOfCode
Github user SolidWallOfCode commented on a diff in the pull request: https://github.com/apache/trafficserver/pull/1567#discussion_r106445625 --- Diff: lib/ts/Diags.h --- @@ -226,6 +242,10 @@ class Diags mutable ink_mutex tag_table_lock; // prevents reconfig/read races

[GitHub] trafficserver issue #1516: Implement Cache-Control: immutable handling

2017-03-16 Thread atsci
Github user atsci commented on the issue: https://github.com/apache/trafficserver/pull/1516 AU check *successful*! https://ci.trafficserver.apache.org/job/autest-github/71/ --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub

[GitHub] trafficserver issue #1516: Implement Cache-Control: immutable handling

2017-03-16 Thread atsci
Github user atsci commented on the issue: https://github.com/apache/trafficserver/pull/1516 clang format *successful*! https://ci.trafficserver.apache.org/job/clang-format-github/74/ --- If your project is set up for it, you can reply to this email and have your reply appear

[GitHub] trafficserver issue #1516: Implement Cache-Control: immutable handling

2017-03-16 Thread atsci
Github user atsci commented on the issue: https://github.com/apache/trafficserver/pull/1516 RAT check *successful*! https://ci.trafficserver.apache.org/job/RAT-github/87/ --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as

[GitHub] trafficserver pull request #1567: [RFC] Diags scrubbing mechanism

2017-03-16 Thread SolidWallOfCode
Github user SolidWallOfCode commented on a diff in the pull request: https://github.com/apache/trafficserver/pull/1567#discussion_r106444530 --- Diff: lib/ts/Diags.cc --- @@ -926,3 +917,29 @@ Diags::rebind_stderr(int new_fd) } return false; } + +void

[GitHub] trafficserver issue #1516: Implement Cache-Control: immutable handling

2017-03-16 Thread danobi
Github user danobi commented on the issue: https://github.com/apache/trafficserver/pull/1516 @shukitchan @SolidWallOfCode Alright I believe I've made all the requested changes. --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as

[GitHub] trafficserver issue #1516: Implement Cache-Control: immutable handling

2017-03-16 Thread atsci
Github user atsci commented on the issue: https://github.com/apache/trafficserver/pull/1516 AU check *successful*! https://ci.trafficserver.apache.org/job/autest-github/70/ --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub

[GitHub] trafficserver pull request #1567: [RFC] Diags scrubbing mechanism

2017-03-16 Thread SolidWallOfCode
Github user SolidWallOfCode commented on a diff in the pull request: https://github.com/apache/trafficserver/pull/1567#discussion_r106444345 --- Diff: lib/ts/Diags.cc --- @@ -926,3 +917,29 @@ Diags::rebind_stderr(int new_fd) } return false; } + +void

[GitHub] trafficserver issue #1516: Implement Cache-Control: immutable handling

2017-03-16 Thread atsci
Github user atsci commented on the issue: https://github.com/apache/trafficserver/pull/1516 RAT check *successful*! https://ci.trafficserver.apache.org/job/RAT-github/86/ --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as

[GitHub] trafficserver issue #1516: Implement Cache-Control: immutable handling

2017-03-16 Thread atsci
Github user atsci commented on the issue: https://github.com/apache/trafficserver/pull/1516 clang format *successful*! https://ci.trafficserver.apache.org/job/clang-format-github/73/ --- If your project is set up for it, you can reply to this email and have your reply appear

[GitHub] trafficserver issue #1587: Intermittent regression test failures (debug buil...

2017-03-16 Thread zwoop
GitHub user zwoop opened an issue: https://github.com/apache/trafficserver/issues/1587 Intermittent regression test failures (debug build) Seeing this on some VMs: ``` REGRESSION TEST SDK_API_HttpTxnTransform started [SDK_API_HttpTxnTransform] TSTransformCreate :

[GitHub] trafficserver issue #1506: Wrong protocol version in the Via header

2017-03-16 Thread shukitchan
Github user shukitchan commented on the issue: https://github.com/apache/trafficserver/issues/1506 The fix is merged --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project does not have this feature enabled and

[GitHub] trafficserver issue #1506: Wrong protocol version in the Via header

2017-03-16 Thread shukitchan
Github user shukitchan closed the issue at: https://github.com/apache/trafficserver/issues/1506 --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project does not have this feature enabled and wishes so, or if the feature

[GitHub] trafficserver issue #1502: issue #1501: reconstruct to load the default valu...

2017-03-16 Thread atsci
Github user atsci commented on the issue: https://github.com/apache/trafficserver/pull/1502 clang-analyzer build *successful*! https://ci.trafficserver.apache.org/job/clang-analyzer-github/330/ --- If your project is set up for it, you can reply to this email and have your

[GitHub] trafficserver issue #1502: issue #1501: reconstruct to load the default valu...

2017-03-16 Thread atsci
Github user atsci commented on the issue: https://github.com/apache/trafficserver/pull/1502 FreeBSD11 build *successful*! https://ci.trafficserver.apache.org/job/freebsd-github/1767/ --- If your project is set up for it, you can reply to this email and have your reply appear

[GitHub] trafficserver issue #1502: issue #1501: reconstruct to load the default valu...

2017-03-16 Thread atsci
Github user atsci commented on the issue: https://github.com/apache/trafficserver/pull/1502 Linux build *failed*! https://ci.trafficserver.apache.org/job/linux-github/1661/ --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub

[GitHub] trafficserver issue #1502: issue #1501: reconstruct to load the default valu...

2017-03-16 Thread atsci
Github user atsci commented on the issue: https://github.com/apache/trafficserver/pull/1502 Intel CC build *failed*! https://ci.trafficserver.apache.org/job/icc-github/198/ --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub

[GitHub] trafficserver issue #1502: issue #1501: reconstruct to load the default valu...

2017-03-16 Thread atsci
Github user atsci commented on the issue: https://github.com/apache/trafficserver/pull/1502 AU check *successful*! https://ci.trafficserver.apache.org/job/autest-github/69/ --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub

[GitHub] trafficserver issue #1502: issue #1501: reconstruct to load the default valu...

2017-03-16 Thread atsci
Github user atsci commented on the issue: https://github.com/apache/trafficserver/pull/1502 clang format *successful*! https://ci.trafficserver.apache.org/job/clang-format-github/72/ --- If your project is set up for it, you can reply to this email and have your reply appear

  1   2   >