Github user gtenev commented on the issue:
https://github.com/apache/trafficserver/pull/792
@ftarnell looks good, thanks for fixing!
@zwoop it will be great if we can back port to 6.2.1
---
If your project is set up for it, you can reply to this email and have your
reply appear
Github user gtenev commented on the issue:
https://github.com/apache/trafficserver/pull/837
@zwoop thanks for reviewing!
As far as can tell the escalate plugin was implemented later then the
HttpHdr caching and the caching implementation does not support its use-case
well
Github user gtenev commented on a diff in the pull request:
https://github.com/apache/trafficserver/pull/818#discussion_r71735386
--- Diff: plugins/header_rewrite/ruleset.cc ---
@@ -51,7 +51,7 @@ RuleSet::add_condition(Parser , const char *filename)
if (!c->set_hook(_h
GitHub user gtenev opened a pull request:
https://github.com/apache/trafficserver/pull/837
TS-4706 Truncated SNI name during escalation
A fix for a problem with SSL hostname verification failing due to truncated
SNI name.
You can merge this pull request into a Git repository
Github user gtenev commented on the issue:
https://github.com/apache/trafficserver/pull/868
@PSUdaemon, tested the change and it seems it worked.
WITHOUT the fix:
```
Per-node process memory usage (in MBs) for PID 33486 ([ET_NET 0
Github user gtenev commented on the issue:
https://github.com/apache/trafficserver/pull/1441
ð looks good
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes
Github user gtenev commented on the issue:
https://github.com/apache/trafficserver/pull/882
@zwoop, announcement sent to users@
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
GitHub user gtenev opened a pull request:
https://github.com/apache/trafficserver/pull/882
TS-4362 Removed cacheurl plugin
Removed the cacheurl plugin and its documentation (including the Japanese
version)
You can merge this pull request into a Git repository by running
GitHub user gtenev opened a pull request:
https://github.com/apache/trafficserver/pull/1515
Logging cache code map size fix
The size of the cache code map does not correspond to the number of cache
result code values.
Discrepancy introduced with commit
GitHub user gtenev opened a pull request:
https://github.com/apache/trafficserver/pull/914
TS-4686 Moved hook-trace plugin to plugins/experimental
Moved hook-trace plugin from examples to plugin/experimental
and its documentation (including the Japanese version).
You can merge
Github user gtenev commented on the issue:
https://github.com/apache/trafficserver/pull/987
ð +1:
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so
Github user gtenev commented on a diff in the pull request:
https://github.com/apache/trafficserver/pull/956#discussion_r78275728
--- Diff: iocore/eventsystem/UnixEventProcessor.cc ---
@@ -129,34 +197,58 @@ EventProcessor::start(int n_event_threads, size_t
stacksize
Github user gtenev commented on the issue:
https://github.com/apache/trafficserver/pull/956
@PSUdaemon, the patch looks good, +1 on fixing the sleep(1).
Built and run it in production with ``exec_thread.affinity: 1`` and it run
fine.
Here some of the things I
GitHub user gtenev opened a pull request:
https://github.com/apache/trafficserver/pull/996
TS-4834 Expose bad disk and disk access failures
For monitoring purposes expose stats about:
- disk access failure count
- marked bad disk count
You can merge this pull request
Github user gtenev commented on a diff in the pull request:
https://github.com/apache/trafficserver/pull/1028#discussion_r79075679
--- Diff: iocore/cache/P_CacheDisk.h ---
@@ -97,6 +97,7 @@ struct CacheDisk : public Continuation {
int num_errors;
int cleared
Github user gtenev commented on a diff in the pull request:
https://github.com/apache/trafficserver/pull/1028#discussion_r79075616
--- Diff: iocore/cache/P_CacheDisk.h ---
@@ -97,6 +97,7 @@ struct CacheDisk : public Continuation {
int num_errors;
int cleared
GitHub user gtenev opened a pull request:
https://github.com/apache/trafficserver/pull/1028
TS-4870 Avoid marking storage offline multiple times
Currently storage can be marked offline multiple times which breaks related
metrics.
You can merge this pull request into a Git
Github user gtenev commented on the issue:
https://github.com/apache/trafficserver/pull/1022
I have not looked enough to say if this change is necessary or not but just
wanted to mention that it helped me with a crash I got after syncing my fork.
```
Starting program
Github user gtenev commented on the issue:
https://github.com/apache/trafficserver/pull/1028
@jpeach, appreciate your feedback!
It felt that "disk being offline" (might be an operator's decision) and
"disk being bad" (number of IO errors reached a thresh
Github user gtenev commented on the issue:
https://github.com/apache/trafficserver/pull/996
@jpeach and @SolidWallOfCode, really appreciate your feedback! Here is the
new patch.
Removed `_count`. The reason I added was that internally the "bad disk
metric" and &q
Github user gtenev commented on a diff in the pull request:
https://github.com/apache/trafficserver/pull/1028#discussion_r79487888
--- Diff: iocore/cache/Cache.cc ---
@@ -2000,6 +2000,12 @@ CacheProcessor::mark_storage_offline(CacheDisk *d
///< Target disk
uint6
Github user gtenev commented on the issue:
https://github.com/apache/trafficserver/pull/1028
@jpeach, renamed "offline" flag to "online", added some reasoning about why
the flag was necessary in the last commit description.
---
If your project is set up f
Github user gtenev commented on the issue:
https://github.com/apache/trafficserver/pull/911
ð
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so
GitHub user gtenev opened a pull request:
https://github.com/apache/trafficserver/pull/1157
TS-4916 Add safety net to avoid H2-infinite-loop deadlock.
Current Http2ConnectionState implementation uses a memory pool for
instantiating streams and DLL<> stream_list for s
Github user gtenev commented on the issue:
https://github.com/apache/trafficserver/pull/996
@zwoop, I have not heard any objections for a while so unless @jpeach and
@SolidWallOfCode have any concerns with the latest patch I think we can land it.
---
If your project is set up
Github user gtenev commented on the issue:
https://github.com/apache/trafficserver/pull/996
@jpeach added docs, @SolidWallOfCode made the requested change.
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project
Github user gtenev closed the pull request at:
https://github.com/apache/trafficserver/pull/1099
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so
Github user gtenev commented on the issue:
https://github.com/apache/trafficserver/pull/1099
@zwoop I did, my fork looks OK. it seems to me that later in the github GUI
I may have submitted the PR against base:master (which was the default), should
have been against 6.2.x. Closing
GitHub user gtenev opened a pull request:
https://github.com/apache/trafficserver/pull/1100
TS-4916: Fix for an H2-infinite-loop deadlock
This is a fix to prevent destroying of the DLL<> structure and the
following iteration over Http2ConnectionState::stream_list t
Github user gtenev commented on a diff in the pull request:
https://github.com/apache/trafficserver/pull/1100#discussion_r83510837
--- Diff: proxy/http2/Http2ConnectionState.cc ---
@@ -936,30 +940,70 @@ Http2ConnectionState::cleanup_streams()
void
Http2ConnectionState
Github user gtenev commented on a diff in the pull request:
https://github.com/apache/trafficserver/pull/1100#discussion_r83508421
--- Diff: proxy/http2/Http2ConnectionState.cc ---
@@ -936,30 +940,70 @@ Http2ConnectionState::cleanup_streams()
void
Http2ConnectionState
Github user gtenev commented on a diff in the pull request:
https://github.com/apache/trafficserver/pull/1100#discussion_r83511226
--- Diff: proxy/http2/Http2ConnectionState.cc ---
@@ -1097,6 +1141,7 @@ void
Http2ConnectionState::send_data_frames(Http2Stream *stream
Github user gtenev commented on a diff in the pull request:
https://github.com/apache/trafficserver/pull/1100#discussion_r83512075
--- Diff: proxy/http2/Http2Stream.cc ---
@@ -267,10 +267,12 @@ Http2Stream::do_io_close(int /* flags */)
// Make sure any trailing end
Github user gtenev commented on the issue:
https://github.com/apache/trafficserver/pull/1100
I was actually thinking to propose just adding a
âcatch-all-delete-streamâ call in `destroy()` before `THREAD_FREE()` in 7.0.
It seems to me that the point of this Jira TS-4813
GitHub user gtenev opened a pull request:
https://github.com/apache/trafficserver/pull/1117
TS-4916 Add safety net to avoid H2-infinite-loop deadlock.
Current Http2ConnectionState implementation uses a memory pool for
instantiating streams and DLL<> stream_list for s
Github user gtenev closed the pull request at:
https://github.com/apache/trafficserver/pull/1100
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so
Github user gtenev commented on the issue:
https://github.com/apache/trafficserver/pull/1100
Chatted with @shinrich offline and she is going to mark related fixes
TS-4813 and TS-4507 for backport from 7.0.0 to 6.2.1, which should take care of
the "missing to delete the stream
GitHub user gtenev opened a pull request:
https://github.com/apache/trafficserver/pull/1173
TS-4706 Truncated SNI name during escalation
SSL hostname verification failing due to truncated SNI name.
(cherry picked from commit 4d02d0e877e24b1dc94948c236462417bdd9bbf0)
You
GitHub user gtenev opened a pull request:
https://github.com/apache/trafficserver/pull/1172
TS-4650: cachekey: not thread safe
(cherry picked from commit f4a97a9d573867441c5dd711b54ff66117fcd057)
(cherry picked from commit 15b2ab08a30a0df8c2223e05c7bfc4cb530ea243)
You can merge
Github user gtenev commented on the issue:
https://github.com/apache/trafficserver/pull/996
@zwoop, it is ready to land now.
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
Github user gtenev commented on a diff in the pull request:
https://github.com/apache/trafficserver/pull/1100#discussion_r83279595
--- Diff: iocore/aio/.diags.log.meta ---
@@ -0,0 +1 @@
+creation_time = 1476307057
--- End diff --
removed, committed by mistake
GitHub user gtenev opened a pull request:
https://github.com/apache/trafficserver/pull/1099
TS-4916: Fix for an H2-infinite-loop deadlock
This is a fix to prevent destroying of the ``DLL<>`` structure and the
following iteration over ``Http2ConnectionState::stream_list`` t
Github user gtenev commented on the issue:
https://github.com/apache/trafficserver/pull/1238
ð looks reasonable to me, it would reduce the amount of data to
transfer/store without post-processing of the `traffic_logstats` output
---
If your project is set up for it, you can reply
Github user gtenev commented on the issue:
https://github.com/apache/trafficserver/pull/1246
ð looks good
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes
GitHub user gtenev opened a pull request:
https://github.com/apache/trafficserver/pull/1239
TS-5069 enhance logstats to report stats per user
Enhanced `traffic_logstats` to aggregate and report stats per user instead
of per host.
You can merge this pull request into a Git
Github user gtenev commented on the issue:
https://github.com/apache/trafficserver/pull/1239
@zwoop no problems, should be good now
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have
Github user gtenev commented on the issue:
https://github.com/apache/trafficserver/pull/1515
@jpeach: sounds like right thing to do, needed a quick fix, will find some
time to make the API less error-prone.
@zwoop: sir, yes, sir!
---
If your project is set up for it, you can
47 matches
Mail list logo
