[GitHub] trafficserver issue #1365: TS-4896: TSHttp***ClientAddrGet/TSHttp***Incoming...

2017-01-30 Thread zwoop
Github user zwoop commented on the issue: https://github.com/apache/trafficserver/pull/1365 Nit picky, and too late, but I kinda wish these two new variables would have been named "saved_XXX" instead of "cached_XXX". Cached make it sounds like it's an optim

[GitHub] trafficserver issue #1393: Trivial Autoconf cleanup

2017-01-30 Thread zwoop
Github user zwoop commented on the issue: https://github.com/apache/trafficserver/pull/1393 Nice catch on AC_SEARCH_LIBS! Question, i wonder if we do this wrong in other places? Are we adding things to LIBS when we shouldn't? There are several places where we do things like

[GitHub] trafficserver issue #1395: Update client streams count in Http2ConnectionSta...

2017-01-30 Thread zwoop
Github user zwoop commented on the issue: https://github.com/apache/trafficserver/pull/1395 Giving to @PSUdaemon, this is for him to consider for backport. --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project

[GitHub] trafficserver issue #1386: ATS hangs, possibly because of OpenSSL 1.1.0

2017-01-27 Thread zwoop
GitHub user zwoop opened an issue: https://github.com/apache/trafficserver/issues/1386 ATS hangs, possibly because of OpenSSL 1.1.0 Seeing very, very deep stack traces, like ``` ... #1602 0x00792a94 in ssl_rm_cached_session (ctx=0x2b6b0bd23400, sess

[GitHub] trafficserver issue #1385: sslheaders plugin fails with OpenSSL v1.1.0d

2017-01-27 Thread zwoop
GitHub user zwoop opened an issue: https://github.com/apache/trafficserver/issues/1385 sslheaders plugin fails with OpenSSL v1.1.0d ``` CXX experimental/sslheaders/experimental_sslheaders_libsslhdr_la-expand.lo experimental/sslheaders/expand.cc: In function 'void

[GitHub] trafficserver issue #1384: Warnings when compiling against OpenSSL 1.1.0d

2017-01-27 Thread zwoop
GitHub user zwoop opened an issue: https://github.com/apache/trafficserver/issues/1384 Warnings when compiling against OpenSSL 1.1.0d ``` SSLUtils.cc: In function ‘void SSLInitializeLibrary()’: SSLUtils.cc:863:57: warning: statement has no effect [-Wunused-value

[GitHub] trafficserver pull request #1383: This fixes build problems when using non-s...

2017-01-27 Thread zwoop
Github user zwoop closed the pull request at: https://github.com/apache/trafficserver/pull/1383 --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project does not have this feature enabled and wishes so, or if the feature

[GitHub] trafficserver pull request #1383: This fixes build problems when using non-s...

2017-01-27 Thread zwoop
GitHub user zwoop opened a pull request: https://github.com/apache/trafficserver/pull/1383 This fixes build problems when using non-standard OpenSSL You can merge this pull request into a Git repository by running: $ git pull https://github.com/zwoop/trafficserver Fix40310af

[GitHub] trafficserver issue #1382: TS-993: OpenBSD sbindir should be ${exec_prefix}/...

2017-01-27 Thread zwoop
Github user zwoop commented on the issue: https://github.com/apache/trafficserver/pull/1382 Ah wth, it seems safe, cherry-picking. --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project does not have

[GitHub] trafficserver issue #1313: Use Autoconf checks vs. OPENSSL_VERSION_NUMBER

2017-01-27 Thread zwoop
Github user zwoop commented on the issue: https://github.com/apache/trafficserver/pull/1313 Cherry-picked to 7.1.x --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project does not have this feature enabled

[GitHub] trafficserver issue #1382: TS-993: OpenBSD sbindir should be ${exec_prefix}/...

2017-01-27 Thread zwoop
Github user zwoop commented on the issue: https://github.com/apache/trafficserver/pull/1382 You want this for 7.1.x? --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project does not have this feature enabled

[GitHub] trafficserver issue #1313: Use Autoconf checks vs. OPENSSL_VERSION_NUMBER

2017-01-27 Thread zwoop
Github user zwoop commented on the issue: https://github.com/apache/trafficserver/pull/1313 You need this for 7.1.x ? --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project does not have this feature enabled

[GitHub] trafficserver pull request #1378: 7.1.x TS-5107: Changes to autolinking in D...

2017-01-26 Thread zwoop
Github user zwoop closed the pull request at: https://github.com/apache/trafficserver/pull/1378 --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project does not have this feature enabled and wishes so, or if the feature

[GitHub] trafficserver issue #1378: 7.1.x TS-5107: Changes to autolinking in Docutils...

2017-01-26 Thread zwoop
Github user zwoop commented on the issue: https://github.com/apache/trafficserver/pull/1378 I saw what happened, the reverts makes sense now. --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project does not have

[GitHub] trafficserver issue #1368: Issue #1367: HdrHeap potential corruption

2017-01-25 Thread zwoop
Github user zwoop commented on the issue: https://github.com/apache/trafficserver/pull/1368 @maskit @shinrich ping? Should we back port to 7.1.x ? --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project does

[GitHub] trafficserver issue #1380: Fixed issue where somaxconn was being set to 0 on...

2017-01-25 Thread zwoop
Github user zwoop commented on the issue: https://github.com/apache/trafficserver/pull/1380 ink_inet.cc:613:10: error: unused variable 'value_size' [-Werror=unused-variable] size_t value_size = sizeof(value); --- If your project is set up for it, you can reply to this email

[GitHub] trafficserver issue #1368: Issue #1367: HdrHeap potential corruption

2017-01-25 Thread zwoop
Github user zwoop commented on the issue: https://github.com/apache/trafficserver/pull/1368 @shinrich Should we cherry-pick this back to 7.1.x ? --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project does

[GitHub] trafficserver issue #1375: Incorrectly freeing Http1ClientSession setting up...

2017-01-25 Thread zwoop
Github user zwoop commented on the issue: https://github.com/apache/trafficserver/pull/1375 Is this a 7.1.x candidate? --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project does not have this feature enabled

[GitHub] trafficserver issue #1378: 7.1.x TS-5107: Changes to autolinking in Docutils...

2017-01-25 Thread zwoop
Github user zwoop commented on the issue: https://github.com/apache/trafficserver/pull/1378 Also, please remember to add Milestone, Label's etc. on each Issue / PR, otherwise @bryancall gets all pissy. :) --- If your project is set up for it, you can reply to this email and have

[GitHub] trafficserver issue #1378: 7.1.x TS-5107: Changes to autolinking in Docutils...

2017-01-25 Thread zwoop
Github user zwoop commented on the issue: https://github.com/apache/trafficserver/pull/1378 Why are there 4 commits on this? Can you squash those? --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project does

[GitHub] trafficserver issue #1303: TS-5107: Changes to autolinking in Docutils 1.3

2017-01-25 Thread zwoop
Github user zwoop commented on the issue: https://github.com/apache/trafficserver/pull/1303 This doesn't merge cleanly into 7.1.x branch (conflicts on the python script). @jablko Can you make a new PR, for the 7.1.x branch please? --- If your project is set up for it, you can reply

[GitHub] trafficserver pull request #1374: Fix CID 1369398: Null pointer dereferences

2017-01-25 Thread zwoop
Github user zwoop closed the pull request at: https://github.com/apache/trafficserver/pull/1374 --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project does not have this feature enabled and wishes so, or if the feature

[GitHub] trafficserver issue #1303: TS-5107: Changes to autolinking in Docutils 1.3

2017-01-24 Thread zwoop
Github user zwoop commented on the issue: https://github.com/apache/trafficserver/pull/1303 Status on this? is thing going to land for 7.1.x ? --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project does not have

[GitHub] trafficserver issue #1357: TS-5022: reduce memory allocation in clientcert l...

2017-01-24 Thread zwoop
Github user zwoop commented on the issue: https://github.com/apache/trafficserver/pull/1357 @shinrich @SolidWallOfCode Is this landing for 7.1.x? --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project does

[GitHub] trafficserver pull request #1350: TS-5080: log when remap.config is successf...

2017-01-24 Thread zwoop
Github user zwoop closed the pull request at: https://github.com/apache/trafficserver/pull/1350 --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project does not have this feature enabled and wishes so, or if the feature

[GitHub] trafficserver issue #1328: Replace gethostbyname_r() with getaddrinfo()

2017-01-23 Thread zwoop
Github user zwoop commented on the issue: https://github.com/apache/trafficserver/pull/1328 Are you guys comfortable with cherry-picking this to 7.1.0? --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project does

[GitHub] trafficserver issue #1355: TS-4716: OpenBSD mandir should be ${prefix}/man

2017-01-23 Thread zwoop
Github user zwoop commented on the issue: https://github.com/apache/trafficserver/pull/1355 Question: Why is this PR also modifying the Debian layout? That seems slightly non-intuitive considering the Summary from the PR (OpenBSD). --- If your project is set up for it, you can reply

[GitHub] trafficserver issue #1350: TS-5080: log when remap.config is successfully re...

2017-01-23 Thread zwoop
Github user zwoop commented on the issue: https://github.com/apache/trafficserver/pull/1350 Seems FreeBSD / clang is finicky on one of the strings. --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project does

[GitHub] trafficserver issue #1366: Issue #1360: REGRESSION_TEST(SDK_API_OVERRIDABLE_...

2017-01-23 Thread zwoop
Github user zwoop commented on the issue: https://github.com/apache/trafficserver/pull/1366 7.1.0 candidate? --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project does not have this feature enabled and wishes

[GitHub] trafficserver issue #1355: TS-4716: OpenBSD mandir should be ${prefix}/man

2017-01-23 Thread zwoop
Github user zwoop commented on the issue: https://github.com/apache/trafficserver/pull/1355 I'm marking this for 7.1.0, since it's mostly benign, and generally useful. --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well

[GitHub] trafficserver issue #1364: Issue #1359: Flaw in TS-2157 port in server addre...

2017-01-23 Thread zwoop
Github user zwoop commented on the issue: https://github.com/apache/trafficserver/pull/1364 Is this a 7.1.0 back port candidate? --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project does not have this feature

[GitHub] trafficserver issue #1357: TS-5022: reduce memory allocation in clientcert l...

2017-01-23 Thread zwoop
Github user zwoop commented on the issue: https://github.com/apache/trafficserver/pull/1357 This has to go into 7.1.0 as well, since we already landed previous tries :). --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well

[GitHub] trafficserver issue #1350: TS-5080: log when remap.config is successfully re...

2017-01-23 Thread zwoop
Github user zwoop commented on the issue: https://github.com/apache/trafficserver/pull/1350 [approve ci] --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project does not have this feature enabled and wishes so

[GitHub] trafficserver issue #1350: TS-5080: log when remap.config is successfully re...

2017-01-20 Thread zwoop
Github user zwoop commented on the issue: https://github.com/apache/trafficserver/pull/1350 [approve ci] --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project does not have this feature enabled and wishes so

[GitHub] trafficserver issue #1349: TS-5079: logging enhancements around OCSP

2017-01-20 Thread zwoop
Github user zwoop commented on the issue: https://github.com/apache/trafficserver/pull/1349 [approve ci] --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project does not have this feature enabled and wishes so

[GitHub] trafficserver issue #1336: cache promote plugin takes too much calculating s...

2017-01-20 Thread zwoop
Github user zwoop closed the issue at: https://github.com/apache/trafficserver/issues/1336 --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project does not have this feature enabled and wishes so, or if the feature

[GitHub] trafficserver pull request #1337: This avoids some badness around some STL i...

2017-01-20 Thread zwoop
Github user zwoop closed the pull request at: https://github.com/apache/trafficserver/pull/1337 --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project does not have this feature enabled and wishes so, or if the feature

[GitHub] trafficserver issue #1352: Documentation for volume.config is confusing and ...

2017-01-20 Thread zwoop
GitHub user zwoop opened an issue: https://github.com/apache/trafficserver/issues/1352 Documentation for volume.config is confusing and obsolete In particular, the example with scheme=http / scheme=https is invalid, there's only one protocol that's supported, http (for all HTTP

[GitHub] trafficserver issue #1327: get_creation_time() takes *time_t, not *long

2017-01-19 Thread zwoop
Github user zwoop commented on the issue: https://github.com/apache/trafficserver/pull/1327 Merged this to the 7.1.x branch as well --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project does not have

[GitHub] trafficserver issue #1347: TS-5022: nullptr check

2017-01-19 Thread zwoop
Github user zwoop commented on the issue: https://github.com/apache/trafficserver/pull/1347 Merged this to the 7.1.x branch as well --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project does not have

[GitHub] trafficserver issue #1343: Change connect_attempts_rr_retries test to match ...

2017-01-19 Thread zwoop
Github user zwoop commented on the issue: https://github.com/apache/trafficserver/pull/1343 Merged this to the 7.1.x branch as well --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project does not have

[GitHub] trafficserver issue #1334: Do not reschedule the periodic inactive_event and...

2017-01-19 Thread zwoop
Github user zwoop commented on the issue: https://github.com/apache/trafficserver/pull/1334 Merged this to the 7.1.x branch as well. --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project does not have

[GitHub] trafficserver issue #1332: Updates to cache documentation and Cache Tool.

2017-01-19 Thread zwoop
Github user zwoop commented on the issue: https://github.com/apache/trafficserver/pull/1332 As we discussed, this ought to go into the "cmd" directory, and renamed traffic_cachetool or some such. --- If your project is set up for it, you can reply to this email and have

[GitHub] trafficserver issue #1340: new warning running 7.1

2017-01-19 Thread zwoop
Github user zwoop closed the issue at: https://github.com/apache/trafficserver/issues/1340 --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project does not have this feature enabled and wishes so, or if the feature

[GitHub] trafficserver pull request #1343: Change connect_attempts_rr_retries test to...

2017-01-19 Thread zwoop
Github user zwoop closed the pull request at: https://github.com/apache/trafficserver/pull/1343 --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project does not have this feature enabled and wishes so, or if the feature

[GitHub] trafficserver issue #1343: Change connect_attempts_rr_retries test to match ...

2017-01-18 Thread zwoop
Github user zwoop commented on the issue: https://github.com/apache/trafficserver/pull/1343 [approve ci] --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project does not have this feature enabled and wishes so

[GitHub] trafficserver issue #1341: openssl errors for every request

2017-01-18 Thread zwoop
Github user zwoop commented on the issue: https://github.com/apache/trafficserver/issues/1341 Looking at 63b924e8, it seems we produce this error, and do these expensive lookups / additions on every request? ```C++ @@ -4018,7 +4020,7 @@ HttpSM::do_remap_request(bool

[GitHub] trafficserver issue #1320: Modify TSHttpTxnHookAdd to add hook only once

2017-01-18 Thread zwoop
Github user zwoop commented on the issue: https://github.com/apache/trafficserver/pull/1320 Not going to do the reverts here, but please be careful going forward with squashing commits that are fixes / review comments. --- If your project is set up for it, you can reply

[GitHub] trafficserver pull request #1339: Revert "Modify TSHttpTxnHookAdd to add hoo...

2017-01-18 Thread zwoop
Github user zwoop closed the pull request at: https://github.com/apache/trafficserver/pull/1339 --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project does not have this feature enabled and wishes so, or if the feature

[GitHub] trafficserver pull request #1339: Revert "Modify TSHttpTxnHookAdd to add hoo...

2017-01-18 Thread zwoop
GitHub user zwoop opened a pull request: https://github.com/apache/trafficserver/pull/1339 Revert "Modify TSHttpTxnHookAdd to add hook only once" Reverts apache/trafficserver#1320 You can merge this pull request into a Git repository by running: $ git pull https://

[GitHub] trafficserver pull request #1338: Revert "Modify TSHttpTxnHookAdd to add hoo...

2017-01-18 Thread zwoop
GitHub user zwoop opened a pull request: https://github.com/apache/trafficserver/pull/1338 Revert "Modify TSHttpTxnHookAdd to add hook only once" Reverts apache/trafficserver#1320 You can merge this pull request into a Git repository by running: $ git pull https://

[GitHub] trafficserver pull request #1338: Revert "Modify TSHttpTxnHookAdd to add hoo...

2017-01-18 Thread zwoop
Github user zwoop closed the pull request at: https://github.com/apache/trafficserver/pull/1338 --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project does not have this feature enabled and wishes so, or if the feature

[GitHub] trafficserver issue #1320: Modify TSHttpTxnHookAdd to add hook only once

2017-01-18 Thread zwoop
Github user zwoop commented on the issue: https://github.com/apache/trafficserver/pull/1320 Well, dammit, I screwed up, this really shouldn't have been merged, you really must squash multiple commits like this into one commit (now I landed one commit that is not correct

[GitHub] trafficserver pull request #1320: Modify TSHttpTxnHookAdd to add hook only o...

2017-01-18 Thread zwoop
Github user zwoop closed the pull request at: https://github.com/apache/trafficserver/pull/1320 --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project does not have this feature enabled and wishes so, or if the feature

[GitHub] trafficserver issue #1320: Modify TSHttpTxnHookAdd to add hook only once

2017-01-18 Thread zwoop
Github user zwoop commented on the issue: https://github.com/apache/trafficserver/pull/1320 [approve ci] --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project does not have this feature enabled and wishes so

[GitHub] trafficserver pull request #1337: This avoids some badness around some STL i...

2017-01-18 Thread zwoop
GitHub user zwoop opened a pull request: https://github.com/apache/trafficserver/pull/1337 This avoids some badness around some STL implementations Where the complexity of ::size is not O(1) Can someone please carefully review that I did the ++'s and --'s in all

[GitHub] trafficserver issue #1335: Deadlock in HostDB

2017-01-18 Thread zwoop
GitHub user zwoop opened an issue: https://github.com/apache/trafficserver/issues/1335 Deadlock in HostDB We have some 7.0.0 boxes, which ends up completely wedged, where all ET_NET threads get stuck on the same lock (so, a deadlock): ``` #6 HostDBProcessor

[GitHub] trafficserver issue #1320: Modify TSHttpTxnHookAdd to add hook only once

2017-01-17 Thread zwoop
Github user zwoop commented on the issue: https://github.com/apache/trafficserver/pull/1320 @meeramn Can you re-run clang-format and update the PR please? --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project

[GitHub] trafficserver issue #1320: Modify TSHttpTxnHookAdd to add hook only once

2017-01-17 Thread zwoop
Github user zwoop commented on the issue: https://github.com/apache/trafficserver/pull/1320 [approve ci] --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project does not have this feature enabled and wishes so

[GitHub] trafficserver issue #1323: NULL in records.config being interpreted as a str...

2017-01-13 Thread zwoop
Github user zwoop closed the issue at: https://github.com/apache/trafficserver/issues/1323 --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project does not have this feature enabled and wishes so, or if the feature

[GitHub] trafficserver pull request #1325: #1323 Restores the NULL string where appro...

2017-01-13 Thread zwoop
Github user zwoop closed the pull request at: https://github.com/apache/trafficserver/pull/1325 --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project does not have this feature enabled and wishes so, or if the feature

[GitHub] trafficserver pull request #1325: #1323 Restores the NULL string where appro...

2017-01-13 Thread zwoop
Github user zwoop commented on a diff in the pull request: https://github.com/apache/trafficserver/pull/1325#discussion_r96107247 --- Diff: lib/records/RecUtils.cc --- @@ -419,7 +419,7 @@ RecDataSetFromString(RecDataT data_type, RecData *data_dst, const char *data_str

[GitHub] trafficserver issue #1325: #1323 Restores the NULL string where appropriate

2017-01-13 Thread zwoop
Github user zwoop commented on the issue: https://github.com/apache/trafficserver/pull/1325 Any takers on reviewing this? --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project does not have this feature enabled

[GitHub] trafficserver issue #1326: Core dump in SSLAccept / SSLNetVConnection::sslSe...

2017-01-13 Thread zwoop
GitHub user zwoop opened an issue: https://github.com/apache/trafficserver/issues/1326 Core dump in SSLAccept / SSLNetVConnection::sslServerHandShakeEvent We (@randall) ran into an odd crashes that seems fairly similar (but not identical) to https://issues.apache.org/jira/browse/TS

[GitHub] trafficserver issue #1320: Modify TSHttpTxnHookAdd to add hook only once

2017-01-13 Thread zwoop
Github user zwoop commented on the issue: https://github.com/apache/trafficserver/pull/1320 Marking this for 7.1.0, we really need this in. --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project does not have

[GitHub] trafficserver issue #1319: 7.0.x TS-5059: Fixes for building with OpenSSL 1....

2017-01-13 Thread zwoop
Github user zwoop commented on the issue: https://github.com/apache/trafficserver/pull/1319 Mr (!) The Oil Rig, ( :-) ) did you check with @bryancall if he's planning a 7.0.1 release? if not, this is a moot point, 7.1.x will hopefully be released in 4 weeks. --- If your

[GitHub] trafficserver pull request #1324: issue-1323: fix RecDataset

2017-01-13 Thread zwoop
Github user zwoop closed the pull request at: https://github.com/apache/trafficserver/pull/1324 --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project does not have this feature enabled and wishes so, or if the feature

[GitHub] trafficserver pull request #1325: #1323 Restores the NULL string where appro...

2017-01-13 Thread zwoop
GitHub user zwoop opened a pull request: https://github.com/apache/trafficserver/pull/1325 #1323 Restores the NULL string where appropriate You can merge this pull request into a Git repository by running: $ git pull https://github.com/zwoop/trafficserver #1323 Alternatively

[GitHub] trafficserver issue #1324: issue-1323: fix RecDataset

2017-01-12 Thread zwoop
Github user zwoop commented on the issue: https://github.com/apache/trafficserver/pull/1324 Albeit reasonable, I don't think we should land this. There's a number of places from ced4da13279f834c381925f2ecd1649bfb459e8b which changes "NULL" to "nullptr" acciden

[GitHub] trafficserver issue #1323: NULL in records.config being interpreted as a str...

2017-01-12 Thread zwoop
Github user zwoop commented on the issue: https://github.com/apache/trafficserver/issues/1323 I think this got broken with ced4da13279f834c381925f2ecd1649bfb459e8b. --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your

[GitHub] trafficserver issue #1322: Possibly crasher in HostDB serialization (disk sy...

2017-01-12 Thread zwoop
Github user zwoop commented on the issue: https://github.com/apache/trafficserver/issues/1322 Pretty sure they had been running for a while (several days at least), but let me check. --- If your project is set up for it, you can reply to this email and have your reply appear

[GitHub] trafficserver issue #1322: Possibly crasher in HostDB serialization (disk sy...

2017-01-12 Thread zwoop
GitHub user zwoop opened an issue: https://github.com/apache/trafficserver/issues/1322 Possibly crasher in HostDB serialization (disk sync) Hi Thomas, we're seeing this odd looking crash, fairly often: ``` #0 0x2d74337d in __libc_waitpid (pid

[GitHub] trafficserver pull request #1316: TS-5022: remove goto in SSLConfig : getnew...

2017-01-10 Thread zwoop
Github user zwoop closed the pull request at: https://github.com/apache/trafficserver/pull/1316 --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project does not have this feature enabled and wishes so, or if the feature

[GitHub] trafficserver issue #1276: TS-5105: Do vc->con.setRemote(target) before sock...

2017-01-07 Thread zwoop
Github user zwoop commented on the issue: https://github.com/apache/trafficserver/pull/1276 Trying a new build [approve ci] --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project does not have this feature

[GitHub] trafficserver issue #1305: CID 1368316 Resource leak

2017-01-07 Thread zwoop
Github user zwoop commented on the issue: https://github.com/apache/trafficserver/issues/1305 Closing this as a dupe of #1308, since it has more details. --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project

[GitHub] trafficserver issue #1305: CID 1368316 Resource leak

2017-01-07 Thread zwoop
Github user zwoop closed the issue at: https://github.com/apache/trafficserver/issues/1305 --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project does not have this feature enabled and wishes so, or if the feature

[GitHub] trafficserver issue #1308: CID 1368316 & 1368315: Leaks and NULL references

2017-01-07 Thread zwoop
GitHub user zwoop opened an issue: https://github.com/apache/trafficserver/issues/1308 CID 1368316 & 1368315: Leaks and NULL references I think this landed recently (TS-5092?), and we have to fix this for 7.1.x. clang-analyzer also detects the NULL pointer reference.

[GitHub] trafficserver issue #1303: TS-5107: Changes to autolinking in Docutils 1.3

2017-01-07 Thread zwoop
Github user zwoop commented on the issue: https://github.com/apache/trafficserver/pull/1303 We need into 7.1.x as well, right? --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project does not have this feature

[GitHub] trafficserver issue #1306: [openbsd] pthread_np.h needs to be included

2017-01-07 Thread zwoop
Github user zwoop commented on the issue: https://github.com/apache/trafficserver/issues/1306 Yeh, I agree with peach, it seems very odd that it's not picking it up properly. It'd be better to fix that, instead of ifdef on openbsd IMO. --- If your project is set up for it, you can

[GitHub] trafficserver issue #1301: Can trafficserver proxy to another proxy?

2017-01-06 Thread zwoop
Github user zwoop commented on the issue: https://github.com/apache/trafficserver/issues/1301 This really belongs on the us...@trafficserver.apache.org mailing list. I'm going to close this, but the short answer is that you could use the parent.config instead of remap. --- If your

[GitHub] trafficserver issue #1301: Can trafficserver proxy to another proxy?

2017-01-06 Thread zwoop
Github user zwoop closed the issue at: https://github.com/apache/trafficserver/issues/1301 --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project does not have this feature enabled and wishes so, or if the feature

[GitHub] trafficserver issue #1302: CID 1368306 & 1368305: NULLPTR and security BP in...

2017-01-06 Thread zwoop
GitHub user zwoop opened an issue: https://github.com/apache/trafficserver/issues/1302 CID 1368306 & 1368305: NULLPTR and security BP in logical.cc ```c ** CID 1368306: Security best practices violations (TOCTOU) /proxy/logcat.cc: 299 in

[GitHub] trafficserver issue #1257: TS-5053 const char **argv passed to TSPluginInit ...

2017-01-03 Thread zwoop
Github user zwoop commented on the issue: https://github.com/apache/trafficserver/pull/1257 [add to whitelist] --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project does not have this feature enabled and wishes

[GitHub] trafficserver issue #1299: TS-2888: remove vararg and format parameters from...

2017-01-03 Thread zwoop
Github user zwoop commented on the issue: https://github.com/apache/trafficserver/pull/1299 [add to whitelist] --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project does not have this feature enabled and wishes

[GitHub] trafficserver issue #1276: TS-5105: Do vc->con.setRemote(target) before sock...

2017-01-03 Thread zwoop
Github user zwoop commented on the issue: https://github.com/apache/trafficserver/pull/1276 Marking this for 6.2.2 for now, unless we need to respond 6.2.1? Also, this has build issues I think? --- If your project is set up for it, you can reply to this email and have your reply

[GitHub] trafficserver issue #1298: traffic_server deadlocked after config reload

2017-01-03 Thread zwoop
Github user zwoop commented on the issue: https://github.com/apache/trafficserver/issues/1298 @randall We only saw this once so far, right? It might be worth trying turning off HostDB syncing again, now that we can do that (supposedly safely) in 7.x ? --- If your project is set up

[GitHub] trafficserver issue #1294: TS-5059: Port TCP Fast Open BIO to OpenSSL 1.1.0

2017-01-03 Thread zwoop
Github user zwoop commented on the issue: https://github.com/apache/trafficserver/pull/1294 I'm seeing e.g. ``` BIO_fastopen.cc: In function 'int fastopen_create(BIO*)': BIO_fastopen.cc:48:11: error: 'BIO' has no member named 'data' BIO_set_data(bio, data

[GitHub] trafficserver issue #1294: TS-5059: Port TCP Fast Open BIO to OpenSSL 1.1.0

2017-01-03 Thread zwoop
Github user zwoop commented on the issue: https://github.com/apache/trafficserver/pull/1294 [add to whitelist] --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project does not have this feature enabled and wishes

[GitHub] trafficserver issue #1297: ISSUE 1283: Fix CID 1367526 and CID 1367525 in mo...

2017-01-03 Thread zwoop
Github user zwoop commented on the issue: https://github.com/apache/trafficserver/pull/1297 I think the Jenkins master was wedged, trying a new build [approve ci]. --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your

[GitHub] trafficserver issue #1282: CID 1367527: Program hangs (SLEEP): cluster/Clust...

2016-12-30 Thread zwoop
Github user zwoop commented on the issue: https://github.com/apache/trafficserver/issues/1282 Do we just ignore /kill all clustering issues? --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project does not have

[GitHub] trafficserver issue #1292: CID 1367515, CID 1367514, CID 1367513: ts_lua plu...

2016-12-30 Thread zwoop
Github user zwoop commented on the issue: https://github.com/apache/trafficserver/issues/1292 Meh, there's already a PR for this, nm. --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project does not have

[GitHub] trafficserver issue #1292: CID 1367515, CID 1367514, CID 1367513: ts_lua plu...

2016-12-30 Thread zwoop
Github user zwoop closed the issue at: https://github.com/apache/trafficserver/issues/1292 --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project does not have this feature enabled and wishes so, or if the feature

[GitHub] trafficserver issue #1292: CID 1367515, CID 1367514, CID 1367513: ts_lua plu...

2016-12-30 Thread zwoop
GitHub user zwoop opened an issue: https://github.com/apache/trafficserver/issues/1292 CID 1367515, CID 1367514, CID 1367513: ts_lua plugin ``` *** CID 1367515: Error handling issues (CHECKED_RETURN) /plugins/experimental/ts_lua/ts_lua_server_response.c: 354

[GitHub] trafficserver issue #1291: CID 1196420: Error handling issues (CHECKED_RETUR...

2016-12-30 Thread zwoop
GitHub user zwoop opened an issue: https://github.com/apache/trafficserver/issues/1291 CID 1196420: Error handling issues (CHECKED_RETURN): proxy/CoreUtils.cc ``` *** CID 1196420: Error handling issues (CHECKED_RETURN) /proxy/CoreUtils.cc: 482 in CoreUtils

[GitHub] trafficserver issue #1290: CID 1367516: Null pointer dereferences (FORWARD_N...

2016-12-30 Thread zwoop
GitHub user zwoop opened an issue: https://github.com/apache/trafficserver/issues/1290 CID 1367516: Null pointer dereferences (FORWARD_NULL): wccp/WccpConfig.cc ``` *** CID 1367516: Null pointer dereferences (FORWARD_NULL) /lib/wccp/WccpConfig.cc: 528 in wccp::CacheImpl

[GitHub] trafficserver issue #1289: CID 1367517: API usage errors (LOCK): mgmt/FileMa...

2016-12-30 Thread zwoop
GitHub user zwoop opened an issue: https://github.com/apache/trafficserver/issues/1289 CID 1367517: API usage errors (LOCK): mgmt/FileManager.cc ``` *** CID 1367517: API usage errors (LOCK) /mgmt/FileManager.cc: 97 in FileManager::~FileManager()() 91 92

[GitHub] trafficserver issue #1288: CID 1367518: (LOCK): records/P_RecCore.cc

2016-12-30 Thread zwoop
GitHub user zwoop opened an issue: https://github.com/apache/trafficserver/issues/1288 CID 1367518:(LOCK): records/P_RecCore.cc ``` *** CID 1367518:(LOCK) /lib/records/P_RecCore.cc: 751 in RecSyncConfigToTB(textBuffer *, bool *)() 745 break

[GitHub] trafficserver issue #1287: CID 1367519: Low impact quality (MISSING_MOVE_ASS...

2016-12-30 Thread zwoop
GitHub user zwoop opened an issue: https://github.com/apache/trafficserver/issues/1287 CID 1367519: Low impact quality (MISSING_MOVE_ASSIGNMENT): ts/ink_memory.h ``` *** CID 1367519: Low impact quality (MISSING_MOVE_ASSIGNMENT) /lib/ts/ink_memory.h: 242 in () 236

[GitHub] trafficserver issue #1286: CID 1367521: Low impact quality (MISSING_MOVE_ASS...

2016-12-30 Thread zwoop
GitHub user zwoop opened an issue: https://github.com/apache/trafficserver/issues/1286 CID 1367521: Low impact quality (MISSING_MOVE_ASSIGNMENT): tsconfig/Errata.h and tsconfig/TsValue.h ``` *** CID 1367521: Low impact quality (MISSING_MOVE_ASSIGNMENT) /lib/tsconfig

[GitHub] trafficserver issue #1285: CID 1367522: (MISSING_MOVE_ASSIGNMENT): /ts/Ptr.h

2016-12-30 Thread zwoop
GitHub user zwoop opened an issue: https://github.com/apache/trafficserver/issues/1285 CID 1367522:(MISSING_MOVE_ASSIGNMENT): /ts/Ptr.h ``` *** CID 1367522:(MISSING_MOVE_ASSIGNMENT) /lib/ts/Ptr.h: 101 in () 95 96

<    1   2   3   4   5   6   7   8   9   >