GitHub user zwoop opened an issue:
https://github.com/apache/trafficserver/issues/1284
CID 1367523:(MISSING_MOVE_ASSIGNMENT): tsconfig/IntrusivePtr.
```
*** CID 1367523:(MISSING_MOVE_ASSIGNMENT)
/lib/tsconfig/IntrusivePtr.h: 134 in ()
128 ownded by a set
GitHub user zwoop opened an issue:
https://github.com/apache/trafficserver/issues/1283
CID 1367526: CID 1367525 : money_trace/money_trace.cc
```
*** CID 1367526: Null pointer dereferences (REVERSE_INULL)
/plugins/experimental/money_trace/money_trace.cc: 57
GitHub user zwoop opened an issue:
https://github.com/apache/trafficserver/issues/1282
CID 1367527: Program hangs (SLEEP): cluster/ClusterCom.cc
```
*** CID 1367527: Program hangs (SLEEP)
/mgmt/cluster/ClusterCom.cc: 1953 in
ClusterCom::sendReliableMessage(unsigned long
GitHub user zwoop opened an issue:
https://github.com/apache/trafficserver/issues/1281
CID 1367528: Security best practices violations (STRING_OVERFLOW):
http/HttpTransactHeaders.cc
```
*** CID 1367528: Security best practices violations (STRING_OVERFLOW)
/proxy/http
GitHub user zwoop opened an issue:
https://github.com/apache/trafficserver/issues/1280
CID 1367529: Security best practices violations (STRING_OVERFLOW):
url_sig/url_sig.c
```
*** CID 1367529: Security best practices violations (STRING_OVERFLOW)
/plugins/experimental
GitHub user zwoop opened an issue:
https://github.com/apache/trafficserver/issues/1279
CID 1367531: Uninitialized members (UNINIT_CTOR): proxy/main.cc
```
*** CID 1367531: Uninitialized members (UNINIT_CTOR)
/proxy/Main.cc: 352 in MemoryLimit::MemoryLimit()()
346
Github user zwoop closed the pull request at:
https://github.com/apache/trafficserver/pull/1273
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature
Github user zwoop commented on the issue:
https://github.com/apache/trafficserver/pull/1273
Try again [approve ci]
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled
GitHub user zwoop opened a pull request:
https://github.com/apache/trafficserver/pull/1273
TS-5030: Fixes the sizeof issues, adds a constant
You can merge this pull request into a Git repository by running:
$ git pull https://github.com/zwoop/trafficserver TS-5030
Github user zwoop commented on the issue:
https://github.com/apache/trafficserver/pull/1184
I'm gonna merge this, and fix the clang-format separately. Please make an
effort to always run clang-format though :).
---
If your project is set up for it, you can reply to this email
Github user zwoop closed the pull request at:
https://github.com/apache/trafficserver/pull/1184
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature
Github user zwoop commented on the issue:
https://github.com/apache/trafficserver/pull/1184
This needs to run clang-format again. Please rebase and push the PR again,
and I'll land it.
---
If your project is set up for it, you can reply to this email and have your
reply appear
Github user zwoop commented on the issue:
https://github.com/apache/trafficserver/pull/1224
This needs to run clang-format again. Please rebase and push the PR again,
and I'll land it.
---
If your project is set up for it, you can reply to this email and have your
reply appear
Github user zwoop commented on the issue:
https://github.com/apache/trafficserver/pull/1184
[approve ci]
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so
Github user zwoop closed the pull request at:
https://github.com/apache/trafficserver/pull/996
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature
Github user zwoop closed the pull request at:
https://github.com/apache/trafficserver/pull/1261
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature
GitHub user zwoop opened a pull request:
https://github.com/apache/trafficserver/pull/1265
TS-5087: Updates the AL2 license on all .po files
Cherry picks from master.
You can merge this pull request into a Git repository by running:
$ git pull https://github.com/zwoop
Github user zwoop commented on the issue:
https://github.com/apache/trafficserver/pull/1259
Nice! Any details on what the impact / symptoms for this is?
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project
Github user zwoop closed the pull request at:
https://github.com/apache/trafficserver/pull/1256
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature
Github user zwoop closed the pull request at:
https://github.com/apache/trafficserver/pull/1255
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature
GitHub user zwoop opened a pull request:
https://github.com/apache/trafficserver/pull/1256
TS-2109: Allows CC: no-cache objects to be stored in cache
However, we still honor the no-cache header, such that we perform an IMS
request against the origin to validate the request
GitHub user zwoop opened a pull request:
https://github.com/apache/trafficserver/pull/1255
TS-5087: Updates the AL2 license on all .po files
You can merge this pull request into a Git repository by running:
$ git pull https://github.com/zwoop/trafficserver TS-5087
Github user zwoop commented on the issue:
https://github.com/apache/trafficserver/pull/1252
Hmmm, it seems we are incredibly inconsistent here. Why singling out this
one place for this change? Do we really need TS_INLINE in general? I notice we
turn off inlining via #define in some
Github user zwoop closed the pull request at:
https://github.com/apache/trafficserver/pull/1247
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature
Github user zwoop closed the pull request at:
https://github.com/apache/trafficserver/pull/1249
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature
Github user zwoop commented on the issue:
https://github.com/apache/trafficserver/pull/1249
[approve ci]
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so
GitHub user zwoop opened a pull request:
https://github.com/apache/trafficserver/pull/1247
TS-5078: Support MADV_DONTDUMP even when the freelist is disabled
I'm a little bit on this ice here, Phil already gave advice on some
details, but this should be properly reviewed (of course
Github user zwoop commented on the issue:
https://github.com/apache/trafficserver/pull/1245
[approve ci]
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so
Github user zwoop commented on the issue:
https://github.com/apache/trafficserver/pull/1229
Well dammit, I screwed up, this PR was against the 7.0.x branch :-/ Can you
please make a new PR against master please? I will undo the 7.0.x commit.
---
If your project is set up for it, you
Github user zwoop commented on the issue:
https://github.com/apache/trafficserver/pull/1209
@SolidWallOfCode Did you make the fixes to the unit tests ?
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does
Github user zwoop closed the pull request at:
https://github.com/apache/trafficserver/pull/1229
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature
Github user zwoop closed the pull request at:
https://github.com/apache/trafficserver/pull/1246
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature
Github user zwoop commented on the issue:
https://github.com/apache/trafficserver/pull/1245
clang-format :).
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes
GitHub user zwoop opened a pull request:
https://github.com/apache/trafficserver/pull/1246
TS-5069: Fixes CID 1366771 and 1366771
These might be older, but this last batch of commits in TS-5069 triggers
Coverity.
You can merge this pull request into a Git repository by running
Github user zwoop commented on the issue:
https://github.com/apache/trafficserver/pull/1243
5.3.x is end-of-lifed, we're not doing any more releases of that.
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your
Github user zwoop commented on the issue:
https://github.com/apache/trafficserver/pull/1243
This might honestly be a back port candidate? Does this apply to 7.0.x as
well as 6.2.x ?
---
If your project is set up for it, you can reply to this email and have your
reply appear
Github user zwoop commented on the issue:
https://github.com/apache/trafficserver/pull/1229
[approve ci]
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so
Github user zwoop closed the pull request at:
https://github.com/apache/trafficserver/pull/1239
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature
Github user zwoop commented on the issue:
https://github.com/apache/trafficserver/pull/1227
@sekimura You want to take stab at adding this as Lua definitions? I
assume the intent would be to expose some of these constants in an internal Lua
table?
---
If your project is set up
Github user zwoop commented on the issue:
https://github.com/apache/trafficserver/pull/1050
It's fixed elsewhere?
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled
Github user zwoop commented on a diff in the pull request:
https://github.com/apache/trafficserver/pull/1239#discussion_r90559251
--- Diff: proxy/logstats.cc ---
@@ -1164,16 +1167,64 @@ update_schemes(OriginStats *stat, int scheme, int
size
Github user zwoop commented on a diff in the pull request:
https://github.com/apache/trafficserver/pull/1239#discussion_r90557544
--- Diff: proxy/logstats.cc ---
@@ -594,15 +594,16 @@ struct CommandLineArgs {
int64_t min_hits;
int max_age;
int line_len
Github user zwoop commented on the issue:
https://github.com/apache/trafficserver/issues/1237
I think think you can set a timeout
(proxy.config.http.transaction_active_timeout_in) which doesn't care if data is
being sent or not (it's a "hard" timeout on an active
Github user zwoop commented on the issue:
https://github.com/apache/trafficserver/pull/1241
Seems two issues here:
1. clang-format
1. FreeBSD doesn't have a T_DNAME ?
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub
Github user zwoop commented on the issue:
https://github.com/apache/trafficserver/pull/1236
[approve ci]
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so
Github user zwoop closed the pull request at:
https://github.com/apache/trafficserver/pull/1240
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature
Github user zwoop commented on the issue:
https://github.com/apache/trafficserver/pull/1240
How about this too:
```
diff --git a/ci/jenkins/bin/docs.sh b/ci/jenkins/bin/docs.sh
index 6754040..f5b2a17 100644
--- a/ci/jenkins/bin/docs.sh
+++ b/ci/jenkins/bin
Github user zwoop commented on the issue:
https://github.com/apache/trafficserver/pull/1239
I landed my changes, so now you have to resolve the conflicts. Sorry bro. :)
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well
Github user zwoop closed the pull request at:
https://github.com/apache/trafficserver/pull/1238
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature
GitHub user zwoop opened a pull request:
https://github.com/apache/trafficserver/pull/1238
TS-4429: Adds a --terse (-e) option for logstats, excludes % metrics
You can merge this pull request into a Git repository by running:
$ git pull https://github.com/zwoop/trafficserver
Github user zwoop commented on the issue:
https://github.com/apache/trafficserver/pull/1235
Which Jira is this for ?
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled
Github user zwoop closed the pull request at:
https://github.com/apache/trafficserver/pull/1234
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature
Github user zwoop commented on the issue:
https://github.com/apache/trafficserver/pull/1234
I think this will clear the clang analyzer errors too.
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does
Github user zwoop commented on the issue:
https://github.com/apache/trafficserver/pull/1227
Hmmm, logging most metrics seems somewhat useless. What would be useful
would be to have generic access to the underlying data that is used to update
the metrics for that transactions
Github user zwoop commented on a diff in the pull request:
https://github.com/apache/trafficserver/pull/1234#discussion_r89405035
--- Diff: mgmt/LocalManager.cc ---
@@ -950,29 +949,27 @@ LocalManager::startProxy(const char *onetime_options)
if (open_ports_p
Github user zwoop commented on the issue:
https://github.com/apache/trafficserver/pull/1229
This needs to be updated with clang-format. Easiest is to just run
$ make clang-format
and then push the branch again to update the PR.
---
If your project is set up
GitHub user zwoop opened a pull request:
https://github.com/apache/trafficserver/pull/1234
TS-5063: Fixes coverity warnings and cleans up the temp string
The Vec seems overkill here, and makes things less nice when
managing the intermediary strings. The new code has issues
Github user zwoop commented on the issue:
https://github.com/apache/trafficserver/pull/1225
Can we put this into tools/reports ? There's one other similar tool in
there.
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well
Github user zwoop commented on the issue:
https://github.com/apache/trafficserver/pull/1184
I'm still not convinced this is a particularly useful API, but it's also
fairly benign. However, I do feel that if we are going to do this, we should
make the prototype something like
Github user zwoop commented on the issue:
https://github.com/apache/trafficserver/pull/1218
Please add Milestones, Labels etc...
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
Github user zwoop commented on a diff in the pull request:
https://github.com/apache/trafficserver/pull/1212#discussion_r87417967
--- Diff: iocore/net/SSLUtils.cc ---
@@ -141,8 +142,9 @@ static int ssl_vc_index = -1;
static ink_mutex *mutex_buf = nullptr;
static bool
Github user zwoop commented on the issue:
https://github.com/apache/trafficserver/pull/1214
I'm going to test this on Docs.
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
Github user zwoop commented on the issue:
https://github.com/apache/trafficserver/pull/1197
Set the tags to the right please :).
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
Github user zwoop commented on the issue:
https://github.com/apache/trafficserver/pull/1184
Set the tags to the right please :).
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
Github user zwoop commented on the issue:
https://github.com/apache/trafficserver/pull/1201
Set the tags to the right please :).
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
Github user zwoop commented on the issue:
https://github.com/apache/trafficserver/pull/1210
Not sure what happened with my final review message, but I'd suggest
looking at dump_headers() in e.g. plugins/background_fetch/headers.cc. It
cleanly dumps all headers into a buffer, which
Github user zwoop commented on a diff in the pull request:
https://github.com/apache/trafficserver/pull/1210#discussion_r86891158
--- Diff: plugins/experimental/log_requests/log_requests.c ---
@@ -0,0 +1,301 @@
+/** @file
+
+ Logs full request/response headers
Github user zwoop commented on the issue:
https://github.com/apache/trafficserver/pull/1209
@SolidWallOfCode You have to fix the unit tests too, in lib/ts/test_Map.cc.
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well
Github user zwoop closed the pull request at:
https://github.com/apache/trafficserver/pull/1198
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature
Github user zwoop commented on the issue:
https://github.com/apache/trafficserver/pull/1202
No docs for the new setting?
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled
Github user zwoop commented on the issue:
https://github.com/apache/trafficserver/pull/1197
Pretty sure I see other places where TCL hash is used, no? So this would
just make things worse, we'd get both TCL hash and STL hashes :-/.
---
If your project is set up for it, you can reply
Github user zwoop commented on the issue:
https://github.com/apache/trafficserver/pull/1197
Is this the only place where we use TCL hash now? If so, it seems we could
shoe horn something else here other than STL?
---
If your project is set up for it, you can reply to this email
Github user zwoop commented on the issue:
https://github.com/apache/trafficserver/pull/1193
How does this leak? If the constructor of LogObject fails?
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does
Github user zwoop closed the pull request at:
https://github.com/apache/trafficserver/pull/1185
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature
GitHub user zwoop opened a pull request:
https://github.com/apache/trafficserver/pull/1185
TS-5031: Use readdir() instead of readdir_r()
See http://lwn.net/Articles/696474/.
You can merge this pull request into a Git repository by running:
$ git pull https://github.com/zwoop
Github user zwoop commented on the issue:
https://github.com/apache/trafficserver/pull/1171
EventSystem.o
../../../iocore/eventsystem/EventSystem.cc:38:7: error: unused variable
'iobuffer_advice' [-Werror,-Wunused-variable]
int iobuffer_advice = 0
Github user zwoop closed the pull request at:
https://github.com/apache/trafficserver/pull/1166
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature
Github user zwoop commented on a diff in the pull request:
https://github.com/apache/trafficserver/pull/1166#discussion_r85968661
--- Diff: plugins/gzip/gzip.cc ---
@@ -480,8 +480,8 @@ gzip_transformable(TSHttpTxn txnp, bool server,
HostConfiguration *host_configur
Github user zwoop commented on a diff in the pull request:
https://github.com/apache/trafficserver/pull/1167#discussion_r85967946
--- Diff: lib/cppapi/Request.cc ---
@@ -177,6 +177,23 @@ Request::getHeaders() const
return state_->headers_;
}
+void
+Requ
Github user zwoop closed the pull request at:
https://github.com/apache/trafficserver/pull/1154
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature
GitHub user zwoop opened a pull request:
https://github.com/apache/trafficserver/pull/1166
TS-5024: Limits the gzip to 200 OK responses
You can merge this pull request into a Git repository by running:
$ git pull https://github.com/zwoop/trafficserver TS-5024
Alternatively
Github user zwoop closed the pull request at:
https://github.com/apache/trafficserver/pull/958
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature
Github user zwoop commented on the issue:
https://github.com/apache/trafficserver/pull/958
Meh, lets not do this.
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled
Github user zwoop commented on a diff in the pull request:
https://github.com/apache/trafficserver/pull/1164#discussion_r85624763
--- Diff: configure.ac ---
@@ -188,6 +188,14 @@ AC_ARG_ENABLE([werror],
)
AC_MSG_RESULT([$enable_werror])
+# Enable ASAN
Github user zwoop commented on the issue:
https://github.com/apache/trafficserver/pull/1164
Looks good to me. A future improvement would be that --enable-asan disables
the freelist. It's today pretty obnoxious to run with ASAN, since you have to
tell traffic_manager to pass along
Github user zwoop commented on the issue:
https://github.com/apache/trafficserver/pull/1152
[approve ci]
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so
Github user zwoop commented on the issue:
https://github.com/apache/trafficserver/pull/1154
@SolidWallOfCode I agree, file a lira :).
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have
Github user zwoop closed the pull request at:
https://github.com/apache/trafficserver/pull/963
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature
Github user zwoop commented on the issue:
https://github.com/apache/trafficserver/pull/996
@gtenev This is ready to land now, right ?
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have
Github user zwoop commented on the issue:
https://github.com/apache/trafficserver/pull/1120
Looks like we have merge conflicts now.
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have
Github user zwoop closed the pull request at:
https://github.com/apache/trafficserver/pull/1140
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature
Github user zwoop closed the pull request at:
https://github.com/apache/trafficserver/pull/1141
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature
Github user zwoop closed the pull request at:
https://github.com/apache/trafficserver/pull/1149
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature
Github user zwoop closed the pull request at:
https://github.com/apache/trafficserver/pull/1155
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature
Github user zwoop commented on the issue:
https://github.com/apache/trafficserver/pull/1158
Before committing this, I think we should at least squash the build fixes
such that there are not intermediate commit steps that are failing.
---
If your project is set up for it, you can
Github user zwoop commented on the issue:
https://github.com/apache/trafficserver/pull/1158
Neat! I wonder, maybe we should start naming these new config files with a
.lua extension? That makes editors much happier, and it makes logical sense
too. So, this could be named storage.lua
Github user zwoop commented on the issue:
https://github.com/apache/trafficserver/pull/1152
@ngara I think this is failing because of clang-format. I recommend you
copy the pre-commit githook into your .git/hooks tree.
---
If your project is set up for it, you can reply
Github user zwoop closed the pull request at:
https://github.com/apache/trafficserver/pull/1144
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature
Github user zwoop commented on the issue:
https://github.com/apache/trafficserver/pull/1152
[approve ci]
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so
Github user zwoop commented on the issue:
https://github.com/apache/trafficserver/pull/1155
[approve ci]
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so
401 - 500 of 896 matches
Mail list logo
