Github user zwoop commented on the issue:
https://github.com/apache/trafficserver/pull/943
:+1:
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so
Github user zwoop commented on the issue:
https://github.com/apache/trafficserver/pull/966
[approve ci]
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so
Github user zwoop commented on the issue:
https://github.com/apache/trafficserver/pull/887
@alhonen Whwere are we with this? Ready to merge? Seems we have a merge
conflict right now, so you'll need to fix that and git push --force again.
---
If your project is set up for it, you
Github user zwoop closed the pull request at:
https://github.com/apache/trafficserver/pull/803
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature
Github user zwoop commented on the issue:
https://github.com/apache/trafficserver/pull/959
I've tested this on OmniOS, and it compiled without problems. The changes
seems reasonable to me, but they are also massive so real difficult to know if
everything is correct :).
---
If your
Github user zwoop commented on the issue:
https://github.com/apache/trafficserver/pull/855
@bryongloden please address James' concern, and we can land this (after we
run it on the CI again).
---
If your project is set up for it, you can reply to this email and have your
reply appear
Github user zwoop commented on the issue:
https://github.com/apache/trafficserver/pull/877
[approve ci]
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so
Github user zwoop closed the pull request at:
https://github.com/apache/trafficserver/pull/950
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature
Github user zwoop closed the pull request at:
https://github.com/apache/trafficserver/pull/961
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature
Github user zwoop commented on the issue:
https://github.com/apache/trafficserver/pull/956
I'm ok with this, the sleep(1) in the main thread looks clunky as we
discussed, but whatevs.
---
If your project is set up for it, you can reply to this email and have your
reply appear
Github user zwoop commented on the issue:
https://github.com/apache/trafficserver/pull/961
I made that suggested change, going to land this unless there are
objections.
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well
Github user zwoop closed the pull request at:
https://github.com/apache/trafficserver/pull/893
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature
Github user zwoop closed the pull request at:
https://github.com/apache/trafficserver/pull/960
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature
Github user zwoop commented on the issue:
https://github.com/apache/trafficserver/pull/960
:+1:
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so
Github user zwoop commented on the issue:
https://github.com/apache/trafficserver/pull/960
Build again, VMs rebooted [approve ci]
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have
Github user zwoop commented on the issue:
https://github.com/apache/trafficserver/pull/960
[approve ci]
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so
Github user zwoop commented on the issue:
https://github.com/apache/trafficserver/pull/961
[approve ci]
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so
Github user zwoop commented on the issue:
https://github.com/apache/trafficserver/pull/961
So, this might look a little odd with removing the flags, but, first,
because of the wrong symbols, they weren't set before. And secondly, I tested
this with ASAN, and it compiles and runs fine
GitHub user zwoop opened a pull request:
https://github.com/apache/trafficserver/pull/961
TS-4810: Use the correct LuaJIT LDFLAGS
You can merge this pull request into a Git repository by running:
$ git pull https://github.com/zwoop/trafficserver TS-4810
Alternatively you can
Github user zwoop commented on the issue:
https://github.com/apache/trafficserver/pull/959
```C++
../../iocore/utils/diags.i: In function 'void reconfigure_diags()':
../../iocore/utils/diags.i:50:24: error: invalid conversion from 'int' to
'DiagsShowLocation' [-fpermissive
Github user zwoop closed the pull request at:
https://github.com/apache/trafficserver/pull/957
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature
Github user zwoop commented on the issue:
https://github.com/apache/trafficserver/pull/921
:+1:
Builds on OmniOS now (however, there's a LuaJIT error now).
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your
Github user zwoop commented on the issue:
https://github.com/apache/trafficserver/pull/893
[approve ci]
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so
Github user zwoop commented on the issue:
https://github.com/apache/trafficserver/pull/893
I'm not 100% certain that Coverity will think this is enough, but lets try.
@jpeach ok with this ?
---
If your project is set up for it, you can reply to this email and have your
reply appear
Github user zwoop commented on the issue:
https://github.com/apache/trafficserver/pull/872
This is failing on Linux because of clang-format. Please run "make
clang-format" and push again.
---
If your project is set up for it, you can reply to this email and have your
re
GitHub user zwoop opened a pull request:
https://github.com/apache/trafficserver/pull/958
TS-4449 Better errors and debug output
This does a few things:
1. Better error reports when parsing a config file
2. Better diagnostics when debugging expressions
I
Github user zwoop closed the pull request at:
https://github.com/apache/trafficserver/pull/953
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature
Github user zwoop commented on the issue:
https://github.com/apache/trafficserver/pull/957
Gah, FreeBSD is so finicky ... [approve ci]
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have
Github user zwoop commented on the issue:
https://github.com/apache/trafficserver/pull/893
Hmmm, still seeing branch merge conflicts :-/
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have
Github user zwoop commented on the issue:
https://github.com/apache/trafficserver/pull/930
@jacksontj Can you review the tsqa test portion please?
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does
Github user zwoop commented on the issue:
https://github.com/apache/trafficserver/pull/930
@jsime Thoughts?
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes
Github user zwoop commented on the issue:
https://github.com/apache/trafficserver/pull/954
@ericcarlschwartz
```C++
- if (s->state_machine->ua_session &&
(!strncmp(s->state_machine->ua_session->get_protocol_string(), "http/2",
Github user zwoop commented on the issue:
https://github.com/apache/trafficserver/pull/954
Hmmm, not sure. But if you look at the link, it clearly didn't like those
lines.
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well
Github user zwoop commented on the issue:
https://github.com/apache/trafficserver/pull/953
Fwiw, I did compare before and after, and things definitely improved. Not a
ton, but noticeable, I think we got rid of 3 cache lines in total across both
structs.
---
If your project is set
GitHub user zwoop opened a pull request:
https://github.com/apache/trafficserver/pull/957
TS-4801 Avoids marking parent down unless CONNECTION_ERROR
You can merge this pull request into a Git repository by running:
$ git pull https://github.com/zwoop/trafficserver TS-4801
Github user zwoop closed the pull request at:
https://github.com/apache/trafficserver/pull/948
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature
Github user zwoop commented on the issue:
https://github.com/apache/trafficserver/pull/956
A cookie for @PSUdaemon for properly setting all Github fields!!!
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your
Github user zwoop commented on the issue:
https://github.com/apache/trafficserver/pull/953
@jpeach what do you mean ? The : ?
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
Github user zwoop commented on the issue:
https://github.com/apache/trafficserver/pull/921
Status on this?
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so
Github user zwoop commented on the issue:
https://github.com/apache/trafficserver/pull/943
Couple of minor question / issues:
1) There are some references to the ICP Via headers in the
cmd/traffic_via/tests directory. They should go away maybe? Or do we still
generate
Github user zwoop commented on the issue:
https://github.com/apache/trafficserver/pull/951
:+1:
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so
Github user zwoop commented on the issue:
https://github.com/apache/trafficserver/pull/953
I have an update to this coming momentarily. :)
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have
Github user zwoop closed the pull request at:
https://github.com/apache/trafficserver/pull/952
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature
Github user zwoop commented on the issue:
https://github.com/apache/trafficserver/pull/952
[approve ci]
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so
Github user zwoop commented on the issue:
https://github.com/apache/trafficserver/pull/955
:+1:
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so
Github user zwoop commented on the issue:
https://github.com/apache/trafficserver/pull/954
@ericcarlschwartz It failed because of clang-format :-).
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does
GitHub user zwoop opened a pull request:
https://github.com/apache/trafficserver/pull/953
TS-4402 Fixes some config "Int" types to "Byte" types
This also makes some reordering of the Byte types to be consistent.
You can merge this pull request into a Git r
Github user zwoop commented on the issue:
https://github.com/apache/trafficserver/pull/952
Also, is a value of r < 0 an expected behavior, or is that some sort of
error case that is not handled properly ?
---
If your project is set up for it, you can reply to this email and h
Github user zwoop commented on the issue:
https://github.com/apache/trafficserver/pull/952
Interesting. How does this manifest itself? Is it possible that r is < 0,
and we go negative?
---
If your project is set up for it, you can reply to this email and have your
reply app
GitHub user zwoop opened a pull request:
https://github.com/apache/trafficserver/pull/950
TS-4803 Removes the config/support for proxy.config.dns.url_expansions
You can merge this pull request into a Git repository by running:
$ git pull https://github.com/zwoop/trafficserver
Github user zwoop closed the pull request at:
https://github.com/apache/trafficserver/pull/949
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature
Github user zwoop commented on the issue:
https://github.com/apache/trafficserver/pull/949
:+1:
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so
Github user zwoop commented on the issue:
https://github.com/apache/trafficserver/pull/928
meh we landed this without testing on the CI :-/. It breaks the builds.
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your
Github user zwoop commented on a diff in the pull request:
https://github.com/apache/trafficserver/pull/943#discussion_r77070843
--- Diff: mgmt/RecordsConfig.cc ---
@@ -1299,6 +1299,9 @@ static const RecordElement RecordsConfig[] =
,
{RECT_CONFIG
Github user zwoop commented on a diff in the pull request:
https://github.com/apache/trafficserver/pull/943#discussion_r77070791
--- Diff: mgmt/RecordsConfig.cc ---
@@ -1299,6 +1299,9 @@ static const RecordElement RecordsConfig[] =
,
{RECT_CONFIG
Github user zwoop commented on a diff in the pull request:
https://github.com/apache/trafficserver/pull/946#discussion_r77069088
--- Diff: configure.ac ---
@@ -1293,13 +1293,13 @@ AS_IF([test "x$enable_posix_cap" != "xno"],
AC_SUBST(use_posix_cap)
GitHub user zwoop opened a pull request:
https://github.com/apache/trafficserver/pull/948
TS-3407 Removes the legacy h2-14 identifiers
You can merge this pull request into a Git repository by running:
$ git pull https://github.com/zwoop/trafficserver TS-3407
Alternatively
Github user zwoop commented on a diff in the pull request:
https://github.com/apache/trafficserver/pull/942#discussion_r76879380
--- Diff: iocore/net/SSLUtils.cc ---
@@ -2018,11 +2047,17 @@ SSLParseCertificateConfiguration(const
SSLConfigParams *params, SSLCertLookup *l
Github user zwoop commented on a diff in the pull request:
https://github.com/apache/trafficserver/pull/942#discussion_r76876810
--- Diff: mgmt/RecordsConfig.cc ---
@@ -1245,7 +1245,7 @@ static const RecordElement RecordsConfig[] =
,
{RECT_CONFIG
Github user zwoop commented on the issue:
https://github.com/apache/trafficserver/pull/942
[approve ci]
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so
Github user zwoop commented on the issue:
https://github.com/apache/trafficserver/pull/928
Cool. And this PR still needs some fixing too on the commit message :).
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your
Github user zwoop commented on a diff in the pull request:
https://github.com/apache/trafficserver/pull/938#discussion_r76835010
--- Diff: iocore/net/SSLUtils.cc ---
@@ -544,7 +547,64 @@ ssl_context_enable_ecdh(SSL_CTX *ctx)
return ctx;
}
+static
Github user zwoop commented on a diff in the pull request:
https://github.com/apache/trafficserver/pull/938#discussion_r76828573
--- Diff: iocore/net/SSLUtils.cc ---
@@ -544,7 +547,64 @@ ssl_context_enable_ecdh(SSL_CTX *ctx)
return ctx;
}
+static
Github user zwoop commented on a diff in the pull request:
https://github.com/apache/trafficserver/pull/938#discussion_r76828078
--- Diff: iocore/net/SSLUtils.cc ---
@@ -95,6 +95,8 @@ struct ssl_user_config {
ssl_user_config() : opt(SSLCertContext::OPT_NONE
Github user zwoop commented on the issue:
https://github.com/apache/trafficserver/pull/938
[approve ci]
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so
Github user zwoop closed the pull request at:
https://github.com/apache/trafficserver/pull/922
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature
Github user zwoop commented on the issue:
https://github.com/apache/trafficserver/pull/922
:+1:
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so
Github user zwoop commented on the issue:
https://github.com/apache/trafficserver/pull/937
:+1:
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so
Github user zwoop commented on the issue:
https://github.com/apache/trafficserver/pull/941
:+1:
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so
Github user zwoop commented on the issue:
https://github.com/apache/trafficserver/pull/941
Yeh, I'm fine with removing it, but maybe at least change the commit
message (and ideally the Jira Summary too). Such that we an easily release-note
that we removed this option as well
Github user zwoop commented on a diff in the pull request:
https://github.com/apache/trafficserver/pull/941#discussion_r76725878
--- Diff: configure.ac ---
@@ -231,33 +231,6 @@ TS_ARG_ENABLE_VAR([has], [tests])
AM_CONDITIONAL([BUILD_TESTS], [test 0 -ne $has_tests
Github user zwoop commented on the issue:
https://github.com/apache/trafficserver/pull/938
make clang-format
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes
Github user zwoop commented on the issue:
https://github.com/apache/trafficserver/pull/937
The changes looks good to me.
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled
Github user zwoop commented on a diff in the pull request:
https://github.com/apache/trafficserver/pull/937#discussion_r76537936
--- Diff: iocore/net/Socks.cc ---
@@ -136,7 +136,7 @@ void
SocksEntry::free()
{
MUTEX_TRY_LOCK(lock, action_.mutex, this_ethread
Github user zwoop commented on the issue:
https://github.com/apache/trafficserver/pull/928
Fwiw, Github sort of imposes a Subject length of 50 characters, it will
line wrap beyond that, making for ugly messages. So, I think we should recommend
TS-1234 < 50 charac
Github user zwoop commented on the issue:
https://github.com/apache/trafficserver/pull/929
Fwiw, if the Linux build succeeds, it means clang-format succeeded.
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your
Github user zwoop commented on the issue:
https://github.com/apache/trafficserver/pull/931
It's a shame, because this plugin works poorly (only one request is
"saved").
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitH
Github user zwoop commented on the issue:
https://github.com/apache/trafficserver/pull/936
:+1:
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so
Github user zwoop commented on the issue:
https://github.com/apache/trafficserver/pull/928
Also update the commit message :)
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
Github user zwoop commented on the issue:
https://github.com/apache/trafficserver/pull/923
Fwiw, we should make sure to review and mark a PR for CI build before
merging.
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well
Github user zwoop commented on the issue:
https://github.com/apache/trafficserver/pull/918
Be careful when eliminating try_to_expand_host_name(), I recently
discovered that this function also deals with DNS failures in parent selection.
I'm +1 on removing (or renaming) this method
Github user zwoop commented on the issue:
https://github.com/apache/trafficserver/pull/912
I applied the patch, and could not see any remnants of _pct metrics.
:+1:
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well
Github user zwoop commented on the issue:
https://github.com/apache/trafficserver/pull/897
I dislike the inconsistency, but your explanation / use case makes a lot of
sense. And if we agree that this makes things better, and not worse, do it.
Maybe file a Jira to have a future
Github user zwoop commented on the issue:
https://github.com/apache/trafficserver/pull/907
:+1:
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so
Github user zwoop commented on the issue:
https://github.com/apache/trafficserver/pull/893
[approve ci]
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so
Github user zwoop commented on the issue:
https://github.com/apache/trafficserver/pull/879
@jpeach we good to land this now?
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
Github user zwoop commented on the issue:
https://github.com/apache/trafficserver/pull/882
Deprecated as of 6.2.0, removed for 7.0.0:
This plugin is deprecated as of v6.2.0 and will be removed as of v7.0.0. It
is replaced by a new Cache Key Manipulation Plugin and you should
Github user zwoop commented on the issue:
https://github.com/apache/trafficserver/pull/897
I guess I don't have a strong opinion, but it seems unfortunate to me to
introduce these new options as headers, rather than URI components. The
original plugin for lighthttpd did everything
Github user zwoop commented on the issue:
https://github.com/apache/trafficserver/pull/895
I'm ok with this, but it's slightly misleading that we are changing both
the HTTP/1 and the H2 timeouts. Perhaps considering mentioning this in the
commit message body, or the Summary? It'll
Github user zwoop commented on the issue:
https://github.com/apache/trafficserver/pull/903
Few issues here:
1) There are merge conflicts
2) Please don't bundle more than one Jira into each PR (unless absolutely
necessary)
3) Squash commits to down to one
Github user zwoop commented on the issue:
https://github.com/apache/trafficserver/pull/905
:+1:
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so
Github user zwoop commented on the issue:
https://github.com/apache/trafficserver/pull/898
:+1:
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so
Github user zwoop commented on the issue:
https://github.com/apache/trafficserver/pull/898
You might want to consider editing the commit subject, Github gets really
weird and truncates messages > 50 characters (so better do a short Summary, and
then more verbose messaging in the b
Github user zwoop commented on a diff in the pull request:
https://github.com/apache/trafficserver/pull/900#discussion_r75857735
--- Diff: proxy/ParentConsistentHash.cc ---
@@ -143,6 +143,8 @@ ParentConsistentHash::selectParent(const
ParentSelectionPolicy *policy, bool fir
Github user zwoop commented on the issue:
https://github.com/apache/trafficserver/pull/901
Looks good. Maybe I suggest a slightly cleaner commit message:
TS-4745 Initializes pRecord.failCount in ParentRecord::ProcessParents
:+1:
---
If your project is set up
Github user zwoop commented on the issue:
https://github.com/apache/trafficserver/pull/902
Also, I'm pretty sure this would fail the CI build, please run "make
clang-format" on the code, and push this again with the updated commit message.
Thanks!
---
If your proj
Github user zwoop commented on the issue:
https://github.com/apache/trafficserver/pull/902
Just to be picky, but we should avoid typos in the commit messages (memory,
not memory). I also think this could be simplified to just e.g.
4746 Fixes ParentRecord *secondary_parents
Github user zwoop commented on the issue:
https://github.com/apache/trafficserver/pull/904
:+1:
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so
Github user zwoop commented on a diff in the pull request:
https://github.com/apache/trafficserver/pull/904#discussion_r75856806
--- Diff: lib/ts/InkErrno.cc ---
@@ -0,0 +1,106 @@
+/** @file
+
+ Error code defines
+
+ @section license License
Github user zwoop commented on the issue:
https://github.com/apache/trafficserver/pull/893
Seems this branch has merge conflicts, please rebase with current master
and push again before review.
---
If your project is set up for it, you can reply to this email and have your
reply
601 - 700 of 896 matches
Mail list logo
