[GitHub] trafficserver pull request #1623: Delete dead code

2017-03-31 Thread zwoop
Github user zwoop closed the pull request at: https://github.com/apache/trafficserver/pull/1623 --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project does not have this feature enabled and wishes so, or if the feature

[GitHub] trafficserver pull request #1623: Delete dead code

2017-03-31 Thread SolidWallOfCode
Github user SolidWallOfCode commented on a diff in the pull request: https://github.com/apache/trafficserver/pull/1623#discussion_r109226190 --- Diff: proxy/logging/LogBuffer.cc --- @@ -112,14 +112,6 @@ LogBufferHeader::log_filename() return addr; }

[GitHub] trafficserver pull request #1623: Delete dead code

2017-03-31 Thread danobi
Github user danobi commented on a diff in the pull request: https://github.com/apache/trafficserver/pull/1623#discussion_r109180096 --- Diff: proxy/logging/LogBuffer.cc --- @@ -112,14 +112,6 @@ LogBufferHeader::log_filename() return addr; }

[GitHub] trafficserver pull request #1623: Delete dead code

2017-03-30 Thread zwoop
Github user zwoop commented on a diff in the pull request: https://github.com/apache/trafficserver/pull/1623#discussion_r109090078 --- Diff: proxy/logging/LogBuffer.cc --- @@ -112,14 +112,6 @@ LogBufferHeader::log_filename() return addr; }

[GitHub] trafficserver pull request #1623: Delete dead code

2017-03-30 Thread danobi
GitHub user danobi opened a pull request: https://github.com/apache/trafficserver/pull/1623 Delete dead code None of this code was being called or used elsewhere. Most likely some point before git history someone migrated off the abstract base class and never bothered to