[GitHub] trafficserver pull request #847: TS-4729: Remove dead assaignment in Http2St...

[masaori335]

Github user masaori335 closed the pull request at:

https://github.com/apache/trafficserver/pull/847


---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastruct...@apache.org or file a JIRA ticket
with INFRA.
---

[GitHub] trafficserver pull request #847: TS-4729: Remove dead assaignment in Http2St...

[shinrich]

Github user shinrich commented on a diff in the pull request:

https://github.com/apache/trafficserver/pull/847#discussion_r74317308
  
--- Diff: proxy/http2/Http2Stream.cc ---
@@ -509,7 +509,7 @@ Http2Stream::update_write_request(IOBufferReader 
*buf_reader, int64_t write_len,
 parent->connection_state.send_headers_frame(this);
 
 // See if the response is chunked.  Set up the dechunking logic if 
it is
-is_done = this->response_initialize_data_handling();
+this->response_initialize_data_handling();
--- End diff --

Actually, the is_done's between response_intiailize_data_handling and 
response_process_data are related.  If the response is not chunked both will 
always return false.  If they are chunked, they both return true if the entire 
chunk was represent and could be read.

It looks like my patch to open source missed the check on the return from 
this->response_initialize_data_handling.  There should be

if (is_done) {
  send_event = VC_EVENT_WRITE_COMPLETE;
}

I'll add that and set up a new PR.


---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastruct...@apache.org or file a JIRA ticket
with INFRA.
---

[GitHub] trafficserver pull request #847: TS-4729: Remove dead assaignment in Http2St...

[bryancall]

Github user bryancall commented on a diff in the pull request:

https://github.com/apache/trafficserver/pull/847#discussion_r74278773
  
--- Diff: proxy/http2/Http2Stream.cc ---
@@ -509,7 +509,7 @@ Http2Stream::update_write_request(IOBufferReader 
*buf_reader, int64_t write_len,
 parent->connection_state.send_headers_frame(this);
 
 // See if the response is chunked.  Set up the dechunking logic if 
it is
-is_done = this->response_initialize_data_handling();
+this->response_initialize_data_handling();
--- End diff --

The boolean is not related to if `response_initialize_data_handling` was 
successful or not, which is bad coding in my opinion.  It is information about 
if the response was chunked and if it is finished.

The return value for `response_initialize_data_handling` should be changed.


---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastruct...@apache.org or file a JIRA ticket
with INFRA.
---

[GitHub] trafficserver pull request #847: TS-4729: Remove dead assaignment in Http2St...

[jpeach]

Github user jpeach commented on a diff in the pull request:

https://github.com/apache/trafficserver/pull/847#discussion_r74273262
  
--- Diff: proxy/http2/Http2Stream.cc ---
@@ -509,7 +509,7 @@ Http2Stream::update_write_request(IOBufferReader 
*buf_reader, int64_t write_len,
 parent->connection_state.send_headers_frame(this);
 
 // See if the response is chunked.  Set up the dechunking logic if 
it is
-is_done = this->response_initialize_data_handling();
+this->response_initialize_data_handling();
--- End diff --

Should you check or assert on the return value here? I would guess that bad 
things happen if ``response_initialize_data_handling`` returns false.


---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastruct...@apache.org or file a JIRA ticket
with INFRA.
---

[GitHub] trafficserver pull request #847: TS-4729: Remove dead assaignment in Http2St...

[masaori335]

GitHub user masaori335 opened a pull request:

https://github.com/apache/trafficserver/pull/847

TS-4729: Remove dead assaignment in Http2Stream

[TS-4729](https://issues.apache.org/jira/browse/TS-4729)

You can merge this pull request into a Git repository by running:

$ git pull https://github.com/masaori335/trafficserver ts-4729

Alternatively you can review and apply these changes as the patch at:

https://github.com/apache/trafficserver/pull/847.patch

To close this pull request, make a commit to your master/trunk branch
with (at least) the following in the commit message:

This closes #847


commit dd48279f66d503312c3f3b5a1ad534bda5d3a65c
Author: Masaori Koshiba 
Date:   2016-08-10T03:06:54Z

TS-4729: Remove dead assaignment in Http2Stream




---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastruct...@apache.org or file a JIRA ticket
with INFRA.
---