[jira] [Work logged] (AMQNET-619) Remote detach is not handled properly for sender link

2019-10-05 Thread ASF GitHub Bot (Jira) 


 [ 
https://issues.apache.org/jira/browse/AMQNET-619?focusedWorklogId=323905=com.atlassian.jira.plugin.system.issuetabpanels:worklog-tabpanel#worklog-323905
 ]

ASF GitHub Bot logged work on AMQNET-619:
-

Author: ASF GitHub Bot
Created on: 05/Oct/19 11:02
Start Date: 05/Oct/19 11:02
Worklog Time Spent: 10m 
  Work Description: michaelandrepearce commented on pull request #42: 
AMQNET-619: Handle remote detach properly for sender link
URL: https://github.com/apache/activemq-nms-amqp/pull/42
 
 
   
 

This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
 
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org


Issue Time Tracking
---

Worklog Id: (was: 323905)
Time Spent: 1h  (was: 50m)

> Remote detach is not handled properly for sender link
> -
>
> Key: AMQNET-619
> URL: https://issues.apache.org/jira/browse/AMQNET-619
> Project: ActiveMQ .Net
>  Issue Type: Bug
>  Components: AMQP
>Reporter: Krzysztof Porebski
>Priority: Major
>  Time Spent: 1h
>  Remaining Estimate: 0h
>
> Remote detach is not handled properly for sender link. MessageProducer is 
> created even if no link terminus was created. It results in unexpected 
> behavior if we try to use MessageProducer immediately after its creation



--
This message was sent by Atlassian Jira
(v8.3.4#803005)

[jira] [Work logged] (AMQNET-619) Remote detach is not handled properly for sender link

2019-10-05 Thread ASF GitHub Bot (Jira) 


 [ 
https://issues.apache.org/jira/browse/AMQNET-619?focusedWorklogId=323888=com.atlassian.jira.plugin.system.issuetabpanels:worklog-tabpanel#worklog-323888
 ]

ASF GitHub Bot logged work on AMQNET-619:
-

Author: ASF GitHub Bot
Created on: 05/Oct/19 08:23
Start Date: 05/Oct/19 08:23
Worklog Time Spent: 10m 
  Work Description: Havret commented on pull request #42: AMQNET-619: 
Handle remote detach properly for sender link
URL: https://github.com/apache/activemq-nms-amqp/pull/42#discussion_r331738433
 
 

 ##
 File path: src/NMS.AMQP/Provider/Amqp/AmqpProducer.cs
 ##
 @@ -53,13 +53,13 @@ public Task Attach()
 };
 
 string linkName = info.Id + ":" + target.Address;
-var taskCompletionSource = new TaskCompletionSource();
-senderLink = new SenderLink(session.UnderlyingSession, linkName, 
frame, (link, attach) => { taskCompletionSource.SetResult(true); });
+TaskCompletionSource tsc = new TaskCompletionSource();
 
 Review comment:
   Hope it's ok now.  
 

This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
 
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org


Issue Time Tracking
---

Worklog Id: (was: 323888)
Time Spent: 50m  (was: 40m)

> Remote detach is not handled properly for sender link
> -
>
> Key: AMQNET-619
> URL: https://issues.apache.org/jira/browse/AMQNET-619
> Project: ActiveMQ .Net
>  Issue Type: Bug
>  Components: AMQP
>Reporter: Krzysztof Porebski
>Priority: Major
>  Time Spent: 50m
>  Remaining Estimate: 0h
>
> Remote detach is not handled properly for sender link. MessageProducer is 
> created even if no link terminus was created. It results in unexpected 
> behavior if we try to use MessageProducer immediately after its creation



--
This message was sent by Atlassian Jira
(v8.3.4#803005)

[jira] [Work logged] (AMQNET-619) Remote detach is not handled properly for sender link

2019-10-05 Thread ASF GitHub Bot (Jira) 


 [ 
https://issues.apache.org/jira/browse/AMQNET-619?focusedWorklogId=323884=com.atlassian.jira.plugin.system.issuetabpanels:worklog-tabpanel#worklog-323884
 ]

ASF GitHub Bot logged work on AMQNET-619:
-

Author: ASF GitHub Bot
Created on: 05/Oct/19 06:55
Start Date: 05/Oct/19 06:55
Worklog Time Spent: 10m 
  Work Description: michaelandrepearce commented on pull request #42: 
AMQNET-619: Handle remote detach properly for sender link
URL: https://github.com/apache/activemq-nms-amqp/pull/42#discussion_r331736022
 
 

 ##
 File path: src/NMS.AMQP/Provider/Amqp/AmqpProducer.cs
 ##
 @@ -53,13 +53,13 @@ public Task Attach()
 };
 
 string linkName = info.Id + ":" + target.Address;
-var taskCompletionSource = new TaskCompletionSource();
-senderLink = new SenderLink(session.UnderlyingSession, linkName, 
frame, (link, attach) => { taskCompletionSource.SetResult(true); });
+TaskCompletionSource tsc = new TaskCompletionSource();
 
 Review comment:
   You made further changes...:s the name is still shortened  i meant to put it 
back to var taskCompletionService so there is no change in this line.
 

This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
 
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org


Issue Time Tracking
---

Worklog Id: (was: 323884)
Time Spent: 40m  (was: 0.5h)

> Remote detach is not handled properly for sender link
> -
>
> Key: AMQNET-619
> URL: https://issues.apache.org/jira/browse/AMQNET-619
> Project: ActiveMQ .Net
>  Issue Type: Bug
>  Components: AMQP
>Reporter: Krzysztof Porebski
>Priority: Major
>  Time Spent: 40m
>  Remaining Estimate: 0h
>
> Remote detach is not handled properly for sender link. MessageProducer is 
> created even if no link terminus was created. It results in unexpected 
> behavior if we try to use MessageProducer immediately after its creation



--
This message was sent by Atlassian Jira
(v8.3.4#803005)

[jira] [Work logged] (AMQNET-619) Remote detach is not handled properly for sender link

2019-10-04 Thread ASF GitHub Bot (Jira) 


 [ 
https://issues.apache.org/jira/browse/AMQNET-619?focusedWorklogId=323872=com.atlassian.jira.plugin.system.issuetabpanels:worklog-tabpanel#worklog-323872
 ]

ASF GitHub Bot logged work on AMQNET-619:
-

Author: ASF GitHub Bot
Created on: 05/Oct/19 04:54
Start Date: 05/Oct/19 04:54
Worklog Time Spent: 10m 
  Work Description: Havret commented on pull request #42: AMQNET-619: 
Handle remote detach properly for sender link
URL: https://github.com/apache/activemq-nms-amqp/pull/42#discussion_r331732826
 
 

 ##
 File path: src/NMS.AMQP/Provider/Amqp/AmqpProducer.cs
 ##
 @@ -53,13 +53,13 @@ public Task Attach()
 };
 
 string linkName = info.Id + ":" + target.Address;
-var taskCompletionSource = new TaskCompletionSource();
-senderLink = new SenderLink(session.UnderlyingSession, linkName, 
frame, (link, attach) => { taskCompletionSource.SetResult(true); });
+var tsc = new TaskCompletionSource();
 
 Review comment:
   Sure thing. Fixed. 
 

This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
 
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org


Issue Time Tracking
---

Worklog Id: (was: 323872)
Time Spent: 0.5h  (was: 20m)

> Remote detach is not handled properly for sender link
> -
>
> Key: AMQNET-619
> URL: https://issues.apache.org/jira/browse/AMQNET-619
> Project: ActiveMQ .Net
>  Issue Type: Bug
>  Components: AMQP
>Reporter: Krzysztof Porebski
>Priority: Major
>  Time Spent: 0.5h
>  Remaining Estimate: 0h
>
> Remote detach is not handled properly for sender link. MessageProducer is 
> created even if no link terminus was created. It results in unexpected 
> behavior if we try to use MessageProducer immediately after its creation



--
This message was sent by Atlassian Jira
(v8.3.4#803005)

[jira] [Work logged] (AMQNET-619) Remote detach is not handled properly for sender link

2019-10-04 Thread ASF GitHub Bot (Jira) 


 [ 
https://issues.apache.org/jira/browse/AMQNET-619?focusedWorklogId=323866=com.atlassian.jira.plugin.system.issuetabpanels:worklog-tabpanel#worklog-323866
 ]

ASF GitHub Bot logged work on AMQNET-619:
-

Author: ASF GitHub Bot
Created on: 05/Oct/19 03:56
Start Date: 05/Oct/19 03:56
Worklog Time Spent: 10m 
  Work Description: michaelandrepearce commented on pull request #42: 
AMQNET-619: Handle remote detach properly for sender link
URL: https://github.com/apache/activemq-nms-amqp/pull/42#discussion_r331731380
 
 

 ##
 File path: src/NMS.AMQP/Provider/Amqp/AmqpProducer.cs
 ##
 @@ -53,13 +53,13 @@ public Task Attach()
 };
 
 string linkName = info.Id + ":" + target.Address;
-var taskCompletionSource = new TaskCompletionSource();
-senderLink = new SenderLink(session.UnderlyingSession, linkName, 
frame, (link, attach) => { taskCompletionSource.SetResult(true); });
+var tsc = new TaskCompletionSource();
 
 Review comment:
   Can you revert the shortening of the var. Unneeded change
 

This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
 
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org


Issue Time Tracking
---

Worklog Id: (was: 323866)
Time Spent: 20m  (was: 10m)

> Remote detach is not handled properly for sender link
> -
>
> Key: AMQNET-619
> URL: https://issues.apache.org/jira/browse/AMQNET-619
> Project: ActiveMQ .Net
>  Issue Type: Bug
>  Components: AMQP
>Reporter: Krzysztof Porebski
>Priority: Major
>  Time Spent: 20m
>  Remaining Estimate: 0h
>
> Remote detach is not handled properly for sender link. MessageProducer is 
> created even if no link terminus was created. It results in unexpected 
> behavior if we try to use MessageProducer immediately after its creation



--
This message was sent by Atlassian Jira
(v8.3.4#803005)

[jira] [Work logged] (AMQNET-619) Remote detach is not handled properly for sender link

2019-10-02 Thread ASF GitHub Bot (Jira) 


 [ 
https://issues.apache.org/jira/browse/AMQNET-619?focusedWorklogId=322126=com.atlassian.jira.plugin.system.issuetabpanels:worklog-tabpanel#worklog-322126
 ]

ASF GitHub Bot logged work on AMQNET-619:
-

Author: ASF GitHub Bot
Created on: 02/Oct/19 18:31
Start Date: 02/Oct/19 18:31
Worklog Time Spent: 10m 
  Work Description: Havret commented on pull request #42: AMQNET-619: 
Handle remote detach properly for sender link
URL: https://github.com/apache/activemq-nms-amqp/pull/42
 
 
   
 

This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
 
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org


Issue Time Tracking
---

Worklog Id: (was: 322126)
Remaining Estimate: 0h
Time Spent: 10m

> Remote detach is not handled properly for sender link
> -
>
> Key: AMQNET-619
> URL: https://issues.apache.org/jira/browse/AMQNET-619
> Project: ActiveMQ .Net
>  Issue Type: Bug
>  Components: AMQP
>Reporter: Krzysztof Porebski
>Priority: Major
>  Time Spent: 10m
>  Remaining Estimate: 0h
>
> Remote detach is not handled properly for sender link. MessageProducer is 
> created even if no link terminus was created. It results in unexpected 
> behavior if we try to use MessageProducer immediately after its creation



--
This message was sent by Atlassian Jira
(v8.3.4#803005)