[jira] [Work logged] (BEAM-1009) Upgrade to Mockito 3
[ https://issues.apache.org/jira/browse/BEAM-1009?focusedWorklogId=302800=com.atlassian.jira.plugin.system.issuetabpanels:worklog-tabpanel#worklog-302800 ] ASF GitHub Bot logged work on BEAM-1009: Author: ASF GitHub Bot Created on: 28/Aug/19 12:24 Start Date: 28/Aug/19 12:24 Worklog Time Spent: 10m Work Description: mxm commented on issue #9441: [BEAM-1009] Revert "Merge pull request #9338: [BEAM-1009] Upgrade to Mockito 3" URL: https://github.com/apache/beam/pull/9441#issuecomment-525721302 Could be. Will also try reverting the other PR. This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: us...@infra.apache.org Issue Time Tracking --- Worklog Id: (was: 302800) Time Spent: 4.5h (was: 4h 20m) > Upgrade to Mockito 3 > > > Key: BEAM-1009 > URL: https://issues.apache.org/jira/browse/BEAM-1009 > Project: Beam > Issue Type: Test > Components: sdk-java-core >Reporter: Pei He >Priority: Major > Fix For: 2.16.0 > > Time Spent: 4.5h > Remaining Estimate: 0h > > Mockito 2 provides useful features, and the mockito-all module is no longer > generated. -- This message was sent by Atlassian Jira (v8.3.2#803003)
[jira] [Work logged] (BEAM-1009) Upgrade to Mockito 3
[ https://issues.apache.org/jira/browse/BEAM-1009?focusedWorklogId=302799=com.atlassian.jira.plugin.system.issuetabpanels:worklog-tabpanel#worklog-302799 ] ASF GitHub Bot logged work on BEAM-1009: Author: ASF GitHub Bot Created on: 28/Aug/19 12:23 Start Date: 28/Aug/19 12:23 Worklog Time Spent: 10m Work Description: iemejia commented on issue #9441: [BEAM-1009] Revert "Merge pull request #9338: [BEAM-1009] Upgrade to Mockito 3" URL: https://github.com/apache/beam/pull/9441#issuecomment-525720102 This PR was merged last week and it worked ok. It seems the changes that broke master are not related to it but to #9000 This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: us...@infra.apache.org Issue Time Tracking --- Worklog Id: (was: 302799) Time Spent: 4h 20m (was: 4h 10m) > Upgrade to Mockito 3 > > > Key: BEAM-1009 > URL: https://issues.apache.org/jira/browse/BEAM-1009 > Project: Beam > Issue Type: Test > Components: sdk-java-core >Reporter: Pei He >Priority: Major > Fix For: 2.16.0 > > Time Spent: 4h 20m > Remaining Estimate: 0h > > Mockito 2 provides useful features, and the mockito-all module is no longer > generated. -- This message was sent by Atlassian Jira (v8.3.2#803003)
[jira] [Work logged] (BEAM-1009) Upgrade to Mockito 3
[ https://issues.apache.org/jira/browse/BEAM-1009?focusedWorklogId=302795=com.atlassian.jira.plugin.system.issuetabpanels:worklog-tabpanel#worklog-302795 ] ASF GitHub Bot logged work on BEAM-1009: Author: ASF GitHub Bot Created on: 28/Aug/19 12:20 Start Date: 28/Aug/19 12:20 Worklog Time Spent: 10m Work Description: iemejia commented on issue #9441: [BEAM-1009] Revert "Merge pull request #9338: [BEAM-1009] Upgrade to Mockito 3" URL: https://github.com/apache/beam/pull/9441#issuecomment-525720102 This PR was merged last week and it worked ok. It seems the changes are not related to it but to #9000 This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: us...@infra.apache.org Issue Time Tracking --- Worklog Id: (was: 302795) Time Spent: 4h 10m (was: 4h) > Upgrade to Mockito 3 > > > Key: BEAM-1009 > URL: https://issues.apache.org/jira/browse/BEAM-1009 > Project: Beam > Issue Type: Test > Components: sdk-java-core >Reporter: Pei He >Priority: Major > Fix For: 2.16.0 > > Time Spent: 4h 10m > Remaining Estimate: 0h > > Mockito 2 provides useful features, and the mockito-all module is no longer > generated. -- This message was sent by Atlassian Jira (v8.3.2#803003)
[jira] [Work logged] (BEAM-1009) Upgrade to Mockito 3
[ https://issues.apache.org/jira/browse/BEAM-1009?focusedWorklogId=302792=com.atlassian.jira.plugin.system.issuetabpanels:worklog-tabpanel#worklog-302792 ] ASF GitHub Bot logged work on BEAM-1009: Author: ASF GitHub Bot Created on: 28/Aug/19 12:17 Start Date: 28/Aug/19 12:17 Worklog Time Spent: 10m Work Description: mxm commented on pull request #9441: [BEAM-1009] Revert "Merge pull request #9338: [BEAM-1009] Upgrade to Mockito 3" URL: https://github.com/apache/beam/pull/9441 This reverts commit 44fa33e6518574cb9561f47774e218e0910093fe, reversing changes made to bb278f4a762eae767e9d052374cda98e90733b43. Reverted PR: #9338 Errors present without this revert: ``` Error Message org.mockito.exceptions.base.MockitoException: Mockito cannot mock this class: class org.apache.beam.sdk.extensions.gcp.util.GcsUtil. Mockito can only mock non-private & non-final classes. If you're not sure why you're getting this error, please report to the mailing list. Java : 1.8 JVM vendor name: Private Build JVM vendor version : 25.222-b10 JVM name : OpenJDK 64-Bit Server VM JVM version: 1.8.0_222-8u222-b10-1ubuntu1~16.04.1-b10 JVM info : mixed mode OS name: Linux OS version : 4.15.0-1032-gcp Underlying exception : java.lang.IllegalArgumentException: Could not create type Stacktrace org.mockito.exceptions.base.MockitoException: Mockito cannot mock this class: class org.apache.beam.sdk.extensions.gcp.util.GcsUtil. Mockito can only mock non-private & non-final classes. If you're not sure why you're getting this error, please report to the mailing list. Java : 1.8 JVM vendor name: Private Build JVM vendor version : 25.222-b10 JVM name : OpenJDK 64-Bit Server VM JVM version: 1.8.0_222-8u222-b10-1ubuntu1~16.04.1-b10 JVM info : mixed mode OS name: Linux OS version : 4.15.0-1032-gcp Underlying exception : java.lang.IllegalArgumentException: Could not create type at org.apache.beam.examples.MinimalWordCountTest.buildMockGcsUtil(MinimalWordCountTest.java:73) at org.apache.beam.examples.MinimalWordCountTest.testMinimalWordCount(MinimalWordCountTest.java:56) at sun.reflect.NativeMethodAccessorImpl.invoke0(Native Method) at sun.reflect.NativeMethodAccessorImpl.invoke(NativeMethodAccessorImpl.java:62) at sun.reflect.DelegatingMethodAccessorImpl.invoke(DelegatingMethodAccessorImpl.java:43) at java.lang.reflect.Method.invoke(Method.java:498) at org.junit.runners.model.FrameworkMethod$1.runReflectiveCall(FrameworkMethod.java:59) at org.junit.internal.runners.model.ReflectiveCallable.run(ReflectiveCallable.java:12) at org.junit.runners.model.FrameworkMethod.invokeExplosively(FrameworkMethod.java:56) at org.junit.internal.runners.statements.InvokeMethod.evaluate(InvokeMethod.java:17) at org.apache.beam.sdk.testing.TestPipeline$1.evaluate(TestPipeline.java:319) at org.junit.runners.ParentRunner$3.evaluate(ParentRunner.java:305) at org.junit.runners.BlockJUnit4ClassRunner$1.evaluate(BlockJUnit4ClassRunner.java:100) at org.junit.runners.ParentRunner.runLeaf(ParentRunner.java:365) at org.junit.runners.BlockJUnit4ClassRunner.runChild(BlockJUnit4ClassRunner.java:103) at org.junit.runners.BlockJUnit4ClassRunner.runChild(BlockJUnit4ClassRunner.java:63) at org.junit.runners.ParentRunner$4.run(ParentRunner.java:330) at org.junit.runners.ParentRunner$1.schedule(ParentRunner.java:78) at org.junit.runners.ParentRunner.runChildren(ParentRunner.java:328) at org.junit.runners.ParentRunner.access$100(ParentRunner.java:65) at org.junit.runners.ParentRunner$2.evaluate(ParentRunner.java:292) at org.junit.runners.ParentRunner$3.evaluate(ParentRunner.java:305) at org.junit.runners.ParentRunner.run(ParentRunner.java:412) at org.gradle.api.internal.tasks.testing.junit.JUnitTestClassExecutor.runTestClass(JUnitTestClassExecutor.java:110) at org.gradle.api.internal.tasks.testing.junit.JUnitTestClassExecutor.execute(JUnitTestClassExecutor.java:58) at org.gradle.api.internal.tasks.testing.junit.JUnitTestClassExecutor.execute(JUnitTestClassExecutor.java:38) at org.gradle.api.internal.tasks.testing.junit.AbstractJUnitTestClassProcessor.processTestClass(AbstractJUnitTestClassProcessor.java:62) at org.gradle.api.internal.tasks.testing.SuiteTestClassProcessor.processTestClass(SuiteTestClassProcessor.java:51) at sun.reflect.NativeMethodAccessorImpl.invoke0(Native Method) at
[jira] [Work logged] (BEAM-1009) Upgrade to Mockito 3
[ https://issues.apache.org/jira/browse/BEAM-1009?focusedWorklogId=298600=com.atlassian.jira.plugin.system.issuetabpanels:worklog-tabpanel#worklog-298600 ] ASF GitHub Bot logged work on BEAM-1009: Author: ASF GitHub Bot Created on: 21/Aug/19 11:14 Start Date: 21/Aug/19 11:14 Worklog Time Spent: 10m Work Description: TimvdLippe commented on issue #9338: [BEAM-1009] Upgrade to Mockito 3 URL: https://github.com/apache/beam/pull/9338#issuecomment-523411846 Thanks for merging! Feel free to ping me/send me a CL if you run into issues when importing this internally. This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: us...@infra.apache.org Issue Time Tracking --- Worklog Id: (was: 298600) Time Spent: 3h 50m (was: 3h 40m) > Upgrade to Mockito 3 > > > Key: BEAM-1009 > URL: https://issues.apache.org/jira/browse/BEAM-1009 > Project: Beam > Issue Type: Test > Components: sdk-java-core >Reporter: Pei He >Priority: Major > Fix For: 2.16.0 > > Time Spent: 3h 50m > Remaining Estimate: 0h > > Mockito 2 provides useful features, and the mockito-all module is no longer > generated. -- This message was sent by Atlassian Jira (v8.3.2#803003)
[jira] [Work logged] (BEAM-1009) Upgrade to Mockito 3
[ https://issues.apache.org/jira/browse/BEAM-1009?focusedWorklogId=298485=com.atlassian.jira.plugin.system.issuetabpanels:worklog-tabpanel#worklog-298485 ] ASF GitHub Bot logged work on BEAM-1009: Author: ASF GitHub Bot Created on: 21/Aug/19 07:11 Start Date: 21/Aug/19 07:11 Worklog Time Spent: 10m Work Description: iemejia commented on pull request #9338: [BEAM-1009] Upgrade to Mockito 3 URL: https://github.com/apache/beam/pull/9338 This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: us...@infra.apache.org Issue Time Tracking --- Worklog Id: (was: 298485) Time Spent: 3h 40m (was: 3.5h) > Upgrade to Mockito 3 > > > Key: BEAM-1009 > URL: https://issues.apache.org/jira/browse/BEAM-1009 > Project: Beam > Issue Type: Test > Components: sdk-java-core >Reporter: Pei He >Priority: Major > Time Spent: 3h 40m > Remaining Estimate: 0h > > Mockito 2 provides useful features, and the mockito-all module is no longer > generated. -- This message was sent by Atlassian Jira (v8.3.2#803003)
[jira] [Work logged] (BEAM-1009) Upgrade to Mockito 3
[
https://issues.apache.org/jira/browse/BEAM-1009?focusedWorklogId=297998=com.atlassian.jira.plugin.system.issuetabpanels:worklog-tabpanel#worklog-297998
]
ASF GitHub Bot logged work on BEAM-1009:
Author: ASF GitHub Bot
Created on: 20/Aug/19 16:15
Start Date: 20/Aug/19 16:15
Worklog Time Spent: 10m
Work Description: kennknowles commented on pull request #9338:
[BEAM-1009] Upgrade to Mockito 3
URL: https://github.com/apache/beam/pull/9338#discussion_r315780301
##
File path:
runners/google-cloud-dataflow-java/worker/src/test/java/org/apache/beam/runners/dataflow/worker/StreamingDataflowWorkerTest.java
##
@@ -675,7 +675,7 @@ public void testBasicHarness() throws Exception {
makeExpectedOutput(i, TimeUnit.MILLISECONDS.toMicros(i)).build(),
result.get((long) i));
}
-verify(hotKeyLogger, atLeastOnce()).logHotKeyDetection(anyString(), any());
+verify(hotKeyLogger,
atLeastOnce()).logHotKeyDetection(nullable(String.class), any());
Review comment:
SGTM
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org
Issue Time Tracking
---
Worklog Id: (was: 297998)
Time Spent: 3.5h (was: 3h 20m)
> Upgrade to Mockito 3
>
>
> Key: BEAM-1009
> URL: https://issues.apache.org/jira/browse/BEAM-1009
> Project: Beam
> Issue Type: Test
> Components: sdk-java-core
>Reporter: Pei He
>Priority: Major
> Time Spent: 3.5h
> Remaining Estimate: 0h
>
> Mockito 2 provides useful features, and the mockito-all module is no longer
> generated.
--
This message was sent by Atlassian Jira
(v8.3.2#803003)
[jira] [Work logged] (BEAM-1009) Upgrade to Mockito 3
[
https://issues.apache.org/jira/browse/BEAM-1009?focusedWorklogId=297999=com.atlassian.jira.plugin.system.issuetabpanels:worklog-tabpanel#worklog-297999
]
ASF GitHub Bot logged work on BEAM-1009:
Author: ASF GitHub Bot
Created on: 20/Aug/19 16:15
Start Date: 20/Aug/19 16:15
Worklog Time Spent: 10m
Work Description: kennknowles commented on pull request #9338:
[BEAM-1009] Upgrade to Mockito 3
URL: https://github.com/apache/beam/pull/9338#discussion_r315780942
##
File path:
sdks/java/io/kinesis/src/test/java/org/apache/beam/sdk/io/kinesis/ShardReadersPoolTest.java
##
@@ -41,11 +41,11 @@
import org.junit.runner.RunWith;
import org.mockito.Mock;
import org.mockito.Mockito;
-import org.mockito.runners.MockitoJUnitRunner;
+import org.mockito.junit.MockitoJUnitRunner;
import org.mockito.stubbing.Answer;
/** Tests {@link ShardReadersPool}. */
-@RunWith(MockitoJUnitRunner.class)
+@RunWith(MockitoJUnitRunner.Silent.class)
Review comment:
OK, cool.
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org
Issue Time Tracking
---
Worklog Id: (was: 297999)
Time Spent: 3.5h (was: 3h 20m)
> Upgrade to Mockito 3
>
>
> Key: BEAM-1009
> URL: https://issues.apache.org/jira/browse/BEAM-1009
> Project: Beam
> Issue Type: Test
> Components: sdk-java-core
>Reporter: Pei He
>Priority: Major
> Time Spent: 3.5h
> Remaining Estimate: 0h
>
> Mockito 2 provides useful features, and the mockito-all module is no longer
> generated.
--
This message was sent by Atlassian Jira
(v8.3.2#803003)
[jira] [Work logged] (BEAM-1009) Upgrade to Mockito 3
[
https://issues.apache.org/jira/browse/BEAM-1009?focusedWorklogId=297997=com.atlassian.jira.plugin.system.issuetabpanels:worklog-tabpanel#worklog-297997
]
ASF GitHub Bot logged work on BEAM-1009:
Author: ASF GitHub Bot
Created on: 20/Aug/19 16:15
Start Date: 20/Aug/19 16:15
Worklog Time Spent: 10m
Work Description: kennknowles commented on pull request #9338:
[BEAM-1009] Upgrade to Mockito 3
URL: https://github.com/apache/beam/pull/9338#discussion_r315780154
##
File path:
sdks/java/core/src/main/java/org/apache/beam/sdk/transforms/reflect/DoFnSignatures.java
##
@@ -479,6 +479,14 @@ private static DoFnSignature parseSignature(Class> fnClass)
return signature;
}
+ private static Class getDeclaringClass(Method onTimerMethod) {
Review comment:
Well, I'll turn that around and say that reflection is often OK when it is
not fancy and mocking is generally not a good idea :-p. That said, both are
worth avoiding if possible.
The relevant kind of reflection here is pretty elementary for
annotation-driven API. I guess thinking about this case, the trigger of the
issue is that we check that a couple classes are exactly the same class?
Anathema to inheritance-based style but with the benefits of being simple and
correct.
Created https://issues.apache.org/jira/browse/BEAM-8013
If it is a different trigger of the problem, can correct the Jira.
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org
Issue Time Tracking
---
Worklog Id: (was: 297997)
Time Spent: 3h 20m (was: 3h 10m)
> Upgrade to Mockito 3
>
>
> Key: BEAM-1009
> URL: https://issues.apache.org/jira/browse/BEAM-1009
> Project: Beam
> Issue Type: Test
> Components: sdk-java-core
>Reporter: Pei He
>Priority: Major
> Time Spent: 3h 20m
> Remaining Estimate: 0h
>
> Mockito 2 provides useful features, and the mockito-all module is no longer
> generated.
--
This message was sent by Atlassian Jira
(v8.3.2#803003)
[jira] [Work logged] (BEAM-1009) Upgrade to Mockito 3
[
https://issues.apache.org/jira/browse/BEAM-1009?focusedWorklogId=298000=com.atlassian.jira.plugin.system.issuetabpanels:worklog-tabpanel#worklog-298000
]
ASF GitHub Bot logged work on BEAM-1009:
Author: ASF GitHub Bot
Created on: 20/Aug/19 16:15
Start Date: 20/Aug/19 16:15
Worklog Time Spent: 10m
Work Description: kennknowles commented on pull request #9338:
[BEAM-1009] Upgrade to Mockito 3
URL: https://github.com/apache/beam/pull/9338#discussion_r315780435
##
File path:
runners/google-cloud-dataflow-java/worker/src/test/java/org/apache/beam/runners/dataflow/worker/util/common/worker/WorkProgressUpdaterTest.java
##
@@ -165,8 +165,7 @@ public void updatesBeforePeriodicCheckpoint() throws
Exception {
// Set the initial lease expiration to 20s so that the first update occurs
at 10s, ie before
// the periodic checkpoint.
initialLeaseExpirationMs = clock.currentTimeMillis() + 20 * 1000L;
-
when(progressHelper.reportProgress(any(NativeReader.DynamicSplitResult.class)))
-.thenReturn(4 * 1000L); // Next update at 14s.
+when(progressHelper.reportProgress(null)).thenReturn(4 * 1000L); // Next
update at 14s.
Review comment:
Got it
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org
Issue Time Tracking
---
Worklog Id: (was: 298000)
> Upgrade to Mockito 3
>
>
> Key: BEAM-1009
> URL: https://issues.apache.org/jira/browse/BEAM-1009
> Project: Beam
> Issue Type: Test
> Components: sdk-java-core
>Reporter: Pei He
>Priority: Major
> Time Spent: 3.5h
> Remaining Estimate: 0h
>
> Mockito 2 provides useful features, and the mockito-all module is no longer
> generated.
--
This message was sent by Atlassian Jira
(v8.3.2#803003)
[jira] [Work logged] (BEAM-1009) Upgrade to Mockito 3
[
https://issues.apache.org/jira/browse/BEAM-1009?focusedWorklogId=297985=com.atlassian.jira.plugin.system.issuetabpanels:worklog-tabpanel#worklog-297985
]
ASF GitHub Bot logged work on BEAM-1009:
Author: ASF GitHub Bot
Created on: 20/Aug/19 16:02
Start Date: 20/Aug/19 16:02
Worklog Time Spent: 10m
Work Description: kennknowles commented on pull request #9338:
[BEAM-1009] Upgrade to Mockito 3
URL: https://github.com/apache/beam/pull/9338#discussion_r315774908
##
File path:
runners/google-cloud-dataflow-java/worker/src/test/java/org/apache/beam/runners/dataflow/worker/util/common/worker/WorkProgressUpdaterTest.java
##
@@ -165,8 +165,7 @@ public void updatesBeforePeriodicCheckpoint() throws
Exception {
// Set the initial lease expiration to 20s so that the first update occurs
at 10s, ie before
// the periodic checkpoint.
initialLeaseExpirationMs = clock.currentTimeMillis() + 20 * 1000L;
-
when(progressHelper.reportProgress(any(NativeReader.DynamicSplitResult.class)))
-.thenReturn(4 * 1000L); // Next update at 14s.
+when(progressHelper.reportProgress(null)).thenReturn(4 * 1000L); // Next
update at 14s.
Review comment:
Nice. In that case, you've made it more clear :-)
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org
Issue Time Tracking
---
Worklog Id: (was: 297985)
Time Spent: 3h 10m (was: 3h)
> Upgrade to Mockito 3
>
>
> Key: BEAM-1009
> URL: https://issues.apache.org/jira/browse/BEAM-1009
> Project: Beam
> Issue Type: Test
> Components: sdk-java-core
>Reporter: Pei He
>Priority: Major
> Time Spent: 3h 10m
> Remaining Estimate: 0h
>
> Mockito 2 provides useful features, and the mockito-all module is no longer
> generated.
--
This message was sent by Atlassian Jira
(v8.3.2#803003)
[jira] [Work logged] (BEAM-1009) Upgrade to Mockito 3
[ https://issues.apache.org/jira/browse/BEAM-1009?focusedWorklogId=297656=com.atlassian.jira.plugin.system.issuetabpanels:worklog-tabpanel#worklog-297656 ] ASF GitHub Bot logged work on BEAM-1009: Author: ASF GitHub Bot Created on: 20/Aug/19 07:26 Start Date: 20/Aug/19 07:26 Worklog Time Spent: 10m Work Description: iemejia commented on issue #9338: [BEAM-1009] Upgrade to Mockito 3 URL: https://github.com/apache/beam/pull/9338#issuecomment-522890374 This looks ok for me, let's wait a bit to see if @kennknowles may have some additional suggestions. This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: us...@infra.apache.org Issue Time Tracking --- Worklog Id: (was: 297656) Time Spent: 3h (was: 2h 50m) > Upgrade to Mockito 3 > > > Key: BEAM-1009 > URL: https://issues.apache.org/jira/browse/BEAM-1009 > Project: Beam > Issue Type: Test > Components: sdk-java-core >Reporter: Pei He >Priority: Major > Time Spent: 3h > Remaining Estimate: 0h > > Mockito 2 provides useful features, and the mockito-all module is no longer > generated. -- This message was sent by Atlassian Jira (v8.3.2#803003)
[jira] [Work logged] (BEAM-1009) Upgrade to Mockito 3
[ https://issues.apache.org/jira/browse/BEAM-1009?focusedWorklogId=296804=com.atlassian.jira.plugin.system.issuetabpanels:worklog-tabpanel#worklog-296804 ] ASF GitHub Bot logged work on BEAM-1009: Author: ASF GitHub Bot Created on: 17/Aug/19 16:29 Start Date: 17/Aug/19 16:29 Worklog Time Spent: 10m Work Description: iemejia commented on issue #9338: [BEAM-1009] Upgrade to Mockito 3 URL: https://github.com/apache/beam/pull/9338#issuecomment-522251551 :+1: No hurries, thanks @TimvdLippe This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: us...@infra.apache.org Issue Time Tracking --- Worklog Id: (was: 296804) Time Spent: 2h 40m (was: 2.5h) > Upgrade to Mockito 3 > > > Key: BEAM-1009 > URL: https://issues.apache.org/jira/browse/BEAM-1009 > Project: Beam > Issue Type: Test > Components: sdk-java-core >Reporter: Pei He >Priority: Major > Time Spent: 2h 40m > Remaining Estimate: 0h > > Mockito 2 provides useful features, and the mockito-all module is no longer > generated. -- This message was sent by Atlassian JIRA (v7.6.14#76016)
[jira] [Work logged] (BEAM-1009) Upgrade to Mockito 3
[ https://issues.apache.org/jira/browse/BEAM-1009?focusedWorklogId=296802=com.atlassian.jira.plugin.system.issuetabpanels:worklog-tabpanel#worklog-296802 ] ASF GitHub Bot logged work on BEAM-1009: Author: ASF GitHub Bot Created on: 17/Aug/19 15:21 Start Date: 17/Aug/19 15:21 Worklog Time Spent: 10m Work Description: TimvdLippe commented on issue #9338: [BEAM-1009] Upgrade to Mockito 3 URL: https://github.com/apache/beam/pull/9338#issuecomment-522246602 I can rebase this PR and cleanup its comments on Monday. Then I will also fix the commit message. This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: us...@infra.apache.org Issue Time Tracking --- Worklog Id: (was: 296802) Time Spent: 2.5h (was: 2h 20m) > Upgrade to Mockito 3 > > > Key: BEAM-1009 > URL: https://issues.apache.org/jira/browse/BEAM-1009 > Project: Beam > Issue Type: Test > Components: sdk-java-core >Reporter: Pei He >Priority: Major > Time Spent: 2.5h > Remaining Estimate: 0h > > Mockito 2 provides useful features, and the mockito-all module is no longer > generated. -- This message was sent by Atlassian JIRA (v7.6.14#76016)
[jira] [Work logged] (BEAM-1009) Upgrade to Mockito 3
[ https://issues.apache.org/jira/browse/BEAM-1009?focusedWorklogId=296801=com.atlassian.jira.plugin.system.issuetabpanels:worklog-tabpanel#worklog-296801 ] ASF GitHub Bot logged work on BEAM-1009: Author: ASF GitHub Bot Created on: 17/Aug/19 15:20 Start Date: 17/Aug/19 15:20 Worklog Time Spent: 10m Work Description: iemejia commented on issue #9338: [BEAM-1009] Upgrade to Mockito 3 URL: https://github.com/apache/beam/pull/9338#issuecomment-522246523 Just one minor thing, I just added the existing JIRA identifier to this PR, we may need to update the title of the commit(s) to include it is the default on Beam `[BEAM-1009] ...` This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: us...@infra.apache.org Issue Time Tracking --- Worklog Id: (was: 296801) Time Spent: 2h 20m (was: 2h 10m) > Upgrade to Mockito 3 > > > Key: BEAM-1009 > URL: https://issues.apache.org/jira/browse/BEAM-1009 > Project: Beam > Issue Type: Test > Components: sdk-java-core >Reporter: Pei He >Priority: Major > Time Spent: 2h 20m > Remaining Estimate: 0h > > Mockito 2 provides useful features, and the mockito-all module is no longer > generated. -- This message was sent by Atlassian JIRA (v7.6.14#76016)
