subject:"\[jira\] \[Work logged\] \(BEAM\-7994\) BEAM SDK has compatibility problems with go1.13"

[jira] [Work logged] (BEAM-7994) BEAM SDK has compatibility problems with go1.13

2019-08-19 Thread ASF GitHub Bot (Jira)



 [ 
https://issues.apache.org/jira/browse/BEAM-7994?focusedWorklogId=297356=com.atlassian.jira.plugin.system.issuetabpanels:worklog-tabpanel#worklog-297356
 ]

ASF GitHub Bot logged work on BEAM-7994:


Author: ASF GitHub Bot
Created on: 19/Aug/19 19:04
Start Date: 19/Aug/19 19:04
Worklog Time Spent: 10m 
  Work Description: lostluck commented on issue #9362: [BEAM-7994] Fixing 
unsafe pointer usage for Go 1.13
URL: https://github.com/apache/beam/pull/9362#issuecomment-522712507
 
 
   IIRC there should only be one other use of Unsafe and that's an optmization
   in the ioutilx package so a []byte we know should be allocated on the stack
   isn't put on the heap. (Noescape essentially).
   The only other workaround would be to plumb a concrete type all the way to
   that spot instead of an io.Reader.
   
   On Mon, Aug 19, 2019, 11:02 AM Joe Tsai  wrote:
   
   > *@dsnet* commented on this pull request.
   > --
   >
   > In sdks/go/pkg/beam/core/util/reflectx/functions_test.go
   > :
   >
   > > +func TestXxx(t *testing.T) {
   > +  val := reflect.ValueOf(testFunction)
   > +  fi := uintptr(val.Pointer())
   > +  typ := val.Type()
   > +
   > +  callable := LoadFunction(fi, typ)
   > +
   > +  cv := reflect.ValueOf(callable)
   > +  out := cv.Call(nil)
   > +  if len(out) != 1 {
   > +  t.Errorf("got %d return values, wanted 1.", len(out))
   > +  }
   > +  // TODO: check type?
   > +  if out[0].Int() != 42 {
   > +  t.Errorf("got %d, wanted 42", out[0].Int())
   > +  }
   >
   > Yes, please! :)
   >
   > The lack of a unit test on this function meant that it took several days
   > to track down the issue when there was mysterious memory corruption
   > happening in the entire beam job. A single unit test would have immediately
   > identified this as the culprit.
   >
   > —
   > You are receiving this because you were mentioned.
   > Reply to this email directly, view it on GitHub
   > 
,
   > or mute the thread
   > 

   > .
   >
   
 

This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
 
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org


Issue Time Tracking
---

Worklog Id: (was: 297356)
Time Spent: 3h 20m  (was: 3h 10m)

> BEAM SDK has compatibility problems with go1.13
> ---
>
> Key: BEAM-7994
> URL: https://issues.apache.org/jira/browse/BEAM-7994
> Project: Beam
>  Issue Type: Improvement
>  Components: sdk-go
>Reporter: Bill Neubauer
>Assignee: Bill Neubauer
>Priority: Minor
> Fix For: 2.16.0
>
>  Time Spent: 3h 20m
>  Remaining Estimate: 0h
>
> The Go team identified a problem in the Beam SDK that appears due to runtime 
> changes in Go 1.13, which is upcoming. There is a backwards compatible fix 
> the team recommended.



--
This message was sent by Atlassian Jira
(v8.3.2#803003)

[jira] [Work logged] (BEAM-7994) BEAM SDK has compatibility problems with go1.13

2019-08-19 Thread ASF GitHub Bot (Jira)



 [ 
https://issues.apache.org/jira/browse/BEAM-7994?focusedWorklogId=297344=com.atlassian.jira.plugin.system.issuetabpanels:worklog-tabpanel#worklog-297344
 ]

ASF GitHub Bot logged work on BEAM-7994:


Author: ASF GitHub Bot
Created on: 19/Aug/19 18:02
Start Date: 19/Aug/19 18:02
Worklog Time Spent: 10m 
  Work Description: dsnet commented on pull request #9362: [BEAM-7994] 
Fixing unsafe pointer usage for Go 1.13
URL: https://github.com/apache/beam/pull/9362#discussion_r315339519
 
 

 ##
 File path: sdks/go/pkg/beam/core/util/reflectx/functions_test.go
 ##
 @@ -0,0 +1,43 @@
+// Licensed to the Apache Software Foundation (ASF) under one or more
+// contributor license agreements.  See the NOTICE file distributed with
+// this work for additional information regarding copyright ownership.
+// The ASF licenses this file to You under the Apache License, Version 2.0
+// (the "License"); you may not use this file except in compliance with
+// the License.  You may obtain a copy of the License at
+//
+//http://www.apache.org/licenses/LICENSE-2.0
+//
+// Unless required by applicable law or agreed to in writing, software
+// distributed under the License is distributed on an "AS IS" BASIS,
+// WITHOUT WARRANTIES OR CONDITIONS OF ANY KIND, either express or implied.
+// See the License for the specific language governing permissions and
+// limitations under the License.
+
+package reflectx
+
+import (
+   "reflect"
+   "testing"
+)
+
+func testFunction() int {
+   return 42
+}
+
+func TestXxx(t *testing.T) {
+   val := reflect.ValueOf(testFunction)
+   fi := uintptr(val.Pointer())
+   typ := val.Type()
+
+   callable := LoadFunction(fi, typ)
+
+   cv := reflect.ValueOf(callable)
+   out := cv.Call(nil)
+   if len(out) != 1 {
+   t.Errorf("got %d return values, wanted 1.", len(out))
+   }
+   // TODO: check type?
+   if out[0].Int() != 42 {
+   t.Errorf("got %d, wanted 42", out[0].Int())
+   }
 
 Review comment:
   Yes, please! :)
   
   The lack of a unit test on this function meant that it took several days to 
track down the issue when there was mysterious memory corruption happening in 
the entire beam job. A single unit test would have immediately identified this 
as the culprit.
 

This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
 
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org


Issue Time Tracking
---

Worklog Id: (was: 297344)
Time Spent: 3h 10m  (was: 3h)

> BEAM SDK has compatibility problems with go1.13
> ---
>
> Key: BEAM-7994
> URL: https://issues.apache.org/jira/browse/BEAM-7994
> Project: Beam
>  Issue Type: Improvement
>  Components: sdk-go
>Reporter: Bill Neubauer
>Assignee: Bill Neubauer
>Priority: Minor
> Fix For: 2.16.0
>
>  Time Spent: 3h 10m
>  Remaining Estimate: 0h
>
> The Go team identified a problem in the Beam SDK that appears due to runtime 
> changes in Go 1.13, which is upcoming. There is a backwards compatible fix 
> the team recommended.



--
This message was sent by Atlassian Jira
(v8.3.2#803003)

[jira] [Work logged] (BEAM-7994) BEAM SDK has compatibility problems with go1.13

2019-08-19 Thread ASF GitHub Bot (Jira)



 [ 
https://issues.apache.org/jira/browse/BEAM-7994?focusedWorklogId=297256=com.atlassian.jira.plugin.system.issuetabpanels:worklog-tabpanel#worklog-297256
 ]

ASF GitHub Bot logged work on BEAM-7994:


Author: ASF GitHub Bot
Created on: 19/Aug/19 16:18
Start Date: 19/Aug/19 16:18
Worklog Time Spent: 10m 
  Work Description: wcn3 commented on pull request #9362: [BEAM-7994] 
Fixing unsafe pointer usage for Go 1.13
URL: https://github.com/apache/beam/pull/9362#discussion_r315296527
 
 

 ##
 File path: sdks/go/pkg/beam/core/util/reflectx/functions_test.go
 ##
 @@ -0,0 +1,43 @@
+// Licensed to the Apache Software Foundation (ASF) under one or more
+// contributor license agreements.  See the NOTICE file distributed with
+// this work for additional information regarding copyright ownership.
+// The ASF licenses this file to You under the Apache License, Version 2.0
+// (the "License"); you may not use this file except in compliance with
+// the License.  You may obtain a copy of the License at
+//
+//http://www.apache.org/licenses/LICENSE-2.0
+//
+// Unless required by applicable law or agreed to in writing, software
+// distributed under the License is distributed on an "AS IS" BASIS,
+// WITHOUT WARRANTIES OR CONDITIONS OF ANY KIND, either express or implied.
+// See the License for the specific language governing permissions and
+// limitations under the License.
+
+package reflectx
+
+import (
+   "reflect"
+   "testing"
+)
+
+func testFunction() int {
+   return 42
+}
+
+func TestXxx(t *testing.T) {
+   val := reflect.ValueOf(testFunction)
+   fi := uintptr(val.Pointer())
+   typ := val.Type()
+
+   callable := LoadFunction(fi, typ)
+
+   cv := reflect.ValueOf(callable)
+   out := cv.Call(nil)
+   if len(out) != 1 {
+   t.Errorf("got %d return values, wanted 1.", len(out))
+   }
+   // TODO: check type?
+   if out[0].Int() != 42 {
+   t.Errorf("got %d, wanted 42", out[0].Int())
+   }
 
 Review comment:
   I like this style, since the comma operator helps keep it compact.
   
   Joe made an offline comment that every usage of the unsafe package should be 
accompanied by a unit test. I agree with that, and I'm looking at the remaining 
unsafe usages in the SDK right now. I'll make this tweak in that followup PR.
 

This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
 
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org


Issue Time Tracking
---

Worklog Id: (was: 297256)
Time Spent: 3h  (was: 2h 50m)

> BEAM SDK has compatibility problems with go1.13
> ---
>
> Key: BEAM-7994
> URL: https://issues.apache.org/jira/browse/BEAM-7994
> Project: Beam
>  Issue Type: Improvement
>  Components: sdk-go
>Reporter: Bill Neubauer
>Assignee: Bill Neubauer
>Priority: Minor
> Fix For: 2.16.0
>
>  Time Spent: 3h
>  Remaining Estimate: 0h
>
> The Go team identified a problem in the Beam SDK that appears due to runtime 
> changes in Go 1.13, which is upcoming. There is a backwards compatible fix 
> the team recommended.



--
This message was sent by Atlassian Jira
(v8.3.2#803003)

[jira] [Work logged] (BEAM-7994) BEAM SDK has compatibility problems with go1.13

2019-08-19 Thread ASF GitHub Bot (Jira)



 [ 
https://issues.apache.org/jira/browse/BEAM-7994?focusedWorklogId=297248=com.atlassian.jira.plugin.system.issuetabpanels:worklog-tabpanel#worklog-297248
 ]

ASF GitHub Bot logged work on BEAM-7994:


Author: ASF GitHub Bot
Created on: 19/Aug/19 16:10
Start Date: 19/Aug/19 16:10
Worklog Time Spent: 10m 
  Work Description: lostluck commented on issue #9362: [BEAM-7994] Fixing 
unsafe pointer usage for Go 1.13
URL: https://github.com/apache/beam/pull/9362#issuecomment-522645991
 
 
   I have no additional comments. The discussion here was excellent, and I'm 
glad we'll be able to transition to go1.13 relatively easily. (Beam's Go Module 
status not withstanding...)
 

This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
 
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org


Issue Time Tracking
---

Worklog Id: (was: 297248)
Time Spent: 2h 50m  (was: 2h 40m)

> BEAM SDK has compatibility problems with go1.13
> ---
>
> Key: BEAM-7994
> URL: https://issues.apache.org/jira/browse/BEAM-7994
> Project: Beam
>  Issue Type: Improvement
>  Components: sdk-go
>Reporter: Bill Neubauer
>Assignee: Bill Neubauer
>Priority: Minor
> Fix For: 2.16.0
>
>  Time Spent: 2h 50m
>  Remaining Estimate: 0h
>
> The Go team identified a problem in the Beam SDK that appears due to runtime 
> changes in Go 1.13, which is upcoming. There is a backwards compatible fix 
> the team recommended.



--
This message was sent by Atlassian Jira
(v8.3.2#803003)

[jira] [Work logged] (BEAM-7994) BEAM SDK has compatibility problems with go1.13

2019-08-19 Thread ASF GitHub Bot (Jira)



 [ 
https://issues.apache.org/jira/browse/BEAM-7994?focusedWorklogId=297241=com.atlassian.jira.plugin.system.issuetabpanels:worklog-tabpanel#worklog-297241
 ]

ASF GitHub Bot logged work on BEAM-7994:


Author: ASF GitHub Bot
Created on: 19/Aug/19 16:08
Start Date: 19/Aug/19 16:08
Worklog Time Spent: 10m 
  Work Description: lostluck commented on pull request #9362: [BEAM-7994] 
Fixing unsafe pointer usage for Go 1.13
URL: https://github.com/apache/beam/pull/9362#discussion_r315292601
 
 

 ##
 File path: sdks/go/pkg/beam/core/util/reflectx/functions_test.go
 ##
 @@ -0,0 +1,43 @@
+// Licensed to the Apache Software Foundation (ASF) under one or more
+// contributor license agreements.  See the NOTICE file distributed with
+// this work for additional information regarding copyright ownership.
+// The ASF licenses this file to You under the Apache License, Version 2.0
+// (the "License"); you may not use this file except in compliance with
+// the License.  You may obtain a copy of the License at
+//
+//http://www.apache.org/licenses/LICENSE-2.0
+//
+// Unless required by applicable law or agreed to in writing, software
+// distributed under the License is distributed on an "AS IS" BASIS,
+// WITHOUT WARRANTIES OR CONDITIONS OF ANY KIND, either express or implied.
+// See the License for the specific language governing permissions and
+// limitations under the License.
+
+package reflectx
+
+import (
+   "reflect"
+   "testing"
+)
+
+func testFunction() int {
+   return 42
+}
+
+func TestXxx(t *testing.T) {
+   val := reflect.ValueOf(testFunction)
+   fi := uintptr(val.Pointer())
+   typ := val.Type()
+
+   callable := LoadFunction(fi, typ)
+
+   cv := reflect.ValueOf(callable)
+   out := cv.Call(nil)
+   if len(out) != 1 {
+   t.Errorf("got %d return values, wanted 1.", len(out))
+   }
+   // TODO: check type?
+   if out[0].Int() != 42 {
+   t.Errorf("got %d, wanted 42", out[0].Int())
+   }
 
 Review comment:
   It's a bit more verbose but I've liked the following style since it avoids 
comparing then printing the wrong things accidentally.
   
   if got,want := out[0].Int(), testFunction(); got != want {
 t.Errorf("got %d, wanted %d", got, want)
   }
   
 

This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
 
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org


Issue Time Tracking
---

Worklog Id: (was: 297241)
Time Spent: 2h 40m  (was: 2.5h)

> BEAM SDK has compatibility problems with go1.13
> ---
>
> Key: BEAM-7994
> URL: https://issues.apache.org/jira/browse/BEAM-7994
> Project: Beam
>  Issue Type: Improvement
>  Components: sdk-go
>Reporter: Bill Neubauer
>Assignee: Bill Neubauer
>Priority: Minor
> Fix For: 2.16.0
>
>  Time Spent: 2h 40m
>  Remaining Estimate: 0h
>
> The Go team identified a problem in the Beam SDK that appears due to runtime 
> changes in Go 1.13, which is upcoming. There is a backwards compatible fix 
> the team recommended.



--
This message was sent by Atlassian Jira
(v8.3.2#803003)

[jira] [Work logged] (BEAM-7994) BEAM SDK has compatibility problems with go1.13

2019-08-19 Thread ASF GitHub Bot (Jira)

 [ 
https://issues.apache.org/jira/browse/BEAM-7994?focusedWorklogId=297224=com.atlassian.jira.plugin.system.issuetabpanels:worklog-tabpanel#worklog-297224
 ]

ASF GitHub Bot logged work on BEAM-7994:

Author: ASF GitHub Bot
Created on: 19/Aug/19 15:48
Start Date: 19/Aug/19 15:48
Worklog Time Spent: 10m 
  Work Description: wcn3 commented on issue #9362: [BEAM-7994] Fixing 
unsafe pointer usage for Go 1.13
URL: https://github.com/apache/beam/pull/9362#issuecomment-522637147

   This was a problem revealed in a beta test in an upcoming version of the Go
   SDK. I am not sure Beam wants to set up test coverage for beta SDKs. In
   general, Go has good backwards compatibility guarantees so testing version
   compatibility of older SDKs hasn’t been needed.

   It is entirely possible to set up the sort of testing you describe, but it
   would be of limited use, particularly with regards to this issue. In this
   case, I believe the Go community process worked as intended: as a precursor
   to the Go team releasing betas, they check it against the Google code
   corpus. Since Beam is used by Google, Beam gets the benefit of this testing
   coverage. This PR came about precisely because of those tests.

   On Mon, Aug 19, 2019 at 8:38 AM Lukasz Cwik 
   wrote:

   > Similar to how we are testing different versions of Python 3.5, 3.6, 3.7
   > with the Beam SDK, is there a way to test different Go versions against the
   > Beam SDK to catch these kinds of things?
   >
   > —
   > You are receiving this because you authored the thread.
   > Reply to this email directly, view it on GitHub
   > 
,
   > or mute the thread
   > 

   > .
   >

This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

For queries about this service, please contact Infrastructure at:
us...@infra.apache.org

Issue Time Tracking
---

Worklog Id: (was: 297224)
Time Spent: 2.5h  (was: 2h 20m)

> BEAM SDK has compatibility problems with go1.13
> ---
>
> Key: BEAM-7994
> URL: https://issues.apache.org/jira/browse/BEAM-7994
> Project: Beam
>  Issue Type: Improvement
>  Components: sdk-go
>Reporter: Bill Neubauer
>Assignee: Bill Neubauer
>Priority: Minor
> Fix For: 2.16.0
>
>  Time Spent: 2.5h
>  Remaining Estimate: 0h
>
> The Go team identified a problem in the Beam SDK that appears due to runtime 
> changes in Go 1.13, which is upcoming. There is a backwards compatible fix 
> the team recommended.

--
This message was sent by Atlassian Jira
(v8.3.2#803003)

[jira] [Work logged] (BEAM-7994) BEAM SDK has compatibility problems with go1.13

2019-08-19 Thread ASF GitHub Bot (Jira)



 [ 
https://issues.apache.org/jira/browse/BEAM-7994?focusedWorklogId=297220=com.atlassian.jira.plugin.system.issuetabpanels:worklog-tabpanel#worklog-297220
 ]

ASF GitHub Bot logged work on BEAM-7994:


Author: ASF GitHub Bot
Created on: 19/Aug/19 15:38
Start Date: 19/Aug/19 15:38
Worklog Time Spent: 10m 
  Work Description: lukecwik commented on issue #9362: [BEAM-7994] Fixing 
unsafe pointer usage for Go 1.13
URL: https://github.com/apache/beam/pull/9362#issuecomment-522632690
 
 
   Similar to how we are testing different versions of Python 3.5, 3.6, 3.7 
with the Beam SDK, is there a way to test different Go versions against the 
Beam SDK to catch these kinds of things?
 

This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
 
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org


Issue Time Tracking
---

Worklog Id: (was: 297220)
Time Spent: 2h 20m  (was: 2h 10m)

> BEAM SDK has compatibility problems with go1.13
> ---
>
> Key: BEAM-7994
> URL: https://issues.apache.org/jira/browse/BEAM-7994
> Project: Beam
>  Issue Type: Improvement
>  Components: sdk-go
>Reporter: Bill Neubauer
>Assignee: Bill Neubauer
>Priority: Minor
> Fix For: 2.16.0
>
>  Time Spent: 2h 20m
>  Remaining Estimate: 0h
>
> The Go team identified a problem in the Beam SDK that appears due to runtime 
> changes in Go 1.13, which is upcoming. There is a backwards compatible fix 
> the team recommended.



--
This message was sent by Atlassian Jira
(v8.3.2#803003)

[jira] [Work logged] (BEAM-7994) BEAM SDK has compatibility problems with go1.13

2019-08-19 Thread ASF GitHub Bot (Jira)



 [ 
https://issues.apache.org/jira/browse/BEAM-7994?focusedWorklogId=297219=com.atlassian.jira.plugin.system.issuetabpanels:worklog-tabpanel#worklog-297219
 ]

ASF GitHub Bot logged work on BEAM-7994:


Author: ASF GitHub Bot
Created on: 19/Aug/19 15:37
Start Date: 19/Aug/19 15:37
Worklog Time Spent: 10m 
  Work Description: lukecwik commented on pull request #9362: [BEAM-7994] 
Fixing unsafe pointer usage for Go 1.13
URL: https://github.com/apache/beam/pull/9362
 
 
   
 

This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
 
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org


Issue Time Tracking
---

Worklog Id: (was: 297219)
Time Spent: 2h 10m  (was: 2h)

> BEAM SDK has compatibility problems with go1.13
> ---
>
> Key: BEAM-7994
> URL: https://issues.apache.org/jira/browse/BEAM-7994
> Project: Beam
>  Issue Type: Improvement
>  Components: sdk-go
>Reporter: Bill Neubauer
>Assignee: Bill Neubauer
>Priority: Minor
>  Time Spent: 2h 10m
>  Remaining Estimate: 0h
>
> The Go team identified a problem in the Beam SDK that appears due to runtime 
> changes in Go 1.13, which is upcoming. There is a backwards compatible fix 
> the team recommended.



--
This message was sent by Atlassian Jira
(v8.3.2#803003)

[jira] [Work logged] (BEAM-7994) BEAM SDK has compatibility problems with go1.13

2019-08-16 Thread ASF GitHub Bot (JIRA)



 [ 
https://issues.apache.org/jira/browse/BEAM-7994?focusedWorklogId=296677=com.atlassian.jira.plugin.system.issuetabpanels:worklog-tabpanel#worklog-296677
 ]

ASF GitHub Bot logged work on BEAM-7994:


Author: ASF GitHub Bot
Created on: 17/Aug/19 00:12
Start Date: 17/Aug/19 00:12
Worklog Time Spent: 10m 
  Work Description: youngoli commented on pull request #9362: [BEAM-7994] 
Fixing unsafe pointer usage for Go 1.13
URL: https://github.com/apache/beam/pull/9362#discussion_r314924082
 
 

 ##
 File path: sdks/go/pkg/beam/core/util/reflectx/functions.go
 ##
 @@ -40,6 +40,8 @@ func FunctionName(fn interface{}) string {
 // points to a valid function implementation.
 func LoadFunction(ptr uintptr, t reflect.Type) interface{} {
v := reflect.New(t).Elem()
-   *(*uintptr)(unsafe.Pointer(v.Addr().Pointer())) = 
(uintptr)(unsafe.Pointer())
+   p := new(uintptr)
+   *p = ptr
+   *(*unsafe.Pointer)(unsafe.Pointer(v.Addr().Pointer())) = 
unsafe.Pointer(p)
 
 Review comment:
   Thanks for the nice summary!
 

This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
 
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org


Issue Time Tracking
---

Worklog Id: (was: 296677)
Time Spent: 2h  (was: 1h 50m)

> BEAM SDK has compatibility problems with go1.13
> ---
>
> Key: BEAM-7994
> URL: https://issues.apache.org/jira/browse/BEAM-7994
> Project: Beam
>  Issue Type: Improvement
>  Components: sdk-go
>Reporter: Bill Neubauer
>Assignee: Bill Neubauer
>Priority: Minor
>  Time Spent: 2h
>  Remaining Estimate: 0h
>
> The Go team identified a problem in the Beam SDK that appears due to runtime 
> changes in Go 1.13, which is upcoming. There is a backwards compatible fix 
> the team recommended.



--
This message was sent by Atlassian JIRA
(v7.6.14#76016)

[jira] [Work logged] (BEAM-7994) BEAM SDK has compatibility problems with go1.13

2019-08-16 Thread ASF GitHub Bot (JIRA)



 [ 
https://issues.apache.org/jira/browse/BEAM-7994?focusedWorklogId=296674=com.atlassian.jira.plugin.system.issuetabpanels:worklog-tabpanel#worklog-296674
 ]

ASF GitHub Bot logged work on BEAM-7994:


Author: ASF GitHub Bot
Created on: 17/Aug/19 00:04
Start Date: 17/Aug/19 00:04
Worklog Time Spent: 10m 
  Work Description: wcn3 commented on pull request #9362: [BEAM-7994] 
Fixing unsafe pointer usage for Go 1.13
URL: https://github.com/apache/beam/pull/9362#discussion_r314923417
 
 

 ##
 File path: sdks/go/pkg/beam/core/util/reflectx/functions_test.go
 ##
 @@ -0,0 +1,43 @@
+// Licensed to the Apache Software Foundation (ASF) under one or more
+// contributor license agreements.  See the NOTICE file distributed with
+// this work for additional information regarding copyright ownership.
+// The ASF licenses this file to You under the Apache License, Version 2.0
+// (the "License"); you may not use this file except in compliance with
+// the License.  You may obtain a copy of the License at
+//
+//http://www.apache.org/licenses/LICENSE-2.0
+//
+// Unless required by applicable law or agreed to in writing, software
+// distributed under the License is distributed on an "AS IS" BASIS,
+// WITHOUT WARRANTIES OR CONDITIONS OF ANY KIND, either express or implied.
+// See the License for the specific language governing permissions and
+// limitations under the License.
+
+package reflectx
+
+import (
+   "reflect"
+   "testing"
+)
+
+func testFunction() int {
+   return 42
+}
+
+func TestXxx(t *testing.T) {
+   val := reflect.ValueOf(testFunction)
+   fi := uintptr(val.Pointer())
+   typ := val.Type()
+
+   callable := LoadFunction(fi, typ)
+
+   cv := reflect.ValueOf(callable)
+   out := cv.Call(nil)
+   if len(out) != 1 {
+   t.Errorf("got %d return values, wanted 1.", len(out))
+   }
+   // TODO: check type?
+   if out[0].Int() != 42 {
+   t.Errorf("got %d, wanted 42", out[0].Int())
+   }
 
 Review comment:
   Good point, will change.
 

This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
 
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org


Issue Time Tracking
---

Worklog Id: (was: 296674)
Time Spent: 1h 50m  (was: 1h 40m)

> BEAM SDK has compatibility problems with go1.13
> ---
>
> Key: BEAM-7994
> URL: https://issues.apache.org/jira/browse/BEAM-7994
> Project: Beam
>  Issue Type: Improvement
>  Components: sdk-go
>Reporter: Bill Neubauer
>Assignee: Bill Neubauer
>Priority: Minor
>  Time Spent: 1h 50m
>  Remaining Estimate: 0h
>
> The Go team identified a problem in the Beam SDK that appears due to runtime 
> changes in Go 1.13, which is upcoming. There is a backwards compatible fix 
> the team recommended.



--
This message was sent by Atlassian JIRA
(v7.6.14#76016)

[jira] [Work logged] (BEAM-7994) BEAM SDK has compatibility problems with go1.13

2019-08-16 Thread ASF GitHub Bot (JIRA)



 [ 
https://issues.apache.org/jira/browse/BEAM-7994?focusedWorklogId=296673=com.atlassian.jira.plugin.system.issuetabpanels:worklog-tabpanel#worklog-296673
 ]

ASF GitHub Bot logged work on BEAM-7994:


Author: ASF GitHub Bot
Created on: 17/Aug/19 00:04
Start Date: 17/Aug/19 00:04
Worklog Time Spent: 10m 
  Work Description: wcn3 commented on pull request #9362: [BEAM-7994] 
Fixing unsafe pointer usage for Go 1.13
URL: https://github.com/apache/beam/pull/9362#discussion_r314923396
 
 

 ##
 File path: sdks/go/pkg/beam/core/util/reflectx/functions.go
 ##
 @@ -40,6 +40,8 @@ func FunctionName(fn interface{}) string {
 // points to a valid function implementation.
 func LoadFunction(ptr uintptr, t reflect.Type) interface{} {
v := reflect.New(t).Elem()
-   *(*uintptr)(unsafe.Pointer(v.Addr().Pointer())) = 
(uintptr)(unsafe.Pointer())
+   p := new(uintptr)
+   *p = ptr
+   *(*unsafe.Pointer)(unsafe.Pointer(v.Addr().Pointer())) = 
unsafe.Pointer(p)
 
 Review comment:
   The problem was that the original code relies on the behavior that when  
is evaluated, the resulting anonymous value will be on the heap. The new 
compiler is able to not put it on the heap, and does so, which causes this code 
to crash in Go 1.13.
   
   This change makes the expected behavior explicit by allocating p on the heap 
and then assigning it's pointed-to value to ptr, thus p ==  and the 
remaining code works as before.
   
   The unit test exercises this function. I verified that the old code crashed 
under Go 1.13 (worked in Go 1.12) and the new code works in both versions.
   
 

This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
 
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org


Issue Time Tracking
---

Worklog Id: (was: 296673)
Time Spent: 1h 40m  (was: 1.5h)

> BEAM SDK has compatibility problems with go1.13
> ---
>
> Key: BEAM-7994
> URL: https://issues.apache.org/jira/browse/BEAM-7994
> Project: Beam
>  Issue Type: Improvement
>  Components: sdk-go
>Reporter: Bill Neubauer
>Assignee: Bill Neubauer
>Priority: Minor
>  Time Spent: 1h 40m
>  Remaining Estimate: 0h
>
> The Go team identified a problem in the Beam SDK that appears due to runtime 
> changes in Go 1.13, which is upcoming. There is a backwards compatible fix 
> the team recommended.



--
This message was sent by Atlassian JIRA
(v7.6.14#76016)

[jira] [Work logged] (BEAM-7994) BEAM SDK has compatibility problems with go1.13

2019-08-16 Thread ASF GitHub Bot (JIRA)



 [ 
https://issues.apache.org/jira/browse/BEAM-7994?focusedWorklogId=296671=com.atlassian.jira.plugin.system.issuetabpanels:worklog-tabpanel#worklog-296671
 ]

ASF GitHub Bot logged work on BEAM-7994:


Author: ASF GitHub Bot
Created on: 17/Aug/19 00:00
Start Date: 17/Aug/19 00:00
Worklog Time Spent: 10m 
  Work Description: wcn3 commented on pull request #9362: [BEAM-7994] 
Fixing unsafe pointer usage for Go 1.13
URL: https://github.com/apache/beam/pull/9362#discussion_r314922876
 
 

 ##
 File path: sdks/go/pkg/beam/core/util/reflectx/functions_test.go
 ##
 @@ -0,0 +1,43 @@
+// Licensed to the Apache Software Foundation (ASF) under one or more
+// contributor license agreements.  See the NOTICE file distributed with
+// this work for additional information regarding copyright ownership.
+// The ASF licenses this file to You under the Apache License, Version 2.0
+// (the "License"); you may not use this file except in compliance with
+// the License.  You may obtain a copy of the License at
+//
+//http://www.apache.org/licenses/LICENSE-2.0
+//
+// Unless required by applicable law or agreed to in writing, software
+// distributed under the License is distributed on an "AS IS" BASIS,
+// WITHOUT WARRANTIES OR CONDITIONS OF ANY KIND, either express or implied.
+// See the License for the specific language governing permissions and
+// limitations under the License.
+
+package reflectx
+
+import (
+   "reflect"
+   "testing"
+)
+
+func testFunction() int {
+   return 42
+}
+
+func TestXxx(t *testing.T) {
 
 Review comment:
   I thought the last commit fixed this, but clearly not. Will fix.
 

This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
 
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org


Issue Time Tracking
---

Worklog Id: (was: 296671)
Time Spent: 1.5h  (was: 1h 20m)

> BEAM SDK has compatibility problems with go1.13
> ---
>
> Key: BEAM-7994
> URL: https://issues.apache.org/jira/browse/BEAM-7994
> Project: Beam
>  Issue Type: Improvement
>  Components: sdk-go
>Reporter: Bill Neubauer
>Assignee: Bill Neubauer
>Priority: Minor
>  Time Spent: 1.5h
>  Remaining Estimate: 0h
>
> The Go team identified a problem in the Beam SDK that appears due to runtime 
> changes in Go 1.13, which is upcoming. There is a backwards compatible fix 
> the team recommended.



--
This message was sent by Atlassian JIRA
(v7.6.14#76016)

[jira] [Work logged] (BEAM-7994) BEAM SDK has compatibility problems with go1.13

2019-08-16 Thread ASF GitHub Bot (JIRA)



 [ 
https://issues.apache.org/jira/browse/BEAM-7994?focusedWorklogId=296636=com.atlassian.jira.plugin.system.issuetabpanels:worklog-tabpanel#worklog-296636
 ]

ASF GitHub Bot logged work on BEAM-7994:


Author: ASF GitHub Bot
Created on: 16/Aug/19 22:37
Start Date: 16/Aug/19 22:37
Worklog Time Spent: 10m 
  Work Description: youngoli commented on pull request #9362: [BEAM-7994] 
Fixing unsafe pointer usage for Go 1.13
URL: https://github.com/apache/beam/pull/9362#discussion_r314909460
 
 

 ##
 File path: sdks/go/pkg/beam/core/util/reflectx/functions_test.go
 ##
 @@ -0,0 +1,43 @@
+// Licensed to the Apache Software Foundation (ASF) under one or more
+// contributor license agreements.  See the NOTICE file distributed with
+// this work for additional information regarding copyright ownership.
+// The ASF licenses this file to You under the Apache License, Version 2.0
+// (the "License"); you may not use this file except in compliance with
+// the License.  You may obtain a copy of the License at
+//
+//http://www.apache.org/licenses/LICENSE-2.0
+//
+// Unless required by applicable law or agreed to in writing, software
+// distributed under the License is distributed on an "AS IS" BASIS,
+// WITHOUT WARRANTIES OR CONDITIONS OF ANY KIND, either express or implied.
+// See the License for the specific language governing permissions and
+// limitations under the License.
+
+package reflectx
+
+import (
+   "reflect"
+   "testing"
+)
+
+func testFunction() int {
+   return 42
+}
+
+func TestXxx(t *testing.T) {
 
 Review comment:
   Yeah, the name here seems wrong.
 

This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
 
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org


Issue Time Tracking
---

Worklog Id: (was: 296636)
Time Spent: 1h 20m  (was: 1h 10m)

> BEAM SDK has compatibility problems with go1.13
> ---
>
> Key: BEAM-7994
> URL: https://issues.apache.org/jira/browse/BEAM-7994
> Project: Beam
>  Issue Type: Improvement
>  Components: sdk-go
>Reporter: Bill Neubauer
>Assignee: Bill Neubauer
>Priority: Minor
>  Time Spent: 1h 20m
>  Remaining Estimate: 0h
>
> The Go team identified a problem in the Beam SDK that appears due to runtime 
> changes in Go 1.13, which is upcoming. There is a backwards compatible fix 
> the team recommended.



--
This message was sent by Atlassian JIRA
(v7.6.14#76016)

[jira] [Work logged] (BEAM-7994) BEAM SDK has compatibility problems with go1.13

2019-08-16 Thread ASF GitHub Bot (JIRA)



 [ 
https://issues.apache.org/jira/browse/BEAM-7994?focusedWorklogId=296632=com.atlassian.jira.plugin.system.issuetabpanels:worklog-tabpanel#worklog-296632
 ]

ASF GitHub Bot logged work on BEAM-7994:


Author: ASF GitHub Bot
Created on: 16/Aug/19 22:36
Start Date: 16/Aug/19 22:36
Worklog Time Spent: 10m 
  Work Description: youngoli commented on pull request #9362: [BEAM-7994] 
Fixing unsafe pointer usage for Go 1.13
URL: https://github.com/apache/beam/pull/9362#discussion_r314909234
 
 

 ##
 File path: sdks/go/pkg/beam/core/util/reflectx/functions.go
 ##
 @@ -40,6 +40,8 @@ func FunctionName(fn interface{}) string {
 // points to a valid function implementation.
 func LoadFunction(ptr uintptr, t reflect.Type) interface{} {
v := reflect.New(t).Elem()
-   *(*uintptr)(unsafe.Pointer(v.Addr().Pointer())) = 
(uintptr)(unsafe.Pointer())
+   p := new(uintptr)
+   *p = ptr
+   *(*unsafe.Pointer)(unsafe.Pointer(v.Addr().Pointer())) = 
unsafe.Pointer(p)
 
 Review comment:
   I had to read up a bit on how reflect and unsafe work to understand what was 
happening here, but I still don't understand exactly why the previous version 
was invalid and this one valid. (I'm using 
https://golang.org/pkg/unsafe/#Pointer as a guideline).
   
   Is it because in the old version we simply put in the address to `ptr`, and 
in the new one we actually create a new copy?
   
   Or is it because in the old version we're reassigning to `v` as a `uintptr` 
instead of as an `unsafe.Pointer`?
   
   Those are the only real differences I could figure out.
 

This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
 
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org


Issue Time Tracking
---

Worklog Id: (was: 296632)
Time Spent: 50m  (was: 40m)

> BEAM SDK has compatibility problems with go1.13
> ---
>
> Key: BEAM-7994
> URL: https://issues.apache.org/jira/browse/BEAM-7994
> Project: Beam
>  Issue Type: Improvement
>  Components: sdk-go
>Reporter: Bill Neubauer
>Assignee: Bill Neubauer
>Priority: Minor
>  Time Spent: 50m
>  Remaining Estimate: 0h
>
> The Go team identified a problem in the Beam SDK that appears due to runtime 
> changes in Go 1.13, which is upcoming. There is a backwards compatible fix 
> the team recommended.



--
This message was sent by Atlassian JIRA
(v7.6.14#76016)

[jira] [Work logged] (BEAM-7994) BEAM SDK has compatibility problems with go1.13

2019-08-16 Thread ASF GitHub Bot (JIRA)



 [ 
https://issues.apache.org/jira/browse/BEAM-7994?focusedWorklogId=296635=com.atlassian.jira.plugin.system.issuetabpanels:worklog-tabpanel#worklog-296635
 ]

ASF GitHub Bot logged work on BEAM-7994:


Author: ASF GitHub Bot
Created on: 16/Aug/19 22:36
Start Date: 16/Aug/19 22:36
Worklog Time Spent: 10m 
  Work Description: youngoli commented on pull request #9362: [BEAM-7994] 
Fixing unsafe pointer usage for Go 1.13
URL: https://github.com/apache/beam/pull/9362#discussion_r314910880
 
 

 ##
 File path: sdks/go/pkg/beam/core/util/reflectx/functions_test.go
 ##
 @@ -0,0 +1,43 @@
+// Licensed to the Apache Software Foundation (ASF) under one or more
+// contributor license agreements.  See the NOTICE file distributed with
+// this work for additional information regarding copyright ownership.
+// The ASF licenses this file to You under the Apache License, Version 2.0
+// (the "License"); you may not use this file except in compliance with
+// the License.  You may obtain a copy of the License at
+//
+//http://www.apache.org/licenses/LICENSE-2.0
+//
+// Unless required by applicable law or agreed to in writing, software
+// distributed under the License is distributed on an "AS IS" BASIS,
+// WITHOUT WARRANTIES OR CONDITIONS OF ANY KIND, either express or implied.
+// See the License for the specific language governing permissions and
+// limitations under the License.
+
+package reflectx
+
+import (
+   "reflect"
+   "testing"
+)
+
+func testFunction() int {
+   return 42
+}
+
+func TestXxx(t *testing.T) {
+   val := reflect.ValueOf(testFunction)
+   fi := uintptr(val.Pointer())
+   typ := val.Type()
+
+   callable := LoadFunction(fi, typ)
+
+   cv := reflect.ValueOf(callable)
+   out := cv.Call(nil)
+   if len(out) != 1 {
+   t.Errorf("got %d return values, wanted 1.", len(out))
+   }
+   // TODO: check type?
+   if out[0].Int() != 42 {
+   t.Errorf("got %d, wanted 42", out[0].Int())
+   }
 
 Review comment:
   Nit: Instead of comparing to 42 directly, could you do something like:
   
   ```
   expected := testFunction()
   if out[0].Int() != expected {
t.Errorf("got %d, wanted %d", out[0].Int(), expected)
   }
   ```
 

This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
 
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org


Issue Time Tracking
---

Worklog Id: (was: 296635)

> BEAM SDK has compatibility problems with go1.13
> ---
>
> Key: BEAM-7994
> URL: https://issues.apache.org/jira/browse/BEAM-7994
> Project: Beam
>  Issue Type: Improvement
>  Components: sdk-go
>Reporter: Bill Neubauer
>Assignee: Bill Neubauer
>Priority: Minor
>  Time Spent: 1h 10m
>  Remaining Estimate: 0h
>
> The Go team identified a problem in the Beam SDK that appears due to runtime 
> changes in Go 1.13, which is upcoming. There is a backwards compatible fix 
> the team recommended.



--
This message was sent by Atlassian JIRA
(v7.6.14#76016)

[jira] [Work logged] (BEAM-7994) BEAM SDK has compatibility problems with go1.13

2019-08-16 Thread ASF GitHub Bot (JIRA)



 [ 
https://issues.apache.org/jira/browse/BEAM-7994?focusedWorklogId=296634=com.atlassian.jira.plugin.system.issuetabpanels:worklog-tabpanel#worklog-296634
 ]

ASF GitHub Bot logged work on BEAM-7994:


Author: ASF GitHub Bot
Created on: 16/Aug/19 22:36
Start Date: 16/Aug/19 22:36
Worklog Time Spent: 10m 
  Work Description: youngoli commented on pull request #9362: [BEAM-7994] 
Fixing unsafe pointer usage for Go 1.13
URL: https://github.com/apache/beam/pull/9362#discussion_r314909460
 
 

 ##
 File path: sdks/go/pkg/beam/core/util/reflectx/functions_test.go
 ##
 @@ -0,0 +1,43 @@
+// Licensed to the Apache Software Foundation (ASF) under one or more
+// contributor license agreements.  See the NOTICE file distributed with
+// this work for additional information regarding copyright ownership.
+// The ASF licenses this file to You under the Apache License, Version 2.0
+// (the "License"); you may not use this file except in compliance with
+// the License.  You may obtain a copy of the License at
+//
+//http://www.apache.org/licenses/LICENSE-2.0
+//
+// Unless required by applicable law or agreed to in writing, software
+// distributed under the License is distributed on an "AS IS" BASIS,
+// WITHOUT WARRANTIES OR CONDITIONS OF ANY KIND, either express or implied.
+// See the License for the specific language governing permissions and
+// limitations under the License.
+
+package reflectx
+
+import (
+   "reflect"
+   "testing"
+)
+
+func testFunction() int {
+   return 42
+}
+
+func TestXxx(t *testing.T) {
 
 Review comment:
   Yeah, the name here seems wrong.
 

This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
 
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org


Issue Time Tracking
---

Worklog Id: (was: 296634)
Time Spent: 1h 10m  (was: 1h)

> BEAM SDK has compatibility problems with go1.13
> ---
>
> Key: BEAM-7994
> URL: https://issues.apache.org/jira/browse/BEAM-7994
> Project: Beam
>  Issue Type: Improvement
>  Components: sdk-go
>Reporter: Bill Neubauer
>Assignee: Bill Neubauer
>Priority: Minor
>  Time Spent: 1h 10m
>  Remaining Estimate: 0h
>
> The Go team identified a problem in the Beam SDK that appears due to runtime 
> changes in Go 1.13, which is upcoming. There is a backwards compatible fix 
> the team recommended.



--
This message was sent by Atlassian JIRA
(v7.6.14#76016)

[jira] [Work logged] (BEAM-7994) BEAM SDK has compatibility problems with go1.13

2019-08-16 Thread ASF GitHub Bot (JIRA)



 [ 
https://issues.apache.org/jira/browse/BEAM-7994?focusedWorklogId=296633=com.atlassian.jira.plugin.system.issuetabpanels:worklog-tabpanel#worklog-296633
 ]

ASF GitHub Bot logged work on BEAM-7994:


Author: ASF GitHub Bot
Created on: 16/Aug/19 22:36
Start Date: 16/Aug/19 22:36
Worklog Time Spent: 10m 
  Work Description: youngoli commented on pull request #9362: [BEAM-7994] 
Fixing unsafe pointer usage for Go 1.13
URL: https://github.com/apache/beam/pull/9362#discussion_r314910919
 
 

 ##
 File path: sdks/go/pkg/beam/core/util/reflectx/functions_test.go
 ##
 @@ -0,0 +1,43 @@
+// Licensed to the Apache Software Foundation (ASF) under one or more
+// contributor license agreements.  See the NOTICE file distributed with
+// this work for additional information regarding copyright ownership.
+// The ASF licenses this file to You under the Apache License, Version 2.0
+// (the "License"); you may not use this file except in compliance with
+// the License.  You may obtain a copy of the License at
+//
+//http://www.apache.org/licenses/LICENSE-2.0
+//
+// Unless required by applicable law or agreed to in writing, software
+// distributed under the License is distributed on an "AS IS" BASIS,
+// WITHOUT WARRANTIES OR CONDITIONS OF ANY KIND, either express or implied.
+// See the License for the specific language governing permissions and
+// limitations under the License.
+
+package reflectx
+
+import (
+   "reflect"
+   "testing"
+)
+
+func testFunction() int {
+   return 42
+}
+
+func TestXxx(t *testing.T) {
 
 Review comment:
   +1, name seems off.
 

This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
 
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org


Issue Time Tracking
---

Worklog Id: (was: 296633)
Time Spent: 1h  (was: 50m)

> BEAM SDK has compatibility problems with go1.13
> ---
>
> Key: BEAM-7994
> URL: https://issues.apache.org/jira/browse/BEAM-7994
> Project: Beam
>  Issue Type: Improvement
>  Components: sdk-go
>Reporter: Bill Neubauer
>Assignee: Bill Neubauer
>Priority: Minor
>  Time Spent: 1h
>  Remaining Estimate: 0h
>
> The Go team identified a problem in the Beam SDK that appears due to runtime 
> changes in Go 1.13, which is upcoming. There is a backwards compatible fix 
> the team recommended.



--
This message was sent by Atlassian JIRA
(v7.6.14#76016)

[jira] [Work logged] (BEAM-7994) BEAM SDK has compatibility problems with go1.13

2019-08-16 Thread ASF GitHub Bot (JIRA)



 [ 
https://issues.apache.org/jira/browse/BEAM-7994?focusedWorklogId=296619=com.atlassian.jira.plugin.system.issuetabpanels:worklog-tabpanel#worklog-296619
 ]

ASF GitHub Bot logged work on BEAM-7994:


Author: ASF GitHub Bot
Created on: 16/Aug/19 21:55
Start Date: 16/Aug/19 21:55
Worklog Time Spent: 10m 
  Work Description: dsnet commented on issue #9362: [BEAM-7994] Fixing 
unsafe pointer usage for Go 1.13
URL: https://github.com/apache/beam/pull/9362#issuecomment-522163621
 
 
   More background can be found here: golang/go#33662
 

This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
 
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org


Issue Time Tracking
---

Worklog Id: (was: 296619)
Time Spent: 40m  (was: 0.5h)

> BEAM SDK has compatibility problems with go1.13
> ---
>
> Key: BEAM-7994
> URL: https://issues.apache.org/jira/browse/BEAM-7994
> Project: Beam
>  Issue Type: Improvement
>  Components: sdk-go
>Reporter: Bill Neubauer
>Assignee: Bill Neubauer
>Priority: Minor
>  Time Spent: 40m
>  Remaining Estimate: 0h
>
> The Go team identified a problem in the Beam SDK that appears due to runtime 
> changes in Go 1.13, which is upcoming. There is a backwards compatible fix 
> the team recommended.



--
This message was sent by Atlassian JIRA
(v7.6.14#76016)

[jira] [Work logged] (BEAM-7994) BEAM SDK has compatibility problems with go1.13

2019-08-16 Thread ASF GitHub Bot (JIRA)



 [ 
https://issues.apache.org/jira/browse/BEAM-7994?focusedWorklogId=296597=com.atlassian.jira.plugin.system.issuetabpanels:worklog-tabpanel#worklog-296597
 ]

ASF GitHub Bot logged work on BEAM-7994:


Author: ASF GitHub Bot
Created on: 16/Aug/19 21:32
Start Date: 16/Aug/19 21:32
Worklog Time Spent: 10m 
  Work Description: dsnet commented on pull request #9362: [BEAM-7994] 
Fixing unsafe pointer usage for Go 1.13
URL: https://github.com/apache/beam/pull/9362#discussion_r314897093
 
 

 ##
 File path: sdks/go/pkg/beam/core/util/reflectx/functions_test.go
 ##
 @@ -0,0 +1,43 @@
+// Licensed to the Apache Software Foundation (ASF) under one or more
+// contributor license agreements.  See the NOTICE file distributed with
+// this work for additional information regarding copyright ownership.
+// The ASF licenses this file to You under the Apache License, Version 2.0
+// (the "License"); you may not use this file except in compliance with
+// the License.  You may obtain a copy of the License at
+//
+//http://www.apache.org/licenses/LICENSE-2.0
+//
+// Unless required by applicable law or agreed to in writing, software
+// distributed under the License is distributed on an "AS IS" BASIS,
+// WITHOUT WARRANTIES OR CONDITIONS OF ANY KIND, either express or implied.
+// See the License for the specific language governing permissions and
+// limitations under the License.
+
+package reflectx
+
+import (
+   "reflect"
+   "testing"
+)
+
+func testFunction() int {
+   return 42
+}
+
+func TestXxx(t *testing.T) {
 
 Review comment:
   `TestLoadFunction`?
 

This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
 
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org


Issue Time Tracking
---

Worklog Id: (was: 296597)
Time Spent: 0.5h  (was: 20m)

> BEAM SDK has compatibility problems with go1.13
> ---
>
> Key: BEAM-7994
> URL: https://issues.apache.org/jira/browse/BEAM-7994
> Project: Beam
>  Issue Type: Improvement
>  Components: sdk-go
>Reporter: Bill Neubauer
>Assignee: Bill Neubauer
>Priority: Minor
>  Time Spent: 0.5h
>  Remaining Estimate: 0h
>
> The Go team identified a problem in the Beam SDK that appears due to runtime 
> changes in Go 1.13, which is upcoming. There is a backwards compatible fix 
> the team recommended.



--
This message was sent by Atlassian JIRA
(v7.6.14#76016)

[jira] [Work logged] (BEAM-7994) BEAM SDK has compatibility problems with go1.13

2019-08-16 Thread ASF GitHub Bot (JIRA)



 [ 
https://issues.apache.org/jira/browse/BEAM-7994?focusedWorklogId=296546=com.atlassian.jira.plugin.system.issuetabpanels:worklog-tabpanel#worklog-296546
 ]

ASF GitHub Bot logged work on BEAM-7994:


Author: ASF GitHub Bot
Created on: 16/Aug/19 20:25
Start Date: 16/Aug/19 20:25
Worklog Time Spent: 10m 
  Work Description: wcn3 commented on issue #9362: [BEAM-7994] Fixing 
unsafe pointer usage for Go 1.13
URL: https://github.com/apache/beam/pull/9362#issuecomment-522140404
 
 
   R: @lostluck @lukecwik 
 

This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
 
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org


Issue Time Tracking
---

Worklog Id: (was: 296546)
Time Spent: 20m  (was: 10m)

> BEAM SDK has compatibility problems with go1.13
> ---
>
> Key: BEAM-7994
> URL: https://issues.apache.org/jira/browse/BEAM-7994
> Project: Beam
>  Issue Type: Improvement
>  Components: sdk-go
>Reporter: Bill Neubauer
>Assignee: Bill Neubauer
>Priority: Minor
>  Time Spent: 20m
>  Remaining Estimate: 0h
>
> The Go team identified a problem in the Beam SDK that appears due to runtime 
> changes in Go 1.13, which is upcoming. There is a backwards compatible fix 
> the team recommended.



--
This message was sent by Atlassian JIRA
(v7.6.14#76016)

[jira] [Work logged] (BEAM-7994) BEAM SDK has compatibility problems with go1.13

2019-08-16 Thread ASF GitHub Bot (JIRA)



 [ 
https://issues.apache.org/jira/browse/BEAM-7994?focusedWorklogId=296544=com.atlassian.jira.plugin.system.issuetabpanels:worklog-tabpanel#worklog-296544
 ]

ASF GitHub Bot logged work on BEAM-7994:


Author: ASF GitHub Bot
Created on: 16/Aug/19 20:24
Start Date: 16/Aug/19 20:24
Worklog Time Spent: 10m 
  Work Description: wcn3 commented on pull request #9362: [BEAM-7994] 
Fixing unsafe pointer usage for Go 1.13
URL: https://github.com/apache/beam/pull/9362
 
 
   The Go team identified a problem in the Beam SDK that appears due to runtime 
changes in Go 1.13, which is upcoming. This is the backwards compatible fix the 
team recommended.
 

This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
 
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org


Issue Time Tracking
---

Worklog Id: (was: 296544)
Time Spent: 10m
Remaining Estimate: 0h

> BEAM SDK has compatibility problems with go1.13
> ---
>
> Key: BEAM-7994
> URL: https://issues.apache.org/jira/browse/BEAM-7994
> Project: Beam
>  Issue Type: Improvement
>  Components: sdk-go
>Reporter: Bill Neubauer
>Assignee: Bill Neubauer
>Priority: Minor
>  Time Spent: 10m
>  Remaining Estimate: 0h
>
> The Go team identified a problem in the Beam SDK that appears due to runtime 
> changes in Go 1.13, which is upcoming. There is a backwards compatible fix 
> the team recommended.



--
This message was sent by Atlassian JIRA
(v7.6.14#76016)

[jira] [Work logged] (BEAM-7994) BEAM SDK has compatibility problems with go1.13

[jira] [Work logged] (BEAM-7994) BEAM SDK has compatibility problems with go1.13

[jira] [Work logged] (BEAM-7994) BEAM SDK has compatibility problems with go1.13

[jira] [Work logged] (BEAM-7994) BEAM SDK has compatibility problems with go1.13

[jira] [Work logged] (BEAM-7994) BEAM SDK has compatibility problems with go1.13

[jira] [Work logged] (BEAM-7994) BEAM SDK has compatibility problems with go1.13

[jira] [Work logged] (BEAM-7994) BEAM SDK has compatibility problems with go1.13

[jira] [Work logged] (BEAM-7994) BEAM SDK has compatibility problems with go1.13

[jira] [Work logged] (BEAM-7994) BEAM SDK has compatibility problems with go1.13

[jira] [Work logged] (BEAM-7994) BEAM SDK has compatibility problems with go1.13

[jira] [Work logged] (BEAM-7994) BEAM SDK has compatibility problems with go1.13

[jira] [Work logged] (BEAM-7994) BEAM SDK has compatibility problems with go1.13

[jira] [Work logged] (BEAM-7994) BEAM SDK has compatibility problems with go1.13

[jira] [Work logged] (BEAM-7994) BEAM SDK has compatibility problems with go1.13

[jira] [Work logged] (BEAM-7994) BEAM SDK has compatibility problems with go1.13

[jira] [Work logged] (BEAM-7994) BEAM SDK has compatibility problems with go1.13

[jira] [Work logged] (BEAM-7994) BEAM SDK has compatibility problems with go1.13

[jira] [Work logged] (BEAM-7994) BEAM SDK has compatibility problems with go1.13

[jira] [Work logged] (BEAM-7994) BEAM SDK has compatibility problems with go1.13

[jira] [Work logged] (BEAM-7994) BEAM SDK has compatibility problems with go1.13

[jira] [Work logged] (BEAM-7994) BEAM SDK has compatibility problems with go1.13

21 matches

Site Navigation

Mail list logo

Footer information