[jira] [Work logged] (BEAM-8164) Correct document for building the python SDK harness container
[ https://issues.apache.org/jira/browse/BEAM-8164?focusedWorklogId=326140=com.atlassian.jira.plugin.system.issuetabpanels:worklog-tabpanel#worklog-326140 ] ASF GitHub Bot logged work on BEAM-8164: Author: ASF GitHub Bot Created on: 10/Oct/19 06:31 Start Date: 10/Oct/19 06:31 Worklog Time Spent: 10m Work Description: sunjincheng121 commented on issue #9536: [BEAM-8164][website] Correct document for building the python SDK ha… URL: https://github.com/apache/beam/pull/9536#issuecomment-540404321 Thanks @ibzib ! This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: us...@infra.apache.org Issue Time Tracking --- Worklog Id: (was: 326140) Time Spent: 2h 40m (was: 2.5h) > Correct document for building the python SDK harness container > -- > > Key: BEAM-8164 > URL: https://issues.apache.org/jira/browse/BEAM-8164 > Project: Beam > Issue Type: Bug > Components: website >Reporter: sunjincheng >Assignee: sunjincheng >Priority: Major > Time Spent: 2h 40m > Remaining Estimate: 0h > > In the runner document, it is described that we can use the command: > `./gradlew :sdks:python:container:docker` > to Build the SDK harness container, see > ([https://beam.apache.org/documentation/runners/flink/)]. > However, the docker config has been removed with the latest python3 docker > related commit [1] the command would failed with the following error message. > {code:java} > > Task :sdks:python:container:docker FAILED > FAILURE: Build failed with an exception. > * What went wrong: > Execution failed for task ':sdks:python:container:docker'. > > name is a required docker configuration item.{code} > I think we should also adapt the document with command: `./gradlew > :sdks:python:container:py2:docker`? Or add the config when run > `:sdks:python:container:docker` auto run all the python version docker? > > What do you think? > > [1] > [https://github.com/apache/beam/commit/47feeafb21023e2a60ae51737cc4000a2033719c#diff-1bc5883bcfcc9e883ab7df09e4dcddb0L63] -- This message was sent by Atlassian Jira (v8.3.4#803005)
[jira] [Work logged] (BEAM-8164) Correct document for building the python SDK harness container
[ https://issues.apache.org/jira/browse/BEAM-8164?focusedWorklogId=325821=com.atlassian.jira.plugin.system.issuetabpanels:worklog-tabpanel#worklog-325821 ] ASF GitHub Bot logged work on BEAM-8164: Author: ASF GitHub Bot Created on: 09/Oct/19 16:56 Start Date: 09/Oct/19 16:56 Worklog Time Spent: 10m Work Description: ibzib commented on issue #9536: [BEAM-8164][website] Correct document for building the python SDK ha… URL: https://github.com/apache/beam/pull/9536#issuecomment-540090866 Thanks for updating this Jincheng. I'll fix the Flink command issue in a separate PR. This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: us...@infra.apache.org Issue Time Tracking --- Worklog Id: (was: 325821) Time Spent: 2h 20m (was: 2h 10m) > Correct document for building the python SDK harness container > -- > > Key: BEAM-8164 > URL: https://issues.apache.org/jira/browse/BEAM-8164 > Project: Beam > Issue Type: Bug > Components: website >Reporter: sunjincheng >Assignee: sunjincheng >Priority: Major > Time Spent: 2h 20m > Remaining Estimate: 0h > > In the runner document, it is described that we can use the command: > `./gradlew :sdks:python:container:docker` > to Build the SDK harness container, see > ([https://beam.apache.org/documentation/runners/flink/)]. > However, the docker config has been removed with the latest python3 docker > related commit [1] the command would failed with the following error message. > {code:java} > > Task :sdks:python:container:docker FAILED > FAILURE: Build failed with an exception. > * What went wrong: > Execution failed for task ':sdks:python:container:docker'. > > name is a required docker configuration item.{code} > I think we should also adapt the document with command: `./gradlew > :sdks:python:container:py2:docker`? Or add the config when run > `:sdks:python:container:docker` auto run all the python version docker? > > What do you think? > > [1] > [https://github.com/apache/beam/commit/47feeafb21023e2a60ae51737cc4000a2033719c#diff-1bc5883bcfcc9e883ab7df09e4dcddb0L63] -- This message was sent by Atlassian Jira (v8.3.4#803005)
[jira] [Work logged] (BEAM-8164) Correct document for building the python SDK harness container
[ https://issues.apache.org/jira/browse/BEAM-8164?focusedWorklogId=325822=com.atlassian.jira.plugin.system.issuetabpanels:worklog-tabpanel#worklog-325822 ] ASF GitHub Bot logged work on BEAM-8164: Author: ASF GitHub Bot Created on: 09/Oct/19 16:56 Start Date: 09/Oct/19 16:56 Worklog Time Spent: 10m Work Description: ibzib commented on pull request #9536: [BEAM-8164][website] Correct document for building the python SDK ha… URL: https://github.com/apache/beam/pull/9536 This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: us...@infra.apache.org Issue Time Tracking --- Worklog Id: (was: 325822) Time Spent: 2.5h (was: 2h 20m) > Correct document for building the python SDK harness container > -- > > Key: BEAM-8164 > URL: https://issues.apache.org/jira/browse/BEAM-8164 > Project: Beam > Issue Type: Bug > Components: website >Reporter: sunjincheng >Assignee: sunjincheng >Priority: Major > Time Spent: 2.5h > Remaining Estimate: 0h > > In the runner document, it is described that we can use the command: > `./gradlew :sdks:python:container:docker` > to Build the SDK harness container, see > ([https://beam.apache.org/documentation/runners/flink/)]. > However, the docker config has been removed with the latest python3 docker > related commit [1] the command would failed with the following error message. > {code:java} > > Task :sdks:python:container:docker FAILED > FAILURE: Build failed with an exception. > * What went wrong: > Execution failed for task ':sdks:python:container:docker'. > > name is a required docker configuration item.{code} > I think we should also adapt the document with command: `./gradlew > :sdks:python:container:py2:docker`? Or add the config when run > `:sdks:python:container:docker` auto run all the python version docker? > > What do you think? > > [1] > [https://github.com/apache/beam/commit/47feeafb21023e2a60ae51737cc4000a2033719c#diff-1bc5883bcfcc9e883ab7df09e4dcddb0L63] -- This message was sent by Atlassian Jira (v8.3.4#803005)
[jira] [Work logged] (BEAM-8164) Correct document for building the python SDK harness container
[ https://issues.apache.org/jira/browse/BEAM-8164?focusedWorklogId=325816=com.atlassian.jira.plugin.system.issuetabpanels:worklog-tabpanel#worklog-325816 ] ASF GitHub Bot logged work on BEAM-8164: Author: ASF GitHub Bot Created on: 09/Oct/19 16:53 Start Date: 09/Oct/19 16:53 Worklog Time Spent: 10m Work Description: ibzib commented on pull request #9536: [BEAM-8164][website] Correct document for building the python SDK ha… URL: https://github.com/apache/beam/pull/9536#discussion_r333123112 ## File path: sdks/python/apache_beam/runners/interactive/README.md ## @@ -224,7 +224,7 @@ You can choose to run Interactive Beam on Flink with the following settings. * Build the SDK container and start the local FlinkService. ```bash -$ ./gradlew -p sdks/python/container docker +$ ./gradlew -p sdks/python/container/py35 docker # Optionally replace py35 with the Python version of your choice $ ./gradlew beam-runners-flink_2.11-job-server:runShadow # Blocking Review comment: I noticed this is also out of date (`Project 'beam-runners-flink_2.11-job-server' not found in root project 'beam'.`) Can you change it to `./gradlew :runners:flink:1.8:job-server:runShadow` This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: us...@infra.apache.org Issue Time Tracking --- Worklog Id: (was: 325816) Time Spent: 2h 10m (was: 2h) > Correct document for building the python SDK harness container > -- > > Key: BEAM-8164 > URL: https://issues.apache.org/jira/browse/BEAM-8164 > Project: Beam > Issue Type: Bug > Components: website >Reporter: sunjincheng >Assignee: sunjincheng >Priority: Major > Time Spent: 2h 10m > Remaining Estimate: 0h > > In the runner document, it is described that we can use the command: > `./gradlew :sdks:python:container:docker` > to Build the SDK harness container, see > ([https://beam.apache.org/documentation/runners/flink/)]. > However, the docker config has been removed with the latest python3 docker > related commit [1] the command would failed with the following error message. > {code:java} > > Task :sdks:python:container:docker FAILED > FAILURE: Build failed with an exception. > * What went wrong: > Execution failed for task ':sdks:python:container:docker'. > > name is a required docker configuration item.{code} > I think we should also adapt the document with command: `./gradlew > :sdks:python:container:py2:docker`? Or add the config when run > `:sdks:python:container:docker` auto run all the python version docker? > > What do you think? > > [1] > [https://github.com/apache/beam/commit/47feeafb21023e2a60ae51737cc4000a2033719c#diff-1bc5883bcfcc9e883ab7df09e4dcddb0L63] -- This message was sent by Atlassian Jira (v8.3.4#803005)
[jira] [Work logged] (BEAM-8164) Correct document for building the python SDK harness container
[ https://issues.apache.org/jira/browse/BEAM-8164?focusedWorklogId=324975=com.atlassian.jira.plugin.system.issuetabpanels:worklog-tabpanel#worklog-324975 ] ASF GitHub Bot logged work on BEAM-8164: Author: ASF GitHub Bot Created on: 08/Oct/19 09:44 Start Date: 08/Oct/19 09:44 Worklog Time Spent: 10m Work Description: sunjincheng121 commented on issue #9536: [BEAM-8164][website] Correct document for building the python SDK ha… URL: https://github.com/apache/beam/pull/9536#issuecomment-539437426 Run Python2_PVR_Flink PreCommit This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: us...@infra.apache.org Issue Time Tracking --- Worklog Id: (was: 324975) Time Spent: 1h 50m (was: 1h 40m) > Correct document for building the python SDK harness container > -- > > Key: BEAM-8164 > URL: https://issues.apache.org/jira/browse/BEAM-8164 > Project: Beam > Issue Type: Bug > Components: website >Reporter: sunjincheng >Assignee: sunjincheng >Priority: Major > Time Spent: 1h 50m > Remaining Estimate: 0h > > In the runner document, it is described that we can use the command: > `./gradlew :sdks:python:container:docker` > to Build the SDK harness container, see > ([https://beam.apache.org/documentation/runners/flink/)]. > However, the docker config has been removed with the latest python3 docker > related commit [1] the command would failed with the following error message. > {code:java} > > Task :sdks:python:container:docker FAILED > FAILURE: Build failed with an exception. > * What went wrong: > Execution failed for task ':sdks:python:container:docker'. > > name is a required docker configuration item.{code} > I think we should also adapt the document with command: `./gradlew > :sdks:python:container:py2:docker`? Or add the config when run > `:sdks:python:container:docker` auto run all the python version docker? > > What do you think? > > [1] > [https://github.com/apache/beam/commit/47feeafb21023e2a60ae51737cc4000a2033719c#diff-1bc5883bcfcc9e883ab7df09e4dcddb0L63] -- This message was sent by Atlassian Jira (v8.3.4#803005)
[jira] [Work logged] (BEAM-8164) Correct document for building the python SDK harness container
[ https://issues.apache.org/jira/browse/BEAM-8164?focusedWorklogId=324974=com.atlassian.jira.plugin.system.issuetabpanels:worklog-tabpanel#worklog-324974 ] ASF GitHub Bot logged work on BEAM-8164: Author: ASF GitHub Bot Created on: 08/Oct/19 09:44 Start Date: 08/Oct/19 09:44 Worklog Time Spent: 10m Work Description: sunjincheng121 commented on issue #9536: [BEAM-8164][website] Correct document for building the python SDK ha… URL: https://github.com/apache/beam/pull/9536#issuecomment-539437184 Run Python PreCommit This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: us...@infra.apache.org Issue Time Tracking --- Worklog Id: (was: 324974) Time Spent: 1h 40m (was: 1.5h) > Correct document for building the python SDK harness container > -- > > Key: BEAM-8164 > URL: https://issues.apache.org/jira/browse/BEAM-8164 > Project: Beam > Issue Type: Bug > Components: website >Reporter: sunjincheng >Assignee: sunjincheng >Priority: Major > Time Spent: 1h 40m > Remaining Estimate: 0h > > In the runner document, it is described that we can use the command: > `./gradlew :sdks:python:container:docker` > to Build the SDK harness container, see > ([https://beam.apache.org/documentation/runners/flink/)]. > However, the docker config has been removed with the latest python3 docker > related commit [1] the command would failed with the following error message. > {code:java} > > Task :sdks:python:container:docker FAILED > FAILURE: Build failed with an exception. > * What went wrong: > Execution failed for task ':sdks:python:container:docker'. > > name is a required docker configuration item.{code} > I think we should also adapt the document with command: `./gradlew > :sdks:python:container:py2:docker`? Or add the config when run > `:sdks:python:container:docker` auto run all the python version docker? > > What do you think? > > [1] > [https://github.com/apache/beam/commit/47feeafb21023e2a60ae51737cc4000a2033719c#diff-1bc5883bcfcc9e883ab7df09e4dcddb0L63] -- This message was sent by Atlassian Jira (v8.3.4#803005)
[jira] [Work logged] (BEAM-8164) Correct document for building the python SDK harness container
[ https://issues.apache.org/jira/browse/BEAM-8164?focusedWorklogId=324972=com.atlassian.jira.plugin.system.issuetabpanels:worklog-tabpanel#worklog-324972 ] ASF GitHub Bot logged work on BEAM-8164: Author: ASF GitHub Bot Created on: 08/Oct/19 09:39 Start Date: 08/Oct/19 09:39 Worklog Time Spent: 10m Work Description: sunjincheng121 commented on issue #9536: [BEAM-8164][website] Correct document for building the python SDK ha… URL: https://github.com/apache/beam/pull/9536#issuecomment-539435457 Hi @ibzib Thanks a lot for the review and sorry for the conflicts. I have rebased to the latest master and updated the PR. This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: us...@infra.apache.org Issue Time Tracking --- Worklog Id: (was: 324972) Time Spent: 1.5h (was: 1h 20m) > Correct document for building the python SDK harness container > -- > > Key: BEAM-8164 > URL: https://issues.apache.org/jira/browse/BEAM-8164 > Project: Beam > Issue Type: Bug > Components: website >Reporter: sunjincheng >Assignee: sunjincheng >Priority: Major > Time Spent: 1.5h > Remaining Estimate: 0h > > In the runner document, it is described that we can use the command: > `./gradlew :sdks:python:container:docker` > to Build the SDK harness container, see > ([https://beam.apache.org/documentation/runners/flink/)]. > However, the docker config has been removed with the latest python3 docker > related commit [1] the command would failed with the following error message. > {code:java} > > Task :sdks:python:container:docker FAILED > FAILURE: Build failed with an exception. > * What went wrong: > Execution failed for task ':sdks:python:container:docker'. > > name is a required docker configuration item.{code} > I think we should also adapt the document with command: `./gradlew > :sdks:python:container:py2:docker`? Or add the config when run > `:sdks:python:container:docker` auto run all the python version docker? > > What do you think? > > [1] > [https://github.com/apache/beam/commit/47feeafb21023e2a60ae51737cc4000a2033719c#diff-1bc5883bcfcc9e883ab7df09e4dcddb0L63] -- This message was sent by Atlassian Jira (v8.3.4#803005)
[jira] [Work logged] (BEAM-8164) Correct document for building the python SDK harness container
[ https://issues.apache.org/jira/browse/BEAM-8164?focusedWorklogId=318577=com.atlassian.jira.plugin.system.issuetabpanels:worklog-tabpanel#worklog-318577 ] ASF GitHub Bot logged work on BEAM-8164: Author: ASF GitHub Bot Created on: 25/Sep/19 20:27 Start Date: 25/Sep/19 20:27 Worklog Time Spent: 10m Work Description: ibzib commented on pull request #9536: [BEAM-8164][website] Correct document for building the python SDK ha… URL: https://github.com/apache/beam/pull/9536#discussion_r328324365 ## File path: website/src/roadmap/portability.md ## @@ -151,13 +151,33 @@ for details. ### Running Python wordcount on Flink {#python-on-flink} +<<< HEAD Review comment: Please resolve this (I removed the runner-specific instructions from this page because I thought runner-specific instructions were better placed in their own respective documentation). This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: us...@infra.apache.org Issue Time Tracking --- Worklog Id: (was: 318577) Time Spent: 1h 20m (was: 1h 10m) > Correct document for building the python SDK harness container > -- > > Key: BEAM-8164 > URL: https://issues.apache.org/jira/browse/BEAM-8164 > Project: Beam > Issue Type: Bug > Components: website >Reporter: sunjincheng >Assignee: sunjincheng >Priority: Major > Time Spent: 1h 20m > Remaining Estimate: 0h > > In the runner document, it is described that we can use the command: > `./gradlew :sdks:python:container:docker` > to Build the SDK harness container, see > ([https://beam.apache.org/documentation/runners/flink/)]. > However, the docker config has been removed with the latest python3 docker > related commit [1] the command would failed with the following error message. > {code:java} > > Task :sdks:python:container:docker FAILED > FAILURE: Build failed with an exception. > * What went wrong: > Execution failed for task ':sdks:python:container:docker'. > > name is a required docker configuration item.{code} > I think we should also adapt the document with command: `./gradlew > :sdks:python:container:py2:docker`? Or add the config when run > `:sdks:python:container:docker` auto run all the python version docker? > > What do you think? > > [1] > [https://github.com/apache/beam/commit/47feeafb21023e2a60ae51737cc4000a2033719c#diff-1bc5883bcfcc9e883ab7df09e4dcddb0L63] -- This message was sent by Atlassian Jira (v8.3.4#803005)
[jira] [Work logged] (BEAM-8164) Correct document for building the python SDK harness container
[ https://issues.apache.org/jira/browse/BEAM-8164?focusedWorklogId=317986=com.atlassian.jira.plugin.system.issuetabpanels:worklog-tabpanel#worklog-317986 ] ASF GitHub Bot logged work on BEAM-8164: Author: ASF GitHub Bot Created on: 25/Sep/19 01:57 Start Date: 25/Sep/19 01:57 Worklog Time Spent: 10m Work Description: sunjincheng121 commented on issue #9536: [BEAM-8164][website] Correct document for building the python SDK ha… URL: https://github.com/apache/beam/pull/9536#issuecomment-534817098 Thanks for the remind @ibzib I have update the PR and rebase the code. This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: us...@infra.apache.org Issue Time Tracking --- Worklog Id: (was: 317986) Time Spent: 1h 10m (was: 1h) > Correct document for building the python SDK harness container > -- > > Key: BEAM-8164 > URL: https://issues.apache.org/jira/browse/BEAM-8164 > Project: Beam > Issue Type: Bug > Components: website >Reporter: sunjincheng >Assignee: sunjincheng >Priority: Major > Time Spent: 1h 10m > Remaining Estimate: 0h > > In the runner document, it is described that we can use the command: > `./gradlew :sdks:python:container:docker` > to Build the SDK harness container, see > ([https://beam.apache.org/documentation/runners/flink/)]. > However, the docker config has been removed with the latest python3 docker > related commit [1] the command would failed with the following error message. > {code:java} > > Task :sdks:python:container:docker FAILED > FAILURE: Build failed with an exception. > * What went wrong: > Execution failed for task ':sdks:python:container:docker'. > > name is a required docker configuration item.{code} > I think we should also adapt the document with command: `./gradlew > :sdks:python:container:py2:docker`? Or add the config when run > `:sdks:python:container:docker` auto run all the python version docker? > > What do you think? > > [1] > [https://github.com/apache/beam/commit/47feeafb21023e2a60ae51737cc4000a2033719c#diff-1bc5883bcfcc9e883ab7df09e4dcddb0L63] -- This message was sent by Atlassian Jira (v8.3.4#803005)
[jira] [Work logged] (BEAM-8164) Correct document for building the python SDK harness container
[ https://issues.apache.org/jira/browse/BEAM-8164?focusedWorklogId=315170=com.atlassian.jira.plugin.system.issuetabpanels:worklog-tabpanel#worklog-315170 ] ASF GitHub Bot logged work on BEAM-8164: Author: ASF GitHub Bot Created on: 19/Sep/19 16:42 Start Date: 19/Sep/19 16:42 Worklog Time Spent: 10m Work Description: ibzib commented on issue #9536: [BEAM-8164][website] Correct document for building the python SDK ha… URL: https://github.com/apache/beam/pull/9536#issuecomment-533214308 FYI there's been another change to the default docker container image names: #9487 This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: us...@infra.apache.org Issue Time Tracking --- Worklog Id: (was: 315170) Time Spent: 1h (was: 50m) > Correct document for building the python SDK harness container > -- > > Key: BEAM-8164 > URL: https://issues.apache.org/jira/browse/BEAM-8164 > Project: Beam > Issue Type: Bug > Components: website >Reporter: sunjincheng >Assignee: sunjincheng >Priority: Major > Time Spent: 1h > Remaining Estimate: 0h > > In the runner document, it is described that we can use the command: > `./gradlew :sdks:python:container:docker` > to Build the SDK harness container, see > ([https://beam.apache.org/documentation/runners/flink/)]. > However, the docker config has been removed with the latest python3 docker > related commit [1] the command would failed with the following error message. > {code:java} > > Task :sdks:python:container:docker FAILED > FAILURE: Build failed with an exception. > * What went wrong: > Execution failed for task ':sdks:python:container:docker'. > > name is a required docker configuration item.{code} > I think we should also adapt the document with command: `./gradlew > :sdks:python:container:py2:docker`? Or add the config when run > `:sdks:python:container:docker` auto run all the python version docker? > > What do you think? > > [1] > [https://github.com/apache/beam/commit/47feeafb21023e2a60ae51737cc4000a2033719c#diff-1bc5883bcfcc9e883ab7df09e4dcddb0L63] -- This message was sent by Atlassian Jira (v8.3.4#803005)
[jira] [Work logged] (BEAM-8164) Correct document for building the python SDK harness container
[ https://issues.apache.org/jira/browse/BEAM-8164?focusedWorklogId=314805=com.atlassian.jira.plugin.system.issuetabpanels:worklog-tabpanel#worklog-314805 ] ASF GitHub Bot logged work on BEAM-8164: Author: ASF GitHub Bot Created on: 19/Sep/19 04:02 Start Date: 19/Sep/19 04:02 Worklog Time Spent: 10m Work Description: sunjincheng121 commented on issue #9536: [BEAM-8164][website] Correct document for building the python SDK ha… URL: https://github.com/apache/beam/pull/9536#issuecomment-532955905 Hi @ibzib, Thanks for the review. I agree with you. I removed the build-docker step in `portability.md` in which we are instructing users to use loopback mode. Would be great if you can take another look. Best, Jincheng This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: us...@infra.apache.org Issue Time Tracking --- Worklog Id: (was: 314805) Time Spent: 50m (was: 40m) > Correct document for building the python SDK harness container > -- > > Key: BEAM-8164 > URL: https://issues.apache.org/jira/browse/BEAM-8164 > Project: Beam > Issue Type: Bug > Components: website >Reporter: sunjincheng >Assignee: sunjincheng >Priority: Major > Time Spent: 50m > Remaining Estimate: 0h > > In the runner document, it is described that we can use the command: > `./gradlew :sdks:python:container:docker` > to Build the SDK harness container, see > ([https://beam.apache.org/documentation/runners/flink/)]. > However, the docker config has been removed with the latest python3 docker > related commit [1] the command would failed with the following error message. > {code:java} > > Task :sdks:python:container:docker FAILED > FAILURE: Build failed with an exception. > * What went wrong: > Execution failed for task ':sdks:python:container:docker'. > > name is a required docker configuration item.{code} > I think we should also adapt the document with command: `./gradlew > :sdks:python:container:py2:docker`? Or add the config when run > `:sdks:python:container:docker` auto run all the python version docker? > > What do you think? > > [1] > [https://github.com/apache/beam/commit/47feeafb21023e2a60ae51737cc4000a2033719c#diff-1bc5883bcfcc9e883ab7df09e4dcddb0L63] -- This message was sent by Atlassian Jira (v8.3.4#803005)
[jira] [Work logged] (BEAM-8164) Correct document for building the python SDK harness container
[ https://issues.apache.org/jira/browse/BEAM-8164?focusedWorklogId=311717=com.atlassian.jira.plugin.system.issuetabpanels:worklog-tabpanel#worklog-311717 ] ASF GitHub Bot logged work on BEAM-8164: Author: ASF GitHub Bot Created on: 12/Sep/19 20:54 Start Date: 12/Sep/19 20:54 Worklog Time Spent: 10m Work Description: ibzib commented on issue #9536: [BEAM-8164][website] Correct document for building the python SDK ha… URL: https://github.com/apache/beam/pull/9536#issuecomment-531002621 Hi Jincheng, sorry I did not see this PR before filing my own that partially addressed some of these issues. A few thoughts: - Removing the outdated instructions LGTM. - We should use python 3 in all the relevant examples, as py2 will be deprecated soon. - In a couple of the runner examples, we are instructing users to use loopback mode, which means building the docker containers is actually not needed (I missed this in #9545 as well). So we can just remove that step. Wherever we actually do use the docker environment (the default), we should probably change it to loopback, because loopback mode is easier to use for newcomers to Beam. This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: us...@infra.apache.org Issue Time Tracking --- Worklog Id: (was: 311717) Time Spent: 40m (was: 0.5h) > Correct document for building the python SDK harness container > -- > > Key: BEAM-8164 > URL: https://issues.apache.org/jira/browse/BEAM-8164 > Project: Beam > Issue Type: Bug > Components: website >Reporter: sunjincheng >Assignee: sunjincheng >Priority: Major > Time Spent: 40m > Remaining Estimate: 0h > > In the runner document, it is described that we can use the command: > `./gradlew :sdks:python:container:docker` > to Build the SDK harness container, see > ([https://beam.apache.org/documentation/runners/flink/)]. > However, the docker config has been removed with the latest python3 docker > related commit [1] the command would failed with the following error message. > {code:java} > > Task :sdks:python:container:docker FAILED > FAILURE: Build failed with an exception. > * What went wrong: > Execution failed for task ':sdks:python:container:docker'. > > name is a required docker configuration item.{code} > I think we should also adapt the document with command: `./gradlew > :sdks:python:container:py2:docker`? Or add the config when run > `:sdks:python:container:docker` auto run all the python version docker? > > What do you think? > > [1] > [https://github.com/apache/beam/commit/47feeafb21023e2a60ae51737cc4000a2033719c#diff-1bc5883bcfcc9e883ab7df09e4dcddb0L63] -- This message was sent by Atlassian Jira (v8.3.2#803003)
[jira] [Work logged] (BEAM-8164) Correct document for building the python SDK harness container
[ https://issues.apache.org/jira/browse/BEAM-8164?focusedWorklogId=310444=com.atlassian.jira.plugin.system.issuetabpanels:worklog-tabpanel#worklog-310444 ] ASF GitHub Bot logged work on BEAM-8164: Author: ASF GitHub Bot Created on: 11/Sep/19 09:43 Start Date: 11/Sep/19 09:43 Worklog Time Spent: 10m Work Description: sunjincheng121 commented on issue #9543: [BEAM-8164] Fix syntax errors in Java doc for PipelineRunner URL: https://github.com/apache/beam/pull/9543#issuecomment-530305992 R: @dmvk :) This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: us...@infra.apache.org Issue Time Tracking --- Worklog Id: (was: 310444) Time Spent: 0.5h (was: 20m) > Correct document for building the python SDK harness container > -- > > Key: BEAM-8164 > URL: https://issues.apache.org/jira/browse/BEAM-8164 > Project: Beam > Issue Type: Bug > Components: website >Reporter: sunjincheng >Assignee: sunjincheng >Priority: Major > Time Spent: 0.5h > Remaining Estimate: 0h > > In the runner document, it is described that we can use the command: > `./gradlew :sdks:python:container:docker` > to Build the SDK harness container, see > ([https://beam.apache.org/documentation/runners/flink/)]. > However, the docker config has been removed with the latest python3 docker > related commit [1] the command would failed with the following error message. > {code:java} > > Task :sdks:python:container:docker FAILED > FAILURE: Build failed with an exception. > * What went wrong: > Execution failed for task ':sdks:python:container:docker'. > > name is a required docker configuration item.{code} > I think we should also adapt the document with command: `./gradlew > :sdks:python:container:py2:docker`? Or add the config when run > `:sdks:python:container:docker` auto run all the python version docker? > > What do you think? > > [1] > [https://github.com/apache/beam/commit/47feeafb21023e2a60ae51737cc4000a2033719c#diff-1bc5883bcfcc9e883ab7df09e4dcddb0L63] -- This message was sent by Atlassian Jira (v8.3.2#803003)
[jira] [Work logged] (BEAM-8164) Correct document for building the python SDK harness container
[ https://issues.apache.org/jira/browse/BEAM-8164?focusedWorklogId=310441=com.atlassian.jira.plugin.system.issuetabpanels:worklog-tabpanel#worklog-310441 ] ASF GitHub Bot logged work on BEAM-8164: Author: ASF GitHub Bot Created on: 11/Sep/19 09:42 Start Date: 11/Sep/19 09:42 Worklog Time Spent: 10m Work Description: sunjincheng121 commented on pull request #9543: [BEAM-8164] Fix syntax errors in Java doc for PipelineRunner URL: https://github.com/apache/beam/pull/9543 Fix syntax errors in Java doc for PipelineRunner, i.e., ``` A {@link PipelineRunner} a {@link Pipeline} against a {@code JobService} ``` -> ``` A {@link PipelineRunner} runs a {@link Pipeline} against a {@code JobService} ``` Post-Commit Tests Status (on master branch) Lang | SDK | Apex | Dataflow | Flink | Gearpump | Samza | Spark --- | --- | --- | --- | --- | --- | --- | --- Go | [![Build Status](https://builds.apache.org/job/beam_PostCommit_Go/lastCompletedBuild/badge/icon)](https://builds.apache.org/job/beam_PostCommit_Go/lastCompletedBuild/) | --- | --- | [![Build Status](https://builds.apache.org/job/beam_PostCommit_Go_VR_Flink/lastCompletedBuild/badge/icon)](https://builds.apache.org/job/beam_PostCommit_Go_VR_Flink/lastCompletedBuild/) | --- | --- | [![Build Status](https://builds.apache.org/job/beam_PostCommit_Go_VR_Spark/lastCompletedBuild/badge/icon)](https://builds.apache.org/job/beam_PostCommit_Go_VR_Spark/lastCompletedBuild/) Java | [![Build Status](https://builds.apache.org/job/beam_PostCommit_Java/lastCompletedBuild/badge/icon)](https://builds.apache.org/job/beam_PostCommit_Java/lastCompletedBuild/) | [![Build Status](https://builds.apache.org/job/beam_PostCommit_Java_ValidatesRunner_Apex/lastCompletedBuild/badge/icon)](https://builds.apache.org/job/beam_PostCommit_Java_ValidatesRunner_Apex/lastCompletedBuild/) | [![Build Status](https://builds.apache.org/job/beam_PostCommit_Java_ValidatesRunner_Dataflow/lastCompletedBuild/badge/icon)](https://builds.apache.org/job/beam_PostCommit_Java_ValidatesRunner_Dataflow/lastCompletedBuild/) | [![Build Status](https://builds.apache.org/job/beam_PostCommit_Java_ValidatesRunner_Flink/lastCompletedBuild/badge/icon)](https://builds.apache.org/job/beam_PostCommit_Java_ValidatesRunner_Flink/lastCompletedBuild/)[![Build Status](https://builds.apache.org/job/beam_PostCommit_Java_PVR_Flink_Batch/lastCompletedBuild/badge/icon)](https://builds.apache.org/job/beam_PostCommit_Java_PVR_Flink_Batch/lastCompletedBuild/)[![Build Status](https://builds.apache.org/job/beam_PostCommit_Java_PVR_Flink_Streaming/lastCompletedBuild/badge/icon)](https://builds.apache.org/job/beam_PostCommit_Java_PVR_Flink_Streaming/lastCompletedBuild/) | [![Build Status](https://builds.apache.org/job/beam_PostCommit_Java_ValidatesRunner_Gearpump/lastCompletedBuild/badge/icon)](https://builds.apache.org/job/beam_PostCommit_Java_ValidatesRunner_Gearpump/lastCompletedBuild/) | [![Build Status](https://builds.apache.org/job/beam_PostCommit_Java_ValidatesRunner_Samza/lastCompletedBuild/badge/icon)](https://builds.apache.org/job/beam_PostCommit_Java_ValidatesRunner_Samza/lastCompletedBuild/) | [![Build Status](https://builds.apache.org/job/beam_PostCommit_Java_ValidatesRunner_Spark/lastCompletedBuild/badge/icon)](https://builds.apache.org/job/beam_PostCommit_Java_ValidatesRunner_Spark/lastCompletedBuild/)[![Build Status](https://builds.apache.org/job/beam_PostCommit_Java_PVR_Spark_Batch/lastCompletedBuild/badge/icon)](https://builds.apache.org/job/beam_PostCommit_Java_PVR_Spark_Batch/lastCompletedBuild/) Python | [![Build Status](https://builds.apache.org/job/beam_PostCommit_Python2/lastCompletedBuild/badge/icon)](https://builds.apache.org/job/beam_PostCommit_Python2/lastCompletedBuild/)[![Build Status](https://builds.apache.org/job/beam_PostCommit_Python35/lastCompletedBuild/badge/icon)](https://builds.apache.org/job/beam_PostCommit_Python35/lastCompletedBuild/)[![Build Status](https://builds.apache.org/job/beam_PostCommit_Python36/lastCompletedBuild/badge/icon)](https://builds.apache.org/job/beam_PostCommit_Python36/lastCompletedBuild/)[![Build Status](https://builds.apache.org/job/beam_PostCommit_Python37/lastCompletedBuild/badge/icon)](https://builds.apache.org/job/beam_PostCommit_Python37/lastCompletedBuild/) | --- | [![Build Status](https://builds.apache.org/job/beam_PostCommit_Py_VR_Dataflow/lastCompletedBuild/badge/icon)](https://builds.apache.org/job/beam_PostCommit_Py_VR_Dataflow/lastCompletedBuild/)[![Build Status](https://builds.apache.org/job/beam_PostCommit_Py_ValCont/lastCompletedBuild/badge/icon)](https://builds.apache.org/job/beam_PostCommit_Py_ValCont/lastCompletedBuild/) | [![Build
[jira] [Work logged] (BEAM-8164) Correct document for building the python SDK harness container
[ https://issues.apache.org/jira/browse/BEAM-8164?focusedWorklogId=309525=com.atlassian.jira.plugin.system.issuetabpanels:worklog-tabpanel#worklog-309525 ] ASF GitHub Bot logged work on BEAM-8164: Author: ASF GitHub Bot Created on: 10/Sep/19 04:41 Start Date: 10/Sep/19 04:41 Worklog Time Spent: 10m Work Description: sunjincheng121 commented on pull request #9536: [BEAM-8164][website] Correct document for building the python SDK ha… URL: https://github.com/apache/beam/pull/9536 The command `:sdks:python:container:docker` has been changed to `:sdks:python:container:buildAll` by the latest commit[1]. This pull requests fix all related places in our documents. Note: For the section (Adding dependencies, and making Python go vroom vroom) in CONTAINERS.md, it has totally outdated, e.g., the add_requirements.sh script can not work now and the dependent docker file has been removed. I think we can add python dependencies directly to the base_image_requirements.txt file and build the docker image if user need to add customized dependencies. [1] https://github.com/apache/beam/commit/47feeafb21023e2a60ae51737cc4000a2033719c#diff-1bc5883bcfcc9e883ab7df09e4dcddb0L63 Post-Commit Tests Status (on master branch) Lang | SDK | Apex | Dataflow | Flink | Gearpump | Samza | Spark --- | --- | --- | --- | --- | --- | --- | --- Go | [![Build Status](https://builds.apache.org/job/beam_PostCommit_Go/lastCompletedBuild/badge/icon)](https://builds.apache.org/job/beam_PostCommit_Go/lastCompletedBuild/) | --- | --- | [![Build Status](https://builds.apache.org/job/beam_PostCommit_Go_VR_Flink/lastCompletedBuild/badge/icon)](https://builds.apache.org/job/beam_PostCommit_Go_VR_Flink/lastCompletedBuild/) | --- | --- | [![Build Status](https://builds.apache.org/job/beam_PostCommit_Go_VR_Spark/lastCompletedBuild/badge/icon)](https://builds.apache.org/job/beam_PostCommit_Go_VR_Spark/lastCompletedBuild/) Java | [![Build Status](https://builds.apache.org/job/beam_PostCommit_Java/lastCompletedBuild/badge/icon)](https://builds.apache.org/job/beam_PostCommit_Java/lastCompletedBuild/) | [![Build Status](https://builds.apache.org/job/beam_PostCommit_Java_ValidatesRunner_Apex/lastCompletedBuild/badge/icon)](https://builds.apache.org/job/beam_PostCommit_Java_ValidatesRunner_Apex/lastCompletedBuild/) | [![Build Status](https://builds.apache.org/job/beam_PostCommit_Java_ValidatesRunner_Dataflow/lastCompletedBuild/badge/icon)](https://builds.apache.org/job/beam_PostCommit_Java_ValidatesRunner_Dataflow/lastCompletedBuild/) | [![Build Status](https://builds.apache.org/job/beam_PostCommit_Java_ValidatesRunner_Flink/lastCompletedBuild/badge/icon)](https://builds.apache.org/job/beam_PostCommit_Java_ValidatesRunner_Flink/lastCompletedBuild/)[![Build Status](https://builds.apache.org/job/beam_PostCommit_Java_PVR_Flink_Batch/lastCompletedBuild/badge/icon)](https://builds.apache.org/job/beam_PostCommit_Java_PVR_Flink_Batch/lastCompletedBuild/)[![Build Status](https://builds.apache.org/job/beam_PostCommit_Java_PVR_Flink_Streaming/lastCompletedBuild/badge/icon)](https://builds.apache.org/job/beam_PostCommit_Java_PVR_Flink_Streaming/lastCompletedBuild/) | [![Build Status](https://builds.apache.org/job/beam_PostCommit_Java_ValidatesRunner_Gearpump/lastCompletedBuild/badge/icon)](https://builds.apache.org/job/beam_PostCommit_Java_ValidatesRunner_Gearpump/lastCompletedBuild/) | [![Build Status](https://builds.apache.org/job/beam_PostCommit_Java_ValidatesRunner_Samza/lastCompletedBuild/badge/icon)](https://builds.apache.org/job/beam_PostCommit_Java_ValidatesRunner_Samza/lastCompletedBuild/) | [![Build Status](https://builds.apache.org/job/beam_PostCommit_Java_ValidatesRunner_Spark/lastCompletedBuild/badge/icon)](https://builds.apache.org/job/beam_PostCommit_Java_ValidatesRunner_Spark/lastCompletedBuild/)[![Build Status](https://builds.apache.org/job/beam_PostCommit_Java_PVR_Spark_Batch/lastCompletedBuild/badge/icon)](https://builds.apache.org/job/beam_PostCommit_Java_PVR_Spark_Batch/lastCompletedBuild/) Python | [![Build Status](https://builds.apache.org/job/beam_PostCommit_Python2/lastCompletedBuild/badge/icon)](https://builds.apache.org/job/beam_PostCommit_Python2/lastCompletedBuild/)[![Build Status](https://builds.apache.org/job/beam_PostCommit_Python35/lastCompletedBuild/badge/icon)](https://builds.apache.org/job/beam_PostCommit_Python35/lastCompletedBuild/)[![Build Status](https://builds.apache.org/job/beam_PostCommit_Python36/lastCompletedBuild/badge/icon)](https://builds.apache.org/job/beam_PostCommit_Python36/lastCompletedBuild/)[![Build