[GitHub] ivankelly commented on a change in pull request #1099: Fix auditor shutdown logic and move decommision tests out of BookKeeperAdminTest

ivankelly commented on a change in pull request #1099: Fix auditor shutdown logic and move decommision tests out of BookKeeperAdminTest URL: https://github.com/apache/bookkeeper/pull/1099#discussion_r165926069 ## File path:

[GitHub] jiazhai opened a new pull request #1120: Cherry picks/i 161

jiazhai opened a new pull request #1120: Cherry picks/i 161 URL: https://github.com/apache/bookkeeper/pull/1120 Descriptions of the changes in this PR: This is cherry-pick from yahoo repo of branch yahoo-4.3. original change is:

Jenkins build is back to stable : bookkeeper_release_branch #50

See

[GitHub] eolivelli commented on issue #853: BP-14 WriteFlag DEFERRED_SYNC Client Side Implementation

eolivelli commented on issue #853: BP-14 WriteFlag DEFERRED_SYNC Client Side Implementation URL: https://github.com/apache/bookkeeper/pull/853#issuecomment-363097163 @sijie do you have cycles for review ? This is an

[GitHub] jiazhai opened a new pull request #1121: [Merge Yahoo repo]: AsyncReadLastEntry should trigger callback with error when ledger is empty

jiazhai opened a new pull request #1121: [Merge Yahoo repo]: AsyncReadLastEntry should trigger callback with error when ledger is empty URL: https://github.com/apache/bookkeeper/pull/1121 Descriptions of the changes in this PR: This is cherry-pick from yahoo repo of branch yahoo-4.3.

Jenkins build is still unstable: bookkeeper_postcommit_master_java8 #32

See

Jenkins build is still unstable: bookkeeper_postcommit_master_java9 #33

See

Jenkins build is still unstable: bookkeeper_release_nightly_snapshot #50

See

[GitHub] sijie commented on a change in pull request #1099: Fix auditor shutdown logic and move decommision tests out of BookKeeperAdminTest

sijie commented on a change in pull request #1099: Fix auditor shutdown logic and move decommision tests out of BookKeeperAdminTest URL: https://github.com/apache/bookkeeper/pull/1099#discussion_r166031486 ## File path:

[GitHub] sijie commented on issue #853: BP-14 WriteFlag DEFERRED_SYNC Client Side Implementation

sijie commented on issue #853: BP-14 WriteFlag DEFERRED_SYNC Client Side Implementation URL: https://github.com/apache/bookkeeper/pull/853#issuecomment-363143430 Will review it. Just one question, is server side change done?

[GitHub] sijie commented on issue #853: BP-14 WriteFlag DEFERRED_SYNC Client Side Implementation

sijie commented on issue #853: BP-14 WriteFlag DEFERRED_SYNC Client Side Implementation URL: https://github.com/apache/bookkeeper/pull/853#issuecomment-363147064 I know the journal change was merged. My question is is all server side changes are done?

[GitHub] eolivelli commented on issue #853: BP-14 WriteFlag DEFERRED_SYNC Client Side Implementation

eolivelli commented on issue #853: BP-14 WriteFlag DEFERRED_SYNC Client Side Implementation URL: https://github.com/apache/bookkeeper/pull/853#issuecomment-363147011 See https://github.com/apache/bookkeeper/commit/a226dbedff03102291648df3a60e78a2c85ae65f

[GitHub] eolivelli commented on issue #853: BP-14 WriteFlag DEFERRED_SYNC Client Side Implementation

eolivelli commented on issue #853: BP-14 WriteFlag DEFERRED_SYNC Client Side Implementation URL: https://github.com/apache/bookkeeper/pull/853#issuecomment-363151299 Oh I see. Actually we have to introduce the force() API on the server side and the LastAddSynced piggy back. IMHO we can

[GitHub] sijie commented on issue #853: BP-14 WriteFlag DEFERRED_SYNC Client Side Implementation

sijie commented on issue #853: BP-14 WriteFlag DEFERRED_SYNC Client Side Implementation URL: https://github.com/apache/bookkeeper/pull/853#issuecomment-363153812 @eolivelli it is always good to complete server side changes before adding logics/functionality at client side. otherwise you

[GitHub] sijie commented on a change in pull request #1117: BP-29: Metadata API module

sijie commented on a change in pull request #1117: BP-29: Metadata API module URL: https://github.com/apache/bookkeeper/pull/1117#discussion_r166044263 ## File path: site/bps/BP-29-metadata-store-api-module.md ## @@ -0,0 +1,87 @@ +--- +title: "BP-29: Metadata API module"

[GitHub] sijie commented on issue #1120: [Merge Yahoo repo]: Only reorder read sequence if any bookie is not available

sijie commented on issue #1120: [Merge Yahoo repo]: Only reorder read sequence if any bookie is not available URL: https://github.com/apache/bookkeeper/pull/1120#issuecomment-363154753 @eolivelli - I believe this fixes both rackware and region-aware. region-ware is a hierarchical

[GitHub] ArvinDevel commented on issue #832: Issue 620: Close the fileChannels for read when they are idle

ArvinDevel commented on issue #832: Issue 620: Close the fileChannels for read when they are idle URL: https://github.com/apache/bookkeeper/pull/832#issuecomment-363021673 @ivankelly thanks for your design and I adopted it, please review it when you have time.

[GitHub] sijie commented on a change in pull request #1117: BP-29: Metadata API module

sijie commented on a change in pull request #1117: BP-29: Metadata API module URL: https://github.com/apache/bookkeeper/pull/1117#discussion_r166158200 ## File path: site/bps/BP-29-metadata-store-api-module.md ## @@ -0,0 +1,87 @@ +--- +title: "BP-29: Metadata API module"

[GitHub] jiazhai commented on issue #1120: [Merge Yahoo repo]: Only reorder read sequence if any bookie is not available

jiazhai commented on issue #1120: [Merge Yahoo repo]: Only reorder read sequence if any bookie is not available URL: https://github.com/apache/bookkeeper/pull/1120#issuecomment-363273342 Thanks @eolivelli @sijie , Yes, this will involves both rackware and region-aware. Will update the

[GitHub] jiazhai commented on issue #1121: [Merge Yahoo repo]: AsyncReadLastEntry should trigger callback with error when ledger is empty

jiazhai commented on issue #1121: [Merge Yahoo repo]: AsyncReadLastEntry should trigger callback with error when ledger is empty URL: https://github.com/apache/bookkeeper/pull/1121#issuecomment-363274346 Thank @sijie @eolivelli . cherry-pick 372a99db49 was handling in

[GitHub] ivankelly opened a new pull request #1122: [WIP] Jenkins bc

ivankelly opened a new pull request #1122: [WIP] Jenkins bc URL: https://github.com/apache/bookkeeper/pull/1122 Descriptions of the changes in this PR: (PR description content here)... Master Issue: # > --- > Be sure to do all of the following to help us incorporate

[GitHub] sijie commented on a change in pull request #1117: BP-29: Metadata API module

sijie commented on a change in pull request #1117: BP-29: Metadata API module URL: https://github.com/apache/bookkeeper/pull/1117#discussion_r166158814 ## File path: site/bps/BP-29-metadata-store-api-module.md ## @@ -0,0 +1,87 @@ +--- +title: "BP-29: Metadata API module"

[GitHub] sijie commented on a change in pull request #1117: BP-29: Metadata API module

sijie commented on a change in pull request #1117: BP-29: Metadata API module URL: https://github.com/apache/bookkeeper/pull/1117#discussion_r166158849 ## File path: site/bps/BP-29-metadata-store-api-module.md ## @@ -0,0 +1,87 @@ +--- +title: "BP-29: Metadata API module"

[GitHub] sijie commented on issue #1117: BP-29: Metadata API module

sijie commented on issue #1117: BP-29: Metadata API module URL: https://github.com/apache/bookkeeper/pull/1117#issuecomment-363272059 @jvrao I fixed all the typos. This is an automated message from the Apache Git Service. To

[GitHub] sijie commented on issue #1120: [Merge Yahoo repo]: Only reorder read sequence if any bookie is not available

sijie commented on issue #1120: [Merge Yahoo repo]: Only reorder read sequence if any bookie is not available URL: https://github.com/apache/bookkeeper/pull/1120#issuecomment-363184560 @jiazhai I think this change changes the behavior, so the rackware placement policy tests might need to

[GitHub] sijie commented on issue #853: BP-14 WriteFlag DEFERRED_SYNC Client Side Implementation

sijie commented on issue #853: BP-14 WriteFlag DEFERRED_SYNC Client Side Implementation URL: https://github.com/apache/bookkeeper/pull/853#issuecomment-363180119 Will try to see if I have cycles to help This is an automated

[GitHub] sijie commented on issue #1121: [Merge Yahoo repo]: AsyncReadLastEntry should trigger callback with error when ledger is empty

sijie commented on issue #1121: [Merge Yahoo repo]: AsyncReadLastEntry should trigger callback with error when ledger is empty URL: https://github.com/apache/bookkeeper/pull/1121#issuecomment-363186519 @jiazhai I think this cherry-pick is not correct. You need to cherry-pick changes

[GitHub] jvrao commented on a change in pull request #1117: BP-29: Metadata API module

jvrao commented on a change in pull request #1117: BP-29: Metadata API module URL: https://github.com/apache/bookkeeper/pull/1117#discussion_r166193302 ## File path: site/bps/BP-29-metadata-store-api-module.md ## @@ -0,0 +1,87 @@ +--- +title: "BP-29: Metadata API module"

[GitHub] athanatos commented on issue #1087: ISSUE #1075: Add a noop digest implentation

athanatos commented on issue #1087: ISSUE #1075: Add a noop digest implentation URL: https://github.com/apache/bookkeeper/pull/1087#issuecomment-363158152 @eolivelli Done. This is an automated message from the Apache Git

[GitHub] eolivelli commented on issue #853: BP-14 WriteFlag DEFERRED_SYNC Client Side Implementation

eolivelli commented on issue #853: BP-14 WriteFlag DEFERRED_SYNC Client Side Implementation URL: https://github.com/apache/bookkeeper/pull/853#issuecomment-363176516 Okay it makes sense.no hurry I don't know when I will have time to create patch for force() API and the other

[GitHub] eolivelli commented on issue #853: BP-14 WriteFlag DEFERRED_SYNC Client Side Implementation

eolivelli commented on issue #853: BP-14 WriteFlag DEFERRED_SYNC Client Side Implementation URL: https://github.com/apache/bookkeeper/pull/853#issuecomment-363183680 @sijie thank you so much This is an automated message from

Build failed in Jenkins: distributedlog-release-nightly-snapshot #158

See -- [...truncated 295.13 KB...] [INFO] Downloaded: https://repo.maven.apache.org/maven2/org/apache/commons/commons-parent/34/commons-parent-34.pom (56 kB at