[GitHub] sijie opened a new pull request #1183: Fix flaky travis build on checking license header

sijie opened a new pull request #1183: Fix flaky travis build on checking license header URL: https://github.com/apache/bookkeeper/pull/1183 Descriptions of the changes in this PR: *Problem* In some environments, `BK_VERSION` is computed as `Downloading`, which is not a valid

[GitHub] ivankelly commented on issue #1183: Fix flaky travis build on checking license header

ivankelly commented on issue #1183: Fix flaky travis build on checking license header URL: https://github.com/apache/bookkeeper/pull/1183#issuecomment-366904551 The IT failure is a result of there being no docker networks available, probably due to failed runs of tests. will push fix. ---

[GitHub] ivankelly opened a new pull request #1184: Prune networks from previous runs before IT

ivankelly opened a new pull request #1184: Prune networks from previous runs before IT URL: https://github.com/apache/bookkeeper/pull/1184 If a build fails, it can leave networks around. Run prune before the integration tests to avoid this. --

[GitHub] eolivelli commented on a change in pull request #1184: Prune networks from previous runs before IT

eolivelli commented on a change in pull request #1184: Prune networks from previous runs before IT URL: https://github.com/apache/bookkeeper/pull/1184#discussion_r169250245 ## File path: .test-infra/jenkins/job_bookkeeper_precommit_integrationtests.groovy ## @@ -39,6 +39,7

[GitHub] ivankelly commented on issue #1184: Prune networks from previous runs before IT

ivankelly commented on issue #1184: Prune networks from previous runs before IT URL: https://github.com/apache/bookkeeper/pull/1184#issuecomment-366911864 It will only prune networks that have no containers attached. This is a

[GitHub] sijie opened a new pull request #1185: BP-30: BookKeeper Table Service

sijie opened a new pull request #1185: BP-30: BookKeeper Table Service URL: https://github.com/apache/bookkeeper/pull/1185 Descriptions of the changes in this PR: This BP is proposing adding a table (aka key/value) service component as a contrib module to the bookkeeper, which can la

[GitHub] sijie commented on issue #1183: Fix flaky travis build on checking license header

sijie commented on issue #1183: Fix flaky travis build on checking license header URL: https://github.com/apache/bookkeeper/pull/1183#issuecomment-366928941 This change is only related to travis ci. This is an automated messa

[GitHub] sijie commented on issue #1183: Fix flaky travis build on checking license header

sijie commented on issue #1183: Fix flaky travis build on checking license header URL: https://github.com/apache/bookkeeper/pull/1183#issuecomment-366928868 IGNORE IT CI This is an automated message from the Apache Git Servic

[GitHub] sijie closed pull request #1183: Fix flaky travis build on checking license header

sijie closed pull request #1183: Fix flaky travis build on checking license header URL: https://github.com/apache/bookkeeper/pull/1183 This is a PR merged from a forked repository. As GitHub hides the original diff on merge, it is displayed below for the sake of provenance: As this is a

[GitHub] sijie commented on issue #1181: Allow to disable LZ4 compression in KeyValueStorageRocksDB

sijie commented on issue #1181: Allow to disable LZ4 compression in KeyValueStorageRocksDB URL: https://github.com/apache/bookkeeper/pull/1181#issuecomment-366931386 The failed IT ci is unrelated to this change. This is an au

[GitHub] sijie commented on issue #1181: Allow to disable LZ4 compression in KeyValueStorageRocksDB

sijie commented on issue #1181: Allow to disable LZ4 compression in KeyValueStorageRocksDB URL: https://github.com/apache/bookkeeper/pull/1181#issuecomment-366931333 IGNORE IT CI This is an automated message from the Apache G

[GitHub] sijie closed pull request #1181: Allow to disable LZ4 compression in KeyValueStorageRocksDB

sijie closed pull request #1181: Allow to disable LZ4 compression in KeyValueStorageRocksDB URL: https://github.com/apache/bookkeeper/pull/1181 This is a PR merged from a forked repository. As GitHub hides the original diff on merge, it is displayed below for the sake of provenance: As t

[GitHub] sijie commented on issue #1168: (WIP) fix TestBKSyncLogReader

sijie commented on issue #1168: (WIP) fix TestBKSyncLogReader URL: https://github.com/apache/bookkeeper/pull/1168#issuecomment-366880569 retest this please This is an automated message from the Apache Git Service. To respond t

[GitHub] sijie commented on issue #1168: (WIP) fix TestBKSyncLogReader

sijie commented on issue #1168: (WIP) fix TestBKSyncLogReader URL: https://github.com/apache/bookkeeper/pull/1168#issuecomment-366931728 retest this please This is an automated message from the Apache Git Service. To respond t

[GitHub] sijie commented on issue #1167: Issue 1166: Create `readonly` path for LocalBookKeeper and BookKeeperClusterTestCase

sijie commented on issue #1167: Issue 1166: Create `readonly` path for LocalBookKeeper and BookKeeperClusterTestCase URL: https://github.com/apache/bookkeeper/pull/1167#issuecomment-366931863 IGNORE IT CI This is an automated

[GitHub] sijie commented on issue #1167: Issue 1166: Create `readonly` path for LocalBookKeeper and BookKeeperClusterTestCase

sijie commented on issue #1167: Issue 1166: Create `readonly` path for LocalBookKeeper and BookKeeperClusterTestCase URL: https://github.com/apache/bookkeeper/pull/1167#issuecomment-366931914 The IT ci failure is unrelated to this change. ---

[GitHub] sijie closed pull request #1167: Issue 1166: Create `readonly` path for LocalBookKeeper and BookKeeperClusterTestCase

sijie closed pull request #1167: Issue 1166: Create `readonly` path for LocalBookKeeper and BookKeeperClusterTestCase URL: https://github.com/apache/bookkeeper/pull/1167 This is a PR merged from a forked repository. As GitHub hides the original diff on merge, it is displayed below for the

[GitHub] sijie closed issue #1166: Failed to getReadOnlyBookies on running tests

sijie closed issue #1166: Failed to getReadOnlyBookies on running tests URL: https://github.com/apache/bookkeeper/issues/1166 This is an automated message from the Apache Git Service. To respond to the message, please log on

[GitHub] sijie commented on issue #1122: [WIP] Jenkins bc

sijie commented on issue #1122: [WIP] Jenkins bc URL: https://github.com/apache/bookkeeper/pull/1122#issuecomment-366932433 @ivankelly do we still need this? it seems all the changes in this PR has been merged? This is an aut

[GitHub] ivankelly commented on issue #1184: Prune networks from previous runs before IT

ivankelly commented on issue #1184: Prune networks from previous runs before IT URL: https://github.com/apache/bookkeeper/pull/1184#issuecomment-366933364 Actually, we can filter by name, to make it extra safe. Will push new patch. ---

[GitHub] ivankelly commented on issue #1122: [WIP] Jenkins bc

ivankelly commented on issue #1122: [WIP] Jenkins bc URL: https://github.com/apache/bookkeeper/pull/1122#issuecomment-366933857 No, will close. This is an automated message from the Apache Git Service. To respond to the messag

[GitHub] ivankelly closed pull request #1122: [WIP] Jenkins bc

ivankelly closed pull request #1122: [WIP] Jenkins bc URL: https://github.com/apache/bookkeeper/pull/1122 This is a PR merged from a forked repository. As GitHub hides the original diff on merge, it is displayed below for the sake of provenance: As this is a foreign pull request (from a f

[GitHub] ivankelly commented on issue #903: Integration/compatibility tests based on docker

ivankelly commented on issue #903: Integration/compatibility tests based on docker URL: https://github.com/apache/bookkeeper/issues/903#issuecomment-366939869 This has been implemented in all the linked PRs. This is an automa

[GitHub] ivankelly closed issue #903: Integration/compatibility tests based on docker

ivankelly closed issue #903: Integration/compatibility tests based on docker URL: https://github.com/apache/bookkeeper/issues/903 This is an automated message from the Apache Git Service. To respond to the message, please log

[GitHub] ivankelly closed pull request #1184: Prune networks from previous runs before IT

ivankelly closed pull request #1184: Prune networks from previous runs before IT URL: https://github.com/apache/bookkeeper/pull/1184 This is a PR merged from a forked repository. As GitHub hides the original diff on merge, it is displayed below for the sake of provenance: As this is a for

[GitHub] ivankelly opened a new pull request #1186: Propogate exception when bookie shutdown fails

ivankelly opened a new pull request #1186: Propogate exception when bookie shutdown fails URL: https://github.com/apache/bookkeeper/pull/1186 When a bookie fails to shutdown cleanly, we should propogate the exception that caused the problem to the main thread. --

[GitHub] ivankelly commented on issue #1187: Allow default methods in MavenClassloader callbacks

ivankelly commented on issue #1187: Allow default methods in MavenClassloader callbacks URL: https://github.com/apache/bookkeeper/pull/1187#issuecomment-366964973 This is the last change needed before I push the yahoo BC test

[GitHub] ivankelly opened a new pull request #1187: Allow default methods in MavenClassloader callbacks

ivankelly opened a new pull request #1187: Allow default methods in MavenClassloader callbacks URL: https://github.com/apache/bookkeeper/pull/1187 AsyncCallback.AddCallback has recently acquired a default method, which breaks the assumption that there is only one method on these callb

[GitHub] eolivelli commented on a change in pull request #1186: Propogate exception when bookie shutdown fails

eolivelli commented on a change in pull request #1186: Propogate exception when bookie shutdown fails URL: https://github.com/apache/bookkeeper/pull/1186#discussion_r169305604 ## File path: bookkeeper-server/src/main/java/org/apache/bookkeeper/server/Main.java ## @@ -211,

[GitHub] ivankelly commented on a change in pull request #1186: Propogate exception when bookie shutdown fails

ivankelly commented on a change in pull request #1186: Propogate exception when bookie shutdown fails URL: https://github.com/apache/bookkeeper/pull/1186#discussion_r169308599 ## File path: bookkeeper-server/src/main/java/org/apache/bookkeeper/server/Main.java ## @@ -211,

[GitHub] ivankelly opened a new issue #1188: Lifecycle states should be thread safe

ivankelly opened a new issue #1188: Lifecycle states should be thread safe URL: https://github.com/apache/bookkeeper/issues/1188 LifeCycle states are currently not thread safe: https://github.com/apache/bookkeeper/blob/245f0c03cdfca0c5cc2ae1aeab3d22765ec3fad0/bookkeeper-common/src/main/j

[GitHub] ivankelly closed pull request #1149: Disable tests reruns on dev profile

ivankelly closed pull request #1149: Disable tests reruns on dev profile URL: https://github.com/apache/bookkeeper/pull/1149 This is a PR merged from a forked repository. As GitHub hides the original diff on merge, it is displayed below for the sake of provenance: As this is a foreign pul

[GitHub] ivankelly commented on issue #1186: Propogate exception when bookie shutdown fails

ivankelly commented on issue #1186: Propogate exception when bookie shutdown fails URL: https://github.com/apache/bookkeeper/pull/1186#issuecomment-366986092 retest this please really strange error in IT. a docker container is destroyed immediately after it's created :/ ---

Jenkins build is unstable: bookkeeper_postcommit_master_java8 #48

See

[GitHub] philipsu522 commented on issue #1165: Issue #1164: TestTruncate#testPurgeLogs is flaky

philipsu522 commented on issue #1165: Issue #1164: TestTruncate#testPurgeLogs is flaky URL: https://github.com/apache/bookkeeper/pull/1165#issuecomment-366993614 lgtm! This is an automated message from the Apache Git Service.

Jenkins build is still unstable: bookkeeper_postcommit_master_java9 #48

See

Jenkins build is unstable: bookkeeper_release_nightly_snapshot #65

See

[GitHub] ivankelly opened a new pull request #1189: Always reset interrupted state after catching InterruptedException

ivankelly opened a new pull request #1189: Always reset interrupted state after catching InterruptedException URL: https://github.com/apache/bookkeeper/pull/1189 There's many places we did not do it. I've added it. This i

[GitHub] ivankelly commented on issue #1187: Allow default methods in MavenClassloader callbacks

ivankelly commented on issue #1187: Allow default methods in MavenClassloader callbacks URL: https://github.com/apache/bookkeeper/pull/1187#issuecomment-367011811 retest this please failure was in BookieWriteLedgerTest/testLedgerCreateAdvWithLedgerIdInLoop in both cases, due to this

[GitHub] ivankelly opened a new pull request #1189: Always reset interrupted state after catching InterruptedException

ivankelly opened a new pull request #1189: Always reset interrupted state after catching InterruptedException URL: https://github.com/apache/bookkeeper/pull/1189 There's many places we did not do it. I've added it. This i

[GitHub] ivankelly closed pull request #1189: Always reset interrupted state after catching InterruptedException

ivankelly closed pull request #1189: Always reset interrupted state after catching InterruptedException URL: https://github.com/apache/bookkeeper/pull/1189 This is a PR merged from a forked repository. As GitHub hides the original diff on merge, it is displayed below for the sake of prove

[GitHub] ivankelly closed pull request #1187: Allow default methods in MavenClassloader callbacks

ivankelly closed pull request #1187: Allow default methods in MavenClassloader callbacks URL: https://github.com/apache/bookkeeper/pull/1187 This is a PR merged from a forked repository. As GitHub hides the original diff on merge, it is displayed below for the sake of provenance: As this

[GitHub] ivankelly opened a new pull request #1190: Test that we don't break compat with Yahoo custom version

ivankelly opened a new pull request #1190: Test that we don't break compat with Yahoo custom version URL: https://github.com/apache/bookkeeper/pull/1190 We've been merging a lot of changes from yahoo's internal bookkeeper fork in the past months. The plan is that once everything is in, y

[GitHub] eolivelli commented on issue #1189: Always reset interrupted state after catching InterruptedException

eolivelli commented on issue #1189: Always reset interrupted state after catching InterruptedException URL: https://github.com/apache/bookkeeper/pull/1189#issuecomment-367058015 Is this a general cleanup patch or did you fall into some real problem?

[GitHub] ivankelly commented on issue #1189: Always reset interrupted state after catching InterruptedException

ivankelly commented on issue #1189: Always reset interrupted state after catching InterruptedException URL: https://github.com/apache/bookkeeper/pull/1189#issuecomment-367059510 General cleanup, though some of the CI stuff I've been fighting was threads seeming to ignore being interrupted,

[GitHub] sijie closed pull request #1186: Propogate exception when bookie shutdown fails

sijie closed pull request #1186: Propogate exception when bookie shutdown fails URL: https://github.com/apache/bookkeeper/pull/1186 This is a PR merged from a forked repository. As GitHub hides the original diff on merge, it is displayed below for the sake of provenance: As this is a fore

[GitHub] sijie commented on issue #1165: Issue #1164: TestTruncate#testPurgeLogs is flaky

sijie commented on issue #1165: Issue #1164: TestTruncate#testPurgeLogs is flaky URL: https://github.com/apache/bookkeeper/pull/1165#issuecomment-367093712 the IT ci failure is unrelated to this change. This is an automated me

[GitHub] sijie commented on issue #1165: Issue #1164: TestTruncate#testPurgeLogs is flaky

sijie commented on issue #1165: Issue #1164: TestTruncate#testPurgeLogs is flaky URL: https://github.com/apache/bookkeeper/pull/1165#issuecomment-367093656 IGNORE IT CI This is an automated message from the Apache Git Service.

[GitHub] sijie closed pull request #1165: Issue #1164: TestTruncate#testPurgeLogs is flaky

sijie closed pull request #1165: Issue #1164: TestTruncate#testPurgeLogs is flaky URL: https://github.com/apache/bookkeeper/pull/1165 This is a PR merged from a forked repository. As GitHub hides the original diff on merge, it is displayed below for the sake of provenance: As this is a f

[GitHub] sijie closed issue #1164: TestTruncate#testPurgeLogs fails on postcommit CI

sijie closed issue #1164: TestTruncate#testPurgeLogs fails on postcommit CI URL: https://github.com/apache/bookkeeper/issues/1164 This is an automated message from the Apache Git Service. To respond to the message, please log

[GitHub] sijie closed pull request #1190: Test that we don't break compat with Yahoo custom version

sijie closed pull request #1190: Test that we don't break compat with Yahoo custom version URL: https://github.com/apache/bookkeeper/pull/1190 This is a PR merged from a forked repository. As GitHub hides the original diff on merge, it is displayed below for the sake of provenance: As th

[GitHub] sijie closed pull request #1189: Always reset interrupted state after catching InterruptedException

sijie closed pull request #1189: Always reset interrupted state after catching InterruptedException URL: https://github.com/apache/bookkeeper/pull/1189 This is a PR merged from a forked repository. As GitHub hides the original diff on merge, it is displayed below for the sake of provenanc

[GitHub] reddycharan commented on a change in pull request #1160: Dump config

reddycharan commented on a change in pull request #1160: Dump config URL: https://github.com/apache/bookkeeper/pull/1160#discussion_r169436048 ## File path: bookkeeper-server/src/main/java/org/apache/bookkeeper/conf/AbstractConfiguration.java ## @@ -618,4 +618,22 @@ public

[GitHub] merlimat commented on issue #1181: Allow to disable LZ4 compression in KeyValueStorageRocksDB

merlimat commented on issue #1181: Allow to disable LZ4 compression in KeyValueStorageRocksDB URL: https://github.com/apache/bookkeeper/pull/1181#issuecomment-367103490 > Looks good. Are you really running bookies on Windows? @eolivelli People try all sort of things :)

[GitHub] dlg99 commented on a change in pull request #1088: ISSUE #1086 (@bug W-4146427@) Client-side backpressure in netty (Fixes: io.netty.util.internal.OutOfDirectMemoryError under continuous heavy

dlg99 commented on a change in pull request #1088: ISSUE #1086 (@bug W-4146427@) Client-side backpressure in netty (Fixes: io.netty.util.internal.OutOfDirectMemoryError under continuous heavy load) URL: https://github.com/apache/bookkeeper/pull/1088#discussion_r169462305 ## File pa

[GitHub] dlg99 commented on a change in pull request #1088: ISSUE #1086 (@bug W-4146427@) Client-side backpressure in netty (Fixes: io.netty.util.internal.OutOfDirectMemoryError under continuous heavy

dlg99 commented on a change in pull request #1088: ISSUE #1086 (@bug W-4146427@) Client-side backpressure in netty (Fixes: io.netty.util.internal.OutOfDirectMemoryError under continuous heavy load) URL: https://github.com/apache/bookkeeper/pull/1088#discussion_r169462745 ## File pa

[GitHub] sijie commented on issue #1126: ZK Ledger Manager doesn't handle zookeeper session expires

sijie commented on issue #1126: ZK Ledger Manager doesn't handle zookeeper session expires URL: https://github.com/apache/bookkeeper/issues/1126#issuecomment-367134864 This has been addressed by #1130 in master. It will be cherry-picked to branch-4.6 by #1161 --

[GitHub] ivankelly commented on a change in pull request #898: Bookies should prioritize recovery reads/writes

ivankelly commented on a change in pull request #898: Bookies should prioritize recovery reads/writes URL: https://github.com/apache/bookkeeper/pull/898#discussion_r169487043 ## File path: bookkeeper-server/src/main/java/org/apache/bookkeeper/client/LedgerFragmentReplicator.java #

[GitHub] ivankelly commented on a change in pull request #898: Bookies should prioritize recovery reads/writes

ivankelly commented on a change in pull request #898: Bookies should prioritize recovery reads/writes URL: https://github.com/apache/bookkeeper/pull/898#discussion_r169489920 ## File path: bookkeeper-server/src/main/java/org/apache/bookkeeper/client/LedgerFragmentReplicator.java #

[GitHub] ivankelly commented on a change in pull request #898: Bookies should prioritize recovery reads/writes

ivankelly commented on a change in pull request #898: Bookies should prioritize recovery reads/writes URL: https://github.com/apache/bookkeeper/pull/898#discussion_r169492145 ## File path: bookkeeper-server/src/main/java/org/apache/bookkeeper/proto/BookieRequestProcessor.java

[GitHub] ivankelly commented on a change in pull request #898: Bookies should prioritize recovery reads/writes

ivankelly commented on a change in pull request #898: Bookies should prioritize recovery reads/writes URL: https://github.com/apache/bookkeeper/pull/898#discussion_r169492337 ## File path: bookkeeper-server/src/main/java/org/apache/bookkeeper/client/LedgerFragmentReplicator.java #

[GitHub] ivankelly commented on issue #898: Bookies should prioritize recovery reads/writes

ivankelly commented on issue #898: Bookies should prioritize recovery reads/writes URL: https://github.com/apache/bookkeeper/pull/898#issuecomment-367157041 Pushing to see how it does on CI, was a pretty big merge from master after 2 months dormant. Still need to change the flags, and fixu