dlg99 commented on a change in pull request #1088: ISSUE #1086 (@bug
W-4146427@) Client-side backpressure in netty (Fixes:
io.netty.util.internal.OutOfDirectMemoryError under continuous heavy load)
URL: https://github.com/apache/bookkeeper/pull/1088#discussion_r169462305
##########
File path:
bookkeeper-server/src/main/java/org/apache/bookkeeper/client/LedgerHandleAdv.java
##########
@@ -211,6 +211,11 @@ public String toString() {
return;
}
+ if (!waitForWritable(distributionSchedule.getWriteSet(op.getEntryId()),
+ op.getEntryId(), 0, waitForWriteSetMs)) {
Review comment:
WQ.
if AQ < WQ, 1 channel is not writable and we decide to wait for AQ only we
have the following options:
-- eventually get out of direct memory error.
-- fail all writes to the blocked channel ==> frequent ensemble changes
caused by slightest fluke in data transfer
Sender is not slowed down in this case and keeps on sending more.
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
[email protected]
With regards,
Apache Git Services
