[GitHub] merlimat commented on issue #1682: Added BlockingQueue implementation based on JCtools

merlimat commented on issue #1682: Added BlockingQueue implementation based on JCtools URL: https://github.com/apache/bookkeeper/pull/1682#issuecomment-436907358 > @merlimat any perf/measurements that you can share? @jvrao Not isolated to this implementation. It's tricky to

Build failed in Jenkins: bookkeeper_postcommit_master_python #30

See -- [...truncated 144.53 KB...] dd-agent 12050 1 12050 Nov 05 0.0 0.1 /opt/datadog-agent/embedded/bin/python /opt/datadog-agent/bin/supervisord -c

[GitHub] eolivelli commented on a change in pull request #1797: Move version out of LedgerMetadata

eolivelli commented on a change in pull request #1797: Move version out of LedgerMetadata URL: https://github.com/apache/bookkeeper/pull/1797#discussion_r231875315 ## File path: bookkeeper-server/src/main/java/org/apache/bookkeeper/client/LedgerHandle.java ## @@ -190,7

[GitHub] ivankelly opened a new pull request #1797: Move version out of LedgerMetadata

ivankelly opened a new pull request #1797: Move version out of LedgerMetadata URL: https://github.com/apache/bookkeeper/pull/1797 The version is a property of the metadata store and not of the LedgerMetadata object itself. Putting it in the LedgerMetadata forces that LedgerMetadata to

Build failed in Jenkins: bookkeeper_release_branch_48_integrationtests #85

See Changes: [eolivelli] Bump branch-4.8 to 4.8.1-SNAPSHOT During the release process of 4.8.0 [eolivelli] [maven-release-plugin] prepare release v4.8.1-rc0 [eolivelli]

Build failed in Jenkins: bookkeeper_release_nightly_snapshot #188

See -- Started by timer [EnvInject] - Loading node environment variables. Building remotely on H33 (ubuntu xenial) in workspace

Jenkins build is back to stable : bookkeeper_release_branch_48_java8 #85

See

Jenkins build became unstable: bookkeeper_release_branch_46 #210

See

[GitHub] ivankelly removed a comment on issue #1797: Move version out of LedgerMetadata

ivankelly removed a comment on issue #1797: Move version out of LedgerMetadata URL: https://github.com/apache/bookkeeper/pull/1797#issuecomment-437021530 rerun bookie replication tests This is an automated message from the

Jenkins build is back to stable : bookkeeper_codecoverage #263

See

[GitHub] ivankelly commented on a change in pull request #1797: Move version out of LedgerMetadata

ivankelly commented on a change in pull request #1797: Move version out of LedgerMetadata URL: https://github.com/apache/bookkeeper/pull/1797#discussion_r231910997 ## File path: bookkeeper-server/src/main/java/org/apache/bookkeeper/client/LedgerHandle.java ## @@ -190,7

[GitHub] ivankelly commented on issue #1797: Move version out of LedgerMetadata

ivankelly commented on issue #1797: Move version out of LedgerMetadata URL: https://github.com/apache/bookkeeper/pull/1797#issuecomment-437021810 rerun bookkeeper-server replication tests This is an automated message from

[GitHub] ivankelly commented on issue #1797: Move version out of LedgerMetadata

ivankelly commented on issue #1797: Move version out of LedgerMetadata URL: https://github.com/apache/bookkeeper/pull/1797#issuecomment-437021530 rerun bookie replication tests This is an automated message from the Apache Git

Jenkins build is still unstable: bookkeeper_release_branch_48_java9 #85

See

[GitHub] merlimat commented on a change in pull request #1641: Added module to enable CPU affinity

merlimat commented on a change in pull request #1641: Added module to enable CPU affinity URL: https://github.com/apache/bookkeeper/pull/1641#discussion_r232007192 ## File path: circe-checksum/src/main/java/com/scurrilous/circe/utils/NativeUtils.java ## @@ -67,13 +67,16

[GitHub] dlg99 commented on issue #1782: Issue #1781: Add traces/zipkin support to simplify troubleshooting of slow requests

dlg99 commented on issue #1782: Issue #1781: Add traces/zipkin support to simplify troubleshooting of slow requests URL: https://github.com/apache/bookkeeper/pull/1782#issuecomment-437131788 I think I have an idea what to do, it won't be exactly interceptors fw but rather an extension of

[GitHub] merlimat commented on issue #1641: Added module to enable CPU affinity

merlimat commented on issue #1641: Added module to enable CPU affinity URL: https://github.com/apache/bookkeeper/pull/1641#issuecomment-437148304 @ivankelly @eolivelli @sijie Please take another look. > However, I think we need an overarching document for these "performance"

[GitHub] merlimat commented on issue #1682: Added BlockingQueue implementation based on JCtools

merlimat commented on issue #1682: Added BlockingQueue implementation based on JCtools URL: https://github.com/apache/bookkeeper/pull/1682#issuecomment-437144006 run integration tests run bookkeeper-server replication tests

[GitHub] sijie commented on a change in pull request #1795: Release notes for 4.8.1

sijie commented on a change in pull request #1795: Release notes for 4.8.1 URL: https://github.com/apache/bookkeeper/pull/1795#discussion_r232013073 ## File path: site/releases.md ## @@ -64,6 +64,10 @@ Client Guide | API docs ## News +### [date] Release {{

[GitHub] sijie commented on issue #1793: [tools] improve bkctl help message

sijie commented on issue #1793: [tools] improve bkctl help message URL: https://github.com/apache/bookkeeper/pull/1793#issuecomment-437109635 run bookkeeper-server remaining tests This is an automated message from the Apache

[GitHub] merlimat commented on a change in pull request #1641: Added module to enable CPU affinity

merlimat commented on a change in pull request #1641: Added module to enable CPU affinity URL: https://github.com/apache/bookkeeper/pull/1641#discussion_r232007721 ## File path: cpu-affinity/src/main/java/org/apache/bookkeeper/common/util/affinity/impl/CpuAffinityImpl.java

[GitHub] merlimat commented on a change in pull request #1641: Added module to enable CPU affinity

merlimat commented on a change in pull request #1641: Added module to enable CPU affinity URL: https://github.com/apache/bookkeeper/pull/1641#discussion_r232012326 ## File path: cpu-affinity/pom.xml ## @@ -0,0 +1,181 @@ + +http://maven.apache.org/POM/4.0.0

[GitHub] merlimat commented on a change in pull request #1641: Added module to enable CPU affinity

merlimat commented on a change in pull request #1641: Added module to enable CPU affinity URL: https://github.com/apache/bookkeeper/pull/1641#discussion_r232012381 ## File path: cpu-affinity/src/main/affinity/cpp/affinity_jni.c ## @@ -0,0 +1,98 @@ +/** + * + * Licensed to

[GitHub] merlimat commented on a change in pull request #1641: Added module to enable CPU affinity

merlimat commented on a change in pull request #1641: Added module to enable CPU affinity URL: https://github.com/apache/bookkeeper/pull/1641#discussion_r232008861 ## File path: cpu-affinity/src/main/java/org/apache/bookkeeper/common/util/affinity/impl/CpuAffinityImpl.java

[GitHub] sijie commented on a change in pull request #1795: Release notes for 4.8.1

sijie commented on a change in pull request #1795: Release notes for 4.8.1 URL: https://github.com/apache/bookkeeper/pull/1795#discussion_r232012899 ## File path: site/_config.yml ## @@ -8,6 +8,7 @@ destination: local-generated twitter_url:

[GitHub] sijie commented on issue #1793: [tools] improve bkctl help message

sijie commented on issue #1793: [tools] improve bkctl help message URL: https://github.com/apache/bookkeeper/pull/1793#issuecomment-437109214 run pr validation run integration tests run bookkeeper remaining tests This

[GitHub] merlimat commented on a change in pull request #1641: Added module to enable CPU affinity

merlimat commented on a change in pull request #1641: Added module to enable CPU affinity URL: https://github.com/apache/bookkeeper/pull/1641#discussion_r232046564 ## File path: cpu-affinity/src/main/java/org/apache/bookkeeper/common/util/affinity/impl/NativeUtils.java ##

[GitHub] eolivelli commented on a change in pull request #1795: Release notes for 4.8.1

eolivelli commented on a change in pull request #1795: Release notes for 4.8.1 URL: https://github.com/apache/bookkeeper/pull/1795#discussion_r232076409 ## File path: site/releases.md ## @@ -64,6 +64,10 @@ Client Guide | API docs ## News +### [date] Release {{

[GitHub] eolivelli commented on a change in pull request #1795: Release notes for 4.8.1

eolivelli commented on a change in pull request #1795: Release notes for 4.8.1 URL: https://github.com/apache/bookkeeper/pull/1795#discussion_r232076286 ## File path: site/_config.yml ## @@ -8,6 +8,7 @@ destination: local-generated twitter_url:

[GitHub] eolivelli commented on a change in pull request #1641: Added module to enable CPU affinity

eolivelli commented on a change in pull request #1641: Added module to enable CPU affinity URL: https://github.com/apache/bookkeeper/pull/1641#discussion_r232079643 ## File path: cpu-affinity/src/main/java/org/apache/bookkeeper/common/util/affinity/impl/CpuAffinityImpl.java

[GitHub] eolivelli commented on a change in pull request #1682: Added BlockingQueue implementation based on JCtools

eolivelli commented on a change in pull request #1682: Added BlockingQueue implementation based on JCtools URL: https://github.com/apache/bookkeeper/pull/1682#discussion_r232078181 ## File path: bookkeeper-server/src/main/java/org/apache/bookkeeper/bookie/LedgerDescriptorImpl.java

[GitHub] eolivelli commented on issue #1682: Added BlockingQueue implementation based on JCtools

eolivelli commented on issue #1682: Added BlockingQueue implementation based on JCtools URL: https://github.com/apache/bookkeeper/pull/1682#issuecomment-437172041 Yes I noticed that Netty has its own copy of jctools queue. I am fine with this idea. Thank you for working on this

[GitHub] sijie commented on issue #1794: [tools] add cookie related commands

sijie commented on issue #1794: [tools] add cookie related commands URL: https://github.com/apache/bookkeeper/pull/1794#issuecomment-437232463 run integration tests This is an automated message from the Apache Git Service. To

[GitHub] merlimat commented on a change in pull request #1682: Added BlockingQueue implementation based on JCtools

merlimat commented on a change in pull request #1682: Added BlockingQueue implementation based on JCtools URL: https://github.com/apache/bookkeeper/pull/1682#discussion_r232113059 ## File path: bookkeeper-server/src/main/java/org/apache/bookkeeper/bookie/LedgerDescriptorImpl.java

[GitHub] merlimat commented on a change in pull request #1682: Added BlockingQueue implementation based on JCtools

merlimat commented on a change in pull request #1682: Added BlockingQueue implementation based on JCtools URL: https://github.com/apache/bookkeeper/pull/1682#discussion_r232114716 ## File path: bookkeeper-common/src/main/java/org/apache/bookkeeper/common/collections/BusyWait.java

[GitHub] eolivelli commented on a change in pull request #1682: Added BlockingQueue implementation based on JCtools

eolivelli commented on a change in pull request #1682: Added BlockingQueue implementation based on JCtools URL: https://github.com/apache/bookkeeper/pull/1682#discussion_r232077650 ## File path: bookkeeper-common/src/main/java/org/apache/bookkeeper/common/collections/BusyWait.java

[GitHub] sijie closed pull request #1794: [tools] add cookie related commands

sijie closed pull request #1794: [tools] add cookie related commands URL: https://github.com/apache/bookkeeper/pull/1794 This is a PR merged from a forked repository. As GitHub hides the original diff on merge, it is displayed below for the sake of provenance: As this is a foreign pull

[GitHub] sijie commented on issue #1794: [tools] add cookie related commands

sijie commented on issue #1794: [tools] add cookie related commands URL: https://github.com/apache/bookkeeper/pull/1794#issuecomment-437257198 IGNORE IT CI This is an automated message from the Apache Git Service. To respond

[GitHub] merlimat commented on a change in pull request #1798: [tools] package bookkeeper tools into a separated distribution

merlimat commented on a change in pull request #1798: [tools] package bookkeeper tools into a separated distribution URL: https://github.com/apache/bookkeeper/pull/1798#discussion_r232159782 ## File path: bookkeeper-dist/src/main/resources/LICENSE-bkctl.bin.txt ## @@ -0,0

[GitHub] sijie opened a new pull request #1798: [tools] package bookkeeper tools into a separated distribution

sijie opened a new pull request #1798: [tools] package bookkeeper tools into a separated distribution URL: https://github.com/apache/bookkeeper/pull/1798 Descriptions of the changes in this PR: *Motivation* Make the tools available without pulling in server dependencies

[GitHub] sijie commented on a change in pull request #1798: [tools] package bookkeeper tools into a separated distribution

sijie commented on a change in pull request #1798: [tools] package bookkeeper tools into a separated distribution URL: https://github.com/apache/bookkeeper/pull/1798#discussion_r232166037 ## File path: bookkeeper-dist/src/main/resources/LICENSE-bkctl.bin.txt ## @@ -0,0

[GitHub] sijie commented on issue #1798: [tools] package bookkeeper tools into a separated distribution

sijie commented on issue #1798: [tools] package bookkeeper tools into a separated distribution URL: https://github.com/apache/bookkeeper/pull/1798#issuecomment-437279549 > Does the script which checks licenses cover this new package? travis checks this package.

[GitHub] sijie commented on a change in pull request #1786: BP-36: Stats documentation annotation

sijie commented on a change in pull request #1786: BP-36: Stats documentation annotation URL: https://github.com/apache/bookkeeper/pull/1786#discussion_r231972864 ## File path: site/bps/BP-36-stats-documentation-annotation.md ## @@ -0,0 +1,157 @@ +--- +title: "BP-36:

[GitHub] sijie commented on a change in pull request #1786: BP-36: Stats documentation annotation

sijie commented on a change in pull request #1786: BP-36: Stats documentation annotation URL: https://github.com/apache/bookkeeper/pull/1786#discussion_r231972932 ## File path: site/bps/BP-36-stats-documentation-annotation.md ## @@ -0,0 +1,157 @@ +--- +title: "BP-36:

[GitHub] sijie closed issue #1791: Read Submission should bypass OSE Threads

sijie closed issue #1791: Read Submission should bypass OSE Threads URL: https://github.com/apache/bookkeeper/issues/1791 This is an automated message from the Apache Git Service. To respond to the message, please log on

[GitHub] sijie commented on issue #1755: Configure Netty allocator in bookie and client

sijie commented on issue #1755: Configure Netty allocator in bookie and client URL: https://github.com/apache/bookkeeper/pull/1755#issuecomment-437072101 run bookkeeper-server tls tests run integration tests This is an

[GitHub] sijie closed pull request #1789: Cache InetSocketAddress if hostname is IPAddress

sijie closed pull request #1789: Cache InetSocketAddress if hostname is IPAddress URL: https://github.com/apache/bookkeeper/pull/1789 This is a PR merged from a forked repository. As GitHub hides the original diff on merge, it is displayed below for the sake of provenance: As this is a