eolivelli commented on issue #1286: Implement directly
ChannelOutboundHandlerAdapter in BookieProtoEncoding#ResponseEncoder
URL: https://github.com/apache/bookkeeper/pull/1286#issuecomment-376063680
I am going to merge this PR and cherry pick to 4.6 today, as soon as CI ends
with success
eolivelli commented on issue #1286: Implement directly
ChannelOutboundHandlerAdapter in BookieProtoEncoding#ResponseEncoder
URL: https://github.com/apache/bookkeeper/pull/1286#issuecomment-376063582
retest this please
This
eolivelli commented on issue #1286: Implement directly
ChannelOutboundHandlerAdapter in BookieProtoEncoding#ResponseEncoder
URL: https://github.com/apache/bookkeeper/pull/1286#issuecomment-375820877
@sijie I have addressed your comment and simplified the description
eolivelli commented on issue #1286: Implement directly
ChannelOutboundHandlerAdapter in BookieProtoEncoding#ResponseEncoder
URL: https://github.com/apache/bookkeeper/pull/1286#issuecomment-375818341
@sijie thank you. Description updated. I will create an issue with logs and
the full story
eolivelli commented on issue #1286: Implement directly
ChannelOutboundHandlerAdapter in BookieProtoEncoding#ResponseEncoder
URL: https://github.com/apache/bookkeeper/pull/1286#issuecomment-375755481
@sijie MessageToMessageEncoder uses reflection and does checks on objects
types and it
eolivelli commented on issue #1286: Implement directly
ChannelOutboundHandlerAdapter in BookieProtoEncoding#ResponseEncoder
URL: https://github.com/apache/bookkeeper/pull/1286#issuecomment-375712254
@merlimat @sijie since you already took a look to this patch I will wait
your ack before
eolivelli commented on issue #1286: Implement directly
ChannelOutboundHandlerAdapter in BookieProtoEncoding#ResponseEncoder
URL: https://github.com/apache/bookkeeper/pull/1286#issuecomment-375702124
The fix is running without problem, my collegues are very happy. I am
removing the flag
