[GitHub] eolivelli commented on issue #1286: Implement directly ChannelOutboundHandlerAdapter in BookieProtoEncoding#ResponseEncoder
eolivelli commented on issue #1286: Implement directly ChannelOutboundHandlerAdapter in BookieProtoEncoding#ResponseEncoder URL: https://github.com/apache/bookkeeper/pull/1286#issuecomment-376063680 I am going to merge this PR and cherry pick to 4.6 today, as soon as CI ends with success This is an automated message from the Apache Git Service. To respond to the message, please log on GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: us...@infra.apache.org With regards, Apache Git Services
[GitHub] eolivelli commented on issue #1286: Implement directly ChannelOutboundHandlerAdapter in BookieProtoEncoding#ResponseEncoder
eolivelli commented on issue #1286: Implement directly ChannelOutboundHandlerAdapter in BookieProtoEncoding#ResponseEncoder URL: https://github.com/apache/bookkeeper/pull/1286#issuecomment-376063582 retest this please This is an automated message from the Apache Git Service. To respond to the message, please log on GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: us...@infra.apache.org With regards, Apache Git Services
[GitHub] eolivelli commented on issue #1286: Implement directly ChannelOutboundHandlerAdapter in BookieProtoEncoding#ResponseEncoder
eolivelli commented on issue #1286: Implement directly ChannelOutboundHandlerAdapter in BookieProtoEncoding#ResponseEncoder URL: https://github.com/apache/bookkeeper/pull/1286#issuecomment-375820877 @sijie I have addressed your comment and simplified the description This is an automated message from the Apache Git Service. To respond to the message, please log on GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: us...@infra.apache.org With regards, Apache Git Services
[GitHub] eolivelli commented on issue #1286: Implement directly ChannelOutboundHandlerAdapter in BookieProtoEncoding#ResponseEncoder
eolivelli commented on issue #1286: Implement directly ChannelOutboundHandlerAdapter in BookieProtoEncoding#ResponseEncoder URL: https://github.com/apache/bookkeeper/pull/1286#issuecomment-375818341 @sijie thank you. Description updated. I will create an issue with logs and the full story and link to this patch next week This is an automated message from the Apache Git Service. To respond to the message, please log on GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: us...@infra.apache.org With regards, Apache Git Services
[GitHub] eolivelli commented on issue #1286: Implement directly ChannelOutboundHandlerAdapter in BookieProtoEncoding#ResponseEncoder
eolivelli commented on issue #1286: Implement directly ChannelOutboundHandlerAdapter in BookieProtoEncoding#ResponseEncoder URL: https://github.com/apache/bookkeeper/pull/1286#issuecomment-375755481 @sijie MessageToMessageEncoder uses reflection and does checks on objects types and it does other things not needed so my idea is that we are saving CPU cycles. I will update the description, the change is more a cleanup/refactor and it does not address directly the problem, but actually with this refactor the problem does not occur anymore. I agree that describing only part of the evidences is only confusing This is an automated message from the Apache Git Service. To respond to the message, please log on GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: us...@infra.apache.org With regards, Apache Git Services
[GitHub] eolivelli commented on issue #1286: Implement directly ChannelOutboundHandlerAdapter in BookieProtoEncoding#ResponseEncoder
eolivelli commented on issue #1286: Implement directly ChannelOutboundHandlerAdapter in BookieProtoEncoding#ResponseEncoder URL: https://github.com/apache/bookkeeper/pull/1286#issuecomment-375712254 @merlimat @sijie since you already took a look to this patch I will wait your ack before merging to master and to branch-4.6 This is an automated message from the Apache Git Service. To respond to the message, please log on GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: us...@infra.apache.org With regards, Apache Git Services
[GitHub] eolivelli commented on issue #1286: Implement directly ChannelOutboundHandlerAdapter in BookieProtoEncoding#ResponseEncoder
eolivelli commented on issue #1286: Implement directly ChannelOutboundHandlerAdapter in BookieProtoEncoding#ResponseEncoder URL: https://github.com/apache/bookkeeper/pull/1286#issuecomment-375702124 The fix is running without problem, my collegues are very happy. I am removing the flag and make the patch available for final review. All lights are green. I would like to cherry-pick this change to 4.6 branch This is an automated message from the Apache Git Service. To respond to the message, please log on GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: us...@infra.apache.org With regards, Apache Git Services
