[GitHub] reddycharan commented on a change in pull request #1807: [bookie] Fix sorted ledger storage rotating entry log files too frequent

2018-11-13 Thread GitBox 
reddycharan commented on a change in pull request #1807: [bookie] Fix sorted 
ledger storage rotating entry log files too frequent
URL: https://github.com/apache/bookkeeper/pull/1807#discussion_r233123238
 
 

 ##
 File path: 
bookkeeper-server/src/main/java/org/apache/bookkeeper/bookie/EntryLogManagerForEntryLogPerLedger.java
 ##
 @@ -640,7 +640,9 @@ BufferedLogChannel getCurrentLogForLedgerForAddEntry(long 
ledgerId, int entrySiz
 if (logChannel != null) {
 logChannel.flushAndForceWriteIfRegularFlush(false);
 }
-createNewLog(ledgerId);
+createNewLog(ledgerId,
+": diskFull = " + diskFull + ", allDisksFull = " + 
allDisksFull
++ ", reachEntryLogLimit = " + reachEntryLogLimit);
 
 Review comment:
   we can get to this block even if logChannel is null. so add that aswell to 
the reason string. 


This is an automated message from the Apache Git Service.
To respond to the message, please log on GitHub and use the
URL above to go to the specific comment.
 
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org


With regards,
Apache Git Services

[GitHub] reddycharan commented on a change in pull request #1807: [bookie] Fix sorted ledger storage rotating entry log files too frequent

2018-11-12 Thread GitBox 
reddycharan commented on a change in pull request #1807: [bookie] Fix sorted 
ledger storage rotating entry log files too frequent
URL: https://github.com/apache/bookkeeper/pull/1807#discussion_r232790690
 
 

 ##
 File path: 
bookkeeper-server/src/main/java/org/apache/bookkeeper/bookie/InterleavedLedgerStorage.java
 ##
 @@ -98,11 +98,32 @@ public void initialize(ServerConfiguration conf,
Checkpointer checkpointer,
StatsLogger statsLogger)
 throws IOException {
+initializeWithEntryLogListener(
+conf,
+ledgerManager,
+ledgerDirsManager,
+indexDirsManager,
+stateManager,
+checkpointSource,
+checkpointer,
+this,
+statsLogger);
+}
+
+void initializeWithEntryLogListener(ServerConfiguration conf,
 
 Review comment:
   instead of adding a new initialize method, you should consider changing the 
signature of the existing initialize method, which takes EntryLogListener 
argument. In ILS initialize method it will check if it receives the listener, 
if it is not null use it otherwise use ‘this’.


This is an automated message from the Apache Git Service.
To respond to the message, please log on GitHub and use the
URL above to go to the specific comment.
 
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org


With regards,
Apache Git Services