[GitHub] sijie commented on a change in pull request #1121: [Merge Yahoo repo]: AsyncReadLastEntry should trigger callback with error when ledger is empty
sijie commented on a change in pull request #1121: [Merge Yahoo repo]:
AsyncReadLastEntry should trigger callback with error when ledger is empty
URL: https://github.com/apache/bookkeeper/pull/1121#discussion_r168635817
##
File path:
bookkeeper-server/src/main/java/org/apache/bookkeeper/client/LedgerHandle.java
##
@@ -787,6 +787,24 @@ public void onFailure(Throwable cause) {
}
}
+/*
+ * Read the last entry in the ledger
+ *
+ * @param cb
+ *object implementing read callback interface
+ * @param ctx
+ *control object
+ */
+public void asyncReadLastEntry(ReadCallback cb, Object ctx) {
+long lastEntryId = getLastAddConfirmed();
Review comment:
Yes it is addressed
This is an automated message from the Apache Git Service.
To respond to the message, please log on GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org
With regards,
Apache Git Services
[GitHub] sijie commented on a change in pull request #1121: [Merge Yahoo repo]: AsyncReadLastEntry should trigger callback with error when ledger is empty
sijie commented on a change in pull request #1121: [Merge Yahoo repo]:
AsyncReadLastEntry should trigger callback with error when ledger is empty
URL: https://github.com/apache/bookkeeper/pull/1121#discussion_r168349626
##
File path:
bookkeeper-server/src/main/java/org/apache/bookkeeper/client/LedgerHandle.java
##
@@ -787,6 +788,35 @@ public void onFailure(Throwable cause) {
}
}
+/*
+ * Read the last entry in the ledger
+ *
+ * @param cb
+ *object implementing read callback interface
+ * @param ctx
+ *control object
+ */
+public void asyncReadLastEntry(ReadCallback cb, Object ctx) {
+long lastEntryId = getLastAddConfirmed();
+if (lastEntryId < 0) {
+// Ledger was empty, so there is no last entry to read
+cb.readComplete(BKException.Code.NoSuchEntryException, this, null,
ctx);
+} else {
+asyncReadEntriesInternal(lastEntryId, lastEntryId, cb, ctx);
+}
+}
+
+public org.apache.bookkeeper.client.api.LedgerEntry readLastEntry()
+throws InterruptedException, ExecutionException, BKException {
Review comment:
we should not throw "ExcuctionException" for sync methods. keep the
behaviour same as other sync methods.
you can check
https://github.com/apache/bookkeeper/blob/master/bookkeeper-server/src/main/java/org/apache/bookkeeper/client/LedgerHandle.java#L594
as an example.
you can use SyncReadCallback as other methods are using.
This is an automated message from the Apache Git Service.
To respond to the message, please log on GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org
With regards,
Apache Git Services
[GitHub] sijie commented on a change in pull request #1121: [Merge Yahoo repo]: AsyncReadLastEntry should trigger callback with error when ledger is empty
sijie commented on a change in pull request #1121: [Merge Yahoo repo]:
AsyncReadLastEntry should trigger callback with error when ledger is empty
URL: https://github.com/apache/bookkeeper/pull/1121#discussion_r168241554
##
File path:
bookkeeper-server/src/main/java/org/apache/bookkeeper/client/ReadOnlyLedgerHandle.java
##
@@ -178,4 +180,19 @@ public String toString() {
protected void initializeExplicitLacFlushPolicy() {
explicitLacFlushPolicy =
ExplicitLacFlushPolicy.VOID_EXPLICITLAC_FLUSH_POLICY;
}
+
+@Override
+public void asyncReadLastEntry(ReadCallback cb, Object ctx) {
+asyncReadLastConfirmed(new ReadLastConfirmedCallback() {
+@Override
+public void readLastConfirmedComplete(int rc, long lastConfirmed,
Object ctx) {
+if (lastConfirmed < 0) {
Review comment:
you need check `rc` first. if `rc` is not `OK`, then fail `ReadCallback`.
Otherwise do the logic to read actual entry.
This is an automated message from the Apache Git Service.
To respond to the message, please log on GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org
With regards,
Apache Git Services
[GitHub] sijie commented on a change in pull request #1121: [Merge Yahoo repo]: AsyncReadLastEntry should trigger callback with error when ledger is empty
sijie commented on a change in pull request #1121: [Merge Yahoo repo]:
AsyncReadLastEntry should trigger callback with error when ledger is empty
URL: https://github.com/apache/bookkeeper/pull/1121#discussion_r168240944
##
File path:
bookkeeper-server/src/main/java/org/apache/bookkeeper/client/LedgerHandle.java
##
@@ -787,6 +788,35 @@ public void onFailure(Throwable cause) {
}
}
+/*
+ * Read the last entry in the ledger
+ *
+ * @param cb
+ *object implementing read callback interface
+ * @param ctx
+ *control object
+ */
+public void asyncReadLastEntry(ReadCallback cb, Object ctx) {
+long lastEntryId = getLastAddConfirmed();
+if (lastEntryId < 0) {
+// Ledger was empty, so there is no last entry to read
+cb.readComplete(BKException.Code.NoSuchEntryException, this, null,
ctx);
+} else {
+asyncReadEntriesInternal(lastEntryId, lastEntryId, cb, ctx);
+}
+}
+
+public org.apache.bookkeeper.client.api.LedgerEntry readLastEntry()
+throws InterruptedException, ExecutionException {
+long lastEntryId = getLastAddConfirmed();
+if (lastEntryId < 0) {
+// Ledger was empty, so there is no last entry to read
+return null;
Review comment:
throw NoSuchEntryException to keep it consistent with asyncReadLastEntry.
This is an automated message from the Apache Git Service.
To respond to the message, please log on GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org
With regards,
Apache Git Services
[GitHub] sijie commented on a change in pull request #1121: [Merge Yahoo repo]: AsyncReadLastEntry should trigger callback with error when ledger is empty
sijie commented on a change in pull request #1121: [Merge Yahoo repo]:
AsyncReadLastEntry should trigger callback with error when ledger is empty
URL: https://github.com/apache/bookkeeper/pull/1121#discussion_r167386207
##
File path:
bookkeeper-server/src/test/java/org/apache/bookkeeper/client/TestReadLastEntryAsync.java
##
@@ -0,0 +1,62 @@
+/*
+ * Licensed to the Apache Software Foundation (ASF) under one
+ * or more contributor license agreements. See the NOTICE file
+ * distributed with this work for additional information
+ * regarding copyright ownership. The ASF licenses this file
+ * to you under the Apache License, Version 2.0 (the
+ * "License"); you may not use this file except in compliance
+ * with the License. You may obtain a copy of the License at
+ *
+ * http://www.apache.org/licenses/LICENSE-2.0
+ *
+ * Unless required by applicable law or agreed to in writing, software
+ * distributed under the License is distributed on an "AS IS" BASIS,
+ * WITHOUT WARRANTIES OR CONDITIONS OF ANY KIND, either express or implied.
+ * See the License for the specific language governing permissions and
+ * limitations under the License.
+ */
+package org.apache.bookkeeper.client;
+
+import static org.junit.Assert.assertEquals;
+
+import java.util.Enumeration;
+import java.util.concurrent.CountDownLatch;
+import org.apache.bookkeeper.client.AsyncCallback.ReadCallback;
+import org.apache.bookkeeper.client.BookKeeper.DigestType;
+import org.apache.bookkeeper.test.BookKeeperClusterTestCase;
+import org.junit.Test;
+
+/**
+ * Test read next entry and the latest last add confirmed.
+ */
+public class TestReadLastEntryAsync extends BookKeeperClusterTestCase {
+
+final DigestType digestType;
+
+public TestReadLastEntryAsync() {
+super(3);
+this.digestType = DigestType.CRC32;
+}
+
+@Test(timeout = 6)
Review comment:
drop the `timeout` here?
This is an automated message from the Apache Git Service.
To respond to the message, please log on GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org
With regards,
Apache Git Services
[GitHub] sijie commented on a change in pull request #1121: [Merge Yahoo repo]: AsyncReadLastEntry should trigger callback with error when ledger is empty
sijie commented on a change in pull request #1121: [Merge Yahoo repo]:
AsyncReadLastEntry should trigger callback with error when ledger is empty
URL: https://github.com/apache/bookkeeper/pull/1121#discussion_r167386849
##
File path:
bookkeeper-server/src/main/java/org/apache/bookkeeper/client/LedgerHandle.java
##
@@ -787,6 +787,24 @@ public void onFailure(Throwable cause) {
}
}
+/*
+ * Read the last entry in the ledger
+ *
+ * @param cb
+ *object implementing read callback interface
+ * @param ctx
+ *control object
+ */
+public void asyncReadLastEntry(ReadCallback cb, Object ctx) {
Review comment:
Let's add a sync version for this method as well.
This is an automated message from the Apache Git Service.
To respond to the message, please log on GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org
With regards,
Apache Git Services
[GitHub] sijie commented on a change in pull request #1121: [Merge Yahoo repo]: AsyncReadLastEntry should trigger callback with error when ledger is empty
sijie commented on a change in pull request #1121: [Merge Yahoo repo]:
AsyncReadLastEntry should trigger callback with error when ledger is empty
URL: https://github.com/apache/bookkeeper/pull/1121#discussion_r167386297
##
File path:
bookkeeper-server/src/test/java/org/apache/bookkeeper/client/TestReadLastEntryAsync.java
##
@@ -0,0 +1,62 @@
+/*
+ * Licensed to the Apache Software Foundation (ASF) under one
+ * or more contributor license agreements. See the NOTICE file
+ * distributed with this work for additional information
+ * regarding copyright ownership. The ASF licenses this file
+ * to you under the Apache License, Version 2.0 (the
+ * "License"); you may not use this file except in compliance
+ * with the License. You may obtain a copy of the License at
+ *
+ * http://www.apache.org/licenses/LICENSE-2.0
+ *
+ * Unless required by applicable law or agreed to in writing, software
+ * distributed under the License is distributed on an "AS IS" BASIS,
+ * WITHOUT WARRANTIES OR CONDITIONS OF ANY KIND, either express or implied.
+ * See the License for the specific language governing permissions and
+ * limitations under the License.
+ */
+package org.apache.bookkeeper.client;
+
+import static org.junit.Assert.assertEquals;
+
+import java.util.Enumeration;
+import java.util.concurrent.CountDownLatch;
+import org.apache.bookkeeper.client.AsyncCallback.ReadCallback;
+import org.apache.bookkeeper.client.BookKeeper.DigestType;
+import org.apache.bookkeeper.test.BookKeeperClusterTestCase;
+import org.junit.Test;
+
+/**
+ * Test read next entry and the latest last add confirmed.
+ */
+public class TestReadLastEntryAsync extends BookKeeperClusterTestCase {
+
+final DigestType digestType;
+
+public TestReadLastEntryAsync() {
+super(3);
Review comment:
I would reduce this to 1. because we don't actually need 3 bookies for
testing this feature.
This is an automated message from the Apache Git Service.
To respond to the message, please log on GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org
With regards,
Apache Git Services
[GitHub] sijie commented on a change in pull request #1121: [Merge Yahoo repo]: AsyncReadLastEntry should trigger callback with error when ledger is empty
sijie commented on a change in pull request #1121: [Merge Yahoo repo]:
AsyncReadLastEntry should trigger callback with error when ledger is empty
URL: https://github.com/apache/bookkeeper/pull/1121#discussion_r167386280
##
File path:
bookkeeper-server/src/test/java/org/apache/bookkeeper/client/TestReadLastEntryAsync.java
##
@@ -0,0 +1,62 @@
+/*
+ * Licensed to the Apache Software Foundation (ASF) under one
+ * or more contributor license agreements. See the NOTICE file
+ * distributed with this work for additional information
+ * regarding copyright ownership. The ASF licenses this file
+ * to you under the Apache License, Version 2.0 (the
+ * "License"); you may not use this file except in compliance
+ * with the License. You may obtain a copy of the License at
+ *
+ * http://www.apache.org/licenses/LICENSE-2.0
+ *
+ * Unless required by applicable law or agreed to in writing, software
+ * distributed under the License is distributed on an "AS IS" BASIS,
+ * WITHOUT WARRANTIES OR CONDITIONS OF ANY KIND, either express or implied.
+ * See the License for the specific language governing permissions and
+ * limitations under the License.
+ */
+package org.apache.bookkeeper.client;
+
+import static org.junit.Assert.assertEquals;
+
+import java.util.Enumeration;
+import java.util.concurrent.CountDownLatch;
+import org.apache.bookkeeper.client.AsyncCallback.ReadCallback;
+import org.apache.bookkeeper.client.BookKeeper.DigestType;
+import org.apache.bookkeeper.test.BookKeeperClusterTestCase;
+import org.junit.Test;
+
+/**
+ * Test read next entry and the latest last add confirmed.
+ */
+public class TestReadLastEntryAsync extends BookKeeperClusterTestCase {
+
+final DigestType digestType;
+
+public TestReadLastEntryAsync() {
+super(3);
+this.digestType = DigestType.CRC32;
+}
+
+@Test(timeout = 6)
+public void testTryReadLastEntryAsyncOnEmptyLedger() throws Exception {
+final LedgerHandle lh = bkc.createLedger(3, 3, 1, digestType,
"".getBytes());
+lh.close();
+
+LedgerHandle readLh = bkc.openLedger(lh.getId(), digestType,
"".getBytes());
+
+final CountDownLatch latch1 = new CountDownLatch(1);
+readLh.asyncReadLastEntry(new ReadCallback() {
+@Override
+public void readComplete(int rc, LedgerHandle lh,
Enumeration seq, Object ctx) {
+assertEquals(BKException.Code.NoSuchEntryException, rc);
Review comment:
I don't think we should `assert` directly in a callback. because the
callback will be executed in a worker scheduler thread.
You can have a `AtomicInteger` or `MutableInteger` to hold the result `rc`,
and check the result after `latch1.await()`.
This is an automated message from the Apache Git Service.
To respond to the message, please log on GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org
With regards,
Apache Git Services
