[GitHub] sijie commented on issue #570: Multiple active entrylogs

2018-03-02 Thread GitBox
sijie commented on issue #570: Multiple active entrylogs URL: https://github.com/apache/bookkeeper/issues/570#issuecomment-369860731 @reddycharan thank you so much for the response. the plan looks good to me. +1 to proceed.

[GitHub] sijie commented on issue #570: Multiple active entrylogs

2018-03-01 Thread GitBox
sijie commented on issue #570: Multiple active entrylogs URL: https://github.com/apache/bookkeeper/issues/570#issuecomment-369711668 > Synchronous communication makes it hard for people to participant. This is why ASF encourages that all discussion happens on the mailing lists [1][2].

[GitHub] sijie commented on issue #570: Multiple active entrylogs

2018-03-01 Thread GitBox
sijie commented on issue #570: Multiple active entrylogs URL: https://github.com/apache/bookkeeper/issues/570#issuecomment-369711668 > Synchronous communication makes it hard for people to participant. This is why ASF encourages that all discussion happens on the mailing lists [1][2].

[GitHub] sijie commented on issue #570: Multiple active entrylogs

2018-03-01 Thread GitBox
sijie commented on issue #570: Multiple active entrylogs URL: https://github.com/apache/bookkeeper/issues/570#issuecomment-369711668 > Synchronous communication makes it hard for people to participant. This is why ASF encourages that all discussion happens on the mailing lists [1][2].

[GitHub] sijie commented on issue #570: Multiple active entrylogs

2018-03-01 Thread GitBox
sijie commented on issue #570: Multiple active entrylogs URL: https://github.com/apache/bookkeeper/issues/570#issuecomment-369539601 the split LGTM This is an automated message from the Apache Git Service. To respond to the

[GitHub] sijie commented on issue #570: Multiple active entrylogs

2018-02-28 Thread GitBox
sijie commented on issue #570: Multiple active entrylogs URL: https://github.com/apache/bookkeeper/issues/570#issuecomment-369471927 @reddycharan great summary. thank you! This is an automated message from the Apache Git

[GitHub] sijie commented on issue #570: Multiple active entrylogs

2018-02-28 Thread GitBox
sijie commented on issue #570: Multiple active entrylogs URL: https://github.com/apache/bookkeeper/issues/570#issuecomment-369243964 > Ah, I didn't go back as far as July. I don't see any concensus on design or a design document though. In fact, the discussions highlighted aren't even

[GitHub] sijie commented on issue #570: Multiple active entrylogs

2018-02-27 Thread GitBox
sijie commented on issue #570: Multiple active entrylogs URL: https://github.com/apache/bookkeeper/issues/570#issuecomment-369018351 > Where has this been discussed? I can't find anything on the dev@ list. The discussion has been started since May 2017 and it has been

[GitHub] sijie commented on issue #570: Multiple active entrylogs

2018-02-27 Thread GitBox
sijie commented on issue #570: Multiple active entrylogs URL: https://github.com/apache/bookkeeper/issues/570#issuecomment-368826780 > What is the rush? I am not suggesting a rush. What I am suggesting here is to respect to what have been discussed and agreed on. What I am saying

[GitHub] sijie commented on issue #570: Multiple active entrylogs

2018-02-26 Thread GitBox
sijie commented on issue #570: Multiple active entrylogs URL: https://github.com/apache/bookkeeper/issues/570#issuecomment-368654064 > It would be good if this could be implemented as a new LedgerStorage implementation, rather than modifying what we have already with a bunch of boolean

[GitHub] sijie commented on issue #570: Multiple active entrylogs

2018-02-23 Thread GitBox
sijie commented on issue #570: Multiple active entrylogs URL: https://github.com/apache/bookkeeper/issues/570#issuecomment-368186471 > The implementation would become simpler, because it is a complex logic to handle and maintain slotmap in configured number of Entrylogs per LedgerDir

[GitHub] sijie commented on issue #570: Multiple active entrylogs

2018-02-23 Thread GitBox
sijie commented on issue #570: Multiple active entrylogs URL: https://github.com/apache/bookkeeper/issues/570#issuecomment-368186471 > The implementation would become simpler, because it is a complex logic to handle and maintain slotmap in configured number of Entrylogs per LedgerDir

[GitHub] sijie commented on issue #570: Multiple active entrylogs

2018-02-23 Thread GitBox
sijie commented on issue #570: Multiple active entrylogs URL: https://github.com/apache/bookkeeper/issues/570#issuecomment-368187219 > Currently with BOOKKEEPER-564 change, we are scheduling checkpoint only when current entrylog file is rotated. So we dont call 'flushCurrentLog' when we

[GitHub] sijie commented on issue #570: Multiple active entrylogs

2018-02-23 Thread GitBox
sijie commented on issue #570: Multiple active entrylogs URL: https://github.com/apache/bookkeeper/issues/570#issuecomment-368186471 ``` The implementation would become simpler, because it is a complex logic to handle and maintain slotmap in configured number of Entrylogs per LedgerDir