[jira] [Assigned] (CALCITE-1413) New CASE statement simplification

2018-10-11 Thread Zoltan Haindrich (JIRA)
[ https://issues.apache.org/jira/browse/CALCITE-1413?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Zoltan Haindrich reassigned CALCITE-1413: - Assignee: Zoltan Haindrich (was: Jesus Camacho Rodriguez) > New CASE

[jira] [Commented] (CALCITE-1413) New CASE statement simplification

2018-10-11 Thread Zoltan Haindrich (JIRA)
[ https://issues.apache.org/jira/browse/CALCITE-1413?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16646586#comment-16646586 ] Zoltan Haindrich commented on CALCITE-1413: --- opened

[jira] [Commented] (CALCITE-1508) SortJoinTransposeRule can remove the top Sort node if it is a trivial ORDER BY and the non-preserved side of the outer join is count-preserving

2018-10-11 Thread Stamatis Zampetakis (JIRA)
[ https://issues.apache.org/jira/browse/CALCITE-1508?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16646761#comment-16646761 ] Stamatis Zampetakis commented on CALCITE-1508: -- I think that the SortRemoveRule can

[jira] [Commented] (CALCITE-2617) FilterProjectTransposeRule should allow filter conditions with correlated variables to be pushed down

2018-10-11 Thread Stamatis Zampetakis (JIRA)
[ https://issues.apache.org/jira/browse/CALCITE-2617?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16646806#comment-16646806 ] Stamatis Zampetakis commented on CALCITE-2617: -- [~rubenql] , I just saw that you already

[jira] [Commented] (CALCITE-2615) When simplifying NOT-AND-OR, RexSimplify incorrectly applies predicates deduced for operands to the same operands

2018-10-11 Thread Zoltan Haindrich (JIRA)
[ https://issues.apache.org/jira/browse/CALCITE-2615?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16646626#comment-16646626 ] Zoltan Haindrich commented on CALCITE-2615: --- in 3 valued logic the following stands: {code} a

[jira] [Commented] (CALCITE-2621) New rule: SemiJoinToCorrelateRule (SemiJoin => LogicalCorrelate)

2018-10-11 Thread Ruben Quesada Lopez (JIRA)
[ https://issues.apache.org/jira/browse/CALCITE-2621?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16646705#comment-16646705 ] Ruben Quesada Lopez commented on CALCITE-2621: -- I'll work on some unit tests. The idea

[jira] [Created] (CALCITE-2622) RexFieldCollation toString method is not deterministic

2018-10-11 Thread Jesus Camacho Rodriguez (JIRA)
Jesus Camacho Rodriguez created CALCITE-2622: Summary: RexFieldCollation toString method is not deterministic Key: CALCITE-2622 URL: https://issues.apache.org/jira/browse/CALCITE-2622

[jira] [Comment Edited] (CALCITE-2617) FilterProjectTransposeRule should allow filter conditions with correlated variables to be pushed down

2018-10-11 Thread Ruben Quesada Lopez (JIRA)
[ https://issues.apache.org/jira/browse/CALCITE-2617?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16646827#comment-16646827 ] Ruben Quesada Lopez edited comment on CALCITE-2617 at 10/11/18 6:00 PM:

[jira] [Commented] (CALCITE-2617) FilterProjectTransposeRule should allow filter conditions with correlated variables to be pushed down

2018-10-11 Thread Ruben Quesada Lopez (JIRA)
[ https://issues.apache.org/jira/browse/CALCITE-2617?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16646827#comment-16646827 ] Ruben Quesada Lopez commented on CALCITE-2617: -- No problem [~zabetak], I can close my PR,

[jira] [Resolved] (CALCITE-2622) RexFieldCollation toString method is not deterministic

2018-10-11 Thread Jesus Camacho Rodriguez (JIRA)
[ https://issues.apache.org/jira/browse/CALCITE-2622?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Jesus Camacho Rodriguez resolved CALCITE-2622. -- Resolution: Fixed Fix Version/s: 1.18.0 Fixed in

[jira] [Commented] (CALCITE-2621) New rule: SemiJoinToCorrelateRule (SemiJoin => LogicalCorrelate)

2018-10-11 Thread Julian Hyde (JIRA)
[ https://issues.apache.org/jira/browse/CALCITE-2621?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16647084#comment-16647084 ] Julian Hyde commented on CALCITE-2621: -- I'm not a fan of making things configurable unless there

[jira] [Commented] (CALCITE-2619) Reduce string literal creation cost by removing charset check

2018-10-11 Thread Ted Xu (JIRA)
[ https://issues.apache.org/jira/browse/CALCITE-2619?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16647315#comment-16647315 ] Ted Xu commented on CALCITE-2619: - As for the cost distribution, I did a quick test:   ||Name||CPU

[jira] [Commented] (CALCITE-2619) Reduce string literal creation cost by removing charset check

2018-10-11 Thread Julian Hyde (JIRA)
[ https://issues.apache.org/jira/browse/CALCITE-2619?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16647257#comment-16647257 ] Julian Hyde commented on CALCITE-2619: -- By the way, what is the expensive part in NlsString? Is it

[jira] [Commented] (CALCITE-2619) Reduce string literal creation cost by removing charset check

2018-10-11 Thread Julian Hyde (JIRA)
[ https://issues.apache.org/jira/browse/CALCITE-2619?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16647247#comment-16647247 ] Julian Hyde commented on CALCITE-2619: -- You've done one of those "let's drill a hole" changes.

[jira] [Comment Edited] (CALCITE-2619) Reduce string literal creation cost by removing charset check

2018-10-11 Thread Ted Xu (JIRA)
[ https://issues.apache.org/jira/browse/CALCITE-2619?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16647315#comment-16647315 ] Ted Xu edited comment on CALCITE-2619 at 10/12/18 3:03 AM: --- As for the cost

[jira] [Commented] (CALCITE-525) Exception-handling in built-in functions

2018-10-11 Thread Vladimir Sitnikov (JIRA)
[ https://issues.apache.org/jira/browse/CALCITE-525?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16646032#comment-16646032 ] Vladimir Sitnikov commented on CALCITE-525: --- {quote} As I said, the SQL standard calls for

[jira] [Commented] (CALCITE-525) Exception-handling in built-in functions

2018-10-11 Thread Hongze Zhang (JIRA)
[ https://issues.apache.org/jira/browse/CALCITE-525?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16646100#comment-16646100 ] Hongze Zhang commented on CALCITE-525: -- AFAIK, MySQL has [sql

[jira] [Comment Edited] (CALCITE-525) Exception-handling in built-in functions

2018-10-11 Thread Hongze Zhang (JIRA)
[ https://issues.apache.org/jira/browse/CALCITE-525?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16646100#comment-16646100 ] Hongze Zhang edited comment on CALCITE-525 at 10/11/18 8:13 AM: AFAIK,

[jira] [Commented] (CALCITE-525) Exception-handling in built-in functions

2018-10-11 Thread Vladimir Sitnikov (JIRA)
[ https://issues.apache.org/jira/browse/CALCITE-525?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16646114#comment-16646114 ] Vladimir Sitnikov commented on CALCITE-525: --- {quote} It actually drop the whole row

[jira] [Created] (CALCITE-2620) Simplify "coalesce(null,x)" to "x"

2018-10-11 Thread pengzhiwei (JIRA)
pengzhiwei created CALCITE-2620: --- Summary: Simplify "coalesce(null,x)" to "x" Key: CALCITE-2620 URL: https://issues.apache.org/jira/browse/CALCITE-2620 Project: Calcite Issue Type: Improvement

[jira] [Commented] (CALCITE-2620) Simplify "coalesce(null,x)" to "x"

2018-10-11 Thread Haisheng Yuan (JIRA)
[ https://issues.apache.org/jira/browse/CALCITE-2620?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16646120#comment-16646120 ] Haisheng Yuan commented on CALCITE-2620: This can be fixed using patch in

[jira] [Commented] (CALCITE-525) Exception-handling in built-in functions

2018-10-11 Thread Hongze Zhang (JIRA)
[ https://issues.apache.org/jira/browse/CALCITE-525?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16646160#comment-16646160 ] Hongze Zhang commented on CALCITE-525: -- {quote}Suppose there's SEMI-ANTI-JOIN. Suppose you drop the

[jira] [Commented] (CALCITE-2619) Reduce string literal creation cost by removing charset check

2018-10-11 Thread Ted Xu (JIRA)
[ https://issues.apache.org/jira/browse/CALCITE-2619?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16646165#comment-16646165 ] Ted Xu commented on CALCITE-2619: - Thanks [~julianhyde], I created a pull request at

[jira] [Commented] (CALCITE-525) Exception-handling in built-in functions

2018-10-11 Thread Vladimir Sitnikov (JIRA)
[ https://issues.apache.org/jira/browse/CALCITE-525?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16646168#comment-16646168 ] Vladimir Sitnikov commented on CALCITE-525: --- {quote}The row will be emitted, since the second

[jira] [Created] (CALCITE-2621) New rule: SemiJoinToCorrelateRule (SemiJoin => LogicalCorrelate)

2018-10-11 Thread Ruben Quesada Lopez (JIRA)
Ruben Quesada Lopez created CALCITE-2621: Summary: New rule: SemiJoinToCorrelateRule (SemiJoin => LogicalCorrelate) Key: CALCITE-2621 URL: https://issues.apache.org/jira/browse/CALCITE-2621

[jira] [Comment Edited] (CALCITE-525) Exception-handling in built-in functions

2018-10-11 Thread Vladimir Sitnikov (JIRA)
[ https://issues.apache.org/jira/browse/CALCITE-525?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16646168#comment-16646168 ] Vladimir Sitnikov edited comment on CALCITE-525 at 10/11/18 9:54 AM: -

[jira] [Commented] (CALCITE-525) Exception-handling in built-in functions

2018-10-11 Thread Hongze Zhang (JIRA)
[ https://issues.apache.org/jira/browse/CALCITE-525?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16646233#comment-16646233 ] Hongze Zhang commented on CALCITE-525: -- Thanks for the example, and I know simply dropping rows

[jira] [Assigned] (CALCITE-2619) Reduce string literal creation cost by removing charset check

2018-10-11 Thread Ted Xu (JIRA)
[ https://issues.apache.org/jira/browse/CALCITE-2619?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Ted Xu reassigned CALCITE-2619: --- Assignee: Ted Xu (was: Julian Hyde) > Reduce string literal creation cost by removing charset

[jira] [Commented] (CALCITE-2621) New rule: SemiJoinToCorrelateRule (SemiJoin => LogicalCorrelate)

2018-10-11 Thread Ruben Quesada Lopez (JIRA)
[ https://issues.apache.org/jira/browse/CALCITE-2621?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16646354#comment-16646354 ] Ruben Quesada Lopez commented on CALCITE-2621: -- A possible way to implement this could be

[jira] [Comment Edited] (CALCITE-2621) New rule: SemiJoinToCorrelateRule (SemiJoin => LogicalCorrelate)

2018-10-11 Thread Ruben Quesada Lopez (JIRA)
[ https://issues.apache.org/jira/browse/CALCITE-2621?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16646354#comment-16646354 ] Ruben Quesada Lopez edited comment on CALCITE-2621 at 10/11/18 12:09 PM:

[jira] [Commented] (CALCITE-2617) FilterProjectTransposeRule should allow filter conditions with correlated variables to be pushed down

2018-10-11 Thread Vladimir Sitnikov (JIRA)
[ https://issues.apache.org/jira/browse/CALCITE-2617?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16646402#comment-16646402 ] Vladimir Sitnikov commented on CALCITE-2617: Should it be enabled by default? Should it be

[jira] [Commented] (CALCITE-2617) FilterProjectTransposeRule should allow filter conditions with correlated variables to be pushed down

2018-10-11 Thread Stamatis Zampetakis (JIRA)
[ https://issues.apache.org/jira/browse/CALCITE-2617?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16646434#comment-16646434 ] Stamatis Zampetakis commented on CALCITE-2617: -- {quote} Should it be enabled by default?

[jira] [Commented] (CALCITE-2617) FilterProjectTransposeRule should allow filter conditions with correlated variables to be pushed down

2018-10-11 Thread Julian Hyde (JIRA)
[ https://issues.apache.org/jira/browse/CALCITE-2617?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16646476#comment-16646476 ] Julian Hyde commented on CALCITE-2617: -- How significant is the risk of regressions? (As opposed to

[jira] [Commented] (CALCITE-2621) New rule: SemiJoinToCorrelateRule (SemiJoin => LogicalCorrelate)

2018-10-11 Thread Julian Hyde (JIRA)
[ https://issues.apache.org/jira/browse/CALCITE-2621?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16646484#comment-16646484 ] Julian Hyde commented on CALCITE-2621: -- Can you add some tests? Why do you need a function to

[jira] [Commented] (CALCITE-2617) FilterProjectTransposeRule should allow filter conditions with correlated variables to be pushed down

2018-10-11 Thread Stamatis Zampetakis (JIRA)
[ https://issues.apache.org/jira/browse/CALCITE-2617?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16646494#comment-16646494 ] Stamatis Zampetakis commented on CALCITE-2617: -- Always pushing filters in the presence of

[jira] [Commented] (CALCITE-2617) FilterProjectTransposeRule should allow filter conditions with correlated variables to be pushed down

2018-10-11 Thread Stamatis Zampetakis (JIRA)
[ https://issues.apache.org/jira/browse/CALCITE-2617?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16646510#comment-16646510 ] Stamatis Zampetakis commented on CALCITE-2617: -- I'm sorry [~julianhyde]  but I am not sure