[jira] [Commented] (CALCITE-2626) RelBuilder generates wrong field list for join

2018-10-12 Thread Julian Hyde (JIRA)
[ https://issues.apache.org/jira/browse/CALCITE-2626?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16648059#comment-16648059 ] Julian Hyde commented on CALCITE-2626: -- Good one. Do you have an illustrative test case? >

[jira] [Commented] (CALCITE-2624) Add a rule to copy a sort below a binary operator over the left or right input

2018-10-12 Thread Julian Hyde (JIRA)
[ https://issues.apache.org/jira/browse/CALCITE-2624?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16648066#comment-16648066 ] Julian Hyde commented on CALCITE-2624: -- Slight difference in tactics: I’d focus on the concrete

[jira] [Commented] (CALCITE-2623) Updating unparseCall() in SqlDialect(s) for dialect specifc SqlNode unparsing

2018-10-12 Thread Julian Hyde (JIRA)
[ https://issues.apache.org/jira/browse/CALCITE-2623?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16648579#comment-16648579 ] Julian Hyde commented on CALCITE-2623: -- Also note that an implementation of

[jira] [Commented] (CALCITE-2617) FilterProjectTransposeRule should allow filter conditions with correlated variables to be pushed down

2018-10-12 Thread Julian Hyde (JIRA)
[ https://issues.apache.org/jira/browse/CALCITE-2617?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16648631#comment-16648631 ] Julian Hyde commented on CALCITE-2617: -- [~rubenql], Do not change the {{containsOver}} call. It is

[jira] [Commented] (CALCITE-2620) Simplify "coalesce(null,x)" to "x"

2018-10-12 Thread pengzhiwei (JIRA)
[ https://issues.apache.org/jira/browse/CALCITE-2620?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16648733#comment-16648733 ] pengzhiwei commented on CALCITE-2620: - [~julianhyde],In  -CALCITE-2506- this issue has not fixed. I

[jira] [Comment Edited] (CALCITE-2620) Simplify "coalesce(null,x)" to "x"

2018-10-12 Thread pengzhiwei (JIRA)
[ https://issues.apache.org/jira/browse/CALCITE-2620?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16648733#comment-16648733 ] pengzhiwei edited comment on CALCITE-2620 at 10/13/18 4:09 AM: ---

[jira] [Updated] (CALCITE-2625) Function Specific Sql Window Unparsing where Framing Not Allowed

2018-10-12 Thread Julian Hyde (JIRA)
[ https://issues.apache.org/jira/browse/CALCITE-2625?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Julian Hyde updated CALCITE-2625: - Component/s: (was: core) jdbc-adapter > Function Specific Sql Window

[jira] [Comment Edited] (CALCITE-2620) Simplify "coalesce(null,x)" to "x"

2018-10-12 Thread pengzhiwei (JIRA)
[ https://issues.apache.org/jira/browse/CALCITE-2620?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16648733#comment-16648733 ] pengzhiwei edited comment on CALCITE-2620 at 10/13/18 4:10 AM: ---

[jira] [Comment Edited] (CALCITE-2620) Simplify "coalesce(null,x)" to "x"

2018-10-12 Thread pengzhiwei (JIRA)
[ https://issues.apache.org/jira/browse/CALCITE-2620?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16648733#comment-16648733 ] pengzhiwei edited comment on CALCITE-2620 at 10/13/18 4:09 AM: ---

[jira] [Commented] (CALCITE-2617) FilterProjectTransposeRule should allow filter conditions with correlated variables to be pushed down

2018-10-12 Thread Julian Hyde (JIRA)
[ https://issues.apache.org/jira/browse/CALCITE-2617?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16648634#comment-16648634 ] Julian Hyde commented on CALCITE-2617: -- Reviewing the PR: * I don't see any need for a new

[jira] [Commented] (CALCITE-2620) Simplify "coalesce(null,x)" to "x"

2018-10-12 Thread Julian Hyde (JIRA)
[ https://issues.apache.org/jira/browse/CALCITE-2620?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16648648#comment-16648648 ] Julian Hyde commented on CALCITE-2620: -- In the fix to CALCITE-2506 I see

[jira] [Commented] (CALCITE-2619) Reduce string literal creation cost by removing charset check

2018-10-12 Thread Julian Hyde (JIRA)
[ https://issues.apache.org/jira/browse/CALCITE-2619?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16648585#comment-16648585 ] Julian Hyde commented on CALCITE-2619: -- I think we should focus on the cost of validating whether

[jira] [Commented] (CALCITE-525) Exception-handling in built-in functions

2018-10-12 Thread Julian Hyde (JIRA)
[ https://issues.apache.org/jira/browse/CALCITE-525?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16648644#comment-16648644 ] Julian Hyde commented on CALCITE-525: - If consistency is paramount for someone, they can continue to

[jira] [Commented] (CALCITE-2625) Function Specific Sql Window Unparsing where Framing Not Allowed

2018-10-12 Thread Julian Hyde (JIRA)
[ https://issues.apache.org/jira/browse/CALCITE-2625?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16648569#comment-16648569 ] Julian Hyde commented on CALCITE-2625: -- I agree. Note that we already have {{boolean

[jira] [Commented] (CALCITE-2623) Updating unparseCall() in SqlDialect(s) for dialect specifc SqlNode unparsing

2018-10-12 Thread Julian Hyde (JIRA)
[ https://issues.apache.org/jira/browse/CALCITE-2623?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16648575#comment-16648575 ] Julian Hyde commented on CALCITE-2623: -- Can you give an example where it currently fails? >

[jira] [Commented] (CALCITE-1413) New CASE statement simplification

2018-10-12 Thread Julian Hyde (JIRA)
[ https://issues.apache.org/jira/browse/CALCITE-1413?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16648641#comment-16648641 ] Julian Hyde commented on CALCITE-1413: -- I'll let [~jcamachorodriguez] review this. Two minor

[jira] [Created] (CALCITE-2624) Add a rule to copy a sort below a binary operator over the left or right input

2018-10-12 Thread Stamatis Zampetakis (JIRA)
Stamatis Zampetakis created CALCITE-2624: Summary: Add a rule to copy a sort below a binary operator over the left or right input Key: CALCITE-2624 URL: https://issues.apache.org/jira/browse/CALCITE-2624

[jira] [Commented] (CALCITE-2621) New rule: SemiJoinToCorrelateRule (SemiJoin => LogicalCorrelate)

2018-10-12 Thread Ruben Quesada Lopez (JIRA)
[ https://issues.apache.org/jira/browse/CALCITE-2621?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16647672#comment-16647672 ] Ruben Quesada Lopez commented on CALCITE-2621: -- Modification pushed, test also included >

[jira] [Updated] (CALCITE-2621) New rule: SemiJoinToCorrelateRule (SemiJoin => LogicalCorrelate)

2018-10-12 Thread Ruben Quesada Lopez (JIRA)
[ https://issues.apache.org/jira/browse/CALCITE-2621?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Ruben Quesada Lopez updated CALCITE-2621: - Description: Similarly to JoinToCorrelateRule, in some contexts it might be

[jira] [Updated] (CALCITE-2621) New rule: SemiJoinToCorrelateRule (SemiJoin => LogicalCorrelate)

2018-10-12 Thread Ruben Quesada Lopez (JIRA)
[ https://issues.apache.org/jira/browse/CALCITE-2621?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Ruben Quesada Lopez updated CALCITE-2621: - Description: Similarly to JoinToCorrelateRule, in some contexts it might be

[jira] [Comment Edited] (CALCITE-2623) Updating unparseCall() in SqlDialect(s) for dialect specifc SqlNode unparsing

2018-10-12 Thread KrishnaKant Agrawal (JIRA)
[ https://issues.apache.org/jira/browse/CALCITE-2623?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16647652#comment-16647652 ] KrishnaKant Agrawal edited comment on CALCITE-2623 at 10/12/18 8:34 AM:

[jira] [Commented] (CALCITE-2623) Updating unparseCall() in SqlDialect(s) for dialect specifc SqlNode unparsing

2018-10-12 Thread KrishnaKant Agrawal (JIRA)
[ https://issues.apache.org/jira/browse/CALCITE-2623?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16647652#comment-16647652 ] KrishnaKant Agrawal commented on CALCITE-2623: -- Will raise the first PR in a couple of

[jira] [Created] (CALCITE-2623) Updating unparseCall() in SqlDialect(s) for dialect specifc SqlNode unparsing

2018-10-12 Thread KrishnaKant Agrawal (JIRA)
KrishnaKant Agrawal created CALCITE-2623: Summary: Updating unparseCall() in SqlDialect(s) for dialect specifc SqlNode unparsing Key: CALCITE-2623 URL: https://issues.apache.org/jira/browse/CALCITE-2623

[jira] [Created] (CALCITE-2625) Function Specific Sql Window Unparsing where Framing Not Allowed

2018-10-12 Thread KrishnaKant Agrawal (JIRA)
KrishnaKant Agrawal created CALCITE-2625: Summary: Function Specific Sql Window Unparsing where Framing Not Allowed Key: CALCITE-2625 URL: https://issues.apache.org/jira/browse/CALCITE-2625

[jira] [Commented] (CALCITE-2619) Reduce string literal creation cost by removing charset check

2018-10-12 Thread Haisheng Yuan (JIRA)
[ https://issues.apache.org/jira/browse/CALCITE-2619?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16647560#comment-16647560 ] Haisheng Yuan commented on CALCITE-2619: [~julianhyde] Once the CharsetEncoder of the CharSet

[jira] [Created] (CALCITE-2626) RelBuilder generates wrong field list for join

2018-10-12 Thread Pavel Gubin (JIRA)
Pavel Gubin created CALCITE-2626: Summary: RelBuilder generates wrong field list for join Key: CALCITE-2626 URL: https://issues.apache.org/jira/browse/CALCITE-2626 Project: Calcite Issue

[jira] [Comment Edited] (CALCITE-2619) Reduce string literal creation cost by removing charset check

2018-10-12 Thread Haisheng Yuan (JIRA)
[ https://issues.apache.org/jira/browse/CALCITE-2619?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16647560#comment-16647560 ] Haisheng Yuan edited comment on CALCITE-2619 at 10/12/18 7:16 AM: --

[jira] [Updated] (CALCITE-2621) New rule: SemiJoinToCorrelateRule (SemiJoin => LogicalCorrelate)

2018-10-12 Thread Ruben Quesada Lopez (JIRA)
[ https://issues.apache.org/jira/browse/CALCITE-2621?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Ruben Quesada Lopez updated CALCITE-2621: - Description: Similarly to JoinToCorrelateRule, in some contexts it might be

[jira] [Comment Edited] (CALCITE-2621) New rule: SemiJoinToCorrelateRule (SemiJoin => LogicalCorrelate)

2018-10-12 Thread Ruben Quesada Lopez (JIRA)
[ https://issues.apache.org/jira/browse/CALCITE-2621?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16647551#comment-16647551 ] Ruben Quesada Lopez edited comment on CALCITE-2621 at 10/12/18 7:00 AM:

[jira] [Commented] (CALCITE-2621) New rule: SemiJoinToCorrelateRule (SemiJoin => LogicalCorrelate)

2018-10-12 Thread Ruben Quesada Lopez (JIRA)
[ https://issues.apache.org/jira/browse/CALCITE-2621?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16647551#comment-16647551 ] Ruben Quesada Lopez commented on CALCITE-2621: -- Ok, I can remove the function and extract

[jira] [Commented] (CALCITE-2619) Reduce string literal creation cost by removing charset check

2018-10-12 Thread Haisheng Yuan (JIRA)
[ https://issues.apache.org/jira/browse/CALCITE-2619?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16647565#comment-16647565 ] Haisheng Yuan commented on CALCITE-2619: I am not worried about the memory overhead for caching