[jira] [Commented] (CALCITE-2444) Rel2Sql: support c IN (1,2)

[ https://issues.apache.org/jira/browse/CALCITE-2444?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=16594670#comment-16594670 ] Zoltan Haindrich commented on CALCITE-2444: --- I've went into a little bit of o

[jira] [Commented] (CALCITE-2444) Rel2Sql: support c IN (1,2)

[ https://issues.apache.org/jira/browse/CALCITE-2444?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=16594674#comment-16594674 ] Zoltan Haindrich commented on CALCITE-2444: --- opened pullrequest: https://gith

[jira] [Commented] (CALCITE-2327) In 3 valued logic mode (b and not b) may not be simplified to false

[ https://issues.apache.org/jira/browse/CALCITE-2327?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=16594828#comment-16594828 ] Zoltan Haindrich commented on CALCITE-2327: --- [~vladimirsitnikov]: You have su

[jira] [Commented] (CALCITE-2327) In 3 valued logic mode (b and not b) may not be simplified to false

[ https://issues.apache.org/jira/browse/CALCITE-2327?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=16594915#comment-16594915 ] Zoltan Haindrich commented on CALCITE-2327: --- I disagree with "off the track"

[jira] [Commented] (CALCITE-2444) Rel2Sql: support c IN (1,2)

[ https://issues.apache.org/jira/browse/CALCITE-2444?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=16596189#comment-16596189 ] Zoltan Haindrich commented on CALCITE-2444: --- [~vladimirsitnikov] I've added a

[jira] [Commented] (CALCITE-2444) Rel2Sql: support c IN (1,2)

[ https://issues.apache.org/jira/browse/CALCITE-2444?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=16596202#comment-16596202 ] Zoltan Haindrich commented on CALCITE-2444: --- I have added one more - but I fe

[jira] [Commented] (CALCITE-2444) Rel2Sql: support c IN (1,2)

[ https://issues.apache.org/jira/browse/CALCITE-2444?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=16597368#comment-16597368 ] Zoltan Haindrich commented on CALCITE-2444: --- [~julianhyde] I've updated the p

[jira] [Commented] (CALCITE-2444) Rel2Sql: support c IN (1,2)

[ https://issues.apache.org/jira/browse/CALCITE-2444?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=16609138#comment-16609138 ] Zoltan Haindrich commented on CALCITE-2444: --- [~julianhyde] Could you please t

[jira] [Commented] (CALCITE-2555) RexSimplify: >=(true, null) could be simplified to null

[ https://issues.apache.org/jira/browse/CALCITE-2555?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=16614543#comment-16614543 ] Zoltan Haindrich commented on CALCITE-2555: --- It's great that the patch also a

[jira] [Commented] (CALCITE-2555) RexSimplify: >=(true, null) could be simplified to null

[ https://issues.apache.org/jira/browse/CALCITE-2555?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=16614846#comment-16614846 ] Zoltan Haindrich commented on CALCITE-2555: --- Sorry [~vladimirsitnikov]; but I

[jira] [Commented] (CALCITE-2555) RexSimplify: >=(true, null) could be simplified to null

[ https://issues.apache.org/jira/browse/CALCITE-2555?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=16615364#comment-16615364 ] Zoltan Haindrich commented on CALCITE-2555: --- [~vladimirsitnikov] you have run

[jira] [Commented] (CALCITE-2555) RexSimplify: >=(true, null) could be simplified to null

[ https://issues.apache.org/jira/browse/CALCITE-2555?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=16617176#comment-16617176 ] Zoltan Haindrich commented on CALCITE-2555: --- [~vladimirsitnikov] e2098d307317

[jira] [Commented] (CALCITE-2555) RexSimplify: >=(true, null) could be simplified to null

[ https://issues.apache.org/jira/browse/CALCITE-2555?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=16617189#comment-16617189 ] Zoltan Haindrich commented on CALCITE-2555: --- 1) there are multiple ways; I do

[jira] [Commented] (CALCITE-2555) RexSimplify: >=(true, null) could be simplified to null

[ https://issues.apache.org/jira/browse/CALCITE-2555?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=16617194#comment-16617194 ] Zoltan Haindrich commented on CALCITE-2555: --- [~vladimirsitnikov] 'while I am

[jira] [Commented] (CALCITE-2555) RexSimplify: >=(true, null) could be simplified to null

[ https://issues.apache.org/jira/browse/CALCITE-2555?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=16617335#comment-16617335 ] Zoltan Haindrich commented on CALCITE-2555: --- "Apparently I was checking just

[jira] [Commented] (CALCITE-2444) Handle IN expressions when converting SqlNode to SQL

[ https://issues.apache.org/jira/browse/CALCITE-2444?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=16618893#comment-16618893 ] Zoltan Haindrich commented on CALCITE-2444: --- Thank you [~vladimirsitnikov] fo

[jira] [Commented] (CALCITE-2451) RexSimplify: fuse unknownAsFalse and IS TRUE handling

[ https://issues.apache.org/jira/browse/CALCITE-2451?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=16623807#comment-16623807 ] Zoltan Haindrich commented on CALCITE-2451: --- interesting...I think I've kinda

[jira] [Commented] (CALCITE-2326) Generalize p(x) IS TRUE/FALSE/UNKNOWN handling in RexSimplify

[ https://issues.apache.org/jira/browse/CALCITE-2326?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=16633979#comment-16633979 ] Zoltan Haindrich commented on CALCITE-2326: --- Passing unkownAs in the methods

[jira] [Created] (CALCITE-2606) Return type inference for and/or may identify result type incorrectly

Zoltan Haindrich created CALCITE-2606: - Summary: Return type inference for and/or may identify result type incorrectly Key: CALCITE-2606 URL: https://issues.apache.org/jira/browse/CALCITE-2606 Pro

[jira] [Commented] (CALCITE-2606) Return type inference for and/or may identify result type incorrectly

[ https://issues.apache.org/jira/browse/CALCITE-2606?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=16637260#comment-16637260 ] Zoltan Haindrich commented on CALCITE-2606: --- That sounds good; then that will

[jira] [Moved] (CALCITE-2608) Simplifying using predicates should consider not equals in case its a predicate

[ https://issues.apache.org/jira/browse/CALCITE-2608?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Zoltan Haindrich moved HIVE-20689 to CALCITE-2608: -- Workflow: jira (was: no-reopen-closed, patch-avail) Is

[jira] [Commented] (CALCITE-2438) RexCall#isAlwaysTrue return incorrect result

[ https://issues.apache.org/jira/browse/CALCITE-2438?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=16638094#comment-16638094 ] Zoltan Haindrich commented on CALCITE-2438: --- I think this issue is very impor

[jira] [Commented] (CALCITE-2611) Code generation fails if one side of an or contains unknown

[ https://issues.apache.org/jira/browse/CALCITE-2611?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=16638411#comment-16638411 ] Zoltan Haindrich commented on CALCITE-2611: --- I'm not sure how to get started

[jira] [Created] (CALCITE-2611) Code generation fails if one side of an or contains unknown

Zoltan Haindrich created CALCITE-2611: - Summary: Code generation fails if one side of an or contains unknown Key: CALCITE-2611 URL: https://issues.apache.org/jira/browse/CALCITE-2611 Project: Calc

[jira] [Reopened] (CALCITE-2438) RexCall#isAlwaysTrue return incorrect result

[ https://issues.apache.org/jira/browse/CALCITE-2438?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Zoltan Haindrich reopened CALCITE-2438: --- Assignee: Zoltan Haindrich (was: Julian Hyde) > RexCall#isAlwaysTrue return inc

[jira] [Commented] (CALCITE-2451) RexSimplify: fuse unknownAsFalse and IS TRUE handling

[ https://issues.apache.org/jira/browse/CALCITE-2451?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=16641579#comment-16641579 ] Zoltan Haindrich commented on CALCITE-2451: --- sorry: in my last comment I was

[jira] [Commented] (CALCITE-2611) Code generation fails if one side of an or contains unknown

[ https://issues.apache.org/jira/browse/CALCITE-2611?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=16641976#comment-16641976 ] Zoltan Haindrich commented on CALCITE-2611: --- reason behind this issue is that

[jira] [Commented] (CALCITE-2611) Code generation fails if one side of an or contains unknown

[ https://issues.apache.org/jira/browse/CALCITE-2611?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=16642004#comment-16642004 ] Zoltan Haindrich commented on CALCITE-2611: --- The uncommon in this {{Boolean.F

[jira] [Commented] (CALCITE-2611) Code generation fails if one side of an or contains unknown

[ https://issues.apache.org/jira/browse/CALCITE-2611?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=16642019#comment-16642019 ] Zoltan Haindrich commented on CALCITE-2611: --- BlockBuilderTest level testcase:

[jira] [Assigned] (CALCITE-2611) Code generation fails if one side of an or contains unknown

[ https://issues.apache.org/jira/browse/CALCITE-2611?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Zoltan Haindrich reassigned CALCITE-2611: - Assignee: Zoltan Haindrich (was: Julian Hyde) > Code generation fails if one

[jira] [Commented] (CALCITE-2611) Code generation fails if one side of an or contains unknown

[ https://issues.apache.org/jira/browse/CALCITE-2611?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=16642103#comment-16642103 ] Zoltan Haindrich commented on CALCITE-2611: --- I was able to fix it by utilizin

[jira] [Commented] (CALCITE-2615) When simplifying NOT-AND-OR, RexSimplify incorrectly applies predicates deduced for operands to the same operands

[ https://issues.apache.org/jira/browse/CALCITE-2615?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=16642386#comment-16642386 ] Zoltan Haindrich commented on CALCITE-2615: --- I'll take a look > When simplif

[jira] [Commented] (CALCITE-2615) When simplifying NOT-AND-OR, RexSimplify incorrectly applies predicates deduced for operands to the same operands

[ https://issues.apache.org/jira/browse/CALCITE-2615?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=16642472#comment-16642472 ] Zoltan Haindrich commented on CALCITE-2615: --- I've found a smaller sample: {c

[jira] [Comment Edited] (CALCITE-2615) When simplifying NOT-AND-OR, RexSimplify incorrectly applies predicates deduced for operands to the same operands

[ https://issues.apache.org/jira/browse/CALCITE-2615?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=16642472#comment-16642472 ] Zoltan Haindrich edited comment on CALCITE-2615 at 10/8/18 9:26 PM: -

[jira] [Commented] (CALCITE-2615) When simplifying NOT-AND-OR, RexSimplify incorrectly applies predicates deduced for operands to the same operands

[ https://issues.apache.org/jira/browse/CALCITE-2615?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=16642567#comment-16642567 ] Zoltan Haindrich commented on CALCITE-2615: --- opened PR: [https://github.com/a

[jira] [Assigned] (CALCITE-2615) When simplifying NOT-AND-OR, RexSimplify incorrectly applies predicates deduced for operands to the same operands

[ https://issues.apache.org/jira/browse/CALCITE-2615?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Zoltan Haindrich reassigned CALCITE-2615: - Assignee: Zoltan Haindrich (was: Julian Hyde) > When simplifying NOT-AND-OR,

[jira] [Commented] (CALCITE-2615) When simplifying NOT-AND-OR, RexSimplify incorrectly applies predicates deduced for operands to the same operands

[ https://issues.apache.org/jira/browse/CALCITE-2615?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=16642900#comment-16642900 ] Zoltan Haindrich commented on CALCITE-2615: --- I went back to paper and proved

[jira] [Comment Edited] (CALCITE-2615) When simplifying NOT-AND-OR, RexSimplify incorrectly applies predicates deduced for operands to the same operands

[ https://issues.apache.org/jira/browse/CALCITE-2615?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=16642900#comment-16642900 ] Zoltan Haindrich edited comment on CALCITE-2615 at 10/9/18 7:25 AM: -

[jira] [Commented] (CALCITE-2615) When simplifying NOT-AND-OR, RexSimplify incorrectly applies predicates deduced for operands to the same operands

[ https://issues.apache.org/jira/browse/CALCITE-2615?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=16644046#comment-16644046 ] Zoltan Haindrich commented on CALCITE-2615: --- The concept on which it builds i

[jira] [Assigned] (CALCITE-1413) New CASE statement simplification

[ https://issues.apache.org/jira/browse/CALCITE-1413?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Zoltan Haindrich reassigned CALCITE-1413: - Assignee: Zoltan Haindrich (was: Jesus Camacho Rodriguez) > New CASE statemen

[jira] [Commented] (CALCITE-1413) New CASE statement simplification

[ https://issues.apache.org/jira/browse/CALCITE-1413?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=16646586#comment-16646586 ] Zoltan Haindrich commented on CALCITE-1413: --- opened [PR#886|https://github.co

[jira] [Commented] (CALCITE-2615) When simplifying NOT-AND-OR, RexSimplify incorrectly applies predicates deduced for operands to the same operands

[ https://issues.apache.org/jira/browse/CALCITE-2615?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=16646626#comment-16646626 ] Zoltan Haindrich commented on CALCITE-2615: --- in 3 valued logic the following

[jira] [Commented] (CALCITE-1289) RexUtil.simplifyCase() should account for nullability

[ https://issues.apache.org/jira/browse/CALCITE-1289?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=16650267#comment-16650267 ] Zoltan Haindrich commented on CALCITE-1289: --- I was looking into these casts a

[jira] [Created] (CALCITE-2631) Address small issues in case simplification

Zoltan Haindrich created CALCITE-2631: - Summary: Address small issues in case simplification Key: CALCITE-2631 URL: https://issues.apache.org/jira/browse/CALCITE-2631 Project: Calcite Iss

[jira] [Commented] (CALCITE-2615) When simplifying NOT-AND-OR, RexSimplify incorrectly applies predicates deduced for operands to the same operands

[ https://issues.apache.org/jira/browse/CALCITE-2615?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=16655112#comment-16655112 ] Zoltan Haindrich commented on CALCITE-2615: --- Thank you [~jcamachorodriguez] f

[jira] [Created] (CALCITE-2632) Add hashCode and equals implementations to RexNode

Zoltan Haindrich created CALCITE-2632: - Summary: Add hashCode and equals implementations to RexNode Key: CALCITE-2632 URL: https://issues.apache.org/jira/browse/CALCITE-2632 Project: Calcite

[jira] [Commented] (CALCITE-2632) Add hashCode and equals implementations to RexNode

[ https://issues.apache.org/jira/browse/CALCITE-2632?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=16655171#comment-16655171 ] Zoltan Haindrich commented on CALCITE-2632: --- I right now see to better option

[jira] [Comment Edited] (CALCITE-2632) Add hashCode and equals implementations to RexNode

[ https://issues.apache.org/jira/browse/CALCITE-2632?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=16655171#comment-16655171 ] Zoltan Haindrich edited comment on CALCITE-2632 at 10/18/18 12:41 PM: ---

[jira] [Commented] (CALCITE-2630) Convert SqlInOperator to In-Expression

[ https://issues.apache.org/jira/browse/CALCITE-2630?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=16655368#comment-16655368 ] Zoltan Haindrich commented on CALCITE-2630: --- Thank you [~pzw2018] for startin

[jira] [Created] (CALCITE-2652) Fix Rel2Sql conversion in case the join condition contains a boolean column reference

Zoltan Haindrich created CALCITE-2652: - Summary: Fix Rel2Sql conversion in case the join condition contains a boolean column reference Key: CALCITE-2652 URL: https://issues.apache.org/jira/browse/CALCITE-2652

[jira] [Updated] (CALCITE-2652) SqlNode to SQL conversion fails if the join condition contains a boolean column reference

[ https://issues.apache.org/jira/browse/CALCITE-2652?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Zoltan Haindrich updated CALCITE-2652: -- Summary: SqlNode to SQL conversion fails if the join condition contains a boolean col

[jira] [Commented] (CALCITE-2652) SqlNode to SQL conversion fails if the join condition contains a boolean column reference

[ https://issues.apache.org/jira/browse/CALCITE-2652?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=16672303#comment-16672303 ] Zoltan Haindrich commented on CALCITE-2652: --- [~julianhyde] I've updated the s

[jira] [Commented] (CALCITE-2652) SqlNode to SQL conversion fails if the join condition uses a column of type BOOLEAN

[ https://issues.apache.org/jira/browse/CALCITE-2652?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=16681504#comment-16681504 ] Zoltan Haindrich commented on CALCITE-2652: --- Thank you [~julianhyde] and [~zh

[jira] [Created] (CALCITE-2675) ReduceExpressionRule may leave behind altered types w.r.t nullability

Zoltan Haindrich created CALCITE-2675: - Summary: ReduceExpressionRule may leave behind altered types w.r.t nullability Key: CALCITE-2675 URL: https://issues.apache.org/jira/browse/CALCITE-2675 Pro

[jira] [Commented] (CALCITE-2675) ReduceExpressionRule may leave behind altered types w.r.t nullability

[ https://issues.apache.org/jira/browse/CALCITE-2675?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=16688318#comment-16688318 ] Zoltan Haindrich commented on CALCITE-2675: --- My proposed solution is to remov

[jira] [Commented] (CALCITE-2675) ReduceExpressionRule may leave behind altered types w.r.t nullability

[ https://issues.apache.org/jira/browse/CALCITE-2675?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=16689758#comment-16689758 ] Zoltan Haindrich commented on CALCITE-2675: --- [~jcamachorodriguez] Could you p

[jira] [Commented] (CALCITE-2675) ReduceExpressionRule may leave behind altered types w.r.t nullability

[ https://issues.apache.org/jira/browse/CALCITE-2675?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=16691388#comment-16691388 ] Zoltan Haindrich commented on CALCITE-2675: --- [~danny0405] Yes, I believe the

[jira] [Created] (CALCITE-2685) Bridge cases in which Calcite's type resolution is more stricter than Hive.

Zoltan Haindrich created CALCITE-2685: - Summary: Bridge cases in which Calcite's type resolution is more stricter than Hive. Key: CALCITE-2685 URL: https://issues.apache.org/jira/browse/CALCITE-2685

[jira] [Closed] (CALCITE-2685) Bridge cases in which Calcite's type resolution is more stricter than Hive.

[ https://issues.apache.org/jira/browse/CALCITE-2685?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Zoltan Haindrich closed CALCITE-2685. - Resolution: Invalid opened the issue in the wrong project; sorry for the noise... > Br

[jira] [Created] (CALCITE-2687) Is distinct from could lead to Exceptions in ReduceExpressionRule

Zoltan Haindrich created CALCITE-2687: - Summary: Is distinct from could lead to Exceptions in ReduceExpressionRule Key: CALCITE-2687 URL: https://issues.apache.org/jira/browse/CALCITE-2687 Project

[jira] [Commented] (CALCITE-2687) Is distinct from could lead to Exceptions in ReduceExpressionRule

[ https://issues.apache.org/jira/browse/CALCITE-2687?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=16693176#comment-16693176 ] Zoltan Haindrich commented on CALCITE-2687: --- Actually it seems like this was

[jira] [Commented] (CALCITE-2687) Is distinct from could lead to Exceptions in ReduceExpressionRule

[ https://issues.apache.org/jira/browse/CALCITE-2687?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=16693275#comment-16693275 ] Zoltan Haindrich commented on CALCITE-2687: --- this is probably caused by CALCI

[jira] [Commented] (CALCITE-2687) Is distinct from could lead to Exceptions in ReduceExpressionRule

[ https://issues.apache.org/jira/browse/CALCITE-2687?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=16693281#comment-16693281 ] Zoltan Haindrich commented on CALCITE-2687: --- opened: https://github.com/apach

[jira] [Created] (CALCITE-2688) Improve diagnosability when return type could not be inferred.

Zoltan Haindrich created CALCITE-2688: - Summary: Improve diagnosability when return type could not be inferred. Key: CALCITE-2688 URL: https://issues.apache.org/jira/browse/CALCITE-2688 Project: C

[jira] [Commented] (CALCITE-2688) Improve diagnosability when return type could not be inferred.

[ https://issues.apache.org/jira/browse/CALCITE-2688?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=16693358#comment-16693358 ] Zoltan Haindrich commented on CALCITE-2688: --- Note: there were some safeguards

[jira] [Created] (CALCITE-2695) Simplify casts which are only widening nullability

Zoltan Haindrich created CALCITE-2695: - Summary: Simplify casts which are only widening nullability Key: CALCITE-2695 URL: https://issues.apache.org/jira/browse/CALCITE-2695 Project: Calcite

[jira] [Commented] (CALCITE-2695) Simplify casts which are only widening nullability

[ https://issues.apache.org/jira/browse/CALCITE-2695?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=16696150#comment-16696150 ] Zoltan Haindrich commented on CALCITE-2695: --- opened [pr934|https://github.com

[jira] [Commented] (CALCITE-2699) The bug of timestampadd handles time

[ https://issues.apache.org/jira/browse/CALCITE-2699?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=16696588#comment-16696588 ] Zoltan Haindrich commented on CALCITE-2699: --- I think for {{timestampadd(MINUT

[jira] [Commented] (CALCITE-2699) The bug of timestampadd handles time

[ https://issues.apache.org/jira/browse/CALCITE-2699?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=16696656#comment-16696656 ] Zoltan Haindrich commented on CALCITE-2699: --- I've just checked {{10.1.26-Mari

[jira] [Commented] (CALCITE-2632) Add hashCode and equals implementations to RexNode

[ https://issues.apache.org/jira/browse/CALCITE-2632?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=16699068#comment-16699068 ] Zoltan Haindrich commented on CALCITE-2632: --- I was looking into how to fix an

[jira] [Commented] (CALCITE-2632) Add hashCode and equals implementations to RexNode

[ https://issues.apache.org/jira/browse/CALCITE-2632?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=16700283#comment-16700283 ] Zoltan Haindrich commented on CALCITE-2632: --- proposed solution: * add hashCo

[jira] [Commented] (CALCITE-2632) Add hashCode and equals implementations to RexNode

[ https://issues.apache.org/jira/browse/CALCITE-2632?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=16700394#comment-16700394 ] Zoltan Haindrich commented on CALCITE-2632: --- I think the goal is the same as

[jira] [Resolved] (CALCITE-1367) Implement equals and hashCode for all sub-classes of RexNode

[ https://issues.apache.org/jira/browse/CALCITE-1367?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Zoltan Haindrich resolved CALCITE-1367. --- Resolution: Duplicate dup of: CALCITE-2632 > Implement equals and hashCode for all

[jira] [Commented] (CALCITE-2632) Add hashCode and equals implementations to RexNode

[ https://issues.apache.org/jira/browse/CALCITE-2632?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=16704516#comment-16704516 ] Zoltan Haindrich commented on CALCITE-2632: --- Yes, I wanted to do the same - I

[jira] [Moved] (CALCITE-2720) Presence of an empty aggregation should not lead to Exceptions

[ https://issues.apache.org/jira/browse/CALCITE-2720?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Zoltan Haindrich moved HIVE-20991 to CALCITE-2720: -- Workflow: jira (was: no-reopen-closed, patch-avail)

[jira] [Commented] (CALCITE-2720) Presence of an empty aggregation should not lead to Exceptions

[ https://issues.apache.org/jira/browse/CALCITE-2720?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=16704928#comment-16704928 ] Zoltan Haindrich commented on CALCITE-2720: --- [~jcamachorodriguez] Could you p

[jira] [Resolved] (CALCITE-2688) Improve diagnosability when return type could not be inferred.

[ https://issues.apache.org/jira/browse/CALCITE-2688?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Zoltan Haindrich resolved CALCITE-2688. --- Resolution: Fixed Fix Version/s: 1.18.0 [~julianhyde]: This change seem to h

[jira] [Moved] (CALCITE-2726) ReduceExpressionRule may oversimplify filter conditions containing nulls

[ https://issues.apache.org/jira/browse/CALCITE-2726?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Zoltan Haindrich moved HIVE-21010 to CALCITE-2726: -- Workflow: jira (was: no-reopen-closed, patch-avail)

[jira] [Commented] (CALCITE-2726) ReduceExpressionRule may oversimplify filter conditions containing nulls

[ https://issues.apache.org/jira/browse/CALCITE-2726?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=16710396#comment-16710396 ] Zoltan Haindrich commented on CALCITE-2726: --- Proposed change: invoked simplif

[jira] [Comment Edited] (CALCITE-2726) ReduceExpressionRule may oversimplify filter conditions containing nulls

[ https://issues.apache.org/jira/browse/CALCITE-2726?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=16710396#comment-16710396 ] Zoltan Haindrich edited comment on CALCITE-2726 at 12/5/18 5:53 PM: -

[jira] [Commented] (CALCITE-2726) ReduceExpressionRule may oversimplify filter conditions containing nulls

[ https://issues.apache.org/jira/browse/CALCITE-2726?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=1676#comment-1676 ] Zoltan Haindrich commented on CALCITE-2726: --- It's a great idea to deprecate E

[jira] [Created] (CALCITE-2731) Case statements are simplified with unsafe conditions

Zoltan Haindrich created CALCITE-2731: - Summary: Case statements are simplified with unsafe conditions Key: CALCITE-2731 URL: https://issues.apache.org/jira/browse/CALCITE-2731 Project: Calcite

[jira] [Commented] (CALCITE-2730) RelBuilder simplifies a filter with duplicate conjunction to empty

[ https://issues.apache.org/jira/browse/CALCITE-2730?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=16713095#comment-16713095 ] Zoltan Haindrich commented on CALCITE-2730: --- This seems to be caused by CALCI

[jira] [Updated] (CALCITE-2731) Case statements are simplified with unsafe conditions

[ https://issues.apache.org/jira/browse/CALCITE-2731?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Zoltan Haindrich updated CALCITE-2731: -- Description: In CALCITE-1413 we were cautious to not simplify {code} CASE a=0 THEN 0

[jira] [Commented] (CALCITE-2731) Case statements are simplified with unsafe conditions

[ https://issues.apache.org/jira/browse/CALCITE-2731?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=16713179#comment-16713179 ] Zoltan Haindrich commented on CALCITE-2731: --- opened PR#960; consider LocalRef

[jira] [Commented] (CALCITE-2730) RelBuilder simplifies a filter with duplicate conjunction to empty

[ https://issues.apache.org/jira/browse/CALCITE-2730?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=16714874#comment-16714874 ] Zoltan Haindrich commented on CALCITE-2730: --- [~zabetak] the issue is with the

[jira] [Comment Edited] (CALCITE-2730) RelBuilder simplifies a filter with duplicate conjunction to empty

[ https://issues.apache.org/jira/browse/CALCITE-2730?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=16714874#comment-16714874 ] Zoltan Haindrich edited comment on CALCITE-2730 at 12/10/18 3:20 PM:

[jira] [Commented] (CALCITE-2730) RelBuilder simplifies a filter with duplicate conjunction to empty

[ https://issues.apache.org/jira/browse/CALCITE-2730?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=16714965#comment-16714965 ] Zoltan Haindrich commented on CALCITE-2730: --- It was working in 1.17 because "

[jira] [Commented] (CALCITE-2730) RelBuilder simplifies a filter with duplicate conjunction to empty

[ https://issues.apache.org/jira/browse/CALCITE-2730?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=16715036#comment-16715036 ] Zoltan Haindrich commented on CALCITE-2730: --- I think at that point replacing

[jira] [Commented] (CALCITE-2730) RelBuilder simplifies a filter with duplicate conjunction to empty

[ https://issues.apache.org/jira/browse/CALCITE-2730?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=16715080#comment-16715080 ] Zoltan Haindrich commented on CALCITE-2730: --- I wanted to suggest to prune dup

[jira] [Commented] (CALCITE-2730) RelBuilder simplifies a filter with duplicate conjunction to empty

[ https://issues.apache.org/jira/browse/CALCITE-2730?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=16715176#comment-16715176 ] Zoltan Haindrich commented on CALCITE-2730: --- without equals being fully opera

[jira] [Commented] (CALCITE-2731) RexProgramBuilder makes unsafe simplifications to CASE expressions

[ https://issues.apache.org/jira/browse/CALCITE-2731?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=16720291#comment-16720291 ] Zoltan Haindrich commented on CALCITE-2731: --- [~julianhyde] I've taken a quick

[jira] [Commented] (CALCITE-2736) ReduceExpressionsRule never reduces dynamic expressions but this should be configurable

[ https://issues.apache.org/jira/browse/CALCITE-2736?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=16723129#comment-16723129 ] Zoltan Haindrich commented on CALCITE-2736: --- [~julianhyde], [~jnadeau]: accid

[jira] [Commented] (CALCITE-2783) Null checks incorrectly optimized by RexSimplfy.simplifyBooleanCase.

[ https://issues.apache.org/jira/browse/CALCITE-2783?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=16740452#comment-16740452 ] Zoltan Haindrich commented on CALCITE-2783: --- I'll take a look > Null checks

[jira] [Assigned] (CALCITE-2783) Null checks incorrectly optimized by RexSimplfy.simplifyBooleanCase.

[ https://issues.apache.org/jira/browse/CALCITE-2783?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Zoltan Haindrich reassigned CALCITE-2783: - Assignee: Zoltan Haindrich (was: Julian Hyde) > Null checks incorrectly optim

[jira] [Commented] (CALCITE-2783) Null checks incorrectly optimized by RexSimplfy.simplifyBooleanCase.

[ https://issues.apache.org/jira/browse/CALCITE-2783?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=16740517#comment-16740517 ] Zoltan Haindrich commented on CALCITE-2783: --- note: CALCITE-1413 have exposed

[jira] [Commented] (CALCITE-2783) Null checks incorrectly optimized by RexSimplfy.simplifyBooleanCase.

[ https://issues.apache.org/jira/browse/CALCITE-2783?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=16743188#comment-16743188 ] Zoltan Haindrich commented on CALCITE-2783: --- it seems like the problem arises

[jira] [Commented] (CALCITE-2783) Null checks incorrectly optimized by RexSimplfy.simplifyBooleanCase.

[ https://issues.apache.org/jira/browse/CALCITE-2783?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=16744031#comment-16744031 ] Zoltan Haindrich commented on CALCITE-2783: --- I was able to fix this; and beca

[jira] [Updated] (CALCITE-2783) Fix null related issues during RexToLix translation

[ https://issues.apache.org/jira/browse/CALCITE-2783?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Zoltan Haindrich updated CALCITE-2783: -- Summary: Fix null related issues during RexToLix translation (was: Null checks incor

[jira] [Commented] (CALCITE-2783) Fix null related issues during RexToLix translation

[ https://issues.apache.org/jira/browse/CALCITE-2783?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=16747824#comment-16747824 ] Zoltan Haindrich commented on CALCITE-2783: --- opened pr: https://github.com/ap

  1   2   3   >