[GitHub] [carbondata] VenuReddy2103 commented on a change in pull request #3776: [CARBONDATA-3834]Segment directory and the segment file in metadata are not created for partitioned table when 'carbon.

2020-07-07 Thread GitBox
VenuReddy2103 commented on a change in pull request #3776: URL: https://github.com/apache/carbondata/pull/3776#discussion_r451275614 ## File path: hadoop/src/main/java/org/apache/carbondata/hadoop/api/CarbonOutputCommitter.java ## @@ -302,6 +318,61 @@ private void

[GitHub] [carbondata] VenuReddy2103 commented on a change in pull request #3776: [CARBONDATA-3834]Segment directory and the segment file in metadata are not created for partitioned table when 'carbon.

2020-07-07 Thread GitBox
VenuReddy2103 commented on a change in pull request #3776: URL: https://github.com/apache/carbondata/pull/3776#discussion_r451275288 ## File path: integration/spark/src/test/scala/org/apache/carbondata/spark/testsuite/standardpartition/StandardPartitionTableLoadingTestCase.scala

[GitHub] [carbondata] vikramahuja1001 commented on a change in pull request #3802: [CARBONDATA-3885] [CARBONDATA-3884] Delete Stale Segment files from Metadata folders when SI segments are deleted and

2020-07-07 Thread GitBox
vikramahuja1001 commented on a change in pull request #3802: URL: https://github.com/apache/carbondata/pull/3802#discussion_r451286366 ## File path: integration/spark/src/main/scala/org/apache/spark/sql/secondaryindex/load/CarbonInternalLoaderUtil.java ## @@ -37,7 +38,6 @@

[GitHub] [carbondata] akashrn5 commented on a change in pull request #3808: [CARBONDATA-3873] Secondary index compaction with maintable clean files causing exception

2020-07-07 Thread GitBox
akashrn5 commented on a change in pull request #3808: URL: https://github.com/apache/carbondata/pull/3808#discussion_r450658081 ## File path: integration/spark/src/main/scala/org/apache/spark/sql/secondaryindex/load/Compactor.scala ## @@ -121,10 +124,20 @@ object Compactor {

[GitHub] [carbondata] akashrn5 commented on pull request #3808: [CARBONDATA-3873] Secondary index compaction with maintable clean files causing exception

2020-07-07 Thread GitBox
akashrn5 commented on pull request #3808: URL: https://github.com/apache/carbondata/pull/3808#issuecomment-654663162 LGTM This is an automated message from the Apache Git Service. To respond to the message, please log on to

[GitHub] [carbondata] Indhumathi27 commented on pull request #3817: [CARBONDATA-3845] Bucket table creation fails with exception for empt…

2020-07-07 Thread GitBox
Indhumathi27 commented on pull request #3817: URL: https://github.com/apache/carbondata/pull/3817#issuecomment-654728062 LGTM This is an automated message from the Apache Git Service. To respond to the message, please log on

[GitHub] [carbondata] QiangCai opened a new pull request #3827: [CARBONDATA-3889] Cleanup code for carbondata-hadoop module

2020-07-07 Thread GitBox
QiangCai opened a new pull request #3827: URL: https://github.com/apache/carbondata/pull/3827 ### Why is this PR needed? need cleanup code for carbondata-hadoop module ### What changes were proposed in this PR? Cleanup code for carbondata-hadoop module ### Does

[GitHub] [carbondata] CarbonDataQA1 commented on pull request #3811: [CARBONDATA-3874] segment mismatch between maintable and SI table when load with concurrency

2020-07-07 Thread GitBox
CarbonDataQA1 commented on pull request #3811: URL: https://github.com/apache/carbondata/pull/3811#issuecomment-654732910 Build Success with Spark 2.4.5, Please check CI http://121.244.95.60:12545/job/ApacheCarbon_PR_Builder_2.4.5/1574/

[GitHub] [carbondata] CarbonDataQA1 commented on pull request #3808: [CARBONDATA-3873] Secondary index compaction with maintable clean files causing exception

2020-07-07 Thread GitBox
CarbonDataQA1 commented on pull request #3808: URL: https://github.com/apache/carbondata/pull/3808#issuecomment-654734465 Build Success with Spark 2.4.5, Please check CI http://121.244.95.60:12545/job/ApacheCarbon_PR_Builder_2.4.5/1575/

[GitHub] [carbondata] CarbonDataQA1 commented on pull request #3811: [CARBONDATA-3874] segment mismatch between maintable and SI table when load with concurrency

2020-07-07 Thread GitBox
CarbonDataQA1 commented on pull request #3811: URL: https://github.com/apache/carbondata/pull/3811#issuecomment-654730812 Build Success with Spark 2.3.4, Please check CI http://121.244.95.60:12545/job/ApacheCarbonPRBuilder2.3/3312/

[GitHub] [carbondata] CarbonDataQA1 commented on pull request #3808: [CARBONDATA-3873] Secondary index compaction with maintable clean files causing exception

2020-07-07 Thread GitBox
CarbonDataQA1 commented on pull request #3808: URL: https://github.com/apache/carbondata/pull/3808#issuecomment-654733164 Build Success with Spark 2.3.4, Please check CI http://121.244.95.60:12545/job/ApacheCarbonPRBuilder2.3/3313/

[GitHub] [carbondata] VenuReddy2103 commented on a change in pull request #3776: [CARBONDATA-3834]Segment directory and the segment file in metadata are not created for partitioned table when 'carbon.

2020-07-07 Thread GitBox
VenuReddy2103 commented on a change in pull request #3776: URL: https://github.com/apache/carbondata/pull/3776#discussion_r450746967 ## File path: hadoop/src/main/java/org/apache/carbondata/hadoop/api/CarbonOutputCommitter.java ## @@ -282,10 +296,12 @@ private void

[GitHub] [carbondata] akashrn5 commented on pull request #3811: [CARBONDATA-3874] segment mismatch between maintable and SI table when load with concurrency

2020-07-07 Thread GitBox
akashrn5 commented on pull request #3811: URL: https://github.com/apache/carbondata/pull/3811#issuecomment-654787100 retest this please This is an automated message from the Apache Git Service. To respond to the message,

[GitHub] [carbondata] akashrn5 commented on pull request #3786: [CARBONDATA-3842] Fix incorrect results on mv with limit (Missed code during mv refcatory)

2020-07-07 Thread GitBox
akashrn5 commented on pull request #3786: URL: https://github.com/apache/carbondata/pull/3786#issuecomment-654788035 retest this please This is an automated message from the Apache Git Service. To respond to the message,

[GitHub] [carbondata] nihal0107 commented on pull request #3819: [CARBONDATA-3855]support carbon SDK to load data from different files

2020-07-07 Thread GitBox
nihal0107 commented on pull request #3819: URL: https://github.com/apache/carbondata/pull/3819#issuecomment-654840974 > @nihal0107 Please remove unused binary files from this PR Those are not the unused binary files. Those are either parquet or ORC or avro file which I am using

[GitHub] [carbondata] VenuReddy2103 commented on a change in pull request #3776: [CARBONDATA-3834]Segment directory and the segment file in metadata are not created for partitioned table when 'carbon.

2020-07-07 Thread GitBox
VenuReddy2103 commented on a change in pull request #3776: URL: https://github.com/apache/carbondata/pull/3776#discussion_r450765502 ## File path: integration/spark/src/main/scala/org/apache/spark/sql/execution/datasources/SparkCarbonTableFormat.scala ## @@ -253,6 +255,14 @@

[GitHub] [carbondata] CarbonDataQA1 commented on pull request #3827: [CARBONDATA-3889] Cleanup code for carbondata-hadoop module

2020-07-07 Thread GitBox
CarbonDataQA1 commented on pull request #3827: URL: https://github.com/apache/carbondata/pull/3827#issuecomment-654746270 Build Success with Spark 2.3.4, Please check CI http://121.244.95.60:12545/job/ApacheCarbonPRBuilder2.3/3314/

[GitHub] [carbondata] akashrn5 commented on pull request #3811: [CARBONDATA-3874] segment mismatch between maintable and SI table when load with concurrency

2020-07-07 Thread GitBox
akashrn5 commented on pull request #3811: URL: https://github.com/apache/carbondata/pull/3811#issuecomment-654776383 LGTM This is an automated message from the Apache Git Service. To respond to the message, please log on to

[GitHub] [carbondata] akashrn5 commented on pull request #3802: [CARBONDATA-3885] [CARBONDATA-3884] Delete Stale Segment files from Metadata folders when SI segments are deleted and Fix for Concurrent

2020-07-07 Thread GitBox
akashrn5 commented on pull request #3802: URL: https://github.com/apache/carbondata/pull/3802#issuecomment-654791824 @vikramahuja1001 the issue reproduce steps, please mention in jira and for PR description, give proper issue, root cause and solution proposed.

[GitHub] [carbondata] VenuReddy2103 commented on a change in pull request #3776: [CARBONDATA-3834]Segment directory and the segment file in metadata are not created for partitioned table when 'carbon.

2020-07-07 Thread GitBox
VenuReddy2103 commented on a change in pull request #3776: URL: https://github.com/apache/carbondata/pull/3776#discussion_r450746967 ## File path: hadoop/src/main/java/org/apache/carbondata/hadoop/api/CarbonOutputCommitter.java ## @@ -282,10 +296,12 @@ private void

[GitHub] [carbondata] VenuReddy2103 commented on a change in pull request #3776: [CARBONDATA-3834]Segment directory and the segment file in metadata are not created for partitioned table when 'carbon.

2020-07-07 Thread GitBox
VenuReddy2103 commented on a change in pull request #3776: URL: https://github.com/apache/carbondata/pull/3776#discussion_r450765502 ## File path: integration/spark/src/main/scala/org/apache/spark/sql/execution/datasources/SparkCarbonTableFormat.scala ## @@ -253,6 +255,14 @@

[GitHub] [carbondata] asfgit closed pull request #3808: [CARBONDATA-3873] Secondary index compaction with maintable clean files causing exception

2020-07-07 Thread GitBox
asfgit closed pull request #3808: URL: https://github.com/apache/carbondata/pull/3808 This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go

[GitHub] [carbondata] akashrn5 commented on a change in pull request #3802: [CARBONDATA-3885] [CARBONDATA-3884] Delete Stale Segment files from Metadata folders when SI segments are deleted and Fix fo

2020-07-07 Thread GitBox
akashrn5 commented on a change in pull request #3802: URL: https://github.com/apache/carbondata/pull/3802#discussion_r450316210 ## File path: integration/spark/src/main/scala/org/apache/spark/sql/secondaryindex/load/CarbonInternalLoaderUtil.java ## @@ -37,7 +38,6 @@ import

[GitHub] [carbondata] nihal0107 commented on a change in pull request #3819: [CARBONDATA-3855]support carbon SDK to load data from different files

2020-07-07 Thread GitBox
nihal0107 commented on a change in pull request #3819: URL: https://github.com/apache/carbondata/pull/3819#discussion_r450844187 ## File path: sdk/sdk/src/main/java/org/apache/carbondata/sdk/file/ParquetCarbonWriter.java ## @@ -0,0 +1,116 @@ +/* + * Licensed to the Apache

[GitHub] [carbondata] nihal0107 commented on a change in pull request #3819: [CARBONDATA-3855]support carbon SDK to load data from different files

2020-07-07 Thread GitBox
nihal0107 commented on a change in pull request #3819: URL: https://github.com/apache/carbondata/pull/3819#discussion_r450843943 ## File path: sdk/sdk/src/main/java/org/apache/carbondata/sdk/file/ORCCarbonWriter.java ## @@ -0,0 +1,196 @@ +/* + * Licensed to the Apache

[GitHub] [carbondata] nihal0107 commented on a change in pull request #3819: [CARBONDATA-3855]support carbon SDK to load data from different files

2020-07-07 Thread GitBox
nihal0107 commented on a change in pull request #3819: URL: https://github.com/apache/carbondata/pull/3819#discussion_r450844071 ## File path: sdk/sdk/src/main/java/org/apache/carbondata/sdk/file/ORCCarbonWriter.java ## @@ -0,0 +1,196 @@ +/* + * Licensed to the Apache

[GitHub] [carbondata] CarbonDataQA1 commented on pull request #3827: [CARBONDATA-3889] Cleanup code for carbondata-hadoop module

2020-07-07 Thread GitBox
CarbonDataQA1 commented on pull request #3827: URL: https://github.com/apache/carbondata/pull/3827#issuecomment-654748600 Build Success with Spark 2.4.5, Please check CI http://121.244.95.60:12545/job/ApacheCarbon_PR_Builder_2.4.5/1576/

[GitHub] [carbondata] QiangCai opened a new pull request #3828: [CARBONDATA-3889] Cleanup typo code for carbondata-core module

2020-07-07 Thread GitBox
QiangCai opened a new pull request #3828: URL: https://github.com/apache/carbondata/pull/3828 ### Why is this PR needed? There are many typos in carbondata-core module ### What changes were proposed in this PR? Cleanup typo code for carbondata-core module ###

[GitHub] [carbondata] nihal0107 commented on a change in pull request #3819: [CARBONDATA-3855]support carbon SDK to load data from different files

2020-07-07 Thread GitBox
nihal0107 commented on a change in pull request #3819: URL: https://github.com/apache/carbondata/pull/3819#discussion_r450845011 ## File path: sdk/sdk/src/main/java/org/apache/carbondata/sdk/file/CarbonWriterBuilder.java ## @@ -594,6 +613,332 @@ public CarbonWriterBuilder

[GitHub] [carbondata] nihal0107 commented on a change in pull request #3819: [CARBONDATA-3855]support carbon SDK to load data from different files

2020-07-07 Thread GitBox
nihal0107 commented on a change in pull request #3819: URL: https://github.com/apache/carbondata/pull/3819#discussion_r450844563 ## File path: sdk/sdk/src/main/java/org/apache/carbondata/sdk/file/ParquetCarbonWriter.java ## @@ -0,0 +1,116 @@ +/* + * Licensed to the Apache

[GitHub] [carbondata] CarbonDataQA1 commented on pull request #3828: [CARBONDATA-3889] Cleanup typo code for carbondata-core module

2020-07-07 Thread GitBox
CarbonDataQA1 commented on pull request #3828: URL: https://github.com/apache/carbondata/pull/3828#issuecomment-654907957 Build Success with Spark 2.3.4, Please check CI http://121.244.95.60:12545/job/ApacheCarbonPRBuilder2.3/3318/

[GitHub] [carbondata] nihal0107 commented on a change in pull request #3819: [CARBONDATA-3855]support carbon SDK to load data from different files

2020-07-07 Thread GitBox
nihal0107 commented on a change in pull request #3819: URL: https://github.com/apache/carbondata/pull/3819#discussion_r450848843 ## File path: sdk/sdk/src/main/java/org/apache/carbondata/sdk/file/CarbonWriterBuilder.java ## @@ -594,6 +613,332 @@ public CarbonWriterBuilder

[GitHub] [carbondata] CarbonDataQA1 commented on pull request #3786: [CARBONDATA-3842] Fix incorrect results on mv with limit (Missed code during mv refcatory)

2020-07-07 Thread GitBox
CarbonDataQA1 commented on pull request #3786: URL: https://github.com/apache/carbondata/pull/3786#issuecomment-654870645 Build Success with Spark 2.4.5, Please check CI http://121.244.95.60:12545/job/ApacheCarbon_PR_Builder_2.4.5/1578/

[GitHub] [carbondata] CarbonDataQA1 commented on pull request #3811: [CARBONDATA-3874] segment mismatch between maintable and SI table when load with concurrency

2020-07-07 Thread GitBox
CarbonDataQA1 commented on pull request #3811: URL: https://github.com/apache/carbondata/pull/3811#issuecomment-654872025 Build Success with Spark 2.3.4, Please check CI http://121.244.95.60:12545/job/ApacheCarbonPRBuilder2.3/3315/

[GitHub] [carbondata] nihal0107 commented on a change in pull request #3819: [CARBONDATA-3855]support carbon SDK to load data from different files

2020-07-07 Thread GitBox
nihal0107 commented on a change in pull request #3819: URL: https://github.com/apache/carbondata/pull/3819#discussion_r450849269 ## File path: sdk/sdk/src/main/java/org/apache/carbondata/sdk/file/CarbonWriterBuilder.java ## @@ -594,6 +613,332 @@ public CarbonWriterBuilder

[GitHub] [carbondata] CarbonDataQA1 commented on pull request #3828: [CARBONDATA-3889] Cleanup typo code for carbondata-core module

2020-07-07 Thread GitBox
CarbonDataQA1 commented on pull request #3828: URL: https://github.com/apache/carbondata/pull/3828#issuecomment-654910077 Build Success with Spark 2.4.5, Please check CI http://121.244.95.60:12545/job/ApacheCarbon_PR_Builder_2.4.5/1579/

[GitHub] [carbondata] CarbonDataQA1 commented on pull request #3811: [CARBONDATA-3874] segment mismatch between maintable and SI table when load with concurrency

2020-07-07 Thread GitBox
CarbonDataQA1 commented on pull request #3811: URL: https://github.com/apache/carbondata/pull/3811#issuecomment-654872523 Build Success with Spark 2.4.5, Please check CI http://121.244.95.60:12545/job/ApacheCarbon_PR_Builder_2.4.5/1577/

[GitHub] [carbondata] CarbonDataQA1 commented on pull request #3786: [CARBONDATA-3842] Fix incorrect results on mv with limit (Missed code during mv refcatory)

2020-07-07 Thread GitBox
CarbonDataQA1 commented on pull request #3786: URL: https://github.com/apache/carbondata/pull/3786#issuecomment-654872715 Build Success with Spark 2.3.4, Please check CI http://121.244.95.60:12545/job/ApacheCarbonPRBuilder2.3/3316/

[GitHub] [carbondata] CarbonDataQA1 commented on pull request #3819: [CARBONDATA-3855]support carbon SDK to load data from different files

2020-07-07 Thread GitBox
CarbonDataQA1 commented on pull request #3819: URL: https://github.com/apache/carbondata/pull/3819#issuecomment-654937795 Build Success with Spark 2.3.4, Please check CI http://121.244.95.60:12545/job/ApacheCarbonPRBuilder2.3/3319/

[GitHub] [carbondata] VenuReddy2103 commented on a change in pull request #3776: [CARBONDATA-3834]Segment directory and the segment file in metadata are not created for partitioned table when 'carbon.

2020-07-07 Thread GitBox
VenuReddy2103 commented on a change in pull request #3776: URL: https://github.com/apache/carbondata/pull/3776#discussion_r450765502 ## File path: integration/spark/src/main/scala/org/apache/spark/sql/execution/datasources/SparkCarbonTableFormat.scala ## @@ -253,6 +255,14 @@

[GitHub] [carbondata] CarbonDataQA1 commented on pull request #3819: [CARBONDATA-3855]support carbon SDK to load data from different files

2020-07-07 Thread GitBox
CarbonDataQA1 commented on pull request #3819: URL: https://github.com/apache/carbondata/pull/3819#issuecomment-654963937 Build Failed with Spark 2.4.5, Please check CI http://121.244.95.60:12545/job/ApacheCarbon_PR_Builder_2.4.5/1580/

[GitHub] [carbondata] VenuReddy2103 commented on a change in pull request #3776: [CARBONDATA-3834]Segment directory and the segment file in metadata are not created for partitioned table when 'carbon.

2020-07-07 Thread GitBox
VenuReddy2103 commented on a change in pull request #3776: URL: https://github.com/apache/carbondata/pull/3776#discussion_r450765502 ## File path: integration/spark/src/main/scala/org/apache/spark/sql/execution/datasources/SparkCarbonTableFormat.scala ## @@ -253,6 +255,14 @@

[GitHub] [carbondata] ajantha-bhat opened a new pull request #3829: [WIP] Fix maintable load failure in concurrent load and compaction sceneario

2020-07-07 Thread GitBox
ajantha-bhat opened a new pull request #3829: URL: https://github.com/apache/carbondata/pull/3829 ### Why is this PR needed? ### What changes were proposed in this PR? ### Does this PR introduce any user interface change? - No - Yes. (please explain

[GitHub] [carbondata] nihal0107 commented on pull request #3819: [CARBONDATA-3855]support carbon SDK to load data from different files

2020-07-07 Thread GitBox
nihal0107 commented on pull request #3819: URL: https://github.com/apache/carbondata/pull/3819#issuecomment-654983835 retest this please This is an automated message from the Apache Git Service. To respond to the message,

[GitHub] [carbondata] CarbonDataQA1 commented on pull request #3829: [WIP] Fix maintable load failure in concurrent load and compaction sceneario

2020-07-07 Thread GitBox
CarbonDataQA1 commented on pull request #3829: URL: https://github.com/apache/carbondata/pull/3829#issuecomment-655023313 Build Success with Spark 2.4.5, Please check CI http://121.244.95.60:12545/job/ApacheCarbon_PR_Builder_2.4.5/1581/

[GitHub] [carbondata] CarbonDataQA1 commented on pull request #3829: [WIP] Fix maintable load failure in concurrent load and compaction sceneario

2020-07-07 Thread GitBox
CarbonDataQA1 commented on pull request #3829: URL: https://github.com/apache/carbondata/pull/3829#issuecomment-655022713 Build Success with Spark 2.3.4, Please check CI http://121.244.95.60:12545/job/ApacheCarbonPRBuilder2.3/3320/

[GitHub] [carbondata] CarbonDataQA1 commented on pull request #3776: [CARBONDATA-3834]Segment directory and the segment file in metadata are not created for partitioned table when 'carbon.merge.index.

2020-07-07 Thread GitBox
CarbonDataQA1 commented on pull request #3776: URL: https://github.com/apache/carbondata/pull/3776#issuecomment-655060959 Build Success with Spark 2.4.5, Please check CI http://121.244.95.60:12545/job/ApacheCarbon_PR_Builder_2.4.5/1585/

[GitHub] [carbondata] CarbonDataQA1 commented on pull request #3776: [CARBONDATA-3834]Segment directory and the segment file in metadata are not created for partitioned table when 'carbon.merge.index.

2020-07-07 Thread GitBox
CarbonDataQA1 commented on pull request #3776: URL: https://github.com/apache/carbondata/pull/3776#issuecomment-655062212 Build Success with Spark 2.3.4, Please check CI http://121.244.95.60:12545/job/ApacheCarbonPRBuilder2.3/3325/

[GitHub] [carbondata] CarbonDataQA1 commented on pull request #3819: [CARBONDATA-3855]support carbon SDK to load data from different files

2020-07-07 Thread GitBox
CarbonDataQA1 commented on pull request #3819: URL: https://github.com/apache/carbondata/pull/3819#issuecomment-655086214 Build Failed with Spark 2.3.4, Please check CI http://121.244.95.60:12545/job/ApacheCarbonPRBuilder2.3/3322/

[GitHub] [carbondata] CarbonDataQA1 commented on pull request #3819: [CARBONDATA-3855]support carbon SDK to load data from different files

2020-07-07 Thread GitBox
CarbonDataQA1 commented on pull request #3819: URL: https://github.com/apache/carbondata/pull/3819#issuecomment-655059772 Build Success with Spark 2.4.5, Please check CI http://121.244.95.60:12545/job/ApacheCarbon_PR_Builder_2.4.5/1583/