ShreelekhyaG commented on pull request #3922:
URL: https://github.com/apache/carbondata/pull/3922#issuecomment-692454326
@akashrn5 for partition with SI case, partition prefix should not be
removed. made small change to my existing code to be compatible. Please check.
CarbonDataQA1 commented on pull request #3926:
URL: https://github.com/apache/carbondata/pull/3926#issuecomment-692459941
Build Success with Spark 2.3.4, Please check CI
http://121.244.95.60:12545/job/ApacheCarbonPRBuilder2.3/4070/
CarbonDataQA1 commented on pull request #3926:
URL: https://github.com/apache/carbondata/pull/3926#issuecomment-692459084
Build Success with Spark 2.4.5, Please check CI
http://121.244.95.60:12545/job/ApacheCarbon_PR_Builder_2.4.5/2331/
akashrn5 commented on pull request #3925:
URL: https://github.com/apache/carbondata/pull/3925#issuecomment-692456538
> Actually, we shall not do the clean work during UPDATE/DELETE. I think we
can directly remove this code to avoid any possiblity of data lose.
>
> > @marchpure can
CarbonDataQA1 commented on pull request #3922:
URL: https://github.com/apache/carbondata/pull/3922#issuecomment-692474056
Build Success with Spark 2.3.4, Please check CI
http://121.244.95.60:12545/job/ApacheCarbonPRBuilder2.3/4071/
ShreelekhyaG commented on pull request #3890:
URL: https://github.com/apache/carbondata/pull/3890#issuecomment-692482869
Closing this PR, as it is identified as spark bug. More details can be found
at https://issues.apache.org/jira/browse/SPARK-31234
[
https://issues.apache.org/jira/browse/CARBONDATA-3952?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel
]
SHREELEKHYA GAMPA updated CARBONDATA-3952:
--
Description:
After reset query not hitting MV.
With the reset,
[
https://issues.apache.org/jira/browse/CARBONDATA-3952?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel
]
SHREELEKHYA GAMPA updated CARBONDATA-3952:
--
Description:
After reset query not hitting MV.
With the reset,
CarbonDataQA1 commented on pull request #3922:
URL: https://github.com/apache/carbondata/pull/3922#issuecomment-692474670
Build Success with Spark 2.4.5, Please check CI
http://121.244.95.60:12545/job/ApacheCarbon_PR_Builder_2.4.5/2332/
jxxfxkp commented on pull request #3662:
URL: https://github.com/apache/carbondata/pull/3662#issuecomment-692436531
Are you sure you can compile successfully? Some packages and classes are not
in the right position ...
Even if I change, I still can't start presto-330 because it can't
ajantha-bhat commented on pull request #3662:
URL: https://github.com/apache/carbondata/pull/3662#issuecomment-692438325
@jxxfxkp : Have you cherry picked this PR? The same errors were resolved in
this PR. Open source master cannot work with presto 330. This PR can
marchpure commented on pull request #3925:
URL: https://github.com/apache/carbondata/pull/3925#issuecomment-692439483
Actually, we shall not do the clean work during UPDATE/DELETE. I think we
can directly remove this code to avoid any possiblity of data lose.
> @marchpure can
ajantha-bhat commented on pull request #3925:
URL: https://github.com/apache/carbondata/pull/3925#issuecomment-691863991
This is an automated message from the Apache Git Service.
To respond to the message, please log on to
CarbonDataQA1 commented on pull request #3924:
URL: https://github.com/apache/carbondata/pull/3924#issuecomment-691886172
Build Success with Spark 2.3.4, Please check CI
http://121.244.95.60:12545/job/ApacheCarbonPRBuilder2.3/4058/
akashrn5 commented on pull request #3925:
URL: https://github.com/apache/carbondata/pull/3925#issuecomment-691904597
add to whitelist
This is an automated message from the Apache Git Service.
To respond to the message,
akashrn5 commented on pull request #3922:
URL: https://github.com/apache/carbondata/pull/3922#issuecomment-691931424
@ShreelekhyaG can you please check for the compatibility of update and
delete case also and try to handle in this PR? As this is is specific to
tupleID, and recent PR
akashrn5 commented on pull request #3911:
URL: https://github.com/apache/carbondata/pull/3911#issuecomment-691917541
@kunal642 build passed, please check
This is an automated message from the Apache Git Service.
To respond
CarbonDataQA1 commented on pull request #3925:
URL: https://github.com/apache/carbondata/pull/3925#issuecomment-691950938
Build Failed with Spark 2.3.4, Please check CI
http://121.244.95.60:12545/job/ApacheCarbonPRBuilder2.3/4062/
ajantha-bhat commented on pull request #3924:
URL: https://github.com/apache/carbondata/pull/3924#issuecomment-691960921
@jack86596 : You can give me more scenario example to add if you have for
this.
This is an automated
CarbonDataQA1 commented on pull request #3876:
URL: https://github.com/apache/carbondata/pull/3876#issuecomment-691975979
Build Success with Spark 2.3.4, Please check CI
http://121.244.95.60:12545/job/ApacheCarbonPRBuilder2.3/4064/
CarbonDataQA1 commented on pull request #3915:
URL: https://github.com/apache/carbondata/pull/3915#issuecomment-691982446
Build Failed with Spark 2.4.5, Please check CI
http://121.244.95.60:12545/job/ApacheCarbon_PR_Builder_2.4.5/2324/
CarbonDataQA1 commented on pull request #3927:
URL: https://github.com/apache/carbondata/pull/3927#issuecomment-691982389
Build Success with Spark 2.3.4, Please check CI
http://121.244.95.60:12545/job/ApacheCarbonPRBuilder2.3/4065/
CarbonDataQA1 commented on pull request #3922:
URL: https://github.com/apache/carbondata/pull/3922#issuecomment-691888439
Build Success with Spark 2.3.4, Please check CI
http://121.244.95.60:12545/job/ApacheCarbonPRBuilder2.3/4059/
akashrn5 commented on pull request #3890:
URL: https://github.com/apache/carbondata/pull/3890#issuecomment-691929213
@ShreelekhyaG as discussed this is fixed in spark, as it was a spark bug, so
can you please close this PR. Please provide the spark jira link in both PR and
CARBONDATA-3952
CarbonDataQA1 commented on pull request #3876:
URL: https://github.com/apache/carbondata/pull/3876#issuecomment-691977352
Build Success with Spark 2.4.5, Please check CI
http://121.244.95.60:12545/job/ApacheCarbon_PR_Builder_2.4.5/2325/
CarbonDataQA1 commented on pull request #3926:
URL: https://github.com/apache/carbondata/pull/3926#issuecomment-691908841
Can one of the admins verify this patch?
This is an automated message from the Apache Git Service.
To
akashrn5 edited a comment on pull request #3925:
URL: https://github.com/apache/carbondata/pull/3925#issuecomment-691913393
@su-article as i can see from code, the delete status which is
`deleteStatus` is updated in `deleteDeltaFunc` function and inside the
executor, and we are returning
akashrn5 commented on pull request #3925:
URL: https://github.com/apache/carbondata/pull/3925#issuecomment-691915235
@marchpure can you please check my comment and give your opinion?
This is an automated message from the
akashrn5 commented on pull request #3915:
URL: https://github.com/apache/carbondata/pull/3915#issuecomment-691919229
@kunal642 please review
This is an automated message from the Apache Git Service.
To respond to the
CarbonDataQA1 commented on pull request #3925:
URL: https://github.com/apache/carbondata/pull/3925#issuecomment-691952268
Build Failed with Spark 2.4.5, Please check CI
http://121.244.95.60:12545/job/ApacheCarbon_PR_Builder_2.4.5/2323/
CarbonDataQA1 commented on pull request #3915:
URL: https://github.com/apache/carbondata/pull/3915#issuecomment-691977347
Build Success with Spark 2.3.4, Please check CI
http://121.244.95.60:12545/job/ApacheCarbonPRBuilder2.3/4063/
CarbonDataQA1 commented on pull request #3922:
URL: https://github.com/apache/carbondata/pull/3922#issuecomment-691886899
Build Success with Spark 2.4.5, Please check CI
http://121.244.95.60:12545/job/ApacheCarbon_PR_Builder_2.4.5/2321/
akashrn5 commented on pull request #3922:
URL: https://github.com/apache/carbondata/pull/3922#issuecomment-691933797
@ShreelekhyaG also please check the partition table in SI, update and delete
cases.
This is an automated
CarbonDataQA1 commented on pull request #3924:
URL: https://github.com/apache/carbondata/pull/3924#issuecomment-691889246
Build Success with Spark 2.4.5, Please check CI
http://121.244.95.60:12545/job/ApacheCarbon_PR_Builder_2.4.5/2320/
akashrn5 opened a new pull request #3927:
URL: https://github.com/apache/carbondata/pull/3927
### Why is this PR needed?
### What changes were proposed in this PR?
### Does this PR introduce any user interface change?
- No
- Yes. (please explain the
nstang01 opened a new pull request #3926:
URL: https://github.com/apache/carbondata/pull/3926
### Why is this PR needed?
Update operation will clean up delta files before update( see
cleanUpDeltaFiles(carbonTable, false)), It's loop traversal metadata path
and segment path many
akashrn5 commented on pull request #3925:
URL: https://github.com/apache/carbondata/pull/3925#issuecomment-691913393
@su-article as i can see from code, the delete status which is
`deleteStatus` is updated in `deleteDeltaFunc` function and inside the
executor, and we are returning the
Karan980 commented on pull request #3876:
URL: https://github.com/apache/carbondata/pull/3876#issuecomment-691918465
retest this please
This is an automated message from the Apache Git Service.
To respond to the message,
ajantha-bhat edited a comment on pull request #3871:
URL: https://github.com/apache/carbondata/pull/3871#issuecomment-692003597
@akashrn5 , It was a WIP PR. Now I got some time and worked on it. Removed
WIP now.
PR is ready you can freshly review and merge.
ajantha-bhat commented on a change in pull request #3871:
URL: https://github.com/apache/carbondata/pull/3871#discussion_r487851114
##
File path:
processing/src/main/java/org/apache/carbondata/processing/loading/TableProcessingOperations.java
##
@@ -54,39 +59,77 @@
public
Chetan Bhat created CARBONDATA-3987:
---
Summary: Issues in SDK Pagination reader (2 issues)
Key: CARBONDATA-3987
URL: https://issues.apache.org/jira/browse/CARBONDATA-3987
Project: CarbonData
Ajantha Bhat created CARBONDATA-3986:
Summary: multiple issues during compaction and concurrent scenarios
Key: CARBONDATA-3986
URL: https://issues.apache.org/jira/browse/CARBONDATA-3986
Project:
ajantha-bhat commented on a change in pull request #3871:
URL: https://github.com/apache/carbondata/pull/3871#discussion_r487851114
##
File path:
processing/src/main/java/org/apache/carbondata/processing/loading/TableProcessingOperations.java
##
@@ -54,39 +59,77 @@
public
CarbonDataQA1 commented on pull request #3871:
URL: https://github.com/apache/carbondata/pull/3871#issuecomment-692003279
Build Success with Spark 2.3.4, Please check CI
http://121.244.95.60:12545/job/ApacheCarbonPRBuilder2.3/4066/
ajantha-bhat commented on pull request #3871:
URL: https://github.com/apache/carbondata/pull/3871#issuecomment-692003597
@akashrn5 , It was a WIP PR. Now I got some time and worked on it.
PR is ready you can freshly review and merge.
CarbonDataQA1 commented on pull request #3923:
URL: https://github.com/apache/carbondata/pull/3923#issuecomment-692026848
Build Success with Spark 2.3.4, Please check CI
http://121.244.95.60:12545/job/ApacheCarbonPRBuilder2.3/4067/
CarbonDataQA1 commented on pull request #3923:
URL: https://github.com/apache/carbondata/pull/3923#issuecomment-692027111
Build Success with Spark 2.4.5, Please check CI
http://121.244.95.60:12545/job/ApacheCarbon_PR_Builder_2.4.5/2328/
ajantha-bhat commented on a change in pull request #3871:
URL: https://github.com/apache/carbondata/pull/3871#discussion_r487850404
##
File path:
integration/spark/src/main/scala/org/apache/carbondata/spark/rdd/CarbonTableCompactor.scala
##
@@ -373,11 +381,7 @@ class
akashrn5 commented on pull request #3922:
URL: https://github.com/apache/carbondata/pull/3922#issuecomment-692059466
> @akashrn5 I have tested for update and delete case for a table with and
without partition. It is working fine.
Yes, since we generate tupleID on the fly and dont
ajantha-bhat commented on a change in pull request #3919:
URL: https://github.com/apache/carbondata/pull/3919#discussion_r487970151
##
File path:
integration/spark/src/main/scala/org/apache/spark/sql/execution/command/management/CarbonLoadDataCommand.scala
##
@@ -191,7
CarbonDataQA1 commented on pull request #3871:
URL: https://github.com/apache/carbondata/pull/3871#issuecomment-691996188
Build Success with Spark 2.4.5, Please check CI
http://121.244.95.60:12545/job/ApacheCarbon_PR_Builder_2.4.5/2327/
ShreelekhyaG commented on pull request #3922:
URL: https://github.com/apache/carbondata/pull/3922#issuecomment-692052269
@akashrn5 I have tested for update and delete case for a table with and
without partition. It is working fine.
CarbonDataQA1 commented on pull request #3927:
URL: https://github.com/apache/carbondata/pull/3927#issuecomment-691991425
Build Success with Spark 2.4.5, Please check CI
http://121.244.95.60:12545/job/ApacheCarbon_PR_Builder_2.4.5/2326/
ajantha-bhat commented on a change in pull request #3919:
URL: https://github.com/apache/carbondata/pull/3919#discussion_r487970978
##
File path:
integration/spark/src/main/scala/org/apache/spark/sql/execution/command/management/CommonLoadUtils.scala
##
@@ -1064,6 +1064,7 @@
CarbonDataQA1 commented on pull request #3923:
URL: https://github.com/apache/carbondata/pull/3923#issuecomment-692121002
Build Success with Spark 2.4.5, Please check CI
http://121.244.95.60:12545/job/ApacheCarbon_PR_Builder_2.4.5/2329/
Akash R Nilugal created CARBONDATA-3989:
---
Summary: Unnecessary segment files are created even when the
segments are neither updated nor deleted
Key: CARBONDATA-3989
URL:
brijoobopanna commented on pull request #3926:
URL: https://github.com/apache/carbondata/pull/3926#issuecomment-692202971
add to whitelist
This is an automated message from the Apache Git Service.
To respond to the
CarbonDataQA1 commented on pull request #3926:
URL: https://github.com/apache/carbondata/pull/3926#issuecomment-692204608
Build Failed with Spark 2.4.5, Please check CI
http://121.244.95.60:12545/job/ApacheCarbon_PR_Builder_2.4.5/2330/
CarbonDataQA1 commented on pull request #3926:
URL: https://github.com/apache/carbondata/pull/3926#issuecomment-692205105
Build Failed with Spark 2.3.4, Please check CI
http://121.244.95.60:12545/job/ApacheCarbonPRBuilder2.3/4069/
asfgit closed pull request #3911:
URL: https://github.com/apache/carbondata/pull/3911
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go
CarbonDataQA1 commented on pull request #3923:
URL: https://github.com/apache/carbondata/pull/3923#issuecomment-692119684
Build Success with Spark 2.3.4, Please check CI
http://121.244.95.60:12545/job/ApacheCarbonPRBuilder2.3/4068/
akashrn5 commented on a change in pull request #3871:
URL: https://github.com/apache/carbondata/pull/3871#discussion_r487993198
##
File path:
core/src/main/java/org/apache/carbondata/core/writer/CarbonIndexFileMergeWriter.java
##
@@ -233,15 +234,24 @@ public String
[
https://issues.apache.org/jira/browse/CARBONDATA-3793?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=17195631#comment-17195631
]
Akash R Nilugal commented on CARBONDATA-3793:
-
PR
Ajantha Bhat created CARBONDATA-3988:
Summary: Support First dimension also as SI column
Key: CARBONDATA-3988
URL: https://issues.apache.org/jira/browse/CARBONDATA-3988
Project: CarbonData
kunal642 commented on pull request #3911:
URL: https://github.com/apache/carbondata/pull/3911#issuecomment-692114248
LGTM
This is an automated message from the Apache Git Service.
To respond to the message, please log on to
[
https://issues.apache.org/jira/browse/CARBONDATA-3973?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel
]
Akash R Nilugal resolved CARBONDATA-3973.
-
Fix Version/s: 2.1.0
Resolution: Fixed
> update and delete does not
akashrn5 commented on pull request #3911:
URL: https://github.com/apache/carbondata/pull/3911#issuecomment-692117143
Jira of this PR is CARBONDATA-3973
This is an automated message from the Apache Git Service.
To respond to
[
https://issues.apache.org/jira/browse/CARBONDATA-3973?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=17195511#comment-17195511
]
Akash R Nilugal commented on CARBONDATA-3973:
-
Linked to
ShreelekhyaG commented on a change in pull request #3922:
URL: https://github.com/apache/carbondata/pull/3922#discussion_r487668590
##
File path:
core/src/main/java/org/apache/carbondata/core/scan/expression/conditional/ImplicitExpression.java
##
@@ -60,12 +61,16 @@ public
CarbonDataQA1 commented on pull request #3911:
URL: https://github.com/apache/carbondata/pull/3911#issuecomment-691850462
Build Success with Spark 2.3.4, Please check CI
http://121.244.95.60:12545/job/ApacheCarbonPRBuilder2.3/4056/
CarbonDataQA1 commented on pull request #3911:
URL: https://github.com/apache/carbondata/pull/3911#issuecomment-691851314
Build Success with Spark 2.4.5, Please check CI
http://121.244.95.60:12545/job/ApacheCarbon_PR_Builder_2.4.5/2318/
CarbonDataQA1 commented on pull request #3871:
URL: https://github.com/apache/carbondata/pull/3871#issuecomment-691855754
Build Failed with Spark 2.3.4, Please check CI
http://121.244.95.60:12545/job/ApacheCarbonPRBuilder2.3/4057/
CarbonDataQA1 commented on pull request #3925:
URL: https://github.com/apache/carbondata/pull/3925#issuecomment-691857427
Can one of the admins verify this patch?
This is an automated message from the Apache Git Service.
To
su-article opened a new pull request #3925:
URL: https://github.com/apache/carbondata/pull/3925
### Why is this PR needed?
For data update, in the CarbonProjectForUpdateCommand process, after the
delete delta file is generated, the status of each segment is checked. If the
status is
CarbonDataQA1 commented on pull request #3871:
URL: https://github.com/apache/carbondata/pull/3871#issuecomment-691858887
Build Failed with Spark 2.4.5, Please check CI
http://121.244.95.60:12545/job/ApacheCarbon_PR_Builder_2.4.5/2319/
75 matches
Mail list logo
